Erik Sipsma3294 solomon4104 I believe | Dagger | Page 1

sly tusk Nov 4, 2022, 5:08 PM

#

Hey @marble gazelle I've been updating with the details of the implementation in my draft PR here: https://github.com/dagger/dagger/pull/3647

But there are still details being figured out 🙂 For instance there were a bunch of problems with the stdio conn approach that I finally got a solution to working (just barely enough) in Go. I'm about to go add another comment describing that and what we should do in the short+long term.

For what you need to do in the Python SDK:

The engine connection approach I mentioned above
The provisioner approach that I describe in the other comments

How about I just summarize all of that in one comment so you have a single place to look. I'll update you in a bit once I've written that. And if you want to chat live any time today please let me know, more than happy to.

mighty breach Nov 4, 2022, 5:12 PM

#

https://github.com/dagger/dagger/issues/3653

GitHub

Helper binary for SDKs · Issue #3653 · dagger/dagger

SDKs need a local binary to enable functionality like local dir sync that has not yet been implemented natively in each SDK language This is an internal-only need, users should not use it directly ...

#

isn’t that the place @sly tusk ?

#

I’d propose centralizing there

sly tusk Nov 4, 2022, 5:13 PM

#

That's the high level description of why. I thought Helder was asking for the lower level details of "what modifications are needed to the python SDK"

mighty breach Nov 4, 2022, 5:13 PM

#

ah

#

Maybe we could move it there, or at least link to it?

sly tusk Nov 4, 2022, 5:14 PM

#

Yeah that makes sense, it's all related to the helper binary, I will put my comment there instead.

marble gazelle Nov 4, 2022, 5:32 PM

#

I see in #3653 there's a milestone "Engine Release for GraphQL Launch". Is the sdk stuff a stopgap or is it the same "engine release" before the sdk launch?

mighty breach Nov 4, 2022, 5:35 PM

#

that wording is confusing

#

And yeah it should be a different milestone

#

one is more short term than the other

#

(although not by much)

mighty breach Nov 4, 2022, 5:37 PM

#

marble gazelle I see in #3653 there's a milestone "Engine Release for GraphQL Launch". Is the s...

what do you mean by "is the sdk stuff a stopgap"

marble gazelle Nov 4, 2022, 5:42 PM

#

If there's an engine release before graphql launch, that's after the python SDK launch. The stopgap would be the cp helper binary from OCI thing I guess. I know we plan on running the engine entirely in a container right? Is that milestone for that? It's confusing.

#

Is the helper binary going to be a thing even after that engine release?

mighty breach Nov 4, 2022, 5:45 PM

#

We can release at any time, with or without milestone. When preparing a launch (communication event with a date constraint) we need to track dependency on certain features being shipped. We use milestones to track these, since milestones are a common way to track releases anyway.

marble gazelle Nov 4, 2022, 5:46 PM

#

I know, just looking for what to track on the python milestone.

mighty breach Nov 4, 2022, 5:46 PM

#

If github supported sub-issues we could just use a parent issue to track dependencies for each launch. But milestone is the next best thing

marble gazelle Nov 4, 2022, 5:46 PM

#

As this is a dependency for it.

mighty breach Nov 4, 2022, 5:47 PM

#

Just add this issue to the python sdk 0.1 milestone, should solve your problem in your case I think?

marble gazelle Nov 4, 2022, 5:47 PM

#

Yes, but it'll remove it from the other, that's why I was asking to understand the scope.

mighty breach Nov 4, 2022, 5:47 PM

#

Basically organize the python milestone in any way is most efficient for you

#

Ah I see, only 1 milestone per issue?

marble gazelle Nov 4, 2022, 5:47 PM

#

Yep

mighty breach Nov 4, 2022, 5:47 PM

#

mmm

#

Yeah python sdk milestone is right

#

there is no CLI release actually

#

CLI = The Dagger CLI

#

which we don't need to release for the python sdk

#

so we're good

#

it shouldn't be in the other milestone to begin with

#

(that was ambiguous until recently - now we know we want to decouple)

#

sorry for the confusion

marble gazelle Nov 4, 2022, 5:49 PM

#

No prob

sly tusk Nov 4, 2022, 6:41 PM

#

@marble gazelle summarized what we need here: https://github.com/dagger/dagger/issues/3653#issuecomment-1303984783

My branch will need a few updates based on the final decisions we've made, so I'm gonna go do that quickly and get an image pushed somewhere for you to start testing against. Let me know if the meantime if you have any questions

#Erik Sipsma3294 solomon4104 I believe