0.14 Bevy Jam

[bitter sparrow]

maybe .editorconfig doesn't recognize that the file is json because of the lack of .json suffix

[slender belfry]

Ooooh right

[bitter sparrow]

my trailing newlines get deleted on save, idk why

[slender belfry]

cool beans

approved 👍

I was thinking about pausing and the settings menu recently

I think it makes sense to wait with those a while until the current code has been bikeshed

Because the template is in a really solid spot right now imo

what do you think?

[bitter sparrow]

yeah i agree, there's other stuff to work on before adding more code

would make refactors / bikeshedding take more work

cart and francois haven't reviewed the template yet so there may be more changes requested

[slender belfry]

I'm a bit burnt out on CI right now, but I'd love to get https://github.com/TheBevyFlock/bevy_quickstart/issues/200 in

Removing the permissions stuff from the guide would be cool

[bitter sparrow]

that and support for workspaces would be nice

[slender belfry]

Agreed

[bitter sparrow]

also i'd like to put all the images in the workflows doc behind details sections

so you can see the bigger picture at a glance

[slender belfry]

Good idea!

I'd also approve a PR for the debug UI. I've seen your post about toggling it at runtime and it seemed a bit convoluted, so I didn't try implementing it

[bitter sparrow]

ive got an implementation for it already

[slender belfry]

Ah, really?

[bitter sparrow]

https://github.com/benfrankel/bevy_jam_template/blob/main/src/core/debug/ui.rs

its pretty small

[slender belfry]

that's already it???

[bitter sparrow]

heh yeah that's all it takes

[slender belfry]

I thought it was way more convoluted 😄

[bitter sparrow]

well and adding the cargo feature in dev builds

i think it's just included in bevy/bevy_dev_tools though

[slender belfry]

We could add that right into /src/dev_tools.rs

[bitter sparrow]

yup

[slender belfry]

Since we lack the core mod

[bitter sparrow]

the more convoluted thing would be toggleable diagnostics logging: https://github.com/benfrankel/bevy_jam_template/blob/main/src/core/debug/diagnostics.rs

[slender belfry]

Oooooh so that's what I was reading

[bitter sparrow]

ah ic

also in this case it's toggled not by a key press, but by hot reloading a config file

with some bools in it

but in bevy_quickstart it would probably just share the F3 toggle key + some UI in the settings menu when that exists

[slender belfry]

for path in to_enable {
    c!(store.get_mut(&path)).is_enabled = true;
}

The absolute raw power of tiny_bail in action

[bitter sparrow]

yup, plus you get the information that this is expected to succeed, whereas cq would mean expected to fail

[slender belfry]

F keys are pretty bad to use on macBooks FYI

[bitter sparrow]

oh really

[slender belfry]

And some other laptops

[bitter sparrow]

what would be the alternative for a debug mode in those cases?

like, / maybe?

[slender belfry]

Yeah, I've got a touch bar where the F buttons would be. I can make it display F keys by holding the fn key on my keyboard

[bitter sparrow]

or backtick

[slender belfry]

Which works, but it's a bit meh

[bitter sparrow]

want to avoid using a keybind that the user may want for actual game stuff

[slender belfry]

Same for many laptops that have their F keys set to just change brightness etc. by default and require pressing a modifier

sec, my rats are eating something and I need to check what

[bitter sparrow]

np

[slender belfry]

fuckers ran away

[slender belfry]

Backtick is often used to enable dev consoles

so there is a precedent for using that for debug stuff

[bitter sparrow]

okay, should be good enough as long as it's defined in a single place so it's easy to change

[slender belfry]

👍

[bitter sparrow]

i'll make a quick pr cause this should be easy

[slender belfry]

Right there in the dev_tools.rs, I'd say

I would not start a keybinding abstraction or such

because the real answer is to just use LWIM

[bitter sparrow]

KeyCode::Backquote mm okay

yeah no i'm not even using LWIM for this in my template. cause it's just for debugging

[slender belfry]

Yeah, put that behind a constant in the same file and we're good

[slender belfry]

Fair enough

Until you want to debug while holding a controller, I guess

I think I've never gotten a full project working with controller anyways

But the newest LWIM release makes me hopeful

[bitter sparrow]

im glad my fix to LWIM is included

wrt disabling actions and just_pressed

[slender belfry]

I read that but didn't get it

[bitter sparrow]

it's so tricky. there are a lot of subtle bugs

[slender belfry]

what was that again?

[bitter sparrow]

if you have key A held down which is mapped to some action

then you enable the action (from disabled) while the key is still held down

it sends a just_pressed

even though the user didn't "just press" the action

they've been holding it down

so for example if a user cancels my text input state by pressing Escape, it will immediately trigger a pause game action when i re-enable that action because Escape is still pressed (unless the user managed to press Escape for exactly 1 frame)

[slender belfry]

So, the timeline is:

• Action disabled
• I press A
• I hold A
• I enable the action
• It sends just_pressed instead of pressed?

[bitter sparrow]

yes

[slender belfry]

Ooooh I see!

Great fix then 😄

[bitter sparrow]

even if you press A before the action is disabled, in which case you would get two just_presseds from one key press

or even more if for some reason the game keeps disabling / re-enabling that action :p

[slender belfry]

Can't have text input bugs when you don't have a text input

[bitter sparrow]

also true

[slender belfry]

This is great 😄

Where should we document this? Right in the readme?

[bitter sparrow]

https://github.com/TheBevyFlock/bevy_quickstart/pull/250

[bitter sparrow]

maybe where we mention dev_tools.rs in the project structure section

[slender belfry]

Good idea

Could you add that to the PR? Looks good otherwise

[bitter sparrow]

done

[slender belfry]

The way you wrote it kinda implies that the entire plugin, including transition logging will be toggled

But eh, it's fine

Approved

The code is simple enough for people to find out what it does 😄

[bitter sparrow]

yeah hard to be more specific

[bitter sparrow]

for now 😈

[slender belfry]

btw, don't forget to update cargo-generate after you merge a PR

[bitter sparrow]

right

[prisma delta]

Can you not automate that?

[bitter sparrow]

we should be able to, it just hasn't been done yet. there's an issue for it

what's your workflow for merging main into cargo-generate?

[slender belfry]

git switch cargo-generate
git pull
git merge origin/main
git push

[bitter sparrow]

ah ok

[slender belfry]

Yeah, I imagine a workflow that the cargo generate tool excludes for users should work. Even better if it created an issue on merge conflicts.

Ping @lunar sail @obsidian ravine in case any of you two feel like doing some easy workflow stuff 😛

[willow remnant]

Nice work doing this. I forgot to say I also added this myself during the jam so meant to suggest it. Backtick is a fine choice. I put mine under either Delete or Backspace (can’t remember which) and I put Inspector Egui on the other one. Works well on macOS at least.

[bitter sparrow]

in my own code i toggle the entire bevy_editor_pls window with F4 😄

by toggling the window entity's visibility

[slender belfry]

And you toggle the game with Alt F4

[bitter sparrow]

not on linux but true

for me it's actually caps lock + Q (or backspace)

[slender belfry]

Huh, that's pretty close to macOS, where it's Cmd + Q

[bitter sparrow]

yeah my caps lock is mapped to "super key" which is the "Windows logo key"

so basically the same thing

[slender belfry]

Aaah, that's cool 🙂

I imagine that's easier to access with the pinky?

[bitter sparrow]

yep it's super convenient. it's not just caps+Q, every alphabetical key does something different

window management stuff

the digit keys do something too actually

caps + enter opens a terminal window for example 😄

[obsidian ravine]

Oooo that looks fun

[bitter sparrow]

here's the issue for context: https://github.com/TheBevyFlock/bevy_quickstart/issues/129

[bitter sparrow]

workflow permissions before and after for the build job which requires Contents: write to upload a GitHub release
other jobs will have even further reduced permissions, plus users won't have to do the setup step of enabling write permissions repo-wide

tested in bevy_jam_template, works fine

[slender belfry]

oh that's great 😄

good job!

I suppose the whole itch.io shebang still works?

[bitter sparrow]

yup

the only thing that required any non-default permissions was the github release step

[bitter sparrow]

https://github.com/TheBevyFlock/bevy_quickstart/pull/252

i edited workflows.md a bit as well

i'm only seeing it rendered now though

hmmm markdown doesn't work inside <summary></summary>

[slender belfry]

Yeah, I noticed that as well

[bitter sparrow]

using HTML instead seems to work

[slender belfry]

Good job with the edits, it reads way nicer now!

[bitter sparrow]

this also avoids the error when you first create your itch page

if you don't set the type of project to HTML before you have a web build available, there will be no error

[slender belfry]

Yeah, that's smart 😄

[bitter sparrow]

ok im done making tiny edit commits lol

[slender belfry]

The one thing that reads a bit weird now is this

It's like "here's random env vars" and telling you you can edit them. But what are they? Why would you edit them?

Hmm, the old version was not much better

Fair enough then

Approved

Nice, I like how much simpler it is now.

[bitter sparrow]

yeah i guess so, all that info is in the comments

which you would have to expand to see

could write something like

[slender belfry]

Maybe something like "Your primary way of configuring the release workflow is through environment variables"

[bitter sparrow]

... contains a list of environment variables to configure the release workflow

or that

[slender belfry]

Yeah that's good too

Wanna do a quick follow-up or should I?

I'm a bit distracted by making sure my rats are not killing themselves while running around the living room

[bitter sparrow]

i'll do it rq. i'll make it a separate sentence, before the expandable section

[slender belfry]

(I swear they try their best)

[bitter sparrow]

the whole doc is so much smaller now that we can afford an extra line heh

[slender belfry]

It's really really clean now. Good work!

[bitter sparrow]

https://github.com/TheBevyFlock/bevy_quickstart/pull/253

[slender belfry]

@hollow bluff where did you get your button sounds from? I would love to use them in the template, but I cannot find them in your credits.
In case you made them yourself, are they CC0 or CC-BY?

[slender belfry]

https://github.com/TheBevyFlock/bevy_quickstart/pull/254

@bitter sparrow could you take a listen?

it's not perfect, but should at least be better

[bitter sparrow]

do you use the gh cli to check out a pr?

[slender belfry]

usually, yeah

[bitter sparrow]

sounds fine but it's quiet

[slender belfry]

That's pretty intentional

The sound as it was was too loud for repeated use

[bitter sparrow]

the previous sound was too harsh

also too loud but not really that loud

[slender belfry]

I wanna be careful here since I expect a lot of people to use the same sound effects again

So I think it's best to err on the side of a bit too quiet

[bitter sparrow]

if it's too quiet it sounds like a bug

[slender belfry]

Button hover doesn't really need a sound at all really, that's just a flourish

I can make the click sound louder, but hover gets annoying real fast

[bitter sparrow]

pitch randomization makes it less annoying

but that's a whole nother thing

[slender belfry]

That is completely true

Or have it semi-integrated with the background music

[bitter sparrow]

would be nice to be able to associate volume / pitch randomization interval / etc. metadata with the sfx file path

but we don't have a design for that rn

[slender belfry]

By using an instrument that also appears in the BGM with a high attack

[slender belfry]

yeah, that should be easy with the current design

But I wouldn't include it

[bitter sparrow]

would that be like

replacing Handle in the map with struct Sfx { handle, .. }?

it's interesting though, we have settings for images

setting the image filter mode

does audio not have something similar built in?

[slender belfry]

It's all getting reworked because audio has infamously very little built-in

So maybe, but I would not count on it

[slender belfry]

Yeah, or the hacky variant of just checking the path in the play function 😛

I'll replace the OnPress sound with something a bit louder and more distinct

[bitter sparrow]

ok

[slender belfry]

Could you check again?

I tried to go for something I wouldn't mind hearing in an ingame menu as well

It's also louder than before.

[bitter sparrow]

approved, it's an improvement over the current sfx

[bitter sparrow]

triggered 0.1.0 release instead of v0.1.0? :p

[slender belfry]

…yes 😅

Thx

[bitter sparrow]

you're not wrong about this. a lot of games kept the Escape -> return to title screen as well

i hit credits and hear the kevin macleod song every time it's so funny

[slender belfry]

Yeah, I got a real pavlovian response when I recently heard it in a YouTube video 😄

[slender belfry]

That one already killed my progress in one game accidentally haha

I think it’s nice that thanks to the template quite a few jam entries have a Bevy splash screen

[bitter sparrow]

yeah i like seeing the bevy branding, especially when they modify the logo somehow

whether that's allowed or not aside, it's cool

[sinful hull]

I wonder if the splash screen could be generalised a little to move through a vec of images? I did something like that for the jam but it was a bit hacky and had a warning I couldn't figure out.

But if you can add images by just adding something to a vec it's seems much more likely people will keep the bevy image

[slender belfry]

It's explicitly not allowed without cart's approval 😄

[slender belfry]

Could you elaborate on that? Like displaying multiple splashes after another?

[sinful hull]

yeah showing a sequence of images with fade in / out for each then transitioning to the title screen. And allowing users to add their own images by just appending a handle / path to the vec of "splash images"

[slender belfry]

Someone even modified the splash and changed the license text of the logo to say MIT 😄

Now that is cheeky

[sinful hull]

I hacked it together in the jam by adding a mut splash_screen: Local<u8>, to the check_splash_timer system and just showing one screen after another

[slender belfry]

That would be neat, but I doubt most people have an own splash

[sinful hull]

true. probably not for a game jam lol

[slender belfry]

Although some entries hacked in an Avian splash, which was cool

[slender belfry]

That's a decent implementation imo. You could also have a resource that is being drained. Not sure which variant is better.

[sinful hull]

yeah was just thinking about a resource. I'll have another go and submit a PR for discussion if I get something I'm happy with

[bitter sparrow]

an animation for the bevy splash would be cool too

like the one in that one video

[slender belfry]

Yeah, I love that one

[bitter sparrow]

found it https://youtu.be/8kLWBDbVP0I?feature=shared&t=237

[bitter sparrow]

https://github.com/TheBevyFlock/bevy_quickstart/pull/256

[lunar sail]

@bitter sparrow @obsidian ravine @prisma delta
I released a new version of cargo-cache with the latest fixes, v2 should pick it up automatically :)
(PS: Is there a better channel than this one to talk about cargo-cache development? 😅 )

[slender belfry]

I thought GitHub actions only worked via tags and didn’t really have a concept of "version" per se? Or does it actually resolve tags according to semver?

[lunar sail]

No, I just moved the v2 tag to the newest commit :P

[slender belfry]

Ah, I see 😄

Thanks for the fixes 🙂

[bitter sparrow]

btw this is relevant #ecs message

instead of registering the one-shot every time the button is spawned, we could have used a newtype MySystem(SystemId), then Local<MySystem> and impl FromWorld for MySystem to register the one-shot once

[slender belfry]

Huh, that's an interesting pattern, didn't know about that one. Thanks!

[slender belfry]

https://github.com/TheBevyFlock/bevy_quickstart/pull/259

got a trivial fix

[slender belfry]

@bitter sparrow ready again

[bitter sparrow]

putting JustifyContent::Center on the label to center it is whacky

it works because we spawn the label as a node with a text child

does it not get centered by ui_root already?

actually even the label node already has JustifyContent::Center. so i don't think that does anything

returning EntityCommands from label but it's pointing to the container entity and not the one with the Text component is weird

[slender belfry]

True

[slender belfry]

The container, but not the text inside

[slender belfry]

Try it, it actually does have an effect

[bitter sparrow]

for the text inside that should already be handled by the container's style

[slender belfry]

Yeah, but the container says to justify with flex start in that PR

[bitter sparrow]

looks centered to me?

[slender belfry]

That without the manual insert?

[bitter sparrow]

that's just main branch

[slender belfry]

Oh yeah, that works

The issue is on my PR

[bitter sparrow]

right

i didn't look at where we were removing center from

[slender belfry]

😄

I was considering adding a label_centered

or a centered container

[bitter sparrow]

yeah no this just needs a followup pr

the whole UI is borked

layout-wise

[slender belfry]

It's a bit whacky in places, agreed

What should I do in my PR?

[bitter sparrow]

i'll just approve it it's w/e

[slender belfry]

I'll see if I can improve it a bit

don't merge yet

[bitter sparrow]

awkward

[slender belfry]

why is this not a single thingy anyways?

[bitter sparrow]

there's no reason, it should be

[slender belfry]

Alright, alright, I'll merge it now 😄

[bitter sparrow]

no i already merged it before you said that i mean heh

[slender belfry]

ah, I see

hahahaha

alright, I'll refactor in a new branch

[bitter sparrow]

we need to pull in bevy-inspector-egui so we can do UI without dying

and then remove bevy-inspector-egui after

[slender belfry]

I'm not a UI person, so I'll just clean up some low-hanging fruits

[bitter sparrow]

okay, i'll make another pr after that then

honestly, it's probably faster to set up bevy-inspector-egui before working on a UI PR then remove it before submitting, than it would be to recompile 50 times

[slender belfry]

hold up

This does not accept BackgroundColor?

The heck

Or at least impl Into<BackgroundColor>

smells like bug

[bitter sparrow]

do you really want to do with_background_color(BackgroundColor(Color::foo))?

[slender belfry]

When that is in a constant, yes

[bitter sparrow]

have that as a Color in the constant

[slender belfry]

Yeah, but I imagine someone might want to have BackgroundColor as a constant for type safety

[bitter sparrow]

sure, it would be reasonable to support it, but in most code we probably should just be storing colors

[slender belfry]

Fair

[bitter sparrow]

another thing that's weird is with_text_justify(JustifyText::foo)

always feels wrong when i type that out

i think it's because it should be something like "with text justifytext"

because justifytext is a field of the text component, not a separate component

but nobody's gonna be confused by with_justify_text

[slender belfry]

https://github.com/TheBevyFlock/bevy_quickstart/pull/260

I had way more, like an fn width(&mut self, width: f32) and fn centered(&mut self) on widget

Which worked, but turned the UI code in the credits into spaghetti

didn't like it, so I reverted it

[bitter sparrow]

yeah i prefer to overwrite the Style wholesale for custom styling

also on the topic of Style, not suggesting this for bevy_quickstart but i have my own extension trait for it: https://github.com/benfrankel/bevy_jam_template/blob/main/src/theme/layout.rs

so i can do stuff like this:

commands.spawn(Style::COLUMN_MID.full_size().node("Title"));

which spawns a NodeBundle + Name component using that style

or for customization:

Style {
    margin: UiRect::vertical(VMin(9.0)),
    row_gap: Vw(2.5),
    ..Style::COLUMN_MID.full_width()
}

[slender belfry]

That's hot

[prisma delta]

Are y'all still able to post here?

[bitter sparrow]

test

[prisma delta]

Great

I tried marking it as "Closed"

[bitter sparrow]

#1034543904478998539 for bevy_quickstart 🥺

[prisma delta]

Yeah, let's do that 🙂

[bitter sparrow]

moving to #1271949921708146770

[obsidian ravine]

@bitter sparrow @slender belfry I'm beginning to work on automatic cargo-generate updates. Would you prefer using merge commits or rebasing off of main?

Rebasing is far cleaner, since it just shows the commits that actually make the branch different, but is less transparent than merge commits because it requires force pushing

[pure depot]

Pretty sure we dont allow glob paths in there

Though the snippet infra hasnt been touched again since its initial implementation so its rather lackluster (as evident by only support 3 kinds as well)

[gilded lance]

👀

Preparing for the next jam already?

[obsidian ravine]

Are we re-opening this channel for the 0.16 Bevy jam? (And if so, can a maintainer rename the thread? Thanks!)