How do you add ComputedVisiblityFlag to the type registery?

[devout adder]

I'm trying to make a general plugin for serializing/deserializing things, but when i try to add ComputedVisiblityFlag to the type registry:

use bevy::{prelude::*, core_pipeline::core_3d::Camera3dDepthTextureUsage, render::view::ComputedVisibilityFlags};

... in plugin block
app.register_type::<ComputedVisibilityFlags>()

I get the error:

struct `ComputedVisibilityFlags` is private
private struct

bitflags::bitflags! {
    #[derive(Clone, Debug, Eq, PartialEq)]
    pub(super) struct ComputedVisibilityFlags: u8 {
        const VISIBLE_IN_VIEW = 1 << 0;
        const VISIBLE_IN_HIERARCHY = 1 << 1;
    }
}
bevy_reflect::impl_reflect_value!((in bevy_render::view) ComputedVisibilityFlags);

/// Algorithmically-computed indication of whether an entity is visible and should be extracted for rendering
#[derive(Component, Clone, Reflect, Debug, Eq, PartialEq)]
#[reflect(Component, Default)]
pub struct ComputedVisibility {
    flags: ComputedVisibilityFlags,
}

How do you add ComputedVisiblityFlag to the type registery?

[night tapir]

Are you sure that you are supposed to use this struct? Seens like its private. Though I don't know if you need to have The type to add to type_registry

[devout adder]

I need to add this struct to the type registry in order to serialize ComputedVisiblity, which every entity which renders something requires.

[hollow berry]

Please don't serialize that type. It's a temporary value created every frame, it's not meant to be persisted.

[devout adder]

I'm fine with it being overwritten after entities are serialized/deserialized when render checks are made, but If this can't serialize/deserialize, then the entity you try to deserialize won't render when its loaded

adding a system to manually query every entity to see if its missing it every update frame so it can add a dummy value seems needlessly expensive though

[night tapir]

Why will it not render? Dont you Just need to spawn with The bundles? Or is this something more specific?

[devout adder]

Im using moonshine saves, which serializes things by grabbing every entity and their component in the type registry into a .ron file, then deserializing that world back into the bevy world

the only component stopping that from wokring as expected, is ComputedVisiblityFlag, which is private. it implements reflect, but I can't access it to add it to the type_registry

[trim pond]

Please don't serialize that type. It's a temporary value created every frame, it's not meant to be persisted.

I don't think that's right -- it's updated every frame, but bevy assumes / relies on its existence.

[topaz loom]

You shouldn't need to manually add it, Visibility and ComputedVisibility should be all that's needed, as that's what you normally add in a SpriteBundle for example

[devout adder]

In order to a serialize a component, all parts of a component need to a part of the type registry. ComputedVisibility may be in the type registry, but its attribute, ComputedVisibilityFlag, isn't, and so, ComputedVisiblity cant be serialized.

[trim pond]

ComputedVisiblity was split into two components in 0.12-dev. Probably worth checking to see if this works there. I think you'll have to find a workaround in the meantime.

[devout adder]

i did, I decided to make a system that runs after my deserialization system to manually add ComputedVisibility to every entity

[trim pond]

gross, but yay 🙂

was going to suggest something similar.

[topaz loom]

Yeah you should anyway just have a system that's adds Visibility, ComputedVisibility, and GlobalTransform to your things that have sprites

You should look up the blueprint pattern in bevy_replicon's docs

Here's an easy link: https://docs.rs/bevy_replicon/latest/bevy_replicon/#blueprints-pattern