Need help with reflection and spigot and addons | SpigotMC | Page 1

rotund hearth Jul 6, 2022, 6:18 PM

#

hey so heres my code for the addon

package org.cloud.addon;

import org.eternitystudios.plugins.cloud.Cloud;

public class Addon {

    Cloud instance;

    public Addon(Cloud instance) {
        this.instance = instance;
    }

    public void addonMain() {
        instance.server
    }
}

#

And heres the addonmanager class ```java
package org.eternitystudios.plugins.cloud.utils;

public class AddonManager {

Cloud instance;

public AddonManager(Cloud instance) {
    this.instance = instance;
}

public void registerAddons() {
    File [] files = instance.af.listFiles();
    for (File file : files) {
        if (file.isFile()) { // this line weeds out other directories/folders
            if (file.getName().endsWith(".jar")) {
                registerJAR(file);
            }
        }
    }
}

public void registerJAR(File jar) {
    try {

        URLClassLoader loader = new URLClassLoader(new URL[] { jar.toURI().toURL() },
                Cloud.class.getClassLoader());

        Class classToLoad = Class.forName("org.cloud.addon.Addon", true, loader);

        System.out.println(classToLoad);
        Class<?>[] type = {Cloud.class};
        Object instance = classToLoad.newInstance();
        Constructor<?> cons = classToLoad.getConstructor(type);
        Object newInstanceObj = cons.newInstance(instance);
        Method method = classToLoad.getDeclaredMethod("addonMain");
        Object result = method.invoke(instance);

    } catch (MalformedURLException | ClassNotFoundException | NoSuchMethodException | SecurityException
             | InstantiationException | IllegalAccessException | IllegalArgumentException
             | InvocationTargetException e) {
        // TODO Auto-generated catch block
        if (instance.getConfig().getBoolean("debugMode")) e.printStackTrace();
        Bukkit.getLogger().warning("Could not load addon " + jar.getName());
    }
}

}

#

package org.eternitystudios.plugins.cloud;

import org.bukkit.Server;
import org.bukkit.plugin.java.JavaPlugin;
import org.eternitystudios.plugins.cloud.utils.AddonManager;

import java.io.File;

public final class Cloud extends JavaPlugin {

    public File af;
    public AddonManager addonManager;
    public Server server;

    public Cloud() {
    }

    @Override
    public void onEnable() {
        // Set server
        server = getServer();

        // Save config
        saveDefaultConfig();

        // Instantiate addonManager
        addonManager = new AddonManager(this);

        // Save addons folder if It's not there.
        String configPath = getDataFolder().getAbsolutePath();
        File addonFolder = new File(configPath);
        af = addonFolder;
        if (!addonFolder.exists()) addonFolder.mkdir();

        // Start searching for addons
        addonManager.registerAddons();
    }





    @Override
    public void onDisable() {
        // Plugin shutdown logic
    }
}
``` this is the main plugin

#

on the addon, i cant access any of the server functions, how can i fix this?

#

im using the server var on the instance

rapid pendant Jul 6, 2022, 6:19 PM

#

rotund hearth on the addon, i cant access any of the server functions, how can i fix this?

What happens when you try

rotund hearth Jul 6, 2022, 6:19 PM

#

rapid pendant What happens when you try

look

rapid pendant Jul 6, 2022, 6:19 PM

#

Also use a paste site

rotund hearth Jul 6, 2022, 6:19 PM

#

okay

#

the server var is not a variable

#

@rapid pendant

rapid pendant Jul 6, 2022, 6:21 PM

#

So uh why do you need that

#

Just use Bukkit#<what you need>

rotund hearth Jul 6, 2022, 6:22 PM

#

its not a javaplugin tho

#

its another class

#

that im loading using reflection

oblique pilot Jul 6, 2022, 6:22 PM

#

your constructor is wonky
'''java
public Addon(Cloud instance) {
this.instance = instance;
}
'''

rotund hearth Jul 6, 2022, 6:22 PM

#

oblique pilot your constructor is wonky '''java public Addon(Cloud instance) { this.in...

it should work tho

oblique pilot Jul 6, 2022, 6:23 PM

#

you need to get the plugin somehow

rotund hearth Jul 6, 2022, 6:23 PM

#

ye

oblique pilot Jul 6, 2022, 6:23 PM

#

you are just doing a weird way of setting it to itself, or null;

#

so all your server functions are null

rotund hearth Jul 6, 2022, 6:23 PM

#

https://paste.md-5.net/uhoqapumer.cs

#

heres the addonmanager

#

thats doing the reflection if that can help me figure it out

#

@oblique pilot

oblique pilot Jul 6, 2022, 6:25 PM

#

what I do is use a singleton in the main class

rotund hearth Jul 6, 2022, 6:25 PM

#

oblique pilot what I do is use a singleton in the main class

its different tho

#

the addon is a whole different jar

oblique pilot Jul 6, 2022, 6:25 PM

#

thats a public static reference to Main accessable from main

rotund hearth Jul 6, 2022, 6:25 PM

#

and the instance is being feeded through reflection

oblique pilot Jul 6, 2022, 6:26 PM

#

I'm doing a terrible job explaining

rotund hearth Jul 6, 2022, 6:26 PM

#

i can try that tho

oblique pilot Jul 6, 2022, 6:26 PM

#

ill find the function

rotund hearth Jul 6, 2022, 6:26 PM

#

okay

oblique pilot Jul 6, 2022, 6:30 PM

#

how do I get the code blocks in discord?

#

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/plugin/java/JavaPlugin.html#getPlugin(java.lang.Class)

Cloud instance;

public Addon(Cloud instance) {
    this.instance = JavaPlugin.getPlugin(Cloud.class);
}

JavaPlugin (Spigot-API 1.19-R0.1-SNAPSHOT API)

declaration: package: org.bukkit.plugin.java, class: JavaPlugin

#

you just never initialize instance properly, all the other code I see as unaffected

rotund hearth Jul 6, 2022, 6:31 PM

#

thing is

#

i dont have javaplugin

#

spigot isnt added in the addon

#

and i dont know if it can be

rapid pendant Jul 6, 2022, 6:33 PM

#

?

#

Just do what ForbiddenSoul said

rotund hearth Jul 6, 2022, 6:34 PM

#

@oblique pilotokay

#

so now im getting an instantsionerror

rapid pendant Jul 6, 2022, 6:34 PM

#

I was expecting that

#

You're trying to access the no args constructor which doesn't exist

rotund hearth Jul 6, 2022, 6:36 PM

#

oh, i needa no args constructer?

rapid pendant Jul 6, 2022, 6:36 PM

#

No you should just use the one you created

rotund hearth Jul 6, 2022, 6:36 PM

#

wdym

rapid pendant Jul 6, 2022, 6:36 PM

#

And not use the no args one

rotund hearth Jul 6, 2022, 6:37 PM

#

@rapid pendantwdym

#

did i just fix it lol

oblique pilot Jul 6, 2022, 6:41 PM

#

In my main class I just make a public static JavaPlugin plugin.

In onEneable you set plugin = this

Then in any addon code you can statically call

Cloud.plugin.serverFunctionYouWant

#

Cloud.plugin.getServer()... actually

rapid pendant Jul 6, 2022, 6:42 PM

#

If you're going to do that at least use a getInstance method

#

Anyways di is the best approach

rotund hearth Jul 6, 2022, 6:42 PM

#

okay

oblique pilot Jul 6, 2022, 6:42 PM

#

https://www.spigotmc.org/threads/beginner-programming-mistakes-and-why-youre-making-them.278876/

1.1 Singletons

rotund hearth Jul 6, 2022, 6:42 PM

#

ive used singletons before

#

and i was

#

im not a beginner

#

it just wasnt working for me

oblique pilot Jul 6, 2022, 6:43 PM

#

I realize, but you missed initializing a varibale

rotund hearth Jul 6, 2022, 6:43 PM

#

but javaplugin prob will

oblique pilot Jul 6, 2022, 6:43 PM

#

then when you call varible.function, the functions are not working

rotund hearth Jul 6, 2022, 6:44 PM

#

hopefully that will work

#

@oblique pilotproblem

#

javaplugin isnt a thing in the addon

#

cause it not exactly using spigot

rapid pendant Jul 6, 2022, 6:47 PM

#

Your plugin instance is the JavaPlugin

rotund hearth Jul 6, 2022, 6:47 PM

#

rapid pendant Your plugin instance is the JavaPlugin

yeah ik

#

package org.cloud.addon;

import org.eternitystudios.plugins.cloud.Cloud;

public class Addon {

    JavaPlugin instance;

    public Addon(JavaPlugin instance) {
        this.instance = instance;
    }


    public void addonMain() {

    }
}
``` in the addon project

#

javaplugin is not a class

rapid pendant Jul 6, 2022, 6:48 PM

#

Import spigot to your project

rotund hearth Jul 6, 2022, 6:48 PM

#

i dont know where to download the jar to add as libary

#

library

rapid pendant Jul 6, 2022, 6:49 PM

#

Use maven or gradle

#

Adding jars directly is a bad idea

rotund hearth Jul 6, 2022, 6:49 PM

#

too late for that

rapid pendant Jul 6, 2022, 6:49 PM

#

You can always migrate your project

rotund hearth Jul 6, 2022, 6:50 PM

#

in intelji? how?

rapid pendant Jul 6, 2022, 6:51 PM

#

I'd create a new project and move everything over

#Need help with reflection and spigot and addons