map doesnt contain itemstacks even i added them | SpigotMC | Page 1

red glade May 28, 2022, 6:32 PM

#

Map<Integer, ItemStack> newSort = new HashMap<Integer, ItemStack>();

@Override
    public boolean onCommand(CommandSender s, Command c, String l, String[] args) {
        Player player = (Player) s;
        KitManager.givePlayerKit(player, KitManager.getKit("tank"));
        player.sendMessage("Sort test");
        
        for(int i = 0; i < p.getInventory().size(); i++) {
            newSort.put(i, player.getInventory().getItem(i));
        }
        
        return false;
    }
    @EventHandler
    void onChat(PlayerChatEvent e) throws IOException {
        System.out.println(newSort);
        
        KitManager.givePlayerKitWithCustomSort(e.getPlayer(), KitManager.getKit("tank"));
        Main.yamlConfiguration.set(e.getPlayer().getName()+ "tankkit", newSort);
        Main.yamlConfiguration.save(Main.file);
    }``` it doesnt register the itemstacks idk why

little geyser May 28, 2022, 6:34 PM

#

In that for loop, check to make sure that the item you are getting isn't null or of type air. Then put a clone of that item into the hashmap.

red glade May 28, 2022, 6:38 PM

#

still doesnt work

little geyser May 28, 2022, 6:41 PM

#

Where is newSort being defined?

red glade May 28, 2022, 6:42 PM

#

before the on command method

little geyser May 28, 2022, 6:43 PM

#

Does givePlayerKit clear the player's inventory?

red glade May 28, 2022, 6:44 PM

#

no i tried to clear the inventory too but doesnt work

little geyser May 28, 2022, 6:48 PM

#

After the for loop, can you make sure that newSort's size is the amount of items that you wanted to add by printing it? Then in PlayerChatEvent print out the size of newSort at that point.

red glade May 28, 2022, 6:50 PM

#

wait i noticed that the for loop doesnt get played

little geyser May 28, 2022, 6:52 PM

#

For that p.getInventory().size(), shouldn't it be p.getInventory().getSize()?

red glade May 28, 2022, 6:52 PM

#

yea i just noticed it, but it still just skips the for loop

little geyser May 28, 2022, 6:53 PM

#

So if you put print statements inside of the for loop, it wouldn't print?

red glade May 28, 2022, 6:54 PM

#

yes, idk why bukkit just skips these for me

little geyser May 28, 2022, 6:55 PM

#

Is it printing out "Sort test" beforehand?

red glade May 28, 2022, 6:56 PM

#

yes it does

#

if i put the for loop in a seperate method it runs

little geyser May 28, 2022, 6:59 PM

#

Try printing out the size of the player's inventory inside of the onCommand method.

red glade May 28, 2022, 7:01 PM

#

it works perfectly fine

little geyser May 28, 2022, 7:03 PM

#

If you make another loop inside of that method that just does a print, does it work? Put it before the other for loop

red glade May 28, 2022, 7:10 PM

#

yes a simple loop like this

    System.out.println("ASD");``` just works completly fine

#

now the other loop works too, but it doesnt add it to the map

little geyser May 28, 2022, 7:12 PM

#

Where is the newSort map being created?

red glade May 28, 2022, 7:12 PM

#


    @Override
    public boolean onCommand(CommandSender s, Command c, String l, String[] args) {```
before the oncommand method

little geyser May 28, 2022, 7:13 PM

#

Just to make sure, after that loop that's supposed to add the items to the hashmap, if you did a print immediately after that does newSort.size() it would return 0?

red glade May 28, 2022, 7:15 PM

#

it returns 36

little geyser May 28, 2022, 7:16 PM

#

Ok, Instead of doing PlayerChatEvent, try doing something like EntityDamageEvent, check to make sure it's a player, and then run the code.

red glade May 28, 2022, 7:19 PM

#

still doesnt work

little geyser May 28, 2022, 7:21 PM

#

Can you post the code you have now?

red glade May 28, 2022, 7:23 PM

#

    @EventHandler
    void onChat(EntityDamageEvent e) throws IOException {
        System.out.println(newSort);

        if(e.getEntity() instanceof Player) {
            Player player = (Player) e.getEntity();
            KitManager.givePlayerKitWithCustomSort(player, KitManager.getKit("tank"));
        Main.yamlConfiguration.set(player.getName() + "tankkit", newSort);
        Main.yamlConfiguration.save(Main.file);
        }
        
        
    }```

little geyser May 28, 2022, 7:23 PM

#

Instead of just printing newSort, try printing newSort.size(). Is that 0?

red glade May 28, 2022, 7:24 PM

#

no its 9

little geyser May 28, 2022, 7:25 PM

#

Does anything happen in between that modifies newSort?

red glade May 28, 2022, 7:29 PM

#

no its just ends the method

#

after that is just the end

little geyser May 28, 2022, 7:29 PM

#

Can you show what you have for onCommand?

red glade May 28, 2022, 7:29 PM

#

 Map<Integer, ItemStack> newSort = new HashMap<Integer, ItemStack>();

    @Override
    public boolean onCommand(CommandSender s, Command c, String l, String[] args) {
        Player player = (Player) s;
        player.getInventory().clear();

        KitManager.givePlayerKit(player, KitManager.getKit("tank"));
        player.sendMessage("Sort test");

        for (int i = 0; i < player.getInventory().getSize(); i++) {
            if(player.getInventory().getItem(i) != null) {
                newSort.put(i, player.getInventory().getItem(i));
                System.out.println(newSort.size());
            }
        }
        
        
        return false;
    }```

little geyser May 28, 2022, 7:31 PM

#

for (int i = 0; i < player.getInventory().getSize(); i++) {
ItemStack item = player.getInventory().getItem(i);
if(item == null || item.getType() == Material.AIR)
{
continue;
}
newSort.put(i, item.clone());
}

#

Sorry, not 100% sure on how to post it with the code style

red glade May 28, 2022, 7:32 PM

#

just three `java code then again the thing

little geyser May 28, 2022, 7:33 PM

#

            ItemStack item = player.getInventory().getItem(i);
            if(item == null || item.getType() == Material.AIR)
            {
                continue;
            }
            newSort.put(i, item.clone());
        }```

#

ah, got it

red glade May 28, 2022, 7:34 PM

#

still nothubng

little geyser May 28, 2022, 7:34 PM

#

For this loop it will likely make it so that newSort no longer has a size of 36 since it'll skip the items that are null or air. Inside of that entitydamageevent, print out all of the items and make sure they are the right ones instead.

red glade May 28, 2022, 7:36 PM

#

little geyser For this loop it will likely make it so that newSort no longer has a size of 36 ...

im trying to print what the map contains but it always says there is nothing in the map

little geyser May 28, 2022, 7:36 PM

#

Show the code

red glade May 28, 2022, 7:37 PM

#

i changed back to the player chat event because in entitydamage event it said the same

 Map<Integer, ItemStack> newSort = new HashMap<Integer, ItemStack>();

    @Override
    public boolean onCommand(CommandSender s, Command c, String l, String[] args) {
        Player player = (Player) s;
        player.getInventory().clear();

        KitManager.givePlayerKit(player, KitManager.getKit("tank"));
        player.sendMessage("Sort test");

        for (int i = 0; i < player.getInventory().getSize(); i++) {
            ItemStack item = player.getInventory().getItem(i);
            if (item == null || item.getType() == Material.AIR) {
                continue;
            }
            newSort.put(i, item.clone());
        }
        return false;
    }

    @EventHandler
    void onChat(PlayerChatEvent e) throws IOException {
        System.out.println(newSort);

        KitManager.givePlayerKitWithCustomSort(e.getPlayer(), KitManager.getKit("tank"));
        Main.yamlConfiguration.set(e.getPlayer().getName() + "tankkit", newSort);
        Main.yamlConfiguration.save(Main.file);

    }```

little geyser May 28, 2022, 7:38 PM

#

Instead of just doing println(newSort), try this instead.

for(int slot : newSort.keySet())
{
    ItemStack item = newSort.get(slot);
    Bukkit.getLogger().info("Slot: " + slot + " ItemType: " + item.getType());
}

red glade May 28, 2022, 7:43 PM

#

doesnt send anything in tzhe console

little geyser May 28, 2022, 7:44 PM

#

Try changing back to the EntityDamageEvent

red glade May 28, 2022, 7:46 PM

#

doesnt do anything

little geyser May 28, 2022, 7:46 PM

#

If you just print something, like "Test", does it output that to the console?

red glade May 28, 2022, 7:47 PM

#

yes

little geyser May 28, 2022, 7:50 PM

#

In the damageevent comment out the line including, and everything after KitManager. In the onCommand, comment out the givePlayerKit.

#

Wait I just realized, you cleared the inventory in your onCommand

#

comment out that line

red glade May 28, 2022, 7:55 PM

#

i already did it

little geyser May 28, 2022, 7:55 PM

#

What code do you have now?

red glade May 28, 2022, 8:01 PM

#

Map<Integer, ItemStack> newSort = new HashMap<Integer, ItemStack>();

    @Override
    public boolean onCommand(CommandSender s, Command c, String l, String[] args) {
        Player player = (Player) s;
        player.getInventory().clear();

        KitManager.givePlayerKit(player, KitManager.getKit("tank"));
        player.sendMessage("Sort test");

        for (int i = 0; i < player.getInventory().getSize(); i++) {
            ItemStack item = player.getInventory().getItem(i);
            if (item == null || item.getType() == Material.AIR) {
                continue;
            }
            newSort.put(i, item.clone());
        }
        
        return false;
    }

    @EventHandler
    void onChat(PlayerChatEvent e) throws IOException {
        for(int slot : newSort.keySet())
        {
            ItemStack item = newSort.get(slot);
            Bukkit.getLogger().info("test");
        }
        //e.getPlayer().getInventory().clear();
        KitManager.givePlayerKitWithCustomSort(e.getPlayer(), KitManager.getKit("tank"));
        Main.yamlConfiguration.set(e.getPlayer().getName() + "tankkit", newSort);
        Main.yamlConfiguration.save(Main.file);

    }```

little geyser May 28, 2022, 8:02 PM

#

remove player.getInventory().clear(); in the onCommand

red glade May 28, 2022, 8:03 PM

#

doesnt work

#

still empty

little geyser May 28, 2022, 8:05 PM

#

@Override
    public boolean onCommand(CommandSender s, Command c, String l, String[] args) {
        Player player = (Player) s;
      
        for (int i = 0; i < player.getInventory().getSize(); i++) {
            ItemStack item = player.getInventory().getItem(i);
            if (item == null || item.getType() == Material.AIR) {
                continue;
            }
            newSort.put(i, item.clone());
        }
        
        return true;
    }

    @EventHandler
    void onChat(PlayerChatEvent e) throws IOException {
        for(int slot : newSort.keySet())
        {
            ItemStack item = newSort.get(slot);
            Bukkit.getLogger().info("Slot: " + slot);
            Bukkit.getLogger().info("Type: " + item.getType());
            Bukkit.getLogger().info("test");
        }
    }
``` If you run just this, does it work?

red glade May 28, 2022, 8:07 PM

#

no it prints empty lines

little geyser May 28, 2022, 8:07 PM

#

Can you show what it's outputting?

red glade May 29, 2022, 7:51 AM

#


>```

#

only this

#map doesnt contain itemstacks even i added them