apply NBT tag to item only while in specific slot | SpigotMC | Page 1

honest fern Mar 1, 2022, 5:40 PM

#

Hi, I'm trying to solve this problem:

I'd like to set NBT data on an item when it is placed in a specific inventory slot, and remove it if it's it's not in that slot. I had thought about getting InventoryClick events and using that to tell if a player is putting an item in a specific slot, but I realised that the item will still have the custom NBT if the player were to drop it or drop it on death. What approach can I use for this problem?

gloomy crown Mar 1, 2022, 5:42 PM

#

use a PlayerDeathEvent to get the item from the inventory and remove the nbt data

honest fern Mar 1, 2022, 5:43 PM

#

ok, another question: The item slot I'm trying to detect items in is the helmet slot, I couldn't find any events specific to armour slots, are there any I missed?

#

also, I was planning on removing the NBT data by testing if a player had removed the item from the helmet slot, and then removing the NBT data from the item in the cursor. I realised that the player may just press Q on the helmet, or shift click it out of the slot, which would mean I couldn't then test for the cursor item

#

I do not want to iterate through all items in a player's inventory just to remove NBT data from a single item

gloomy crown Mar 1, 2022, 5:44 PM

#

The PlayerInteractEvent can be used to detect a right click

#

and the InventoryClickEvent can also be used to detect when they put the helmet in the helmet slot

gloomy crown Mar 1, 2022, 5:45 PM

#

gloomy crown The `PlayerInteractEvent` can be used to detect a right click

this event will fire when the player right clicks the helmet to put it on

honest fern Mar 1, 2022, 5:45 PM

#

Okay

#

My main issue is with removing the NBT data though

#

since there are many more ways of removing an item than equipping a helmet

gloomy crown Mar 1, 2022, 5:45 PM

#

honest fern also, I was planning on removing the NBT data by testing if a player had removed...

use the InventoryClickEvent to test if the helmet slot is air

#

pressing q in the helmet also triggers the InventoryClickEvent iirc

honest fern Mar 1, 2022, 5:46 PM

#

Oh excellent

#

how can I detect if the player drops an item on death though? is there any way to access the player's inventory before they drop all their items?

gloomy crown Mar 1, 2022, 5:47 PM

#

honest fern how can I detect if the player drops an item on death though? is there any way t...

PlayerDeathEvent will fire just before a death

honest fern Mar 1, 2022, 5:47 PM

#

brilliant

#

So I can detect the inventory click for when a player drops an item and when they shift-click it out of their helmet slot, but how do I then find that item so that I can remove the NBT data?

#

do i have to iterate through the inventory? and how would I get the dropped item?

#

does inventoryclick fire before the item is dropped?

gloomy crown Mar 1, 2022, 5:48 PM

#

honest fern So I can detect the inventory click for when a player drops an item and when the...

iterate through the inventory and check if the item has your nbt data

gloomy crown Mar 1, 2022, 5:48 PM

#

honest fern does inventoryclick fire before the item is dropped?

yes

honest fern Mar 1, 2022, 5:48 PM

#

oh buoy

gloomy crown Mar 1, 2022, 5:49 PM

#

all events fire 1 tick before it happens

#

so you can cancel them

honest fern Mar 1, 2022, 5:49 PM

#

wouldn't running ~30 ifs per inventory click event slow things down a bit?

#

I don't know much about plugin performance

gloomy crown Mar 1, 2022, 5:49 PM

#

the event should give you which item was clicked

#

just check if that clicked item is your item

honest fern Mar 1, 2022, 5:50 PM

#

so i can get the item even before it moves slot with shift-click?

gloomy crown Mar 1, 2022, 5:50 PM

#

yes

#

you can also get which slot it will shift click to

honest fern Mar 1, 2022, 5:50 PM

#

Pizza Guy you have been the most helpful discord user I've ever met in any programming server

gloomy crown Mar 1, 2022, 5:50 PM

#

:)

honest fern Mar 1, 2022, 5:51 PM

#

that should be all my questions for now, will this thread close itself or can I leave this here?

#

so i can reference it later

gloomy crown Mar 1, 2022, 5:51 PM

#

it should archive, but not delete

honest fern Mar 1, 2022, 5:51 PM

#

good

gloomy crown Mar 1, 2022, 5:51 PM

#

good luck with your plugin

honest fern Mar 1, 2022, 5:51 PM

#

thank you :)

honest fern Mar 1, 2022, 6:16 PM

#

i have another question, what is NMS? When I've searched how to edit NBT data, all examples have a line where they convert an ItemStack into a NMS itemstack, why is this required/what can you do with a NMS itemstack that you can't with a bukkit one?

gloomy crown Mar 1, 2022, 6:27 PM

#

honest fern i have another question, what is NMS? When I've searched how to edit NBT data, a...

nms stands for Net Minecraft Server and is the raw obfuscated code of the server

#

you can edit the NBT data with UnsafeValues, without the need of nms

#

UnsafeValues is unsafe because it edits the raw nbt of an item, but you can use it to edit nbt

honest fern Mar 1, 2022, 6:28 PM

#

what is best practice

#

or most common

gloomy crown Mar 1, 2022, 6:28 PM

#

UnsafeValues

honest fern Mar 1, 2022, 6:28 PM

#

oh great

gloomy crown Mar 1, 2022, 6:28 PM

#

if you need to do really complicated NBT things, you can touch on nms, but its very confusing and complicated

honest fern Mar 1, 2022, 6:28 PM

#

but what happens if you do something unsafe? does the server crash?

gloomy crown Mar 1, 2022, 6:28 PM

#

it cant crash from UnsafeValues

#

the name only means that if you did something wrong, the item would get corrupted

honest fern Mar 1, 2022, 6:29 PM

#

ok

#

is the data in {} in this command NBT data? /give @p lantern{CustomModelData:400000} just to make sure

gloomy crown Mar 1, 2022, 6:30 PM

#

oh

#

are you editing custom model data?

honest fern Mar 1, 2022, 6:30 PM

#

?

#

Yes

#

Well

gloomy crown Mar 1, 2022, 6:30 PM

#

customModelData is in the API

#

you dont need to edit nbt

honest fern Mar 1, 2022, 6:30 PM

#

I'm not editing, there is a resource pack which has customModelData for certain NBT data

#

huh??

#

so I don't even need a resource pack?

#

or will I still

gloomy crown Mar 1, 2022, 6:31 PM

#

wait, do you understand how custommodeldata works?

honest fern Mar 1, 2022, 6:31 PM

#

as far as I'm aware, a resource pack can apply a custom model to an item with certain NBT data, and one NBT tag you can use specifically for this purpose is the CustomModelData tag

#

so I've made a resource pack which will apply a certain model to a lantern with customModelData value 400,000

#

it works

#

But if there is a more intentional and streamlined way of doing this without any resource pack I'd love to learn about it

gloomy crown Mar 1, 2022, 6:33 PM

#

this is the correct way to do it

#

if your trying to remove and add the custommodeldata of an item, you dont need to mess with the raw nbt

#

spigotapi has methods for this

honest fern Mar 1, 2022, 6:34 PM

#

setCustomModelData(Integer data)

#

is this basically just a function which does what I'm trying to do manually with NBT?

gloomy crown Mar 1, 2022, 6:34 PM

#

ItemStack#getItemMeta().setCustomModelData()

#

yes

honest fern Mar 1, 2022, 6:34 PM

#

that's nice

gloomy crown Mar 1, 2022, 6:34 PM

#

theres also ItemStack#getItemMeta().getCustomModelData() and ItemStack#getItemMeta().hasCustomModelData()

honest fern Mar 1, 2022, 6:35 PM

#

saves me learning that NMS and unsafe stuff

gloomy crown Mar 1, 2022, 6:35 PM

#

:)

honest fern Mar 1, 2022, 6:35 PM

#

so I will still require the resource pack though

gloomy crown Mar 1, 2022, 6:35 PM

#

yes

honest fern Mar 1, 2022, 6:35 PM

#

that's not an issue

#

ok

gloomy crown Mar 1, 2022, 6:35 PM

#

it needs somewhere to get the texture

honest fern Mar 1, 2022, 6:35 PM

#

thank you :)

gloomy crown Mar 1, 2022, 6:35 PM

#

you can actually tell the server to recommend installing a texture pack to a user

honest fern Mar 1, 2022, 6:35 PM

#

yes I think you can even make it mandatory

honest fern Mar 1, 2022, 6:49 PM

#

gloomy crown you can also get which slot it will shift click to

I've looked for this but I can only find people saying this can't be done?

#

on an inventory click I'm trying to get the slot the item was clicked into, is the only way to do this with InventoryDrag

gloomy crown Mar 1, 2022, 6:53 PM

#

im pretty sure shiftclick sends two events

#

one for picking it up and one for placing it down

honest fern Mar 1, 2022, 6:54 PM

#

?

gloomy crown Mar 1, 2022, 6:54 PM

#

when you shiftclick on your client

#

what it really does

#

is the game quickly picks up the item

#

and quickly places it down in another slot

#

2 events

honest fern Mar 1, 2022, 6:55 PM

#

ok, what about for regular click though

#

like I've clicked an item into my cursor, and now I'm clicking that item into a slot

#

how do I get that slot number

gloomy crown Mar 1, 2022, 6:56 PM

#

InventoryClickEvent#getSlot() should return the numerical id of the slot

#

slot 1 being 0

honest fern Mar 1, 2022, 6:56 PM

#

so that won't return that the item slot was the cursor?

gloomy crown Mar 1, 2022, 6:56 PM

#

#

it returns one of these

honest fern Mar 1, 2022, 6:57 PM

#

oh thanks for that image, google told me the helmet slot was 5???

gloomy crown Mar 1, 2022, 6:57 PM

#

hm

honest fern Mar 1, 2022, 6:57 PM

#

hold on I will test and see if it returns the slot number i click it into

#

yay it gives the index i want :)

#

!! head item slot is #39

#

not 103

gloomy crown Mar 1, 2022, 7:10 PM

#

:)

#

i guess the slots change every update

honest fern Mar 1, 2022, 7:11 PM

#

another question

#

the click event will give me the slot that I've clicked the item into, but if I try and get the item in that slot it will say it's empty

#

how can I delay the check for the item slot till after the item actually gets put in that slot?

gloomy crown Mar 1, 2022, 7:13 PM

#

you can use a BukkitRunnable to schedule a task to be run maybe a few ticks after

honest fern Mar 1, 2022, 7:13 PM

#

will 1 tick be too quick?

#

or is the timing precise

gloomy crown Mar 1, 2022, 7:14 PM

#

a lot of things can happen in 1 tick

#

1 tick is just one step in the game loop

honest fern Mar 1, 2022, 7:14 PM

#

yes

#

so i can only schedule events by delay, i can't say "do this after this has happened"?

#

like callback after the current tick has finished

gloomy crown Mar 1, 2022, 7:16 PM

#

well "do this after this has happened" is kind of what events are for

honest fern Mar 1, 2022, 7:18 PM

#

i mean the inventoryclick listener is firing right before the inventory click event actually gets processed, i'd just like to run something immediately after the click event is done

#

do i have to use a bukkit runnable for that

gloomy crown Mar 1, 2022, 7:19 PM

#

yea

#

just delay 1 tick

honest fern Mar 1, 2022, 7:20 PM

#

https://i.imgur.com/6RxgUpX.png

#

;o

gloomy crown Mar 1, 2022, 7:20 PM

#

runTaskLater is prefered

honest fern Mar 1, 2022, 7:21 PM

#

why is that?

gloomy crown Mar 1, 2022, 7:22 PM

#

it runs the task with a delay

#

BukkitRunnable#runTaskLater(JavaPlugin plugin, Long delay)

#

should be something like that iirc

honest fern Mar 1, 2022, 7:23 PM

#

yes but why for a 1 tick delay like this is runTaskLayer preferred over runTask which just runs it on the next tick?

gloomy crown Mar 1, 2022, 7:23 PM

#

Screen_Shot_2022-03-01_at_2.23.23_PM.png

honest fern Mar 1, 2022, 7:24 PM

#

also the syntax of this confuses me, how does passing it the plugin work

#

what part of the plugin runs?

gloomy crown Mar 1, 2022, 7:24 PM

#

pass in the main JavaPlugin class

honest fern Mar 1, 2022, 7:24 PM

#

but what part of that will run

gloomy crown Mar 1, 2022, 7:24 PM

#

it wont

#

it just needs to know which plugin is scheduling

honest fern Mar 1, 2022, 7:25 PM

#

I'm so confused

gloomy crown Mar 1, 2022, 7:25 PM

#

what is your main class called?

honest fern Mar 1, 2022, 7:25 PM

#

Hats

gloomy crown Mar 1, 2022, 7:25 PM

#

ok

#

so in your Hats file

#

create a private static Hats instance = null;

#

then in your onEnable, set instance = this;

#

now create a ```java
public static Hats getInstance() {
return instance;
}

#

now when you do runTask or runTaskLater

#

just pass in Hats.getInstance() as the plugin

honest fern Mar 1, 2022, 7:28 PM

#

why would you do that

#

why not just pass this

gloomy crown Mar 1, 2022, 7:28 PM

#

wait, where are you creating your BukkitRunnable

honest fern Mar 1, 2022, 7:28 PM

#

also I was confused about where the code I want to run goes

#

I have no idea where I'm creating my bukkit runnable

gloomy crown Mar 1, 2022, 7:28 PM

#

BukkitRunnables usually go in their own class

honest fern Mar 1, 2022, 7:29 PM

#

i'm just trying to schedule some code to run in 1 tick

gloomy crown Mar 1, 2022, 7:29 PM

#

so you want to create a class and name it something related to what the runnable will do

gloomy crown Mar 1, 2022, 7:29 PM

#

honest fern i'm just trying to schedule some code to run in 1 tick

then create the runnable in that event

#

new BukkitRunnable() {
  public void run() {
    // code...
  }
}.runTask(Hats.getInstance(), 1L);

honest fern Mar 1, 2022, 7:30 PM

#

ohhhhhh

gloomy crown Mar 1, 2022, 7:30 PM

#

that will create a new class that extends BukkitRunnable

honest fern Mar 1, 2022, 7:30 PM

#

that's just instantiating a bukkitrunnable wdym

#

o

#

wait is this an extension syntax i've not seen

#

o wait yes i've only ever seen new ObjectName()

#

never new ObjectName() { wow new stuff }

gloomy crown Mar 1, 2022, 7:32 PM

#

gloomy crown ```java new BukkitRunnable() { public void run() { // code... } }.runTas...

its the equivalent of

public class MyRunnable extends BukkitRunnable {
  public void run() {}
}

//...
new MyRunnable().runTask(Hats.getInstance(), 1L);
//...

honest fern Mar 1, 2022, 7:32 PM

#

ye :>

gloomy crown Mar 1, 2022, 7:33 PM

#

you can extend a class by writing the extended code in brackets after the instantiating in the {}

honest fern Mar 1, 2022, 7:33 PM

#

yes

#

if i want to pass args to the runnable

gloomy crown Mar 1, 2022, 7:36 PM

#

pass into the run() method?

honest fern Mar 1, 2022, 7:36 PM

#

it puts red squiggles under the BukkitRunnable

gloomy crown Mar 1, 2022, 7:36 PM

#

show me code?

#

did you import BukkitRunnable?

honest fern Mar 1, 2022, 7:37 PM

#

yes

#

hold on getting screenshot

#

https://i.imgur.com/0regStE.png

#

I have imported it

#

the squiggles go away without the arguments in run()

gloomy crown Mar 1, 2022, 7:38 PM

#

there arent supposed to be any arguments in run()

honest fern Mar 1, 2022, 7:38 PM

#

https://i.imgur.com/KL0XvW8.png

gloomy crown Mar 1, 2022, 7:39 PM

#

i was asking if you wanted to know how to pass variables into the run method lol

honest fern Mar 1, 2022, 7:39 PM

#

oops

#

well i imagine you know now what i want to do

#

how do i?

gloomy crown Mar 1, 2022, 7:40 PM

#

i was gonna say that you dont need to pass anything, it should just be able to access variables in it's scope

#

where are you declaring the runnable?

honest fern Mar 1, 2022, 7:40 PM

#

directly in the inventoryclick event

gloomy crown Mar 1, 2022, 7:41 PM

#

ok, so you should be able to just use player in the run method

honest fern Mar 1, 2022, 7:42 PM

#

:v it keeps the same frame?

#

uh scope

gloomy crown Mar 1, 2022, 7:42 PM

#

yes

honest fern Mar 1, 2022, 7:42 PM

#

omg yay

gloomy crown Mar 1, 2022, 7:43 PM

#

// event code
Player p = e.getPlayer();

new BukkitRunnable() {
  public void run() {
    p.sendMessage("Sent on the next tick");
  }
}.runTask(Hats.getInstance(), 1L);
// blah blah...

gloomy crown Mar 1, 2022, 7:44 PM

#

honest fern directly in the inventoryclick event

where is your inventoryclick event located

#

in the main class?

honest fern Mar 1, 2022, 7:44 PM

#

yes

gloomy crown Mar 1, 2022, 7:45 PM

#

hm ok

#

you should move all of your events to a different class that implements Listener

#

and have all of your code there

honest fern Mar 1, 2022, 7:50 PM

#

there is one single event

#

my entire plugin is a single event handler

#

no onEnable or onDisable

gloomy crown Mar 1, 2022, 7:52 PM

#

oh

#

how do you register your event handler if you dont have an onEnable?

honest fern Mar 1, 2022, 7:55 PM

#

wait i forgot that bit yes

#

that exists

#

but that's it!!

gloomy crown Mar 1, 2022, 7:56 PM

#

you didnt register your events?

honest fern Mar 1, 2022, 7:57 PM

#

no i did, i have them register in onEnable, i just forgot that onEnable actually did something in my code

honest fern Mar 1, 2022, 8:32 PM

#

ItemStack cursor = event.getCursor();

#

no matter what I do, this always gives an air block

#

oh no :( i've figured out why

#

I'm relying on EssentialsX's hat feature, but that doesn't move an item from the cursor to the player's head in the same way equipping a helmet does

#

equipping a helmet shows me there was a helmet in the cursor, but using the hat feature tells me there was only air ;(

honest fern Mar 1, 2022, 9:10 PM

#

i've found a workaround

#

also i saw somewhere, someone said that you need to like "apply" changes? I'm setting custom model data, but it's not showing any NBT tags ingame

#

do I have to do this other step? I'm going to @ you in this thread instead of #help-development since it's busy

#

@gloomy crown

#

blixten are u here

marsh dew Mar 1, 2022, 9:20 PM

#

I didn't necessarily say I had the means to help

honest fern Mar 1, 2022, 9:20 PM

#

ok but are you familiar with custom model data

marsh dew Mar 1, 2022, 9:20 PM

#

I happen to be actually

honest fern Mar 1, 2022, 9:20 PM

#

i'm trying to apply it to an item but it's not applying ingame

marsh dew Mar 1, 2022, 9:20 PM

#

How are you applying it?

honest fern Mar 1, 2022, 9:20 PM

#

i think there's an extra step i need to do to make it show up

marsh dew Mar 1, 2022, 9:21 PM

#

There's a common pitfall; setting custom_model_data to 0

honest fern Mar 1, 2022, 9:21 PM

#

item.getItemMeta().setCustomModelData(CUSTOM_MODEL_DATA);

#

the value is 400,000

#

also, to clear custom model data do you null it

marsh dew Mar 1, 2022, 9:21 PM

#

You could set it to zero

honest fern Mar 1, 2022, 9:21 PM

#

ok

marsh dew Mar 1, 2022, 9:21 PM

#

Haven't tried nulling it

honest fern Mar 1, 2022, 9:22 PM

#

so that line there is in my code

marsh dew Mar 1, 2022, 9:22 PM

#

That won't really work

honest fern Mar 1, 2022, 9:22 PM

#

:V

#

how so

marsh dew Mar 1, 2022, 9:22 PM

#

You need to first create a variable with the value item.getItemMeta()

#

Then you call .setCustomModelData on that

honest fern Mar 1, 2022, 9:22 PM

#

🤔

#

ok i will try

marsh dew Mar 1, 2022, 9:22 PM

#

then you do item.setItemMeta(theothervar)

honest fern Mar 1, 2022, 9:22 PM

#

what?

#

setCustomModelData

#

oh wait no i get you

#

i update original item's metadata to this new data i've just made

marsh dew Mar 1, 2022, 9:23 PM

#

ItemMeta itemMeta = item.getItemMeta();
itemMeta.setCustomModelData(2);
item.setItemMeta(itemMeta);

honest fern Mar 1, 2022, 9:23 PM

#

so uhh

marsh dew Mar 1, 2022, 9:24 PM

#

The item's meta is encapsulated

#

.getItemMeta gives you a clone

honest fern Mar 1, 2022, 9:24 PM

#

yes

#

okey thank you

marsh dew Mar 1, 2022, 9:24 PM

#

You're welcome

honest fern Mar 1, 2022, 9:51 PM

#

blixten are you still there

#apply NBT tag to item only while in specific slot