Help with a command blocker plugin | SpigotMC | Page 1

gentle mulch Dec 31, 2021, 7:11 PM

#

ok

#

so

dapper iron Dec 31, 2021, 7:11 PM

#

What are you trying to achieve?

#

I think im not in the picture

gentle mulch Dec 31, 2021, 7:11 PM

#

just get support

dapper iron Dec 31, 2021, 7:12 PM

#

Yeah but on what topic XD. Im not quite sure what you are trying to do

gentle mulch Dec 31, 2021, 7:12 PM

#

hold on a sec

#

help with a command blocker plugin

dapper iron Dec 31, 2021, 7:14 PM

#

What isnt working?

gentle mulch Dec 31, 2021, 7:15 PM

#

i'm trying to get a command's permission by the command name

#

googling i found bukkit.getServer().getPluginCommand()

#

but it doesen't work with all the plugins in my server

#

i opened a plugin's plugin.yml file and i found all the plugin's permission

dapper iron Dec 31, 2021, 7:17 PM

#

  @EventHandler
  public void onCommand(PlayerCommandPreprocessEvent event) {
    String commandName = ...;
    String permission =  Bukkit.getCommandMap().getCommand(commandName).getPermission();
  }

gentle mulch Dec 31, 2021, 7:18 PM

#

that's what i did

#

and yet it returns null with most of my plugin when i try to get the permission

dapper iron Dec 31, 2021, 7:20 PM

#

Then this command does not have a permission associated with it

#

So everyone can send this command

gentle mulch Dec 31, 2021, 7:21 PM

#

i know it may seem sus

#

but

#

can you join my server (it's a public server)

#

with domain, discord and everything

dapper iron Dec 31, 2021, 7:22 PM

#

mc server?

gentle mulch Dec 31, 2021, 7:22 PM

#

yes

dapper iron Dec 31, 2021, 7:22 PM

#

version?

gentle mulch Dec 31, 2021, 7:22 PM

#

1.18.1

dapper iron Dec 31, 2021, 7:22 PM

#

fine...

gentle mulch Dec 31, 2021, 7:22 PM

#

and don't worry, we patched log4j

dapper iron Dec 31, 2021, 7:22 PM

#

whats the command?

#

Wouldnt matter because i as a client have to patch it as well

gentle mulch Dec 31, 2021, 7:23 PM

#

try to use a random command

gentle mulch Dec 31, 2021, 7:23 PM

#

dapper iron Wouldnt matter because i as a client have to patch it as well

i know

dapper iron Dec 31, 2021, 7:23 PM

#

right send me the domain then

gentle mulch Dec 31, 2021, 7:23 PM

#

play.orientalcraft.eu

#

lemme add u to the whitelist

dapper iron Dec 31, 2021, 7:24 PM

#

Gestankbratwurst

gentle mulch Dec 31, 2021, 7:24 PM

#

i'm starting lunar

dapper iron Dec 31, 2021, 7:24 PM

#

"maintenance"

gentle mulch Dec 31, 2021, 7:24 PM

#

yeah

#

added

#

try to log in

#

i'm the admin

#

@dapper iron ayt?

dapper iron Dec 31, 2021, 7:28 PM

#

Cant join ;D

gentle mulch Dec 31, 2021, 7:29 PM

#

why?

dapper iron Dec 31, 2021, 7:29 PM

#

gentle mulch Dec 31, 2021, 7:29 PM

#

ok

#

try now

dapper iron Dec 31, 2021, 7:32 PM

#

gentle mulch Dec 31, 2021, 7:32 PM

#

yeah

#

https://paste.md-5.net/uxifeyegat.js

#

that's the whole class: https://paste.md-5.net/mivagagaje.java

dapper iron Dec 31, 2021, 7:35 PM

#

...

#

one moment

gentle mulch Dec 31, 2021, 7:35 PM

#

so?

#

am i trying to do something impossible?

dapper iron Dec 31, 2021, 7:36 PM

#

This can be done in half the amount of lines

gentle mulch Dec 31, 2021, 7:36 PM

#

i know

dapper iron Dec 31, 2021, 7:36 PM

#

So you want to have a file where you can specify the permissions yourself? For all plugins?

gentle mulch Dec 31, 2021, 7:36 PM

#

but i started coding in java 2 days ago

#

i have a config file

#

commandblocker:
enabled: true
allowed-cmds:
- "/example"
permission-blocked-commands:
# /command , permission
- "/example example.use"

dapper iron Dec 31, 2021, 7:37 PM

#

why "permission-blocked-commands" and not just "blocked-commands"?

gentle mulch Dec 31, 2021, 7:38 PM

#

allowed commands are line above that

dapper iron Dec 31, 2021, 7:39 PM

#

Ok but why do you need the "permission-blocked-commands" section at all?

gentle mulch Dec 31, 2021, 7:39 PM

#

it's another thing i was going to add

#

it's just a scratch

dapper iron Dec 31, 2021, 7:40 PM

#

I dont get the purpose of it

gentle mulch Dec 31, 2021, 7:41 PM

#

ok

#

but

#

for the other thing

dapper iron Dec 31, 2021, 7:41 PM

#

Let me show you an example

gentle mulch Dec 31, 2021, 7:42 PM

#

there is no way to get a command's permission by it's name?

#

unless i won't declare it by myself

dapper iron Dec 31, 2021, 7:46 PM

#

public class CommandListener implements Listener {

  private static final String BYPASS_PERMISSION = "orientalcmds.cmd.bypass";

  private final List<String> allowedCommands = Main.getInstance().getConfig().getStringList("commandblocker.allowed-cmds");
  
  @EventHandler
  public void commandEvent(PlayerCommandPreprocessEvent event) {
    Player player = event.getPlayer();

    if (player.hasPermission(BYPASS_PERMISSION)) {
      return;
    }

    String[] content = event.getMessage().split(" ");
    String commandInput = content[0];

    if (!allowedCommands.contains(commandInput)) {
      // Handle disallowed command here
    }
  }

}

gentle mulch Dec 31, 2021, 7:47 PM

#

in the class there was a custom message for two commands (/backpack and /claim) cause the were level blocked

#

(you had to reach a certain level to access them)

#

but ok

#

doing this i will block every command that is not in my whitelist

#

but what if there is some command i want my staff to use but not the players?

dapper iron Dec 31, 2021, 7:50 PM

#

public class CommandListener implements Listener {

  private static final String BYPASS_PERMISSION = "orientalcmds.cmd.bypass";

  private final List<String> allowedCommands = Main.getInstance().getConfig().getStringList("commandblocker.allowed-cmds");
  // Put your level requirements in here
  private final Map<String, Integer> levelRequirements = new HashMap<>();

  @EventHandler
  public void commandEvent(PlayerCommandPreprocessEvent event) {
    Player player = event.getPlayer();

    if (player.hasPermission(BYPASS_PERMISSION)) {
      return;
    }

    String[] content = event.getMessage().split(" ");
    String commandInput = content[0];

    int playerLevel = player.getLevel();
    int requiredLevel = levelRequirements.getOrDefault(commandInput, 0);

    if (!allowedCommands.contains(commandInput)) {
      // Handle disallowed command here
    }

    if (playerLevel < requiredLevel) {
      // Handle players level is too low
    }
    
  }

}

gentle mulch Dec 31, 2021, 7:50 PM

#

for the level thing, don't worry

#

it was working

gentle mulch Dec 31, 2021, 7:51 PM

#

gentle mulch but what if there is some command i want my staff to use but not the players?

.

#

considering that they're both deopped

dapper iron Dec 31, 2021, 7:51 PM

#

one moment

#

public class CommandListener implements Listener {

  private static final String BYPASS_PERMISSION = "orientalcmds.cmd.bypass";

  private final List<String> allowedCommands = Main.getInstance().getConfig().getStringList("commandblocker.allowed-cmds");
  // Put your level threshold in here
  private final Map<String, Integer> levelRequirements = new HashMap<>();
  // Put your command bypasses in here
  private final Map<String, String> commandBypasses = new HashMap<>();

  @EventHandler
  public void commandEvent(PlayerCommandPreprocessEvent event) {
    Player player = event.getPlayer();

    String[] content = event.getMessage().split(" ");
    String commandInput = content[0];

    String commandBypassPerm = commandBypasses.get(commandInput);

    if (player.hasPermission(BYPASS_PERMISSION) || (commandBypassPerm != null && player.hasPermission(commandBypassPerm))) {
      return;
    }

    int playerLevel = player.getLevel();
    int requiredLevel = levelRequirements.getOrDefault(commandInput, 0);

    if (!allowedCommands.contains(commandInput)) {
      // Handle disallowed command here
    }

    if (playerLevel < requiredLevel) {
      // Handle players level is too low
    }

  }

}

gentle mulch Dec 31, 2021, 7:54 PM

#

what if i put in my config file another whitelist for staff commands

dapper iron Dec 31, 2021, 7:54 PM

#

public class CommandListener implements Listener {

  private static final String BYPASS_PERMISSION = "orientalcmds.cmd.bypass";

  private final List<String> allowedCommands = Main.getInstance().getConfig().getStringList("commandblocker.allowed-cmds");
  // Put your level threshold in here
  private final Map<String, Integer> levelRequirements = new HashMap<>();
  // Put your command bypasses in here
  private final Map<String, String> commandBypasses = new HashMap<>();

  @EventHandler
  public void commandEvent(PlayerCommandPreprocessEvent event) {
    Player player = event.getPlayer();

    String[] content = event.getMessage().split(" ");
    String commandInput = content[0];

    String commandBypassPerm = commandBypasses.get(commandInput);

    if (player.hasPermission(BYPASS_PERMISSION) || (commandBypassPerm != null && player.hasPermission(commandBypassPerm))) {
      return;
    }

    int playerLevel = player.getLevel();
    int requiredLevel = levelRequirements.getOrDefault(commandInput, 0);

    if (!allowedCommands.contains(commandInput)) {
      player.sendMessage("You dont have the required permission");
      event.setCancelled(true);
      return;
    }

    if (playerLevel < requiredLevel) {
      player.sendMessage(String.format("You need at least level %d for this command", requiredLevel));
      event.setCancelled(true);
    }

  }

}

gentle mulch Dec 31, 2021, 7:55 PM

#

ok thx

dapper iron Dec 31, 2021, 7:55 PM

#

gentle mulch what if i put in my config file another whitelist for staff commands

You dont need to. Just give your staff the permissions you want

gentle mulch Dec 31, 2021, 7:55 PM

#

my plugin would block commands

dapper iron Dec 31, 2021, 7:56 PM

#

Yes but give them your custom commands

gentle mulch Dec 31, 2021, 7:56 PM

#

if they're not in the whitelist

dapper iron Dec 31, 2021, 7:56 PM

#

why?

gentle mulch Dec 31, 2021, 7:56 PM

#

that other list

#

private final Map<String, String> commandBypasses = new HashMap<>();

dapper iron Dec 31, 2021, 7:56 PM

#

Oh i see...

gentle mulch Dec 31, 2021, 7:57 PM

#

so i have to use: private final List<String> allowedCommands = Main.getInstance().getConfig().getStringList("commandblocker.allowed-cmds");

#

to get from the config file the staff commands whitelist

#

so players cant execute and see staff commands

#

but staff can execute and see them without any problem

dapper iron Dec 31, 2021, 7:58 PM

#

just give your staff the bypass persmissions for those commands then

gentle mulch Dec 31, 2021, 7:59 PM

#

if i give bypass even a trainee can see every command

#

including plugins

dapper iron Dec 31, 2021, 8:00 PM

#

private final Map<String, String> commandBypasses = new HashMap<>();
This map contains for example:

"/help" - "oriental.command.bypass.help"
"/spawn" - "oriental.command.bypass.spawn"

Then you can just give your staff those two permissions

gentle mulch Dec 31, 2021, 8:00 PM

#

ok, so give bypass permission for singular commands

dapper iron Dec 31, 2021, 8:01 PM

#

Yes thats what the map is for. There is a "master" bypass permission (the constant) and there is also a bypass permission for every command

gentle mulch Dec 31, 2021, 8:02 PM

#

ok, but i want to be able to modify them whitout having to modify the source code if that's possibile

dapper iron Dec 31, 2021, 8:03 PM

#

Yes. Just read the maps from a config

gentle mulch Dec 31, 2021, 8:03 PM

#

i can loop my whitelist in the config file for the command names

#

and create a permission with that name

dapper iron Dec 31, 2021, 8:05 PM

#

Your config should look a bit like this:

blocked-commands:
  - "help"
  - "spawn"
command-bypass-permissions:
  help: "oriental.command.bypass.help"
  spawn: "oriental.command.bypass.spawn"
command-level-requirements:
  backpack: 10
  autocraft: 20

#

You can also scrap the "command-bypass-permissions" and just generate them using the command

gentle mulch Dec 31, 2021, 8:06 PM

#

i was thinking like

dapper iron Dec 31, 2021, 8:06 PM

#

blocked-commands:
  - "help"
  - "spawn"
command-level-requirements:
  backpack: 10
  autocraft: 20

gentle mulch Dec 31, 2021, 8:06 PM

#

like that

#

ok thanks

dapper iron Dec 31, 2021, 8:08 PM

#

  private static final String BYPASS_PERMISSION = "orientalcmds.cmd.bypass";

  private final List<String> allowedCommands;
  private final Map<String, Integer> levelRequirements = new HashMap<>();
  private final Map<String, String> commandBypasses = new HashMap<>();

  public CommandListener() {
    allowedCommands = Main.getInstance().getConfig().getStringList("commandblocker.allowed-cmds");
    for (String command : allowedCommands) {
      String bypassPerm = "oriental.command.bypass." + command.substring(1);
      commandBypasses.put(command, bypassPerm);
    }
    // Fill level req map here
  }

gentle mulch Dec 31, 2021, 8:08 PM

#

also

#

could you send an example of how to decleare an hasmap?

#

nvm, i'll google it

#

thanks

gentle mulch Dec 31, 2021, 10:13 PM

#

@dapper iron thx again, it works

#Help with a command blocker plugin