Applying potion to certain players | SpigotMC | Page 1

bold pike Oct 9, 2021, 9:39 AM

#

rotund tapir Oct 9, 2021, 9:39 AM

#

ahh

bold pike Oct 9, 2021, 9:39 AM

#

So

rotund tapir Oct 9, 2021, 9:39 AM

#

sup mate

bold pike Oct 9, 2021, 9:40 AM

#

What you want
All players with your helmet get a potion every X seconds, all others should not

#

Right?

rotund tapir Oct 9, 2021, 9:40 AM

#

yes, i want it so that the player who wears the custom helmet, gets haste

#

and it loops

#

so its like permament haste until you remove the helm

#

like beacons

bold pike Oct 9, 2021, 9:40 AM

#

yes

#

That's why you do this:

rotund tapir Oct 9, 2021, 9:40 AM

#

if you get out of the beacon range, it stops

bold pike Oct 9, 2021, 9:41 AM

#

In your onEnable, create a syncRepeatingTask

#

inside that, loop over all players

#

inside that loop, apply the effect to all players that have your helmet

#

that's it

rotund tapir Oct 9, 2021, 9:41 AM

#

yes true

#

oh just syncRepeatingTask?

#

thats a thing?

#

stuff here right?

bold pike Oct 9, 2021, 9:45 AM

#

oh you're using a runnable

#

yeah that you can use too

#

exactly, at //stuff here you add the for loop

#

that goes through all online players

rotund tapir Oct 9, 2021, 9:45 AM

#

so something like

bold pike Oct 9, 2021, 9:45 AM

#

btw it would be nice if your screenshots would show a bit more context

rotund tapir Oct 9, 2021, 9:45 AM

#

wait lemme try stuff out and get back to ya

#

ok next time i will

#

';' expected

#

why da heck

bold pike Oct 9, 2021, 9:49 AM

#

BRO

#

STOP USING

#

THE WHILE LOOP

rotund tapir Oct 9, 2021, 9:49 AM

#

oops

bold pike Oct 9, 2021, 9:49 AM

#

Okay I will now literally write it for you

rotund tapir Oct 9, 2021, 9:49 AM

#

._.

#

sorry

bold pike Oct 9, 2021, 9:50 AM

#

np, the problem is just, that you don't try to understand what your code does 😄

#

@Override
    public void onEnable() {
        Bukkit.getScheduler().scheduleSyncRepeatingTask(this, () -> {
            for(Player player : Bukkit.getOnlinePlayers()) {
                if(isMinerHelmet(player.getInventory().getHelmet())) {
                    player.addPotionEffect(new PotionEffect(PotionEffectType.JUMP, 2, 1));
                }
            }
        }, 20, 20); // 20 means every second
    }

#

The while loop will never end

#

it will run forever

#

and you do not even need it

#

basically the syncRepeatingTask is what we are using instead of your while loop

rotund tapir Oct 9, 2021, 9:51 AM

#

ok tysm

#

the thing of spoonfeeding is

bold pike Oct 9, 2021, 9:51 AM

#

oh wait

rotund tapir Oct 9, 2021, 9:51 AM

#

you get spoonfed once

bold pike Oct 9, 2021, 9:51 AM

#

in the PotionEffect thing, replace the 2 with a 40

rotund tapir Oct 9, 2021, 9:52 AM

#

then you dont need it anymore

#

yes ofc

bold pike Oct 9, 2021, 9:52 AM

#

40 ticks = 2 seconds

rotund tapir Oct 9, 2021, 9:52 AM

#

im not that dumb lol

bold pike Oct 9, 2021, 9:52 AM

#

yeah I thought it was using seconds

rotund tapir Oct 9, 2021, 9:52 AM

#

its all fine

#

idk what is happening

bold pike Oct 9, 2021, 9:59 AM

#

what is happening?

rotund tapir Oct 9, 2021, 9:59 AM

#

i will test some stuf

#

if i cant find it out

#

i will ask

#

it doesnt give me the helm

#

lemme recompile

#

nope, no item

bold pike Oct 9, 2021, 10:07 AM

#

Show your code again pls

rotund tapir Oct 9, 2021, 10:07 AM

#

of what

bold pike Oct 9, 2021, 10:07 AM

#

well you say it doesnt give you any item

#

so show the code that gives players an item

rotund tapir Oct 9, 2021, 10:08 AM

#

    public static ItemStack minerHelmet;

    public static void init(){
        createMinerHelmet();
    }

    public static void createMinerHelmet(){


        {
            ItemStack item = new ItemStack(Material.IRON_HELMET);
            ItemMeta meta = item.getItemMeta();
            meta.setDisplayName("§6Miner helmet");
            List<String> minerHelmetLore = new ArrayList<>();
            minerHelmetLore.add("§7Wear this helmet");
            minerHelmetLore.add("§7to gain §e:pick: Haste 1!");
            minerHelmetLore.add("");
            minerHelmetLore.add("§6§lLEGENDARY");
            meta.setLore(minerHelmetLore);
            item.setItemMeta(meta);
            meta.getPersistentDataContainer().set(new NamespacedKey(SMPCore.getInstance(), "minerhelmet"), PersistentDataType.BYTE, (byte) 1);


            minerHelmet = item;
``` this is in main

bold pike Oct 9, 2021, 10:08 AM

#

you don't set the PDC tag

#

you are using item.setItemMeta and AFTER that add the PDC to the itemmeta

#

switch the item.setItemMeta and meta.getPersistent... lines

rotund tapir Oct 9, 2021, 10:09 AM

#

ah ok

#

pretty dumb of me

#

nope it still doesnt give me the helm on command

#

public class GiveHelm implements CommandExecutor {
    @Override
    public boolean onCommand(CommandSender sender, Command command, String s, String[] strings){
        if (command.getName().equalsIgnoreCase("givehelm")) {

                ( (Player) sender ).getInventory().addItem(SMPCore.minerHelmet);
            }
        return true;
        }

    }

#

thats my command to give helm

bold pike Oct 9, 2021, 10:12 AM

#

does the onCommand even run?

#

add a message to see if it actually runs

rotund tapir Oct 9, 2021, 10:12 AM

#

ok

#

uh oh

#

looks like a command problem

bold pike Oct 9, 2021, 10:13 AM

#

by the way

#

the if(command.getName()...) is useless

#

your executor will only run for the commands you registered it to

#

you did register the commandexecutor, did you?

rotund tapir Oct 9, 2021, 10:14 AM

#

yes i did ofc

bold pike Oct 9, 2021, 10:14 AM

#

show the code pls

#

for registering it

rotund tapir Oct 9, 2021, 10:14 AM

#

ok

#

getCommand("givehelm").setExecutor(new GiveHelm());

bold pike Oct 9, 2021, 10:14 AM

#

that's in your onEnable()?

rotund tapir Oct 9, 2021, 10:15 AM

#

wait what

#

yes

#

all commands stopped

bold pike Oct 9, 2021, 10:15 AM

#

send your latest.log pls

rotund tapir Oct 9, 2021, 10:15 AM

#

oh i see why

#

ok i will

#

📎 latest.log

#

oh didnt notice that

#

org.bukkit.inventory.ItemStack.hasItemMeta()" because "itemToCheck" is null

bold pike Oct 9, 2021, 10:17 AM

#

whoa you have a ton of errors

#

anyway you do not even need any ArmorEquipEvent

#

I'd just completely remove that event

rotund tapir Oct 9, 2021, 10:18 AM

#

okay

#

as i like to call it

#

APIPhobia

#

ooo

#

now it works

bold pike Oct 9, 2021, 10:22 AM

#

nice

rotund tapir Oct 9, 2021, 10:22 AM

#

1 line of code messed up the whole plugin

#

how the hell

#

ty for the help good human

bold pike Oct 9, 2021, 10:25 AM

#

np 😄

rotund tapir Oct 9, 2021, 2:10 PM

#

@bold pike are you still there?

bold pike Oct 9, 2021, 2:11 PM

#

yes

rotund tapir Oct 9, 2021, 2:12 PM

#

so

#

to prevent new players (in trash armor) to mine out my fossil boss. how can i make a custom block for the boss

#

currently i have this

#

thats fine and all

#

but im experiencing problems in block break event

#

which ik how to fix, but not how to fix with custom items

bold pike Oct 9, 2021, 2:14 PM

#

a custom block? wdym?

rotund tapir Oct 9, 2021, 2:14 PM

#

a custom itemstack

#

like this, but a block

bold pike Oct 9, 2021, 2:15 PM

#

all the custom itemmeta is lost when you place your itemstack

#

you have to use my CUstomBlockData library to store information inside blocks

#

it's in the spigot forums

rotund tapir Oct 9, 2021, 2:15 PM

#

ok

#

is it hard to do?

bold pike Oct 9, 2021, 2:15 PM

#

https://link.jeff-media.com/customblockdata-spigot

SpigotMC - High Performance Minecraft

Resource - Custom Block Data - PersistentDataContainer for Blocks!

Hi everyone :)

Today I want to show you my new CustomBlockData resource. If you are only interested in how it works, check out the GitHub link below,...

rotund tapir Oct 9, 2021, 2:15 PM

#

for a spigot beginner

bold pike Oct 9, 2021, 2:15 PM

#

no it basically just provides a PDC for blocks

rotund tapir Oct 9, 2021, 2:16 PM

#

alright

bold pike Oct 9, 2021, 2:16 PM

#

but on blockplaceevent, you have to manually add the information to the block again

rotund tapir Oct 9, 2021, 2:16 PM

#

oh its an api

#

api/lib

bold pike Oct 9, 2021, 2:16 PM

#

I think there's an example plugin linked in the thread or github repo

#

yes you can include it with maven into your plugin

rotund tapir Oct 9, 2021, 2:16 PM

#

i have never figured out how to put it in

#

WHERE IS THEIR JAR DOWNLAOD

bold pike Oct 9, 2021, 2:17 PM

#

hm?

#

what .jar download?

rotund tapir Oct 9, 2021, 2:17 PM

#

i cant find the file download

bold pike Oct 9, 2021, 2:17 PM

#

for my library?

rotund tapir Oct 9, 2021, 2:17 PM

#

oh its yours

#

lmfao

bold pike Oct 9, 2021, 2:17 PM

#

maven downloads it automatically from the repository

rotund tapir Oct 9, 2021, 2:17 PM

#

ohh

bold pike Oct 9, 2021, 2:17 PM

#

you dont need to download it yourself

#

just follow the instructions there in the "maven" part

rotund tapir Oct 9, 2021, 2:18 PM

#

thanks Kody Simpson for the confusion!

#

you german i see

bold pike Oct 9, 2021, 2:18 PM

#

yes

rotund tapir Oct 9, 2021, 2:19 PM

#

ja ja ich lehre deutsch

bold pike Oct 9, 2021, 2:19 PM

#

😄

#

viel erfolg!

rotund tapir Oct 9, 2021, 2:19 PM

#

sorry i only know like

#

uh

#

A2

#

not even A2 lol

#

mein deutsch ist blōd

bold pike Oct 9, 2021, 2:21 PM

#

nein, es ist ganz gut 😄

rotund tapir Oct 9, 2021, 2:21 PM

#

ik what that means

#

but idk how to answer

rotund tapir Oct 9, 2021, 2:21 PM

#

bold pike nein, es ist ganz gut 😄

ok danke

rotund tapir Oct 9, 2021, 2:37 PM

#

yo @bold pike i have an honest question

#

is it polite to ask "ich mōchte" in a restaurant?

#

but like how can i set the data?

#

i cant figure it ou t

bold pike Oct 9, 2021, 2:56 PM

#

rotund tapir is it polite to ask "ich mōchte" in a restaurant?

better would be

#

"Ich hätte gerne ..."

bold pike Oct 9, 2021, 2:56 PM

#

rotund tapir but like how can i set the data?

Okay Ill give an example, one sec

#

@EventHandler
    public void onPlaceBlock(BlockPlaceEvent event) {
        if(event.getItemInHand().getItemMeta().getPersistentDataContainer().has(/* Check if this is your custom item */)) {
            // This is our custom item! Let's set the custom block data
            CustomBlockData cbd = new CustomBlockData(event.getBlock(), yourPlugin);
            cbd.set(new NamespacedKey(myPlugin,"mydata", PersistentDataType.STRING, "my custom data"));
        }
    }

@rotund tapir

rotund tapir Oct 9, 2021, 3:00 PM

#

thanks

#

what do i replace myPlugin with?

#

main class?

bold pike Oct 9, 2021, 3:10 PM

#

a reference to your main class, yes

rotund tapir Oct 9, 2021, 3:10 PM

#

 if (e.getItemInHand().getItemMeta().getPersistentDataContainer().has(SMPCore.boss_spawner)) {
        CustomBlockData cbd = new CustomBlockData(e.getBlock(), SMPCore.getInstance());
        cbd.set(new NamespacedKey(SMPCore.getInstance(), "mydata", PersistentDataType.STRING, "my custom data"));

bold pike Oct 9, 2021, 3:11 PM

#

sorry I made mistake above

#

move the second last ) behind "mydata"

#

cbd.set(new NamespacedKey(SMPCore.getInstance(), "mydata"), PersistentDataType.STRING, "my custom data");

rotund tapir Oct 9, 2021, 3:11 PM

#

i see i see

#

and what is this fuss about?

bold pike Oct 9, 2021, 3:12 PM

#

it says that getItemMeta COULD be null

#

but only when the player doesnt have an item in their hand

rotund tapir Oct 9, 2021, 3:12 PM

#

not that

#

but on the right

#

its colored red

bold pike Oct 9, 2021, 3:13 PM

#

has() needs to be provided a NamespacedKey

rotund tapir Oct 9, 2021, 3:13 PM

#

so that means uh

bold pike Oct 9, 2021, 3:13 PM

#

https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/persistence/PersistentDataContainer.html#has(org.bukkit.NamespacedKey,org.bukkit.persistence.PersistentDataType)

PersistentDataContainer (Spigot-API 1.17.1-R0.1-SNAPSHOT API)

declaration: package: org.bukkit.persistence, interface: PersistentDataContainer

rotund tapir Oct 9, 2021, 3:13 PM

#

ok

bold pike Oct 9, 2021, 3:13 PM

#

that means you must do things like

if(pdc.has(new NamespacedKey(myPlugin,"mydata"),PersistentDataType.STRING))

rotund tapir Oct 10, 2021, 1:06 PM

#

yo @bold pike quick question before closing this thread

bold pike Oct 10, 2021, 1:06 PM

#

yes?

rotund tapir Oct 10, 2021, 1:06 PM

#

so

#

my server has a thing with rng

#

there is a chance to get a thing when breaking a specific block

#

all of them work fine, except

#

 public static void onMine(BlockBreakEvent e) {
        if (e.getBlock().getType() == Material.DIAMOND_ORE || e.getBlock().getType() == Material.DEEPSLATE_DIAMOND_ORE || e.getBlock().getType() == Material.EMERALD_ORE || e.getBlock().getType() == Material.DEEPSLATE_EMERALD_ORE) {
            int random = ThreadLocalRandom.current().nextInt(10000);
            if (random == 1000) {
                e.getBlock().getDrops().add(new ItemStack(Material.IRON_INGOT));
                e.getPlayer().sendMessage("§f§lCOMMON!" + "§7 1x Iron Ingot");


            } else if (random == 100) {
                e.getBlock().getDrops().add(new ItemStack(Material.NETHERITE_SCRAP, 2));
                e.getPlayer().sendMessage("§9§lRARE DROP!" + "§7 2x Netherite Scrap");
            } else if (random == 10) {
                e.getBlock().getDrops().add(new ItemStack(Material.NETHERITE_INGOT, 1));
                e.getPlayer().sendMessage("§9§lRARE DROP!" + "§7 1x Netherite Ingot");
            } else if (random == 1) {
                e.getBlock().getDrops().add(new ItemStack(Material.DIAMOND_BLOCK, 2));
                e.getPlayer().sendMessage("§6§lEPIC DROP!" + "§7 2X Diamond Block");
            }
        }
        }
    }

`

#

oops

#

should i invert the random chances?

#

instead of going high to low, make it go low to high?

bold pike Oct 10, 2021, 1:08 PM

#

you're doing it wrong

#

you are getting an int between 0 and 10000

#

so 10000 possible values

rotund tapir Oct 10, 2021, 1:08 PM

#

yeah

bold pike Oct 10, 2021, 1:08 PM

#

then you check 4 times for a specific value

#

meaning every of your drop changes is 1/10000 = 0.01%

rotund tapir Oct 10, 2021, 1:09 PM

#

but then

bold pike Oct 10, 2021, 1:09 PM

#

the chance for random == 1000 is exactly as high as for random = 1

#

0.01%

#

it's like throwing a dice and saying when dice == 3 do this, when dice == 2 do that

rotund tapir Oct 10, 2021, 1:09 PM

#

why does this work then?

bold pike Oct 10, 2021, 1:09 PM

#

it's 1/6 chance everytime

#

because there you are checking if the number is smaller and not equal to your desired chance

rotund tapir Oct 10, 2021, 1:10 PM

#

ah ok

bold pike Oct 10, 2021, 1:10 PM

#

if (random <= 1000) = 10% chance

#

if(random <= 100) = 1% chance

#

oh btw and your first line, you do this:

        if (e.getBlock().getType() == Material.DIAMOND_ORE || e.getBlock().getType() == Material.DEEPSLATE_DIAMOND_ORE || e.getBlock().getType() == Material.EMERALD_ORE || e.getBlock().getType() == Material.DEEPSLATE_EMERALD_ORE) {

#

I'd rather do it like this:

rotund tapir Oct 10, 2021, 1:13 PM

#

 int random = ThreadLocalRandom.current().nextInt(10000);
            if (random <= 1) {
                e.getBlock().getDrops().add(new ItemStack(Material.DIAMOND_BLOCK, 2));
                e.getPlayer().sendMessage("§6§lEPIC DROP!" + "§7 2X Diamond Block");
            } else if (random <= 10) {
                e.getBlock().getDrops().add(new ItemStack(Material.NETHERITE_INGOT, 1));
                e.getPlayer().sendMessage("§9§lRARE DROP!" + "§7 1x Netherite Ingot");
            } else if (random <= 100) {

                e.getBlock().getDrops().add(new ItemStack(Material.NETHERITE_SCRAP, 2));
                e.getPlayer().sendMessage("§9§lRARE DROP!" + "§7 2x Netherite Scrap");
            } else if (random <= 1000) {

                e.getBlock().getDrops().add(new ItemStack(Material.IRON_INGOT));
                e.getPlayer().sendMessage("§f§lCOMMON!" + "§7 1x Iron Ingot");
            }
        }
        }
    }

#

so like this?

bold pike Oct 10, 2021, 1:14 PM

#

wait pls

#

a few things

rotund tapir Oct 10, 2021, 1:14 PM

#

ok

bold pike Oct 10, 2021, 1:14 PM

#

first of all I'd replace the check for the blocks

#

hardcoding all that stuff in the event is a bit dirty

#

and yeah, you have to switch the order like you already did

#

oh and also

#

you cannot add to the getDrops list

rotund tapir Oct 10, 2021, 1:15 PM

#

ok brb

bold pike Oct 10, 2021, 1:15 PM

#

private static final Set<Material> ores = new HashSet<>(Arrays.asList(
            Material.DIAMOND_ORE,
            Material.DEEPSLATE_DIAMOND_ORE,
            Material.EMERALD_ORE,
            Material.DEEPSLATE_EMERALD_ORE));

    public static void onMine(BlockBreakEvent e) {
        if (!ores.contains(e.getBlock().getType())) return;
        
        // Do you random stuff here
        ...
    }

#

first, you cannot just add to the getDrops list

#

and second, if it would work to add items, that wouldnt affect the drops

rotund tapir Oct 10, 2021, 1:17 PM

#

yeah i had a problem

#

if i do getPlayer.getInventory.add(blah blah blah)

bold pike Oct 10, 2021, 1:17 PM

#

Block#getDrops doesnt set the drops for this specific block, but rather just returns a list of drops that this block WOULD drop

rotund tapir Oct 10, 2021, 1:17 PM

#

and the inventory was full

#

then it wouldnt add

bold pike Oct 10, 2021, 1:17 PM

#

simply drop the item yourself

rotund tapir Oct 10, 2021, 1:18 PM

#

getPlayer().drop() ?

#

something like that

#

?

bold pike Oct 10, 2021, 1:18 PM

#

e.getBlock().getWorld().dropItemNaturally(e.getBlock().getLocation(), new ItemStack(Material.IRON_INGOT));

rotund tapir Oct 10, 2021, 1:18 PM

#

ok brb gotta go eat lunch/dunch

#

sorry

bold pike Oct 10, 2021, 1:18 PM

#

but I wouldnt repeat all this logic everytime. Better create a variable "drop" and "message", and at the bottom of your code, check whether they are null, and if not, call the drop logic

#

otherwise you repeat the same two lines 4 times

#

basically sth like this

        ItemStack bonusDrop = null;
        String message = null;

        if (random <= 1000) {
            bonusDrop = new ItemStack(Material.IRON_INGOT);
            message = "§f§lCOMMON!" + "§7 1x Iron Ingot";
        } else if (random <= 100) {
            bonusDrop = new ItemStack(Material.NETHERITE_SCRAP, 2);
            message = "§9§lRARE DROP!" + "§7 2x Netherite Scrap";
         }

         if(bonusDrop != null) {
             e.getBlock().getWorld().dropItemNaturally(e.getBlock().getLocation(), bonusDrop); 
             player.sendMessage(message);
         }

rotund tapir Oct 10, 2021, 1:34 PM

#

alright thanks mate!

#

oh wow that actually makes sense

#

okay thx

#

too lazy to start up my localhost

#

   private static final Set<Material> ores;

    static{
        ores = new HashSet<>(Arrays.asList(
                Material.DIAMOND_ORE,
                Material.DEEPSLATE_DIAMOND_ORE,
                Material.EMERALD_ORE,
                Material.DEEPSLATE_EMERALD_ORE));
    }

    @EventHandler

    public static void onMine(BlockBreakEvent e) {
        if (!ores.contains(e.getBlock().getType())) return;
        else  {
            int random = ThreadLocalRandom.current().nextInt(10000);
            ItemStack bonusDrop = null;
            String message = null;
            Player player = e.getPlayer();
            if (random <= 1) {
                bonusDrop = new ItemStack(Material.DIAMOND_BLOCK, 2);
                message = "§6§lEPIC DROP!" + "§7 2X Diamond Block";
            } else if (random <= 10) {
           bonusDrop = new ItemStack(Material.NETHERITE_INGOT);
                message = "§9§lRARE DROP!" + "§7 1x Netherite Ingot";
            } else if (random <= 100) {

               bonusDrop = new ItemStack(Material.NETHERITE_SCRAP, 2);
                message = "§9§lRARE DROP!" + "§7 2x Netherite Scrap";
            } else if (random <= 1000) {

                bonusDrop = new ItemStack(Material.IRON_INGOT);
                message = "§f§lCOMMON!" + "§7 1x Iron Ingot";
            } if (bonusDrop != null) {
                e.getBlock().getWorld().dropItemNaturally(e.getBlock().getLocation(), bonusDrop);
                player.sendMessage(message);
            }
        }
        }
    }

this should work right?

#

ok update: it works. thanks

bold pike Oct 10, 2021, 2:03 PM

#

np 🙂

rotund tapir Oct 10, 2021, 2:05 PM

#

still cant figure out on how to do the java thing

#

System.out.println("text")

#

????

bold pike Oct 10, 2021, 2:14 PM

#

@rotund tapir

rotund tapir Oct 10, 2021, 2:15 PM

#

System.out.println("Hello, world!")

#

there we go

bold pike Oct 10, 2021, 2:15 PM

#

yaay

rotund tapir Oct 10, 2021, 2:16 PM

#

ngl i feel like minikloon

#Applying potion to certain players