Spigot API changes | SpigotMC | Page 1

crisp crescent Sep 24, 2021, 11:13 AM

#

Relevant tickets https://hub.spigotmc.org/jira/browse/SPIGOT-6745 https://hub.spigotmc.org/jira/browse/SPIGOT-6023

#

React: 1️⃣ For calling if behavior changed or 2️⃣ If you wanna call everytime the itemstack is changed

frank reef Sep 24, 2021, 11:15 AM

#

The more data we can pull out from an event, the more useful it is

crisp crescent Sep 24, 2021, 11:16 AM

#

First to reach 5 reactions will get used

crisp crescent Sep 24, 2021, 11:16 AM

#

frank reef The more data we can pull out from an event, the more useful it is

Yeah but i think MD will hate that behavior xD

trim belfry Sep 24, 2021, 11:17 AM

#

dont call 2 separate events

#

fix the current one to do its job nothing more

crisp crescent Sep 24, 2021, 11:17 AM

#

They aint 2 seperate events

trim belfry Sep 24, 2021, 11:17 AM

#

you want to call the event again

#

retriggering it

crisp crescent Sep 24, 2021, 11:18 AM

#

With the new itemstack

trim belfry Sep 24, 2021, 11:18 AM

#

wich will most likely break plugins listening to the dispenser rather than the item

crisp crescent Sep 24, 2021, 11:18 AM

#

currently there is no way around not calling it again if the new itemstack's dispense behavior is different

crisp crescent Sep 24, 2021, 11:19 AM

#

trim belfry wich will most likely break plugins listening to the dispenser rather than the i...

It already calls if again if the dispense behavior is different because thats how the genius who made this in the first place set this up

trim belfry Sep 24, 2021, 11:19 AM

#

your ticket is specific,fix whats in it,rn the problem is the player equips the original item even if a new one is set

crisp crescent Sep 24, 2021, 11:20 AM

#

Dont forget https://hub.spigotmc.org/jira/browse/SPIGOT-6023

trim belfry Sep 24, 2021, 11:20 AM

#

dont combine tickets

#

,,,

crisp crescent Sep 24, 2021, 11:20 AM

#

They are the same system

trim belfry Sep 24, 2021, 11:20 AM

#

make a new one for it if its still a problem

#

with a unrelated ticket

crisp crescent Sep 24, 2021, 11:20 AM

#

its not unrelated

trim belfry Sep 24, 2021, 11:21 AM

#

the ticket you are fixing says item is not properly set

#

dont also fix something from another one

crisp crescent Sep 24, 2021, 11:21 AM

#

I was fixing 6023 i encountered 6745

trim belfry Sep 24, 2021, 11:21 AM

#

as the changelog needs to remain relevant

#

if you will fix both problems do a ticket for each

crisp crescent Sep 24, 2021, 11:22 AM

#

You mean PR for each?

#

They already have seperate tickets

trim belfry Sep 24, 2021, 11:23 AM

#

yes separate them

crisp crescent Sep 24, 2021, 11:23 AM

#

:painexe:

trim belfry Sep 24, 2021, 11:24 AM

#

its likely to not get rejected by md...

#

that way

crisp crescent Sep 24, 2021, 11:24 AM

#

Fine that sucks tho

#

That still causes the event to trigger again if the dispensebehavior is different

#

Another question: Currently when you change the itemstack in the event the original itemstack stays inside of the dispenser and does not get subtracted.

#

Do you guys think this behavior should stay or should the original itemstack get subtracted by 1

#Spigot API changes