[IN DEV] CVN (Cross-Version-NMS) | SpigotMC | Page 2

fallow sky May 25, 2024, 6:13 PM

#

see you later 👋

rigid saffron May 25, 2024, 6:13 PM

#

that we will feed to spigot

#

it just does the same things a JavaPlugin does usually

#

apparently there is something called a PluginBase

rigid saffron May 25, 2024, 6:36 PM

#

Actually, JavaPlugin has a protected contructor that lets us give it a PluginFileDescriptor, meaning we can just call that using reflection without any extra classes

fallow sky May 25, 2024, 6:39 PM

#

rigid saffron Actually, JavaPlugin has a protected contructor that lets us give it a PluginFil...

can you make that?

rigid saffron May 25, 2024, 6:40 PM

#

Once I finish the gradle plugin

fallow sky May 25, 2024, 6:41 PM

#

okok

#

and after that, we would have finished CVN?

rigid saffron May 25, 2024, 6:41 PM

#

Yeah

fallow sky May 25, 2024, 6:41 PM

#

incredible

#

it was so fast

rigid saffron May 25, 2024, 6:41 PM

#

Just that we will also need a maven plugin

fallow sky May 25, 2024, 6:41 PM

#

rigid saffron Just that we will also need a maven plugin

...and to publish on a maven repo

rigid saffron May 25, 2024, 6:42 PM

#

Yeah

#

But that all is a secondary problem

fallow sky May 25, 2024, 6:42 PM

#

yeah x)

#

this is incredible

#

I'll make a youtube tutorial to teach how to use CVN as soon as we'll have finished

rigid saffron May 25, 2024, 6:42 PM

#

Actually, wait, we are overcomplicating things even more, since we end up creating a remapped jar, we can just change the cvn-plugin.yml to be a plugin.yml and load it like usual

fallow sky May 25, 2024, 6:42 PM

#

rigid saffron Actually, wait, we are overcomplicating things even more, since we end up creati...

I thought of that

rigid saffron May 25, 2024, 6:43 PM

#

This makes everything so much easier

fallow sky May 25, 2024, 6:43 PM

#

but there was a problem but I can't remember which one

#

also, we shouldn't forget to make the plugins remapped using CVN as dependency to make sure we can update them before loading them (if the original not remapped file is changed, basically)

rigid saffron May 25, 2024, 6:44 PM

#

There shouldn't be one. We remap the plugin, change the cvn-plugin.yml to be a plugin.yml and put it in some directory + we add its hash so we know when to update the remapped jar
Then we load them through PluginManager#loadPlugin(File) and enjoy life

fallow sky May 25, 2024, 6:44 PM

#

perfect then

#

I re-go eat x) If we can finish today, it's perfect 😄

rigid saffron May 25, 2024, 6:45 PM

#

I doubt I can finish today

#

Likely only tomorrow

fallow sky May 25, 2024, 6:45 PM

#

I'll work too

#

focus on the gradle/maven plugin, and push on github too

#

I'll do my best for CVN if I have time later

#

see you later

fallow sky May 25, 2024, 7:14 PM

#

rigid saffron Actually, JavaPlugin has a protected contructor that lets us give it a PluginFil...

how I create the PluginDescriptionFile from the cvn-plugin.yml ?
what should I put for JavaPluginLoader ?

rigid saffron May 25, 2024, 7:16 PM

#

fallow sky how I create the PluginDescriptionFile from the cvn-plugin.yml ? what should I p...

No need to, just do the approach I described here: #1243264378522959914 message

fallow sky May 25, 2024, 7:16 PM

#

oh yeah

#

I forgot you said that x)

fallow sky May 25, 2024, 7:17 PM

#

rigid saffron No need to, just do the approach I described here: https://discord.com/channels/...

how can I rename a file in a jar?

rigid saffron May 25, 2024, 7:18 PM

#

Unsure whether the JarFile or whatever it was called has a method for that

fallow sky May 25, 2024, 7:18 PM

#

google says that it's like a zip, hmm

fallow sky May 25, 2024, 7:18 PM

#

rigid saffron Unsure whether the JarFile or whatever it was called has a method for that

it's called JarFile yeah

rigid saffron May 25, 2024, 7:18 PM

#

But you could unarchive it, as it is a zip, change the yml file name and rearchive it

fallow sky May 25, 2024, 7:19 PM

#

yeah

fallow sky May 25, 2024, 7:37 PM

#

@rigid saffron not finished, and there might be bugs that I'll patch after x)
https://github.com/Cross-Version-NMS/CVN/commit/b7817978e3435b59ce26999d75ef89ee842574da

GitHub

Enhanced remapper, Added the base of the loader · Cross-Version-NMS...

#

and still no hash

rigid saffron May 25, 2024, 7:39 PM

#

okay

#

Nice

woven arrow May 25, 2024, 7:40 PM

#

why is this comment here

rigid saffron May 25, 2024, 7:40 PM

#

Lol

fallow sky May 25, 2024, 7:40 PM

#

woven arrow why is this comment here

x)

rigid saffron May 25, 2024, 7:40 PM

#

Rad, why are you inspecting all the code

fallow sky May 25, 2024, 7:40 PM

#

rigid saffron Lol

is the plugin going good ?

rigid saffron May 25, 2024, 7:41 PM

#

I still have no idea what is causing my issue

fallow sky May 25, 2024, 7:41 PM

#

oh really

rigid saffron May 25, 2024, 7:41 PM

#

I have asked on a few forums, waiting

fallow sky May 25, 2024, 7:41 PM

#

I think you should work on the plugin loader while waiting :)

woven arrow May 25, 2024, 7:41 PM

#

rigid saffron Rad, why are you inspecting all the code

i checked out the commit

rigid saffron May 25, 2024, 7:42 PM

#

fallow sky I think you should work on the plugin loader while waiting :\)

Nah I'll play a mobile game and go sleep

fallow sky May 25, 2024, 7:42 PM

#

woven arrow i checked out the commit

is it bad enough

#

pandalove

fallow sky May 25, 2024, 7:42 PM

#

rigid saffron Nah I'll play a mobile game and go sleep

sleep ?

#

what is this ?

woven arrow May 25, 2024, 7:42 PM

#

i'm not necessarily seeing anything bad there

fallow sky May 25, 2024, 7:42 PM

#

woven arrow i'm not necessarily seeing anything bad there

it should works

woven arrow May 25, 2024, 7:42 PM

#

but i also dk anything about reflection and that typa thing

fallow sky May 25, 2024, 7:42 PM

#

but not perfectly

fallow sky May 25, 2024, 7:42 PM

#

woven arrow but i also dk anything about reflection and that typa thing

there isn't reflection 😎

#

just modifying a jar file without extracting his content

woven arrow May 25, 2024, 7:43 PM

#

then like jar modding

#

never done that, never needed

fallow sky May 25, 2024, 7:44 PM

#

woven arrow then like jar modding

yeah, just replacing cvn-plugin.yml by plugin.yml

rigid saffron May 25, 2024, 7:44 PM

#

woven arrow then like jar modding

Kinda

fallow sky May 25, 2024, 7:44 PM

#

basically those lines :```java
InputStream stream = jar.getInputStream(jar.getJarEntry("cvn-plugin.yml"));

ZipFile zipFile = new ZipFile(plugin);
zipFile.removeFile("cvn-plugin.yml");

ZipParameters parameters = new ZipParameters();
parameters.setFileNameInZip("plugin.yml");

zipFile.addStream(stream, parameters);```

#

I should close the jar file too x)

#

idk if it's good 🤷

#

@rigid saffron is there a way I can use intermediary mappings directly?

#

even, is it necessary to have intermediary mappings to pass the plugin into CVN?

#

just some basic bukkit code will works?

rigid saffron May 25, 2024, 7:47 PM

#

Wdym

#

You want a plugin with intermediary mappings for testing?

#

You can use the tiny-remapper by fabricmc and remap it

fallow sky May 25, 2024, 7:49 PM

#

rigid saffron You want a plugin with intermediary mappings for testing?

Yeah

rigid saffron May 25, 2024, 7:50 PM

#

fallow sky I should close the jar file too x)

Use a try with resources to autoclose

fallow sky May 25, 2024, 7:50 PM

#

rigid saffron Use a try with resources to autoclose

Okok

fallow sky May 25, 2024, 7:52 PM

#

rigid saffron Use a try with resources to autoclose

I'm already using a try with resources, and then I pass the resource in return and reuse it after

#

so, wait, it's already closed?

#

I must remake a try with resource?

rigid saffron May 25, 2024, 7:53 PM

#

try with resource closes things automatically

fallow sky May 25, 2024, 7:53 PM

#

okok

#

so I must remake one

#

bruh, almost 1 Mb 💀

rigid saffron May 25, 2024, 7:59 PM

#

The whole plugin?

fallow sky May 25, 2024, 7:59 PM

#

yeah

rigid saffron May 25, 2024, 8:00 PM

#

Damn

fallow sky May 25, 2024, 8:00 PM

#

📎 CVN-1.0-SNAPSHOT-all.jar

#

tinyremapper is the heaviest

rigid saffron May 25, 2024, 8:01 PM

#

Yeah, I'll refactor it a bit so it has less useless classes

fallow sky May 25, 2024, 8:01 PM

#

perfect

#

let's test our system

#

seems to be a very good test plugin

rigid saffron May 25, 2024, 8:04 PM

#

Great plugin

fallow sky May 25, 2024, 8:05 PM

#

I...

rigid saffron May 25, 2024, 8:05 PM

#

Lol

fallow sky May 25, 2024, 8:05 PM

#

📎 test-plugin-1.0-SNAPSHOT.jar

rigid saffron May 25, 2024, 8:05 PM

#

That's weird

#

It shouldn't do that in theory

fallow sky May 25, 2024, 8:05 PM

#

and it is not loaded by CVN 👍

rigid saffron May 25, 2024, 8:06 PM

#

Amazing

fallow sky May 25, 2024, 8:06 PM

#

let's do a good debugging

rigid saffron May 25, 2024, 8:06 PM

#

Lol

#

Ig we'll have to make a cvn-plugins folder or something, but that is cringe

fallow sky May 25, 2024, 8:09 PM

#

yeah

#

okay, the problem was a dot

#

there

#

.jar -> jar

rigid saffron May 25, 2024, 8:09 PM

#

Lol

fallow sky May 25, 2024, 8:10 PM

#

rigid saffron Ig we'll have to make a cvn-plugins folder or something, but that is cringe

and, if we edit the source code of the original server.jar ? 👀

rigid saffron May 25, 2024, 8:10 PM

#

That is even more cringe

fallow sky May 25, 2024, 8:10 PM

#

x)

#

and, if we fake the server?

#

by creating a fake plugin.yml redirecting to an empty class?

rigid saffron May 25, 2024, 8:11 PM

#

well, thought of thaz

#

Kinda cringe

fallow sky May 25, 2024, 8:11 PM

#

huh, it will be loaded...

#

so we won't be able to edit him

#

hmmm

rigid saffron May 25, 2024, 8:11 PM

#

We need a spigot expert

fallow sky May 25, 2024, 8:11 PM

#

yeah

#

md5

#

x)

rigid saffron May 25, 2024, 8:11 PM

#

Lol

fallow sky May 25, 2024, 8:12 PM

#

what the hell is that

rigid saffron May 25, 2024, 8:12 PM

#

Or maybe somebody else, frostalf or something

rigid saffron May 25, 2024, 8:12 PM

#

fallow sky what the hell is that

Bad path

#

Looks like your FilenameUtils is doing a linux format

fallow sky May 25, 2024, 8:12 PM

#

the / at the beginning is the problem?

fallow sky May 25, 2024, 8:13 PM

#

rigid saffron Looks like your FilenameUtils is doing a linux format

oh

#

but this will works on linux then?

rigid saffron May 25, 2024, 8:13 PM

#

Just do .endsWith(".jar")

fallow sky May 25, 2024, 8:13 PM

#

okay

#

where?

rigid saffron May 25, 2024, 8:13 PM

#

fallow sky there

^ here I think

fallow sky May 25, 2024, 8:13 PM

#

@rigid saffron this is the problem

#

Paths.get(cvn.getServer().getClass().getProtectionDomain().getCodeSource().getLocation().getPath()),```

rigid saffron May 25, 2024, 8:14 PM

#

Interesting

fallow sky May 25, 2024, 8:14 PM

#

let's try by adding .replaceFirst("/", "") 🤓

#

bruh

#

BRUH

#

what I have done

#

sueur~2

rigid saffron May 25, 2024, 8:16 PM

#

fallow sky ```java Paths.get(cvn.getServer().getClass().getProtectionDomain().getCodeSource...

Can you print the output without Paths.get and .getPath()

fallow sky May 25, 2024, 8:16 PM

#

yeah, sure

#

file:/C:/Users/paule/Documents/Serveurs/test-plugin-1.9.4/cache/patched_1.9.4.jar

#

@rigid saffron

rigid saffron May 25, 2024, 8:17 PM

#

try .replace("file:/", "") and then turn it into a Path

fallow sky May 25, 2024, 8:17 PM

#

bruh, here his what I get

📎 test-plugin-1.0-SNAPSHOT_-_remapped.jar

#

the code disappeared, and cvn-plugin.yml hasn't been replaced :/

rigid saffron May 25, 2024, 8:18 PM

#

Lol

#

Amazing

fallow sky May 25, 2024, 8:19 PM

#

still illegal char

#

the first one was working

rigid saffron May 25, 2024, 8:19 PM

#

Show outout

fallow sky May 25, 2024, 8:19 PM

#

/C:/Users/paule/Documents/Serveurs/test-plugin-1.9.4/cache/patched_1.9.4.jar

#

.replaceFirst("/", "") works "perfectly"

rigid saffron May 25, 2024, 8:19 PM

#

Show code

fallow sky May 25, 2024, 8:19 PM

#

Paths.get(cvn.getServer().getClass().getProtectionDomain().getCodeSource().getLocation().getPath().replaceFirst("/", ""))

rigid saffron May 25, 2024, 8:19 PM

#

Does it actually work

fallow sky May 25, 2024, 8:20 PM

#

and if I put both maybe?

rigid saffron May 25, 2024, 8:20 PM

#

Doubt it

fallow sky May 25, 2024, 8:20 PM

#

rigid saffron Does it actually work

I get this
#1243264378522959914 message

#

so it "works"

rigid saffron May 25, 2024, 8:20 PM

#

Weird

#

Let's continue tomorrow

fallow sky May 25, 2024, 8:20 PM

#

the problem is this

fallow sky May 25, 2024, 8:20 PM

#

rigid saffron Let's continue tomorrow

for you, not for me :)

#

see you tomorrow

rigid saffron May 25, 2024, 8:20 PM

#

Ok

#

Bye bye

fallow sky May 25, 2024, 8:20 PM

#

👋

#

the problem comes from when remapping

#

this path doesn't exist

#

that's why it doesn't work ?

#

(I'm asking myself)

#

oh

#

it's not the server

#

but wait

#

wtf

#

it's getting the patched file, so it should works?

#

bump

#

LOL

#

PAPER IS THE PROBLEM

#

I'll need to use paper as dependency to make some checks if the server is paper based

#

hope it will works, or I'll use reflection

#

basically, getServer#getClass#... is in cache/patched-version.jar

#

but we wants it as server.jar

#

I'll need to do some tricks

#

wtf

#

apache.commons >>>

#

a bit working

#

NO WAY

#

remapped, but not launched?

#

@rigid saffron @woven arrow @inland spoke 😎

#

yeah, many pings

#

but I'm happy 😄

woven arrow May 25, 2024, 8:55 PM

#

yoooo

#

that's rlly cool

#

wait is that mc 1.9.4 o_O

fallow sky May 25, 2024, 8:55 PM

#

yeah

#

it works on any version

woven arrow May 25, 2024, 8:56 PM

#

great!

fallow sky May 25, 2024, 8:56 PM

#

(logically)

fallow sky May 26, 2024, 12:05 AM

#

Actual system - theorically working versions (because test plugin is not using mappings in his code) :

1.20.6 ✅ (detected getServer class : versions\1.20.6\paper-1.20.6.jar) ASM : 9.3
1.20.4 ✅ (detected getServer class : versions\1.20.4\paper-1.20.4.jar) ASM : 9.3
1.16.5 ✅ (detected getServer class : cache\patched_1.16.5.jar) ASM : ??
1.14.4 ✅ (detected getServer class : cache\patched_1.14.4.jar) ASM : ??
1.13.2 ✅ (detected getServer class : cache\patched_1.13.2.jar) ASM : present
1.12.2 ✅ (detected getServer class : cache\patched_1.12.2.jar)
1.11.2 ✅ (detected getServer class : cache\patched_1.11.2.jar)
1.10.2 ✅ (detected getServer class : cache\patched_1.10.2.jar)
1.9.4 ✅ (detected getServer class : cache\patched_1.9.4.jar)
1.8.8 ✅ (detected getServer class : cache\patched_1.8.8.jar)

fallow sky May 26, 2024, 12:23 AM

#

we need to know what is different in this version

#

gn

woven arrow May 26, 2024, 4:40 AM

#

fallow sky Actual system - theorically working versions (because test plugin is not using m...

i think this will still be fine as most people either run 1.8 or 1.14.4+ so congrats

rigid saffron May 26, 2024, 5:52 AM

#

fallow sky Actual system - theorically working versions (because test plugin is not using m...

This is the place where it fucks up

Files.walkFileTree(fs.getPath("/"), new SimpleFileVisitor<Path>() {
                @Override
                public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
                    if (file.toString().endsWith(".class")) {
                        ClassInstance res = analyze(isInput, tags, srcPath, file);
                        if (res != null) ret.add(res);
                    }

                    return FileVisitResult.CONTINUE;
                }
            });```

#

(inside of the tiny remapper)

#

I'll inspect further

#

     ClassVisitor cv = new ClassVisitor(Opcodes.ASM9) {
            @Override
            public void visit(int version, int access, String name, String signature, String superName, String[] interfaces) {
                ret.init(name, version, mrjVersion, signature, superName, access, interfaces);
                super.visit(version, access, name, signature, superName, interfaces);
            }

            @Override
            public MethodVisitor visitMethod(int access, String name, String desc, String signature, String[] exceptions) {
                MemberInstance prev = ret.addMember(new MemberInstance(TrMember.MemberType.METHOD, ret, name, desc, access, ret.getMembers().size()));
                if (prev != null) throw new RuntimeException(String.format("duplicate method %s/%s%s in inputs", ret.getName(), name, desc));

                return super.visitMethod(access, name, desc, signature, exceptions);
            }

            @Override
            public FieldVisitor visitField(int access, String name, String desc, String signature, Object value) {
                MemberInstance prev = ret.addMember(new MemberInstance(TrMember.MemberType.FIELD, ret, name, desc, access, ret.getMembers().size()));
                if (prev != null) throw new RuntimeException(String.format("duplicate field %s/%s;;%s in inputs", ret.getName(), name, desc));

                return super.visitField(access, name, desc, signature, value);
            }
        };```

rigid saffron May 26, 2024, 5:56 AM

#

fallow sky Actual system - theorically working versions (because test plugin is not using m...

I thought it may be because of the java version, but why would 1.8 work then

#

I found an issue my googling the exception and this is the answer I found (two times on github and one time on stackoverflow)

Screenshot_2024-05-26-08-03-19-459_com.android.chrome-edit.jpg

rigid saffron May 26, 2024, 6:27 AM

#

Girls and boys, I found our issue

woven arrow May 26, 2024, 6:28 AM

#

what's the issue

rigid saffron May 26, 2024, 6:28 AM

#

Most likely asm version shit

Screenshot_2024-05-26-08-27-58-148_com.termux.jpg

woven arrow May 26, 2024, 6:28 AM

#

why did you do that on your phone

rigid saffron May 26, 2024, 6:28 AM

#

Can't test it, but who knows

rigid saffron May 26, 2024, 6:28 AM

#

woven arrow why did you do *that* on your phone

Why not

#

If I can do something without standing up, I will do it without standing up

woven arrow May 26, 2024, 6:29 AM

#

skull

rigid saffron May 26, 2024, 6:31 AM

#

📎 dependencies.txt

#

That's how the dependency tree looks

#

I wonder if just setting asm level to 8 instead of 9 would change anything

#

Actually, lemme build a 1.9.4 jar and see the asm version for that

#

Why is there no java 8 for termux

woven arrow May 26, 2024, 6:40 AM

#

rigid saffron Why is there no java 8 for termux

just get up dude

rigid saffron May 26, 2024, 6:41 AM

#

In a hour

rigid saffron May 26, 2024, 7:17 AM

#

Damn, I have posted about my question on two forums and I did not get a single answer or even a question overnight, like, literally nothing

rigid saffron May 26, 2024, 8:13 AM

#

IT WORKED

#

all the jars are here

#

it worked

#

this is amazing

#

who could've thought that Files.newOutputStream could be the imposter

#

huh it did not?

#

why are the jars empty

#

interesting

rigid saffron May 26, 2024, 8:44 AM

#

I'm confused to death

spiral onyx May 26, 2024, 8:57 AM

#

rigid saffron Damn, I have posted about my question on two forums and I did not get a single a...

People don't know what the fuck you are talking about lmao

rigid saffron May 26, 2024, 9:00 AM

#

spiral onyx People don't know what the fuck you are talking about lmao

I have fixed one issue but now I got another

#

please help me

spiral onyx May 26, 2024, 9:18 AM

#

Tell me what the issue is and I might be able to give you some intel but probably not

rigid saffron May 26, 2024, 9:23 AM

#

I wonder if my issue comes from the fact I'm doing some funky shits directly in the libs folder instead of doing stuff in the tmp folder and then moving to libs

#

lemme try

inland spoke May 26, 2024, 9:26 AM

#

Oh, an ASM issue? If you give me reproduction steps I can find the cause and a solution rather easily

rigid saffron May 26, 2024, 9:28 AM

#

the asm issue is @fallow sky's issue, I'm currently fighting gradle

fallow sky May 26, 2024, 9:42 AM

#

rigid saffron the asm issue is <@696076032133955635>'s issue, I'm currently fighting gradle

What do you mean ?

inland spoke May 26, 2024, 9:43 AM

#

okay I personally can't reproduce anything so I'll just assume that there is no issue.

rigid saffron May 26, 2024, 9:43 AM

#

fallow sky What do you mean ?

I suspect your issue could come from ASM version mismatch (it might be possible that minecraft has one version of ASM and tiny-remapper has another inside)

fallow sky May 26, 2024, 9:44 AM

#

rigid saffron I suspect your issue could come from ASM version mismatch (it might be possible ...

Oh I see

inland spoke May 26, 2024, 9:44 AM

#

ASM is being shaded into the plugin jar. Depending on the classloader that is a non-issue

fallow sky May 26, 2024, 9:44 AM

#

So we just need to change the ASM version of tinyremapper

#

I'll see that later

rigid saffron May 26, 2024, 9:45 AM

#

fallow sky So we just need to change the ASM version of tinyremapper

we could probably just not shadow ASM into tiny-remapper

#

my current issue is that class files suddenly go poof for no good reason

inland spoke May 26, 2024, 9:48 AM

#

rigid saffron we could probably just not shadow ASM into tiny-remapper

Not really, TR probably makes use of Opcodes.ASM9 (e.g. https://github.com/Cross-Version-NMS/tiny-remapper-dependency/blob/master/src/main/java/net/fabricmc/tinyremapper/extension/mixin/common/data/Constant.java#L24) where as older servers might only support ASM 5 - 7, so I suspect that won't work.

#

Instead, you might try to relocate ASM

fallow sky May 26, 2024, 9:48 AM

#

rigid saffron we could probably just not shadow ASM into tiny-remapper

Oh yeah

rigid saffron May 26, 2024, 9:48 AM

#

inland spoke Instead, you might try to relocate ASM

hmm

fallow sky May 26, 2024, 9:49 AM

#

inland spoke Instead, you might try to relocate ASM

Oh yeah

rigid saffron May 26, 2024, 9:49 AM

#

haven't had to deal with relocation in gradle yet

fallow sky May 26, 2024, 9:49 AM

#

We should see that, not very difficult shading or relocating

rigid saffron May 26, 2024, 9:49 AM

#

https://github.com/Cross-Version-NMS/tiny-remapper-dependency

GitHub

GitHub - Cross-Version-NMS/tiny-remapper-dependency: Tiny JAR remap...

Tiny JAR remapping tool. Contribute to Cross-Version-NMS/tiny-remapper-dependency development by creating an account on GitHub.

fallow sky May 26, 2024, 9:49 AM

#

rigid saffron haven't had to deal with relocation in gradle yet

I had

rigid saffron May 26, 2024, 9:49 AM

#

rigid saffron https://github.com/Cross-Version-NMS/tiny-remapper-dependency

do stuff here

inland spoke May 26, 2024, 9:49 AM

#

rigid saffron https://github.com/Cross-Version-NMS/tiny-remapper-dependency

I really don't see how it helps to fork TR tbh

fallow sky May 26, 2024, 9:50 AM

#

rigid saffron do stuff here

Yeah I'll see for that don't worry

rigid saffron May 26, 2024, 9:50 AM

#

inland spoke I really don't see how it helps to fork TR tbh

we'll just have a fork refactored to work with CVN just as we need

#

tr isn't a library by itself, that's why we turn it into one

fallow sky May 26, 2024, 9:50 AM

#

Instead, can any of you see the version of ASM between 1.8, 1.9, 1.13 and 1.14 ?

#

To see if the problem is the version

rigid saffron May 26, 2024, 9:51 AM

#

fallow sky Instead, can any of you see the version of ASM between 1.8, 1.9, 1.13 and 1.14 ?

1.19.4 uses 9.4 iirc

inland spoke May 26, 2024, 9:51 AM

#

TR is meant to be used as a library.
If you have performance concerns caused by additional I/O overhead, you might want to use something like my stianloader-remapper but really there is no need to refractor TR

rigid saffron May 26, 2024, 9:51 AM

#

inland spoke TR is meant to be used as a library. If you have performance concerns caused by ...

isn't TR a standalone application

inland spoke May 26, 2024, 9:52 AM

#

It's a library

rigid saffron May 26, 2024, 9:52 AM

#

do all libraries have a Main class

inland spoke May 26, 2024, 9:52 AM

#

It can also be used as a standalone application. Quite a few libs have a main class in fact

inland spoke May 26, 2024, 9:53 AM

#

inland spoke It's a library

I know that as I've used it for a very long time in gslStarplane (until I switched to stianloader-remapper + micromixin-remapper)

rigid saffron May 26, 2024, 9:54 AM

#

but well, I will definitely just clean up the everything in the fork I made (configure gradle for it to relocate asm and remove a few unused by us classes)

inland spoke May 26, 2024, 9:54 AM

#

And the only time I had to use a fork of TR is https://github.com/FabricMC/tiny-remapper/pull/109 - which would be a non-issue in spigot world either way

fallow sky May 26, 2024, 10:09 AM

#

okay let's work on that

#

#

seemsgood

#

let's clone the plugin and tiny remapper

rigid saffron May 26, 2024, 10:11 AM

#

I haven't pushed the plugin yet

fallow sky May 26, 2024, 10:11 AM

#

huh

rigid saffron May 26, 2024, 10:11 AM

#

Kinda forgor

fallow sky May 26, 2024, 10:11 AM

#

x) I see that

fallow sky May 26, 2024, 10:11 AM

#

rigid saffron I haven't pushed the plugin yet

can you also create a repo for a test plugin?

rigid saffron May 26, 2024, 10:12 AM

#

fallow sky can you also create a repo for a test plugin?

Give me a few minutes

#

oh wait no I can't rn

fallow sky May 26, 2024, 10:12 AM

#

okay np

#

where is asm located in server.jar ?

rigid saffron May 26, 2024, 10:14 AM

#

In the same place where it is located in any jar

fallow sky May 26, 2024, 10:14 AM

#

rigid saffron In the same place where it is located in any jar

can't find it

#

oh

rigid saffron May 26, 2024, 10:14 AM

#

But well, you don't even need to find it

fallow sky May 26, 2024, 10:14 AM

#

in 1.20.4 I've got it

fallow sky May 26, 2024, 10:14 AM

#

rigid saffron But well, you don't even need to find it

I need to check the version

rigid saffron May 26, 2024, 10:15 AM

#

Just install it into a gradle project and run gradlew dependencies

#

It'll show you all dependencies

fallow sky May 26, 2024, 10:15 AM

#

hm I could

rigid saffron May 26, 2024, 10:15 AM

#

The best idea would be to just simply relocate asm in tr and not struggle with random shit

fallow sky May 26, 2024, 10:16 AM

#

rigid saffron The best idea would be to just simply relocate asm in tr and not struggle with r...

yeah but I need a lot of informations

rigid saffron May 26, 2024, 10:16 AM

#

Nah, just change the package and enjoy

#

There should be some gradle relocation plugin I'm sure

fallow sky May 26, 2024, 10:17 AM

#

yeah

rigid saffron May 26, 2024, 10:17 AM

#

shadowJar even got a relocate feature apparently?

#

shadowJar {
relocate 'com.myCompany.project.event', 'com.myCompany.relocated.project.event'
}

fallow sky May 26, 2024, 10:17 AM

#

I think so

fallow sky May 26, 2024, 10:17 AM

#

rigid saffron shadowJar { relocate 'com.myCompany.project.event', 'com.myCompany.relocated...

I'll do that

#

I just want to finish that

#

when thinking of it, no

#

let's do relocating directly

spiral onyx May 26, 2024, 10:18 AM

#

paulem this is quite random but your english is really good

#

i just wanted to point it out

#

lol

fallow sky May 26, 2024, 10:18 AM

#

thank you 😄

#

I really like english

#

Github Desktop is so cool wow

#

it worked 😎

#

📎 tiny-remapper-0.10.3local-fat.jar

#

who can test me 😎

#

so, now it should works on any version?

rigid saffron May 26, 2024, 10:24 AM

#

¯_(ツ)_/¯

#

We should make some software that would casually build and then run all versions of minecraft

fallow sky May 26, 2024, 10:24 AM

#

yeah

#

but not enough time for now

#

x)

#

oh, maybe I was using the wrong dependency...

rigid saffron May 26, 2024, 10:25 AM

#

Wdym

fallow sky May 26, 2024, 10:25 AM

#

not using the local-fat

#

let me cook...

#

perfect

#

here I go

#

LET'S FUCKING GOOOOOO

#

@rigid saffron @inland spoke @woven arrow
YAHOUUUUU

#

perfect

#

working on 1.13.2 too

rigid saffron May 26, 2024, 10:35 AM

#

https://hub.spigotmc.org/versions/ here is the repo with versions, we can use that to write the testing software

fallow sky May 26, 2024, 10:35 AM

#

yeah

rigid saffron May 26, 2024, 10:36 AM

#

If you don't want to, I can write it later

fallow sky May 26, 2024, 10:36 AM

#

fetching from jenkins, hummm

#

I'll try to do that, focus on the plugin x)

#

I'm pushing the patch on github too

#

CVN and tiny remapper have been updated

rigid saffron May 26, 2024, 10:37 AM

#

👍

fallow sky May 26, 2024, 10:38 AM

#

there was an error with commons io in certain versions, but I fixed it by implementing apache commons, I think I'll made something more optimized than that later

woven arrow May 26, 2024, 10:38 AM

#

fallow sky <@637908289014988800> <@755527678433427546> <@539112187160166401> YAHOUUUUU

yoooooo that's really cool

fallow sky May 26, 2024, 10:38 AM

#

woven arrow yoooooo that's really cool

yeah

#

we still have the problem with those "huh, invalid plugin.yml"

rigid saffron May 26, 2024, 10:39 AM

#

fallow sky we still have the problem with those "huh, invalid plugin.yml"

We have three ways:

(The easiest) Tell the users to ignore it
Make a fake plugin.yml and some dummy class that will just disable the plugin
(Please do not) Do funny stuffs to modify the server jar

#

Oh, and well

#

Use a different plugins directory

#

The best is either 1 or 2

fallow sky May 26, 2024, 10:40 AM

#

rigid saffron Use a different plugins directory

like you said, that's cringe and not efficient

fallow sky May 26, 2024, 10:41 AM

#

rigid saffron We have three ways: 1. (The easiest) Tell the users to ignore it 2. Make a fake ...

1 is bad, 3 is bad

rigid saffron May 26, 2024, 10:41 AM

#

Everything here is bad

woven arrow May 26, 2024, 10:41 AM

#

rigid saffron We have three ways: 1. (The easiest) Tell the users to ignore it 2. Make a fake ...

cvn-mixins

fallow sky May 26, 2024, 10:41 AM

#

so the solution 2, I make it now

fallow sky May 26, 2024, 10:41 AM

#

woven arrow 4. cvn-mixins

https://tenor.com/xGM9.gif

Tenor

rigid saffron May 26, 2024, 10:41 AM

#

fallow sky so the solution 2, I make it now

Solution 2 would be a gradle plugin thing I think

fallow sky May 26, 2024, 10:41 AM

#

rigid saffron Solution 2 would be a gradle plugin thing I think

yeah

#

I forgot about that x)

rigid saffron May 26, 2024, 10:41 AM

#

I wonder if plugins can set their main class to be a class from another plugin

#

Can you try it?

fallow sky May 26, 2024, 10:42 AM

#

huh

#

this would be so wtf

#

I can do that

rigid saffron May 26, 2024, 10:42 AM

#

Make some class in cvn called DummyPlugin, extend JavaPlugin, make it just disable itself, then make another plugin and set the main class to io.github.cvn.DummyPlugin

fallow sky May 26, 2024, 10:43 AM

#

hmm

#

I don't know if I can edit the content on a file in a zip with my actual system

rigid saffron May 26, 2024, 10:44 AM

#

fallow sky I don't know if I can edit the content on a file in a zip with my actual system

Unarchive to some temp folder, do changes, archive, replace old zip with new, delete temp folder

#

I'm pretty sure that's the way even WinRAR does it

fallow sky May 26, 2024, 10:45 AM

#

yeah

#

7zip too

#

best plugin in my entire life

rigid saffron May 26, 2024, 10:46 AM

#

Lol

fallow sky May 26, 2024, 10:46 AM

#

I'm here in a few minutes

rigid saffron May 26, 2024, 10:46 AM

#

getServer().getPluginManager().disablePlugin(this);

fallow sky May 26, 2024, 10:51 AM

#

yeah

rigid saffron May 26, 2024, 10:54 AM

#

Did it work tho

fallow sky May 26, 2024, 10:54 AM

#

rigid saffron Did it work tho

what?

#

the plugin.yml main class changer?

rigid saffron May 26, 2024, 10:54 AM

#

Ye

fallow sky May 26, 2024, 10:54 AM

#

I'm actually copying some methods of apache commons io to lightweight the plugin

rigid saffron May 26, 2024, 10:57 AM

#

Also, we need to talk about the plugins license

fallow sky May 26, 2024, 10:57 AM

#

yeah ?

rigid saffron May 26, 2024, 10:57 AM

#

I say LGPL because we have a LGPL dependency

#

You okay with that?

fallow sky May 26, 2024, 10:57 AM

#

why not

#

idk I'm not really familiar with licenses

#

LGPL looks good for me

#

x)

rigid saffron May 26, 2024, 10:58 AM

#

👍

fallow sky May 26, 2024, 10:58 AM

#

one of my plugin is LGPL

#

so it's good for me 👍

#

(you can download it here, yeah that's an ad : https://www.spigotmc.org/resources/better-mending.112248/)

#

april fool

rigid saffron May 26, 2024, 10:59 AM

#

Lol

#

We don't even shade spigot

fallow sky May 26, 2024, 11:00 AM

#

no x)

#

bruh there is nothing in org.spigotmc

#

the biggest thing is bukkit, I forgot about that x)

rigid saffron May 26, 2024, 11:00 AM

#

Lol

inland spoke May 26, 2024, 11:01 AM

#

setting the shadow jar archiveClassifier to empty only makes sense if the regular jar has a non-empty archiveClassifier

#

otherwise performance bye-bye

fallow sky May 26, 2024, 11:01 AM

#

inland spoke setting the shadow jar archiveClassifier to empty only makes sense if the regula...

really ?

inland spoke May 26, 2024, 11:02 AM

#

I mean that is how caching works

fallow sky May 26, 2024, 11:02 AM

#

well, it generates me plugin.jar and plugin-all.jar so I wanted to "fix" that

inland spoke May 26, 2024, 11:03 AM

#

You could of course dunk the regular ("slim") jar in some random dir, but that is more non-standard

fallow sky May 26, 2024, 11:03 AM

#

and for tiny remapper, we don't really have choice because it doesn't choose tinyremapper-fat by default

fallow sky May 26, 2024, 11:03 AM

#

inland spoke You could of course dunk the regular ("slim") jar in some random dir, but that i...

hmm

inland spoke May 26, 2024, 11:03 AM

#

the flat classifier shouldn't be used as a dependency either way

fallow sky May 26, 2024, 11:04 AM

#

inland spoke the flat classifier shouldn't be used as a dependency either way

so how can I use tinyremapper-fat.jar as dependency?

inland spoke May 26, 2024, 11:04 AM

#

why would you need to? Doing so completely kills the purpose of using dependency management tools in the first place

fallow sky May 26, 2024, 11:05 AM

#

inland spoke why would you need to? Doing so completely kills the purpose of using dependency...

because we shaded asm

#

so I need asm

#

or should I shade asm directly from CVN ?

inland spoke May 26, 2024, 11:05 AM

#

yeah, you shade dependencies as late in the build pipeline as possible

fallow sky May 26, 2024, 11:05 AM

#

okay

inland spoke May 26, 2024, 11:06 AM

#

doing it earlier would result in severe issues with dependency management tools - leading to duplicate classes, transitive dependencies that shouldn't exist but do (or vice-versa), and more

fallow sky May 26, 2024, 11:06 AM

#

looks like it's better

#

📎 CVN-1.0-SNAPSHOT-all.jar

#

should I relocate everything we shade ?

rigid saffron May 26, 2024, 11:08 AM

#

Only the things that want relocation

fallow sky May 26, 2024, 11:08 AM

#

okay

#

so only the thing that might be already present : ASM

inland spoke May 26, 2024, 11:08 AM

#

fallow sky should I relocate everything we shade ?

yes, not doing so could cause compatibility issues when the classloader is poorly written

fallow sky May 26, 2024, 11:08 AM

#

we poorly write 😢

#

x)

#

okay it's on github

inland spoke May 26, 2024, 11:10 AM

#

we don't have control over the classloader (the classloader being bukkit).
And I haven't been doing bukkit in a long while and thus don't know how good it's classloader is.

rigid saffron May 26, 2024, 11:10 AM

#

inland spoke we don't have control over the classloader (the classloader being bukkit). And I...

definitely not the best

fallow sky May 26, 2024, 11:10 AM

#

hum

fallow sky May 26, 2024, 11:10 AM

#

rigid saffron definitely not the best

looks like

rigid saffron May 26, 2024, 11:10 AM

#

I've seen it do weird shit before

fallow sky May 26, 2024, 11:10 AM

#

"huh you don't have plugin.yml"

#

"hello I'm bukkit I'm dumb"

rigid saffron May 26, 2024, 11:11 AM

#

Lol

fallow sky May 26, 2024, 11:11 AM

#

@woven arrow there is a comment dedicated to you in CVN 😎

inland spoke May 26, 2024, 11:11 AM

#

I mean writing classloaders is really hard - even my classloaders has serious faults at times. It's pretty much a pain to debug edge cases and when you encounter them you often tend to just work around them instead of fixing them outright

rigid saffron May 26, 2024, 11:12 AM

#

inland spoke I mean writing classloaders is really hard - even my classloaders has serious fa...

Thank god CVN doesn't need a classloader

fallow sky May 26, 2024, 11:12 AM

#

yeah x)

#

let's do the tricky thing about plugin.yml

rigid saffron May 26, 2024, 11:12 AM

#

Yeah, I'm very curious on whether the main class thing works or not

fallow sky May 26, 2024, 11:13 AM

#

it may not work

#

if the plugin is loaded before CVN

rigid saffron May 26, 2024, 11:13 AM

#

Bukkit when it has to load 7 plugins with the exact same main class be like: ???

fallow sky May 26, 2024, 11:13 AM

#

oh yeah maybe that too

rigid saffron May 26, 2024, 11:13 AM

#

fallow sky if the plugin is loaded before CVN

Just make it depend

fallow sky May 26, 2024, 11:13 AM

#

rigid saffron Just make it depend

yeah

rigid saffron May 26, 2024, 11:13 AM

#

We will just inject a dummy plugin.yml into the plugin anyways and maybe even let the user write their stuff in the normak plugin.yml and just rename it on compilation

fallow sky May 26, 2024, 11:14 AM

#

"Make some class in cvn called DummyPlugin, extend JavaPlugin, make it just disable itself, then make another plugin and set the main class to io.github.cvn.DummyPlugin"
"Unarchive to some temp folder, do changes, archive, replace old zip with new, delete temp folder"

#

(bump)

fallow sky May 26, 2024, 11:14 AM

#

rigid saffron We will just inject a dummy plugin.yml into the plugin anyways and maybe even le...

yeah

woven arrow May 26, 2024, 11:14 AM

#

fallow sky <@539112187160166401> there is a comment dedicated to you in CVN 😎

yoo

#

what does it say

fallow sky May 26, 2024, 11:14 AM

#

woven arrow what does it say

search 😉

woven arrow May 26, 2024, 11:14 AM

#

oh god

#

what's the org name

fallow sky May 26, 2024, 11:15 AM

#

https://github.com/Cross-Version-NMS/CVN

GitHub

GitHub - Cross-Version-NMS/CVN: The main plugin of the CVN project

The main plugin of the CVN project. Contribute to Cross-Version-NMS/CVN development by creating an account on GitHub.

#

the comment is in this x)

#

it's YOUR line 🫡

#

not OUR

woven arrow May 26, 2024, 11:15 AM

#

😭

fallow sky May 26, 2024, 11:16 AM

#

:)

rigid saffron May 26, 2024, 11:16 AM

#

Lol

fallow sky May 26, 2024, 11:22 AM

#

doc talks about facts

rigid saffron May 26, 2024, 11:23 AM

#

Yes

fallow sky May 26, 2024, 11:24 AM

#

wait

#

I'm lost in what I should make

rigid saffron May 26, 2024, 11:24 AM

#

A plugin with a plugin.yml that leads to the class of another plugin?

fallow sky May 26, 2024, 11:24 AM

#

yeah

#

thanks x)

#

it's time to

#

?tryandsee

distant plankBOT May 26, 2024, 11:26 AM

#

https://tryitands.ee/

rigid saffron May 26, 2024, 11:26 AM

#

Lol

#

?tias

#

?tas

distant plankBOT May 26, 2024, 11:26 AM

#

https://tryitands.ee/

rigid saffron May 26, 2024, 11:26 AM

#

shorter

fallow sky May 26, 2024, 11:26 AM

#

yeah

#

shorter = better

#

let's rename CVN to C

rigid saffron May 26, 2024, 11:27 AM

#

Lol

fallow sky May 26, 2024, 11:27 AM

#

huh, looks like it already exists

rigid saffron May 26, 2024, 11:27 AM

#

fallow sky shorter = better

Besides when you are choosing between getBetterPlugin() and getPlugin()

fallow sky May 26, 2024, 11:27 AM

#

rigid saffron Besides when you are choosing between getBetterPlugin() and getPlugin()

hummm

#

it depends of context 🤓

rigid saffron May 26, 2024, 11:28 AM

#

Another case is ZBLL vs Зяблик

fallow sky May 26, 2024, 11:28 AM

#

hummmm

rigid saffron May 26, 2024, 11:28 AM

#

@spiral onyx right Зяблик?

fallow sky May 26, 2024, 11:28 AM

#

one is more readable for the west world

rigid saffron May 26, 2024, 11:29 AM

#

West world doesn't matter fr

fallow sky May 26, 2024, 11:29 AM

#

my grand father says the same for the east world...

#

strange 🤔

spiral onyx May 26, 2024, 11:31 AM

#

rigid saffron <@532643399652868106> right Зяблик?

yes :3

fallow sky May 26, 2024, 11:33 AM

#

@rigid saffron looks like it doesn't work

#

https://paste.md-5.net/oyewunomov.sql

rigid saffron May 26, 2024, 11:34 AM

#

Then we need to include it in all plugins, oh what a pain in the ass

fallow sky May 26, 2024, 11:34 AM

#

yeah

#

I thought of that, so let's do that?

rigid saffron May 26, 2024, 11:35 AM

#

Another addition to the gradle plugin

fallow sky May 26, 2024, 11:35 AM

#

we'll make it smoother with the gradle plugin so not really a problem, right?

fallow sky May 26, 2024, 11:35 AM

#

rigid saffron Another addition to the gradle plugin

gradle pain-in

rigid saffron May 26, 2024, 11:35 AM

#

it's like a drive-in, just a pain-in

fallow sky May 26, 2024, 11:35 AM

#

x)

woven arrow May 26, 2024, 11:36 AM

#

fallow sky https://paste.md-5.net/oyewunomov.sql

paper...?

#

why paper 1.20.6

#

paper remaps to mojmapped

fallow sky May 26, 2024, 11:36 AM

#

woven arrow paper...?

yeah, because if it works on paper, it works on spigot

fallow sky May 26, 2024, 11:36 AM

#

woven arrow paper remaps to mojmapped

yeah

#

I know

rigid saffron May 26, 2024, 11:36 AM

#

fallow sky yeah, because if it works on paper, it works on spigot

DAMN

woven arrow May 26, 2024, 11:36 AM

#

that will break stuff

fallow sky May 26, 2024, 11:36 AM

#

that can be another little problem

rigid saffron May 26, 2024, 11:36 AM

#

LEGENDARY

fallow sky May 26, 2024, 11:36 AM

#

x)

#

on spigot***

#

my bad

woven arrow May 26, 2024, 11:37 AM

#

!!

woven arrow May 26, 2024, 11:37 AM

#

fallow sky yeah, because if it works on paper, it works on spigot

it wont for 20.5+

fallow sky May 26, 2024, 11:37 AM

#

incredible

fallow sky May 26, 2024, 11:37 AM

#

woven arrow it wont for 20.5+

yeah

rigid saffron May 26, 2024, 11:37 AM

#

fallow sky incredible

Lmfao

fallow sky May 26, 2024, 11:37 AM

#

but @rigid saffron we can easily make intermediary -> mojmaps ?

#

oh damn

rigid saffron May 26, 2024, 11:38 AM

#

I'm thinking we'll rename all the plugins in the plugin.yml to CVNDummyPlugin-{uuid} so it doesn't get confusing why a plugin is loading, unloading and loading again

rigid saffron May 26, 2024, 11:38 AM

#

fallow sky but <@637908289014988800> we can easily make intermediary -> mojmaps ?

Gonna be a bit painful ig

#

Idk where to get the mojmaps from tbh

fallow sky May 26, 2024, 11:38 AM

#

rigid saffron I'm thinking we'll rename all the plugins in the plugin.yml to CVNDummyPlugin-{u...

yeah

#

there is a problem

woven arrow May 26, 2024, 11:39 AM

#

you're not allowed to publish mojmaps iirc

rigid saffron May 26, 2024, 11:39 AM

#

woven arrow you're not allowed to publish mojmaps iirc

We won't

fallow sky May 26, 2024, 11:40 AM

#

it doesn't remap anymore :/

rigid saffron May 26, 2024, 11:40 AM

#

Lol

#

Amazing /s

woven arrow May 26, 2024, 11:41 AM

#

mojank

fallow sky May 26, 2024, 11:41 AM

#

I'M DUMB

#

or maybe not ?

#

no I'm dumb

#

see by yourself

#

so it's a PluginType.NONE

#

I need to put a condition if both are true

#

perfectly

#

not working

fallow sky May 26, 2024, 11:44 AM

#

rigid saffron I'm thinking we'll rename all the plugins in the plugin.yml to CVNDummyPlugin-{u...

so I need to edit like you said

#

seemsgood

#

UUID pluginUuid = UUID.randomUUID();

String folderPath = plugin.getDataFolder().getAbsolutePath() + "/temp";
Files.createDirectories(Paths.get(folderPath));

// Edit from cvn-plugin.yml to plugin.yml
ZipFile zipFile = new ZipFile(remappedPlugin);
zipFile.removeFile("plugin.yml");
zipFile.renameFile("cvn-plugin.yml", "plugin.yml");

File tempPlugin = new File(folderPath + "/cvn-" + pluginUuid +".yml");

zipFile.extractFile("plugin.yml", tempPlugin.getAbsolutePath());

YamlConfiguration yamlConfiguration = YamlConfiguration.loadConfiguration(tempPlugin);

yamlConfiguration.set("name", "CVNDummyPlugin-" + pluginUuid);```

#

lol

#

I forgot to apply to the remapped jar

#

and to call my method too x)

fallow sky May 26, 2024, 11:52 AM

#

fallow sky ```java UUID pluginUuid = UUID.randomUUID(); String folderPath = plugin.getData...

not good 👎

rigid saffron May 26, 2024, 11:54 AM

#

Did something go wrong

fallow sky May 26, 2024, 11:54 AM

#

yeah, because I don't know how to write code

#

and to write in english too lol

#

partially working

#

I need to go

rigid saffron May 26, 2024, 11:58 AM

#

I'll have to leave in half a hour

#

So ngl, we all are fucked

woven arrow May 26, 2024, 12:03 PM

#

i might be able to help with sth

#

idk

#

i have the next two days off as well

rigid saffron May 26, 2024, 12:07 PM

#

holy fuck I just fixed the gradle plugin somehow

#

Finished remapping jars. Jar:
Intermediary mapped (to be used with CVN): NMSTestProject-1.0.jar
Official/Obfuscated (to be used like normal): NMSTestProject-1.0-official.jar
Original (Unmapped): NMSTestProject-1.0-original.jar

fallow sky May 26, 2024, 12:09 PM

#

perfect

fallow sky May 26, 2024, 12:09 PM

#

rigid saffron So ngl, we all are fucked

no problem

#

I'll work on CVN this afternoon

#

just, please, @rigid saffron PUSH ON GITHUUUUUUB

#

🙏

rigid saffron May 26, 2024, 12:09 PM

#

yes

#

sec

fallow sky May 26, 2024, 12:09 PM

#

okay 👍

rigid saffron May 26, 2024, 12:20 PM

#

._.

fallow sky May 26, 2024, 12:20 PM

#

wat

rigid saffron May 26, 2024, 12:20 PM

#

I'm unable to push

fallow sky May 26, 2024, 12:20 PM

#

use github desktop

fallow sky May 26, 2024, 12:20 PM

#

rigid saffron I'm unable to push

can you send the source code here ?

rigid saffron May 26, 2024, 12:21 PM

#

sec

fallow sky May 26, 2024, 12:21 PM

#

okay

rigid saffron May 26, 2024, 12:21 PM

#

here

📎 GNI-Remapper.zip

fallow sky May 26, 2024, 12:22 PM

#

thanks

rigid saffron May 26, 2024, 12:22 PM

#

the thing is a bit messy, I've written everything in one class, but it works

fallow sky May 26, 2024, 12:22 PM

#

okay

#

I'm pushing for you

rigid saffron May 26, 2024, 12:23 PM

#

oh btw, this is the plugin that I tested with

📎 NMSTestProject.zip

fallow sky May 26, 2024, 12:24 PM

#

okay

#

thanks

#

I'll push everything

#

you'll just have to clone the repo and you'll be able to push

rigid saffron May 26, 2024, 12:24 PM

#

but make a seperate repo for the test plugin

fallow sky May 26, 2024, 12:24 PM

#

yeah for sure

rigid saffron May 26, 2024, 12:24 PM

#

fallow sky you'll just have to clone the repo and you'll be able to push

👍

#

interesting

#

well, I gtg

#

bye

fallow sky May 26, 2024, 12:26 PM

#

bye

woven arrow May 26, 2024, 12:27 PM

#

rigid saffron 👍

do it in intellij with github logged in if possible

fallow sky May 26, 2024, 12:28 PM

#

woven arrow do it in intellij with github logged in if possible

yeah, but the best is clearly github desktop

#

rigid saffron May 26, 2024, 12:28 PM

#

I got a few mins more

fallow sky May 26, 2024, 12:28 PM

#

oh perfect

woven arrow May 26, 2024, 12:28 PM

#

fallow sky yeah, but the best is clearly github desktop

i just use gh cli or intellij 🤷

rigid saffron May 26, 2024, 12:28 PM

#

woven arrow do it in intellij with github logged in if possible

I pushed in IJ with being logged into gh

woven arrow May 26, 2024, 12:28 PM

#

should work then 🤷

rigid saffron May 26, 2024, 12:28 PM

#

It denied access

#

Might add a token later

#

I used to have one added but it vanished

woven arrow May 26, 2024, 12:29 PM

#

yeah that's the issue then

#

i just use the gh cli to log in git

fallow sky May 26, 2024, 12:29 PM

#

it's live
https://github.com/Cross-Version-NMS/CVN-test-plugin/tree/main

woven arrow May 26, 2024, 12:29 PM

#

and then i can also just git clnoe

fallow sky May 26, 2024, 12:29 PM

#

this too
https://github.com/Cross-Version-NMS/CVN-remapper-plugin

fallow sky May 26, 2024, 12:30 PM

#

woven arrow and then i can also just git clnoe

yeah

woven arrow May 26, 2024, 12:30 PM

#

do you need help with anything

#

i'm free rn

fallow sky May 26, 2024, 12:30 PM

#

humm I don't think so

#

for now I'm just pushing and testing

#

if you want to make the mass server tester, maybe 🤷

#

downloading all versions of spigot, and testing if the plugin works, and getting the result

rigid saffron May 26, 2024, 12:32 PM

#

Damn this is great

#

We only started 2 days ago and we already have an usable result

fallow sky May 26, 2024, 12:32 PM

#

yeah x)

rigid saffron May 26, 2024, 12:32 PM

#

Definitely not the final result, but usable

fallow sky May 26, 2024, 12:33 PM

#

yeah for sure

#

partially usable, idk if my code now works

#

not working

#

📎 message.txt

rigid saffron May 26, 2024, 12:34 PM

#

The next thing I'll do will most likely be either the maven plugin or the mass tester

fallow sky May 26, 2024, 12:34 PM

#

rigid saffron The next thing I'll do will most likely be either the maven plugin or the mass t...

yeah

rigid saffron May 26, 2024, 12:34 PM

#

fallow sky

Hmm, where code

woven arrow May 26, 2024, 12:39 PM

#

question

#

why are we logging to stdout and not bukkit logger

#

ohh that was gradle nvm

rigid saffron May 26, 2024, 12:40 PM

#

Lol

woven arrow May 26, 2024, 12:41 PM

#

bukkit logger in gradle, ah yes

rigid saffron May 26, 2024, 12:41 PM

#

Ideal

#

getting the bukkit logger when there is no bukkit is a 200 iq move

woven arrow May 26, 2024, 12:41 PM

#

i might be the thinker

rigid saffron May 26, 2024, 12:41 PM

#

Also, why are you inspecting code again

woven arrow May 26, 2024, 12:41 PM

#

i cloned everything

rigid saffron May 26, 2024, 12:42 PM

#

why

woven arrow May 26, 2024, 12:42 PM

#

i was hoping i could help with something later today

#

bc bored

rigid saffron May 26, 2024, 12:42 PM

#

Ah

#

Either make the thing that downloads buildtools, gets all versions from https://hub.spigotmc.org/versions/ (that are actual mc versions), takes all files from a folder and setups servers for all versions to test whether things work

#

Or

#

Clean up our already existing code

woven arrow May 26, 2024, 12:44 PM

#

rigid saffron Either make the thing that downloads buildtools, gets all versions from <https:/...

so this is just a script that downloads everything and sets up servers?

rigid saffron May 26, 2024, 12:44 PM

#

woven arrow so this is just a script that downloads everything and sets up servers?

Yeah, and then it runs them and tells us things

woven arrow May 26, 2024, 12:44 PM

#

can i do it in kotlin

rigid saffron May 26, 2024, 12:45 PM

#

I thought of giving it a folder where you put stuff like the plugins folder, eula.txt, server.properties and it would copy it to all servers

rigid saffron May 26, 2024, 12:45 PM

#

woven arrow can i do it in kotlin

Sure

woven arrow May 26, 2024, 12:45 PM

#

yay

#

i'll start later

#

gets all versions from https://hub.spigotmc.org/versions/ (that are actual mc versions)
wtf are these other things

rigid saffron May 26, 2024, 12:45 PM

#

They are kinda like experimental builds or something

woven arrow May 26, 2024, 12:46 PM

#

so 1.8.3-latest?

rigid saffron May 26, 2024, 12:46 PM

#

You can check whether it's an actual version by just checking whether it has more than one dot in the name

rigid saffron May 26, 2024, 12:46 PM

#

woven arrow so 1.8.3-latest?

Ye

woven arrow May 26, 2024, 12:46 PM

#

👍

#

okay but does it download it from jenkins or sth

rigid saffron May 26, 2024, 12:47 PM

#

Nah, it just runs buildtools

woven arrow May 26, 2024, 12:47 PM

#

bc it says there's a jenkins id

#

oh god

#

that will take a while but sure

rigid saffron May 26, 2024, 12:47 PM

#

yeah lol

#

A bit resource intensive but worth it

#

You'll also have to make it give all servers a different port because concurrency

woven arrow May 26, 2024, 12:47 PM

#

~~time to make it in bend~~

rigid saffron May 26, 2024, 12:48 PM

#

in what

woven arrow May 26, 2024, 12:48 PM

#

bend

#

that concurrent gpu lang thing

rigid saffron May 26, 2024, 12:48 PM

#

Never heard of it

#

I am very deep in java, can't get out this comfort zone, alright

fallow sky May 26, 2024, 1:39 PM

#

woven arrow why are we logging to stdout and not bukkit logger

it's spigot

#

just it was more efficient using System.out.println for debugging instead of instancing my main class and getting logger...

#

@rigid saffron don't forget to fetch the github branch before remodifying your code !!

#

because I renamed the gradle plugin to CVN

#

perfect remapping

#

it didn't remapped

#

it's almost working

#

basically, remapping using tinyremapper in CVN isn't working...

#

we're almost there

rigid saffron May 26, 2024, 2:02 PM

#

fallow sky basically, remapping using tinyremapper in CVN isn't working...

Show code

fallow sky May 26, 2024, 2:02 PM

#

/**
 * Takes in an intermediary mapped jar and remaps it to an official mapped jar (an obfuscated one).
 * @param jarFile       The jar file to remap
 * @param resultJarFile The file to save the remapped jar to
 */
public void remapJarFromIntermediary(Path classpath, File jarFile, File resultJarFile) {
    File mappingFile = plugin.getMappingFile();

    if(mappingFile == null) throw new IllegalStateException("Could not find mapping file !");

    TinyRemapper remapper = TinyRemapper.newRemapper()
            .withMappings(
                    TinyUtils.createTinyMappingProvider(
                            mappingFile.toPath(),
                            Namespace.INTERMEDIARY.getNamespaceName(), // "intermediary"
                            Namespace.OBFUSCATED.getNamespaceName() // "official"
                    )
            ).build();

    try (OutputConsumerPath outputConsumer = new OutputConsumerPath.Builder(resultJarFile.toPath()).build()) {
        outputConsumer.addNonClassFiles(jarFile.toPath(), NonClassCopyMode.FIX_META_INF, remapper);

        remapper.readInputs(jarFile.toPath());
        remapper.readClassPath(classpath);

        remapper.apply(outputConsumer);
    } catch (IOException e) {
        throw new RuntimeException(e);
    } finally {
        remapper.finish();
    }
}```

rigid saffron May 26, 2024, 2:02 PM

#

I think I might have a free minute

rigid saffron May 26, 2024, 2:03 PM

#

fallow sky ```java /** * Takes in an intermediary mapped jar and remaps it to an official ...

Have you decompiled the result jar

#

To see

fallow sky May 26, 2024, 2:03 PM

#

rigid saffron Have you decompiled the result jar

yeah

fallow sky May 26, 2024, 2:03 PM

#

fallow sky perfect remapping

here

#

it's still in intermediary..

rigid saffron May 26, 2024, 2:04 PM

#

Ah

#

Any exceptions?

#

Tried debugging?

fallow sky May 26, 2024, 2:04 PM

#

well, the server saying that he doesn't know MinecraftServer

#

java.lang.RuntimeException: org.bukkit.plugin.InvalidPluginException: java.lang.NoClassDefFoundError: net/minecraft/server/MinecraftServer

fallow sky May 26, 2024, 2:04 PM

#

rigid saffron Tried debugging?

debugging what ?

rigid saffron May 26, 2024, 2:04 PM

#

The remapping

fallow sky May 26, 2024, 2:05 PM

#

well no

#

idk how to debug TwT

#

only with println

rigid saffron May 26, 2024, 2:05 PM

#

Just add sysouts

fallow sky May 26, 2024, 2:05 PM

#

yeah

#

huh

#

oh I'm dumb

#

wait I forgot inverting

#

oh no

#

it was already switched

#

so if I re-switch ?

#

not working too

#

@rigid saffron any idea ?

#

wait

#

that is no sense

#

you told me to use the method to remap from intermediary, instead of using the one to remap to obfuscate

#

but we need obfuscate here

rigid saffron May 26, 2024, 2:12 PM

#

No

fallow sky May 26, 2024, 2:12 PM

#

no ?

rigid saffron May 26, 2024, 2:12 PM

#

The one to obfuscate goes from mojang to obfuscated

#

The one from intermediary goes from intermediary to obfuscated

fallow sky May 26, 2024, 2:12 PM

#

oh

fallow sky May 26, 2024, 2:13 PM

#

rigid saffron The one to obfuscate goes from mojang to obfuscated

but I need the mojang -> obfuscated to invert it for paper 1.20.6 and after

#

right ?

#

so 2 remappings for paper 1.20.6 and higher

#

comfyPanic

rigid saffron May 26, 2024, 2:15 PM

#

fallow sky so 2 remappings for paper 1.20.6 and higher

Yeah

fallow sky May 26, 2024, 2:15 PM

#

idk how to revert it

rigid saffron May 26, 2024, 2:15 PM

#

But I think paper goes from obfuscated to mojang by itself

fallow sky May 26, 2024, 2:15 PM

#

but first, we need to know why intermediary to obfuscate don't work

fallow sky May 26, 2024, 2:15 PM

#

rigid saffron But I think paper goes from obfuscated to mojang by itself

If I remember correctly yeah

rigid saffron May 26, 2024, 2:15 PM

#

fallow sky but first, we need to know why intermediary to obfuscate don't work

The issue is nobody has any idea

fallow sky May 26, 2024, 2:15 PM

#

:/

#

so close to the goal x)

rigid saffron May 26, 2024, 2:15 PM

#

@woven arrow you wanted to help

#

Ye okay I'll go

#

A bit busy today

fallow sky May 26, 2024, 2:16 PM

#

okay goodbye

rigid saffron May 26, 2024, 2:30 PM

#

Got a few free mins rn

CLASS   net/minecraft/server/MinecraftServer$a  net/minecraft/server/MinecraftServer$class_6897
CLASS   net/minecraft/server/MinecraftServer$b  net/minecraft/server/MinecraftServer$class_7460
CLASS   net/minecraft/server/MinecraftServer$c  net/minecraft/server/MinecraftServer$class_6414
CLASS   net/minecraft/server/MinecraftServer$c$1       net/minecraft/server/MinecraftServer$class_6414$1```
MinecraftServer doesn't seem to be renamed. I wonder if NMS gets relocated

fallow sky May 26, 2024, 2:34 PM

#

rigid saffron Got a few free mins rn ``` CLASS net/minecraft/server/MinecraftServer$a net/m...

oh...

#

what can we do ?

rigid saffron May 26, 2024, 2:34 PM

#

¯_(ツ)_/¯

#

Oh wait

#

We could modify the mappings

fallow sky May 26, 2024, 2:42 PM

#

huh

#

this is wild

#

but let's test that

#

@rigid saffron did you really choose the only class that isn't remapped x)

fallow sky May 26, 2024, 2:50 PM

#

rigid saffron Got a few free mins rn ``` CLASS net/minecraft/server/MinecraftServer$a net/m...

MinecraftServer is the common name for every namespace

#

All of them uses MinecraftServer as name

#

interesting

#

in 1.20.4, the error is

#

📎 message.txt

#

what the hell

#

ama is the obfuscated name for DedicatedServer, who extends MinecraftServer

#

@rigid saffron we forgot about craftbukkit

#

we need to "remap" the imported package too

rigid saffron May 26, 2024, 3:01 PM

#

fallow sky <@637908289014988800> we forgot about craftbukkit

oh

fallow sky May 26, 2024, 3:02 PM

#

I always get a ClassNotFoundException

rigid saffron May 26, 2024, 3:02 PM

#

I think we can use a ClassLoader

fallow sky May 26, 2024, 3:02 PM

#

📎 message.txt

fallow sky May 26, 2024, 3:02 PM

#

rigid saffron I think we can use a ClassLoader

oh, the thing that is really made bad ?

fallow sky May 26, 2024, 3:03 PM

#

fallow sky

using nms 1.17.1, with craftbukkit 1.17.1, on a 1.17.1 server

rigid saffron May 26, 2024, 3:03 PM

#

if(className.startsWith("org.bukkit.craftbukkit")) super.findClass(replace the version with the right one)

fallow sky May 26, 2024, 3:04 PM

#

rigid saffron if(className.startsWith("org.bukkit.craftbukkit")) super.findClass(replace the v...

so we need to do that for each class of the jarfile ?

fallow sky May 26, 2024, 3:05 PM

#

fallow sky

the problem is that the name for MinecraftServer is... MinecraftServer and not "aas"

#

but here is what I see when decompiling

#

so idk why it's searching for aas if the namespace in the remapped code is MinecraftServer

woven arrow May 26, 2024, 3:10 PM

#

rigid saffron <@539112187160166401> you wanted to help

i have been summoned

fallow sky May 26, 2024, 3:10 PM

#

perfect

#

I push everything on github for you rad

woven arrow May 26, 2024, 3:11 PM

#

what do you need halp with

fallow sky May 26, 2024, 3:12 PM

#

fallow sky

I need to know why it's searching for "aas" (obfuscated 1.17.1's name for MinecraftServer) instead of MinecraftServer, even more strange because in the remapped code, the namespace is named "MinecraftServer" so it should search for MinecraftServer

woven arrow May 26, 2024, 3:12 PM

#

ok i can help in like 15mins

fallow sky May 26, 2024, 3:13 PM

#

ok

#

I'll soon go

fallow sky May 26, 2024, 3:15 PM

#

fallow sky but here is what I see when decompiling

same issue on paper server and spigot server

#

@woven arrow use a 1.17.1 server for testing

rigid saffron May 26, 2024, 3:24 PM

#

We should ask the mapper himself (md_5) to help us

fallow sky May 26, 2024, 3:24 PM

#

yeah

#

how tf do we use ClassLoader for this especially ?

rigid saffron May 26, 2024, 3:25 PM

#

I doubt we can, finally, we don't load the plugin

fallow sky May 26, 2024, 3:25 PM

#

hm

rigid saffron May 26, 2024, 3:25 PM

#

Our best idea would be to do more asm

fallow sky May 26, 2024, 3:25 PM

#

I need to go

#

sorry goodbye

rigid saffron May 26, 2024, 3:25 PM

#

And here I doubt there is a lib to do that

#

bye

woven arrow May 26, 2024, 3:27 PM

#

okay i'm just tryna set up the project atm

#

huh

#

i tried to run 1.19.4 remapped buildtools

rigid saffron May 26, 2024, 3:39 PM

#

Lmao

woven arrow May 26, 2024, 3:39 PM

#

rigid saffron Lmao

😭

rigid saffron May 26, 2024, 3:50 PM

#

I wonder if spigot does any extra remapping

#

It might be possible that spigot does a few things which will make us die

fallow sky May 26, 2024, 4:22 PM

#

rigid saffron It might be possible that spigot does a few things which will make us die

We should ask md5 directly

fallow sky May 26, 2024, 4:23 PM

#

fallow sky I need to know why it's searching for "aas" (obfuscated 1.17.1's name for Minecr...

@latent mulch hello, sorry for pinging but we are a bit stuck, how can we solve this ?

#

And does spigot makes extra remapping ?

rigid saffron May 26, 2024, 4:30 PM

#

How do pings in threads work

#

When you're not in one

woven arrow May 26, 2024, 4:36 PM

#

rigid saffron When you're not in one

you get added

rigid saffron May 26, 2024, 4:36 PM

#

Yeah I noticed

#

Just tested it with a friend

#

Australian md is prob sleeping, right?

woven arrow May 26, 2024, 4:43 PM

#

yea probs

fallow sky May 26, 2024, 4:47 PM

#

rigid saffron Australian md is prob sleeping, right?

Maybe 🤷

#

He'll see that this night then x)

inland spoke May 26, 2024, 4:58 PM

#

So can this issue be reproduced by simply building all plugins from source and using them on a paper 1.17 server, or?

fallow sky May 26, 2024, 4:59 PM

#

inland spoke So can this issue be reproduced by simply building all plugins from source and u...

Well, actually because of craftbukkit

#

But we will soon fix that

#

So actually, a CVN plugin using craftbukkit as dependency can only work for one version

#

But everything is on GitHub to reproduce the issue

inland spoke May 26, 2024, 5:01 PM

#

so you found the solution now or?

fallow sky May 26, 2024, 5:01 PM

#

inland spoke so you found the solution now or?

No because I'm not programming rn

#

It's some strange cases of trying to use obfuscated namespace instead of Spigot one...

#

Yeah wait @rigid saffron, we should remap to Spigot, not obfuscated?

inland spoke May 26, 2024, 5:02 PM

#

well I suppose that narrows it down

fallow sky May 26, 2024, 5:04 PM

#

inland spoke well I suppose that narrows it down

A bit, but we'll fix that

#

In the days comings

#

And when CVN will be working, I'll do some libs based on it, because it's not at his full potential

#

We can make much better

rigid saffron May 26, 2024, 5:06 PM

#

fallow sky Yeah wait <@637908289014988800>, we should remap to Spigot, not obfuscated?

Spigot is just another type of deobfuscated mappings

fallow sky May 26, 2024, 5:06 PM

#

I'll explain that later, but we are actually grouping similar nms versions, not all versions

fallow sky May 26, 2024, 5:06 PM

#

rigid saffron Spigot is just another type of deobfuscated mappings

It's not the same

rigid saffron May 26, 2024, 5:07 PM

#

It's kinda like mcp or yarn afaik

fallow sky May 26, 2024, 5:08 PM

#

rigid saffron It's kinda like mcp or yarn afaik

CVN or Spigot ?

rigid saffron May 26, 2024, 5:08 PM

#

Spigot mappings

fallow sky May 26, 2024, 5:09 PM

#

rigid saffron Spigot mappings

But it's not the same 🤓☝️

#

I think that's why it's not working, we should do spigot remapping

#

Not obfuscated remapping

#

It's theory, but that could be a lib to do intra-remappings really easily

rigid saffron May 26, 2024, 5:10 PM

#

No, wtf are you saying

fallow sky May 26, 2024, 5:10 PM

#

rigid saffron No, wtf are you saying

Spigot use spigot mappings, right ?

rigid saffron May 26, 2024, 5:11 PM

#

No

#

Spigot before mojmaps used spigot mappings

#

Mappings are just a way to make the games code more readable

#

On runtime the game is always obfuscated

#

Besides paper 1.20.6

#

And one quintillion other situations

#

But we are in spigot

fallow sky May 26, 2024, 5:12 PM

#

Yeah

#

We are in spigot

#

But whyyyyy it's not working 😭😭

rigid saffron May 26, 2024, 5:13 PM

#

Because spigot does funky stuff

#

We'll have to look into specialsource maven plugin ig

fallow sky May 26, 2024, 5:13 PM

#

rigid saffron Because spigot does funky stuff

Funky groove 🕺

fallow sky May 26, 2024, 5:13 PM

#

rigid saffron We'll have to look into specialsource maven plugin ig

Oh okay

#

Not shading it, it's +5 Mb 💀

rigid saffron May 26, 2024, 5:14 PM

#

Would be nice if md 5 himself could tell us

fallow sky May 26, 2024, 5:18 PM

#

rigid saffron Would be nice if md 5 himself could tell us

...but looks like he's sleeping

rigid saffron May 26, 2024, 5:20 PM

#

Yeah

#

Sleepy md

inland spoke May 26, 2024, 6:06 PM

#

I have my doubts that it is because spigot uses a special type of mappings

rigid saffron May 26, 2024, 6:07 PM

#

I doubt that too

inland spoke May 26, 2024, 6:07 PM

#

It is unlikely that md knows what it is

rigid saffron May 26, 2024, 6:07 PM

#

But I don't understand why MinecraftServer stays unmapped

rigid saffron May 26, 2024, 6:07 PM

#

inland spoke It is unlikely that md knows what it is

But he knows more than we all do

inland spoke May 26, 2024, 6:07 PM

#

I'm taking a look at it

rigid saffron May 26, 2024, 6:07 PM

#

Finally, he has written all of this spigot and spigot mapping ecosystem

inland spoke May 26, 2024, 6:08 PM

#

What are the steps of reproducing the issue - just building all the plugins and the issue appears or is it more involved?

rigid saffron May 26, 2024, 6:08 PM

#

yeah, just building should do it

#

Build and run, should show the issue

#

But you might have to install a few things to your maven local

inland spoke May 26, 2024, 6:12 PM

#

Well, first I need to run bt heh

#

seriously, I need to have 2FA enabled for this?
gah

rigid saffron May 26, 2024, 6:14 PM

#

Lol

fallow sky May 26, 2024, 6:15 PM

#

rigid saffron But I don't understand why MinecraftServer stays unmapped

It can't find the obfuscated name of MinecraftServer

#

Don't forget the logs I'd sent before

rigid saffron May 26, 2024, 6:30 PM

#

Probably because it does not exist or something

fallow sky May 26, 2024, 6:32 PM

#

yeah

#

but if it's obfuscated, why ?

rigid saffron May 26, 2024, 6:33 PM

#

I can't test rn but can you make a plugin (just a plugin, not a CVN one) that just calls Class.forName("net.minecraft.server.MinecraftServer") and Class.forName("net.minecraft.server.v1_19_R01.MinecraftServer") or whatever your version is and wraps both of them in a try catch to know which one failed and which did not

fallow sky May 26, 2024, 6:33 PM

#

rigid saffron I can't test rn but can you make a plugin (just a plugin, not a CVN one) that ju...

oh yeah great idea

#

inland spoke May 26, 2024, 6:35 PM

#

so - which jar am I supposed to use?

fallow sky May 26, 2024, 6:35 PM

#

I searched a bit too

fallow sky May 26, 2024, 6:35 PM

#

inland spoke so - which jar am I supposed to use?

where ?

fallow sky May 26, 2024, 6:35 PM

#

inland spoke so - which jar am I supposed to use?

the highlighted one

#

(it's said on build)

inland spoke May 26, 2024, 6:36 PM

#

that one fails on a random exception

fallow sky May 26, 2024, 6:36 PM

#

inland spoke that one fails on a random exception

hum wtf

#

is that the latest commit?

#

you're not using the latest

inland spoke May 26, 2024, 6:37 PM

#

well time to nuke the build directory then

fallow sky May 26, 2024, 6:37 PM

#

I'd fixed that

fallow sky May 26, 2024, 6:37 PM

#

inland spoke well time to nuke the build directory then

yeah lol

inland spoke May 26, 2024, 6:37 PM

#

oh right - I completely forgot that build doesn't invoke the shadowJar task (you should change that)

fallow sky May 26, 2024, 6:37 PM

#

'cause well actually

fallow sky May 26, 2024, 6:37 PM

#

inland spoke oh right - I completely forgot that build doesn't invoke the shadowJar task (you...

oh yeah

rigid saffron May 26, 2024, 6:37 PM

#

fallow sky

So it does exist there???

fallow sky May 26, 2024, 6:38 PM

#

rigid saffron So it does exist there???

looks like

#

(in 1.17.1)

rigid saffron May 26, 2024, 6:38 PM

#

What class was missing then

rigid saffron May 26, 2024, 6:38 PM

#

inland spoke oh right - I completely forgot that build doesn't invoke the shadowJar task (you...

build {
finalizedBy shadowJar
}
Or something

fallow sky May 26, 2024, 6:38 PM

#

class name isn't obfuscated, method, field etc. yes therefore

fallow sky May 26, 2024, 6:38 PM

#

rigid saffron build { finalizedBy shadowJar } Or something

I add that

inland spoke May 26, 2024, 6:38 PM

#

rigid saffron build { finalizedBy shadowJar } Or something

I generally use dependsOn instead of finalizedBy

rigid saffron May 26, 2024, 6:39 PM

#

I don't think it makes much of a difference

fallow sky May 26, 2024, 6:39 PM

#

google says that too

rigid saffron May 26, 2024, 6:39 PM

#

fallow sky class name isn't obfuscated, method, field etc. yes therefore

Can you send the class?

fallow sky May 26, 2024, 6:39 PM

#

rigid saffron Can you send the class?

the entire jar?

rigid saffron May 26, 2024, 6:39 PM

#

The MinecraftServer class

fallow sky May 26, 2024, 6:39 PM

#

oh okay

rigid saffron May 26, 2024, 6:39 PM

#

I wanna see it

fallow sky May 26, 2024, 6:39 PM

#

wait

inland spoke May 26, 2024, 6:39 PM

#

donno, even more random exception now

fallow sky May 26, 2024, 6:40 PM

#

📎 MinecraftServer.class

fallow sky May 26, 2024, 6:40 PM

#

inland spoke donno, even more random exception now

you're using linux...

#

I was a bit afraid of that x)

inland spoke May 26, 2024, 6:40 PM

#

From the looks of it you are stripping the leading slash of the path

rigid saffron May 26, 2024, 6:40 PM

#

fallow sky I was a bit afraid of that x)

Holy shit how did you manage to mess up paths that much lol

fallow sky May 26, 2024, 6:41 PM

#

rigid saffron Holy shit how did you manage to mess up paths that much lol

I'm bad with paths x)

inland spoke May 26, 2024, 6:41 PM

#

well at least linux paths a much more sane than how it works under windows

fallow sky May 26, 2024, 6:41 PM

#

inland spoke well at least linux paths a much more sane than how it works under windows

yeah

#

in windows, we have sometimes /, sometimes \, sometimes there is a / at the end, or even a \

#

everything is perfect 👍

#

and both can be present, like C:\Users/me/Documents\Hey Is That A Folder/hello\

#

oh, I messed up

#

then there is spaces, so you need to put " at the beginning and the end

#

I very like paths :/

fallow sky May 26, 2024, 6:43 PM

#

fallow sky

how is it @rigid saffron ?

fallow sky May 26, 2024, 6:43 PM

#

inland spoke From the looks of it you are stripping the leading slash of the path

let's fix that 🤓

inland spoke May 26, 2024, 6:44 PM

#

I don't quite see where the error sneaks in though

fallow sky May 26, 2024, 6:44 PM

#

inland spoke I don't quite see where the error sneaks in though

with the / ?

rigid saffron May 26, 2024, 6:44 PM

#

fallow sky how is it <@637908289014988800> ?

Just like it should be

fallow sky May 26, 2024, 6:44 PM

#

rigid saffron Just like it should be

so OUR code is racist

inland spoke May 26, 2024, 6:44 PM

#

fallow sky with the / ?

ye

fallow sky May 26, 2024, 6:45 PM

#

for 1.17.1

fallow sky May 26, 2024, 6:45 PM

#

inland spoke ye

I know where it is

inland spoke May 26, 2024, 6:45 PM

#

okay I think I got it now too

fallow sky May 26, 2024, 6:45 PM

#

inland spoke okay I think I got it now too

what ?

#

the / ?

#

@inland spoke see by yourself my "wonderful code"

rigid saffron May 26, 2024, 6:46 PM

#

Here my favourite method (setUsesAuthentication)

Screenshot_2024-05-26-20-46-10-064_com.android.chrome.jpg

inland spoke May 26, 2024, 6:46 PM

#

well not exactly the workaround I would have gone with though

fallow sky May 26, 2024, 6:46 PM

#

rigid saffron Here my favourite method (setUsesAuthentication)

incredible

fallow sky May 26, 2024, 6:47 PM

#

inland spoke well not exactly the workaround I would have gone with though

how would you had done this?

rigid saffron May 26, 2024, 6:47 PM

#

inland spoke well not exactly the workaround I would have gone with though

If you know better options, tell us everything you know

fallow sky May 26, 2024, 6:47 PM

#

rigid saffron If you know better options, tell us everything you know

YEAH

#

lol

rigid saffron May 26, 2024, 6:48 PM

#

Awful

fallow sky May 26, 2024, 6:48 PM

#

rigid saffron Awful

I know

#

but I do my best x)

inland spoke May 26, 2024, 6:48 PM

#

fallow sky how would you had done this?

nope, I was a bit blind

#

why is it even needed to strip the leading slash on windows?

fallow sky May 26, 2024, 6:49 PM

#

inland spoke why is it even needed to strip the leading slash on windows?

because there is a / at the beginning...

#

I don't know why

#

Windows is shit 🤓☝️

inland spoke May 26, 2024, 6:49 PM

#

does it work anyways?

fallow sky May 26, 2024, 6:49 PM

#

inland spoke does it work anyways?

it works.

inland spoke May 26, 2024, 6:49 PM

#

Might be a valid UNC path for what I know

fallow sky May 26, 2024, 6:49 PM

#

not on linux

rigid saffron May 26, 2024, 6:49 PM

#

fallow sky because there is a / at the beginning...

What if you put it into a new File first

#

Without reformatting anything

fallow sky May 26, 2024, 6:50 PM

#

rigid saffron Without reformatting anything

not working

rigid saffron May 26, 2024, 6:50 PM

#

And then toPath()

inland spoke May 26, 2024, 6:50 PM

#

fallow sky it works.

No, I mean including the leading slash in windows

fallow sky May 26, 2024, 6:50 PM

#

I was doing that before

rigid saffron May 26, 2024, 6:50 PM

#

fallow sky I was doing that before

Weren't you doing Paths.get

fallow sky May 26, 2024, 6:50 PM

#

rigid saffron And then toPath()

so new File(new File(path).toPath()) 💀

rigid saffron May 26, 2024, 6:50 PM

#

fallow sky so `new File(new File(path).toPath())` 💀

lol

fallow sky May 26, 2024, 6:50 PM

#

inland spoke No, I mean including the leading slash in windows

no

fallow sky May 26, 2024, 6:51 PM

#

rigid saffron Weren't you doing Paths.get

oh yeah I was

rigid saffron May 26, 2024, 6:51 PM

#

import java.io.File;
import java.net.URISyntaxException;

public class JarPathFinder {
    public static void main(String[] args) {
        try {
            // Get the location of the class file of the main class
            String path = JarPathFinder.class.getProtectionDomain().getCodeSource().getLocation().toURI().getPath();

            // Convert the path to a file to get a normalized version
            File jarFile = new File(path);

            // Get the absolute path of the JAR file
            String jarFilePath = jarFile.getAbsolutePath();

            // Print the path to the JAR file
            System.out.println("Path to the JAR file: " + jarFilePath);
        } catch (URISyntaxException e) {
            e.printStackTrace();
        }
    }
}
``` chatgpt suggested me this

fallow sky May 26, 2024, 6:51 PM

#

looks like I'm not doing this anymore

fallow sky May 26, 2024, 6:51 PM

#

rigid saffron ```java import java.io.File; import java.net.URISyntaxException; public class J...

CHATGPT IS BAD

#

but let's listen to chatgpt a bit

rigid saffron May 26, 2024, 6:51 PM

#

fallow sky CHATGPT IS BAD

It sometimes can be good

fallow sky May 26, 2024, 6:51 PM

#

rigid saffron It sometimes can be good

sometimes

rigid saffron May 26, 2024, 6:52 PM

#

Instead of jar path finder use the (bukkit) Server class

fallow sky May 26, 2024, 6:53 PM

#

for sure

#

I'm not that dumb x)

rigid saffron May 26, 2024, 6:53 PM

#

Who knows, who knows

fallow sky May 26, 2024, 6:53 PM

#

rigid saffron Who knows, who knows

x)

rigid saffron May 26, 2024, 6:53 PM

#

We need to make sure everything is ideal

fallow sky May 26, 2024, 6:54 PM

#

there is still a lot of works to make everything ideal :/

rigid saffron May 26, 2024, 6:54 PM

#

But eventually

#

It will be ideal

fallow sky May 26, 2024, 6:54 PM

#

rigid saffron ```java import java.io.File; import java.net.URISyntaxException; public class J...

it worked

rigid saffron May 26, 2024, 6:54 PM

#

Just that with every new mc version we will need to upload the mappings

fallow sky May 26, 2024, 6:54 PM

#

but ✨ still the same error ✨

fallow sky May 26, 2024, 6:54 PM

#

rigid saffron Just that with every new mc version we will need to upload the mappings

not a problem

rigid saffron May 26, 2024, 6:55 PM

#

fallow sky but ✨ still the same error ✨

what error

fallow sky May 26, 2024, 6:55 PM

#

📎 message.txt

#

✨

rigid saffron May 26, 2024, 6:55 PM

#

"aas"?

fallow sky May 26, 2024, 6:56 PM

#

rigid saffron "aas"?

#

see by yourself

#

DedicatedServer, so the extend of MinecraftServer

#

the real form of CraftServer.getServer

rigid saffron May 26, 2024, 6:56 PM

#

Screenshot_2024-05-26-20-56-27-250_com.mi.globalbrowser-edit.jpg

#[IN DEV] CVN (Cross-Version-NMS)