Weird error | SpigotMC | Page 1

burnt garnet Feb 16, 2024, 10:07 PM

#

gloomy rain Feb 16, 2024, 10:07 PM

#

so

burnt garnet Feb 16, 2024, 10:07 PM

#

gloomy rain Feb 16, 2024, 10:07 PM

#

send in PlayerManager:93 again, please

burnt garnet Feb 16, 2024, 10:07 PM

#

oh yeha

#

gloomy rain Feb 16, 2024, 10:08 PM

#

so this isn't possible for any of the player instances to be null, unless you explicitly set a player to null

#

Bukkit.getOnlinePlayers() only returns nonnull objects, afaik

burnt garnet Feb 16, 2024, 10:08 PM

#

let me check other functions that run

gloomy rain Feb 16, 2024, 10:08 PM

#

since you use IntelliJ, you can easily just search through the entire file tree

#

search after playerList.add or playerList.replace or playerList.set

burnt garnet Feb 16, 2024, 10:09 PM

#

alr

thorn forum Feb 16, 2024, 10:09 PM

#

gloomy rain search after `playerList.add` or `playerList.replace` or `playerList.set`

yes and the logged it and the values were not null but a normal player instance but opon tp its null

burnt garnet Feb 16, 2024, 10:10 PM

#

gloomy rain Feb 16, 2024, 10:10 PM

#

ah

#

very weird, is there anything else

burnt garnet Feb 16, 2024, 10:10 PM

#

nope

gloomy rain Feb 16, 2024, 10:10 PM

#

thorn forum yes and the logged it and the values were not null but a normal player instance ...

what kind of list are you using?

#

an ArrayList @burnt garnet ?

thorn forum Feb 16, 2024, 10:10 PM

#

gloomy rain what kind of list are you using?

HashMap

burnt garnet Feb 16, 2024, 10:10 PM

#

gloomy rain Feb 16, 2024, 10:11 PM

#

oh so playerList is a map

#

🤦‍♂️

#

im an idiot I programmed too much in typescript recently I forgot that forEach doesn't supply an index

#

for iterables

#

but this doesn't explain null anyways

burnt garnet Feb 16, 2024, 10:12 PM

#

so the java gods just dont like me or smth?

gloomy rain Feb 16, 2024, 10:12 PM

#

nah there will be a logical explanation

#

where do you call setPlayerTeam

burnt garnet Feb 16, 2024, 10:13 PM

#

#

only place

gloomy rain Feb 16, 2024, 10:13 PM

#

search for playerList.put instead lol

#

since I thought it was a list, I assumed .add

burnt garnet Feb 16, 2024, 10:14 PM

#

gloomy rain Feb 16, 2024, 10:14 PM

#

okay and addPlayer you only call in that loop...

#

very interesting situation

burnt garnet Feb 16, 2024, 10:14 PM

#

this was working last time i tested it

#

it randomly stopped working

gloomy rain Feb 16, 2024, 10:14 PM

#

well, put a sysout everywhere, where you mutate that map

#

so everywhere, where there is a put a replace or anything that modifies the map except removals

#

you just have to debug in what method you pass in null

burnt garnet Feb 16, 2024, 10:15 PM

#

allr

#

alr

#

#

this is it

#

wait what

#

the /stopevent command is working now?!

thorn forum Feb 16, 2024, 10:19 PM

#

try to log the player location

burnt garnet Feb 16, 2024, 10:19 PM

#

wtf

#

its working now

#

but i've had another issue

thorn forum Feb 16, 2024, 10:20 PM

#

which is?

burnt garnet Feb 16, 2024, 10:20 PM

#

wait

#

#

@EventHandler
    private void onDeath(PlayerDeathEvent e) {
        if (gameManager.playerList.containsKey(e.getPlayer())) {
            e.setCancelled(true);
            e.getDrops().add(new ItemStack(Material.TOTEM_OF_UNDYING, 1));
            e.getDrops().forEach(drop -> e.getEntity().getWorld().dropItemNaturally(e.getEntity().getLocation(), drop));
            gameManager.getPlayerManager().removePlayer(e.getPlayer());
            gameManager.getPlayerManager().removePlayerFromTeam(e.getPlayer());
            e.getPlayer().setGameMode(GameMode.SPECTATOR);
            util.broadcast(e.getEntity().getName() + " has lost!");
            e.getPlayer().getLocation().getWorld().strikeLightningEffect(e.getPlayer().getLocation());
            if (gameManager.teamList.size() == 1) {
                util.broadcast("Game over! Team number " + gameManager.getPlayerManager().getPlayerTeam(e.getPlayer()) + " has won!");
                util.broadcast("The following players were in the winning team:" + gameManager.getPlayerManager().getPlayersInTeam(gameManager.getPlayerManager().getPlayerTeam(e.getPlayer())));
                util.broadcast("You can do /lobby");
            } else {
                util.broadcast("There are " + gameManager.teamList.size() + " teams left!");
            }
        }
    }

thorn forum Feb 16, 2024, 10:21 PM

#

The map is null

burnt garnet Feb 16, 2024, 10:22 PM

#

same issue as the other one

#

but why is the stopevent working but not this

#

thorn forum Feb 16, 2024, 10:23 PM

#

witch line is 26

burnt garnet Feb 16, 2024, 10:23 PM

#

burnt garnet

^

thorn forum Feb 16, 2024, 10:26 PM

#

what is line 55 for / what are you checking

burnt garnet Feb 16, 2024, 10:26 PM

#

if its there

#

i was just trying a bunch of stuff

#

cause nothing worked

thorn forum Feb 16, 2024, 10:29 PM

#

what does the logging say

burnt garnet Feb 16, 2024, 10:29 PM

#

lemme check

#

thorn forum Feb 16, 2024, 10:30 PM

#

are you shure he is even in a team?

burnt garnet Feb 16, 2024, 10:30 PM

#

i've looped it

#

before

#

he's in a team

#

wait

thorn forum Feb 16, 2024, 10:31 PM

#

apprently he isnt

burnt garnet Feb 16, 2024, 10:31 PM

#

i have a check team command

#

lemme use it rq

#

thorn forum Feb 16, 2024, 10:33 PM

#

but then playerList isnt saving the data right

burnt garnet Feb 16, 2024, 10:33 PM

#

i have no idea whats going on

#

is the way im checking the info wrong?

thorn forum Feb 16, 2024, 10:35 PM

#

check what type of code is used for line 55

#

like the main or the else

burnt garnet Feb 16, 2024, 10:36 PM

#

?

#

thorn forum Feb 16, 2024, 10:36 PM

#

debug if it runs the if body or the else body

burnt garnet Feb 16, 2024, 10:36 PM

#

oh okay

#

it wont say

#

the error happens before

thorn forum Feb 16, 2024, 10:39 PM

#

send the code

burnt garnet Feb 16, 2024, 10:40 PM

#

this?

#

its not pasting

#

one second

#

thorn forum Feb 16, 2024, 10:42 PM

#

log the teamlist and then the playerList

burnt garnet Feb 16, 2024, 10:42 PM

#

alr

#

like each team and player?

thorn forum Feb 16, 2024, 10:42 PM

#

like the way you did earlier with the player

burnt garnet Feb 16, 2024, 10:42 PM

#

alr

#

like that/

thorn forum Feb 16, 2024, 10:44 PM

#

no just playerList.toString()

#

and teamList.toString()

burnt garnet Feb 16, 2024, 10:44 PM

#

oh okay

#

mb

#

OH SHIT

#

wait

#

i think it removed the player first

#

im just stupid

#

bro

#

im so sorry for wasting your time

thorn forum Feb 16, 2024, 10:48 PM

#

all good im watching a series while thinking a bit

burnt garnet Feb 16, 2024, 10:48 PM

#

thank you for trying to help

#

im just stupid

thorn forum Feb 16, 2024, 10:48 PM

#

np

tired salmon Feb 16, 2024, 10:50 PM

#

burnt garnet

Unnecessary check for #containsKey. you dont need to check when using #put operation

#

A tip from someone who is trying to better themselves. Follow OOP structure.

drifting geyser Feb 17, 2024, 9:06 PM

#

https://tenor.com/view/boom-cat-parry-brick-gif-27687560

Tenor

drifting geyser Feb 17, 2024, 9:06 PM

#

tired salmon A tip from someone who is trying to better themselves. Follow OOP structure.

?learnjava

#Weird error