Changing a plugin to use CustomModelData? | SpigotMC | Page 1

dire sapphire Nov 11, 2023, 12:06 PM

#

I made a plugin a while ago that basically turns a specified block into a 'scrap block'. A scrap block can be right clicked and the player receives one of the x specified rewards. There's then a cooldown till the player can rightclick it again. There's also a particle right above the block to indicate that it's a scrap block.
My issue is, right now I can specify all the rewards the player can get, but I want this to include custommodeldata as well, seeing as I'll be working with a bunch of custom items.
Here's the part that lets an admin turn a block into a scrap block:

        switch (args[0]) {
            case "add" -> {
                if (args.length == 4) {
                    // convert args[1] to particle
                    Particle particle = validParticles.contains(args[1].toUpperCase()) ? Particle.valueOf(args[1].toUpperCase()) : Particle.ASH;
                    // convert args[2] to int
                    int cooldown = Integer.parseInt(args[2]);

                    // convert args[3] to List<ItemStack>
                    List<ItemStack> items = new ArrayList<>();
                    String[] itemStrings = args[3].split(",");
                    for (String itemString : itemStrings) {
                        Material material = Material.matchMaterial(itemString.trim());
                        if (material != null) {
                            ItemStack item = new ItemStack(material);
                            items.add(item);
                        }
                    }
                    ChestObject chest = new ChestObject(false, blockLoc, particle, cooldown, items);
                    pHandler.AddLoc(chest, sender);
                    return true;
                }```
How canI change it so that you can specify custommodeldata per given item? When it's not given it should just be custommodeldata 0.

#

#

An example of the command:
/sc add SCRAPE 5 white_dye,sand,gravel,diamond_pickaxe

#

SCRAPE is the particle type

#

5 is 5 seconds cooldown

#

So what I want to change it to is something like this:
/sc add SCRAPE 5 white_dye(1),sand,gravel,diamond_pickaxe(20)
where the numbers represent the custom model data

rotund summit Nov 11, 2023, 12:46 PM

#

Well

#

You basically just need to parse your itemstring

#

Regex could help, or you can write something manual

dire sapphire Nov 11, 2023, 12:47 PM

#

Yeah I was thinking about using regex, but Im just not sure how I'd store the custommodeldata specific to the item

rotund summit Nov 11, 2023, 12:48 PM

#

dire sapphire Nov 11, 2023, 12:50 PM

#

oh wait, I have an idea. What if I change this:

                  String[] itemStrings = args[3].split(",");
                  for (String itemString : itemStrings) {
                        Material material = Material.matchMaterial(itemString.trim());
                        if (material != null) {
                            ItemStack item = new ItemStack(material);
                            items.add(item);
                        }```
to something like this:
```java
                  String[] itemStrings = args[3].split(",");
                  for (String itemString : itemStrings) {
                        //seperate the (x) from the string, and the string from the x
                        //int custommodeldata = x. x = 0 if no brackets
                        Material material = Material.matchMaterial(itemString.trim());
                        if (material != null) {
                            ItemStack item = new ItemStack(material);
                            items.add(item);
                            // ????????
                        }

At the '????????', what do I do there? I mean, I need to store the custommodeldata, but how

rotund summit Nov 11, 2023, 12:51 PM

#

Yeah that's the idea

#

I'd split it into a separate method to start with

dire sapphire Nov 11, 2023, 12:51 PM

#

Split what into a seperate method?

rotund summit Nov 11, 2023, 12:51 PM

#

private ItemStack parseItem(String input) {

}

dire sapphire Nov 11, 2023, 12:51 PM

#

ah?

rotund summit Nov 11, 2023, 12:51 PM

#

Let's start with that

#

We can then do our regex magic

#

private static final Pattern PATTERN = Pattern.compile("(\w+)\\(*(\d+)*\\)*");

private ItemStack parseItem(String input) {
  Matcher matcher = PATTERN.matcher(input);

  if(!matcher.matches()) {
    return null;
  }

  int groupCount = matcher.groupCount();

  if(groupCount == 0) {
    return null; // wtf
  }

  Material material = Material.matchMaterial(matcher.group(1));
  int model = (groupCount == 1 ? 0 : Integer.parseInt(matcher.group(2));

  ...
}

#

something like that

dire sapphire Nov 11, 2023, 12:55 PM

#

rotund summit something like that

What does the matcher part do?

rotund summit Nov 11, 2023, 12:55 PM

#

regex stuff

dire sapphire Nov 11, 2023, 12:55 PM

#

right...

rotund summit Nov 11, 2023, 12:56 PM

#

there

#

It basically grabs the pattern and matches it to our input

dire sapphire Nov 11, 2023, 12:56 PM

#

and what's the groupcount?

rotund summit Nov 11, 2023, 12:56 PM

#

allowing us to get our groups

dire sapphire Nov 11, 2023, 12:56 PM

#

ahhh

rotund summit Nov 11, 2023, 12:56 PM

#

p sure the groupcount check will fail because I might be an idiot

#

so you might want to check for null

#

I don't do regex often

dire sapphire Nov 11, 2023, 12:56 PM

#

yeah no me neither

dire sapphire Nov 11, 2023, 12:57 PM

#

rotund summit ```java private static final Pattern PATTERN = Pattern.compile("(\w+)\\(*(\d+)*\...

But this doesn't really tell how to store material and custommodeldata together

rotund summit Nov 11, 2023, 12:57 PM

#

modeldata is part of the itemmeta

#

ItemStack stack = ...
ItemMeta meta = stack.getItemMeta

meta.setCustomModelData(model)
stack.setItemMeta(meta)

#

basic itemstack api

dire sapphire Nov 11, 2023, 12:58 PM

#

See, if I use a command like this:
/sc add SCRAPE 5 white_dye(1),sand,gravel,diamond_pickaxe(20)
The middle 2 won't have a custom custommodeldata, so if it's stored it would look like this right?
items: white_dye, sand, gravel, diamond_pickaxe
models: 1, 20

dire sapphire Nov 11, 2023, 12:58 PM

#

rotund summit ItemStack stack = ... ItemMeta meta = stack.getItemMeta meta.setCustomModelData...

Ahhh

#

So, in this case

ItemStack item = new ItemStack(material);
                            items.add(item);```
item would store both the material and custommodeldata?

rotund summit Nov 11, 2023, 12:59 PM

#

think about it for a second

rotund summit Nov 11, 2023, 12:59 PM

#

dire sapphire See, if I use a command like this: /sc add SCRAPE 5 white_dye(1),sand,gravel,dia...

split it by ,

#

white_dye(1),sand,gravel,diamond_pickaxe(20) -> ["white_dye(1)", "sand", "gravel", "diamond_pickaxe(20)"]

#

Convert every entry to an itemstack

#

white_dye(1)
group 1 : white_dye
group 2 : 1

sand
group 1 : sand
group 2 : undefined

gravel
group 1 : gravel
group 2 : undefined

diamond_pickaxe(20)
group 1 : diamond_pickaxe
group 2 : 20

#

bim bim bam bam

#

Collection<ItemStack> items = new ArrayList<>();
for(String input : myArg.split(",")) {
  items.add(parseItem(input);
}

dire sapphire Nov 11, 2023, 1:02 PM

#

👍 I get it, I think

#

Let me try to implement it

dire sapphire Nov 11, 2023, 1:04 PM

#

rotund summit ```java private static final Pattern PATTERN = Pattern.compile("(\w+)\\(*(\d+)*\...

It shows these red

#

Also, I don't necessarily need to do this right?
if(groupCount == 0) {
return null; // wtf
}
If I leave that out, 0 will just be stored as custommodeldata

rotund summit Nov 11, 2023, 1:05 PM

#

Add another \

#

Uhh no

dire sapphire Nov 11, 2023, 1:06 PM

#

rotund summit Uhh no

?

#

wdym

#

oh nevermind

#

group is the amount of arguments in arg[3]

#

or items listed

dire sapphire Nov 11, 2023, 6:27 PM

#

@rotund summit the line you wrote for me when helping doesn't really work and I don't see what's wrong with it

  private ItemStack parseItem(String input) {
        Matcher matcher = PATTERN.matcher(input);

        if (!matcher.matches()) return null;
        int groupCount = matcher.groupCount();
        if (groupCount == 0) return null;

        Material material = Material.matchMaterial(matcher.group(1));
        int model = (groupCount == 1 ? 0 : Integer.parseInt(matcher.group(2)));     // This causes the error
        if (material != null) {
            ItemStack item = new ItemStack(material);
            ItemMeta meta = item.getItemMeta();
            if (meta == null) return item;
            meta.setCustomModelData(model);
            item.setItemMeta(meta);
            return item;
            }
        return null;
    }```
[19:22:49 INFO]: JustinS_2006 issued server command: /sc add ASH 5 sand,grass(5),dirt(200)
[19:22:49 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'sc' in plugin ScrapCollection v1.0
    ....
    at java.lang.Thread.run(Thread.java:833) [?:?]
Caused by: java.lang.NumberFormatException: Cannot parse null string
    ...
    at me.JustinS_2006.particles.AddParticleCommand.parseItem(AddParticleCommand.java:117) ~[?:?]
    at me.JustinS_2006.particles.AddParticleCommand.onCommand(AddParticleCommand.java:69) ~[?:?]
    ...

#

The error only happens when one of the items don't have brackets

#

if I change it to /sc add ASH 5 sand(3),grass(5),dirt(200) it does work PERFECTLY which I thank you for so incredibly much

#Changing a plugin to use CustomModelData?