[IMMPORTANT] Error(the PlayerQuitEvent Included) | SpigotMC | Page 1

eternal swallow Jun 27, 2023, 8:56 PM

#

https://mclo.gs/iZddSw8

#

[IMMPORTANT] Error(the PlayerQuitEvent Included)

#

playerjoin i meant

#

@EventHandler
    public void onPlayerJoin(PlayerJoinEvent e){
        HypixelSkillCore plugin = HypixelSkillCore.getInstance();
        Player player = e.getPlayer();
        if(player.getPersistentDataContainer().get(plugin.getKey(), plugin.getType()) != null){
            if(plugin.getPlayer(player.getUniqueId()) != null) return;
            plugin.setPlayer(player.getUniqueId(), player.getPersistentDataContainer().get(plugin.getKey(), plugin.getType()));
        }
        if(plugin.getPlayer(player.getUniqueId()) == null){
            plugin.createPlayer(player.getUniqueId());
            player.getPersistentDataContainer().set(plugin.getKey() , plugin.getType(), plugin.getPlayer(player.getUniqueId()));
            player.sendMessage(ChatColor.GREEN + "Welcome To server! Your SkyblockSkills Account Has Been Created");
        }
    }

#

happened after a rejoin

#

public void onPlayerLeave(PlayerQuitEvent e){
        Player player = e.getPlayer();
        HypixelSkillCore plugin = HypixelSkillCore.getInstance();
        player.getPersistentDataContainer().set(plugin.getKey() , plugin.getType(), plugin.getPlayer(player.getUniqueId()));
    }

playerquit if needed

#

public final class HypixelSkillCore extends JavaPlugin {
    private HashMap<UUID, HypixelPlayer> uuidToPlayerMap = new HashMap<>();
    private static HypixelSkillCore plugin;

    private ConfigurationSerializableDataType<HypixelPlayer> type = new ConfigurationSerializableDataType<>(HypixelPlayer.class);
    private NamespacedKey key;

    @Override
    public void onEnable() {
        plugin = this;
        key = new NamespacedKey(this, "key");
        registerClasses();
        enableListeners();
        this.getCommand("skillstext").setExecutor(new SkillsText());
        getLogger().info("HypixelSkillCore for ");
        new BukkitRunnable(){
            @Override
            public void run(){
                ArrayList<HypixelPlayer> array = new ArrayList<>(uuidToPlayerMap.values());
                for (HypixelPlayer player: array) {
                    try {
                        player.setTrueStats();
                        player.getSkillBossBar().setVisible(true);
                        if (player.getSkillBossBar().getPlayers().size() != 0) {
                            player.getSkillBossBar().removePlayer(getServer().getPlayer(player.getUuid()));
                        }
                    }catch(Throwable rock){}
                }
            }
        }.runTaskTimer(this, 1L, 80L);
    }

    public static HypixelSkillCore getInstance() {
        return plugin;
    }

    public void createPlayer(UUID uuid){
discord limit
    }

    public void setPlayer(UUID uuid, HypixelPlayer player){
        uuidToPlayerMap.put(uuid, player);
    }

    public HypixelPlayer getPlayer(UUID uuid){
        return uuidToPlayerMap.get(uuid);
    }

    public ConfigurationSerializableDataType<HypixelPlayer> getType() {
        return type;
    }

    public NamespacedKey getKey() {
        return key;
    }

    private void enableListeners(){
  removed due to discord limit
    }

    private void registerClasses(){
   removed due to discord limit
    }

#

public class HypixelPlayer implements ConfigurationSerializable {
    private Farming farming = new Farming();
    private Mining mining = new Mining();
    private Woodcutting woodcutting = new Woodcutting();
    private Combat combat = new Combat();

    BossBar skillBossBar = Bukkit.createBossBar("+69 SKILLNAME SKILLXP/REQSKILLXP", BarColor.GREEN, BarStyle.SOLID);

    private UUID uuid;

    private double damage = 1;
    private double health = 20;
    private double defense = 1;

    //.addPotionEffect(new PotionEffect(PotionEffectType.HEALTH_BOOST, 10, (int)Math.floor(health), false));
    public void setTrueStats(){
        HypixelSkillCore.getInstance().getServer().getPlayer(uuid).setMaxHealth(health);
    }

removed getters and setters for discord limitation

    public Map<String, Object> serialize(){
        return Map.of(
            "uuid",uuid,
            "skill_woodcutting",woodcutting,
            "skill_mining",mining,
            "skill_farming",farming,
            "skill_combat",combat,
            "stats_heath",health,
            "stats_damage",damage,
            "stats_defense",defense
            );
    }

    public void deserialize(Map<String, Object> m){
        uuid = (UUID) m.get("uuid");
        woodcutting = (Woodcutting) m.get("skill_woodcutting");
        mining = (Mining) m.get("skill_mining");
        farming = (Farming) m.get("skill_farming");
        combat = (Combat) m.get("skill_combat");
        health = (Double) m.get("stats_health");
        damage = (Double) m.get("stats_damage");
        defense = (Double) m.get("stats_defense");
    }
}

#

the problem is in deserializing the class

#

yes i registered them

#

and made the skill classes ConfigurationSerializable

waxen walrus Jun 27, 2023, 9:10 PM

#

that deserialize should be static and return an instance iirc

eternal swallow Jun 27, 2023, 9:10 PM

#

wdym?

waxen walrus Jun 27, 2023, 9:11 PM

#

eternal swallow Jun 27, 2023, 9:11 PM

#

public static void deserialize

#

?

waxen walrus Jun 27, 2023, 9:11 PM

#

no, thats void, it should return an instance

ashen grail Jun 27, 2023, 9:12 PM

#

eternal swallow ``` public final class HypixelSkillCore extends JavaPlugin { private HashMap...

I already told you, you gotta register your seriazable class

eternal swallow Jun 27, 2023, 9:12 PM

#

wdym by returning an instance you mean public static HypixelPlayer deserialize? and return this;?

eternal swallow Jun 27, 2023, 9:12 PM

#

ashen grail I already told you, you gotta register your seriazable class

done

ashen grail Jun 27, 2023, 9:12 PM

#

in onEnable

ashen grail Jun 27, 2023, 9:12 PM

#

eternal swallow done

where? I don't see it in your code

eternal swallow Jun 27, 2023, 9:12 PM

#

private void registerClasses(){
ConfigurationSerialization.registerClass(HypixelPlayer.class);
ConfigurationSerialization.registerClass(Combat.class);
ConfigurationSerialization.registerClass(Farming.class);
ConfigurationSerialization.registerClass(Mining.class);
ConfigurationSerialization.registerClass(Woodcutting.class);
}

#

private void registerClasses(){
ConfigurationSerialization.registerClass(HypixelPlayer.class);
ConfigurationSerialization.registerClass(Combat.class);
ConfigurationSerialization.registerClass(Farming.class);
ConfigurationSerialization.registerClass(Mining.class);
ConfigurationSerialization.registerClass(Woodcutting.class);
}

waxen walrus Jun 27, 2023, 9:12 PM

#

public static HypixelPlayer deserialize(Map<String, Object> map) {
    return this(map);
}

public HypixelPlayer(Map<String, Object> map) {
    this.whatever= map.get("whatever")
}

ashen grail Jun 27, 2023, 9:13 PM

#

eternal swallow ```java public class HypixelPlayer implements ConfigurationSerializable { pr...

your deserialize method must be static

#

eternal swallow Jun 27, 2023, 9:14 PM

#

i will do it rn

eternal swallow Jun 27, 2023, 9:14 PM

#

waxen walrus ```java public static HypixelPlayer deserialize(Map<String, Object> map) { r...

should i add that at the end of my deserialize method?

#

or the deserialize will be that

waxen walrus Jun 27, 2023, 9:15 PM

#

thats an example to follow DRY

eternal swallow Jun 27, 2023, 9:16 PM

#

oh fuck java whoever made java was a fucking bitch

waxen walrus Jun 27, 2023, 9:16 PM

#

no not really

eternal swallow Jun 27, 2023, 9:17 PM

#

ashen grail your deserialize method must be static

who should i listen to you or @waxen walrus

#

you say i just make my method static

waxen walrus Jun 27, 2023, 9:17 PM

#

my deserialize is static, and it also follows dry

eternal swallow Jun 27, 2023, 9:17 PM

#

wdym by dry?

waxen walrus Jun 27, 2023, 9:18 PM

#

dont repeat yourself

eternal swallow Jun 27, 2023, 9:18 PM

#

oh

#

oh im so fucking dumb

#

i got it

#

i got an error. should i make the costructor private?

waxen walrus Jun 27, 2023, 9:19 PM

#

?paste ur new class

inland willowBOT Jun 27, 2023, 9:19 PM

#

https://paste.md-5.net/

waxen walrus Jun 27, 2023, 9:20 PM

#

oh fun

#

cafebabe works in threads

eternal swallow Jun 27, 2023, 9:20 PM

#

that website doesnt work for me

waxen walrus Jun 27, 2023, 9:20 PM

#

use any other paste site then

eternal swallow Jun 27, 2023, 9:21 PM

#

done fixed the error realated to creating a new HypixelPlayer with this:
public HypixelPlayer(){}

waxen walrus Jun 27, 2023, 9:21 PM

#

if it doesnt take the map you just have to handle the deserializing in the method and it would break if it trys to use the constructor

eternal swallow Jun 27, 2023, 9:22 PM

#

waxen walrus if it doesnt take the map you just have to handle the deserializing in the metho...

no thats for the other places where i create a HypixelPlayer()

#

the other constructor is there

#

return this(m); doesnt work

#

Call to 'this()' must be first statement in constructor body

#

public static HypixelPlayer deserialize(Map<String, Object> m){
return this(m);
}

public HypixelPlayer(Map<String, Object> m){
    this.uuid = (UUID) m.get("uuid");
    this.woodcutting = (Woodcutting) m.get("skill_woodcutting");
    this.mining = (Mining) m.get("skill_mining");
    this.farming = (Farming) m.get("skill_farming");
    this.combat = (Combat) m.get("skill_combat");
    this.health = (Double) m.get("stats_health");
    this.damage = (Double) m.get("stats_damage");
    this.defense = (Double) m.get("stats_defense");
}

public HypixelPlayer(){}

waxen walrus Jun 27, 2023, 9:25 PM

#

return new HypixelPlayer(m); then

eternal swallow Jun 27, 2023, 9:26 PM

#

done before you could tell me

#

now its time to do it with all the skill classes. oh fck

#

//TODO fix the deserialization with the tips from EpicEbic
too tired

eternal swallow Jun 28, 2023, 10:09 AM

#

all the deserializing code done

#

time to test it ou

#

t

#

mclo.gs

#

https://mclo.gs

#

im not gonna share the log rn. lemme see if the playerdata has been saved on pdc or not

#

https://mclo.gs/JY27z8A
https://mclo.gs/mtjiPbU
https://mclo.gs/ftw3F1b
managed to go through a whole join and leave without errors but after the join it gave an error
the stats / skills were still there though

#

lemme restart the server...

#

it doesn seem that anything has been saved on the players nbt data

ashen grail Jun 28, 2023, 10:41 AM

#

?nocode

inland willowBOT Jun 28, 2023, 10:41 AM

#

It’s hard to answer a programming question without code
Oh no! You ran into a problem. But no worries, people are willing to help, but first they need to see your code. This is because otherwise, they would be providing help based on guesses instead of concrete knowledge. Whether it be a compile error, runtime error, or an unexpected output, I'm sure that if you were to provide code, you'd receive a quick solution.

eternal swallow Jun 28, 2023, 10:52 AM

#

okay

#

which parts of the plugin?

#

@ashen grail

#

@EventHandler
    public void onPlayerJoin(PlayerJoinEvent e){
        HypixelSkillCore plugin = HypixelSkillCore.getInstance();
        Player player = e.getPlayer();
        if(player.getPersistentDataContainer().get(plugin.getKey(), plugin.getType()) != null){
            if(plugin.getPlayer(player.getUniqueId()) != null) return;
            plugin.setPlayer(player.getUniqueId(), player.getPersistentDataContainer().get(plugin.getKey(), plugin.getType()));
        }
        if(plugin.getPlayer(player.getUniqueId()) == null){
            plugin.createPlayer(player.getUniqueId());
            player.getPersistentDataContainer().set(plugin.getKey() , plugin.getType(), plugin.getPlayer(player.getUniqueId()));
            player.sendMessage(ChatColor.GREEN + "Welcome To server! Your SkyblockSkills Account Has Been Created");
        }
    }

onPlayerJoin

#

@EventHandler
    public void onPlayerLeave(PlayerQuitEvent e){
        Player player = e.getPlayer();
        HypixelSkillCore plugin = HypixelSkillCore.getInstance();
        player.getPersistentDataContainer().set(plugin.getKey() , plugin.getType(), plugin.getPlayer(player.getUniqueId()));
    }

playerLeave

#

private ConfigurationSerializableDataType<HypixelPlayer> type = new ConfigurationSerializableDataType<>(HypixelPlayer.class);
    private NamespacedKey key;

creating the key and the type

#

key = new NamespacedKey(this, "key");
setting the key

#

in onEnable

ashen grail Jun 28, 2023, 10:58 AM

#

?paste the WHOLE hypixel player class

inland willowBOT Jun 28, 2023, 10:58 AM

#

https://paste.md-5.net/

eternal swallow Jun 28, 2023, 10:59 AM

#

i have to use another pastebin

#

wait wtf

#

cannot resolve symbol combat?

#

who made intellij idea

#

i want to talk with him... just talk nothing else

#

i got more serious problems this one for later

#

can i just paste the code on a public repository of mine in github?

#

https://gist.github.com/amirparsab90-maker/266802707623c522972255dda4194983

#

@ashen grail here u go

ashen grail Jun 28, 2023, 11:12 AM

#

the map passed to the map constructor doesnt contain "stats_defense" or sth. Not 100% sure because you changed your code after you got the stacktrace

#

one of these does not exist in the map

eternal swallow Jun 28, 2023, 11:12 AM

#

leme check the serialize method...

#

heath... WTF IS WRONG WITH ME WHAT IS HEATH ITS HEALTH

#

i stayed awake 9+ hours to fix a stupid spelling mistake

#

leme just replace my deprecated way of setting the player health and then i will test it out

eternal swallow Jun 28, 2023, 11:37 AM

#

@ashen grail thanks for wasting 9 hours of your life helping me fix this stupid typo

#[IMMPORTANT] Error(the PlayerQuitEvent Included)