Plugin drops unwanted item | SpigotMC | Page 1

scenic knoll Oct 15, 2022, 4:26 PM

#

Could someone help me fix the bug in plugin I made year ago? I have been coding in C# recently so I don't remember java. https://hastebin.com/afuxilihuv.java the plugin drops steve head with player one for some reason, how could I fix it?

prime notch Oct 15, 2022, 4:35 PM

#

so it drops both heads?

scenic knoll Oct 15, 2022, 4:40 PM

#

steve head and player one

prime notch Oct 15, 2022, 4:44 PM

#

is this multiversion or something, i dont get the point of the 2 playerHead ='s

scenic knoll Oct 15, 2022, 4:48 PM

#

I don't remember why there are two of them

prime notch Oct 15, 2022, 4:49 PM

#

remove the try catch and change ItemStack playerHead to ItemStack playerHead = new ItemStack(Material.PLAYER_HEAD, 1);

scenic knoll Oct 15, 2022, 6:34 PM

#

Now it gives 2 playerheads

scenic knoll Oct 15, 2022, 7:05 PM

#

You know what may be causing the 2nd one to drop?

prime notch Oct 15, 2022, 8:32 PM

#

Check the drops adding

#

could be adding it twice

scenic knoll Oct 16, 2022, 7:05 AM

#

I tried removing the bottom itemstack but it still dropped 2

prime notch Oct 16, 2022, 7:28 AM

#

send the updated code

scenic knoll Oct 16, 2022, 7:29 AM

#

https://hastebin.com/upiwizadaq.swift

#

dont mind the stuff behind //

prime notch Oct 16, 2022, 7:33 AM

#

public class Getkilled implements Listener {
    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent event) {
        Player getKilled  = event.getEntity();
        String killerName = getKilled.getKiller().getName();

        if (event.getEntity().getKiller() == null) return;

        ItemStack playerHead = new ItemStack(Material.PLAYER_HEAD, 1);

        SkullMeta meta = (SkullMeta) playerHead.getItemMeta();
        meta.setOwner(getKilled.getName());
        meta.setLore(Arrays.asList("Killed by " + killerName)
        playerHead.setItemMeta(meta);

        getKilled.getWorld().dropItemNaturally(getKilled.getLocation(), playerHead);
    }
}

scenic knoll Oct 16, 2022, 7:35 AM

#

thank you so much

#

It works now

prime notch Oct 16, 2022, 7:40 AM

#

np

scenic knoll Oct 16, 2022, 6:00 PM

#

How can I make a second lore line?

prime notch Oct 16, 2022, 6:16 PM

#

meta.setLore(Arrays.asList("Killed by " + killerName, "Lore Line 2"))

scenic knoll Oct 16, 2022, 6:40 PM

#

oh it goes in the same bracket

prime notch Oct 16, 2022, 6:40 PM

#

just a comma between differnet lines

scenic knoll Oct 16, 2022, 6:40 PM

#

yea, tried to put the other text in extra brackets after comma before

prime notch Oct 16, 2022, 6:41 PM

#

ah lol

scenic knoll Oct 17, 2022, 2:28 PM

#

How can I change color and make text for example bold in the item lore?

prime notch Oct 17, 2022, 2:50 PM

#

meta.setLore(Arrays.asList(ChatColor.GREEN.toString() + ChatColor.BOLD + "Killed by " + killerName, "Lore Line 2"))

scenic knoll Oct 17, 2022, 2:53 PM

#

okay, thank you

scenic knoll Oct 19, 2022, 3:25 PM

#

Hello once again, how can I make so the color1 and format1 can be controlled from config?
code: https://hastebin.com/uwazenunop.swift
config: https://hastebin.com/odihamuyed.apache

Hastebin: Send and Save Text or Code Snippets for Free | Toptal®

Hastebin is a free web-based pastebin service for storing and sharing text and code snippets with anyone. Get started now.

Hastebin: Send and Save Text or Code Snippets for Free | Toptal®

Hastebin is a free web-based pastebin service for storing and sharing text and code snippets with anyone. Get started now.

prime notch Oct 19, 2022, 3:35 PM

#

Create a file called config.yml in the resources folder and add the default there then you can use that instead of copying defaults another way

scenic knoll Oct 19, 2022, 3:38 PM

#

The second one is my config file that I created

prime notch Oct 19, 2022, 3:54 PM

#

config:

Color1: "WHITE"
Format1: "ITALIC"
Color2: "WHITE"
Format2: "ITALIC"
Drop Chance: 1.0
  # Color1 Is color of the killer name and Format1 is format aka bold, italic and so one, for kill date is color2 and format2
  # Write exactly as in the link, https://hub.spigotmc.org/javadocs/spigot/org/bukkit/ChatColor.html
  # It must be in " "
  # Drop chance: 1.0
  # 1.0 = 100%, 0.1 = 10%, 0 = 0%, 0 = disabled

Code:

https://paste.md-5.net/usigitalak.java

project formatting:

scenic knoll Oct 19, 2022, 5:05 PM

#

Does the drop chance code work with any percentage or only with 100% and 10%?

prime notch Oct 19, 2022, 5:08 PM

#

only 1.0 and 0.1 because thats what the comments on config said

#

its not hard to make it work with 100.0 and between 1.0

scenic knoll Oct 19, 2022, 5:30 PM

#

Probally the most stupid question yet, but how do I change so when I build the plugin jar version wont always be 1.0-snapshot?

prime notch Oct 19, 2022, 5:31 PM

#

maven or gradle

scenic knoll Oct 19, 2022, 5:32 PM

#

maven

prime notch Oct 19, 2022, 5:33 PM

#

send your pom

#

?paste

#

fuck

#

https://paste.md-5.net

scenic knoll Oct 19, 2022, 5:35 PM

#

where do I find it?

#

nvm

#

📎 pom.xml

#

Do I have to change it in pom?

prime notch Oct 19, 2022, 5:37 PM

#

<version>1.0-SNAPSHOT</version> im guessing

scenic knoll Oct 19, 2022, 5:57 PM

#

Do I need to write some code more for the plugin to actually create config file when in server?

prime notch Oct 19, 2022, 5:58 PM

#

just needs the config in resources and it should do it automatically from the saveDefaultConfig(); on onEnable

scenic knoll Oct 19, 2022, 6:04 PM

#

btw is the chance thing correct?

prime notch Oct 19, 2022, 6:05 PM

#

the code that should be used is on https://paste.md-5.net/usigitalak.java

#

just copy that

#

just change the package name up top and class name

scenic knoll Oct 19, 2022, 6:05 PM

#

isn't the percentage for 100 or 10% only?

prime notch Oct 19, 2022, 6:06 PM

#

do you want Drop Chance in config to be a 100 to 1 percent

#

so Drop Chance: 95 has a 95% chance of dropping

scenic knoll Oct 19, 2022, 6:07 PM

#

prime notch do you want Drop Chance in config to be a 100 to 1 percent

yes

prime notch Oct 19, 2022, 6:08 PM

#

@EventHandler
    public void onPlayerDeath(PlayerDeathEvent event) {
        int chance = getConfig().getInt("Drop Chance");


        // Config
        String color1 = getConfig().getString("Color1");
        String format1 = getConfig().getString("Format1");
        String color2 = getConfig().getString("Color2");
        String format2 = getConfig().getString("Format2");

        Player getKilled  = event.getEntity();
        String killerName = getKilled.getKiller().getName();
        // LocalDate date = LocalDate.now();
        Date date = Calendar.getInstance().getTime();
        DateFormat formatter = new SimpleDateFormat("dd/MM/yyyy");
        String today = formatter.format(date);


        if (event.getEntity().getKiller() == null) return;

        ItemStack playerHead = new ItemStack(Material.PLAYER_HEAD, 1);

        SkullMeta meta = (SkullMeta) playerHead.getItemMeta();
        meta.setOwner(getKilled.getName());
        Bukkit.getLogger().info(getConfig().getString("drop chance" + "is my name"));
        meta.setLore(Arrays.asList(ChatColor.of(color1).toString() + ChatColor.of(format1) + "Killed by " + killerName, ChatColor.of(color2).toString() + ChatColor.of(format2) + "Killed on "+ today ));
        playerHead.setItemMeta(meta);
        Double randomChance = ThreadLocalRandom.current().nextInt(0, 100);
        if (chance > randomChance) getKilled.getWorld().dropItemNaturally(getKilled.getLocation(), playerHead);


    }

scenic knoll Oct 19, 2022, 6:12 PM

#

What does it want to int?

prime notch Oct 19, 2022, 6:12 PM

#

oh change the first Double to int

#

ln 56

scenic knoll Oct 19, 2022, 6:29 PM

#

for some reason it didn't make a config file in server nor drops a head

prime notch Oct 19, 2022, 6:29 PM

#

do you have the onEnable code

scenic knoll Oct 19, 2022, 6:30 PM

#

yes

prime notch Oct 19, 2022, 6:30 PM

#

is the default config in the resources folder

scenic knoll Oct 19, 2022, 6:30 PM

#

#

I think so

prime notch Oct 19, 2022, 6:31 PM

#

i know the problem

#

Is main or getkilled your main class

#

if there isnt anything in main, delete it

scenic knoll Oct 19, 2022, 6:33 PM

#

there's this stuff but idk if it's needed

prime notch Oct 19, 2022, 6:33 PM

#

remove the extends JavaPlugin and onEnable from getKilled

#

ill get the code for di

#

Main should have ```
@Override
public void onEnable() {
// Plugin startup logic
saveDefaultConfig();
getServer().getPluginManager().registerEvents(new GetKilled(this), this);

#

oh wait forgot something

#

And getKilled should look like

public class GetKilled implements Listener {
    private final MainClassName plugin;

    public CurrentClassName(MainClassName plugin) {
        this.plugin = plugin;
    }

    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent event) {
        int chance = plugin.getConfig().getDouble("Drop Chance");


        // Config
        String color1 = plugin.getConfig().getString("Color1");
        String format1 = plugin.getConfig().getString("Format1");
        String color2 = plugin.getConfig().getString("Color2");
        String format2 = plugin.getConfig().getString("Format2");

        Player getKilled  = event.getEntity();
        String killerName = getKilled.getKiller().getName();
        // LocalDate date = LocalDate.now();
        Date date = Calendar.getInstance().getTime();
        DateFormat formatter = new SimpleDateFormat("dd/MM/yyyy");
        String today = formatter.format(date);


        if (event.getEntity().getKiller() == null) return;

        ItemStack playerHead = new ItemStack(Material.PLAYER_HEAD, 1);

        SkullMeta meta = (SkullMeta) playerHead.getItemMeta();
        meta.setOwner(getKilled.getName());
        Bukkit.getLogger().info(plugin.getConfig().getString("drop chance" + "is my name"));
        meta.setLore(Arrays.asList(ChatColor.of(color1).toString() + ChatColor.of(format1) + "Killed by " + killerName, ChatColor.of(color2).toString() + ChatColor.of(format2) + "Killed on "+ today ));
        playerHead.setItemMeta(meta);
        int randomChance = ThreadLocalRandom.current().nextDouble(0.0, 100.0);
        if (percentage > randomChance) getKilled.getWorld().dropItemNaturally(getKilled.getLocation(), playerHead);


    }
}

scenic knoll Oct 19, 2022, 6:40 PM

#

theres some errors now

prime notch Oct 19, 2022, 6:41 PM

#

chance the top to the correct stuff, its just placeholders

#

private final MainClassName plugin;

public CurrentClassName(MainClassName plugin) {
        this.plugin = plugin;
    }

scenic knoll Oct 19, 2022, 6:41 PM

#

oh ok

prime notch Oct 19, 2022, 6:41 PM

#

MainClassName = Main
CurrentClassName = Getkilled

scenic knoll Oct 19, 2022, 6:42 PM

#

this.plugin too?

prime notch Oct 19, 2022, 6:44 PM

#

this.plugin is fine to stay

scenic knoll Oct 19, 2022, 6:45 PM

#

and what about all these cannot resolve method "getConfig()"

prime notch Oct 19, 2022, 6:45 PM

#

should fix itself after getting the correct class names

scenic knoll Oct 19, 2022, 6:51 PM

#

it says it needs int but there is int

prime notch Oct 19, 2022, 6:51 PM

#

change nextDouble to nextInt

#

numbers to 0 and 100

#

int randomChance = ThreadLocalRandom.current().nextInt(0, 100);

scenic knoll Oct 19, 2022, 6:53 PM

#

hmm

prime notch Oct 19, 2022, 6:53 PM

#

numbers to 0 and 100

#

nextInt(0, 100)

scenic knoll Oct 19, 2022, 6:54 PM

#

oops

#

but isn't it declared as public?

prime notch Oct 19, 2022, 6:57 PM

#

class name is wrong

#

Getkilled not GetKilled

#

forgot to change the int and chance stuff

@EventHandler
    public void onPlayerDeath(PlayerDeathEvent event) {
        int chance = plugin.getConfig().getDouble("Drop Chance");
``` should be the top of the event sorry

scenic knoll Oct 19, 2022, 7:01 PM

#

it gives me error that it should be int not double so getDouble to getInt?

prime notch Oct 19, 2022, 7:01 PM

#

correct

prime notch Oct 19, 2022, 7:01 PM

#

prime notch `` int randomChance = ThreadLocalRandom.current().nextInt(0, 100);``

.

scenic knoll Oct 19, 2022, 7:02 PM

#

prime notch forgot to change the int and chance stuff ``` @EventHandler public void onP...

I meant about this one

prime notch Oct 19, 2022, 7:02 PM

#

oh yeah

#

forgot about that

#

sorry

scenic knoll Oct 19, 2022, 7:03 PM

#

no problem

#

also ty for all the help this far

prime notch Oct 19, 2022, 7:04 PM

#

np lol

#

    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent event) {
        int chance = plugin.getConfig().getInt("Drop Chance");


        // Config
        String color1 = plugin.getConfig().getString("Color1");
        String format1 = plugin.getConfig().getString("Format1");
        String color2 = plugin.getConfig().getString("Color2");
        String format2 = plugin.getConfig().getString("Format2");

        Player getKilled  = event.getEntity();
        String killerName = getKilled.getKiller().getName();
        // LocalDate date = LocalDate.now();
        Date date = Calendar.getInstance().getTime();
        DateFormat formatter = new SimpleDateFormat("dd/MM/yyyy");
        String today = formatter.format(date);


        if (event.getEntity().getKiller() == null) return;

        ItemStack playerHead = new ItemStack(Material.PLAYER_HEAD, 1);

        SkullMeta meta = (SkullMeta) playerHead.getItemMeta();
        meta.setOwner(getKilled.getName());
        Bukkit.getLogger().info(plugin.getConfig().getString("drop chance" + "is my name"));
        meta.setLore(Arrays.asList(ChatColor.of(color1).toString() + ChatColor.of(format1) + "Killed by " + killerName, ChatColor.of(color2).toString() + ChatColor.of(format2) + "Killed on "+ today ));
        playerHead.setItemMeta(meta);
        int randomChance = ThreadLocalRandom.current().nextInt(0, 100);
        if (chance >= randomChance) getKilled.getWorld().dropItemNaturally(getKilled.getLocation(), playerHead);


    }
``` should be the 100% correct code lol

scenic knoll Oct 20, 2022, 4:36 AM

#

Welp I forgot yesterday but I hope it wouldn't be too hard to be able to separately disable line 1 of lore and line 2 from config, that would be the final thing that I would need to add to the plugin.

prime notch Oct 20, 2022, 9:29 AM

#

Thats not hard to do, ill get it when im on my pc

scenic knoll Oct 20, 2022, 9:36 AM

#

I am in school rn so you don't have to hurry

prime notch Oct 20, 2022, 9:54 AM

#

    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent event) {
        ArrayList lore = new ArrayList();
        int chance = plugin.getConfig().getInt("Drop Chance");
        Player getKilled  = event.getEntity();
        String killerName = getKilled.getKiller().getName();
        
        // Date
        Date date = Calendar.getInstance().getTime();
        DateFormat formatter = new SimpleDateFormat("dd/MM/yyyy");
        String today = formatter.format(date);

        // Config
        String color1 = plugin.getConfig().getString("Color1");
        String format1 = plugin.getConfig().getString("Format1");
        String color2 = plugin.getConfig().getString("Color2");
        String format2 = plugin.getConfig().getString("Format2");
        
        String line1Enabled = plugin.getConfig().getString("Line1");
        String line1 = ChatColor.of(color1).toString() + ChatColor.of(format1) + "Killed by " + killerName;
        String line2Enabled = plugin.getConfig().getString("Line2");
        String line2 = ChatColor.of(color2).toString() + ChatColor.of(format2) + "Killed on " + today;
        
        if (line1Enabled.equals("enabled")) lore.add(line1);
        if (line2Enabled.equals("enabled")) lore.add(line2);

        if (event.getEntity().getKiller() == null) return;

        ItemStack playerHead = new ItemStack(Material.PLAYER_HEAD, 1);

        SkullMeta meta = (SkullMeta) playerHead.getItemMeta();
        meta.setOwner(getKilled.getName());
        Bukkit.getLogger().info(plugin.getConfig().getString("drop chance" + "is my name"));
        meta.setLore(lore);
        playerHead.setItemMeta(meta);
        int randomChance = ThreadLocalRandom.current().nextInt(0, 100);
        if (chance >= randomChance) getKilled.getWorld().dropItemNaturally(getKilled.getLocation(), playerHead);


    }

scenic knoll Oct 20, 2022, 3:35 PM

#

for some reason it doesn't seem to want to drop the head

prime notch Oct 20, 2022, 3:38 PM

#

whats drop chance in config

scenic knoll Oct 20, 2022, 3:38 PM

#

100

prime notch Oct 20, 2022, 3:38 PM

#

add a System.out.println for chance and random chance to check its not doing the math correctly

scenic knoll Oct 20, 2022, 4:02 PM

#

and where do I see when it prints them?

prime notch Oct 20, 2022, 4:03 PM

#

console

scenic knoll Oct 20, 2022, 4:27 PM

#

found a thing

📎 message.txt

prime notch Oct 20, 2022, 4:43 PM

#

oh add

Line1: enabled
Line2: enabled
``` to config.yml on server and resource

#Plugin drops unwanted item