wait no
#help-development
mortal hare
where inner static classes seems to be a way to solve some problems
echo basalt
imajin having a stroke
mortal hare
?paste
undone axleBOT
ivory sleet
I mean its nice for iterators etc
echo basalt
why do I hate this code so much
mortal hare
it just looks weird
thats all
but sometimes inner classes are a good way to encapsulate some parts of the code
which you wouldnt want to expose
quaint mantle
public static Nameable CHEST_9X1 = Nameable.CHEST_9X1;
public static Nameable CHEST_9X2 = Nameable.CHEST_9X2;
public static Nameable CHEST_9X3 = Nameable.CHEST_9X3;
public static Nameable CHEST_9X4 = Nameable.CHEST_9X4;
public static Nameable CHEST_9X5 = Nameable.CHEST_9X5;
public static Nameable CHEST_9X6 = Nameable.CHEST_9X6;
someone should make a lombok generator for stuff like this
@Wrapper
echo basalt
we can tell
chrome beacon
Why no final
ivory sleet
^
echo basalt
I mean you can just write with lombok and call delombok whenever you start to lose touch with reality
mortal hare
thank you
cyan compass
Why does Player.Spigot.sendMessage say that the symbol of sendMessage isn't found?
quaint mantle
probably because it cant be found
cyan compass
well yes but shouldn't it be found?
https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/entity/Player.Spigot.html Cause this says it should
quaint mantle
are you providing a basecomponent?
echo basalt
Player#spigot().sendMessage
quaint mantle
or a vararg basecomponent
echo basalt
you might be calling the static class
quaint mantle
or a chatmessagetype and basecomponent
or a chestmessagetype and a vararg basecomponent
cyan compass
Player#spigot().sendMessage
Lowercase doesn't showup
mortal hare
sendMessage() is a method not a field, if you wrote it like that, ofc it wouldnt work. Just saying
echo basalt
Lowercase doesn't showup
I mean like
quaint mantle
= instance call
echo basalt
Player player = ...;
player.spigot().sendMessage
thats not how it works dude
cyan compass
yes i know i need to provide fields to send message but send message doesn't exist
cyan compass
ah
quaint mantle
notice the hashtag meaning an instance call
mortal hare
spigot() method is not necessary here, public inner class exposed to that (nvm)
tepid ore
I know that, but are there any other benefits? I always make them static, but why can you make them non static
I have like one occasion where I "need" non static
cyan compass
I'm just trying to figure out how to do an action bar :P
quaint mantle
quaint mantle
yes
tepid ore
I'm just trying to figure out how to do an action bar :P
player.spigot().sendMessage(ChatMessageType.ACTION_BAR, new TextComponent(message));
radiant cedar
seems not to not work for me, my yml is still empty
cyan compass
`player.spigot().sendMessage(ChatMessageType.ACTION_BAR, new TextComponent(messa...
Thanks. I was sure i tried that earlier but i must have made a typo
mortal hare
I have like one occasion where I "need" non static
i haven't used non static class that much myself, so i can't really tell you why, as I said previously i think that feature exists for you to provide outer class private fields to the inner class, without using the getters of the outer class
tepid ore
i haven't used non static class that much myself, so i can't really tell you why...
Yeah, that is the only reason I make them non-static
radiant cedar
JavaPlugin#saveConfig()
do i do config.save(new File(path))
quaint mantle
get your plugin instance and call saveConfig
radiant cedar
path
next stratus
Use a config manager ;)
mortal hare
public class Foo {
private final id;
public Foo(int id) {
this.id = id;
}
class Bar {
private final int barId;
public Bar() {
this.barId = Foo.this.id;
}
}
}
this should be legal
afaik
even if the field of outer class is private
you could still access it via inner class
tepid ore
You don't need Foo.this.id, or do you?
ivory sleet
I mean thats not the point of it
tepid ore
Am i dum
ivory sleet
you're supposed to access the outer class field directly
mortal hare
You don't need Foo.this.id, or do you?
that's an example
ivory sleet
thats the benefit
tepid ore
that's an example
I mean, you only need id
mortal hare
thats the benefit
that is what I was trying to portray
radiant cedar
When I have a String str = ChatColor.BLUE + "something";
mortal hare
I mean, you only need id
That's an EXAMPLE. This is not real code
i'm not going to implement
radiant cedar
When I have a String str = ChatColor.BLUE + "something";
how can i remove ChatColor.BLUE
mortal hare
Windows 11 just for an explanation
radiant cedar
just by str
tepid ore
That's an EXAMPLE. This is not real code
Yeah I get it, it was a badly formulated question
mortal hare
Day 158. I still have a fobia for Object @NotNull []
echo basalt
lmao
echo basalt
Day 158. I still have a fobia for ``Object @NotNull []``
public static Object @NotNull myArray[];
radiant cedar
when i dont now what that "something" is
ivory sleet
`public static Object @NotNull myArray[];`
oh my... this is unholy
quaint mantle
ew
echo basalt
:)
ivory sleet
(:
mortal hare
i wonder if this is possible to do with C style notation
echo basalt
fun
mortal hare
Object foo[]; <- this is still legal in java
crisp steeple
even better
mortal hare
I hope future java versions will steal the idea of operator overloading from C++
crisp steeple
ivory sleet
there's nothing as confusing as operator overloading ngl
but can also be nice
altho its not in javas style to add that type of shortcut for the given verbosity itd substitute
echo basalt
public static void dA(Test. @NotNull Test2<@Nullable Test.Test3>.NonNls[] @NotNull bC) {
return;
}
hmm
Nms be like
bet your decompiler has a stroke upon seeing that
crisp steeple
radiant cedar
When I have a String str = ChatColor.BLUE + "something";
how can i remove ChatColor.BLUE
when i dont know "something"
hollow arch
Hey hey,
Is there a way to get the itemstack that's being popped out of the itemframe?
Seem as though the one you can get with EntityDamageEvent#getEntity#getItem is a different one?
hollow arch
yeah probably
I don't think those fire since you are not breaking the item frame, just popping the item out
hollow arch
I don't think those fire since you are not breaking the item frame, just popping...
Just gonna cancel the event and spawn in my own item, ty for the help
ivory sleet
native has always been available pretty much
crisp steeple
think its probably always been there tbh and i just didnt notice
yea
dont really see how it could be used for anything though without major java compiler hacks
ivory sleet
jni
crisp steeple
i am not smart enough to use that
mortal hare
listeners do get disabled if the plugin gets disabled automatically, right?
lost matrix
There is nothing smart about that. All you do is compile some dlls and call functions from java.
If you know some C(++) then this is not exactly black magic. But since JIT is a thing i dont really see
a benefit. Maybe for AI applications or CUDA stuff.
ivory sleet
listeners do get disabled if the plugin gets disabled automatically, right?
myes
iirc thats the implementation
mortal hare
what do you need to call explicitly when disabling from the API
except for the shutdown plugin things
ivory sleet
not much
eternal night
ivory sleet
I mean
eternal night
if that is what you mean
ivory sleet
strong references to other plugins should be dropped
thats bout it
and yeah I mean external io connections and streams should be closed probably
ig also services such as ExecutorService instances might deserve to be properly terminated
compact crane
Why is the BlockBreakEvent e.getDrops not exactly the number of items when I break the block with Fortune3? Can I query it to see how much is really dropping?
crisp steeple
try event.getBlock().getDrops(event.getPlayer().getItemInHand());
compact crane
Ok, i try
lost matrix
Why is the BlockBreakEvent e.getDrops not exactly the number of items when I bre...
Look into the BlockDropItemEvent
tepid ore
try `event.getBlock().getDrops(event.getPlayer().getItemInHand());`
Will that work for an air item stack? Aka return an empty collection?
crisp steeple
probably, or use blockdropitemevent like smile said
lost matrix
Will that work for an air item stack? Aka return an empty collection?
Yes. It will return exactly the items that would be obtained.
tepid ore
Yes. It will return exactly the items that would be obtained.
Ohhh, exciting
I need that
tender shard
I still wonder
why the returned list of drops is only partly mutable
like, you can remove items, but you can't add any
it seems a bit weird to me
past brook
anyone know what is going wrong here? it isnt a crash but it is annoying
https://cdn.discordapp.com/attachments/704402403470082199/974817199082598400/latest.log
crisp steeple
?paste
undone axleBOT
worldly ingot
Whatever your chunk generator is is not doing a great job
worldly ingot
core.jar//com.cmdpro.servercore.PlantPopulator.populate(PlantPopulator.java:30) is what's in the trace
past brook
hm
lost matrix
core.jar//com.cmdpro.servercore.PlantPopulator.populate fks up your chunk loading
past brook
ill send you the code in there
worldly ingot
Actually seems to be a few different places in your populators. TreePopulator as well
crisp steeple
it seems like it just places so many trees on the main thread it times out
worldly ingot
And plants, yeah, that's most likely the case
lost matrix
Im suspecting that the generator calls for the chunk so generation is triggered in a recursive loop.
Or it just takes way too long
worldly ingot
Already right off the bat, for (int i = 0; i < random.nextInt(50, 256); i++) {
You're going to want to generate that number once
Remember that that condition is checked and evaluated every iteration
worldly ingot
It would run 256 times at most
lost matrix
You should not base your generation on a single chunk. Rather use some noise algo like OpenSimple to create
a double[][]. Then generate a tree if a field has a certain value (>0.9 for example)
After that you should play around with the frequency and amplitude to get thin high amps for single trees.
worldly ingot
I'd +1 that, yeah. I was about to suggest something a bit more mathematical
For convenience by the way, there is World#getHighestBlockAt() and #getHighestBlockYAt(). No need to loop it yourself. You can make use of height maps to ignore water or leaves
There's actually one specifically for world generation, https://helpch.at/docs/1.16.2/org/bukkit/HeightMap.html#WORLD_SURFACE_WG
Spigot does have noise generators by the way
Perlin and Simplex
dusk flicker
noise
tender shard
I only know that term "octave" from music etc
kindred valley
how do i get all the args that the player entered for the command
crisp steeple
just use the args array?
kindred valley
just use the args array?
no i mean i want to take how long does players' message's length
dusk flicker
args.length?
kindred valley
i know that shit wtf
tender shard
I think they want to do String.join(" ",args).length
kindred valley
i cant explain myself
crisp steeple
(command.getName() + " " + String.join(" ", args)).length
dusk flicker
it joins the provided list together
tender shard
well String.join does this:
args[0] = "my";
args[1] = "name";
String result = String.join(" ", args); // It's now "my name";
dusk flicker
with the string provided seperating
lost matrix
i cant explain myself
Where do you need it? Because there are some events that could be helpful
kindred valley
Where do you need it? Because there are some events that could be helpful
actually i want to make a message system when player enters arguments i want to calculate how long is that argument is
crisp steeple
if you're just trying to add a character limit on commands CommandPreprocessEvent
tender shard
actually i want to make a message system when player enters arguments i want to ...
then, as everyone already told you, use String.join on the args array and use " " for joining
kind hatch
String#length()?
lost matrix
actually i want to make a message system when player enters arguments i want to ...
A message has no arguments
dusk flicker
do you mean in a command or like a player talking in chat
crisp steeple
actually i want to make a message system when player enters arguments i want to ...
String.join(" ", args).length
tender shard
A message has no arguments
they probably have a command like "/msg asd asd asd asd asda sdasdadasdsd"
crisp steeple
its that simple
kindred valley
do you mean in a command or like a player talking in chat
commands
kindred valley
they probably have a command like "/msg asd asd asd asd asda sdasdadasdsd"
yes
dusk flicker
then you have had your answer 5x over
lost matrix
they probably have a command like "/msg asd asd asd asd asda sdasdadasdsd"
Ah that makes sense
crisp steeple
i didnt know String.join existed for a while and for the longest time i was manually stringing arguments together ;-;
tender shard
i didnt know String.join existed for a while and for the longest time i was manu...
F
it exists since Java 1.0 IIRC lol
lost matrix
new approach:
int size = String.join(" ", args).length
idk why i never thought to check for a method like that
lost matrix
Never seen before
dusk flicker
it exists since Java 1.0 IIRC lol
yep JDK1.0
crisp steeple
life got so much easier after i found it
kindred valley
new approach:
```java
int size = String.join(" ", args).length
```
so this shows what
arg length?
dusk flicker
the length of all args combined by a space
tender shard
so this shows what
bruh sorry but, can you read?
undone axleBOT
Here are some links to get you started on learning Java:
- https://www.codecademy.com/learn/learn-java
- https://www.sololearn.com/learning/1068
- https://www.learnjavaonline.org/
- https://programmingbydoing.com/
- https://docs.oracle.com/javase/tutorial/java/index.html
The last one is the only official one, however some of those concepts assume that you already know a bit about programming.
kindred valley
?
torn shuttle
meanwhile if you're learning unity you have to unlearn programming and get ready to commit some programming war crimes
dusk flicker
war crimes are fun
echo basalt
I wonder if we can make a sound-based world generator
tender shard
for example, this prints "15":
public static void main(String[] args) {
String[] message = new String[] {"my","name","is","jeff"};
System.out.println(String.join(" ",message).length());
}
Input: /msg some arguments in msg
args: ["some", "arguments", "in", "msg"]
After join: "some arguments in msg"
It has been explained several times now
dusk flicker
as long as you are the one doing them
crisp steeple
String[] test = new String[]{"this", "is", "a", "test"};
String.join(" ", test) ----> "this is a test"
tender shard
for example, this prints "15":
```java
public static void main(String[] args...
because that's the length of "my name is jeff"
torn shuttle
war crimes are fun
not when you're committing them against your future self
crisp steeple
we all made an example at the same time lol
echo basalt
where we scream at a mic and the louder we scream, the taller the mountains become
and background noise makes trees or something
and if we say wowowowowowo we can end up with some very funky terrain 🤔
torn shuttle
and background noise makes trees or something
please let me know if you are moving anywhere so I make sure I am always at least three cities over from you
kindred valley
okay you dont need to be moody
tender shard
okay you dont need to be moody
noone is being "moody"
lost matrix
and background noise makes trees or something
You can directly feed the amplitudes and frequency into some noise algo
echo basalt
yeah that's where I was going off of
kindred valley
noone is being "moody"
didnt mean you
echo basalt
and then the same noise will always make the same world
dusk flicker
"noone"
echo basalt
and then we make NFTs out of screams
dusk flicker
fuck NFTs
crisp steeple
i am mooding right now
torn shuttle
the only terrain generator that might get a dmca takedown notice
dusk flicker
wait what
echo basalt
or maybe grab an image and convert pixel data to noise somehow
echo basalt
I wonder what an FBI-warning generated world would be
torn shuttle
or maybe grab an image and convert pixel data to noise somehow
you are slowly recreating perlin noise
echo basalt
yeah except instead of using just funky numbers we can use memes
what if we grab every frame on the shrek movie and convert it to noise, feed that all into an algorithm and end up with a great world
lost matrix
what if we grab every frame on the shrek movie and convert it to noise, feed tha...
And layer despacito on top of it
echo basalt
yes
echo basalt
the audio makes the ores, the video makes the terrain itself
if it's hella loud, there will be more ores
torn shuttle
this idea is as worthless as it would be likely to get 3 million views on youtube if you made a video about making it
tender shard
rather use this song I made out of a friend's cough https://soundcloud.com/le-crochet/schoko-hustet
echo basalt
Le crochet reminds me of Fish au chocolat
echo basalt
this idea is as worthless as it would be likely to get 3 million views on youtub...
probably
tender shard
"Le Crochet" is french for "the hook" iirc
echo basalt
and maybe start a trend off of meme worlds
and get famos
either that or I'm extremely sleep deprived
kindred valley
I tried to remove arg[0] with for loop but its colliding
how can i remove arg[0] without any exception
tender shard
either that or I'm extremely sleep deprived
you cannot just "remove" elements from an array
You have to create a new array to "remove" the first element
tepid ore
how can i remove arg[0] without any exception
You can set them to null, or shorten the array
tender shard
I use this to do it:
public static <T> T[] shiftArray(T[] original) {
if(original.length == 0) return original;
T[] shifted = (T[]) Array.newInstance(original.getClass().getComponentType(),original.length-1);
if(shifted.length == 0) return shifted;
System.arraycopy(original, 1, shifted, 0, shifted.length);
return shifted;
}
obviously you can replace "T" with "String" if you only need it for strings
echo basalt
you replied to the wrong message and I got extremely confused
echo basalt
That does seem like a fairly simple method hmm
I wonder if it's possible to simplify it further
lost matrix
I use this to do it:
```java
public static <T> T[] shiftArray(T[] original) ...
Those shenanigans again... Just use a Deque.
quaint mantle
only way to block opening crafting tables is with interact? bc inventoryopen and checking the type didn't work
tender shard
Those shenanigans again... Just use a Deque.
no, why would I lol
echo basalt
only way to block opening crafting tables is with interact? bc inventoryopen and...
check the holder or something
tender shard
only way to block opening crafting tables is with interact? bc inventoryopen and...
just check InventoryOpenEvent?
tender shard
where's the problem?
tender shard
what type did you compare to?
quaint mantle
CRAFTING
quaint mantle
lemme check
lost matrix
no, why would I lol
less overhead, both cpu and memory wise. You also have one less point in your system that can fail and you have to maintain.
quaint mantle
ah
tender shard
less overhead, both cpu and memory wise. You also have one less point in your sy...
tbh I doubt it
quaint mantle
yea i didn't do workbench
tender shard
creating a deque just to copy an array?
quaint mantle
thanks
tender shard
np
lost matrix
creating a deque just to copy an array?
To easily pop args from your array. Ill write a jmh benchmark. Interesten in what is faster to be honest.
radiant cedar
can u only have the given ChatColors for colors in scoreboard and chat
or can i use any custom color code
tender shard
can u only have the given ChatColors for colors in scoreboard and chat
scoreboards only support the 16 normal chat colors
chat supports hex colors
tender shard
idk, check the ChatColor class
dusk flicker
i thought scoreboard supported rgb
tender shard
hm maybe I'm wrong
tender shard
To easily pop args from your array. Ill write a jmh benchmark. Interesten in wha...
Array: 29300
Deque: 47600
dusk flicker
https://www.spigotmc.org/threads/1-16-scoreboard-objective-score-with-rgb-hex-color.468079/ looks like its possible
but not fun
kindred valley
I use this to do it:
```java
public static <T> T[] shiftArray(T[] original) ...
hmm
lost matrix
Array: 29300
Deque: 47600
Yeah thats not even remotely close to being a benchmark...
silent vigil
> Could not resolve all files for configuration ':Bungee:compileClasspath'.
> Could not find net.md-5:brigadier:1.0.16-SNAPSHOT.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/net/md-5/brigadier/1.0.16-SNAPSHOT/maven-metadata.xml
- https://repo.maven.apache.org/maven2/net/md-5/brigadier/1.0.16-SNAPSHOT/brigadier-1.0.16-SNAPSHOT.pom
- file:/C:/Users/Punchline/.m2/repository/net/md-5/brigadier/1.0.16-SNAPSHOT/maven-metadata.xml
- file:/C:/Users/Punchline/.m2/repository/net/md-5/brigadier/1.0.16-SNAPSHOT/brigadier-1.0.16-SNAPSHOT.pom
Required by:
project :Bungee > net.md-5:bungeecord-api:1.16-R0.4 > net.md-5:bungeecord-protocol:1.16-R0.4
Possible solution:
- Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html
``` error on attempting to compile with gradle, anyone know where to get the brigadier thing?why not? except for the obvious thing that I didn't run it 200 thousand times
echo basalt
Jmh tunes garbage collection and all
With accurate numbers, failure rates
Well
You're calling that code on another thread
Bukkit doesn't like it
Bukkit.isPrimaryThread
Returns true if you're on the main thread
lost matrix
why not? except for the obvious thing that I didn't run it 200 thousand times
Benchmark (amountOfArguments) Mode Cnt Score Error Units
ArrayVsDequeArgsPop.argsFromArrayCopy 2 avgt 4 25,643 ± 0,265 ns/op
ArrayVsDequeArgsPop.argsFromArrayCopy 3 avgt 4 49,742 ± 0,351 ns/op
ArrayVsDequeArgsPop.argsFromArrayCopy 4 avgt 4 71,057 ± 0,715 ns/op
ArrayVsDequeArgsPop.argsFromArrayCopy 5 avgt 4 96,647 ± 0,694 ns/op
ArrayVsDequeArgsPop.argsFromDequePoll 2 avgt 4 15,959 ± 0,099 ns/op
ArrayVsDequeArgsPop.argsFromDequePoll 3 avgt 4 32,533 ± 0,325 ns/op
ArrayVsDequeArgsPop.argsFromDequePoll 4 avgt 4 38,818 ± 0,238 ns/op
ArrayVsDequeArgsPop.argsFromDequePoll 5 avgt 4 40,677 ± 1,473 ns/op
https://paste.md-5.net/urugotayox.java
There is only a single time when copying the whole array is faster: When there are exactly 2 elements in the array.
lost matrix
```
Benchmark (amountOfArguments) Mode Cnt Scor...
And after that it gets quite bad quite fast
echo basalt
Use the scheduler to run the task on the main thread
tender shard
```
Benchmark (amountOfArguments) Mode Cnt Scor...
waiiit noooo
lost matrix
why not? except for the obvious thing that I didn't run it 200 thousand times
You have no idea when and how the jvm is warmed up. How the jit compiles during your tests, no averaging so a little hickup in your CPU from your browser or a discord
can invalidate a single measurement and so on.
tender shard
you cannot compare this
you are never turning the deque into an array again, do you?
tender shard
are you actually converting the deque into an array again?
lost matrix
Why would i? I thought this was used to simply pop args from an array
tender shard
Why would i? I thought this was used to simply pop args from an array
because people who want to remove an element from an array obviously need an array and not some random other thing
someone who says "how can I remove the first element of my T[]" wants a T[] as result and not a Deque<T>
otherwise they wouldn't have asked this question I guess
lost matrix
otherwise they wouldn't have asked this question I guess
Or its an xy question. Which is the case most of the time.
tender shard
Or its an xy question. Which is the case most of the time.
yeah probably
I mean I totally agree with you that a Deque<T> is probably more useful and also faster. But the question was "how to remove the first element of an array" and not "how to remove the first element of a deque"
and I think in 99.9999% of cases, the performance of both operations is really neglible
if someone is removing the first element of an array 10 thousand times per tick, they're doing something wrong anyway lol
lost matrix
true
My only point is: Dont reinvent the wheel
But i have no idea what this limpeex guy was talking about anyways...
tender shard
lol yeah I think they wanted to do sth like this:
have a /msg command, and a message can only have up to 500 letters or something
and obviously args[0] is probably the receiving player's name
so they wanted to turn args into args without the first element, then check if the "length" of the joined string is less than 500 or whatever
that's the only explanation that makes sense to me
lethal coral
If I'm integrating JDA into my plugin, should I be running most JDA-related things async?
compact haven
I use this to do it:
```java
public static <T> T[] shiftArray(T[] original) ...
not that this isn't over, but you could've just returned System.arraycopy(original, 1, original, 0, original.length - 1);
System#arraycopy() will automatically create a new array if the src and dest arrays are the same, so you're just doing legwork that it can do itself
sterile token
Hi want to know if possible to fix this issue - a friend has a custom enchant plugin which allow him to use unbreaking lvl 10 for example, but then you compare the armor with another and its the same as enchanting it with unbreaking lvl 3
quaint mantle
hello everyone
i am once again asking for assistance on how to make a certain entity glow for one player
ii am not very good with protocolib and my knowledge with packets is very basic
grand perch
shop:
blocks:
grass:
itemName: §7Grass Block
price:
buy: 10
sell: 5
dirt:
itemName: §7Dirt Block
price:
buy: 5
sell: 2
food:
steak:
itemName: §6Cooked Beef
price:
buy: 1
sell: 1
my goal:
for each item in blocks make an item and put it in the gui
how?
sterile token
```
shop:
blocks:
grass:
itemName: §7Grass Block
price:
...
A bit simply but i explain
First you ill need to loop the "food" section
sterile token
So you will have to loop each section with Config#getConfiguractionSection()#getKeys(false)
And then build the item and add to the menu
grand perch
So you will have to loop each section with Config#getConfiguractionSection()#get...
is this the method to get all items in the object???
sterile token
Explain a bit more
grand perch
hwat
sterile token
I didnt understand your question
grand perch
Have you worked with spigot api before?
yes but not with the FileConfiguration stuff
bcs i always just hardcode the configs
sterile token
Allright so i recommend forward learning that
Because if not its diff to explain
And my goal is you to understand how it works, not to just spoof the code
quaint mantle
sping spoof
sterile token
sping spoof
Not a good moment for shocking
wind tulip
Hey, can someone help me debug this error? I can't figure it out.
Error: https://pastebin.com/4s62fUqg
Library method: https://pastebin.com/L7xp7cTY
Call From Main Class: Bukkit.getOnlinePlayers().forEach(p -> DFSpigotLib.PlaySounds(p, new String[] {"Chime","Chime","Bit"}, new Location(p.getWorld(), 5.929617510431854, 50, 4.765213468406728, -73.46591f, 21.44098f), new float[][]{{2f, 0.749154f},{2f, 0.840896f},{2f, 2f}}, (long) 50));
summer scroll
So I have a plugin that can launch a fireball with custom damage, and it will damage every entity in 3 radius of the explosion, for some reason it will broke a totem, so the totem got used but the player still dies.
This is how damage the entity
for (Entity nearby : fireball.getNearbyEntities(3, 3, 3).stream().filter(entity -> entity instanceof LivingEntity).toList()) {
((LivingEntity) nearby).damage(FireShardConfig.INITIAL_DAMAGE * power);
}
whats a deep
round agate
yes but not with the FileConfiguration stuff
Your config file is a ""FileConfiguration""
You can load the config file by using YamlConfiguration.load(yourConfigFile)
Then you can get the ConfigurationSection out of the FileConfiguration
For example, in your config file:
The shop is a section of the config file
The blocks is a section of the shop section.
So on...
You can use loop and get the keys then get then use ConfigurationSection or FileConfiguration to get the value out of the key.
Then proceed to create your item by using the value you just recieve
sterile token
Your config file is a ""`FileConfiguration`""
You can load the config file by us...
Isnt what i explained him?
😆
round agate
Yeah. I didn't scroll up
grand perch
Your config file is a ""`FileConfiguration`""
You can load the config file by us...
a key is a variable correct??
sterile token
a key is a variable correct??
The key is the thing before the ":"
round agate
sterile token
So in this case:
- "test" is the path and the "value" its a string
- "users" is the path of a section, it contains 2 childrens called "uuid-1" and "uuid-2"
test: "value"
users:
uuid-1:
name: ""
coins: 10
uuid-2:
name: ""
coins: 10
okay
i understnad that part
the part i dont is the looping
sterile token
I do a simple example:
FileConfiguration config = config getter;
ConfiguractionSection blocks = config.getConfigurationSection("shop.blocks");
ConfiguractionSection food = config.getConfigurationSection("shop.food");
for (String key : blocks.getKeys(false)) {
System.out.println("Block name: " + key + ", display: " + section.getString("shop.blocks." + key));
}
There you have a simple example
In the case you are working with sections, the getKeys() method will returned each children name
@grand perch if you need more help just ask!
grand perch
okay
sterile token
Do you understand that code i sent know?
grand perch
sort of
round agate
spoonfeed!!! i will report you to spigot supreme court!!!
grand perch
spoonfeed!!! i will report you to spigot supreme court!!!
its not technicly spoon feeding my code is weird
sterile token
Hahah i didnt want that but its 3am so im sleepy to explain in another way and even more if you are not english native speaker
🤙
I recommend watching about good practices when developing
grand perch
Cannot resolve symbol 'ConfiguractionSection'
round agate
Configuration not Configuraction
grand perch
Cannot resolve symbol 'section'
quaint mantle
?learnjava
undone axleBOT
Here are some links to get you started on learning Java:
- https://www.codecademy.com/learn/learn-java
- https://www.sololearn.com/learning/1068
- https://www.learnjavaonline.org/
- https://programmingbydoing.com/
- https://docs.oracle.com/javase/tutorial/java/index.html
The last one is the only official one, however some of those concepts assume that you already know a bit about programming.
summer scroll
So I have a plugin that can launch a fireball with custom damage, and it will da...
bump
sterile token
?learnjava
I can ask something?
WHy you randomly appear for help and just throw "shity to people"
Like you dont help much in that way
grand perch
I do a simple example:
```java
FileConfiguration config = config getter;
Confi...
section doesnt exist
;-;
quaint mantle
WHy you randomly appear for help and just throw "shity to people"
he doesnt know how to declare variables my guy
im telling him to learn java
sterile token
Oh
sterile token
Yeah i suppoused that
quaint mantle
actually he didnt declare it
ConfiguractionSection blocks = config.getConfigurationSection("shop.blocks");
ConfiguractionSection food = config.getConfigurationSection("shop.food");
for (String key : blocks.getKeys(false)) {
System.out.println("Block name: " + key + ", display: " + section.getString("shop.blocks." + key));
}
can i recommend something
quaint mantle
shop:
0:
material: COOKED_BEEF
name: "&4Steak"
price:
buy: 10
sell: 2.5
i think the config would look best like this
grand perch
```yml
shop:
0:
material: COOKED_BEEF
name: "&4Steak"
price:
...
why 0 tho
quaint mantle
its the inventory slot of the item
sterile token
```yml
shop:
0:
material: COOKED_BEEF
name: "&4Steak"
price:
...
Agree
Imajin i do something worst hahahaha
grand perch
ok
sterile token
I just keep all the config item on Object!!
grand perch
shop:
blocks:
0:
itemName: §7Grass Block
price:
buy: 10
sell: 5
1:
itemName: §7Dirt Block
price:
buy: 5
sell: 2
food:
0:
itemName: §6Cooked Beef
price:
buy: 1
sell: 1
But only when doing items that need to do custom things
sterile token
```yaml
shop:
blocks:
0:
itemName: §7Grass Block
price:
...
Yes look better
Why food its diff?
Like why you dont just use one section?
grand perch
bcs food is a diffrent category on the shop
sterile token
Oh ok
That why i use a menu api
So i can use this in config:
Shop:
category-1:
0:
name: "bla la"
price: 10
1:
name: "bla la"
price: 10
category-2:
0:
name: "bla la"
price: 10
1:
name: "bla la"
price: 10
i copy every guide on spigot for entity metadata packets
and not one of them work
is anyone able to help me fix my protoclib code to make an entity glow
sterile token
See you soon people i will go to sleep
sterile token
i copy every guide on spigot for entity metadata packets
You already asked, please be patient...
grand perch
why name it category-x when i can just name it the category name
quaint mantle
You already asked, please be patient...
i asked like 20 times but it gets lost in a sea of other requests
no harm in asking again so someone might see it
sterile token
why name it category-x when i can just name it the category name
Just an example for you, there you can just chaneit
sterile token
i asked like 20 times but it gets lost in a sea of other requests
I dont agree, if you want to dont lost it open a thread on this channel
quaint mantle
ok man...
sterile token
You should respect the rules
I have been banned many times for double posting code every time...
quaint mantle
ive been here for 2 years and ive never had someone have a go at me for doing what i do
people are genuinely nice here
grand perch
i tested it
it doesnt send anything
ConfigurationSection blocks = config.getConfigurationSection("shop.blocks");
//ConfigurationSection food = config.getConfigurationSection("shop.food");
for (String key : blocks.getKeys(false)) {
System.out.println("Block name: " + key + ", display: " + config.getString("shop.blocks." + key));
player.sendMessage("Block name: " + key + ", display: " + config.getString("shop.blocks." + key));
}
this is the updated code i tested
quaint mantle
i know i've asked a few times but im getting confused with how packets work
i thought it should just be possible to send an entity metadata update to one player and make the entity glow/not glow, however this never works
do i have to do something like, use the spigot API to go entity.setGlowing(true) and then listen to the entity metadata update packet and interecept it so only some players can see the change or is the first approach possible
quaint mantle
ok so update for anyone curious i've been playing around with it
public void addGlow(Player player, Entity target) {
PacketContainer packet = getInstance().getProtocolManager().createPacket(PacketType.Play.Server.ENTITY_METADATA);
packet.getIntegers().write(0, target.getEntityId()); //Set packet's entity id
getInstance().getServer().broadcastMessage(target.getEntityId() + " id");
WrappedDataWatcher watcher = new WrappedDataWatcher(); //Create data watcher, the Entity Metadata packet requires this
WrappedDataWatcher.Serializer serializer = WrappedDataWatcher.Registry.get(Byte.class); //Found this through google, needed for some stupid reason
watcher.setEntity(target); //Set the new data watcher's target
byte flag = 0;
flag |= 0x01;
flag |= 0x02;
flag |= 0x08;
getInstance().getServer().broadcastMessage(flag + " flag");
watcher.setObject(0, serializer, flag); //Set status to glowing, found on protocol page
packet.getWatchableCollectionModifier().write(0, watcher.getWatchableObjects()); //Make the packet's datawatcher the one we created
try {
getInstance().getProtocolManager().sendServerPacket(player, packet);
} catch (InvocationTargetException e) {
e.printStackTrace();
}
}
this works for under a millisecond, i honestly think the only reason i can see the changes is because i have a 240hz monitor
i can see the player crouching+sprinting etc but then it goes back instantly to normal
what am i missing
chilly fox
anyone got a nice announcement plugin?
mellow edge
has bungee cord the same code as spigot?
harsh totem
ItemStack[] inv = player.getInventory().getContents();
int count = 0;
for (int i = 0; i < inv.length-4; i++){
if (inv[i] != null){
if (inv[i].isSimilar(item)){
count += worth * inv[i].getAmount();
player.getInventory().setItem(i, null);
}
}
}
GiveCoins(player, count);
}```
When I call this function like this `SellItem(player, item, 1);` I get 1299 coins and IDK why.
If I call it and I have something valuable in my inventory is gets it and gives me the right amount of money + 1299 for some reasonI don't understand where's the 1299 from
I tried calling it with any worth and item and it always returns the right amount + 1299
The count in the function is fine
the count is what it's supposed to be
but I still get 1299 more coins than I should
The function GiveCoins() is also fine and works correctly
graceful fiber
How could I make my plugin be useable in more than one version?
wet breach
has bungee cord the same code as spigot?
no
tardy delta
if i'm getting a collection from a database, is a set better than a list?
wet breach
depends on what you need to do with the collection
graceful fiber
like is it possible to do thjat?
wet breach
yes it is possible
graceful fiber
How could I make my plugin be useable in more than one version?
talking about this
I mean it's possible but is it possible for a plugin thats already made
wet breach
the easiest way is to make use of API methods only and then use multiple classes for where API is slightly different and identifying the version plugin is being ran on for this which you can make use of Enums for this
graceful fiber
or would I have to er make the project or re write the pom.xml
graceful fiber
yeah I'm not that good
round agate
yeah I'm not that good
multi module is the keyword
wet breach
you don't need a multi-module for API only
graceful fiber
hmm, still I haven't done anything with NMS yet.
wet breach
API is only different between certain sets of versions
graceful fiber
I actually wanna make my plugin useable from 1.16 to 1.18
wet breach
and even then it really depends which methods are being made use of as not everything changes in the API
tardy delta
depends on what you need to do with the collection
the thing is that i'm not really doing much with it, its just to store elements in, which will be added to the cache later
round agate
i think he's talking about NMS
wet breach
from 1.16 to 1.18 not much really needs to be done except compiling against 1.16
graceful fiber
from 1.16 to 1.18 not much really needs to be done except compiling against 1.16
yeah but I want to make it so that one jar file can be ran in all versions
wet breach
yes compiling for 1.16
graceful fiber
yeah I don't know how to do that
wet breach
means the plugin can be used in 1.17 and 1.18
you don't need to compile specifically for higher versions unless you want to make use of methods that exist in those versions specifically
graceful fiber
means the plugin can be used in 1.17 and 1.18
not 1.16?
wet breach
which I am not aware of any major changes between 1.16 to 1.18
if you compile for 1.16 it should work in 1.16+
wet breach
the thing is that i'm not really doing much with it, its just to store elements ...
A set should be fine for this. Easier to work with a set overall then Lists
especially in regards to collections sometimes
wet breach
correct
graceful fiber
but how can I shift it from 1.18 to 1.16
wet breach
you use 1.16 as the dependency to compile against, use the API methods that exist in 1.16 which should exist in later versions
which you will need to test
kindred valley
how can i remove specified element from an array
wet breach
if the methods are different or have been changed in a later version, this is where you have to make use of multi-class specific code
or as stated earlier multi-module
wet breach
how can i remove specified element from an array
you need to know its index
kindred valley
you need to know its index
i know
kindred valley
you need to know its index
I actually made it but its not updating the index after removing
wet breach
you mean the index of the rest of the elements?
kindred valley
?paste
undone axleBOT
wet breach
your method is a void method
since you don't have a global array for the string
the void method essentially provides nothing once it is done
it is lost into the void
instead of a void method, change that to String[]
and then return an array 🙂
tardy delta
hmm im looking for a way to work around this:
i have a Storage interface with one abstract method: Set<Home> loadHomes() and i want to have two implementations of that interface: a YamlStorage and a H2Storage but i want to work with futures in the h2 one, but i cant just change the return type from Set<Home> to Future<Set<Home>>, maybe i can work with callbacks idk whats the best to handle this
tardy delta
an interface for what?
wet breach
instead of using Abstract
you could change it to an interface and then have the following classes implement it, and override it if necessary
tardy delta
ye but i want to 'override' the return type in the H2Storage to be a Future<Set<Home>> instead of a Set<Home>
do you understand?
x)
harsh totem
``` public void SellItem(Player player, ItemStack item, int worth){
I...
Can anyone help?
tardy delta
there is an PlayerInventory#containsAtLeast method
wet breach
do you understand?
yeah. This might be a case where your api is too concrete at the upper level
and need to move the concreteness to the lower levels instead
kindred valley
and then return an array 🙂
https://paste.md-5.net/oviqapocaj.cpp like this?
tardy delta
ye that happened to me many times before, dunno really how to fix it
wet breach
https://paste.md-5.net/oviqapocaj.cpp like this?
that should work and yield some kind of result 🙂
wet breach
o.O
did you use /reload?
if so probably best to just restart the server lol
you should have gotten something different back
kindred valley
did you use /reload?
yes
harsh totem
there is an PlayerInventory#containsAtLeast method
How would that help
quaint mantle
how do i get a datawatcher in 1.18
kindred valley
provided you the answer before you responded 😛
do you mean reload of stopping and restarting?
wet breach
I don't mean reloading anything. Just stop and start the server or otherwise known as restarting
tardy delta
How would that help
nvm
kindred valley
I don't mean reloading anything. Just stop and start the server or otherwise kno...
same
https://paste.md-5.net/owapoyiqar.cpp whole class
harsh totem
nvm
I just don't even know what could cause this problem
There shouldn't be any problem
tardy delta
whats not working?
also method names should start with a lowercase character
SellItem -> sellItem
quiet ice
that is an odd number
tardy delta
maybe you only want to check the material?
harsh totem
Wdym
tardy delta
instead of checking if the itemstack is similar
@wet breach im pretty sure there is a better way
wet breach
There is, you need to do the reverse for your API
let your storage classes set the methods, make a class that combines all the storages into easy methods
tardy delta
so no storage interface
wet breach
you can, just its doing the opposite
instead of going from 1 top class, you are starting with a multiple and then condensing down
harsh totem
instead of checking if the itemstack is similar
how do I get the material of an ItemStack
tardy delta
getType
wet breach
I gey 1299 more coins than I should
count += worth * inv[i].getAmount(); explain this math?
this is obviously where it is going wrong
I have a feeling it has to do with that multiplication on the right
humble tulip
Count = count + worth * item amt
wet breach
Count = count + worth * item amt
I know math, I need them to explain why they are doing this
humble tulip
Where?
harsh totem
`count += worth * inv[i].getAmount();` explain this math?
the amount of coins is supposed to be equal to the amount of coins plus the worth of the sold item multiplied by the amount of this item
humble tulip
I just opened this chat
wet breach
I just opened this chat
then don't respond to things if you are out of the loop
humble tulip
👀
harsh totem
`count += worth * inv[i].getAmount();` explain this math?
What's wrong with this?
wet breach
try changing it to this then
harsh totem
???
humble tulip
Oh it's a sellitems method
wet breach
count = ((count + worth) * inv[i].getAmount());
quiet ice
that likely does not do what the user wants
tardy delta
isnt worth the price?
humble tulip
No because you're multipling the previous cost by the amount
harsh totem
`count += worth * inv[i].getAmount();` explain this math?
I check it and the count variable is always what it should be but I get (1299 + count) coins
humble tulip
Isn't that growing exponentially now?
quiet ice
I check it and the count variable is always what it should be but I get (1299 + ...
Did you try debugging each incrementing of count to get where it comes from?
quiet ice
And even just before invoking the giveCoints method?
harsh totem
This is giveCoins(). I already checked it and it should be fine
int[] amount = new int[9];
amount[8] = coins / 10000;
coins %= 10000;
amount[7] = coins / 5000;
coins %= 5000;
amount[6] = coins / 2000;
coins %= 2000;
amount[5] = coins / 1000;
coins %= 1000;
amount[4] = coins / 500;
coins %= 500;
amount[3] = coins / 200;
coins %= 200;
amount[2] = coins / 100;
coins %= 100;
amount[1] = coins / 10;
coins %= 10;
amount[0] = coins;
ItemStack[] items = {Coins.one.clone(), Coins.ten.clone(), Coins.hundred.clone(), Coins.twoHundred.clone(), Coins.fiveHundred.clone(), Coins.thousand.clone(), Coins.twoThousand.clone(), Coins.fiveThousand.clone(), Coins.tenThousand.clone()};
for (int i = 0; i < items.length; i++){
items[i].setAmount(amount[i]);
player.getInventory().addItem(items[i]);
}
}```In that case, it's the giveCoins method that is bork, not your sellItems one
Oh yeah, that has huge potential to be borked
harsh totem
Oh yeah, that has huge potential to be borked
I have another command that the only thing it does is use this function and it works perfectly
quiet ice
Even with the same value?
wet breach
ah yes modulus
harsh totem
Even with the same value?
lets asume I put 345 coins.
I get 1 coin of 200, 1 coin of 100, 4 coins of 10, 5 coins of 1
That is how it should be
wet breach
o.O
quiet ice
And for your sellItems method it just gives 1299 coins more?
harsh totem
yes
quiet ice
Even if you give it 345 coins?
harsh totem
yes
quiet ice
sounds inplausible
harsh totem
I checked it. if count == 0 in the end of the function I still get 1299
wet breach
I can see how they are getting that
not sure why you are doing your math like that though
harsh totem
and that's how I called this function
SellItem(player, item, 1);```so why are you using an array to do counting?
harsh totem
so why are you using an array to do counting?
in the giveCoins()?
to make the code shorter
harsh totem
that doesn't seem shorter to me
If I hadn't used the array I would have needed to make a clone of each item and then add this to the player's inventory which would take 18 lines
wet breach
if you wanted to do math that way, you would need to do it similarly when doing math for binary
harsh totem
?
quiet ice
private void giveAmount(Player p, ItemStack is, int amount) {
is = is.clone();
is.setAmount(amount);
player.getInventory().addItem(is);
}
public void GiveCoins(Player player, int coins){
giveAmount(player, Coins.tenThousand, coins / 10000);
coins %= 10000;
giveAmount(player, Coins.fiveThousand, coins / 5000);
coins %= 5000;
giveAmount(player, Coins.twoThousand, coins / 2000);
coins %= 2000;
giveAmount(player, Coins.thousand, coins / 1000);
coins %= 1000;
giveAmount(player, Coins.fiveHundred, coins / 500);
coins %= 500;
giveAmount(player, Coins.twoHundred, coins / 200);
coins %= 200;
giveAmount(player, Coins.hundred, coins / 100);
coins %= 100;
giveAmount(player, Coins.ten, coins / 10);
coins %= 10;
giveAmount(player, Coins.one, coins);
}
Without an array it is one line shorter
harsh totem
```java
private void giveAmount(Player p, ItemStack is, int amount) {
is = i...
ok you're right
humble tulip
Why do u have to clone the item each time?
If you're setting the amount each time
Oh i guess other usages
harsh totem
Why do u have to clone the item each time?
because otherwise the items would be changes so that if i use another command that uses these items it may not work
quiet ice
I guess it isn't really needed there actually
humble tulip
because otherwise the items would be changes so that if i use another command th...
??
quiet ice
As long that is the only usage of it that is
humble tulip
You mean instances of those items?
quiet ice
As CB will clone the itemstack again once you call #addItem
harsh totem
??
lets assum i set the amount to 64 to give it, if i try to use another command that uses the item that i used before, the mount would stay 64 until i reload the plugin
quiet ice
As long as the amount is irrelevant for other logic, you can ignore that fact
humble tulip
Yeah^
quiet ice
But really this is just a minor nitpick about performancee
Though depending on the plugin it can be a justified nitpick, cloning is expensive
harsh totem
well I wanted to get help because my command isn't working. my performance is mostly fine
humble tulip
Well if performance is fine you can keep it as is until you need to optimize i guess
At the end of givecoins
What's the value of coins?
harsh totem
What's the value of coins?
the amount of coins in the end of giveCoins() is the first amount % 10
wet breach
if performance is your concern
you could easily do this with bitshifting
and know all the remainders in one go of a loop
wet breach
but seems you are just making this more complex then it really needs to be
just because it is shorter in terms of lines, doesn't make it better or more optimal
harsh totem
IK. I'm not trying to make it efficient
quiet ice
It is probably some random method that appears unrelated but actually bricks the method in an unexpected way
But really you'd need the full source to estimate what is going on. Just did a test myself on my own impl and it seems to work right
harsh totem
Maybe I can make a function to remove coins and always remove 1299 from the player after he sells anything
quaint mantle
in 1.18 spigot you cant use ENTITY_METADATA properly, the changes last for a millisecond before going away
radiant cedar
how can I make it so that nobody can break blocks in the server but they can only at given spots of like 30x30s
quiet ice
Maybe I can make a function to remove coins and always remove 1299 from the play...
Give the whole source code
harsh totem
?paste
undone axleBOT
glass mauve
in 1.18 spigot you cant use ENTITY_METADATA properly, the changes last for a mil...
really?
humble tulip
Maybe I can make a function to remove coins and always remove 1299 from the play...
Nah
harsh totem
quaint mantle
really?
the only time my packet works is when i run a 1ms timer to set it constantly
im convinced its broken
ive been at it for a day and tried every tutorial
quiet ice
You have no breaks in your onClick method, are you sure that that is wanted?
glass mauve
I have also problems with packets and ENTITY_METADATA
quaint mantle
i swear its broken?"
idk who to ask or what to do
feel like ive just wasted a day trying to do the impossible
harsh totem
You have no breaks in your onClick method, are you sure that that is wanted?
it isn't wait
glass mauve
so setting my itemframe invisible works, but settings the item inside is weird
quaint mantle
so setting my itemframe invisible works, but settings the item inside is weird
idk maybe protocolib is broken
quiet ice
np
glass mauve
idk maybe protocolib is broken
so for me I think its actually my problem, bc setting the item as APPLE works, but not as FILLED_MAP with image
quaint mantle
idk its just fucked haha
this has to be the least documented version of MC
new BukkitRunnable(){
public void run(){
Player p1 = getServer().getPlayer("account1");
Player p2 = getServer().getPlayer("account2");
getGlowManager().setGlowing(p1, p2, true);
}
}.runTaskTimer(this, 0, 1);
this makes it work
so idk wtf is going on
humble tulip
@harsh totem I'd recommend you make classes for coins and sellableitems
quiet ice
Reee BukkitRunnable
quaint mantle
Reee BukkitRunnable
exactly
this is what im saying
works for 1 millisecond then breaks
quiet ice
Use lambdas
quaint mantle
no i dont want to use it haha
im saying why cant the packet persist
theres something wrong with it
like i noticed today when i was testing if i sent the packet to set a palyer on fire/running itd work for a millisecond
and then disappear
what in 1.18 is so different that it gets rid of the changes instantly
quiet ice
quaint mantle
idk i can read through it all but tbth my knowledge on packets is so small and limited i wouldnt be able to find it if u put it right in my face
wet breach
like i noticed today when i was testing if i sent the packet to set a palyer on ...
are you sure you are setting the time correctly?
as in you are not setting it to just 1 tick?
quaint mantle
are you sure you are setting the time correctly?
for glowing?
public void setGlowing(Player player, Entity target, boolean glowing) {
PacketContainer packet = ProtocolLibrary.getProtocolManager().createPacket(PacketType.Play.Server.ENTITY_METADATA);
packet.getIntegers().write(0, target.getEntityId()); //Set packet's entity id
WrappedDataWatcher watcher = new WrappedDataWatcher(); //Create data watcher, the Entity Metadata packet requires this
WrappedDataWatcher.Serializer serializer = WrappedDataWatcher.Registry.get(Byte.class); //Found this through google, needed for some stupid reason
watcher.setEntity(target); //Set the new data watcher's target
byte entityByte = 0x00;
if (glowing) {
entityByte = (byte) (entityByte | 0x40);
} else {
entityByte = (byte) (entityByte & ~0x40);
}
watcher.setObject(0, serializer, entityByte); //Set status to glowing, found on protocol page
packet.getWatchableCollectionModifier().write(0, watcher.getWatchableObjects()); //Make the packet's datawatcher the one we created
try {
ProtocolLibrary.getProtocolManager().sendServerPacket(player, packet);
} catch (InvocationTargetException e) {
e.printStackTrace();
}
}
heres my code
quiet ice
https://wiki.vg/Protocol#Entity_Effect yeah, the only reason would be that the duration is 1
wet breach
whatever it is you are trying to do. Things done via packets have to be constantly sent because generally the server is unaware of what you are doing and thus when the server sends an entity update to the client
it removes your changes
quiet ice
Where do you set the duration?
quaint mantle
this used to work fine in older versions
quiet ice
Likely because of how 0 (or whatever the default val was) was treated
quaint mantle
how do you mean
wet breach
just because it worked fine in older versions, doesn't mean older protocol versions are the same
quaint mantle
glowapi is broken as well so idk what my options are to fix this
yeah i mean thats true
quiet ice
Well, assume the default duration is 0, before it was treated as an infinite time period, now it is treated as less than a tick
wet breach
I just know when you are doing things with packets in regards to entities especially setting their metadatas. If you are not cancelling the entity updates in the server events, then the server sending the update will wipe your changes.
quaint mantle
I just know when you are doing things with packets in regards to entities especi...
how do i do this
quiet ice
wait quick question are you saying it's like a potion effect?
I'd highly assume that it is a potion effect at the backend, but idk what you are doing
quaint mantle
i can track who should/shouldnt see glows
quiet ice
oh it's entity metdata
quaint mantle
I'd highly assume that it is a potion effect at the backend, but idk what you ar...
it used to just be an entity metadata
yeah
u CANN use potions but that seems doodoo
like isnt the point of manipulating the datawatcher to stop the server from wiping changes?
quiet ice
I think exactly that is happening rn
but uh, I am not really knowledgeable in this field
quaint mantle
either
idk if anyone reading this has a solution i’m gonna give it a rest but i’d appreciate any input or push in the right direction
harsh totem
<@931310561218674768> I'd recommend you make classes for coins and sellableitems
I do have classes for these
quaint mantle
```
public void setGlowing(Player player, Entity target, boolean glowing) {
...
If you already have a real bukkit Entity then you should not create a WrappedDataWatcher from scratch but wrap
the current entities DataWatcher. Then manipulate the bytes.
Be sure to also listen for outgoing meta packets for that entity because if the player receives any update for this
entity then the glowing effect will vanish.
glass mauve
do I need to listen for outgoing meta packets aswell? I create an invisible item frame (working) and want to set the item inside, but that spawns and despawns instantly
quaint mantle
do I need to listen for outgoing meta packets aswell? I create an invisible item...
Is the item frame present on the servers side?
glass mauve
the itemframe is an packet
lost matrix
Then the server wont send any packets for this item frame because it doesnt know that the item frame exists.
glass mauve
ok, but why is my itemframe with map with image not working ._.
lost matrix
ok, but why is my itemframe with map with image not working ._.
How do you add the map to the item frames?
glass mauve
I have this:
PacketManager.sendItemFrame(player, l.getX(), l.getY() + y, l.getZ() + z, true, map); and map is an itemstack, when I change map to
new ItemStack(Material.APPLE), then its working
wet breach
regardless of how you are creating the itemframe with the map in it via packets. The reason it disappears is you will have to stop and modify any block or chunk updates near your item frame otherwise it will vanish from the client
lost matrix
I have this:
`PacketManager.sendItemFrame(player, l.getX(), l.getY() + y, l.getZ...
Did you tag the item frame as 'fixed' so it doesnt care about adjacent blocks?
glass mauve
eh no ig, but still it works with an APPLE
sendItemFrame(): https://paste.ofcode.org/4NPr7ttfRBGBDRdWN73Zq8
quaint mantle
If you already have a real bukkit Entity then you should not create a WrappedDat...
how do i get the entitys datawatcher
quaint mantle
If you already have a real bukkit Entity then you should not create a WrappedDat...
i need to listen to every packet? that seems awfully laggy
lost matrix
i need to listen to every packet? that seems awfully laggy
If you have 1k players and show them 1k glowing entities it would def use <0.25% of the tick.
You will run out of cpu time for players before listening to some TCP packets becomes an issue.
quaint mantle
If you have 1k players and show them 1k glowing entities it would def use <0.25%...
so its fine to do it this way?
it shouldnt be that drastic anyway
how do i go about grabbing an entity’s already existing datawatcher
lost matrix
?paste
undone axleBOT
quaint mantle
My Intellij goes to 100% cpu usage when decomiling Material.class
lost matrix
My Intellij goes to 100% cpu usage when decomiling Material.class
Then dont decompile any spigot classes... The sources can be imported.
lost matrix
how do i go about grabbing an entity’s already existing datawatcher
Ill send you something in a minute. Just have to test it.
quaint mantle
Ill send you something in a minute. Just have to test it.
ty
ive had to go afk for a while so ill trst when im back
ty for the help
quaint mantle
Then dont decompile any spigot classes... The sources can be imported.
lol yeah now I can't open the project anymore xD
frick
ok finally
cool
im gonna import those sources really fast
:P
quaint mantle
Then dont decompile any spigot classes... The sources can be imported.
How do I import the sources?
grim oak
how would i do something like event.getClickedBlock() == Anvil like how would i do the anvil bit
because Material.Anvil isnt working cuz it gets a block and not a material
lost matrix
because `Material.Anvil` isnt working cuz it gets a block and not a material
Get the material of the block and compare it with Material.ANVIL
grim oak
ah ty
lost matrix
ty
Ok i got it to work. This is an example that lets me set an entity glowing for 1 second after hitting it:
@EventHandler
public void onInteract(EntityDamageByEntityEvent event) {
if (event.getDamager() instanceof Player player) {
Entity entity = event.getEntity();
glowManager.setGlowing(player, entity);
Bukkit.getScheduler().runTaskLater(this, () -> glowManager.stopGlowing(player, entity), 20);
}
}
Its a single class. You can take a look here:
https://gist.github.com/FlorianMineCrypto/310fd25ead0e7af1bb3a81abcd5dbb0b
quaint mantle
Its a single class. You can take a look here:
https://gist.github.com/FlorianMin...
ill sus now
wait are you manually removing the glow
or does it time out
lost matrix
Bukkit.getScheduler().runTaskLater(this, () -> glowManager.stopGlowing(player, entity), 20);
quaint mantle
because i want to make it permanent until i turn it off
sorry if i missed it because im on my phone out atm
so u turning the glow on makes it permanent until u turn it off?
lost matrix
so u turning the glow on makes it permanent until u turn it off?
Yes
glass mauve
I have a problem with loading images on a map, that is inside an item frame, that is send through a packet to a player, the item frame and setting is the item is fine, but I have problems with the map. It only works when I also add the map to the players inventory if not, than they spawn and despawn instantly:
main part: https://paste.ofcode.org/36FcpZFVjQwhV885veFCe2c
ImageRenderer: https://paste.ofcode.org/4VGrT3MbjT8gZ7FYSHq3NL
with add map to players inventory: https://www.youtube.com/watch?v=gbldtnt6Ojs
without: https://www.youtube.com/watch?v=Fg7q0iOQeSc
radiant cedar
how can I change the names of people in TAB and their names above their characters in game
lost matrix
how can I change the names of people in TAB and their names above their characte...
Just give them a new PlayerProfile with another name.
radiant cedar
can also add colors like that
if i want it to look like this on tab and above their characters
radiant cedar
Just give them a new PlayerProfile with another name.
can new PlayerProfile do taht
lost matrix
can new PlayerProfile do taht
Sure
earnest forum
player profile changes the name even for commands
radiant cedar
earnest forum
so if you change my name to yada1 instead of /tp yada0 you would have to do /tp yada1
earnest forum
its nms
radiant cedar
what
earnest forum
bit more complicated than that
wet breach
if you don't know what NMS is probably shouldn't be touching it
lost matrix
the hell
Do you want to change the players name all together?
So that he appears differently in other plugins, messages, etc too?
lost matrix
To achieve what?
radiant cedar
i already did the messages by just canceling mesage and sending new
radiant cedar
To achieve what?
huh
cus I want cool looking names i guess
idek
with ranks next to tehma
and colors
lost matrix
Ah thats a different story. You can achieve that by using prefixes and suffixes of teams.
radiant cedar
would it be better idea to make a team for each rank
so they all have same prefix and suffix
wet breach
there is other ways of learning something without doing. You don't need to use NMS to know what NMS is.
did you also not understand java?
yeah for me they are one in the same anyways not arguing semantics here nor am I changing my stance 🙂
obviously you decided to learn the more difficult way, and either it has paid off or you learned some terrible habits. Either way, most others don't learn this way
I didn't say anything in regards to spigot
if you learn
if you don't learn something new from what you previously knew you don't progress
quaint mantle
#help-development not #debating
How do I import the spigot sources in a maven project, so Intellij doesn't have to decompile everything when opening?
wet breach
anyways, I am going somewhere else. You are a terrible debater
quaint mantle
How do I import the spigot sources in a maven project, so Intellij doesn't have ...
.
wet breach
nor accept their opinion
quaint mantle
omg
radiant cedar
I used this for their name on the TAB list
quaint mantle
not sure really - i just look at the stash normally
stash?
undone axleBOT
radiant cedar
but how can I change their names on their heads
wet breach
How do I import the spigot sources in a maven project, so Intellij doesn't have ...
normally you could right click on the maven project to tell it where it can find the sources for a dependency
at least this is how it is in netbeans
pretty sure it is something similar in IntelliJ
I am a netbeans fan
in case you didn't know 🙂
wet breach
no
wet breach
while intelliJ and netbeans are pretty similar in terms of functionality and could argue they are the same. They are still different because of how they both choose to organize their menus, what level of control over the IDE's they allow you to have as well as even though they have the same features how they are implemented are not the same.
quaint mantle
then yah
ivory sleet
tho zacken you do have a point, all ides do share a common set of features in order for them to be considered ides
and not just DEs or Code Editors
radiant cedar
why does this not work for setting the players' name above their heads to have a prefix
tardy delta
does it work on tab?
radiant cedar
i did something else for tab
i mean this is something i guess
but doesnt work on tab
radiant cedar
even when i dont have this
mighty pier
i want to start a bukkit runnable every time a player hits a player but if a bukkit runnable is already running how do i stop it?
tardy delta
any good recommendations for a command annotation framework?
lost matrix
i want to start a bukkit runnable every time a player hits a player but if a buk...
You can keep a Map<UUID, Integer> that maps the player id to the runnable id.
You should most probably do something else to manage this.
lost matrix
any good recommendations for a command annotation framework?
ACF
radiant cedar
how could I use this API in my maven project
tardy delta
dumb question
radiant cedar
first time using maven
lost matrix
It takes a while to get used to. But if you understand all the internals then you
will write commands very fast.
tardy delta
good :)
lost matrix
how could I use this API in my maven project
Usually they have an example setup for that on their documentation
radiant cedar
is there an easier way u know that I could use to setup the players' naems above their heads
mighty pier
You can keep a Map<UUID, Integer> that maps the player id to the runnable id.
Yo...
new BukkitRunnable() {
@Override
public void run() {
something.put(p.getUniqueId(), this);```luck perms supports that iirc
lost matrix
``` something.get(p.getUniqueId()).cancel();
new BukkitRunnable()...
Explain in detail what you are trying to do
mighty pier
yes
tender shard
did you add the proper repository?
radiant cedar
torn vale
<!-- StatsAPI -->
<dependency>
<groupId>de.snx</groupId>
<artifactId>statsapi</artifactId>
<version>v1.2.6-SNAPSHOT</version>
<scope>system</scope>
<systemPath>${project.basedir}/libs/StatsAPI.jar</systemPath>
</dependency>```
Why cant I use the API?
tender shard
click the maven reload button
radiant cedar
radiant cedar
doesnt work
radiant cedar
com.nametagedit:nametagedit:pom:4.1.16 was not found in https://hub.spigotmc.org/nexus/content/repositories/snapshots/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of spigotmc-repo has elapsed or updates are forced
com.nametagedit:nametagedit:pom:4.1.16 was not found in https://hub.spigotmc.org/nexus/content/repositories/snapshots/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of spigotmc-repo has elapsed or updates are forced
tender shard
click on the "m" button, then enter "mvn clean package -U"
lost matrix
yes
Then you should only need one runnable.
When the player gets attacked -> Add a unix timestamp to their PDC
Then start one runnable when the server starts. This runnable goes through every player in 20 ticks
and checks the timestamp. If the timestamp is further than N milliseconds in the past you send them a message.
If you want to check if someone is being tagged as "in combat" then you just get their PDC and check the timestamp.
tender shard
where is the m
radiant cedar
dont have this
tender shard
are you using intelliJ?
radiant cedar
yes
tender shard
then you do have this button
quiet ice
It should be on the right side
radiant cedar
tender shard
by default, on the right side, there's a bar called "maven"
quiet ice
Probably is
quiet ice
but wtf is this theme
tender shard
press "shift" twice, then enter "execute maven goal"