ohh like wynncraft
#help-development
buoyant viper
when ur in a conversation with an npc ur chat is only the dialogue and then it switches back to regular chat when its over
ancient plank
mmm
I gotta rewrite some code in a plugin which still uses the bukkit conversation api ๐ค
it's been on the server since 2013, and I recently just refactored the code to use the new (by new, I mean it was made in 2017) command framework
summer scroll
maybe chat system with channels is good?
ancient plank
I made a very very very simple & weh weh version of a chat channel plugin we use on our server, because my friend wanted to test chat ranges in one of his builds on his build server ๐ค
summer scroll
take a look at this https://github.com/sVoxelDev/sChat it's pretty good imo
but rip user's chat log
ancient plank
can't imagine how that'd look if you played on a smaller chat size
vestal barn
can you cancel an event from another function that you pass event into
summer scroll
i think you can, yes
vocal cloud
As long as it's not async
granite owl
can you cancel an event from another function that you pass event into
like you register an event callback OnBlockPlace
then pass the blockplace event to another function
and modify it there?
do you think its a smart idea to use a plugin from someone else and then attack its data structure?
you didnt say that anywhere before
delicate lynx
that is what is supposed to happen
fork WorldGuard and change it
it's always going to do that
coarse finch
i have the library installed and it still errors
quaint mantle
send pom
coarse finch
arctic moth
having trouble shading CustomBlockData, Intellij seems to recognize the dependency, but it raises a NoClassDefFoundError
https://paste.md-5.net/apebojehet.xml
quaint mantle
having trouble shading CustomBlockData, Intellij seems to recognize the dependen...
its the minimize jar plugin
arctic moth
?
arctic moth
lol
quaint mantle
i dont think its that line i think its the plugin, i changed a setting and it worked
quaint mantle
looking for it
actually
why are you even relocating it
shouldnt alex get his credit?
arctic moth
idk
quaint mantle
seems dicky to include someone elses code and at the least, not even put it in the directory that specifies the author
coarse finch
whats a pom
arctic moth
it says to relocate it
coarse finch
and how do i send it
coarse finch
im using gradle
granite owl
i have the library installed and it still errors
since when do we have to override callbacks? aint they hooked automatically by the api?
coarse finch
since when do we have to override callbacks? aint they hooked automatically by t...
idk im following tutorial
granite owl
remove the override annotion
coarse finch
ok but how can i fix the import issue
granite owl
why its hooked automatically
arctic moth
is it tho
quaint mantle
its for clarification
and in older java versions its required
go into any project with abstractation and you will see @Override
arctic moth
realizes nitro runs out in 2 days
arctic moth
this is the right jar right? https://hub.spigotmc.org/nexus/content/repositories...
did u just
download the jar
coarse finch
i added it as the thingy
coarse finch
its in dependancies
arctic moth
of what
coarse finch
im pretty sure thats only the javadocs
on spigot website
granite owl
its for clarification
well as for me i just ever let the parent class JavaPlugin handle these standard callbacks but i also use the latest version of the jdk
quaint mantle
well as for me i just ever let the parent class JavaPlugin handle these standard...
yeah no. add @override
arctic moth
of intellij
gradle dependencies or literally just project dependencies?
quaint mantle
if i really wanted to argue i'd just @ choco cause he can explain everything
arctic moth
gradle has build.gradle and stuff
coarse finch
gradle has build.gradle and stuff
it doesnt. also havent tried building yet as intellij shows an error
granite owl
if i really wanted to argue i'd just @ choco cause he can explain everything
nah id pass on arguing over that
coarse finch
gradle dependencies or literally just project dependencies?
it shows in both
quaint mantle
it doesnt. also havent tried building yet as intellij shows an error
this doesnt even include the spigot jar
its just dependencies
coarse finch
oh
quaint mantle
im pretty sure its for building spgiot
arctic moth
it shows in both
show where the thing is
quaint mantle
not actually running it
coarse finch
where do i get the spigot jar then
granite owl
anyway its weird
arctic moth
screenshot
quaint mantle
where do i get the spigot jar then
?bt
undone axleBOT
quaint mantle
or just add it as a dependency in gradle
granite owl
on the one hand it recognizes the JavaPlugin class
quaint mantle
which is way easier
coarse finch
do i have to build it?
arctic moth
no
quaint mantle
you dont have to
granite owl
on the other hand it doesnt recognize its members?
quaint mantle
just add it into your build.gradle
arctic moth
just add it into your build.gradle
probably should show him how to do that
arctic moth
lol
coarse finch
just add it into your build.gradle
ok how do i do that
arctic moth
i hate gradle thats the main reason why im only a spigot dev and not a fabric dev
quaint mantle
ok how do i do that
quaint mantle
i hate gradle thats the main reason why im only a spigot dev and not a fabric de...
or a forge dev
it requires you to use gradle
coarse finch
i think intellij does it automatically, the thingy i added before is in build.gradle
quaint mantle
plugins just need to port to fabruc
arctic moth
oh u can?
granite owl
or a forge dev
dont forge servers require their playerbase to have well forge installed?
quaint mantle
dont forge servers require their playerbase to have well forge installed?
nah its not like thats how modding works or anything
if forge wasnt required on both ends
- minecraft would be a virus
- spigot or any server fork wouldnt exist
coarse finch
how long does building it take
ivory sleet
dont forge servers require their playerbase to have well forge installed?
technically it could be faked as its just a packet spam that keeps the client and server together
oo
coarse finch
why not just add it into your gradle
you said to build
arctic moth
lol i was just checking through channels and found a spammer
coarse finch
im so confused rn
arctic moth
little child
arctic moth
im so confused rn
not u the kid in the screenshot
coarse finch
i figured lol
arctic moth
anyways @quaint mantle ya figure out what u did to fix the maven stuffs
coarse finch
so do i just put the build output as a dependency?
arctic moth
so do i just put the build output as a dependency?
i have no idea what ur saying ยฏ_(ใ)_/ยฏ
might as well just use maven
coarse finch
guy on another server said to use gradle its easier
ok its done building @quaint mantle
arctic moth
how is gradle easier
arctic moth
make it false
didnt work
quaint mantle
how is gradle easier
maven > gradle > building the dependencies yourselves
quaint mantle
@ivory sleet
quaint mantle
didnt work
ok for me the problem was i didnt specify the execution phase, like clean package
are you sure the build command contains package
stuck flax
i am creating a plugin with placeholdersapi but it says Cannot resolve symbol 'PlaceholderAPI'
arctic moth
where?
arctic moth
are you sure the build command contains `package`
uhhhhhhhhhh
quaint mantle
i am creating a plugin with placeholdersapi but it says `Cannot resolve symbol ...
import it
arctic moth
what am i supposed to do there
quaint mantle
then it cant give you that error?
wet breach
should learn how to program before trying to do stuff with plugins
buoyant viper
maven > gradle > building the dependencies yourselves
mmb > mavem > gradle > self
quaint mantle
should learn how to program before trying to do stuff with plugins
fr
quaint mantle
mmb > mavem > gradle > self
ant >
buoyant viper
@lavish hemlock s minimal buildsystem > all
grizzled hazel
why is it that you can't directly deserialize any map from a yaml config that doesn't have string keys?
wet breach
what other keys would it have?
coarse finch
i think i found it
coarse finch
arctic moth
what am i supposed to do there
so what do i do for the package like what am i supposed to define
quaint mantle
so what do i do for the package like what am i supposed to define
nothing
arctic moth
like for settings and stuff
quaint mantle
its just the build command
arctic moth
oh
quaint mantle
mvn clean package
where tho
quaint mantle
quaint mantle
๐
grizzled hazel
what other keys would it have?
as in the map i serialised had Location keys and the values were a type i made that implemented ConfigurationSerializable
the type i made deserialises just fine on its own but then when it comes to deserialising the entire map i can't do that because getConfigurationSection returns a Map<String, Object> and i have no idea how to convert those string keys back into locations
quaint mantle
keys can only be strings
arctic moth
still didnt work
quaint mantle
as in the map i serialised had `Location` keys and the values were a type i made...
you'd have to make a method to turn a location into a legal key string
arctic moth
was this what i was supposed to do
quaint mantle
was this what i was supposed to do
you can remove the mvn, its implied
grizzled hazel
the other annoying thing is it seems to cut half the location off because
world: world
x: -96.0
y: 83.0
z: -177.0
pitch: 0.0
yaw: 0.0```
became
org.bukkit.Location
world: world
x: -96.0```
when i looked at the value of the string key in the deserialised result
quaint mantle
just try it
coarse finch
i added it to my build.gradle and the import is erroring heeeeeeeeelp
when i run it i get Unexpected input: '{' @ line 8, column 14. repositories { ^
arctic moth
nope didnt work
quaint mantle
idk
arctic moth
when i run it i get ```Unexpected input: '{' @ line 8, column 14.
repositor...
do u know gradle syntax
quaint mantle
i feel like there should be an easier build system
coarse finch
do u know gradle syntax
no
granite owl
keys can only be strings
the implementation of a Map is <T1, T2>
arctic moth
no
just look at the way everything else is , because those brackets arent the right thing
quaint mantle
the implementation of a Map is <T1, T2>
coarse finch
wait i got it
i hate these things {}
they were messed up
still doesnt import though
arctic moth
i feel like there should be an easier build system
are u talking about me?
or the other guy
quaint mantle
are u talking about me?
everyone
arctic moth
i noticed that build artifacts and the mvn clean package build buttons do separate things in the build log
coarse finch
when i run it it just does gradle heeeeeeeeelp
granite owl
not fair cuz i cant send pictures here but np wait
arctic moth
lol
wet breach
i feel like there should be an easier build system
maven is really not that difficult
quaint mantle
maven is really not that difficult
its slow
wet breach
its not
quaint mantle
anyways, what am i supposed to do rn
idk bro i told u everything i know
arctic moth
is the clean package exporting to the same place as artifacts?
granite owl
as in the map i serialised had `Location` keys and the values were a type i made...
just as an idea, put ur locations as x,x,z... and then String.split using ',' as seperator
quaint mantle
did you enable threads and increase the resources maven is allowed to use?
yes and its still not that fast
granite owl
returns a primitive array from which u can create ur location
arctic moth
cuz what is clean package actually doing
wet breach
yes and its still not that fast
have you tried using a different compiler?
don't have to use the one mavens likes
arctic moth
my maven builds are usually pretty quick
wet breach
for most people it is
arctic moth
just annoying how i feel that even if i copy/paste the same pom in a new plugin it doesnt work half the time
wet breach
but most people also don't realize you can configure maven to be more optimal if you have the resources to give it
out of the box maven is conservative
buoyant viper
those darn liberal build systems
arctic moth
out of the box maven is conservative
at least its not gradle
gradle takes like 10 mins to build for me
granite owl
as in the map i serialised had `Location` keys and the values were a type i made...
also if map keys must be string classes and u put another class the data is prob corrupted but maybe not
buoyant viper
gradle takes a while to spool up for me but building its pretty good
wet breach
also, most people use clean as part of the default build
using clean will remove half the benefits maven has
most of the time you don't need to use clean
arctic moth
also, most people use `clean` as part of the default build
i dont even know if clean is actually building to the same place as the build artifacts button
that could be a reason it doesnt work
quaint mantle
clean just removes existing build directories
wet breach
maven can do incremental building
but if you use clean you remove the benefits of incremental building and caching
arctic moth
because i have it set in my project settings to build to my plugins folder
but idk where the maven builds
buoyant viper
target
wet breach
clean is a life cycle that removes the entire build directory
buoyant viper
probably
granite owl
why do i still need to run buildtools to have a local maven repository? like whats the advantage?
buoyant viper
id check maven-jar-plugin configuration
wet breach
why do i still need to run buildtools to have a local maven repository? like wha...
you don't need build tools for local maven repo
granite owl
but putting the spigot repo as dependencies yada yada throws errors if i didnt run buildtools for that version of the server
wet breach
build tools just conveniently installs the api to your local maven repo because that is one of the few areas when using maven to build your project that maven will look at to see if you have dependencies already there
granite owl
hm
arctic moth
its not
vast apex
Hey guys, I have an issue. My plugin for some reason doesn't work on ApexHosting. What can cause this?
arctic moth
noble lantern
Hey guys, I have an issue. My plugin for some reason doesn't work on ApexHosting...
error?
arctic moth
generated-sources just has an empty annotations folder
wet breach
Hey guys, I have an issue. My plugin for some reason doesn't work on ApexHosting...
Apex Hosting can cause this ๐
doubt that helps though
buoyant viper
yeah no youd see a jar like right in the first level of the folder
arctic moth
Hey guys, I have an issue. My plugin for some reason doesn't work on ApexHosting...
did u restart the server
vast apex
I'm getting this from one of my plugin users
(not me cause i dont have an apex server)
buoyant viper
ur running mvn package right
vast apex
like to build
vast apex
server version is 1.18.2
noble lantern
```org.bukkit.plugin.InvalidPluginException: Unsupported API version 1.18.2 (doe...
You need 1.18 in your plugin.yml
not 1.18.2
vast apex
oh
quaint mantle
```org.bukkit.plugin.InvalidPluginException: Unsupported API version 1.18.2 (doe...
did you even test your plugin
noble lantern
:p
arctic moth
lol
buoyant viper
ur running mvn package right
@arctic moth
arctic moth
wut
noble lantern
clean package*
buoyant viper
u can just package smh
arctic moth
i am
buoyant viper
hmm
normal isle
Can someone compile a modified plugin for me?
noble lantern
package doesnt clean though
quaint mantle
Can someone compile a modified plugin for me?
no
granite owl
```org.bukkit.plugin.InvalidPluginException: Unsupported API version 1.18.2 (doe...
like @noble lantern said. you specify the major version not the minor patches
buoyant viper
u dont need to clean tho
normal isle
):
arctic moth
package doesnt clean though
i have clean package
noble lantern
always gives errors without cleaning on my end
arctic moth
noble lantern
says theres already an existing archive
arctic moth
for me thats never happened im just trying to figure out why CustomBlockData doesnt wanna shadow
buoyant viper
says theres already an existing archive
quaint mantle
isnt customblockdata just pdc for non-supporting block types
arctic moth
isnt customblockdata just pdc for non-supporting block types
yes
granite owl
am i right to asume that pdc just accesses nms methods and namespaces the keys?
arctic moth
idk
granite owl
i mean basically just namespaces the keys by plugin instance
quaint mantle
am i right to asume that pdc just accesses nms methods and namespaces the keys?
i guess
noble lantern
kinda
buoyant viper
why not decompile server and look at source ๐
granite owl
so i could access pdc values with nms methods if ik the namespace ? :P
ivory sleet
ye
noble lantern
you can access them just by getting the plugins instance you want to use
without nms
buoyant viper
pdc is just a bukkit front for nbt isnt it
granite owl
just trying to understand what pdc actually does
ivory sleet
main point of the pdc api is the resistance towards changes, lets say minecraft dont want to use nbt and snbt anymore
in that case pdc could stay completely unaffected
buoyant viper
snbt?
ivory sleet
myes
granite owl
in that case pdc could stay completely unaffected
because the backend would be adapted by spigot and we dont feel the difference yaya
arctic moth
but see i dont think this is actually building to anything
it takes about a fifth of a second
i doubt even saving an empty txt is that fast
granite owl
why not decompile server and look at source ๐
no need. the buildtools leaves all class files as java files from the bukkit api
buoyant viper
buildtools does the decompiling for u yes
granite owl
i mean it leaves the entire bukkit api
as source files
so u can look any bukkit class up at any time really
arctic moth
where lol
granite owl
where lol
in the target/src/bukkit/org or whatever its called directory
wherever u ran buildtools
arctic moth
in the target/src/bukkit/org or whatever its called directory
i dont have anything like that in my target
granite owl
idk would have to look it up
arctic moth
this is my entire target folder
granite owl
but ive searched it recently to find out how to tabcomplete commands
and figured that JavaPlugin has a member for it
xD
ivory sleet
ye
granite owl
so
ivory sleet
basically the fallback cmd executor + tab completer for all commands declared in ur plugin yml iirc
ivory sleet
yes
ivory sleet
x)
ivory sleet
ye no worries lol
arctic moth
ive noticed that it has the library in external libraries
i just dont know why its not in the build
granite owl
basically the fallback cmd executor + tab completer for all commands declared in...
yea basically what happens in the plugin.yml is that all specified commands get put into one command executor
so where for vanilla commands every command has its own executor
every plugin has one for all of its commands
so technically
summer scroll
i just dont know why its not in the build
are you getting cnf exception?
ivory sleet
yuh
granite owl
every plugin is one command
arctic moth
are you getting cnf exception?
no
granite owl
has*
summer scroll
gradle or maven?
ivory sleet
or whatever the setting is called in maven
quaint mantle
dont include minimize jar
this isnt the issue
arctic moth
dont include minimize jar
oh
quaint mantle
i mean
arctic moth
gradle or maven?
maven
quaint mantle
u can try and remove that
and it would probably work
but that wasnt the issue for me
coarse finch
lets go i made a functional clear command
ivory sleet
epic
granite owl
@ivory sleet ive recently figured(overridden the vanilla /op command), that a plugins command executor is being handled by bukkit like single vanilla commands xD
granite owl
and so is the tabcomplete*
arctic moth
still didnt work :(
coarse finch
whats the right way to send messages when the plugin is starting? should i use the logger or is printing fine
arctic moth
logger
coarse finch
ok
granite owl
whats the right way to send messages when the plugin is starting? should i use t...
the logger is a wrapper
ivory sleet
<@299969655915806741> ive recently figured(overridden the vanilla /op command), ...
myes
granite owl
to put everything into log files as well
noble lantern
whats the right way to send messages when the plugin is starting? should i use t...
By default spigot already says your plugins starting btw, but yeah use logger or println function
ivory sleet
I know there is a lot of hackery
especially since the underlying system has heavily incorporated brig
whilst bukkit stays away from it
granite owl
basically every vanilla command is being registered into the command map by namespaced command and non namespaced command
coarse finch
hmmm what to make now
granite owl
and every command is a VanillaCommand
ivory sleet
yes
ivory sleet
but thats just to make the api proper
arctic moth
dont include minimize jar
heres my pom if that helps https://paste.md-5.net/wivevinopa.xml
granite owl
and the ignoreequalscase is just the function "internal" splitter
grizzled hazel
you'd have to make a method to turn a location into a legal key string
(it works now, so thanks)
granite owl
although i cast the cmd to lower case and switch it cause java can cast strings to sha hashes
๐คฃ
coarse finch
wait i dont see how this knows what command is being run...
its just going straight from on command to ah yes clear command
nothing checking it
bad tutorial!!
granite owl
I know there is a lot of hackery
yea it is. funny to actually see it in action tho that every plugin is being treated as 1 vanilla command xD
ivory sleet
heres my pom if that helps https://paste.md-5.net/wivevinopa.xml
mind enlightening me about the issue?
granite owl
am i being stupid for serializing my permission map? xD
arctic moth
mind enlightening me about the issue?
oh
trying to shadow CustomBlockData, getting the NoClassDefFound error
granite owl
dont blocks have metadata?
arctic moth
no
ivory sleet
tile entities I believe
ivory sleet
trying to shadow CustomBlockData, getting the NoClassDefFound error
did u have the stacktrace? :p
arctic moth
did u have the stacktrace? :p
its just nested function spam with the NoClassDefFound error saying that CustomBlockData isnt defined or smth
ig ill run it again but it lags the server cuz its a nested function
ivory sleet
sure
granite owl
Block.rayTrace(Locationย start,ย Vectorย direction, doubleย maxDistance,ย FluidCollisionModeย fluidCollisionMode)
``` is this new? didnt see it 2 years ago when i needed interpolation
arctic moth
```java
Block.rayTrace(Locationย start,ย Vectorย direction, doubleย maxDistance,ย Flu...
i dont remember it
ivory sleet
```java
Block.rayTrace(Locationย start,ย Vectorย direction, doubleย maxDistance,ย Flu...
myes
its a bit new
ivory sleet
okay
so do u know that when u use maven you should be getting 2 jars right
at least with the shade plugin
ivory sleet
no clue honestly, but possibly
granite owl
cause like
ivory sleet
like in the target directory
quaint mantle
original and dependency included
granite owl
back then ive written my own very precise but poor performance method for it xD
arctic moth
theres nothing in the target directory but a bunch of classes
ivory sleet
what maven tasks r u runing
twilit wharf
I am creating a custom generation plugin, and I set a chunks biome to DEEP_OCEAN yet there is land there. f3 shows that it is deep ocean to. It is a large landmass even though it is supposedly DEEP_OCEAN. Any ideas? Thanks in advance! ๐
arctic moth
quaint mantle
I am creating a custom generation plugin, and I set a chunks biome to DEEP_OCEAN...
i dont think changing the biome would do anything
quaint mantle
i dont think changing the biome would do anything
until after the blocks are placed
arctic moth
rnt u supposed to run mvn clean install or sth
ill try ig
twilit wharf
until after the blocks are placed
I am overriding the default biome provider
and I know it works
quaint mantle
so why doesnt it
maiden thicket
hey, so i load in a jar from another jar but there's an issue. ( not a plugin, it's a module system im doing kind of? )
jar1 loads jar2
issue is jar2 has a config.yml AND jar1 has a config.yml, and jar2 loads jar1's config.yml
jar2 is loaded on jar1's classpath
URLClassLoader loader = new URLClassLoader(
new URL[]{file.toURI().toURL()},
Plex.class.getClassLoader()
);
InputStreamReader internalModuleFile = new InputStreamReader(loader.getResourceAsStream("module.yml"), StandardCharsets.UTF_8);
YamlConfiguration internalModuleConfig = YamlConfiguration.loadConfiguration(internalModuleFile);
String name = internalModuleConfig.getString("name");
if (name == null)
{
throw new ModuleLoadException("Plex module name can't be null!");
}
String main = internalModuleConfig.getString("main");
if (main == null)
{
throw new ModuleLoadException("Plex module main class can't be null!");
}
String description = internalModuleConfig.getString("description", "A Plex module");
String version = internalModuleConfig.getString("version", "1.0");
List<String> libraries = internalModuleConfig.getStringList("libraries");
PlexModuleFile plexModuleFile = new PlexModuleFile(name, main, description, version);
plexModuleFile.setLibraries(libraries);
Class<? extends PlexModule> module = (Class<? extends PlexModule>)Class.forName(main, true, loader);```have you shade it?
crisp steeple
is there any reason this exception handler doesnt trigger? works in normal java projects but just doesnt work on a server
handler:
private static final Thread.UncaughtExceptionHandler handler = (thread, throwable) -> {
Bukkit.broadcastMessage("Exception"); // doesnt trigger
handleException(throwable);
};
public static void start(){
Thread.setDefaultUncaughtExceptionHandler(handler);
Bukkit.broadcastMessage(Thread.currentThread().getName()); // Server Thread
Thread.currentThread().setUncaughtExceptionHandler(handler);
}
exception trigger test:
@EventHandler
public void testException(PlayerFishEvent event){
Bukkit.broadcastMessage(Thread.currentThread().getName()); // Server Thread
Bukkit.broadcastMessage(Thread.currentThread().getUncaughtExceptionHandler().toString()); // correct instance
String a = null;
a.toString();
}
probably since its overwritten
ivory sleet
ngl i have no clue how to use maven
well
if u're willing to jump over to gradle
I'd be glad to assist you
as my field of expertise isnt maven per say
arctic moth
gradle is scary
ivory sleet
nah
people just spread fear, uncertainty and doubt
but its really not that bad
well
they're both not bad
summer scroll
ye
try to use version 3.2.4 for the maven shade and relocate it
and use mvn package to build
arctic moth
still not working
odd spear
Hey I'm new to plugin dev, so forgive me if this is a stupid question but how do you set a wait command which will pause the execution of code in that class?
crisp steeple
probably since its overwritten
i checked that in the Bukkit.broadcastMessage(Thread.currentThread().getUncaughtExceptionHandler().toString()); line, and it appears to be correct
arctic moth
Hey I'm new to plugin dev, so forgive me if this is a stupid question but how do...
runnable
ivory sleet
i checked that in the `Bukkit.broadcastMessage(Thread.currentThread().getUncaugh...
yes
but like
summer scroll
still not working
send updated pom
ivory sleet
the runnable declared inside the thread could just catch any throwable
crisp steeple
yeah thats what i was thinking
noble lantern
Is there a way to override a chunk generator without adding it to the bukkit.yml like shown here
arctic moth
send updated pom
it is updated
crisp steeple
which might be annoying
ivory sleet
ye
arctic moth
just 3.2.4 in the version of maven-shade-plugin
summer scroll
it is updated
i mean ur pom file, i want to see after you change it
arctic moth
summer scroll
https://paste.md-5.net/xuluwoxilo.xml
relocate the thing
ivory sleet
who specifically?
summer scroll
might as well try
arctic moth
who specifically?
idk imajin i think
summer scroll
some of libs will conflict if not shaded
arctic moth
welp gtg now
ive been on this one problem for almost 4 hours
I thought maven was supposed to, like, be easy or smth
This exact pom has worked with other plugins, but now its just deciding to not work
arctic moth
if u're willing to jump over to gradle
I kinda wanna learn Gradle sometime for stuff like fabric and forge anyways, so maybe I will ยฏ_(ใ)_/ยฏ
ivory sleet
noice, well gl
odd spear
welp gtg now
hey thanks a lot for replying! i also have the runnable inside a command executor, how can i pass my arguments into the runnable?
waut
wait
im stupid
summer scroll
I thought maven was supposed to, like, be easy or smth
it's pretty easy lmao, i never had that problem but yeah sometimes it's weird
coarse finch
how do i do newlines in a logger or chat message?
summer scroll
Send another message
coarse finch
ok
ivory sleet
or with \n
coarse finch
ok
noble lantern
Would ThreadLocalRandom.current() have any performance issues by chance?
Or should i just create a Random instance in my main class and create a getter for it
ivory sleet
no not really
but it offers no reproducability
which kinda sucks
so I'd use SplittableRandom
also really fast, even in parallel environments
in case you wanna use it over threads, could go with ThreadLocal<SplittableRandom>
and invoke split on it
noble lantern
Nah im not gonna be using it over threads, im just using a random to calculate how many veins of ore should generate in a given chunk so i was wondering what would give the best performance as it would likely get called shittons when players fly through the world like the nether
For this i don't really thing reproducability would be an issue as i necessarily wouldn't want to reproduce any values just have random ones like here
odd spear
I'm receiving "An internal error occurred while attempting to perform this command" upon running a command. Compiling is fine. How can I diagnose the problem? Is there a way to see what line it is?
noble lantern
I'm receiving "An internal error occurred while attempting to perform this comma...
check your console
past brook
how do i add custom structures to my custom generator
noble lantern
how do i add custom structures to my custom generator
you would either manually set each block using block.setType or paste a schematic at a given location
pasting schems is the best way
past brook
you would either manually set each block using block.setType or paste a schemati...
what about if the schematic is too big for a single chunk and the others are not loaded
noble lantern
good question uhm
no idea ngl, i would assume you would have to split the schem into multiple parts
and paste accross those chunks
would be rather complicated
odd spear
check your console
right, dunno why i didnt do that haha thanks
Im a noob with java so forgive me if this is a stupid question but what does this mean:
java.lang.IllegalArgumentException: Plugin cannot be null
noble lantern
right, dunno why i didnt do that haha thanks
Im a noob with java so forgive me ...
It means the plugin instance your are using is not set
Show the command code
I also recommend properly learning java before taking a whack at plugins
cold pawn
Does anyone know why im getting this error in console. For some context im trying to make a respawn packet using protocol lib, I recently switched to 1.18.2 and reused the respawn packet I had when I was working in 1.16, making some slight updates. So far everything else works except this, any reason why?
past brook
you would either manually set each block using block.setType or paste a schemati...
oh and also how do i make schematics?
cold pawn
Does anyone know why im getting this error in console. For some context im tryin...
respawn.getWorldTypeModifier().write(0, world.getWorldType()); - Line were error occurs
noble lantern
Does anyone know why im getting this error in console. For some context im tryin...
Might be an issue with ProtocolLib tbh
noble lantern
oh and also how do i make schematics?
you could create them in game, then upload the files to your plugin and past them using WorldEditAPI
cold pawn
Might be an issue with ProtocolLib tbh
Oh, that really sucks
noble lantern
Might be worth opening an issue on theyre github asking about it
idk if they have a discord
cold pawn
Alright.
undone axleBOT
odd spear
mb
noble lantern
plus thats the error
odd spear
noble lantern
plus thats the error
dot
noble lantern
your actual command class yes
odd spear
oh right haha
delicate lynx
Caused by: java.lang.IllegalArgumentException: Plugin cannot be null
odd spear
fyi this issue came up only when i added runnables https://pastebin.com/krBtggWz
that is the class
delicate lynx
you never set Plugin
noble lantern
?di
undone axleBOT
Guide to dependency injection: https://www.spigotmc.org/wiki/using-dependency-injection/
delicate lynx
pass your plugin instance to the command class, that is that dependency injection is
see that link
odd spear
yes i do see it
currently reading
oh i see so i needed to write this.plugin = plugin; in the constructor
golden turret
where in the craft bukkit this is called?
i really need it
or is there a way that i do something like entity.damage(damage, damager) and that event with that constructor is called
noble lantern
or is there a way that i do something like `entity.damage(damage, damager)` and ...
Damagable#damage(double, LivingEntity)
that's also not a NMS method either (The one i shown)
wait hold on my bad
thats not a Damageable method
golden turret
actually it is
noble lantern
okay so how we do it is just getDamager() on EntityDamageByEnetity it procudes a Entity
And using the method you shown damage(damage, damager)
No NMS really needed here
Unless you are on a version that doesnt have that event?
odd spear
Hey Im really stuck with this code, would someone be down to call and help? I would really appreciate it
ivory sleet
uh sure
odd spear
sweet
ivory sleet
?scheduling
undone axleBOT
stark carbon
noble lantern
https://paste.md-5.net/qebimovalo.java
So I'm randomly getting a location in the nether dependent upon whether or not my code runs into the ceiling or floor
Pardon my math but I can't seem to get the actual location anywhere other than 0.0 86.0 0.0 (Where y always moves but x and z are always 0)
Is this something in the logic of my code that's not letting the x and z values iterate? Or some type of math I'm doing when converting the block-chunks location to a real-world Location?
undone axleBOT
Here are some links to get you started on learning Java:
- https://www.codecademy.com/learn/learn-java
- https://www.sololearn.com/learning/1068
- https://www.learnjavaonline.org/
- https://programmingbydoing.com/
- https://docs.oracle.com/javase/tutorial/java/index.html
The last one is the only official one, however some of those concepts assume that you already know a bit about programming.
noble lantern
https://paste.md-5.net/qebimovalo.java
So I'm randomly getting a location in th...
my own stupidity gets the better of me somtimes smh
buoyant viper
https://paste.md-5.net/qebimovalo.java
So I'm randomly getting a location in th...
i reckon if getX or getZ return 0, then x * 0 = 0
noble lantern
i reckon if getX or getZ return 0, then x * 0 = 0
yeah that and on top of it the way i was converting was so wrong too lmao
i did this instead:
granite burrow
Hey what would be the best way to determine if the player has a permission (permission.number.#)
Where # would be any number
I feel like a loop wouldn't be the best way to go about this but thats the only way I can think about getting this info other than using vault
summer scroll
Hey what would be the best way to determine if the player has a permission `(per...
loop is the only way i guess
granite burrow
loop is the only way i guess
yeah, I found a nice way to do it with a loop, just finished testing it and it works as well as expected lmao.
public int getNumberedPerm(Player p, String node) {
// Loop through all players permissions nodes
for (PermissionAttachmentInfo perm : p.getEffectivePermissions()) {
// Find the permission node that starts with the desired node
if (perm.getPermission().startsWith(node)) {
// Format node to take into account the extra "."
node = node+".";
try {
// Format the perm to only have the number in it
// Convert the string of the number into an integer and return the int
return Integer.parseInt(perm.getPermission().replace(node, ""));
} catch (NumberFormatException numberError) {
// Let the server owner know that there is an error with their permission
plugin.getLogger().severe("Player ("+p.getName()+") has an invalid permission number, permission name: "+perm.getPermission()+" \nPlayer's UUID: "+p.getUniqueId() + "\nPlease submit the following error to Brand0n_ if you cannot resolve the issue:");
// Print the stack trace to make it easier to debug what happened
// This should never be useful as no one should be putting in something that isn't a number
numberError.printStackTrace();
}
}
}
return 0;
}
Made it so that if it can't find the number or if the number is wrong it tells the user in the console and results in a 0 being sent in its place
can for sure make it loop prettier tho
summer scroll
yeah, I found a nice way to do it with a loop, just finished testing it and it w...
I would just return 0 if the number is invalid instead throwing an error
granite burrow
yeah that would be better
fleet pier
what do you think about redis as primary database
wraith delta
map.put(player.getUniqueId(), false);
new BukkitRunnable() {
public void run() {
if (!map.get(player.getUniqueId())) {
player.teleport(new Location(player.getWorld(), finalTeleportLocation.getX(), finalTeleportLocation.getY() + 1.0, finalTeleportLocation.getZ()));
map.remove(player.getUniqueId());
}
}
@EventHandler
public void onMove(PlayerMoveEvent event) {
if (map.containsKey(player.getUniqueId())) {
if (event.getTo().getX() != event.getFrom().getX() || event.getTo().getZ() != event.getFrom().getZ()) {
map.put(player.getUniqueId(), true);
}
}
}
```Hello! I am trying to create a cancel teleport on move event using hashmap boolean. Here is a brief piece of the code. See anything out of place? The issue is after moving the TP cancels but you stay in the hashmap.use putIfAbsent not put, that way you dont need checks and your not possibly putting in duplicate entries
wraith delta
Well I also use a cooldown and messages to tell the user whether they cancelled the teleport, or are in cooldown etc. That is just a trimmed code.
noble lantern
what do you think about redis as primary database
why not mysql or mongodb?
fleet pier
why not mysql or mongodb?
im using arangodb but redis is just better i think cuz i can store Java Objects without converting them to a jsonobject for example yk
and redis is faster
and i use redis pubsub a lot
noble lantern
if you want to store JavaObjects without converting them the MongoDB driver does this
If you use mysql/redis youll likely need to convert
Redis isnt really meant to be used as a persistant database
fleet pier
You can change it to be persistent tho
noble lantern
I dont reccommend it
summer scroll
You can use HashSet maybe instead using Map to store a boolean
wraith delta
use putIfAbsent not put, that way you dont need checks and your not possibly put...
Unfortunately that seems to have lagged the teleport. And the player still teleports even though they moved, its just delayed
Darn videos arent allowed here lol.
buoyant viper
get verified
wraith delta
get verified
Thanks. Thats fancy
wraith delta
use putIfAbsent not put, that way you dont need checks and your not possibly put...
Notice that kind of lagged it lol. And the player still teleports now, where as with just 'put' the user only stays in the hash
buoyant viper
if map contains player... insert player? wat
noble lantern
im a little confused about that as well lmao
wraith delta
if map contains player... insert player? wat
Because when the user types the command to TP they are added to the hash
buoyant viper
so the map is like a queue of players to be teleported?
so do u mean to remove them from it if they move
wraith delta
Yes and after the teleport they shall not be in the map
buoyant viper
so then remove them on move and on tp id think
wraith delta
so then remove them on move and on tp id think
In my code I showed above I have map.remove(player.getUniqueId()); when they finish teleporting
Hm it seems with Burchards correction you are removed from the map however you can still teleport if you moved during the moment before teleporting
summer scroll
Use HashSet please
wraith delta
Use HashSet please
Ive changed that now, assuming for efficiency?
summer scroll
Ive changed that now, assuming for efficiency?
yes, and that's not how you use a map
also you want to remove player from the set when they move
wraith delta
yes, and that's not how you use a map
My bad. Ive rarely messed with it
if (!map.contains(player.getUniqueId())) {
map.remove(player.getUniqueId());
```And on teleport/commandthat will never happen
severe plume
๐
summer scroll
if player is in the set, remove from the set
wraith delta
Whats strange is it still let me teleport
summer scroll
My bad. Ive rarely messed with it
when player move, you add them back again instead removing them
wraith delta
when player move, you add them back again instead removing them
I just figured having add the player on move, it would defeat the purpose to remove them on move aswell..
I may see, so I should add them first thing on command, and continuously remove on move?
summer scroll
so when player execute the command, add them onto the set
and listen to playermoveevent
if they move, remove from the set
wraith delta
Great. Ill give it a go
summer scroll
and after the cooldown or warm up
check if player is still on the set
if player is still on the set, teleport them and remove them from the set
wraith delta
The reason I had a if statement to check if they are in the set is to make sure they dont run the command a second time to bypass it
summer scroll
you can add a check on the command
wraith delta
you can add a check on the command
Awesome thanks ๐ So simple yet mind twisting sometimes
sleek flume
is it possible to give a falling block a potion effect like levitation?
wraith delta
Sounds like youve got some crazy antigravity plans. Unlikely you can give a potion, youd have to either cancel the fall event or use armor stand animations
sleek flume
oh then i think ill do it with velocity
frigid rock
does anyone know why the bot is sending multiple messages instead of one? (i'm using jda) the code: ```java
@EventHandler
public void chatEvent(AsyncPlayerChatEvent e){
String message = e.getMessage();
TextChannel textChannel = jda.getTextChannelById("963443913362927666");
assert textChannel != null;
textChannel.sendMessage("" + e.getPlayer().getDisplayName()+ ": " + message).queue();
}
@Override
public void onMessageReceived(@NotNull MessageReceivedEvent e) {
super.onMessageReceived(e);
if(!(e.getAuthor().isBot()) || !(e.getAuthor().isSystem())){
String message = e.getMessage().getContentRaw();
User user = e.getAuthor();
Bukkit.broadcastMessage(user.getName() + "#" + user.getDiscriminator() + ": " + message);
}
}```
tardy delta
How many
buoyant viper
does anyone know why the bot is sending multiple messages instead of one? (i'm u...
change the || to && in the isBot isSystem check
frigid rock
hang on lemme try
buoyant viper
ur effectively saying
if user is not a Bot(false) OR user is not system(true)
==True
instead of
if user is not a Bot(false) AND user is not system(true)
== False
buoyant viper
is the listener registered more than once somehow?
lavish hemlock
You can simplify !(e.getAuthor().isBot()) to just !e.getAuthor().isBot(). Much more readable.
frigid rock
is the listener registered more than once somehow?
nope i dont think so
buoyant viper
random nag but i think the super.onMessageReceived isnt needed since that JDA method should be empty
nothing else in that code immediately screams duplicate send, idk
frigid rock
i think that is a jda problem maybe? idk
buoyant viper
maybe
frigid rock
thanks anyway for the support ^^
quaint mantle
hi
i want help
i put levelledmobs on my server when they kill then show lvl 23 en all i want to do that show zombie lvl when alive how :?
jovial kraken
does any1 know how to play the block break anymation and then break the block when the block is placed down? im using spigot 1.8.8
sharp flare
is there any way to make particles move slowly or last longer
tried the extra parameter and count to 0
jovial kraken
yeh but how to like use them ik dis one but i cant import it is it from protocollib ??PacketPlayOutBlockBreakAnimation
sharp flare
yeah doing it right now through a runnable
gonna do task timer for this
how may I find these particle data
not that familiar with particle data
thanks
checked the wiki.vg, no particular data for smoke large unfortunately but the repeating task works fine
raven ravine
Hello, I'm trying to code custom enchants in spigot 1.18.2, but this code doesn't seem to work. It throws NoSuchFieldExceptions, but if I look into the class Enchantment.class, there is a field which has this exact name. I checked for typos, but there are none. Please help.
public static void registerEnchantment(Enchantment ench) { boolean registered = true; try { Bukkit.getConsoleSender().sendMessage("accepting " + Enchantment.isAcceptingRegistrations()); Field f = Enchantment.class.getField("acceptingNew"); f.setAccessible(true); f.set(null, true); Enchantment.registerEnchantment(ench); } catch (Exception e) { e.printStackTrace(); registered = false; } if(registered) { Bukkit.getConsoleSender().sendMessage("Enchantment " + ench.getName() + " registered"); } }
noble lantern
Hello, I'm trying to code custom enchants in spigot 1.18.2, but this code doesn'...
your using a Namespaced key in the super() correct as in 1.18/more recent this has changed
also
use getDeclaredField
not getField
also look into this from chocos post: https://www.spigotmc.org/threads/making-a-custom-enchantment.226403/#post-2308129
thick tundra
Hello, im trying to create a custom api for my plugins, but when i try to access the api from a diffrent plugin it gives me a java.lang.ClassCastException
noble lantern
Hello, im trying to create a custom api for my plugins, but when i try to access...
How are you getting your API and how are you casting it
how does this API run, is it compiled in or running as a seperate plugin on your server?
thick tundra
Its running as a seperate plugin on my serer
noble lantern
and your depending on it in plugin.yml correct
noble lantern
How are you getting your API and how are you casting it
this too
thick tundra
private RideManager rideManager;
@Override
public void onEnable() {
rideManager = JavaPlugin.getPlugin(RideManager.class);
}
this is how i try to get the main class of the other plugin
i tried multiple ways, none seemed to work. first i used getServer().getpluginmanager().getplugin
raven ravine
use getDeclaredField
It works now. Thank you very much! ๐
thick tundra
and your depending on it in plugin.yml correct
depend:
- RideManager
and you used the string for this on as well correct
if anything
just make a static getter for the plugin
RideManager.getPlugin()
thick tundra
wait i can do that
noble lantern
will be loads easier than using the plugin manager
thick tundra
xD
thick tundra
ohh hwhahah then im going through a lot of trouble for nothing
i already have a static instance of the plugin in the main class xD
noble lantern
yep your fine getting it this way, its how a lot of other plugin API's do it
twilit wharf
so why doesnt it
That is why I asked here lol
I set the biome, then Minecraft generates it, and what Minecraft generates is generally correct, except the plain barren land when there should be deep ocean
noble lantern
```java
private RideManager rideManager;
@Override
public void onEn...
have you tried using PluginManage#isPluginEnabled("thatpluginsname")?
try checking the value of that
thick tundra
Yeah im doing that now
java.lang.ClassCastException: class eu.ridemanager.base.RideManager cannot be cast to class eu.ridemanager.base.RideManager (eu.ridemanager.base.RideManager is in unnamed module of loader 'base-1.0-SNAPSHOT.jar' @34f798f2; eu.ridemanager.base.RideManager is in unnamed module of loader 'operators-1.0-SNAPSHOT.jar' @6c2f0ff3)```im so confused xD
eternal oxide
you included your Ridemanager plugin with your second plugin
thick tundra
ohh
noble lantern
could definatly be a possibility, what scope for the import are you using miners?
should be provided
noble lantern
Yessir
noble lantern
For a plugin dev what would be a good way to read timings? Is using 1% of a servers load decent without any optimized flags for generating in additional ore veins in new chunks? (in the nether)
This is also while flying around generating new chunks on top of the above ^
echo basalt
looking at your code
you make a chunksnapshot
you can process it async btw
also aikar's timings are quite better for debugging
noble lantern
you make a chunksnapshot
yeah im using the chunk snapshot however
one sec
?paste
undone axleBOT
noble lantern
Method for generating random block location: https://paste.md-5.net/aqesiviqot.java
It looks for a chance for it to spawn either on the nether roof or nether surface
ChunkLoadEvent: https://paste.md-5.net/jumepumulu.java
I dont really thing i could do this async as getting the block from the world would throw an error, as well as setting the block would throw an error as well
echo basalt
ChunkSnapshots can be processed async
you can make it a CompletableFuture<Block> getRandomNetherBlock
and call .whenComplete
noble lantern
I see let me give it a whirl
And when I supplyAsync this will make the CompletableFuture run async correct? or should I still wrap this in an async BukkitRunnable?
noble lantern
sounds good thank you! ill come back with my results in a few mins
holy shit
no way
I need to use CompleteableFuture's more often I guess i underestimated how good they were LMFAO
noble lantern
yeah when the completeable future finishes im returning the chunk.getBlock() method
noble lantern
weird bukkit isnt throwing me any async errors
unless your only talking about the block scanning from ChunkSnapshot
noble lantern
ahh i see
i don't really mind this processing async though, as I'm not doing anything with these blocks once they're generated, i just set theyre BlockDataMeta and the other events handle everything from there
but ty for that tip definatly saved a lot on the reports it seemed
just seemed odd to me that generating one block randomly in a location used that much power :p
paper lance
package me.snazzeh.main;
import org.bukkit.entity.Player;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
public class Main extends JavaPlugin {
public void onPlayerJoin(PlayerJoinEvent event) {
Player p = event.getPlayer();
event.setJoinMessage("Welcome to the server," + p + "!");
}
}
anyone know why it doesnt work? Console doesnt throw any errors
eternal oxide
needs @eventhandler
paper lance
ohh cheers
jagged thicket
its a test lmao
river oracle
```java
package me.snazzeh.main;
import org.bukkit.entity.Player;
import org.bu...
no it doesn't implement handler no @eventHandler annotation and it isn't registered
paper lance
"Yet Another Join Message Plugin"
its a test Maow
plus im not making plugins for other people its for my own server calm down lol
paper lance
no it doesn't implement handler no @eventHandler annotation and it isn't registe...
shit how do i register again lol
lavish hemlock
I believe it's uhh
eternal oxide
in onEnable
lavish hemlock
Bukkit.getPluginManager().registerEvents(this, <listener here>);
although I may be wrong
paper lance
Bukkit.getPluginManager().registerEvents(this, PlayerJoinEvent); Like this?
river oracle
`Bukkit.getPluginManager().registerEvents(this, PlayerJoinEvent);` Like this?
this, this
implement listener
lavish hemlock
ye
paper lance
ohh cheers
river oracle
and add the annotation
paper lance
package me.snazzeh.main;
import org.bukkit.Bukkit;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.player.PlayerJoinEvent;
import org.bukkit.plugin.java.JavaPlugin;
public class Main extends JavaPlugin implements Listener {
public void OnEnable() {
Bukkit.getPluginManager().registerEvents(this, this);
}
@EventHandler
public void onPlayerJoin(PlayerJoinEvent event) {
Player p = event.getPlayer();
event.setJoinMessage("Welcome to the server," + p + "!");
}
}
Like this?
river oracle
idk probably
paper lance
The method registerEvents(Listener, Plugin) in the type PluginManager is not applicable for the arguments (Main, Main)
wait nvm im dumb fixed it
cheers for the help
river oracle
`The method registerEvents(Listener, Plugin) in the type PluginManager is not ap...
why did you make your own is my qusetion there are like a trillion join plugins
paper lance
nah im just testing
i wanna start learning how to make java plugins but i gotta start somewhere
noble lantern
its a good learning project too
paper lance
yeah lols
glossy venture
your OnEnable should be onEnable
glossy venture
and might be useful to have @Override before it
paper lance
what does @Override do exactly?
eternal oxide
ensures you are overriding an actual method defined in the interface/class
paper lance
oh okay ty
echo basalt
and might be useful to have `@Override` before it
it's optional
glossy venture
so i usually do it
echo basalt
we aren't coding in c#
tardy delta
arent we?
echo basalt
I also usually do it but no need to point it out if it isn't there
glossy venture
makes it more readable tho
eternal oxide
reason to point it out is, he's learning
tardy delta
teach 'em while they are young
glossy venture
also it gives compile time errors when your signature is incorrect
crude loom
I want to implement a vanish feature to my plugin
Is there a simpeler way then taking off the players armor and applying an invisibillity effect?
echo basalt
player.hidePlayer
crude loom
Oh, does that hide the player even if he has armor on?
tardy delta
yes
wanna take a look at my vanish plugin?
yes, smh forgot my github password
grr
ah finally
quiet ice
@Override is a must as it simplifies updating by a lot
tardy delta
tardy delta
the hell is wrong with my fonts lol
smoky oak
Is it better to pass the same instance of random around, or to generate a new one when it's needed? If the latter, should i manually set a seed or no?
eternal oxide
depends on use case
noble lantern
?paste
undone axleBOT
tardy delta
that font isnt cool lol
echo basalt
Is it better to pass the same instance of random around, or to generate a new on...
ThreadLocalRandom.current does the job 95% of the time
noble lantern
Hey @echo basalt i used the Completable future system but it seems the server cant really handle calling these in each and every chunk generation? I get a thread dump error like this: https://paste.md-5.net/eyuyamisez.cs
smoky oak
depends on use case
replacing blocks with a random chance in an area using a BukkitRunnable
noble lantern
sec ill resent the code im using rn
tardy delta
unsafe stuff hmm
crude loom
wanna take a look at my vanish plugin?
That would be great!
eternal oxide
replacing blocks with a random chance in an area using a BukkitRunnable
then as Imll said, ThreadLocalRandom
noble lantern
Generation event: https://paste.md-5.net/nomipigifo.java
CompletableFuture method: https://paste.md-5.net/ujevomilew.java
(its called max of 3 times per chunk)
tardy delta
That would be great!
i just send the github repo above ^
crude loom
Thanks ๐
grim ice
replacing blocks with a random chance in an area using a BukkitRunnable
you're distributing that right
smoky oak
you're distributing that right
maximum of 400 blocks at once so no
its not like the chunk shit where i had to generate 20000 blocks at once
tardy delta
Generation event: https://paste.md-5.net/nomipigifo.java
CompletableFuture meth...
i would do CompletableFuture#thenAccept instead of whenComplete if you're not using the throwable
it wont run if the throwable is != null too
noble lantern
ill try that, not sure if it would fix the stacktrace im currently getting but ill try it
tardy delta
thats alot of loops
smoky oak
also
if(block.getType() == from && randomChance())
block.setType(to);
//or
if(block.getType() == from){
if(chance==1.0){
block.setType(to);
}
else if(randomChance()){
block.setType(to);
}
}
```?ayo what the fuck
tardy delta
some stuff seems to be broken here
noble lantern
ill try that, not sure if it would fix the stacktrace im currently getting but i...
honestly this is weird asf, even just generating the chunks in a player radius it just crashes the whole serer with CompletableFuture in a for loop
ah i see theres a max thread pool allowed when using these async
smoky oak
what's the sound name for when lava and water collide?
grim ice
how to check if a spawner is naturally generated
crude loom
How do I call this method given a Player? https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/entity/Player.Spigot.html#getHiddenPlayers()
eternal night
Player player = ....
player.spigot().getHiddenPlayers()
Thanks!
eternal night
np ๐
noble lantern
honestly this is weird asf, even just generating the chunks in a player radius i...
Managed to fix this using .join() instead of thenAccept however performance seems to have suffered from this but i am generating more of these random locations per block so that could be the issue
noble lantern
how to check if a spawner is naturally generated
No good way to do this without listening to when a chunks generated and storing its location, i dont beileve theres any vanilla methods for checking naturally generated blocks
noble lantern
Managed to fix this using .join() instead of thenAccept however performance seem...
oh interesting seems to stable itself out over time
Ty for the pointers guys 
granite owl
this always checks wheter or not a player is known to the server right?
if (player.isOnline() || player.hasPlayedBefore())
because hasPlayedBefore seems to only check if a playerfile exists but idk how exactly it works
from which list it retrieves its info
noble lantern
this always checks wheter or not a player is known to the server right?
hasPlayedBefore() will indeed check if they exists by the playerfile iirc
ivory sleet
I mean isOnline would always imply that the latter is true
noble lantern
^
granite owl
yea isonline always returns true ofc if that player is online rn
was more about if its still an oversight to check like ths
based on hasPlayedBefore
noble lantern
hasPlayedBefore() is more or less something you use in PlayerJoinEvent
after that fires thats marked as true if it was false before
ivory sleet
ye, well Idr exactly the implementation, but it probably just checks the cache or sth
granite owl
i use it in my command to modify that player if he is a valid target
noble lantern
offline target or online
granite owl
UUID uuid = NonReflectables.getPlayerUUID(args[0]);
if (uuid != null)
{
OfflinePlayer player = Bukkit.getOfflinePlayer(uuid);
if (player != null)
{
if (player.isOnline() || player.hasPlayedBefore())
{
also
if a player is offline
player gets nullified
so your isOnline() would throw an NPE to my knowledge
ivory sleet
yes
ivory sleet
iirc it does
ivory sleet
but implementation might have changed
granite owl
huh?
grim ice
no that doesnt make sense
grim ice
isOnline wont throw npe
granite owl
Player or OfflinePlayer one of the two inherits the other
ivory sleet
isOnline wont throw npe
ye
granite owl
nono
if i explicitly want the online player
i just check if hes online by getting him
and if its not null
its a valid target
this is to target offlineplayers
ivory sleet
ye
noble lantern
so just use hasPlayedBefore()
grim ice
no
granite owl
who log in for the first time ever
grim ice
so just use hasPlayedBefore()
u may use isOnline before hasPlayedBefore
granite owl
kk
grim ice
cuz if online is true, it definitely hasPlayedBefore(), therefore skipping IO Checks
i think hasPlayedBefore uses IO
noble lantern
u may use isOnline before hasPlayedBefore
yes but he said hes checking if Player was null beforehand so isOnline() would always be false
grim ice
not sure tho
granite owl
so this if (player.isOnline() || player.hasPlayedBefore()) i suppose is accurate to use?
ivory sleet
yes 2hex
granite owl
by this isonline should be checked first
ivory sleet
but like File::exists isn't as heavy as writing or reading IO
grim ice
but like File::exists isn't as heavy as writing or reading IO
ig
but isOnline() will be better
to start with
ivory sleet
yup
granite owl
yea but if java isnt completly janky this should it
iterating the conditions left to right
granite owl
so this if (player.isOnline() || player.hasPlayedBefore()) i suppose is accurate...
^
and executing on the first true return value
grim ice
so this if (player.isOnline() || player.hasPlayedBefore()) i suppose is accurate...
if u wanna check if a player has joined ur server before yeh
granite owl
on logout
it should
disconnect of a player
when the data is written from memory
to his file
undone axleBOT