#help-development | SpigotMC | Page 1782

mortal hare Nov 22, 2021, 5:02 PM

#

oh yeah i forgot, yep its final, fuck bukkit

misty current Nov 22, 2021, 5:02 PM

#

it also implements an interface

#

maybe i can make it implement it?

mortal hare Nov 22, 2021, 5:02 PM

#

i've had this issue before

misty current Nov 22, 2021, 5:02 PM

#

doubt it would do anything

#

PluginIdentifiableCommand

mortal hare Nov 22, 2021, 5:03 PM

#

no it wouldnt work

#

wait nvm

#

it could

ivory sleet Nov 22, 2021, 5:03 PM

#

What are you trying to do

mortal hare Nov 22, 2021, 5:03 PM

#

he's trying to setup Command node system

#

for his plugin probs

ivory sleet Nov 22, 2021, 5:03 PM

#

Ah

misty current Nov 22, 2021, 5:03 PM

#

yea, tryna register commands outside plugin.yml

#

commandapi

ivory sleet Nov 22, 2021, 5:03 PM

#

Technically don’t need PluginCommand at all

mortal hare Nov 22, 2021, 5:03 PM

#

ivory sleet Technically don’t need PluginCommand at all

it breaks things if you don't use it

quaint mantle Nov 22, 2021, 5:03 PM

#

Incendo/Cloud 👉 👉

mortal hare Nov 22, 2021, 5:04 PM

#

for example getCommand() doesnt work anymore

#

since it checks instanceof PluginCommand

#

or something like that

#

afaik

ivory sleet Nov 22, 2021, 5:04 PM

#

yeah sure but you could just create a new derived system based of Command ?

mortal hare Nov 22, 2021, 5:04 PM

#

you need to sync commands yourself

#

just because of dumb final keyword

ivory sleet Nov 22, 2021, 5:04 PM

#

Yuh

misty current Nov 22, 2021, 5:04 PM

#

can't even construct the class

#

else it would be pretty useless

ivory sleet Nov 22, 2021, 5:04 PM

#

Which class

misty current Nov 22, 2021, 5:05 PM

#

PluginCommand

mortal hare Nov 22, 2021, 5:05 PM

#

PluginCommand

ivory sleet Nov 22, 2021, 5:05 PM

#

You can tho

#

Reflection

misty current Nov 22, 2021, 5:05 PM

#

misty current else it would be pretty useless

wouldn't it be useless

#

not like i can override its methods

ivory sleet Nov 22, 2021, 5:05 PM

#

You can inject a custom command executor

#

And what not

#

Because most of its properties are mutable

misty current Nov 22, 2021, 5:06 PM

#

hm i don't know, that sounds worse than just extending Command

ivory sleet Nov 22, 2021, 5:06 PM

#

it’s a bit limiting sure

quaint mantle Nov 22, 2021, 5:07 PM

#

Dam just use a command framework

ivory sleet Nov 22, 2021, 5:08 PM

#

Bukkit’s command api roo_confuse

misty current Nov 22, 2021, 5:08 PM

#

Bukkit's command api's kinda doo doo

quaint mantle Nov 22, 2021, 5:08 PM

#

I wish we will get a better command api someday

ivory sleet Nov 22, 2021, 5:09 PM

#

🙏

#

Might be a good time to redo the thing when md5 is gonna yeet the enums

misty current Nov 22, 2021, 5:09 PM

#

new CommandBuilder("addenchant")
                .setAliases("addcustomenchant", "customenchant")
                .appendArgument(new StringArgument()
                        .setArgName("enchant id"))
                        .setTabCompleter(enchants::getRegisteredEnchantsIds)

                .appendArgument(new IntegerArgument(1)
                        .setArgName("level")
                        .setTabCompleter(1, 2, 3, 4, 5)
                )

                .appendArgument(new PlayerArgument(true)
                        .setTabCompleter(Utils::getOnlinePlayersList)
                )

                .executesPlayer((player, args) -> {
                    String ench = args[0];
                    int level = Integer.parseInt(args[1]);
                    Player playerArg = Bukkit.getPlayer(args[2]);
                    //code
                    }
                });

i like this more

quaint mantle Nov 22, 2021, 5:10 PM

#

ivory sleet Bukkit’s command api <:roo_confuse:744140156143140904>

by command framework i meant proper command framework

stone sinew Nov 22, 2021, 5:10 PM

#

@ivory sleet @sullen marlin Thanks for your help. (Also anyone else I didn't mention but that had helped.)
https://github.com/TheCrappiest/TaskManagement
Output: ```
[2021-11-22 10:20:50] main
[2021-11-22 10:20:50] ForkJoinPool-1-worker-13
[2021-11-22 10:20:50] ForkJoinPool-1-worker-4
[2021-11-22 10:20:50] ForkJoinPool-1-worker-9
[2021-11-22 10:20:50] ForkJoinPool-1-worker-11
[2021-11-22 10:20:50] ForkJoinPool-1-worker-2
[2021-11-22 10:20:50] main
[2021-11-22 10:20:50] main
[2021-11-22 10:20:50] main
[2021-11-22 10:20:50] main
[2021-11-22 10:21:01] main was delayed.
[2021-11-22 10:21:01] ForkJoinPool-1-worker-2 was delayed.

misty current Nov 22, 2021, 5:11 PM

#

yeah anyways i guess i'll stick with restarts

quaint mantle Nov 22, 2021, 5:11 PM

#

Singletones ☹️
-1000000 social credit
☹️

misty current Nov 22, 2021, 5:12 PM

#

i use singletones sometimes, they're useful

#

especially to store player data or such

quaint mantle Nov 22, 2021, 5:13 PM

#

What stops you from not using singletones to store player data or such

ivory sleet Nov 22, 2021, 5:13 PM

#

stone sinew <@!299969655915806741> <@!263617378032680962> Thanks for your help. (Also anyone...

Oo pog

#

Singleton and unit tests pepeShocked

stone sinew Nov 22, 2021, 5:13 PM

#

ivory sleet Oo pog

Oh god... I just looked through the github... why does github add 8 spaces instead of 4 for spacing?

waxen plinth Nov 22, 2021, 5:14 PM

#

misty current ```java new CommandBuilder("addenchant") .setAliases("addcustome...

🤢

ivory sleet Nov 22, 2021, 5:14 PM

#

stone sinew Oh god... I just looked through the github... why does github add 8 spaces inste...

Idk might be cause you use tabs

misty current Nov 22, 2021, 5:14 PM

#

quaint mantle What stops you from not using singletones to store player data or such

nothing but i see a lot of different opinions about them

waxen plinth Nov 22, 2021, 5:14 PM

#

misty current especially to store player data or such

That's really not unique to singletons at all

stone sinew Nov 22, 2021, 5:14 PM

#

ivory sleet Idk might be cause you use tabs

I don't. I add 4 spaces xD

ivory sleet Nov 22, 2021, 5:14 PM

#

Uh Idk then shrug

quaint mantle Nov 22, 2021, 5:14 PM

#

waxen plinth 🤢

(RedLib adverstiment starts here)

misty current Nov 22, 2021, 5:14 PM

#

misty current nothing but i see a lot of different opinions about them

so i really don't know if i should use them or not lol

stone sinew Nov 22, 2021, 5:14 PM

#

I wish you could edit a class without needing to commit

waxen plinth Nov 22, 2021, 5:15 PM

#

What

misty current Nov 22, 2021, 5:15 PM

#

wait redempt you used to be a developer on orbitmc or something similar

#

didn't you

waxen plinth Nov 22, 2021, 5:15 PM

#

quaint mantle (RedLib adverstiment starts here)

All I'm sayin is that builder looks real ugly

waxen plinth Nov 22, 2021, 5:16 PM

#

misty current wait redempt you used to be a developer on orbitmc or something similar

Yes, I was the only developer lol

#

Wait I remember you from there

ivory sleet Nov 22, 2021, 5:16 PM

#

waxen plinth All I'm sayin is that builder looks real ugly

What is your preferred style

waxen plinth Nov 22, 2021, 5:16 PM

#

I knew I remembered you from somewhere!

ivory sleet Nov 22, 2021, 5:16 PM

#

annots?

misty current Nov 22, 2021, 5:16 PM

#

waxen plinth I knew I remembered you from somewhere!

same

#

redlib made me remember

waxen plinth Nov 22, 2021, 5:16 PM

#

ivory sleet annots?

Those are just as space inefficient

misty current Nov 22, 2021, 5:16 PM

#

you were talking about it in server chat too lmao

waxen plinth Nov 22, 2021, 5:16 PM

#

But prettier I suppose

#

And more organized

ivory sleet Nov 22, 2021, 5:17 PM

#

Yeah Idk what’s better either

quaint mantle Nov 22, 2021, 5:17 PM

#

Annotations -> organized

waxen plinth Nov 22, 2021, 5:17 PM

#

I would say annotation > builder

#

But command file > annotation 💪

ivory sleet Nov 22, 2021, 5:17 PM

#

uwu

misty current Nov 22, 2021, 5:17 PM

#

i'm proud of my builder :c

#

not that experienced

waxen plinth Nov 22, 2021, 5:17 PM

#

Want to try an alternative

misty current Nov 22, 2021, 5:17 PM

#

tbf i'm surprised it got it to work

ivory sleet Nov 22, 2021, 5:18 PM

#

Proves you’re smarter than what you think (:

misty current Nov 22, 2021, 5:18 PM

#

waxen plinth Want to try an alternative

lemme guess

#

redlib?

#

:p

waxen plinth Nov 22, 2021, 5:19 PM

#

👀

#

If you don't wanna try it you can say so and I will stop talking about it

misty current Nov 22, 2021, 5:19 PM

#

i took a look at it before deciding to develop my own

quaint mantle Nov 22, 2021, 5:20 PM

#

waxen plinth I would say annotation > builder

No abstraction at all, primitive types only and no possibilities to get annotation paramaters from non static context ☹️

#

accidental reactions

misty current Nov 22, 2021, 5:20 PM

#

just wanted to challenge myself so i made my own

#

i had found a similar one but it was for 1.13+

#

and i'm on 1.8

#

insults incoming

waxen plinth Nov 22, 2021, 5:20 PM

#

quaint mantle No abstraction at all, primitive types only and no possibilities to get annotati...

Primitives only?

#

Really?

ivory sleet Nov 22, 2021, 5:21 PM

#

Tbh builders with generic types would be nice once we get project valhallas primitive generic thingy jep

waxen plinth Nov 22, 2021, 5:21 PM

#

Well that changes my tune

waxen plinth Nov 22, 2021, 5:21 PM

#

misty current and i'm on 1.8

cringe

mortal hare Nov 22, 2021, 5:21 PM

#

Builder ftw. Annotations use reflections to process things

misty current Nov 22, 2021, 5:21 PM

#

:d

quaint mantle Nov 22, 2021, 5:21 PM

#

Well , enums, classes, and arrays

waxen plinth Nov 22, 2021, 5:21 PM

#

Reflection is fine lol

misty current Nov 22, 2021, 5:21 PM

#

i like builders, they are very sexy

waxen plinth Nov 22, 2021, 5:21 PM

#

I love reflection

quaint mantle Nov 22, 2021, 5:21 PM

#

You could probably abuse enum mutability but eh

misty current Nov 22, 2021, 5:21 PM

#

i have a gui builder, item builder, command builder...

mortal hare Nov 22, 2021, 5:22 PM

#

Reflection is fine until you don't use it as your main source of doing all the things

waxen plinth Nov 22, 2021, 5:22 PM

#

And honestly I would be really surprised if the reflection overhead is higher than time it takes to process commands anyways

#

Considering how complicated that code is

quaint mantle Nov 22, 2021, 5:22 PM

#

waxen plinth I love reflection

reflection based code is a nightmare smh

waxen plinth Nov 22, 2021, 5:22 PM

#

How so

#

It has pitfalls but it has huge advantages too

ivory sleet Nov 22, 2021, 5:23 PM

#

Yeah

#

Depends on what exactly you’re doing

misty current Nov 22, 2021, 5:23 PM

#

afaik reflection abuse not gud

waxen plinth Nov 22, 2021, 5:23 PM

#

Yeah conflating all reflection with abuse is also not good though

#

You can make a lot of really nice abstractions with reflection

#

Obviously you shouldn't use it for everything

#

But it's not nearly as slow as most people will lead you to believe

#

And it's getting much faster in java 18

mortal hare Nov 22, 2021, 5:24 PM

#

its not slow af as it used to be

waxen plinth Nov 22, 2021, 5:24 PM

#

As in, java 18 will have nearly no reflection overhead

ivory sleet Nov 22, 2021, 5:24 PM

#

waxen plinth And it's getting much faster in java 18

Oo, what is getting improved more specifically?

mortal hare Nov 22, 2021, 5:24 PM

#

i love patterns in jdk14+

waxen plinth Nov 22, 2021, 5:25 PM

#

Reflection is going to use method handles under the hood instead of its own pathways

ivory sleet Nov 22, 2021, 5:25 PM

#

Ah

blazing scarab Nov 22, 2021, 5:25 PM

#

i've heard it's going to use methodhandles internally

ivory sleet Nov 22, 2021, 5:25 PM

#

That’s awesome

waxen plinth Nov 22, 2021, 5:25 PM

#

Yep

#

And method handles have nearly no overhead

uneven lily Nov 22, 2021, 5:25 PM

#

please help me
https://paste.md-5.net/exaliwosab.sql
error
if iam using any command regarding plugins it is showing a internal error occured while attempting this command how to fiix it
imaginedev bro please help me

ivory sleet Nov 22, 2021, 5:26 PM

#

I know that if you use smtng like a method handle lookup where you unreflect a reflective object it’s going to be slow in invocation. But else yeah if you use lambda meta factory it’s darn fast.

mortal hare Nov 22, 2021, 5:26 PM

#

so basically under the hood it would utilise some kind of address pointer under the hood

#

to find the method quickly

#

?

waxen plinth Nov 22, 2021, 5:26 PM

#

Method handles are just a direct reference to a method basically

blazing scarab Nov 22, 2021, 5:26 PM

#

honeslty, reflection code always looks like a mess
https://github.com/KyoriPowered/adventure-platform/blob/master/platform-bukkit/src/main/java/net/kyori/adventure/platform/bukkit/MinecraftComponentSerializer.java
as example

GitHub

adventure-platform/MinecraftComponentSerializer.java at master · Ky...

Adventure platform implementations. Contribute to KyoriPowered/adventure-platform development by creating an account on GitHub.

waxen plinth Nov 22, 2021, 5:26 PM

#

So yeah

#

They're much faster than reflection

waxen plinth Nov 22, 2021, 5:27 PM

#

ivory sleet I know that if you use smtng like a method handle lookup where you unreflect a r...

Really?

ivory sleet Nov 22, 2021, 5:27 PM

#

blazing scarab honeslty, reflection code always looks like a mess https://github.com/KyoriPower...

Yuh indeed

waxen plinth Nov 22, 2021, 5:27 PM

#

I thought unreflect made it faster

#

I haven't used it though so I don't know for sure

misty current Nov 22, 2021, 5:27 PM

#

oh also a thing about reflection

mortal hare Nov 22, 2021, 5:27 PM

#

this is more stream API mess than Reflection API mess for me

misty current Nov 22, 2021, 5:27 PM

#

should you use it for NMS access?

ivory sleet Nov 22, 2021, 5:27 PM

#

Yeah redempt, think matt switched over to method handles in triumph cmds where he basically just unreflect’d turned out to be slower than normal reflection iirc

waxen plinth Nov 22, 2021, 5:28 PM

#

Stream API... Mess?

waxen plinth Nov 22, 2021, 5:28 PM

#

ivory sleet Yeah redempt, think matt switched over to method handles in triumph cmds where h...

Weird

blazing scarab Nov 22, 2021, 5:28 PM

#

isnt unreflect is just a convenience method to get a method handle from reflection method?

ivory sleet Nov 22, 2021, 5:28 PM

#

Idk actually

blazing scarab Nov 22, 2021, 5:28 PM

#

for sure you can do a lookup by yourself

waxen plinth Nov 22, 2021, 5:28 PM

#

The overhead is really not a big deal for commands anyways though

ivory sleet Nov 22, 2021, 5:28 PM

#

Indeed

waxen plinth Nov 22, 2021, 5:28 PM

#

Commands aren't that performance critical

blazing scarab Nov 22, 2021, 5:28 PM

#

mortal hare this is more stream API mess than Reflection API mess for me

LoL no stream api is used here

ivory sleet Nov 22, 2021, 5:29 PM

#

Stream api tends to make code cleaner, and not messier shrug

blazing scarab Nov 22, 2021, 5:29 PM

#

oh wait nvm

waxen plinth Nov 22, 2021, 5:29 PM

#

ivory sleet Stream api tends to make code cleaner, and not messier <:shrug:84885926477588070...

Yeah

mortal hare Nov 22, 2021, 5:29 PM

#

ivory sleet Stream api tends to make code cleaner, and not messier <:shrug:84885926477588070...

i prefer old C way

waxen plinth Nov 22, 2021, 5:29 PM

#

Stream API is a fucking godsend

mortal hare Nov 22, 2021, 5:29 PM

#

its a choice

waxen plinth Nov 22, 2021, 5:29 PM

#

Yeah it is

#

And streams are cleaner and easily parallelizable

mortal hare Nov 22, 2021, 5:30 PM

#

maybe i should try to use streams more.

#

is the overhead big?

waxen plinth Nov 22, 2021, 5:30 PM

#

You shouldn't do everything with them

waxen plinth Nov 22, 2021, 5:30 PM

#

mortal hare is the overhead big?

Not really

#

It's about 15-20% slower from benchmarks Matt ran

#

I don't use them on performance critical stuff

#

But for everything else they're cheff's kiss

mortal hare Nov 22, 2021, 5:31 PM

#

well but parallel streams are really godsend

waxen plinth Nov 22, 2021, 5:31 PM

#

Ok I gotta go, toodles

waxen plinth Nov 22, 2021, 5:31 PM

#

mortal hare well but parallel streams are really godsend

Exactly

ivory sleet Nov 22, 2021, 5:32 PM

#

Can we choose the executor of a parallel stream? Haven’t used them so just out of curiosity

waxen plinth Nov 22, 2021, 5:34 PM

#

@mortal hare

ivory sleet Nov 22, 2021, 5:34 PM

#

Ah actually doesn’t look like its possible which might be a downside

mortal hare Nov 22, 2021, 5:35 PM

#

yea it uses ForkJoinPool.commonPool()

#

just like CompletableFuture

#

but at least you can pass your own executor in completablefuture afaik

ivory sleet Nov 22, 2021, 5:36 PM

#

CompletableFuture doesn’t necessarily use fjp cp

#

Yeah

#

But if the parallelism of cp is 1 then iirc it just has an executor which starts a thread for every supplied function

tribal gyro Nov 22, 2021, 5:52 PM

#

how do you change the max hearts a player has

visual tide Nov 22, 2021, 5:52 PM

#

?di

undone axleBOT Nov 22, 2021, 5:52 PM

#

Guide to dependency injection: https://www.spigotmc.org/wiki/using-dependency-injection/

visual tide Nov 22, 2021, 5:53 PM

#

pass your plugin instance

waxen plinth Nov 22, 2021, 6:01 PM

#

Or config instance

visual tide Nov 22, 2021, 6:01 PM

#

^

tardy delta Nov 22, 2021, 6:14 PM

#

or string 😳

ivory sleet Nov 22, 2021, 6:15 PM

#

LeeSpin

quaint mantle Nov 22, 2021, 6:15 PM

#

CharSequence

tardy delta Nov 22, 2021, 6:16 PM

#

stfu real bros use a char[]

quaint mantle Nov 22, 2021, 6:17 PM

#

const char*

tardy delta Nov 22, 2021, 6:18 PM

#

dont break my brain again

tribal gyro Nov 22, 2021, 6:21 PM

#

how do I make an indefinite potion effect

undone pebble Nov 22, 2021, 6:23 PM

#

by using Integer.MAX_VALUE as your duration

quaint mantle Nov 22, 2021, 6:23 PM

#

or 99999

#

How would you call an implementation of a Clan that also applies changes to the database? ClanImpl is already taken

#

AutoSavingClan maybe

tardy delta Nov 22, 2021, 6:28 PM

#

yesh uwu

ivory sleet Nov 22, 2021, 6:32 PM

#

FinalDatabaseManagableClanImpl 🥴

silent steppe Nov 22, 2021, 6:40 PM

#

just a quick question, the runTaskTimerAsynchronously function runs the runnable on its own new thread right?

young knoll Nov 22, 2021, 6:43 PM

#

It runs on one of the bukkit worker threads

quaint mantle Nov 22, 2021, 6:44 PM

#

ivory sleet FinalDatabaseManagableClanImpl 🥴

Conclure, just want to thank you second time. I spent a lots of time solving that design issue, and now i finally feel free!

tribal gyro Nov 22, 2021, 6:45 PM

#

how do i set max health of a player

young knoll Nov 22, 2021, 6:46 PM

#

getAttribute(whatever the health one is).setBaseValue

tribal gyro Nov 22, 2021, 6:46 PM

#

young knoll getAttribute(whatever the health one is).setBaseValue

will that change the ui for how many hearts you have

young knoll Nov 22, 2021, 6:47 PM

#

Yes

quaint mantle Nov 22, 2021, 6:54 PM

#

if i wanna run a task async, should i use CompletableFutures? Or BukkitScheduler is preffered?

ivory sleet Nov 22, 2021, 6:54 PM

#

What are you doing in the task? 😮

quaint mantle Nov 22, 2021, 6:55 PM

#

ivory sleet What are you doing in the task? 😮

hahahahahaha... executing sql queries

ivory sleet Nov 22, 2021, 6:56 PM

#

Ah oui, hmm maybe a CompletableFuture with a custom executor.

quaint mantle Nov 22, 2021, 6:56 PM

#

i made a tricky editor system to apply multiple changes at once

ivory sleet Nov 22, 2021, 6:56 PM

#

I mean the Bukkit scheduler is fine, just that having your very own stuff gives you more power.

#

Oo

#

Like a bulk operator?

quaint mantle Nov 22, 2021, 6:58 PM

#

Yeah, kinda

public static void editor(Clan clan, Component displayName, ClanMember member) {
        
        clan.edit(editor -> editor.setDisplayName(displayName).addMember(member));
    }

Using jdbc transactions

ivory sleet Nov 22, 2021, 7:05 PM

#

Oo that looks neat

tardy delta Nov 22, 2021, 7:08 PM

#

why dont function?

#

🤓

quaint mantle Nov 22, 2021, 7:09 PM

#

🧐

tardy delta Nov 22, 2021, 7:10 PM

#

#help-server message

drifting grove Nov 22, 2021, 7:13 PM

#

How may I convert player to string? so I can get the player name instead of the whole player thing

quaint mantle Nov 22, 2021, 7:14 PM

#

Question, how could I get the nearest player object from an entity?

quaint mantle Nov 22, 2021, 7:15 PM

#

drifting grove How may I convert player to string? so I can get the player name instead of the ...

player.getName...

quaint mantle Nov 22, 2021, 7:15 PM

#

quaint mantle Question, how could I get the nearest player object from an entity?

getNearbyEntites i guess?

#

mmm how would does that work?

maiden thicket Nov 22, 2021, 7:16 PM

#

so i'm using the steer packet to help the player control an entity, but i believe i did it a little janky

#

i have a player riding an arrow riding the entity

#

because i needed to position the player

#

so i had them ride an arrow

#

        Arrow arrow = (Arrow) entity.getWorld().spawnEntity(entity.getLocation().clone().add(0, 0, 1.5), org.bukkit.entity.EntityType.ARROW);
        arrow.setGravity(false);
        entity.addPassenger(arrow);
        System.out.println(arrow.isInsideVehicle());
        arrow.addPassenger(event.getPlayer());

        event.getPlayer().setCollidable(false);```

#

that's the player getting on, entity being the vehicle / entity to ride

drifting grove Nov 22, 2021, 7:17 PM

#

quaint mantle player.getName...

I tried that but I got this public HashMap<Zombie, Player> ZombieToName = new HashMap(); and im getting it by doing ZombieToName.get(zombie)) but when I do player.getname, it still doesnt actually just show the name but the whole player thing

maiden thicket Nov 22, 2021, 7:17 PM

#

    @EventHandler
    public void onSteer(InputEvent event) {
        if (event.getPlayer().getVehicle().getType() != org.bukkit.entity.EntityType.ARROW) return;
        if (event.getPlayer().getVehicle().getVehicle() == null) return;
        if (!matches(event.getPlayer().getVehicle().getVehicle(), "helicopter")) return;

        float angle = new Vector(event.getPacket().getZza(), 0, event.getPacket().getXxa()).normalize().angle(new Vector(1, 0, 0));
        Vector vechileVelocity = event.getPlayer().getEyeLocation().getDirection().rotateAroundY(angle);
        event.getPlayer().getVehicle().getVehicle().setVelocity(vechileVelocity);
        event.getPlayer().getVehicle().setVelocity(vechileVelocity);
        event.getPlayer().setVelocity(vechileVelocity);
    }```

#

this is me listening to the steer packet event

#

the entity itself moves, but the player and the arrow remain still

quaint mantle Nov 22, 2021, 7:18 PM

#

drifting grove I tried that but I got this `public HashMap<Zombie, Player> ZombieToName = new H...

Show the code

tardy delta Nov 22, 2021, 7:19 PM

#

why dont function?

mortal hare Nov 22, 2021, 7:20 PM

#

drifting grove Nov 22, 2021, 7:20 PM

#

quaint mantle Show the code

that is the code, what I showed

#

thats how I store and how I use it

misty current Nov 22, 2021, 7:21 PM

#

what happens if you set the damage to negative in an entitydamageevent?

#

does the victim heal?

mortal hare Nov 22, 2021, 7:21 PM

#

if i had to guess he'll die

quaint mantle Nov 22, 2021, 7:23 PM

#

misty current what happens if you set the damage to negative in an entitydamageevent?

Nothing

#

Maybe a illegal argument exception

tardy delta Nov 22, 2021, 7:23 PM

#

bruh

tardy delta Nov 22, 2021, 7:24 PM

#

misty current does the victim heal?

try it on yourself?

misty current Nov 22, 2021, 7:24 PM

#

quaint mantle Nothing

thanks

ember estuary Nov 22, 2021, 7:29 PM

#

What's the alternative to the depricated World#regenerateChunk ?

tardy delta Nov 22, 2021, 7:31 PM

#

From the JavaDocs
"Deprecated.
regenerating a single chunk is not likely to produce the same chunk as before as terrain decoration may be spread across chunks. Use of this method should be avoided as it is known to produce buggy results."

If you don't mind that, you can keep on using the regenerateChunk method.
If you do, you'd need to pretty much rewrite all world generation in order to support it. (Also, look below for another possible solution)

ember estuary Nov 22, 2021, 7:33 PM

#

can you send me the docs?

#

because here it doesnt say that https://hub.spigotmc.org/javadocs/spigot/org/bukkit/World.html#regenerateChunk(int,int)

World (Spigot-API 1.18-pre5-R0.1-SNAPSHOT API)

declaration: package: org.bukkit, interface: World

tardy delta Nov 22, 2021, 7:34 PM

#

uhh i found it on github

ember estuary Nov 22, 2021, 7:35 PM

#

But doesn't deprecated mean its gonna be removed in the next versions

tardy delta Nov 22, 2021, 7:35 PM

#

uhh i dunno how that works with the spigot api

ember estuary Nov 22, 2021, 7:35 PM

#

Or do deprecated methods stay forever

#

idk either

#

wouldnt wanna use something thats about to be removed in 1.18/1.19

quaint mantle Nov 22, 2021, 7:36 PM

#

ember estuary But doesn't deprecated mean its gonna be removed in the next versions

No

ember estuary Nov 22, 2021, 7:36 PM

#

then whats the point of deprecated

visual tide Nov 22, 2021, 7:37 PM

#

ember estuary then whats the point of deprecated

to stop people from using it when theres something better

quaint mantle Nov 22, 2021, 7:37 PM

#

Deprecated is used to striketrough questioniable methods

#

To get developer attention LoL

ember estuary Nov 22, 2021, 7:37 PM

#

visual tide to stop people from using it when theres something better

Then whats the better alternative to regenerateChunk ??

quaint mantle Nov 22, 2021, 7:37 PM

#

visual tide to stop people from using it when theres something better

not only

quaint mantle Nov 22, 2021, 7:37 PM

#

ember estuary Then whats the better alternative to regenerateChunk ??

There's no, just read deprecation note

visual tide Nov 22, 2021, 7:37 PM

#

ember estuary Then whats the better alternative to regenerateChunk ??

just cause it's deprecated doesnt mean there's an alternative
it's just often the case

tardy delta Nov 22, 2021, 7:38 PM

#

there is no better alternative, you could store the chunks so you get the exact state

ember estuary Nov 22, 2021, 7:38 PM

#

visual tide just cause it's deprecated doesnt mean there's an alternative it's just often th...

You just said that tho ... "to stop people from using it when theres something better"

visual tide Nov 22, 2021, 7:38 PM

#

ember estuary You just said that tho ... "to stop people from using it when theres something b...

"usually"

ember estuary Nov 22, 2021, 7:39 PM

#

tardy delta there is no better alternative, you could store the chunks so you get the exact ...

i wanna change a specific part of the seed and then regenerate them.

#

just gonna use it then and hope it doesnt get removed xD

dense shoal Nov 22, 2021, 7:41 PM

#

Good afternoon! I'm trying to add a mechanic to my plugin where a crossbow is automatically reloaded (in certain cases). I'm attempting to do this via CrossbowMeta, setting charged projectiles and then setting the item meta. Currently, my POC code and testing it, I'm firing a health 2 tipped arrow and am trying to reload the crossbow with a regular arrow.

What I'm expecting to happen: After firing the health 2 tipped arrow, the crossbow is loaded with a regular arrow after firing.

What is happening: after firing the health 2 tipped arrow, nothing more is happening. I can't fire the arrow that should supposedly be loaded.

What I have tried: My suspicion was that I was trying to set a charged projectile too early and then tried setting the charged project in a sync delayed task.

Here is my relevant code:

    @EventHandler
    public void onArrowFire(EntityShootBowEvent event)
    {
        // If the entity is a player
        if (MUtil.isntPlayer(event.getEntity())) return;
        
        Player player = (Player) event.getEntity();
        UPlayer uPlayer = UPlayer.get(player);
        
        // and the player is a level 1 Qadir
        if (!abilityCheck(uPlayer, 1)) return;
        
        // and the thing that the Qadir is shooting from is not null
        if (event.getBow() == null) return;
        
        // and the thing that the Qadir is shooting from is not a cross bow
        if (event.getBow().getType() != Material.CROSSBOW) return;
        
        ItemStack crossbow = event.getBow();
        
        System.out.println(crossbow);
        
        // and the projectile shot is an arrow
        if (!(event.getProjectile() instanceof Arrow)) return;
        Arrow arrow = (Arrow) event.getProjectile();
        
        // Prevent the arrow from being able to be picked up (don't allow people to dupe lol)
        arrow.setPickupStatus(PickupStatus.DISALLOWED);
        
        CrossbowMeta crossbowMeta = (CrossbowMeta) crossbow.getItemMeta();
        assert crossbowMeta != null;
        crossbowMeta.setChargedProjectiles(MUtil.list(new ItemStack(Material.ARROW, 1)));
        
        crossbow.setItemMeta(crossbowMeta);
        
        System.out.println(crossbow);
    }```

In my debugs, I can see that the first System.out.println() is outputting the crossbow with the tipped arrow and the second one is outputting the crossbow with the regular arrow. I could also observe this behavior with the IntelliJ debug evaluator. 

Please forgive me for any hilarious mistake I have made, I started working on this at roughly 2a today rip. A second pair of eyes would be appreciated though 😄

Here's a picture of the console debug output for good measure:
https://i.imgur.com/tKCtP9o.png

Imgur

#

OH, I also tried just adding a new crossbow to my inventory, that works, I get a loaded crossbow.

ember estuary Nov 22, 2021, 8:03 PM

#

What about player.updateInventory(); after the crossbow.setItemMeta(crossbowMeta);?

#

but just replacing the item entirely, like you're doing now, should also do the trick, yeah

dense shoal Nov 22, 2021, 8:08 PM

#

ember estuary What about player.updateInventory(); after the crossbow.setItemMeta(crossbowMeta...

Heya, thanks for your reply. Now I'm trying to just even remove the bow from the inventory after firing and I think I'm going nuts. I noticed that I was missing the updateInventory call a little bit ago. The following won't work:

    public void onArrowFire(EntityShootBowEvent event)
    {
        // If the entity is a player
        if (MUtil.isntPlayer(event.getEntity())) return;
        
        Player player = (Player) event.getEntity();
        UPlayer uPlayer = UPlayer.get(player);
        
        // and the player is a level 1 Qadir
        if (!abilityCheck(uPlayer, 1)) return;
        
        // and the thing that the Qadir is shooting from is not null
        if (event.getBow() == null) return;
        
        // and the thing that the Qadir is shooting from is not a cross bow
        if (event.getBow().getType() != Material.CROSSBOW) return;
        
        ItemStack crossbow = event.getBow();
        
        // and the projectile shot is an arrow
        if (!(event.getProjectile() instanceof Arrow)) return;
        Arrow arrow = (Arrow) event.getProjectile();
        
        // Prevent the arrow from being able to be picked up (don't allow people to dupe lol)
        arrow.setPickupStatus(PickupStatus.DISALLOWED);
        
        CrossbowMeta crossbowMeta = (CrossbowMeta) crossbow.getItemMeta();
        assert crossbowMeta != null;
        crossbowMeta.setChargedProjectiles(MUtil.list(new ItemStack(Material.ARROW, 1)));
        
        player.getInventory().removeItem(crossbow);
        
        player.getInventory().setItemInMainHand(new ItemStack(Material.AIR, 1));
        player.updateInventory();
        
    }```

I can remove other stuff though with success. I was doing `.removeItem(new ItemStack(Material.CHEST, 1))` with success. I think that if I get the above working, I can identify the root of the problem.

I noticed that when calling removeItem(), there's a hashmap that it returns with the items that could not be removed and the hashmap is empty. So, I believe that Spigot *thinks* that the item is being removed. But it persists in my inventory after relogging and disconnect, so I don't think it is a client side issue.

#

I also looped through the player's entire inventory and noted the crossbow was not there after the method completed.

subtle folio Nov 22, 2021, 8:10 PM

#

How do i disable taking off armor with spigot?

dense shoal Nov 22, 2021, 8:10 PM

#

Also I'm in survival

tardy delta Nov 22, 2021, 8:10 PM

#

does player.updateInv() even does anything?

dense shoal Nov 22, 2021, 8:11 PM

#

tardy delta does player.updateInv() even does anything?

I thought it was necessary if certain things were updated. But I think that opening and closing an inventory will accomplish the same functionality.

tardy delta Nov 22, 2021, 8:11 PM

#

i update things and i dont need it

dense shoal Nov 22, 2021, 8:12 PM

#

subtle folio How do i disable taking off armor with spigot?

You could find the associated event and cancel it if it's armor, maybe InventoryClickEvent https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryClickEvent.html could help. Alternatively, you could just apply like curse of binding or something.

InventoryClickEvent (Spigot-API 1.18-pre5-R0.1-SNAPSHOT API)

declaration: package: org.bukkit.event.inventory, class: InventoryClickEvent

misty current Nov 22, 2021, 8:12 PM

#

sometimes i'm getting NaN when dividing the event damage squared over the final damage. what might cause it?

ember estuary Nov 22, 2021, 8:14 PM

#

maybe if its 0?

#

the damage

tardy delta Nov 22, 2021, 8:15 PM

#

NaN in java 🤔

ember estuary Nov 22, 2021, 8:15 PM

#

0.0 / 0.0 gives NaN

tardy delta Nov 22, 2021, 8:15 PM

#

that gives a ..

ember estuary Nov 22, 2021, 8:15 PM

#

it gives NaN

tardy delta Nov 22, 2021, 8:15 PM

#

dividebyzeroexception or something?

ember estuary Nov 22, 2021, 8:15 PM

#

nope

#

NaN

#

try it

tardy delta Nov 22, 2021, 8:15 PM

#

rawr

ember estuary Nov 22, 2021, 8:16 PM

#

https://www.jdoodle.com/online-java-compiler/
Input System.out.println(0.0/0.0);, will give you NaN

JDoodle - free Online Compiler, Editor for Java, C/C++, etc

JDoodle is a free Online Compiler, Editor, IDE for Java, C, C++, PHP, Perl, Python, Ruby and many more. you can run your programs on the fly online and you can save and share them with others. Quick and Easy way to compile and run programs online.

dense shoal Nov 22, 2021, 8:16 PM

#

Are you taking a square root of anything? NaN could result from the production of an imaginary number i. Otherwise, I think a floating point zero divided by 0 will output a NaN.

ember estuary Nov 22, 2021, 8:17 PM

#

Just if damage == 0 return

#

Should fix it

misty current Nov 22, 2021, 8:17 PM

#

dense shoal Are you taking a square root of anything? NaN could result from the production o...

nope, i'm just dividing the square of the damage by the final damage

#

it's basically to set the final damage

tardy delta Nov 22, 2021, 8:17 PM

#

WHAT THE HECK

ember estuary Nov 22, 2021, 8:18 PM

#

and if both is 0 your doing 0.0/0.0 = NaN. just check if its not 0

misty current Nov 22, 2021, 8:18 PM

#

0/0 is an arithmetic exception whatever

#

but 0.0/0.0 is NaN

#

java being java

ember estuary Nov 22, 2021, 8:18 PM

#

xD

dense shoal Nov 22, 2021, 8:18 PM

#

IEEE 754

#

http://mathcenter.oxford.emory.edu/site/cs170/ieee754/

misty current Nov 22, 2021, 8:18 PM

#

what if it is 1.0/0.0

ember estuary Nov 22, 2021, 8:18 PM

#

infinity?

#

lemme try

misty current Nov 22, 2021, 8:19 PM

#

think so

ember estuary Nov 22, 2021, 8:19 PM

#

yeah

#

Infinity, as expected

misty current Nov 22, 2021, 8:19 PM

#

what if a number is very small

#

like very close to 0

tardy delta Nov 22, 2021, 8:19 PM

#

hey java.lang.ArithmeticException: / by zero
at Main.main(Main.java:3)

misty current Nov 22, 2021, 8:19 PM

#

like 0.00000001

ember estuary Nov 22, 2021, 8:19 PM

#

then it will just get close to infinity

misty current Nov 22, 2021, 8:19 PM

#

does it approx to 0.0

tardy delta Nov 22, 2021, 8:19 PM

#

java cringe

ember estuary Nov 22, 2021, 8:19 PM

#

gives 1.0E10

tardy delta Nov 22, 2021, 8:19 PM

#

noone ever told me nan exists in java

ember estuary Nov 22, 2021, 8:19 PM

#

u know double can do really high and low right

misty current Nov 22, 2021, 8:19 PM

#

yea

ember estuary Nov 22, 2021, 8:19 PM

#

xD

misty current Nov 22, 2021, 8:20 PM

#

because sometimes i've noticed my damage gets very close to 0

#

or sometimes doubles randomly gains 10 nines after the dot

ember estuary Nov 22, 2021, 8:20 PM

#

that should be a worry tho

misty current Nov 22, 2021, 8:20 PM

#

and i still don't understand why

ember estuary Nov 22, 2021, 8:20 PM

#

wont give NaN

misty current Nov 22, 2021, 8:20 PM

#

aight

tardy delta Nov 22, 2021, 8:21 PM

#

i heard that too much this evening bye

misty current Nov 22, 2021, 8:21 PM

#

k so i can just check if either getdamage or getfinaldamage is 0

#

and do stuff

ember estuary Nov 22, 2021, 8:21 PM

#

yeah

#

should do the right

misty current Nov 22, 2021, 8:21 PM

#

aight thanks

ember estuary Nov 22, 2021, 8:21 PM

#

no problem

tardy delta Nov 22, 2021, 8:22 PM

#

night uwu

misty current Nov 22, 2021, 8:22 PM

#

night

ember estuary Nov 22, 2021, 8:23 PM

#

You can just do
if (Double.isNaN(result)) System.out.println(theOneDamageValue +" "+ theOtherDamageValue);
to see what the values are in case you get NaN

#

but yeah i assume they're 0.0

misty current Nov 22, 2021, 8:24 PM

#

o yea useful

#

thanks

ember estuary Nov 22, 2021, 8:24 PM

#

no problem ^^

misty current Nov 22, 2021, 8:24 PM

#

i'll send it as a warn

#

in the logger

ember estuary Nov 22, 2021, 8:24 PM

#

yeah, better than println xD

misty current Nov 22, 2021, 8:25 PM

#

:p

subtle folio Nov 22, 2021, 8:26 PM

#

dense shoal You could find the associated event and cancel it if it's armor, maybe Inventory...

that doesnt exist in 1.8.8 XD

dense shoal Nov 22, 2021, 8:27 PM

#

I have never touched 1.8.8, sorry

twilit wharf Nov 22, 2021, 8:27 PM

#

how do I get unicode characters to show in chat? I want a star

subtle folio Nov 22, 2021, 8:27 PM

#

dont worry, i just checked with that event if it was armor you were right.

twilit wharf Nov 22, 2021, 8:28 PM

#

twilit wharf how do I get unicode characters to show in chat? I want a star

all it shows is the decompressed version

subtle folio Nov 22, 2021, 8:28 PM

#

no recommened 1.8.8 unless pvp

ember estuary Nov 22, 2021, 8:28 PM

#

thats probably why he uses it

ember estuary Nov 22, 2021, 8:28 PM

#

twilit wharf all it shows is the decompressed version

with the \u.... code

#

whats the character you want

quaint mantle Nov 22, 2021, 8:30 PM

#

fuck 1.8 pvp tho

ember estuary Nov 22, 2021, 8:30 PM

#

1.8 pvp is great

#

xD

ember estuary Nov 22, 2021, 8:30 PM

#

twilit wharf how do I get unicode characters to show in chat? I want a star

what character do you want

#

what star

twilit wharf Nov 22, 2021, 8:31 PM

#

✦

#

or U+2726

ember estuary Nov 22, 2021, 8:31 PM

#

\u2726

#

put this in the string

twilit wharf Nov 22, 2021, 8:31 PM

#

yeah, I just did that, testing now

ember estuary Nov 22, 2021, 8:31 PM

#

alright

twilit wharf Nov 22, 2021, 8:32 PM

#

yep, that worked

#

thanks

ember estuary Nov 22, 2021, 8:32 PM

#

nice :D

#

no problem

twilit wharf Nov 22, 2021, 8:32 PM

#

I appreciate it

ember estuary Nov 22, 2021, 8:32 PM

#

glad i could help

ember estuary Nov 22, 2021, 8:34 PM

#

subtle folio that doesnt exist in 1.8.8 XD

The InventoryClickEvent does exist in 1.8.8
https://helpch.at/docs/1.8.8/org/bukkit/event/inventory/InventoryClickEvent.html

subtle folio Nov 22, 2021, 8:34 PM

#

ember estuary The InventoryClickEvent does exist in 1.8.8 https://helpch.at/docs/1.8.8/org/buk...

im talking about curse of binding..

ember estuary Nov 22, 2021, 8:34 PM

#

ahhh sorry

subtle folio Nov 22, 2021, 8:34 PM

#

no worries

dawn phoenix Nov 22, 2021, 8:43 PM

#

So 1.16 to 1.17 --- NMS changed a ton... any write up on those changes?

quaint mantle Nov 22, 2021, 8:52 PM

#

dawn phoenix So 1.16 to 1.17 --- NMS changed a ton... any write up on those changes?

See 1.17 developer notes on spigotmc.org

glossy venture Nov 22, 2021, 8:59 PM

#

static String formatterPatternSwitch(Object o) {
    return switch (o) {
        case Integer i -> String.format("int %d", i);
        case Long l    -> String.format("long %d", l);
        case Double d  -> String.format("double %f", d);
        case String s  -> String.format("String %s", s);
        default        -> o.toString();
    };
}
``` duuuude

#

this is new in jdk 17

#

type checking switch statements

#

https://openjdk.java.net/projects/jdk/17/

eternal night Nov 22, 2021, 8:59 PM

#

it is still in preview isn't it

ivory sleet Nov 22, 2021, 8:59 PM

#

That’s an expression I think but yeah pretty pog

glossy venture Nov 22, 2021, 9:00 PM

#

eternal night it is still in preview isn't it

no i think it got released

#

minecraft 1.18 is in jdk 17

eternal night Nov 22, 2021, 9:00 PM

#

https://openjdk.java.net/jeps/406

#

seems to be in preview

dense shoal Nov 22, 2021, 9:00 PM

#

I see the enumerable of all the particles that can be used in spigot here: https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Particle.html

Is anyone aware of any like... pictures?

Particle (Spigot-API 1.18-pre5-R0.1-SNAPSHOT API)

declaration: package: org.bukkit, enum: Particle

glossy venture Nov 22, 2021, 9:00 PM

#

eternal night seems to be in preview

#

the full jdk 17 launched in september this year

#

i think

#

at least it was scheduled to

eternal night Nov 22, 2021, 9:02 PM

#

can't recall this being in first preview in java 15 tho

glossy venture Nov 22, 2021, 9:02 PM

#

dense shoal I see the enumerable of all the particles that can be used in spigot here: https...

maybe theres a minecraft wiki about it

#

hm

#

idk

eternal night Nov 22, 2021, 9:03 PM

#

Yea, this is still in preview. E.g. the move of pattern matching in instance of: https://openjdk.java.net/jeps/305 in java 14 to https://openjdk.java.net/jeps/375 in java 15 and https://openjdk.java.net/jeps/394 in java 16

glossy venture Nov 22, 2021, 9:03 PM

#

ohk

#

the memory segments are already in it tho

#

https://openjdk.java.net/jeps/412

#

i tested

ivory sleet Nov 22, 2021, 9:07 PM

#

Yeah foreign memory api is all good to go

young knoll Nov 22, 2021, 9:08 PM

#

Foreign who what

sullen marlin Nov 22, 2021, 9:20 PM

#

damn foreigners

#

ruining our memory

vale cradle Nov 22, 2021, 9:21 PM

#

ivory sleet Yeah foreign memory api is all good to go

I'm pretty excited about it ngl

gloomy edge Nov 22, 2021, 9:30 PM

#

Would anyone know how to fix this? https://www.spigotmc.org/threads/specialsourcemp-error.534817/ Or what could be causing this?

SpigotMC - High Performance Minecraft

1.17.x - SpecialSourceMP Error

Hello, I get "Unexpected end of ZLIB input stream" often when I compile my plugin.

To compile my plugin I use clean install package

Here's the error...

sullen marlin Nov 22, 2021, 9:32 PM

#

seems your jar is broke

#

rerun BuildTools.jar --remapped

dawn phoenix Nov 22, 2021, 9:36 PM

#

Speaking of development anyone have experience migrating nexus servers?
Got a lot of plugins depending on my nexus and i gotta move it off my box

sullen marlin Nov 22, 2021, 9:36 PM

#

which nexus version

#

I'd stick with 2.x if you can

#

I upgraded one to 3.x and kind of regret it

#

but it should be as simple as just copying the directories

#

its all self contained

gloomy edge Nov 22, 2021, 9:43 PM

#

I re-ran java -jar BuildTools.jar --rev 1.17.1 --remapped and tried to compile again and still the same error

sullen marlin Nov 22, 2021, 9:45 PM

#

thats really weird

#

oh hm could be your plugin jar is corrupt

#

youre not coding in a onedrive folder or anything are you?

gloomy edge Nov 22, 2021, 9:47 PM

#

No, but the project is on a different drive

sullen marlin Nov 22, 2021, 9:49 PM

#

hmmm I'll try building your plugin

#

compiled for me

#

lol

#

it'd be interesting to find the issue

#

antivirus maybe?

#

something is corrupting the jar

gloomy edge Nov 22, 2021, 9:51 PM

#

Let me test with antivirus off

#

Wow, It was Bitdefender the whole time.

sullen marlin Nov 22, 2021, 9:56 PM

#

gottem

gloomy edge Nov 22, 2021, 9:57 PM

#

Thank you! anyways I should've tried that before asking for help; my bad

sullen marlin Nov 22, 2021, 9:58 PM

#

no worries, it's not always obvious

#

antivirus does seem to cause a lot of issues though

worn condor Nov 22, 2021, 9:58 PM

#

Anyone know how I'd add enchanted books to a merchant using MerchantRecipe, I tried but it doesn't show the recipe in the trading UI
however when I print the recipes the merchant has, it does show it has that recipe
ItemStack{ENCHANTED_BOOK x 1, ENCHANTED_META:{meta-type=ENCHANTED, enchants={MENDING=1}}}

sullen marlin Nov 22, 2021, 9:59 PM

#

doesnt show it how?

#

like at all? or do you need an enchanted book in your inventory

worn condor Nov 22, 2021, 9:59 PM

#

https://cdn.lukatjee.be/QETO5/vOHEKoWi34.png

#

In here

sullen marlin Nov 22, 2021, 9:59 PM

#

sorry not super familiar with merchants

#

if you dont have an enchant does it work?

worn condor Nov 22, 2021, 9:59 PM

#

Ye

sullen marlin Nov 22, 2021, 10:00 PM

#

do merchants have enchanted items in vanilla?

worn condor Nov 22, 2021, 10:00 PM

#

Ye, f.e. librarian villagers I think hold enchanted books

sullen marlin Nov 22, 2021, 10:01 PM

#

hmmm

#

do you have a 5 liner I can test with

worn condor Nov 22, 2021, 10:03 PM

#

uhh, it's a listener so it's rather complicated

#

1 sec

sullen marlin Nov 22, 2021, 10:05 PM

#

        EnchantmentStorageMeta meta = (EnchantmentStorageMeta) enchanted.getItemMeta();
        meta.addStoredEnchant( Enchantment.LURE, 3, true );
        enchanted.setItemMeta( meta );

        WanderingTrader trader = l.getWorld().spawn( l, WanderingTrader.class );
        trader.setRecipes( Arrays.asList( new MerchantRecipe( new ItemStack( Material.ENCHANTED_BOOK ), 10 ), new MerchantRecipe( enchanted, 5 ) ) );```

#

does this look kind of similar

worn condor Nov 22, 2021, 10:06 PM

#

ye

sullen marlin Nov 22, 2021, 10:06 PM

#

ok testing

#

apparently merchant recipes need ingredients lol

#

silly api

worn condor Nov 22, 2021, 10:08 PM

#

oop ye :3

sullen marlin Nov 22, 2021, 10:08 PM

#

#

works for me

#

        EnchantmentStorageMeta meta = (EnchantmentStorageMeta) enchanted.getItemMeta();
        meta.addStoredEnchant( Enchantment.LURE, 3, true );
        enchanted.setItemMeta( meta );

        MerchantRecipe first = new MerchantRecipe( new ItemStack( Material.ENCHANTED_BOOK ), 10 );
        first.addIngredient( new ItemStack( Material.STONE ) );
        MerchantRecipe second = new MerchantRecipe( enchanted, 5 );
        second.addIngredient( new ItemStack( Material.COBBLESTONE ) );

        WanderingTrader trader = l.getWorld().spawn( l, WanderingTrader.class );
        trader.setRecipes( Arrays.asList( first, second ) );```

#

note: 1.18-pre5, but I doubt its different in 1.17.1

worn condor Nov 22, 2021, 10:09 PM

#

could you print the .getResult() from the second one?

sullen marlin Nov 22, 2021, 10:10 PM

#

like second.getResult() ?

#

[09:10:19] [Server thread/INFO]: ItemStack{ENCHANTED_BOOK x 1, ENCHANTED_META:{meta-type=ENCHANTED, stored-enchants={LURE=3}}}

#

oooh

#

I think the issue is you enchanted the book

#

not added a stored enchant to the book

#

use addStoredEnchant not addEnchant

#

they look similar aside from the text colour, but the result is different

crimson terrace Nov 22, 2021, 10:13 PM

#

Hey md_5 ive been having trouble with my plugins perms. any ideas? ive been getting ignored a bit and I dont know if its because the question is too dumb

sullen marlin Nov 22, 2021, 10:13 PM

#

too dumb

#

maybe :p

#

your code: "p.hasPermission("permissions.VB.SummonBosses")"

#

your permission: "VB.SummonBosses"

#

remove the permissions. part

#

(from your code, not yaml)

crimson terrace Nov 22, 2021, 10:14 PM

#

oh the path i copied from the yaml had that in there. thanks 🙂

crimson terrace Nov 22, 2021, 10:15 PM

#

sullen marlin > too dumb

now I agree. brainfart.

worn condor Nov 22, 2021, 10:20 PM

#

still doesn't work

peak badge Nov 22, 2021, 10:57 PM

#

Hello, is there ProtocolLib fan? Can you explain me how set structure for this nms packet: (pls ping me 😉 )

class PacketPlayOutEntityEquipment {
    private final int b;
    private final List<Pair<EnumItemSlot, ItemStack>> c;
}

sullen marlin Nov 22, 2021, 11:00 PM

#

Player#sendEquipmentChange

#

no protocollib required 🙂

young knoll Nov 22, 2021, 11:01 PM

#

Wait hold up

#

That's a thing? cool

sullen marlin Nov 22, 2021, 11:02 PM

#

only on 1.18 but yes

peak badge Nov 22, 2021, 11:02 PM

#

Thanks md_5, but I'm writing npcs :<

young knoll Nov 22, 2021, 11:02 PM

#

Woo new features

peak badge Nov 22, 2021, 11:03 PM

#

Do we have 1.18? XD

young knoll Nov 22, 2021, 11:03 PM

#

We have 1.18-pre5

sullen marlin Nov 22, 2021, 11:03 PM

#

why do you even need packets for npcs

#

cant you just like y'know spawn them in the world

#

I feel like the leap to entirely API npcs is not very far

misty current Nov 22, 2021, 11:04 PM

#

interesting

sullen marlin Nov 22, 2021, 11:04 PM

#

what is the error

ancient plank Nov 22, 2021, 11:04 PM

#

description 100

proud basin Nov 22, 2021, 11:04 PM

#

I'm assuming it's a null pointer

foggy estuary Nov 22, 2021, 11:09 PM

#

Does anyone know if it is possible to add potion effects if you walk on certain blocks…?

young knoll Nov 22, 2021, 11:10 PM

#

Sure

ancient plank Nov 22, 2021, 11:11 PM

#

anything is possible

#

smile

lean gull Nov 22, 2021, 11:41 PM

#

anyone know how to use custom heads in a gui?

young knoll Nov 22, 2021, 11:48 PM

#

Just add the itemstack

lean gull Nov 22, 2021, 11:48 PM

#

idk how to make custom heads in java tho

#

is there a way to just set / add the nbt to the itemstack?

young knoll Nov 22, 2021, 11:49 PM

#

It's a bit finicky

lean gull Nov 22, 2021, 11:49 PM

#

young knoll It's a bit finicky

what's "finicky"

young knoll Nov 22, 2021, 11:49 PM

#

https://www.spigotmc.org/threads/how-to-create-heads-with-custom-base64-texture.352562/

lean gull Nov 22, 2021, 11:52 PM

#

i can't use gameprofile, i've tried it before

proud basin Nov 22, 2021, 11:52 PM

#

Why can’t you?

lean gull Nov 22, 2021, 11:53 PM

#

idk

#

i'll try their method in a sec

#

https://paste.md-5.net/wowexukapa.java

paper viper Nov 23, 2021, 12:13 AM

#

its cause you didnt import authlib as a dependency

young knoll Nov 23, 2021, 12:14 AM

#

It's part of NMS, but you can also import it separately

sullen marlin Nov 23, 2021, 12:15 AM

#

not part of nms in 1.18

paper viper Nov 23, 2021, 12:16 AM

#

To add it:
repo: https://libraries.minecraft.net/
group id: com.mojang
artifact: authlib
version: 1.5.26

chilly hill Nov 23, 2021, 12:29 AM

#

Is there a way to change the y level of where the player enters a different dimension?

sullen marlin Nov 23, 2021, 12:39 AM

#

sure, just teleport them to the new location

#

PlayerWorldChangeEvent or something

lean gull Nov 23, 2021, 12:43 AM

#

paper viper To add it: repo: https://libraries.minecraft.net/ group id: com.mojang artifact:...

am not sure how to use this

sullen marlin Nov 23, 2021, 12:43 AM

#

it'll be in your local repo if you've run buildtools

lean gull Nov 23, 2021, 12:44 AM

#

can anyone help

late kraken Nov 23, 2021, 12:47 AM

#

Trying to start a server on the 1.18-pre5 jar but every time it loads the end it gets stuck at a random percentage. Is this an issue for it right now?

sullen marlin Nov 23, 2021, 12:48 AM

#

no

late kraken Nov 23, 2021, 12:48 AM

#

Hmm weird then

sullen marlin Nov 23, 2021, 12:49 AM

#

try and isolate it without plugins / a specific subsection of your world, then open a bug report

late kraken Nov 23, 2021, 12:50 AM

#

Okay thanks

#

Hmm deleted the bundler folder seems to fix it

sullen marlin Nov 23, 2021, 12:57 AM

#

seems surprising

golden turret Nov 23, 2021, 1:47 AM

#

how could i do a crafter system without needing to check every single item of the inventory?

#

i have the recipe stored in my object

paper viper Nov 23, 2021, 1:48 AM

#

you could try creating a hash based on the 9 slots of your inventory

#

and have a hashmap

#

that way you have O(1) efficiency

golden turret Nov 23, 2021, 1:49 AM

#

forgot to metion, it is in a chest inventory

paper viper Nov 23, 2021, 1:49 AM

#

i mean that doesnt matter

golden turret Nov 23, 2021, 1:49 AM

#

and the items arent ordered

proud basin Nov 23, 2021, 2:17 AM

#

Anyone know if protocolLib has a way to check if they are near a vehicle and if they are flying? Can't seem to find anything

maiden thicket Nov 23, 2021, 2:18 AM

#

proud basin Anyone know if protocolLib has a way to check if they are near a vehicle and if ...

cant u do nearby entities, if instanceof vehicle and if flying

#

something like getNearbyEntities(params).stream().filter(entity -> entity.isFlying() && entity instanceof Vehicle)

proud basin Nov 23, 2021, 2:19 AM

#

There is no reason to stream it

maiden thicket Nov 23, 2021, 2:19 AM

#

¯_(ツ)_/¯

sacred mountain Nov 23, 2021, 2:23 AM

#

i got this error after trying to load the 1.17 bungee proxy

#

oh i cant send images

young knoll Nov 23, 2021, 2:24 AM

#

Verify or use something like imgur

sacred mountain Nov 23, 2021, 2:25 AM

#

ok

#

#

i registered

golden turret Nov 23, 2021, 2:33 AM

#

golden turret how could i do a crafter system without needing to check every single item of th...

any help pls

proud basin Nov 23, 2021, 2:33 AM

#

How would one calculate airticks?

eternal plume Nov 23, 2021, 2:37 AM

#

Hello. Is it planned to use kyori adventure in spigot? https://github.com/KyoriPowered/adventure

#

I read it is to replace "bungee chat" api and is new improvement.

paper viper Nov 23, 2021, 2:38 AM

#

eternal plume Hello. Is it planned to use kyori adventure in spigot? https://github.com/KyoriP...

probably not

#

it is however used in paper

eternal plume Nov 23, 2021, 2:38 AM

#

ok I will keep using paper api

#

is it allowed paper plugins on spigotmc.org/resources? I think not

lean gull Nov 23, 2021, 2:39 AM

#

lean gull https://paste.md-5.net/wowexukapa.java

can anyone help with this? (look above for more info)

tribal gyro Nov 23, 2021, 2:56 AM

#

can plugins not edit text documetns?

paper viper Nov 23, 2021, 2:56 AM

#

?

#

they can?

tribal gyro Nov 23, 2021, 2:57 AM

#

then why it no workie

#

i think im doing it wrong smthg

paper viper Nov 23, 2021, 2:58 AM

#

damn man idk either

#

its not like you showed any code lol

tribal gyro Nov 23, 2021, 2:59 AM

#

        File dataFile = new File(fileName);
        FileWriter fileWriter = new FileWriter(dataFile, false);
        String condensedData = "";
        for (String s : text) {
            condensedData += s;
            condensedData += "\n";
        }
        fileWriter.write(condensedData);
        fileWriter.close();```

#

sorry

#

forgot

#

lol

#

assume fileName and text are all defined

#

text is an arraylsit

#

help :/

keen lily Nov 23, 2021, 3:04 AM

#

hello

fickle helm Nov 23, 2021, 3:04 AM

#

tribal gyro ```java File dataFile = new File(fileName); FileWriter fileWrite...

do yourself a favor and use a StringBuilder

keen lily Nov 23, 2021, 3:04 AM

#

i need help with replacing water with fire when the bucket empty event happens

tribal gyro Nov 23, 2021, 3:04 AM

#

fickle helm do yourself a favor and use a StringBuilder

i converted it baack from that

#

🤦‍♂️

subtle folio Nov 23, 2021, 3:07 AM

#

There is nothing wrong with my plugin.yml. I dont know why im getting this error: ```[03:02:32 ERROR]: Could not load 'plugins/Tazpvp-6.9.jar' in folder 'plugins'

org.bukkit.plugin.InvalidDescriptionException: Invalid plugin.yml

at org.bukkit.plugin.java.JavaPluginLoader.getPluginDescription(JavaPluginLoader.java:160) ~[patched.jar:git-PaperSpigot-"4c7641d"]

at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:136) [patched.jar:git-PaperSpigot-"4c7641d"]

at org.bukkit.craftbukkit.v1_8_R3.CraftServer.loadPlugins(CraftServer.java:293) [patched.jar:git-PaperSpigot-"4c7641d"]

at net.minecraft.server.v1_8_R3.DedicatedServer.init(DedicatedServer.java:202) [patched.jar:git-PaperSpigot-"4c7641d"]

at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:563) [patched.jar:git-PaperSpigot-"4c7641d"]

at java.lang.Thread.run(Thread.java:748) [?:1.8.0_292]

Caused by: java.util.zip.ZipException: zip file is empty

at java.util.zip.ZipFile.open(Native Method) ~[?:1.8.0_292]

at java.util.zip.ZipFile.<init>(ZipFile.java:225) ~[?:1.8.0_292]

at java.util.zip.ZipFile.<init>(ZipFile.java:155) ~[?:1.8.0_292]

at java.util.jar.JarFile.<init>(JarFile.java:166) ~[?:1.8.0_292]

at java.util.jar.JarFile.<init>(JarFile.java:130) ~[?:1.8.0_292]

at org.bukkit.plugin.java.JavaPluginLoader.getPluginDescription(JavaPluginLoader.java:148) ~[patched.jar:git-PaperSpigot-"4c7641d"]

... 5 more```

#

my plugin yml: https://www.toptal.com/developers/hastebin/ezonaxagem.yaml

quaint mantle Nov 23, 2021, 3:07 AM

#

zip file is empty?

subtle folio Nov 23, 2021, 3:08 AM

#

what zip file?

paper viper Nov 23, 2021, 3:08 AM

#

quaint mantle zip file is empty?

its just an exception usually from some sorta corrupted jar or something

#

cause you know, jars are still archives

tribal gyro Nov 23, 2021, 3:08 AM

#

fickle helm do yourself a favor and use a StringBuilder

``java

#

oops

#

        File dataFile = new File(fileName);
        FileWriter fileWriter = new FileWriter(dataFile, false);
        StringBuilder condensedData = new StringBuilder();
        for (String s : text) {
            condensedData.append(s).append("\n");
        }
        fileWriter.write(condensedData.toString());
        fileWriter.close();``` you know whats wrong?

paper viper Nov 23, 2021, 3:09 AM

#

well, that seems right. But you called the method right? (brain fart check)

tribal gyro Nov 23, 2021, 3:15 AM

#

yes

#

public static Hashtable<String, Integer> getData(Player player) throws IOException {
        String playerId = player.getUniqueId().toString();
        List<String> readData = readFile("playerData.txt");
        Hashtable<String, Integer> data = new Hashtable<>();

        boolean found = false;

        if (readData != null) {
            for (String read : readData) {
                String[] dataLine = read.split(" ");
                if (playerId.equals(dataLine[0])) {
                    found = true;
                    Bukkit.broadcastMessage("Data Found");
                    String[] playerData = read.split(";");
                    data.put("Strength", Integer.parseInt(playerData[1]));
                    data.put("MaxHealth", Integer.parseInt(playerData[2]));
                }
            }
        }

        if (!found && readData != null) {
            readData.add(playerId + " ;0;20");
            writeFile(readData, "playerData");
        } else if (!found) {
            List<String> newData = new ArrayList<>();
            newData.add(playerId + " ;0;20");
            writeFile(newData, "playerData");
            data.put("Strength", 0);
            data.put("MaxHealth", 20);
            Bukkit.broadcastMessage("Created new profile for " + player.getName());
        }

        return data;
    }``` is this correct?

sullen marlin Nov 23, 2021, 3:18 AM

#

gosh you want HashMap not hashtable

#

also you store your data in a list not a map wish is very inefficient

keen lily Nov 23, 2021, 3:18 AM

#

keen lily i need help with replacing water with fire when the bucket empty event happens

turns out part of the event is not triggering and i have 0 idea on why it isnt

sullen marlin Nov 23, 2021, 3:18 AM

#

perhaps just use the YamlConfiguration API and store in yaml rather than you rown config format

tribal gyro Nov 23, 2021, 3:22 AM

#

sullen marlin perhaps just use the YamlConfiguration API and store in yaml rather than you row...

but i suck

#

:/

#

but i just wantt o know why it isnt working

#

oh wait it does work

#

just its not writing in the correct file

#

oh bruh im dumb

#

i forgot to put txt after the file name

tribal gyro Nov 23, 2021, 3:53 AM

#

public static void onPlayerUse(PlayerInteractEvent event) throws IOException {
        Player player = event.getPlayer();
        ItemStack item = player.getInventory().getItemInMainHand();
        ItemMeta meta = item.getItemMeta();
        if(meta != null && meta.getLore() != null) {
            if (event.getAction().equals(Action.RIGHT_CLICK_AIR) || event.getAction().equals(Action.RIGHT_CLICK_BLOCK)) {
                if (meta.getDisplayName().equals(ChatColor.AQUA+"Strength Adder")) {
                    PlayerData.changeData(player, 1, "Strength");
                    Bukkit.broadcastMessage("Strength");
                    PlayerData.updateData(player);
                } else if (meta.getDisplayName().equals(ChatColor.RED+"Health Adder")) {
                    PlayerData.changeData(player, 1, "Health");
                    Bukkit.broadcastMessage("Health");
                    PlayerData.updateData(player);
                } else {
                    meta.getDisplayName();
                }
                if (item.getAmount() == 1) {
                    player.getInventory().setItemInMainHand(new ItemStack(Material.AIR));
                } else {
                    item.setAmount(item.getAmount()-1);
                }
            }
        }
    }``` anyone know why this event keeps getting registered twice?

uneven lily Nov 23, 2021, 3:58 AM

#

any one please help me i downloaded a plugin but it is not working properly but iam using via version still it is not working how to fix it

sullen marlin Nov 23, 2021, 4:01 AM

#

check event.getHand or whatever

echo basalt Nov 23, 2021, 4:02 AM

#

tribal gyro ```java File dataFile = new File(fileName); FileWriter fileWrite...

String.join???

tribal gyro Nov 23, 2021, 4:04 AM

#

echo basalt String.join???

wdym

quaint mantle Nov 23, 2021, 4:04 AM

#

Hello, It's been quite a while since I've coded anything and I've recently been getting back into plugin development. I'm trying to make a very simple faction core.

Here is my code:

public boolean onCommand(CommandSender sender, Command command, String s, String[] args) {
        Player player = (Player) sender;
        if (args[1] == null) {
            player.sendMessage(Utils.chat("&cYou must provide a argument. Usage: /f create <name>."));
            return false;
        }
        Configuration config1 = (Configuration) plugin.getConfig();
        config1.createSection(args[1] + ": []");
        return false;
    }

Upon running it generates this error:

#

org.bukkit.command.CommandException: Unhandled exception executing command 'fcreate' in plugin funnyplugin v1.0
       
Caused by: java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1

#

only left in the main parts ^

#

unsure exactly what the issue is, i suspect i may just be using the createSection method incorrectly

uneven lily Nov 23, 2021, 4:08 AM

#

any one please help me i downloaded a plugin but it is not working properly but iam using via version still it is not working how to fix it

echo basalt Nov 23, 2021, 4:09 AM

#

tribal gyro wdym

String result = String.join("\n", text);

tribal gyro Nov 23, 2021, 4:11 AM

#

echo basalt String result = String.join("\n", text);

?????

echo basalt Nov 23, 2021, 4:12 AM

#

Read the docs

echo basalt Nov 23, 2021, 4:13 AM

#

quaint mantle Hello, It's been quite a while since I've coded anything and I've recently been ...

Check if args.length < 2

#

@quaint mantle

quaint mantle Nov 23, 2021, 4:14 AM

#

echo basalt Check if args.length < 2

oh yeah i forgot u gotta check the args length 🤦

#

damn its been a while

#

i literally tried doing !args[1] at first

echo basalt Nov 23, 2021, 4:14 AM

#

Lol

#

Happens

sullen marlin Nov 23, 2021, 4:18 AM

#

@young knoll -Pdevelopment to check for missing annotations (@NotNull)

#

also mention ticket in commit message if you can please

quaint mantle Nov 23, 2021, 4:21 AM

#

echo basalt Check if args.length < 2

retyrbs wutg tge san errot

#

oml wtf did i just type

#

returns with the same error

echo basalt Nov 23, 2021, 4:22 AM

#

Check before

quaint mantle Nov 23, 2021, 4:22 AM

#

if (args[1].length() < 2) {

quaint mantle Nov 23, 2021, 4:22 AM

#

echo basalt Check before

?

echo basalt Nov 23, 2021, 4:22 AM

#

No wtf

#

Legit my message

#

How are you going to obtain the second object on an array of size 1

grand escarp Nov 23, 2021, 4:23 AM

#

does anyone know how to add a smithing recipe, but instead of the netherite ingot, it's a custom item in the same class? i cant seem to get smithing recipes working without custom items (normally) :(

echo basalt Nov 23, 2021, 4:24 AM

#

grand escarp does anyone know how to add a smithing recipe, but instead of the netherite ingo...

Either events or nms

grand escarp Nov 23, 2021, 4:25 AM

#

echo basalt Either events or nms

that doesnt help much, im a beginner

#

idk what u mean lol

echo basalt Nov 23, 2021, 4:25 AM

#

https://www.spigotmc.org/threads/preparesmithingevent-setresult-buggy.507584/#post-4171530

SpigotMC - High Performance Minecraft

Solved - PrepareSmithingEvent setResult buggy(?)

I try to add new recipes to the smithing table, that recipe has a dynamic result item (based on the first and the second slot/item). That means i...

quaint mantle Nov 23, 2021, 4:37 AM

#

echo basalt No wtf

well now despite there being a argument provided, it returns with the error i provided if a argument isnt inputted

echo basalt Nov 23, 2021, 4:38 AM

#

Invert the check

quaint mantle Nov 23, 2021, 4:40 AM

#

echo basalt Invert the check

?

grand escarp Nov 23, 2021, 4:49 AM

#

echo basalt https://www.spigotmc.org/threads/preparesmithingevent-setresult-buggy.507584/#po...

i dont see where to add the ingredients

#

nvm that

#

how do i add AttributeModifiers to items

young knoll Nov 23, 2021, 5:06 AM

#

sullen marlin <@!125349520249847809> -Pdevelopment to check for missing annotations (@NotNull)

-Pdevelopment?

quaint mantle Nov 23, 2021, 5:09 AM

#

so does config.addSection() actually save a new entry to the config.yml or..

#

it seems to not be doing so for me

tribal gyro Nov 23, 2021, 5:09 AM

#

public static void onPlayerUse(PlayerInteractEvent event) throws IOException {
        Player player = event.getPlayer();
        ItemStack item = player.getInventory().getItemInMainHand();
        ItemMeta meta = item.getItemMeta();
        if(meta != null && meta.getLore() != null) {
            if (event.getAction().equals(Action.RIGHT_CLICK_AIR) || event.getAction().equals(Action.RIGHT_CLICK_BLOCK)) {
                if (meta.getDisplayName().equals(ChatColor.AQUA+"Strength Adder")) {
                    PlayerData.changeData(player, 1, "Strength");
                    Bukkit.broadcastMessage("Strength");
                    PlayerData.updateData(player);
                } else if (meta.getDisplayName().equals(ChatColor.RED+"Health Adder")) {
                    PlayerData.changeData(player, 1, "Health");
                    Bukkit.broadcastMessage("Health");
                    PlayerData.updateData(player);
                } else {
                    meta.getDisplayName();
                }
                if (item.getAmount() == 1) {
                    player.getInventory().setItemInMainHand(new ItemStack(Material.AIR));
                } else {
                    item.setAmount(item.getAmount()-1);
                }
            }
        }
    }``` anyone know why its doing this twice?

sullen marlin Nov 23, 2021, 5:10 AM

#

young knoll -Pdevelopment?

defvelopment maven profile

tribal gyro Nov 23, 2021, 5:24 AM

#

tribal gyro ```java public static void onPlayerUse(PlayerInteractEvent event) throws IOExcep...

can someone helpe me

waxen plinth Nov 23, 2021, 5:26 AM

#

tribal gyro ```java public static void onPlayerUse(PlayerInteractEvent event) throws IOExcep...

The event fires once for main hand, once for off hand when they interact

#

Easiest way is to add this line at the start:

#

if (e.getHand() != EquipmentSlot.HAND) return;```

tribal gyro Nov 23, 2021, 5:32 AM

#

like before if(meta != null ....

tribal gyro Nov 23, 2021, 5:32 AM

#

waxen plinth Easiest way is to add this line at the start:

that line?

waxen plinth Nov 23, 2021, 5:32 AM

#

Yeah just return if the interact was fired from the offhand

#

AKA not from the main hand

#

Speaking of which

#

You should use early return to clean up that code

#

Also 8 spaces for indentation?

#

🌚

#

    public static void onPlayerUse(PlayerInteractEvent event) throws IOException {
        Player player = event.getPlayer();
        ItemStack item = player.getInventory().getItemInMainHand();
        ItemMeta meta = item.getItemMeta();
        if (meta == null || meta.getLore() == null) {
            return;
        }
        if (!event.getAction().toString().startsWith("RIGHT")) {
            return;
        }
        if (meta.getDisplayName().equals(ChatColor.AQUA+"Strength Adder")) {
            PlayerData.changeData(player, 1, "Strength");
            Bukkit.broadcastMessage("Strength");
            PlayerData.updateData(player);
        } else if (meta.getDisplayName().equals(ChatColor.RED+"Health Adder")) {
            PlayerData.changeData(player, 1, "Health");
            Bukkit.broadcastMessage("Health");
            PlayerData.updateData(player);
        } else {
            meta.getDisplayName();
        }
        if (item.getAmount() == 1) {
            player.getInventory().setItemInMainHand(new ItemStack(Material.AIR));
        } else {
            item.setAmount(item.getAmount()-1);
        }
    }```

#

Here, see how I flattened it by taking some of the conditions out, checking them first and returning if they are not met?

#

It works the exact same way but it's a lot less indented now, much easier to read

tribal gyro Nov 23, 2021, 5:42 AM

#

ah

#

ty

#

im very inexperienced with java

#

👀

lavish hemlock Nov 23, 2021, 5:43 AM

#

?learnjava :)

undone axleBOT Nov 23, 2021, 5:43 AM

#

Here are some links to get you started on learning Java:

The last one is the only official one, however some of those concepts assume that you already know a bit about programming.

tardy delta Nov 23, 2021, 7:37 AM

#

is there a good implementation somewhere about how to setup a tabcompleter in each command class?

quaint mantle Nov 23, 2021, 7:40 AM

#

using command framework

west oxide Nov 23, 2021, 7:41 AM

#

hey

#

i cant figure out what i did wrong on this one

#

        public String getPrefix(plugin prefix){
            plugin.getConfig().getString("prefix");
        }```

tardy delta Nov 23, 2021, 7:42 AM

#

quaint mantle using command framework

well tell me one

quaint mantle Nov 23, 2021, 7:42 AM

#

incendo/Cloud is cool

west oxide Nov 23, 2021, 7:42 AM

#

west oxide ```Plugin plugin = this; public String getPrefix(plugin prefix){ ...

it gives me error here

#

i want to be able to just call this on other classes and get the prefix from config.yml

glossy venture Nov 23, 2021, 7:43 AM

#

west oxide it gives me error here

Plugin has to be uppercase

west oxide Nov 23, 2021, 7:43 AM

#

glossy venture Plugin has to be uppercase

even if i did this before it ?

#

glossy venture Nov 23, 2021, 7:43 AM

#

(Plugin prefix)

glossy venture Nov 23, 2021, 7:43 AM

#

west oxide even if i did this before it ?

yes bro

west oxide Nov 23, 2021, 7:44 AM

#

still error

glossy venture Nov 23, 2021, 7:44 AM

#

everywhere

west oxide Nov 23, 2021, 7:44 AM

#

glossy venture Nov 23, 2021, 7:44 AM

#

what is the code around it

west oxide Nov 23, 2021, 7:44 AM

#

    public void onEnable() {
        Plugin plugin = this;
        public String getPrefix(Plugin prefix){
            plugin.getConfig().getString("prefix");
        }
        saveDefaultConfig();
        getCommand("info").setExecutor(new info());
        getCommand("Fly").setExecutor(new Fly());
        getCommand("enchant").setExecutor(new enchant());
        getCommand("Bangui").setExecutor(new Bangui());
        getCommand("Heal").setExecutor(new Heal());
        getCommand("Feed").setExecutor(new Feed());
        getCommand("Gmc").setExecutor(new gmc());
        getCommand("Gms").setExecutor(new gms());
        getCommand("Gmsp").setExecutor(new gmsp());
        getServer().getPluginManager().registerEvents(new JoinMessages(),this);
        getServer().getConsoleSender().sendMessage(ChatColor.AQUA + "BasicEssentials is now working !");

    }```

glossy venture Nov 23, 2021, 7:44 AM

#

you are defining a amethod in another method

#

not possible

#

put it outside

west oxide Nov 23, 2021, 7:44 AM

#

oh

#

thank you

#

that fixed

glossy venture Nov 23, 2021, 7:45 AM

#

do you know basic java

west oxide Nov 23, 2021, 7:45 AM

#

it gives me other error now smh

west oxide Nov 23, 2021, 7:45 AM

#

glossy venture do you know basic java

am learning it

glossy venture Nov 23, 2021, 7:45 AM

#

ok

tardy delta Nov 23, 2021, 7:45 AM

#

hyped

west oxide Nov 23, 2021, 7:45 AM

#

i watched few videos about constructors

#

and classes

#

i already know about variables

glossy venture Nov 23, 2021, 7:45 AM

#

?learnjava

undone axleBOT Nov 23, 2021, 7:45 AM

#

Here are some links to get you started on learning Java:

The last one is the only official one, however some of those concepts assume that you already know a bit about programming.

glossy venture Nov 23, 2021, 7:45 AM

#

some good resources

west oxide Nov 23, 2021, 7:46 AM

#

okay

#

thank you

#

i fixed the other error

glossy venture Nov 23, 2021, 7:46 AM

#

k

tardy delta Nov 23, 2021, 7:47 AM

#

anyways instead of in onEnable { instance = this; } and static Plugin getInstance { return instance; } cant u just return this?

glossy venture Nov 23, 2021, 7:47 AM

#

no lol

#

its static

tardy delta Nov 23, 2021, 7:47 AM

#

owh yea i forgot

glossy venture Nov 23, 2021, 7:47 AM

#

java doesnt know that its a singleton

quaint mantle Nov 23, 2021, 7:52 AM

#

tardy delta is there a good implementation somewhere about how to setup a tabcompleter in ea...

welp

#

if you implement tabcompleter at the same class that implemented commandexecutor

#

then when you register the command

tardy delta Nov 23, 2021, 7:53 AM

#

yea i know i have it in that way rn

quaint mantle Nov 23, 2021, 7:53 AM

#

it will automatically register tab completer for you

tardy delta Nov 23, 2021, 7:56 AM

#

normally my onCommand method shared a private field with the onTabComplete by calling a method which initiliazes it but now i'm getting some nprs

#

so directly overriding onTabComplete doesnt really work as i should call super.onTabCOmplete every time to get the player object etc

quaint mantle Nov 23, 2021, 7:57 AM

#

huh

#

what do you mean?

#

i dont understand-

tardy delta Nov 23, 2021, 7:57 AM

#

rn i fixed it like this

#

but therefore i has no executor field in the method and it took the one from the parent class

#

which is null rn

#

so i have to cast it every time and thats stupid as i just want to share objects

#

plain helm Nov 23, 2021, 8:00 AM

#

Guys does 1.12.2 support getConfig().getLocation() ?

quaint mantle Nov 23, 2021, 8:00 AM

#

go find it yourself? idk

plain helm Nov 23, 2021, 8:00 AM

#

Idk how

tardy delta Nov 23, 2021, 8:00 AM

#

i use (Location) config.get(string)

#

i threw an error

#

i forgot which one

#

on 1.16

quaint mantle Nov 23, 2021, 8:01 AM

#

lol.... 1.16 already support getlocation

tardy delta Nov 23, 2021, 8:02 AM

#

i dunno it never worked with me

plain helm Nov 23, 2021, 8:03 AM

#

It works with 1.16.5

#

I know that for sure

quaint mantle Nov 23, 2021, 8:03 AM

#

oh yeah

#

i used 1.16.5

#

or an alternative

#

getConfig.get(location here, Location.class)

west oxide Nov 23, 2021, 8:06 AM

#

hey i have question about java , so basically i did this and if i understood well , if am inside the same class i can just do getPrefix(); and it will do the action on the method ?


    Plugin plugin = this;
    public void getPrefix(Plugin prefix){
        plugin.getConfig().getString("prefix");
    }

quaint mantle Nov 23, 2021, 8:23 AM

#

huh...?

#

:madman:

quaint mantle Nov 23, 2021, 8:51 AM

#

Go learn java

#

Your code makes literally no sence

#

i wonder if he is trolling

#

or that is actually his code...

west oxide Nov 23, 2021, 9:00 AM

#

quaint mantle i wonder if he is trolling

pov you are this bad ...that ppl think you are trolling

#

lol

quaint mantle Nov 23, 2021, 9:00 AM

#

no

#

i literally have a pretty good start with java

#

while looks like you dont lol

west oxide Nov 23, 2021, 9:01 AM

#

yeah

tribal holly Nov 23, 2021, 9:33 AM

#

I bump my problem, because i still don't understand why my event is not fire

#

i register it, and even remove all my code expect the System.out and he still print nothing when i'm in my area

torn shuttle Nov 23, 2021, 9:49 AM

#

I'm not too hooked into things but wasn't 1.18 meant to do some changes to chunk loading with visual only and mob chunk loading?

#

wait the scoreboard api changed to a max of 32767 characters?

#

what is this dark magic

#

does it autoscroll now?

sullen marlin Nov 23, 2021, 9:58 AM

#

probably just glitches tbh

#

idk why mojang changed it

tardy delta Nov 23, 2021, 9:59 AM

#

what is the generic U?

sullen marlin Nov 23, 2021, 9:59 AM

#

generic names are just like variable names

#

they can be anything

tardy delta Nov 23, 2021, 9:59 AM

#

sometimes i'm wondering what they mean

#

like K is key

sullen marlin Nov 23, 2021, 9:59 AM

#

totally depends on what the author wants them to mean

tardy delta Nov 23, 2021, 10:00 AM

#

oki

torn shuttle Nov 23, 2021, 10:05 AM

#

honestly I prefer glitching out to erroring at 16, that thing made me want to pull the few hairs I have left out

#

so is there going to be an event for simulation chunks loading separate from the "visual" chunks now?

sullen marlin Nov 23, 2021, 10:08 AM

#

There's no real difference

#

Spigot has had essentially the same feature at various times

#

Notably entity activation range in 1.17

#

The block version was removed forever ago because everyone hated that it stopped their crops growing

#

Simulation range is really just that, entity and block activation range

torn shuttle Nov 23, 2021, 10:09 AM

#

well the real question is it detectable because if it is not this will effectively kill any plugins that scan entities on chunk load

sullen marlin Nov 23, 2021, 10:10 AM

#

How so?

#

Did entity activation range kill them?

torn shuttle Nov 23, 2021, 10:10 AM

#

I've come across with some issues, I can't tell exactly why, with persistent entities not being loaded on chunk load

sullen marlin Nov 23, 2021, 10:11 AM

#

That's a 1.17 thing and has been fixed months ago

torn shuttle Nov 23, 2021, 10:11 AM

#

has it?

#

I ended up taking the long way around that one lol

#

so it was a bug and not me going insane after all

#

though if entities don't load when non-sim blocks load and non-sim blocks "always*" load first, wouldn't that result in being unable to scan persistent entities in those chunks 100% of the time?

sullen marlin Nov 23, 2021, 10:12 AM

#

You're overthinking what simulation distance is

torn shuttle Nov 23, 2021, 10:12 AM

#

just activation?

sullen marlin Nov 23, 2021, 10:12 AM

#

Yes, as I said

torn shuttle Nov 23, 2021, 10:13 AM

#

I guess I assumed they went a step further and were sending players the chunk info without "really" loading it

#

so if one of those crash-happy entities resides in a chunk and it gets loaded into visual it will still crash a server just fine, right

sullen marlin Nov 23, 2021, 10:14 AM

#

Depends why it crashes?

torn shuttle Nov 23, 2021, 10:14 AM

#

excessive nbt data or whatever that exploit was

#

it's been a while

#

man just activation is pretty lame, for some reason I expected way more

#

huh barrier not a particle anymore in 1.18, interesting

#

that's a shame, it was super useful

#

does that mean barriers have a completely different display behavior then?

#

ah block_marker

sullen marlin Nov 23, 2021, 10:26 AM

#

If they're actually identical we can add a remap

torn shuttle Nov 23, 2021, 10:27 AM

#

they act the same

#

as it stands, just updated my 50k line codebase with only having to change 2 lines of code for the barrier particles, thanks for all the hard work with keeping things consistent throughout versions md_5 💯

sullen marlin Nov 23, 2021, 10:28 AM

#

Thanks, I'll look if we should add a remap and make it 0 tomorrow

torn shuttle Nov 23, 2021, 10:29 AM

#

that'd be awesome, I can verify in .5 seconds if they're the same behavior

#

actually it will take about as long as it takes to dl mc 1.18 snapshot 5, I was on 6

#

now that's interesting, the barrier particles did change

#

they used to take up the whole block

#

they are still as wide as a block on the barrier but via the API they are now noticeably smaller, maybe 50% of the original size

#

I don't have a banana for scale but I think you can sort of see it

#

    private void doParticleTrail(Particle particle) {
        bukkitTasks.add(new BukkitRunnable() {
            @Override
            public void run() {
                //In case of boss death or chunk unload, stop the effect
                if (!livingEntity.isValid()) {
                    cancel();
                    return;
                }
                //All conditions cleared, do the boss flair effect
                Location entityCenter = livingEntity.getLocation().clone().add(0, livingEntity.getHeight() / 2, 0);
                livingEntity.getWorld().spawnParticle(particle, entityCenter, 1, 0.1, 0.1, 0.1, 0.05);
            }
        }.runTaskTimer(MetadataHandler.PLUGIN, 0, 1));
    }

that is the code I am using to spawn particles, I am decently sure none of the settings should affect scale and they certainly didn't in the previous version

#

it would be cool if there is a way to fix this as I was personally using barrier block's ability to fully take up a block in width to preview block locations / visualizing specific locations in air without actually putting anything on there

#

should I report this as an issue or is it possibly intended 1.18 behavior

worldly ingot Nov 23, 2021, 10:40 AM

#

If you explicitly pass the BlockData to the particle it may expand outwards

#

Block markers accept BlockData as a data argument (because you can show literally any block), I'd just imagine that barrier is the default one

torn shuttle Nov 23, 2021, 10:42 AM

#

hm

worldly ingot Nov 23, 2021, 10:42 AM

#

livingEntity.getWorld().spawnParticle(particle, entityCenter, 1, 0.1, 0.1, 0.1, 0.05, Material.BARRIER.createBlockData());
(and tbh, ideally that BlockData would be a constant you can refer to instead)

stoic osprey Nov 23, 2021, 10:43 AM

#

can anyone help me to setup the worldedit API for my plugin - I have no idea how

torn shuttle Nov 23, 2021, 10:47 AM

#

worldly ingot `livingEntity.getWorld().spawnParticle(particle, entityCenter, 1, 0.1, 0.1, 0.1,...

no dice

worldly ingot Nov 23, 2021, 10:47 AM

#

Worth a shot I suppose

#

They might increase the size for blocks

#

Not much to do there

torn shuttle Nov 23, 2021, 10:47 AM

#

could be

tardy delta Nov 23, 2021, 10:48 AM

#

https://worldedit.enginehub.org/en/latest/api/index.html

torn shuttle Nov 23, 2021, 10:48 AM

#

why minify it at all, I will be among the few who will ever even see that they are tiny when spawned manually

#

oh well

#

so out of curiosity is the non-sim distance as simple as setting mobs to have a noAI tag?

mint fern Nov 23, 2021, 10:49 AM

#

I'm having a hard time manipulating BookMeta right now. Does anyone have a good resource on it so I can fully understand how it works?

wispy plume Nov 23, 2021, 10:54 AM

#

Is it possible to make silent lava?

ember estuary Nov 23, 2021, 10:54 AM

#

maybe theres a sound event which you can cancel?

#

so theres Player#stopSound, but i think it only stops already playing sounds. running it every tick doesnt seem like a good option. lemme search for something better

#

probably gotta use a packet listener, i dont think spigot has any SoundEvent implemented

#

but would be a great addition @admins

#

Question:
Do maps support RGB values?
I could only find MapCanvas#setPixel(int x, int y, byte color), but what the heck is the byte for? what combination of 1s and 0s is what color?

torn shuttle Nov 23, 2021, 11:06 AM

#

oof yikes this 1.18-pre-5 fps isn't feeling so hot

#

20 view distance tanks my fps down to 20 even when not moving and I have a beast of a pc

#

an i7 9700k and a rtx 3090

#

this is the one thing that minecraft has consistently failed to do and it breaks my heart every single time, I don't think we'll ever actually be able to see really far into the distance in this game

ember estuary Nov 23, 2021, 11:18 AM

#

Is it bad or good practise to make your plugins main class a singleton?

public class MyPlugin extends JavaPlugin {
    public static MyPlugin instance;

    @Override
    public void onEnable() {
        instance = this;
    }
}

ivory sleet Nov 23, 2021, 11:20 AM

#

That’s not a singleton

ember estuary Nov 23, 2021, 11:20 AM

#

its not?

#

MyPlugin.instance. ....
there will only ever be one

ivory sleet Nov 23, 2021, 11:21 AM

#

A singleton design pattern where you have a function which returns one instance

ember estuary Nov 23, 2021, 11:21 AM

#

well then add a .getInstance()

ivory sleet Nov 23, 2021, 11:21 AM

#

Your static field is public and non final thus its mutable

torn shuttle Nov 23, 2021, 11:21 AM

#

worldly ingot They might increase the size for blocks

ah you know what, I figured it out; it used to show the particle effect for the barrier block, but now it's showing the particle effect for the dropped item instead

ivory sleet Nov 23, 2021, 11:21 AM

#

So it breaks the pattern since you allow it to be mutated

torn shuttle Nov 23, 2021, 11:21 AM

#

these are likely two different particles

ember estuary Nov 23, 2021, 11:21 AM

#

but i wont, so effectively its a singleton

ivory sleet Nov 23, 2021, 11:22 AM

#

No its not lol

ember estuary Nov 23, 2021, 11:22 AM

#

its just that i didnt implement it right

#

whats the difference if mutable or not, if im not gonna mutate it

torn shuttle Nov 23, 2021, 11:22 AM

#

the ability to mutate it

ember estuary Nov 23, 2021, 11:22 AM

#

but that doesnt change anything if i dont use that ability

#

i dont really see a point in making it unmutable, if i know its supposed to be unmutable

ivory sleet Nov 23, 2021, 11:23 AM

#

It’s not a singleton then

fallow hearth Nov 23, 2021, 11:23 AM

#

Yeah you are right but they are too, just create a static get-method to be safe

ember estuary Nov 23, 2021, 11:23 AM

#

alright, will do that then, even tho i dont get the point

#

just good practise i guess

torn shuttle Nov 23, 2021, 11:24 AM

#

it's not a crime to make it unmutable, you were the one showing up here saying you made it unmutable in the first place

#

or a singleton to be more exact

fallow hearth Nov 23, 2021, 11:24 AM

#

Think about it this way: If you do not develop the project for 2 years and come back to it you might not remeber that part. Thats why you want to keep yourself from using it wrong

ivory sleet Nov 23, 2021, 11:24 AM

#

Anyways Bukkit actually provides a way to retrieve the plugin instance JavaPlugin::getPlugin

#

Also it’s called immutable not unmutable lol

ember estuary Nov 23, 2021, 11:24 AM

#

sorry, im not english xD

torn shuttle Nov 23, 2021, 11:25 AM

#

yeah that didn't sound right, it's time for me to go to bed

ivory sleet Nov 23, 2021, 11:25 AM

#

No worries was just picking on your words

ember estuary Nov 23, 2021, 11:25 AM

#

:D

torn shuttle Nov 23, 2021, 11:25 AM

#

I was just getting disappointed at 1.18 before going to bed

#

18 fps man

#

it hurts

ivory sleet Nov 23, 2021, 11:25 AM

#

Oof

ember estuary Nov 23, 2021, 11:25 AM

#

sad xD

torn shuttle Nov 23, 2021, 11:25 AM

#

I can't even tell what's capping

#

46% cpu use, 35% gpu

#

but it is going between 8-20 fps on idle

ember estuary Nov 23, 2021, 11:25 AM

#

Wait, so i dont have to make a singleton, so instead of
MyPlugin.getInstance()
I can just use
MyPlugin.getPlugin()
?

torn shuttle Nov 23, 2021, 11:26 AM

#

I wonder if it's single-threaded performance

ivory sleet Nov 23, 2021, 11:26 AM

#

ember estuary Wait, so i dont have to make a singleton, so instead of `MyPlugin.getInstance()...

In principle MyPlugin.getPlugin(MyPlugin.class) iirc

ember estuary Nov 23, 2021, 11:26 AM

#

thats too long for me, gonna use singleton

#

x'D

ivory sleet Nov 23, 2021, 11:26 AM

#

shrug

fallow hearth Nov 23, 2021, 11:26 AM

#

torn shuttle I wonder if it's single-threaded performance

With 20 vd and 20 simdist i have 60 fps when its loaded on 3080 & 5950x

ivory sleet Nov 23, 2021, 11:26 AM

#

Anyways I avoid singletons since it makes unit tests a pain

torn shuttle Nov 23, 2021, 11:27 AM

#

I'm at current cap 32 vd and 10 sim

#

funny thing is

#

I get the same framerate at 20 that I get on 32

ember estuary Nov 23, 2021, 11:27 AM

#

you unit test your plugins? :o
Sounds like a good idea, but a lot of work

quaint mantle Nov 23, 2021, 11:27 AM

#

torn shuttle I wonder if it's single-threaded performance

check core cpu usage then?

fallow hearth Nov 23, 2021, 11:27 AM

#

Resolution?

torn shuttle Nov 23, 2021, 11:27 AM

#

4k

fallow hearth Nov 23, 2021, 11:27 AM

#

LUL

ivory sleet Nov 23, 2021, 11:27 AM

#

ember estuary you unit test your plugins? :o Sounds like a good idea, but a lot of work

Yeah it is a bit of work in the start, but very addicting nonetheless lol

ember estuary Nov 23, 2021, 11:28 AM

#

but you cant really test ingame stuff, can u?

fallow hearth Nov 23, 2021, 11:28 AM

#

with vd 32, sm 10, 4k i have 30 fps

ember estuary Nov 23, 2021, 11:28 AM

#

with a website you can test if it looks how it should - but with minecraft you probably cant

ivory sleet Nov 23, 2021, 11:28 AM

#

Yes you can

ember estuary Nov 23, 2021, 11:28 AM

#

how

#

any framework?

ivory sleet Nov 23, 2021, 11:28 AM

#

You can use MockBukkit and emulate certain events and actions

Yes it’s a bit inconvenient but it works

fallow hearth Nov 23, 2021, 11:28 AM

#

Oops sorry vsync was on by default, 57

ember estuary Nov 23, 2021, 11:28 AM

#

Oh wow, very useful, thank you

ivory sleet Nov 23, 2021, 11:29 AM

#

Yeah no worries 🍉

torn shuttle Nov 23, 2021, 11:29 AM

#

this sucks

ember estuary Nov 23, 2021, 11:29 AM

#

If you dont use Singleton, which is like the only way i've seen plugins made, how does your main class usually look like?

torn shuttle Nov 23, 2021, 11:29 AM

#

well it's always good to get a little disappointment before going to bed

fallow hearth Nov 23, 2021, 11:29 AM

#

@ember estuary Just make sure you dont expose a map from a singleton or something similar. That typically ends in bad design

ember estuary Nov 23, 2021, 11:29 AM

#

wym with map

ivory sleet Nov 23, 2021, 11:30 AM

#

torn shuttle well it's always good to get a little disappointment before going to bed

Maybe, it will work better with something like optifine or sodium once those are out

ember estuary Nov 23, 2021, 11:30 AM

#

you mean Objects in general? pass by reference n stuff?

fallow hearth Nov 23, 2021, 11:30 AM

#

For example Map<UUID, UserSettings> do not give out a reference to something like that

ember estuary Nov 23, 2021, 11:30 AM

#

ok yeah

ivory sleet Nov 23, 2021, 11:30 AM

#

It’s probably smart to use proper encapsulation and abstraction

fallow hearth Nov 23, 2021, 11:30 AM

#

A lot of devs start with stuff like Map<UUID,Player> resulting in a clusterfuck of a plugin

ivory sleet Nov 23, 2021, 11:31 AM

#

Yeah makes the plugin very implementation dependent

torn shuttle Nov 23, 2021, 11:31 AM

#

oh wow I'm getting huge fps dips even at 10 view distance

#

even at 8 I get big spikes, is this even playable for other people?

ivory sleet Nov 23, 2021, 11:32 AM

#

I will give it a try once I get home

torn shuttle Nov 23, 2021, 11:32 AM

#

I am running it through spigot on localhost

fallow hearth Nov 23, 2021, 11:32 AM

#

torn shuttle an i7 9700k and a rtx 3090

Must be the cpu i think

torn shuttle Nov 23, 2021, 11:33 AM

#

I do get cpu spikes when just walking around

#

but they're insanely high

#

oh actually could be the server messing up

ivory sleet Nov 23, 2021, 11:33 AM

#

ember estuary If you dont use Singleton, which is like the only way i've seen plugins made, ho...

I can send a link

fallow hearth Nov 23, 2021, 11:33 AM

#

Maybe check CPU-Temps, might not be correctly setup?

ivory sleet Nov 23, 2021, 11:33 AM

#

Altho this never got finished

ember estuary Nov 23, 2021, 11:33 AM

#

alright, sure

#

cuz im having trouble understanding how you'd do it xD

ivory sleet Nov 23, 2021, 11:34 AM

#

https://github.com/Conclure/cityrp-core/blob/master/paper/src/main/java/me/conclure/cityrp/paper/PaperEntrypoint.java

torn shuttle Nov 23, 2021, 11:35 AM

#

ok yeah the dips was the server loading enough blocks for my 32 view distance

#

though I still don't hit fps cap on idle at 15 vd which is not a good sign for performance

#

I feel like this update is going to leave a lot of people in the dust

ember estuary Nov 23, 2021, 11:37 AM

#

thanks Conclure

#

thats a loooong constructor xD

fallow hearth Nov 23, 2021, 11:37 AM

#

Compare with SP. On VD 15 i get 250 fps... With 9700k you should get at least like 150 @ idle

ember estuary Nov 23, 2021, 11:37 AM

#

but it makes sense, yeah

ivory sleet Nov 23, 2021, 11:37 AM

#

Yuh

#

Could maybe have a builder there

#

Though I have disbanded that shit lol

torn shuttle Nov 23, 2021, 11:38 AM

#

I'll compare with SP but I feel like SP performance tends to not match server client performance

ember estuary Nov 23, 2021, 11:39 AM

#

wym with builder

ivory sleet Nov 23, 2021, 11:39 AM

#

Google builder design pattern (:

ember estuary Nov 23, 2021, 11:39 AM

#

ah, i think i had that in university

#

also had factory and stuff like that

#

but i dont remember a single thing haha

ivory sleet Nov 23, 2021, 11:41 AM

#

Yeah

torn shuttle Nov 23, 2021, 11:41 AM

#

bdp is fine but it gets to be a massive chore a lot of the time

#

singleplayer idling at max view range I actually get exactly the same fps, 20

ember estuary Nov 23, 2021, 11:42 AM

#

In MapCanvas#setPixel(int x, int y, byte color), what is the byte for? what combination of 1s and 0s is what color?

torn shuttle Nov 23, 2021, 11:42 AM

#

idling at 15 I get lower fps than in the server

#

significantly so too

#

about half

ivory sleet Nov 23, 2021, 11:45 AM

#

ember estuary In MapCanvas#setPixel(int x, int y, byte color), what is the byte for? what comb...

Actually no clue, but did you check out MapPalette

#

MapPalette.matchColor is probably what you want to use

ember estuary Nov 23, 2021, 11:47 AM

#

deprecated :c

#

i wonder whats the alternative

#

ill just use that for now tho

#

why would they deprecate useful methods like that, there has to be an alternative

ivory sleet Nov 23, 2021, 11:48 AM

#

Magic values

#

Which basically means ambiguous api

ember estuary Nov 23, 2021, 11:53 AM

#

When you try to make a Github Account, use your super strong password that you use everywhere else too, and github just says "Password is in a list of passwords commonly used on other websites"
Bruh :c xD

last ledge Nov 23, 2021, 11:53 AM

#

md_5

ivory sleet Nov 23, 2021, 11:53 AM

#

banana

last ledge Nov 23, 2021, 11:53 AM

#

my github account

#

https://guthib.com/

ember estuary Nov 23, 2021, 11:54 AM

#

lol, thats cool

ivory sleet Nov 23, 2021, 11:54 AM

#

Your GitHub account is a link?

last ledge Nov 23, 2021, 11:54 AM

#

ye lmao

#

see it

ember estuary Nov 23, 2021, 11:54 AM

#

click the link

#

xD

last ledge Nov 23, 2021, 11:54 AM

#

xD

ivory sleet Nov 23, 2021, 11:54 AM

#

Hmm, I’d rather not

last ledge Nov 23, 2021, 11:54 AM

#

I bought the domain, just for that purpose

ember estuary Nov 23, 2021, 11:54 AM

#

:D

#

i dont care if he has my ip, can just restart the router

last ledge Nov 23, 2021, 11:54 AM

#

its not a ip grabber

ember estuary Nov 23, 2021, 11:55 AM

#

and i dont think he owns the url, or do u

#

well, everything can be

#

xD

last ledge Nov 23, 2021, 11:55 AM

#

ye I do

ember estuary Nov 23, 2021, 11:55 AM

#

you can see which ips connected to your server, so technically it could be

last ledge Nov 23, 2021, 11:55 AM

#

but did u see the homepage right

#

its a joke