#help-development | SpigotMC | Page 1409

quaint mantle Apr 30, 2021, 1:01 PM

#

no

#

I must become a dev

glossy scroll Apr 30, 2021, 1:01 PM

#

Capitalize soldier.java

#

Maybe that will fix your issue

wraith rapids Apr 30, 2021, 1:02 PM

#

inb4 SOLDIER.JAVA

glossy scroll Apr 30, 2021, 1:02 PM

#

LMFAO

hybrid spoke Apr 30, 2021, 1:02 PM

#

its unnecressary anyways

quaint mantle Apr 30, 2021, 1:02 PM

#

@glossy scroll

novel hornet Apr 30, 2021, 1:02 PM

#

when i run a command on my server nothing happends what could cause this to happen

glossy scroll Apr 30, 2021, 1:02 PM

#

hybrid spoke its unnecressary anyways

Idk how eclispse works but its always nice to have javadocs in ide

hybrid spoke Apr 30, 2021, 1:02 PM

#

glossy scroll Idk how eclispse works but its always nice to have javadocs in ide

just use maven

wraith rapids Apr 30, 2021, 1:02 PM

#

what plugin provides this command

glossy scroll Apr 30, 2021, 1:02 PM

#

quaint mantle <@!178795078750306304>

Perfect

unkempt ore Apr 30, 2021, 1:02 PM

#

novel hornet when i run a command on my server nothing happends what could cause this to happ...

You have no idea how little that narrows it down

quaint mantle Apr 30, 2021, 1:02 PM

#

glossy scroll Perfect

now what?

glossy scroll Apr 30, 2021, 1:03 PM

#

Idk

hybrid spoke Apr 30, 2021, 1:03 PM

#

oh i understood wrong

wraith rapids Apr 30, 2021, 1:03 PM

#

now we sit down

hybrid spoke Apr 30, 2021, 1:03 PM

#

i am reading the javadocs in the classes directly

wraith rapids Apr 30, 2021, 1:03 PM

#

and start to contemplate the futility of human existence

rigid hazel Apr 30, 2021, 1:03 PM

#

I'm using java player.openBook(book); and for a second or something the book is popping up with the text and closes. Why this intervall so short?

wraith rapids Apr 30, 2021, 1:03 PM

#

something could be calling player.closeInventory or something

hybrid spoke Apr 30, 2021, 1:03 PM

#

hybrid spoke i am reading the javadocs in the classes directly

and with maven you can just hover over your object and get the javadoc comment

quaint mantle Apr 30, 2021, 1:03 PM

#

@hybrid spoke

rigid hazel Apr 30, 2021, 1:03 PM

#

wraith rapids something could be calling player.closeInventory or something

Okay.

glossy scroll Apr 30, 2021, 1:04 PM

#

hybrid spoke and with maven you can just hover over your object and get the javadoc comment

I like to look at src code and see javadocs above i

wispy monolith Apr 30, 2021, 1:04 PM

#

Should I use bukkit ChatColor or bungee ChatcColor?

quaint mantle Apr 30, 2021, 1:04 PM

#

@glossy scroll how do I use maven?

wraith rapids Apr 30, 2021, 1:04 PM

#

depends

#

bungee supports rgb

glossy scroll Apr 30, 2021, 1:04 PM

#

@wraith rapids he wants to use maven

#

Wheres the guide

rigid hazel Apr 30, 2021, 1:04 PM

#

rigid hazel I'm using ```java player.openBook(book);``` and for a second or something the bo...

I'm using it in the inventoryclikevent

#

Can this produce the error?

wraith rapids Apr 30, 2021, 1:04 PM

#

i don't have the eclipse maven tutorial at hand

#

uh

glossy scroll Apr 30, 2021, 1:05 PM

#

google

unkempt ore Apr 30, 2021, 1:05 PM

#

Quick question, I’m making a custom item, just an item with some special meta, and I want to check if another ItemStack matches it. What is the most reliable way to? Testing the metas’ .equals() doesn’t sound right because, say, a player could change the item’s display name in an anvil and it wouldn’t match. Not sure what to do. I wish I could do something like give it a custom Material type

hybrid spoke Apr 30, 2021, 1:05 PM

#

rigid hazel I'm using it in the inventoryclikevent

what if you delay the opening?

#

by 1 tick or smth

wispy monolith Apr 30, 2021, 1:05 PM

#

wraith rapids bungee supports rgb

I want to use like in this way as an example ChatColor.RED

glossy scroll Apr 30, 2021, 1:05 PM

#

unkempt ore Quick question, I’m making a custom item, just an item with some special meta, a...

isSimilar

rigid hazel Apr 30, 2021, 1:05 PM

#

hybrid spoke what if you delay the opening?

What will happen?

unkempt ore Apr 30, 2021, 1:05 PM

#

Alright, I’ll look into that

hybrid spoke Apr 30, 2021, 1:05 PM

#

rigid hazel What will happen?

it delays the opening by 1 tick 🤔

wraith rapids Apr 30, 2021, 1:05 PM

#

that one guy linked it recently but I don't have it in my browser history for some reason

novel hornet Apr 30, 2021, 1:05 PM

#

unkempt ore You have no idea how little that narrows it down

could i provided a latest.log to narrow it down

rigid hazel Apr 30, 2021, 1:05 PM

#

wraith rapids that one guy linked it recently but I don't have it in my browser history for so...

Sorry. Stupid question

quaint mantle Apr 30, 2021, 1:06 PM

#

@wraith rapids what should I do?

wraith rapids Apr 30, 2021, 1:06 PM

#

@unkempt ore use persistent data container

#

equals is the same as issimilar, it just ignores stack size

glossy scroll Apr 30, 2021, 1:06 PM

#

unkempt ore Alright, I’ll look into that

Nvm i misread

wispy monolith Apr 30, 2021, 1:06 PM

#

Right, Where I put plugin.yml?

wraith rapids Apr 30, 2021, 1:06 PM

#

write a tag in the PDC in the item's meta and use that for comparison

#

in the resources directory

glossy scroll Apr 30, 2021, 1:06 PM

#

Use persistent data container like NNYajcjsojfkeke said

wraith rapids Apr 30, 2021, 1:06 PM

#

with your config.yml

wispy monolith Apr 30, 2021, 1:06 PM

#

wraith rapids with your config.yml

ok

wraith rapids Apr 30, 2021, 1:07 PM

#

https://bukkit.fandom.com/wiki/Plugin_Tutorial_(Eclipse)
@quaint mantle

quaint mantle Apr 30, 2021, 1:08 PM

#

wraith rapids https://bukkit.fandom.com/wiki/Plugin_Tutorial_(Eclipse) <@456226577798135808>

arigatou

eternal oxide Apr 30, 2021, 1:08 PM

#

quaint mantle <@!599731521922007066> what should I do?

Eclipse tutorial using maven https://bukkit.fandom.com/wiki/Plugin_Tutorial_(Eclipse)

wraith rapids Apr 30, 2021, 1:09 PM

#

i can't find any properly navigable trie impls either

#

i guess my level of expectations for "navigable" is just too high

wispy monolith Apr 30, 2021, 1:10 PM

#

thx

#

everything work now

wraith rapids Apr 30, 2021, 1:10 PM

#

and this is why you should always use a dependency manager

#

your dependency might depend on other dependencies which might depend on yet other dependencies

#

a dependency manager will just grab and import them all

unkempt ore Apr 30, 2021, 1:11 PM

#

wraith rapids <@358822645225095170> use persistent data container

And give it an ID of sorts?

#

Yeah, sounds perfect

limpid veldt Apr 30, 2021, 1:13 PM

#

in the plugin.yml is there a way to put variables such as this in other areas such as permissions or smtn?

eternal oxide Apr 30, 2021, 1:14 PM

#

yes

wraith rapids Apr 30, 2021, 1:14 PM

#

anything that you have declared as a filtered resource can use them

eternal oxide Apr 30, 2021, 1:14 PM

#

            <resource>
                <directory>resources</directory>
                <filtering>true</filtering>```

#

or wherever yoru resources are

wraith rapids Apr 30, 2021, 1:15 PM

#

speaking of

#

how do you people infer the main package of the plugin to use in these vars

limpid veldt Apr 30, 2021, 1:15 PM

#

like if I want a variable for the permissions, id just stick that in the pom or something along those lines right?

wraith rapids Apr 30, 2021, 1:15 PM

#

i just have a project property for it but it feels kind of crummy

eternal oxide Apr 30, 2021, 1:16 PM

#

This is my generic plugin.yml ```yaml
name: ${project.artifactId}
main: ${project.groupId}.${project.artifactId}
version: ${project.version}
api-version: ${project.bukkitAPIVersion}

author: ElgarL
website: ${project.url}```

limpid veldt Apr 30, 2021, 1:16 PM

#

thats actually pretty smart

#

ultimate boilerplate

quaint mantle Apr 30, 2021, 1:18 PM

#

eternal oxide Apr 30, 2021, 1:18 PM

#

You can;t do that

quaint mantle Apr 30, 2021, 1:18 PM

#

sudden raft Apr 30, 2021, 1:19 PM

#

mmm

quaint mantle Apr 30, 2021, 1:19 PM

#

Yushu ❤️

eternal oxide Apr 30, 2021, 1:19 PM

#

It measn replace with your Artifact name

sudden raft Apr 30, 2021, 1:19 PM

#

You must replace it by your group id and your artifact name

quaint mantle Apr 30, 2021, 1:20 PM

#

#

Like this?

eternal oxide Apr 30, 2021, 1:20 PM

#

no

#

your outer class should extend JavaPlugin

quaint mantle Apr 30, 2021, 1:21 PM

#

oof I'm stupid

#

I don't know what to do

eternal oxide Apr 30, 2021, 1:21 PM

#

keep trying. You know the saying about moneys and a typewriter.

wraith rapids Apr 30, 2021, 1:21 PM

#

doesn't that involve using a different group id for each plugin, though

eternal oxide Apr 30, 2021, 1:22 PM

#

wraith rapids doesn't that involve using a different group id for each plugin, though

Mine? no

novel hornet Apr 30, 2021, 1:23 PM

#

when i run a command on my server nothing happens what could cause this to happen should i provide latest.log

wraith rapids Apr 30, 2021, 1:23 PM

#

main: includes the class name

eternal oxide Apr 30, 2021, 1:23 PM

#

yep

#

${project.groupId}.${project.artifactId}

wraith rapids Apr 30, 2021, 1:23 PM

#

the last element of your main is the artifact id

#

which would make your artifact id the class name

eternal oxide Apr 30, 2021, 1:23 PM

#

yes

wraith rapids Apr 30, 2021, 1:23 PM

#

but what about your main package?

#

that should differ between plugins

eternal oxide Apr 30, 2021, 1:23 PM

#

class = project name

wraith rapids Apr 30, 2021, 1:24 PM

#

which it can't unless you specify a different group id for each plugin

eternal oxide Apr 30, 2021, 1:24 PM

#

artifactId would be GroupManager

#

groupId would be the package

wraith rapids Apr 30, 2021, 1:25 PM

#

give an example for groupId

eternal oxide Apr 30, 2021, 1:25 PM

#

    <groupId>com.palmergames.spigot.homestead</groupId>
    <artifactId>Homestead</artifactId>```

wraith rapids Apr 30, 2021, 1:25 PM

#

so you do change the group id for each plugin

eternal oxide Apr 30, 2021, 1:25 PM

#

I don;t have to

wraith rapids Apr 30, 2021, 1:26 PM

#

well I don't "have" to have a plugin package either

#

i can just have my classes directly under main

#

but I should have an unique package for each plugin

#

which means that you should change your group id for each plugin

eternal oxide Apr 30, 2021, 1:27 PM

#

I guess I could include the lower case ArtifactId on the GroupId which would make it fully dynamic

wraith rapids Apr 30, 2021, 1:27 PM

#

lowercase artifactId is what I do

#

or, would do, if I knew how to make things lowercase

eternal oxide Apr 30, 2021, 1:27 PM

#

🙂

wraith rapids Apr 30, 2021, 1:27 PM

#

do you know how to make things lowercase?

quaint mantle Apr 30, 2021, 1:28 PM

#

What should I do?

chrome beacon Apr 30, 2021, 1:29 PM

#

You should look in to basic Java before making your first plugin

eternal oxide Apr 30, 2021, 1:29 PM

#

wraith rapids do you know how to make things lowercase?

you shoudl be able to use ${artifactId.toLowerCase()}

wraith rapids Apr 30, 2021, 1:29 PM

#

remarkable

quaint mantle Apr 30, 2021, 1:30 PM

#

chrome beacon You should look in to basic Java before making your first plugin

how basic?

#

Is my code not alright?

wraith rapids Apr 30, 2021, 1:31 PM

#

well i mean

#

you have an empty class

#

but it's no longer on fire and all red and exploding

#

so that's progress

eternal oxide Apr 30, 2021, 1:32 PM

#

seems not

wraith rapids Apr 30, 2021, 1:33 PM

#

there's like a maven plugin that can do it I think

#

but I've never bothered to set it up

quaint mantle Apr 30, 2021, 1:37 PM

#

Can someone tell my, why this doesn't work?

        if(e.getView().getTitle().equalsIgnoreCase(WINDOW.MAIN_NAME)) {
            if(e.getCurrentItem().getItemMeta().getDisplayName().equalsIgnoreCase("§c✘")) {
                e.setCancelled(true);
            }
        }

#

it doesn't cancel

chrome beacon Apr 30, 2021, 1:38 PM

#

Looks fine

glossy scroll Apr 30, 2021, 1:38 PM

#

Oof thats not a good way to test items

chrome beacon Apr 30, 2021, 1:38 PM

#

^^

quaint mantle Apr 30, 2021, 1:38 PM

#

glossy scroll Oof thats not a good way to test items

what's better then?

glossy scroll Apr 30, 2021, 1:38 PM

#

If you have an instance of that itemstack anywhere, use that and call itemStack#isSimilar

quaint mantle Apr 30, 2021, 1:39 PM

#

ok

#

        ItemStack GLASS = new ItemStack(Material.GRAY_STAINED_GLASS_PANE);
        ItemMeta GLASS_META = GLASS.getItemMeta();
        GLASS_META.setDisplayName("§c✘");
        GLASS.setItemMeta(GLASS_META);
        
        if(e.getView().getTitle().equalsIgnoreCase(WINDOW.MAIN_NAME)) {
            if(e.getCurrentItem().isSimilar(GLASS)) {
                e.setCancelled(true);
            }
        }

still not working

sour rampart Apr 30, 2021, 1:42 PM

#

Is it possible to access the config in a static? Here's my code: https://paste.md-5.net/iyofuligob.cpp
Error: Cannot make a static reference to the non-static method getConfig() from the type JavaPlugin

glossy scroll Apr 30, 2021, 1:42 PM

#

quaint mantle ```java ItemStack GLASS = new ItemStack(Material.GRAY_STAINED_GLASS_PANE...

Wheres the item you use to put in the inventory

#

Use that item

quaint mantle Apr 30, 2021, 1:43 PM

#

that's the same item

#

but just in another class

obtuse basin Apr 30, 2021, 1:43 PM

#

Sooo, Following Situation: I want to add an Membersystem for my worldmanagement plugin (each player it's own world), but have no Idea how to save and remove the members of the world, I already tried with a config in the world but it not really helped, any ideas? the code I tried to use for that: ```
fun addmember(world: String, uuid: String): Void? {
val ccfg: File = File("world//" + world + "//world.yml")
val cfg: YamlConfiguration = YamlConfiguration.loadConfiguration(ccfg)
cfg.set("- ", uuid)
try {
cfg.save(ccfg)
} catch (e: IOException) {
e.printStackTrace()
}
return null
}

fun delmember(world: String): Void? {
    val ccfg: File = File("world//" + world + "//world.yml")
    val cfg: YamlConfiguration = YamlConfiguration.loadConfiguration(ccfg)
    cfg.set("- ", null)
    try {
        cfg.save(ccfg)
    } catch (e: IOException) {
        e.printStackTrace()
    }
    return null
}```

glossy scroll Apr 30, 2021, 1:43 PM

#

Ok well then thats fine

#

Your next problem is coaring inventory names

quaint mantle Apr 30, 2021, 1:43 PM

#

glossy scroll Ok well then thats fine

but if I click on that item, I can still get it

#

so it doesn't cancel

glossy scroll Apr 30, 2021, 1:44 PM

#

I would probably call IntventoryView#getTopInventory

#

Im not sure what InventoryView.getTitle does

quaint mantle Apr 30, 2021, 1:44 PM

#

it get's the name

glossy scroll Apr 30, 2021, 1:45 PM

#

I dont think it does apparently

quaint mantle Apr 30, 2021, 1:45 PM

#

that's the only thing I found for 1.16.5

glossy scroll Apr 30, 2021, 1:46 PM

#

ugh i just wouldnt realy do it this way so im not sure whats wrong

quaint mantle Apr 30, 2021, 1:47 PM

#

but I have to do it in 1.16.5

glossy scroll Apr 30, 2021, 1:47 PM

#

@quaint mantle id just recommend debugging

quaint mantle Apr 30, 2021, 1:49 PM

#

        ItemStack GLASS = new ItemStack(Material.GRAY_STAINED_GLASS_PANE);
        ItemMeta GLASS_META = GLASS.getItemMeta();
        GLASS_META.setDisplayName("§c✘");
        GLASS.setItemMeta(GLASS_META);
        
        if(e.getCurrentItem().isSimilar(GLASS)) {
            e.setCancelled(true);
        }

#

this doesn't work either

#

and it doesn't spit any errors

glossy scroll Apr 30, 2021, 1:50 PM

#

Make sure you have eventhandler

#

And once again try debugging

quaint mantle Apr 30, 2021, 1:50 PM

#

omfg

#

I'm sooooooo dumb

ivory sleet Apr 30, 2021, 1:51 PM

#

Same frankly

glossy scroll Apr 30, 2021, 1:51 PM

#

quaint mantle I'm sooooooo dumb

Was it eventhandler?

quaint mantle Apr 30, 2021, 1:51 PM

#

yes

#

xd

bleak sapphire Apr 30, 2021, 1:51 PM

#

Hi everyone, I've been trying to code a plugin that allows an entity to follow me for a long time. With all the research I've done I still can't do it. Could someone help me?

obtuse basin Apr 30, 2021, 1:51 PM

#

obtuse basin Sooo, Following Situation: I want to add an Membersystem for my worldmanagement ...

any ideas what i could can do here instead?

glossy scroll Apr 30, 2021, 1:51 PM

#

LOL i used to make that mistake all the time

glossy scroll Apr 30, 2021, 1:52 PM

#

obtuse basin any ideas what i could can do here instead?

Save it as a list instead

ivory sleet Apr 30, 2021, 1:53 PM

#

obtuse basin Sooo, Following Situation: I want to add an Membersystem for my worldmanagement ...

Unit? Why nullable Void

#

Also uh I mean the type is inferred for val so Idk why write it out but that’s a preference Ig.

#

Also btw iirc kotlin has string interpolation

wispy monolith Apr 30, 2021, 1:54 PM

#

How to replace player inv?

obtuse basin Apr 30, 2021, 1:57 PM

#

glossy scroll Save it as a list instead

Do u mean Java Map or what do u mean?

ivory sleet Apr 30, 2021, 1:57 PM

#

List != Map

wraith rapids Apr 30, 2021, 1:57 PM

#

define "for a long time"

wispy monolith Apr 30, 2021, 1:57 PM

#

is this going to work?

Inventory player2inv = player2.getInventory();
player1.getInventory().clear();
player1.getInventory().addItem((ItemStack) player2inv);

wraith rapids Apr 30, 2021, 1:57 PM

#

from across the entire world?

#

for x hours?

wispy monolith Apr 30, 2021, 1:58 PM

#

wispy monolith is this going to work? ```java Inventory player2inv = player2.getInventory(); pl...

Pls help @wraith rapids

quaint mantle Apr 30, 2021, 2:00 PM

#

wispy monolith is this going to work? ```java Inventory player2inv = player2.getInventory(); pl...

no

#

you're casting an inventory to an item

wispy monolith Apr 30, 2021, 2:01 PM

#

So how to do it?

glossy scroll Apr 30, 2021, 2:02 PM

#

learn java idk

quaint mantle Apr 30, 2021, 2:02 PM

#

wispy monolith is this going to work? ```java Inventory player2inv = player2.getInventory(); pl...

Inventory player2Inv = player2.getInventory();
player1.getInventory().setContents(player2.getContents());

#

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/Inventory.html#setContents(org.bukkit.inventory.ItemStack[])

Inventory (Spigot-API 1.16.5-R0.1-SNAPSHOT API)

declaration: package: org.bukkit.inventory, interface: Inventory

glossy scroll Apr 30, 2021, 2:02 PM

#

learn to read jd too

#

player2Inv*

wispy monolith Apr 30, 2021, 2:03 PM

#

quaint mantle ```java Inventory player2Inv = player2.getInventory(); player1.getInventory().se...

thx

novel hornet Apr 30, 2021, 2:04 PM

#


import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;

public class Commandss implements CommandExecutor {
    
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        
        Player player = (Player) sender;
        player.getInventory().addItem(me.mrpiedot.PantsThatPoopTnt.items.items.TntPants);
        
        return true;
    }
} ```

quaint mantle Apr 30, 2021, 2:04 PM

#

no

novel hornet Apr 30, 2021, 2:04 PM

#

i have a error in line 14

wraith rapids Apr 30, 2021, 2:04 PM

#

check instanceof before cast

obtuse basin Apr 30, 2021, 2:05 PM

#

quaint mantle I'm sooooooo dumb

same, looking 5mins why it not works and then "oh, I haven't done X for it to work"

crude charm Apr 30, 2021, 2:06 PM

#

why did my plugin compile as a bunch of files not classes

#

it should look like this

ivory sleet Apr 30, 2021, 2:07 PM

#

Reload maven project

crude charm Apr 30, 2021, 2:07 PM

#

aight

novel hornet Apr 30, 2021, 2:08 PM

#


import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;

public class Commandss implements CommandExecutor {
    
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
        
        Player player = (Player) sender;
        player.getInventory().addItem(me.mrpiedot.PantsThatPoopTnt.items.items.TntPants);
        
        return true;
    }
} ``` I'm getting a error in line 14 whats causing this problem

crude charm Apr 30, 2021, 2:09 PM

#

ivory sleet Reload maven project

didnt fix it

ivory sleet Apr 30, 2021, 2:09 PM

#

Uh weird, restart and invalidate caches

crude charm Apr 30, 2021, 2:09 PM

#

I did

#

idk how to invalidate caches tho

ivory sleet Apr 30, 2021, 2:10 PM

#

File -> Invalidate Caches -> Restart and invalidate caches

#

iirc

crude charm Apr 30, 2021, 2:10 PM

#

ah ok

#

doing that rn

wraith rapids Apr 30, 2021, 2:10 PM

#

              <plugin>
                <groupId>org.codehaus.mojo</groupId>
                <artifactId>build-helper-maven-plugin</artifactId>
                <version>1.12</version>
                <executions>
                    <execution>
                        <id>compute-plugin-package</id>
                        <goals>
                            <goal>regex-property</goal>
                        </goals>
                        <configuration>
                            <name>plugin.package</name>
                            <regex>.*</regex>
                            <value>${project.artifactId}</value>
                            <replacement>$0</replacement>
                            <failIfNoMatch>false</failIfNoMatch>
                            <toLowerCase>true</toLowerCase>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

ended up with doing this

#

it seems to work

crude charm Apr 30, 2021, 2:11 PM

#

ivory sleet File -> Invalidate Caches -> Restart and invalidate caches

I think its gonna work its indexing

wraith rapids Apr 30, 2021, 2:11 PM

#

but is a bit excessive for just lowercasing a single fucking value

ivory sleet Apr 30, 2021, 2:11 PM

#

Ah nice zoi

crude charm Apr 30, 2021, 2:12 PM

#

didnt work

#

but im trying smth else rn

#

which will

#

and

#

it worked

#

🙂

#

the thing I needed to do was add it as a maven project

ivory sleet Apr 30, 2021, 2:13 PM

#

Pog

ocean warren Apr 30, 2021, 2:13 PM

#

wraith rapids ```xml <plugin> <groupId>org.codehaus.mojo</groupI...

gradle init 🤡

crude charm Apr 30, 2021, 2:13 PM

#

grandle is so shit

#

and ugly

#

idk how people use it

#

I tried it today

#

and rubish

#

hot 💩

ocean warren Apr 30, 2021, 2:14 PM

#

Pea brain yessir

unkempt ore Apr 30, 2021, 2:14 PM

#

Would it be a good idea to store an ItemMeta for when I want to create an item stack and just assign the meta right there with the stored data? I assume I should clone it, right?

wraith rapids Apr 30, 2021, 2:14 PM

#

if I were using gradle I could've done what I did there in like 1 line

#

gradle is definitely better in some ways

#

maven is pretty inflexible and archaic

#

all item metas are clones

ivory sleet Apr 30, 2021, 2:14 PM

#

True

crude charm Apr 30, 2021, 2:14 PM

#

mvn package 😋

wraith rapids Apr 30, 2021, 2:15 PM

#

every time you call getItemMeta, you clone the item's meta

crude charm Apr 30, 2021, 2:15 PM

#

mvn clean install

compact haven Apr 30, 2021, 2:15 PM

#

i literally hat eintellij rn

unkempt ore Apr 30, 2021, 2:15 PM

#

wraith rapids all item metas are clones

Good, so setItemMeta copies?

crude charm Apr 30, 2021, 2:15 PM

#

mvn package -s

#

mvn package -e

wraith rapids Apr 30, 2021, 2:15 PM

#

i'm not sure about set

#

but get does clone

crude charm Apr 30, 2021, 2:15 PM

#

wraith rapids i'm not sure about set

I meant -e

wraith rapids Apr 30, 2021, 2:15 PM

#

let me check I suppose

unkempt ore Apr 30, 2021, 2:15 PM

#

Thanks

crude charm Apr 30, 2021, 2:15 PM

#

-e shows more info on an error

ivory sleet Apr 30, 2021, 2:15 PM

#

Yeah, man IntelliJ has been screwing me recently like sheesh

unkempt ore Apr 30, 2021, 2:15 PM

#

Having more than one item refer to the same meta sounds like it could be catastrophic, so I'm expecting it does defensive copy

crude charm Apr 30, 2021, 2:15 PM

#

ivory sleet Yeah, man IntelliJ has been screwing me recently like sheesh

same

#

I had an issue with one of my plugins where it wouldn't want to compile my plugin.yml so I had to add it manually each time

wraith rapids Apr 30, 2021, 2:17 PM

#

it depends

crude charm Apr 30, 2021, 2:17 PM

#

works with every other plugin

crude charm Apr 30, 2021, 2:17 PM

#

wraith rapids it depends

ALSO

#

git clone

wraith rapids Apr 30, 2021, 2:17 PM

#

bukkit handles items in a pretty convoluted fashion

crude charm Apr 30, 2021, 2:17 PM

#

mvn clean install

ivory sleet Apr 30, 2021, 2:17 PM

#

Yeah, it couldn’t find the dependencies onetime so I had to yeet .m2 and reinstall BuildTools for different versions which was a painful process

crude charm Apr 30, 2021, 2:17 PM

#

boom

unkempt ore Apr 30, 2021, 2:17 PM

#

Hmmmmm

wraith rapids Apr 30, 2021, 2:17 PM

#

if you're setting the itemmeta of a craft item stack, it always clones

#

because craftstacks hold nms meta, not bukkit meta

#

all bukkit stacks are also converted to craft stacks and then nms stacks when you insert them in an inventory

#

which clones the meta into nms meta

#

so unless you are holding them as raw itemstacks in an array or something, it won't be an issue

unkempt ore Apr 30, 2021, 2:18 PM

#

Nice

wraith rapids Apr 30, 2021, 2:18 PM

#

itemstacks are fucking cancer because you can literally not do anything without tripping a million clones

#

a simple isSimilar clones the item meta of the associated items 2-4 times

#

and considering the meta size of shit like books and shulker boxes, that is a fucking shit fest

ivory sleet Apr 30, 2021, 2:19 PM

#

didnt know it cloned it so often

wraith rapids Apr 30, 2021, 2:19 PM

#

some plugins like slimefun that do a lot of issimilar comparisons and set items in inventories will literally make your server shit bricks

#

it doesn't help that they are using a fucking retarded "optimization" which actually just increases the number of meta clones per comparison by a factor of 4

crude charm Apr 30, 2021, 2:20 PM

#

?paste

queen dragonBOT Apr 30, 2021, 2:20 PM

#

https://paste.md-5.net/

unkempt ore Apr 30, 2021, 2:21 PM

#

wraith rapids it doesn't help that they are using a fucking retarded "optimization" which actu...

Lmao

wraith rapids Apr 30, 2021, 2:21 PM

#

i rewrote myself an itemstack impl that is more sane with the way it handles itemmeta and cloning and comparisons

#

i've been working on a live-view itemmeta on and off for a while

ivory sleet Apr 30, 2021, 2:21 PM

#

hmm so by convenience writing our own itemstack comparison methods might be a good optimization

wraith rapids Apr 30, 2021, 2:21 PM

#

yeah, but you will of course need nms for that

#

or reflection, i guess

crude charm Apr 30, 2021, 2:21 PM

#

wraith rapids some plugins like slimefun that do a lot of issimilar comparisons and set items ...

WTF

#

slime fun has changed SO much

wraith rapids Apr 30, 2021, 2:22 PM

#

it hasn't

#

it was shit

#

it's still shit

crude charm Apr 30, 2021, 2:22 PM

#

oh

wraith rapids Apr 30, 2021, 2:22 PM

#

the author was a tard

#

the author is still a tard

ivory sleet Apr 30, 2021, 2:22 PM

#

uh that sucks

crude charm Apr 30, 2021, 2:22 PM

#

im just looking at screenshots

wraith rapids Apr 30, 2021, 2:22 PM

#

there are just more items now

crude charm Apr 30, 2021, 2:22 PM

#

not code

wraith rapids Apr 30, 2021, 2:22 PM

#

that's the only difference

crude charm Apr 30, 2021, 2:22 PM

#

screenshots

#

not code

#

never seen the code

wraith rapids Apr 30, 2021, 2:22 PM

#

you don't want to, either

#

i'm currently in the slow process of rewriting slimefun from scratch

crude charm Apr 30, 2021, 2:23 PM

#

but whatever these pipy things are look cool

wraith rapids Apr 30, 2021, 2:23 PM

#

i have even decided on a name

crude charm Apr 30, 2021, 2:23 PM

#

idk what they doi

wraith rapids Apr 30, 2021, 2:23 PM

#

i shall call it shrekfun

crude charm Apr 30, 2021, 2:23 PM

#

or what the plugin is about

wraith rapids Apr 30, 2021, 2:23 PM

#

so I can keep the /sf shorthand

#

it will be ogre and onion themed

crude charm Apr 30, 2021, 2:23 PM

#

call it

#

slimefunissoshitsoimadethisinstead

#

error: https://paste.md-5.net/vilugifohu.md
code: https://paste.md-5.net/fatebevebe.java

wraith rapids Apr 30, 2021, 2:24 PM

#

i feel strangely accomplished now that i've managed to automagically lowercase my artifactId

#

how magical

ivory sleet Apr 30, 2021, 2:26 PM

#

lmao

vast quest Apr 30, 2021, 2:27 PM

#

can someone help me with making custom config files

crude charm Apr 30, 2021, 2:27 PM

#

its easy

vast quest Apr 30, 2021, 2:27 PM

#

I cant understand from the tutorial

crude charm Apr 30, 2021, 2:27 PM

#

its easy tho

wraith rapids Apr 30, 2021, 2:27 PM

#

new YamlConfiguration

vast quest Apr 30, 2021, 2:27 PM

#

I cant understand tho

wraith rapids Apr 30, 2021, 2:27 PM

#

config.save(file)

crude charm Apr 30, 2021, 2:27 PM

#

then understand

wraith rapids Apr 30, 2021, 2:28 PM

#

config.load(file)

vast quest Apr 30, 2021, 2:28 PM

#

do I put those on load?

crude charm Apr 30, 2021, 2:28 PM

#

yes

wraith rapids Apr 30, 2021, 2:28 PM

#

you put them where you need them

#

load the config when you need to load it

#

save it when you need to save it

vast quest Apr 30, 2021, 2:28 PM

#

how to reload it

crude charm Apr 30, 2021, 2:28 PM

#

delete it when you need to delete it

#

#reload

vast quest Apr 30, 2021, 2:29 PM

#

can I have multiple?

wraith rapids Apr 30, 2021, 2:29 PM

#

reload is just re-loading it; calling load again

crude charm Apr 30, 2021, 2:29 PM

#

yes

wraith rapids Apr 30, 2021, 2:29 PM

#

keep in mind that .save nukes all comments

#

because nobody has bothered to update bukkit to use the new snakeyaml versions that don't explode with comments

minor garnet Apr 30, 2021, 2:30 PM

#

    public static List<Loot> loadAll(){
        List<Loot> loots = new ArrayList<Loot>();
        try {
            String query = "SELECT * FROM loot";
            ResultSet rs = stmt.executeQuery(query);
            while(rs.next()) {
                Loot loot = new Loot(rs.getString(1), Utils.itemStackFromBase64(rs.getString(2)),
                                        rs.getInt(3), Utils.deserializeLocation(rs.getString(4)));
                loots.add(loot);
            }
        } catch(SQLException e) {
            
        }
        return loots;
    }```

wraith rapids Apr 30, 2021, 2:30 PM

#

because it is a law of nature that literally everything in bukkit must stagnate and be at least 5 years out of date

#

because otherwise, what would happen to those poor, poor plugins written for 1.8 that nobody fucking uses anymore

minor garnet Apr 30, 2021, 2:30 PM

#

📎 message.txt

#

why i getting null by array list ?

wraith rapids Apr 30, 2021, 2:31 PM

#

what is line 48

minor garnet Apr 30, 2021, 2:31 PM

#

well its other method because spaces,

wraith rapids Apr 30, 2021, 2:31 PM

#

???

minor garnet Apr 30, 2021, 2:32 PM

#

but i think is this List<Loot> loots = new ArrayList<Loot>();

wraith rapids Apr 30, 2021, 2:32 PM

#

that can not throw a npe

#

GroundLoot class, line 48

minor garnet Apr 30, 2021, 2:32 PM

#

sorry i mistake

#

is thios

wraith rapids Apr 30, 2021, 2:32 PM

#

something is null

crude charm Apr 30, 2021, 2:32 PM

#

WTF is that red terminal

minor garnet Apr 30, 2021, 2:32 PM

#

red terminal ?

crude charm Apr 30, 2021, 2:32 PM

#

that is so ugly how do you see

unkempt ore Apr 30, 2021, 2:32 PM

#

It hurts

wraith rapids Apr 30, 2021, 2:33 PM

#

let me show you some red

crude charm Apr 30, 2021, 2:33 PM

#

oops

#

ignore that

minor garnet Apr 30, 2021, 2:33 PM

#

?

wraith rapids Apr 30, 2021, 2:33 PM

#

https://cdn.discordapp.com/attachments/324667367860862977/837670507481661440/image.png

crude charm Apr 30, 2021, 2:33 PM

#

minor garnet Apr 30, 2021, 2:33 PM

#

yes ?

crude charm Apr 30, 2021, 2:33 PM

#

its ugly

#

I cant read it

minor garnet Apr 30, 2021, 2:33 PM

#

because of it

#

i send a text message

vast quest Apr 30, 2021, 2:33 PM

#

what does this mean saveResource("name of file in jar here", replaceIfAlreadyExists). and where am I suppose to put it

crude charm Apr 30, 2021, 2:33 PM

#

this is alot easier to read

wraith rapids Apr 30, 2021, 2:33 PM

#

https://cdn.discordapp.com/attachments/324667367860862977/787428656708321290/image.png

crude charm Apr 30, 2021, 2:34 PM

#

LMFAO

#

VIRTUAL BOY

#

HAHAHAHA

minor garnet Apr 30, 2021, 2:34 PM

#

ok so ?

crude charm Apr 30, 2021, 2:34 PM

#

crude charm Apr 30, 2021, 2:34 PM

#

wraith rapids https://cdn.discordapp.com/attachments/324667367860862977/787428656708321290/ima...

literally the virtual boy

minor garnet Apr 30, 2021, 2:34 PM

#

whats is suposse to be null i think a loot class maybe ?

#

i already tried debug it

crude charm Apr 30, 2021, 2:34 PM

#

minor garnet whats is suposse to be null i think a loot class maybe ?

its null

wraith rapids Apr 30, 2021, 2:34 PM

#

a class cannot be null

crude charm Apr 30, 2021, 2:34 PM

#

so its throwing an error

#

yeah

#

use

#

ready for it

#

dependency injection

#

WOW

#

https://tenor.com/view/yawnface-gif-4425271

Tenor

shocked

▶ Play video

wraith rapids Apr 30, 2021, 2:35 PM

#

@vast quest you put it in the resources directory

#

maven will then package it into your jar

#

and that method will pull it out of the jar

vast quest Apr 30, 2021, 2:35 PM

#

ok then

wraith rapids Apr 30, 2021, 2:35 PM

#

maven or whatever dependency manager you're using

vast quest Apr 30, 2021, 2:35 PM

#

how can I use it?

wraith rapids Apr 30, 2021, 2:35 PM

#

what do you mean use

vast quest Apr 30, 2021, 2:35 PM

#

like get smth from it

wraith rapids Apr 30, 2021, 2:35 PM

#

you call the method

#

it shits out a file into the plugin directory

#

then you access that file

#

as you would any other file

vast quest Apr 30, 2021, 2:36 PM

#

it wants me to make public FileConfiguration getCustomConfig() {
return this.customConfig;
} static

minor garnet Apr 30, 2021, 2:36 PM

#

d e a d.. code ???

unkempt ore Apr 30, 2021, 2:37 PM

#

Means it can't be reached

vast quest Apr 30, 2021, 2:37 PM

#

im reading from this but it doesnt say it needs to be

#

https://www.spigotmc.org/wiki/config-files/

Working with Configuration Files | SpigotMC - High Performance Mine...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

wraith rapids Apr 30, 2021, 2:37 PM

#

you don't need to put the config in the jar, no

#

but then you need to write it with code

#

config.set("key", value)
config.save

minor garnet Apr 30, 2021, 2:37 PM

#

so i dont know

unkempt ore Apr 30, 2021, 2:37 PM

#

Your flow of control won't let that code be reached, that's what it means

#

That implies loot can't be null

vast quest Apr 30, 2021, 2:38 PM

#

wraith rapids but then you need to write it with code

do I need to write it in the plugin cant I use config.yml in resources

wraith rapids Apr 30, 2021, 2:38 PM

#

why

#

i mean what

vast quest Apr 30, 2021, 2:38 PM

#

Oh wait

#

nvm

hidden torrent Apr 30, 2021, 2:38 PM

#

unkempt ore That implies loot can't be null

where did you get that from? his if is missing braces and only executing 1 statement

vast quest Apr 30, 2021, 2:38 PM

#

I forgot to get instance

unkempt ore Apr 30, 2021, 2:39 PM

#

if (loot == null) (dead code)

#

I don't know what else that could mean to you

wraith rapids Apr 30, 2021, 2:39 PM

#

usually that would highligh the if clause itself though

unkempt ore Apr 30, 2021, 2:39 PM

#

Why?

hidden torrent Apr 30, 2021, 2:39 PM

#

dang, yea I didn't see immediately that it is pointing towards that if-code

wraith rapids Apr 30, 2021, 2:40 PM

#

because it is either always true or always false

#

thus making it redundant

unkempt ore Apr 30, 2021, 2:40 PM

#

You're right actually

#

It would say "This would always be true"

wraith rapids Apr 30, 2021, 2:40 PM

#

well, whatever

#

redundant is redundant

#

just delete it

unkempt ore Apr 30, 2021, 2:40 PM

#

But I mean, dead execution means the same thing, true

quaint mantle Apr 30, 2021, 2:41 PM

#

oops wrong discord

wraith rapids Apr 30, 2021, 2:41 PM

#

my client keeps all deleted images

#

i will now dox you using this image you accidentally sent

quaint mantle Apr 30, 2021, 2:41 PM

#

mine does too

#

I just didn't want it to be there for people that didn't see it

wraith rapids Apr 30, 2021, 2:42 PM

#

looks fancy though

obtuse basin Apr 30, 2021, 2:44 PM

#

ivory sleet List != Map

Hmm, ok, but how save a Map list into a yamlcfg?

wraith rapids Apr 30, 2021, 2:45 PM

#

config.set("key", map)

#

all of the elements in the map should be ConfigurationSerializable

#

iirc

eternal oxide Apr 30, 2021, 2:45 PM

#

reload after saving to have the Map convert into a MemorySection

wraith rapids Apr 30, 2021, 2:45 PM

#

and the keys should be strings

#

i think there might also be an util method somewhere to create a memorysection or a configsection out of a map, but I'm not sure

unkempt ore Apr 30, 2021, 2:46 PM

#

Are NamespacedKeys reusable?

wraith rapids Apr 30, 2021, 2:46 PM

#

they are immutable

#

so yes

unkempt ore Apr 30, 2021, 2:46 PM

#

Good

wraith rapids Apr 30, 2021, 2:47 PM

#

and you should always at least try to reuse them

#

constructing them on the spot is relatively cheap but is a bit of a code smell unless doing that is actually necessary

vast quest Apr 30, 2021, 2:47 PM

#

do I have to create the file in the jar

#

for it to generatwe

wraith rapids Apr 30, 2021, 2:47 PM

#

yes

#

that's what saveResource does

#

it takes the file out of the jar

#

if there's nothing to take, it can't take it out

#

put it in your resources directory in your ide and it should be automatically packaged into your plugin

#

like config.yml

#

and plugin.yml

vast quest Apr 30, 2021, 2:48 PM

#

Ok

#

btw wdym by commenting breaks?

#

can I not put comments in the yml

wraith rapids Apr 30, 2021, 2:49 PM

#

config.save deletes comments

vast quest Apr 30, 2021, 2:49 PM

#

oh

wraith rapids Apr 30, 2021, 2:49 PM

#

only way to have comments is to write them in the yml file in your ide

#

and then save it with saveResource

#

that keeps comments

vast quest Apr 30, 2021, 2:49 PM

#

ok

minor garnet Apr 30, 2021, 2:49 PM

#

okay ```vb
List<Loot> list = ConnectionSQL.loadAll();
if (list != null) sendMessage("is not null");
}

#

public static List<Loot> loot; i need add it to

wraith rapids Apr 30, 2021, 2:50 PM

#

split every deference onto a new line

vast quest Apr 30, 2021, 2:50 PM

#

welp imma recode my entire plugin cuz im changing from normal config to custom config

wraith rapids Apr 30, 2021, 2:50 PM

#

and try again

vast quest Apr 30, 2021, 2:50 PM

#

for events adn stuff

wraith rapids Apr 30, 2021, 2:50 PM

#

use a configuration library or framework

#

bukkit's is mediocre at best

vast quest Apr 30, 2021, 2:50 PM

#

uh

#

whats that

wraith rapids Apr 30, 2021, 2:51 PM

#

a thing that does configurations

vast quest Apr 30, 2021, 2:51 PM

#

Uhm

wraith rapids Apr 30, 2021, 2:51 PM

#

i guess bukkit's config api is beginner friendly

vast quest Apr 30, 2021, 2:51 PM

#

it doesnt generate the config

#

:/

wraith rapids Apr 30, 2021, 2:51 PM

#

open up the jar

#

is the file there

vast quest Apr 30, 2021, 2:51 PM

#

the jar

#

or the editor

wraith rapids Apr 30, 2021, 2:51 PM

#

the jar

vast quest Apr 30, 2021, 2:52 PM

#

ok I made it zip

#

yes its there

wraith rapids Apr 30, 2021, 2:52 PM

#

what is its name

vast quest Apr 30, 2021, 2:52 PM

#

events.yml

wraith rapids Apr 30, 2021, 2:52 PM

#

what is the line of code you're extracting it with

sharp bough Apr 30, 2021, 2:53 PM

#

how many ticks does this delay the action?

#

Bukkit.getScheduler().runTask(Main.get(), () -> player.teleport(loc));

wraith rapids Apr 30, 2021, 2:53 PM

#

0 to 1

#

it runs at the start of the next tick

vast quest Apr 30, 2021, 2:53 PM

#

    private void createEventFile() {
        Events = new File(getDataFolder(), "events.yml");
        if (!Events.exists()) {
            Events.getParentFile().mkdirs();
            saveResource("events.yml", false);
        }

        customConfig = new YamlConfiguration();
        try {
            customConfig.load(Events);
        } catch (IOException | InvalidConfigurationException e) {
            e.printStackTrace();
        }
    }

#

this is what I have

compact haven Apr 30, 2021, 2:54 PM

#

thats

#

not how u java

#

at all

#

well actually its pretty similar

#

minus the incorrect naming

vast quest Apr 30, 2021, 2:54 PM

#

I just looked it up from https://www.spigotmc.org/wiki/config-files/

Working with Configuration Files | SpigotMC - High Performance Mine...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

#

o

#

ok

wraith rapids Apr 30, 2021, 2:54 PM

#

how does that even compile

compact haven Apr 30, 2021, 2:54 PM

#

and Events needs to be init

#

before u call that

wraith rapids Apr 30, 2021, 2:54 PM

#

i guess "Events" is a field you've declared earlier with a type of File

#

stick to the conventions please

#

variables and fields should be lowercase

#

trying to read code that throws the conventions out of the window is cancer

#

that said

#

events.yml will never exist

#

although you are extracting it if it doesn't exist

#

dunno

minor garnet Apr 30, 2021, 2:56 PM

#

public static List<Loot> loot;

        List<Loot> list = ConnectionSQL.loadAll();
        sendMessage(list.get(1).getName());```

is working but tho define all i need cast it ?

wraith rapids Apr 30, 2021, 2:56 PM

#

that looks haram

minor garnet Apr 30, 2021, 2:57 PM

#

haram ?

#

when i execute that line e get null exception message

vast quest Apr 30, 2021, 2:58 PM

#

NNY imma be honest

#

I just copied from the thing

wraith rapids Apr 30, 2021, 2:59 PM

#

i hate the antichrist

vast quest Apr 30, 2021, 3:00 PM

#

??

quaint mantle Apr 30, 2021, 3:00 PM

#

wraith rapids i hate the antichrist

me too

vast quest Apr 30, 2021, 3:00 PM

#

can someone tell me what im missing/

sour rampart Apr 30, 2021, 3:01 PM

#

Is it possible to access the config in a static void? code: https://paste.md-5.net/otinoxodut.cpp

sour sand Apr 30, 2021, 3:02 PM

#

how to do you set the amount in an itemstack

wraith rapids Apr 30, 2021, 3:04 PM

#

itemstack.setAmount

sour sand Apr 30, 2021, 3:04 PM

#

ok thanks

wraith rapids Apr 30, 2021, 3:04 PM

#

it's fucking rocket science, I know

sharp bough Apr 30, 2021, 3:06 PM

#

is there a way to cancel the next event happening by a player or update a gui without closing and reopening the inv?

#

i have a gui with a listener that sends you to a location if you exit the gui, but i want to be able to delete the beds without sending you to the default location , when you click an item it sends you to that location

wraith rapids Apr 30, 2021, 3:07 PM

#

mark the player in a set or something when you close their inventory

#

in your listener, check if the player is marked, and if they are, ignore the event

#

then unmark them

sharp bough Apr 30, 2021, 3:07 PM

#

hm

#

thats a good ideaa

#

and then reopen the gui with the new items

wraith rapids Apr 30, 2021, 3:08 PM

#

super hyper technically you don't even need a set or anything, just a single boolean

sharp bough Apr 30, 2021, 3:08 PM

#

wdym

wraith rapids Apr 30, 2021, 3:08 PM

#

but a set would probably be a less fragile solution

vast quest Apr 30, 2021, 3:08 PM

#

so how can I make a custom config generate?

sharp bough Apr 30, 2021, 3:08 PM

#

i could save them in the yaml file with false, and then if getIsUpdating cancel the event

#

or something like that

#

right?

wraith rapids Apr 30, 2021, 3:08 PM

#

strip out all of the ifs and shit and see if the saveResource call works

#

you don't need to save them in an yaml

#

you only need to mark them for 1 tick

#

yaml and files are used when you need to remember something after the server restarts

sharp bough Apr 30, 2021, 3:09 PM

#

and how do you mark a player? do i save the uuid?

wraith rapids Apr 30, 2021, 3:09 PM

#

which you do not need to do

#

Set<Player> or Set<UUID>

#

add and remove

sharp bough Apr 30, 2021, 3:10 PM

#

oh

#

didnt know what existed

quaint mantle Apr 30, 2021, 3:10 PM

#

            try {
                if(Economy.hasEnough(p.getDisplayName(), 300)) {
                    try {
                        Economy.subtract(p.getDisplayName(), 300);
                        p.sendMessage(Main.PREFIX + "Du hast erfolgreich §e1 Netherite §7gekauft.");
                        p.playSound(p.getLocation(), Sound.ENTITY_PLAYER_LEVELUP, 2F, 2F);
                    } catch (NoLoanPermittedException e1) {
                        // TODO Auto-generated catch block
                        e1.printStackTrace();
                    }
                } else {
                    p.sendMessage(Main.PREFIX + "Du hast nicht genügend Geld!");
                }
            } catch (UserDoesNotExistException e1) {
                // TODO Auto-generated catch block
                e1.printStackTrace();
            }

it doesn't work

#

how do I broadcast message in server?

wraith rapids Apr 30, 2021, 3:10 PM

#

why are you using display names

#

you should be using the player name, not the player display name

sharp bough Apr 30, 2021, 3:10 PM

#

quaint mantle how do I broadcast message in server?

google how to broadcast a message in minecraft ajva spigot

quaint mantle Apr 30, 2021, 3:10 PM

#

quaint mantle how do I broadcast message in server?

Bukkit.broadcastMessage(STRING);

wraith rapids Apr 30, 2021, 3:10 PM

#

player display name can be changed with shit like essentials /nickname

sharp bough Apr 30, 2021, 3:11 PM

#

lol

wraith rapids Apr 30, 2021, 3:11 PM

#

you probably don't want that

eternal oxide Apr 30, 2021, 3:11 PM

#

@wraith rapids I found no way to lowerCase so this is the best I ended up with ```yaml
<groupId>com.palmergames</groupId>
<artifactId>homestead</artifactId>
<name>Homestead</name>
<version>0.0.1-SNAPSHOT</version>
<description>Homestead land claim and protection system.</description>

<!-- Project's website -->
<url>http://palmergames.com</url>

<properties>
    <project.bukkitAPIVersion>1.16</project.bukkitAPIVersion>
    <project.javaVersion>1.8</project.javaVersion>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <jar.finalName>${project.name}</jar.finalName>
</properties>

name: ${project.name}
main: ${project.groupId}.${project.artifactId}.${project.name}
version: ${project.version}
api-version: ${project.bukkitAPIVersion}

author: ElgarL
website: ${project.url}

description: >
${project.description}```

quaint mantle Apr 30, 2021, 3:11 PM

#

wraith rapids player display name can be changed with shit like essentials /nickname

it's my server

#

with my homies

#

not public

wraith rapids Apr 30, 2021, 3:11 PM

#

you still don't want to use display name

#

bad code is bad code

quaint mantle Apr 30, 2021, 3:11 PM

#

ok, UUID then?

wraith rapids Apr 30, 2021, 3:11 PM

#

homies or not

#

no

#

player name

#

player.getName

quaint mantle Apr 30, 2021, 3:11 PM

#

Ok

wraith rapids Apr 30, 2021, 3:12 PM

#

              <plugin>
                <groupId>org.codehaus.mojo</groupId>
                <artifactId>build-helper-maven-plugin</artifactId>
                <version>1.12</version>
                <executions>
                    <execution>
                        <id>compute-plugin-package</id>
                        <goals>
                            <goal>regex-property</goal>
                        </goals>
                        <configuration>
                            <name>plugin.package</name>
                            <regex>.*</regex>
                            <value>${project.artifactId}</value>
                            <replacement>$0</replacement>
                            <failIfNoMatch>false</failIfNoMatch>
                            <toLowerCase>true</toLowerCase>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

I also came up with something @eternal oxide

#

this little plugin thingy converts the artifact id to lowercase

quaint mantle Apr 30, 2021, 3:13 PM

#

quaint mantle Bukkit.broadcastMessage(STRING);

it's giving me error on enable

#

https://www.spigotmc.org/wiki/creating-a-blank-spigot-plugin-in-intellij-idea/
or
https://www.spigotmc.org/wiki/creating-a-plugin-with-maven-using-intellij-idea/

Creating a blank Spigot plugin in IntelliJ IDEA | SpigotMC - High P...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

Creating a plugin with Maven using IntelliJ IDEA | SpigotMC - High ...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

wraith rapids Apr 30, 2021, 3:13 PM

#

but i guess it is pretty excessive just to convert one string to lowercase lmao

#

oh so you gave up on the eclipse tutorial now

#

and now you want to switch to intellij

#

and want a tutorial for it

quaint mantle Apr 30, 2021, 3:14 PM

#

no but a frand told me to use intellij

eternal oxide Apr 30, 2021, 3:14 PM

#

wraith rapids this little plugin thingy converts the artifact id to lowercase

I did see that but GitHub is now blocking anything but lower case ArtifactId So I've gone with the name field

grand coral Apr 30, 2021, 3:14 PM

#

How to make own BreakBlockEvent?

wraith rapids Apr 30, 2021, 3:14 PM

#

you know, you're going to run out of things to give up on at this rate

sharp bough Apr 30, 2021, 3:14 PM

#

wraith rapids Set<Player> or Set<UUID>

wait could you give me an example? i have no idea what you are talking about and cant find anything in google or autocomplete

quaint mantle Apr 30, 2021, 3:14 PM

#

public class Broadcast implements CommandExecutor {
    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        Player player = (Player) sender;
        if (args.length > 0){
            Bukkit.broadcastMessage(String.valueOf(args));
        }
        else {
            player.sendMessage(ChatColor.GRAY.toString() + "Usage:" + ChatColor.AQUA.toString() + " /broadcast <message>");
        }

        return false;
    }
}

#

why its giving error

sharp bough Apr 30, 2021, 3:15 PM

#

cuz args is not 1 word

#

you have to use for string in args

#

add that to a list replacing _ with " "

#

i think

hexed rover Apr 30, 2021, 3:16 PM

#

String.join(" ", args)

wraith rapids Apr 30, 2021, 3:18 PM

#

i mean it takes the artifact id, converts it to lowecase, and writes it as the value of the "plugin.package" property @eternal oxide

#

the actual artifact id remains capitalized

quaint mantle Apr 30, 2021, 3:18 PM

#

public class Broadcast implements CommandExecutor {
    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        Player player = (Player) sender;
        if (args.length > 0){
            Bukkit.broadcastMessage(String.join("", args));
        }
        else {
            player.sendMessage(ChatColor.GRAY.toString() + "Usage:" + ChatColor.AQUA.toString() + " /broadcast <message>");
        }

        return false;
    }
}

#

like this?

eternal oxide Apr 30, 2021, 3:18 PM

#

wraith rapids the actual artifact id remains capitalized

Yep, that will be blocked by GitHub

wraith rapids Apr 30, 2021, 3:18 PM

#

why? the artifact Id remains capitalized

eternal oxide Apr 30, 2021, 3:19 PM

#

They started enforcing lower case on Artifacts a while back

wraith rapids Apr 30, 2021, 3:19 PM

#

what

#

that's gay

eternal oxide Apr 30, 2021, 3:19 PM

#

very

wraith rapids Apr 30, 2021, 3:19 PM

#

well fuck github i guess

eternal oxide Apr 30, 2021, 3:19 PM

#

I had to move GroupManager to groupmanager to be able to install

wraith rapids Apr 30, 2021, 3:20 PM

#

i thought you meant they enforced not having them as lowercase

eternal oxide Apr 30, 2021, 3:20 PM

#

it worked for years, but all of a sudden gave a wierd error that tells you nothing

wraith rapids Apr 30, 2021, 3:20 PM

#

github is going down the shitter

eternal oxide Apr 30, 2021, 3:20 PM

#

one step forward, two back

young knoll Apr 30, 2021, 3:21 PM

#

What packet

quaint mantle Apr 30, 2021, 3:21 PM

#

hexed rover String.join(" ", args)

public class Broadcast implements CommandExecutor {
    @Override
    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
        Player player = (Player) sender;
        if (args.length > 0){
            Bukkit.broadcastMessage(String.join("", args));
        }
        else {
            player.sendMessage(ChatColor.GRAY.toString() + "Usage:" + ChatColor.AQUA.toString() + " /broadcast <message>");
        }

        return false;
    }
}

wraith rapids Apr 30, 2021, 3:21 PM

#

good thing I don't really use github actions or anything

#

or really use github at all

eternal oxide Apr 30, 2021, 3:22 PM

#

I have my own private git locally hosted, but public goes on GitHub

wraith rapids Apr 30, 2021, 3:23 PM

#

they don't actually block like your entire repository if they sniff out you have a not-lowercase artifact id in your pom somewhere, do they

#

it's just for like, actions and all of the other build magic and shit

eternal oxide Apr 30, 2021, 3:23 PM

#

no, only if you use install

#

general hosting works fine

#

everyone is just going to use jitpack if they made things any more difficult.

wraith rapids Apr 30, 2021, 3:24 PM

#

or just not deploy to github

#

i've found the github packages support work really terribly anyway

#

tried to get it to work for a good few days at one point and everything just kept blowing up one by one

hexed rover Apr 30, 2021, 3:28 PM

#

quaint mantle ```d public class Broadcast implements CommandExecutor { @Override publi...

with a space between the " " so it puts a space between each word, if it still doesnt work you should send the error

quaint mantle Apr 30, 2021, 3:29 PM

#

@hexed rover

#

[20:59:09 ERROR]: Error occurred while enabling Demo v0.0.1 (Is it up to date?)
java.lang.NullPointerException
        at me.nix.demo.Demo.onEnable(Demo.java:22) ~[?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:321) ~[patched.jar:git-PaperSpigot-"4c7641d"]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:332) [patched.jar:git-PaperSpigot-"4c7641d"]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:407) [patched.jar:git-PaperSpigot-"4c7641d"]
        at org.bukkit.craftbukkit.v1_8_R3.CraftServer.loadPlugin(CraftServer.java:359) [patched.jar:git-PaperSpigot-"4c7641d"]
        at org.bukkit.craftbukkit.v1_8_R3.CraftServer.enablePlugins(CraftServer.java:318) [patched.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.MinecraftServer.s(MinecraftServer.java:408) [patched.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.MinecraftServer.k(MinecraftServer.java:372) [patched.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.MinecraftServer.a(MinecraftServer.java:327) [patched.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.DedicatedServer.init(DedicatedServer.java:267) [patched.jar:git-PaperSpigot-"4c7641d"]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:563) [patched.jar:git-PaperSpigot-"4c7641d"]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_51]
[20:59:09 INFO]: [DEMO] Disabling Demo v0.0.1

hexed rover Apr 30, 2021, 3:29 PM

#

Did u register the command in plugin.yml

quaint mantle Apr 30, 2021, 3:30 PM

#

oof

wraith rapids Apr 30, 2021, 3:30 PM

#

lmao paperspigot

vast quest Apr 30, 2021, 3:30 PM

#

package whyhax.proje;

import org.bukkit.configuration.InvalidConfigurationException;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.plugin.java.JavaPlugin;

import java.io.File;
import java.io.IOException;

public class Proje extends JavaPlugin {

    private File customConfigFile;
    private FileConfiguration customConfig;

    @Override
    public void onEnable(){
        createCustomConfig();
    }

    public FileConfiguration getCustomConfig() {
        return this.customConfig;
    }

    private void createCustomConfig() {
        customConfigFile = new File(getDataFolder(), "custom.yml");
        if (!customConfigFile.exists()) {
            customConfigFile.getParentFile().mkdirs();
            saveResource("custom.yml", false);
        }

        customConfig= new YamlConfiguration();
        try {
            customConfig.load(customConfigFile);
        } catch (IOException | InvalidConfigurationException e) {
            e.printStackTrace();
        }
    }
}
 ``` I copied from <https://www.spigotmc.org/wiki/config-files/#using-custom-configurations> word by word and it STILL DOESNT GENERATE

hexed rover Apr 30, 2021, 3:30 PM

#

do you have a custom.yml in your src folder

wraith rapids Apr 30, 2021, 3:30 PM

#

get rid of all ifs and shit and just test the saveResource call

vast quest Apr 30, 2021, 3:31 PM

#

hexed rover do you have a custom.yml in your src folder

yes

vast quest Apr 30, 2021, 3:31 PM

#

wraith rapids get rid of all ifs and shit and just test the saveResource call

do I put that onEnable

wraith rapids Apr 30, 2021, 3:31 PM

#

yes

#

just delete literally everything

#

and add only the saveResource call to onenable

hexed rover Apr 30, 2021, 3:32 PM

#

        if (!file.exists()) {
            if (!file.getParentFile().exists())
                if (!file.getParentFile().mkdirs()) {
                    // error 
                }

            plugin.saveResource(file, false);
        }```
this is usually what i do

vast quest Apr 30, 2021, 3:33 PM

#

import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.plugin.java.JavaPlugin;

import java.io.File;

public class Proje extends JavaPlugin {

    private File customConfigFile;
    private FileConfiguration customConfig;

    @Override
    public void onEnable(){
        saveResource("custom.yml", false);
    }

}
 ``` deleted litteraly anything

#

imma tst

hexed rover Apr 30, 2021, 3:34 PM

#

does it give you any errors if that doesnt work?

vast quest Apr 30, 2021, 3:34 PM

#

Nope doesnt work

wraith rapids Apr 30, 2021, 3:34 PM

#

and you have a custom.yml file in the root of your plugin jar

vast quest Apr 30, 2021, 3:34 PM

#

📎 message.txt

wraith rapids Apr 30, 2021, 3:34 PM

#

next to your config.yml and plugin.yml

vast quest Apr 30, 2021, 3:34 PM

#

Yes

wraith rapids Apr 30, 2021, 3:35 PM

#

and you are checking the compiled jar

#

and not your ide or whatever

vast quest Apr 30, 2021, 3:35 PM

#

no ;-;

wraith rapids Apr 30, 2021, 3:35 PM

#

i told you to open up the jar

#

what did you think I meant by that

#

open it with like winrar or whatever

vast quest Apr 30, 2021, 3:36 PM

#

the config.yml is IN the compiled jar

wraith rapids Apr 30, 2021, 3:36 PM

#

and custom.yml?

vast quest Apr 30, 2021, 3:36 PM

#

Yes

wraith rapids Apr 30, 2021, 3:36 PM

#

they're in the root of the jar, both in the same directory

vast quest Apr 30, 2021, 3:36 PM

#

yes

#

just when I open it

#

[18:37:34 ERROR]: Could not load 'plugins\Proje-1.0.jar' in folder 'plugins'

wraith rapids Apr 30, 2021, 3:38 PM

#

and what's the exception

vast quest Apr 30, 2021, 3:38 PM

#

📎 message.txt

wraith rapids Apr 30, 2021, 3:39 PM

#

use some paste site

vast quest Apr 30, 2021, 3:39 PM

#

ok

#

https://paste.md-5.net/xaviqupiwe.rb

wraith rapids Apr 30, 2021, 3:40 PM

#

Cannot find main class `whyhax.proje.Proje'

vast quest Apr 30, 2021, 3:40 PM

#

huh

#

public class Proje extends JavaPlugin {

wraith rapids Apr 30, 2021, 3:40 PM

#

no wonder nothing is happening, your plugin isn't even enabling to begin with

vast quest Apr 30, 2021, 3:41 PM

#

o

#

how can I fix that

wraith rapids Apr 30, 2021, 3:41 PM

#

open up the jar and check whether the path bukkit is looking for is exactly the same as the path of your main class

vast quest Apr 30, 2021, 3:42 PM

#

yep

#

it is

wraith rapids Apr 30, 2021, 3:42 PM

#

restart your server instead of using reload

quaint mantle Apr 30, 2021, 3:43 PM

#

https://www.spigotmc.org/wiki/creating-a-blank-spigot-plugin-in-intellij-idea/
or
https://www.spigotmc.org/wiki/creating-a-plugin-with-maven-using-intellij-idea/
Which one should I use?

Creating a blank Spigot plugin in IntelliJ IDEA | SpigotMC - High P...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

Creating a plugin with Maven using IntelliJ IDEA | SpigotMC - High ...

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

wraith rapids Apr 30, 2021, 3:44 PM

#

whichever

vast quest Apr 30, 2021, 3:44 PM

#

error has gotten shorter

wraith rapids Apr 30, 2021, 3:44 PM

#

try the first one

#

when you give up on it

#

you can try the second one

vast quest Apr 30, 2021, 3:44 PM

#

https://paste.md-5.net/ziyenehuye.rb

wraith rapids Apr 30, 2021, 3:44 PM

#

it still can't find your main class

vast quest Apr 30, 2021, 3:44 PM

#

idk

wraith rapids Apr 30, 2021, 3:44 PM

#

show a screenshot of you looking at your compiled main class in your jar

vast quest Apr 30, 2021, 3:45 PM

#

wraith rapids Apr 30, 2021, 3:45 PM

#

that is not a fucking jar

#

open up your compiled jar

#

navigate to your main class

vast quest Apr 30, 2021, 3:46 PM

#

wraith rapids Apr 30, 2021, 3:47 PM

#

yeah i don't know

#

magic i guess

vast quest Apr 30, 2021, 3:47 PM

#

should I try to open another project?

wraith rapids Apr 30, 2021, 3:47 PM

#

i guess

vast quest Apr 30, 2021, 3:49 PM

#

uh

#

magic is weird

#

huh

vast quest Apr 30, 2021, 3:51 PM

#

wraith rapids i guess

it works

#

for sum reason

#

ok...

sick ravine Apr 30, 2021, 3:52 PM

#

I created Custom Enchant from net.minecraft.server.v1_12_R1.Enchantment but in minecraft I don't see EnchantName I
Can you help me?

#

#

;_;

proven sierra Apr 30, 2021, 3:57 PM

#

You can't get the client to render it

north osprey Apr 30, 2021, 3:58 PM

#

@sick ravine I also tested creating custom enchantments recently and had the same problem. Perhaps some custom datapack with translations for your enchantment would do it. At least that was my hypothesis but I haven't tested that.

sick ravine Apr 30, 2021, 3:58 PM

#

on 1.16.5, client is able to render custom enchants names

sick ravine Apr 30, 2021, 3:59 PM

#

north osprey <@!534018824559788032> I also tested creating custom enchantments recently and h...

um okey

wraith rapids Apr 30, 2021, 3:59 PM

#

how unfortunate that you're using a version that is like 4 years old

north osprey Apr 30, 2021, 3:59 PM

#

BTW you should not need to access classes from the net.minecraft package.

wraith rapids Apr 30, 2021, 4:00 PM

#

does bukkit let you register custom enchantments through the api now?

#

last I checked you still needed nms

north osprey Apr 30, 2021, 4:01 PM

#

I did it by enabling org.bukkit.enchantments.Enchantment.acceptingNew private field through the reflection API.

#

But as I said, the name still did not render...

wraith rapids Apr 30, 2021, 4:01 PM

#

lol

sour rampart Apr 30, 2021, 4:02 PM

#

how can I access the config in a static void? code: https://paste.md-5.net/otinoxodut.cpp
plz help

wraith rapids Apr 30, 2021, 4:02 PM

#

i guess that works

#

you shouldn't access the config in a static void

sour rampart Apr 30, 2021, 4:02 PM

#

oh

wraith rapids Apr 30, 2021, 4:02 PM

#

static is static and shouldn't depend on the data held by your plugin instance

#

such as your config

sour rampart Apr 30, 2021, 4:03 PM

#

how can I access the config not in the main class then

wraith rapids Apr 30, 2021, 4:03 PM

#

normally

#

pass your plugin object to the object you want to access it in

#

and then just call methods on it

north osprey Apr 30, 2021, 4:03 PM

#

If you have a piece of code that depends on the config then just pass the config instance.

sick ravine Apr 30, 2021, 4:04 PM

#

public class CustomEnchantment extends net.minecraft.server.v1_12_R1.Enchantment {

}

CustomEnchantment customEnchantment = new CustomEnchantment(...

net.minecraft.server.v1_12_R1.Enchantment.enchantments.a(100, new KeyMinecraft("customEnchantment"), customEnchantment);
CraftEnchantment craftEnchantment = new CraftEnchantment(customEnchantment);
org.bukkit.enchantments.Enchantment.registerEnchantment(customEnchantment);

north osprey Apr 30, 2021, 4:04 PM

#

Passing the plugin instance is also ok but then you'll not be 100% truthful about what your code depends on.

sick ravine Apr 30, 2021, 4:04 PM

#

sick ravine `public class CustomEnchantment extends net.minecraft.server.v1_12_R1.Enchantmen...

no refection

#

legal 😳

north osprey Apr 30, 2021, 4:05 PM

#

IMO reflection dependent on the Bukkit API is much better than code dependent on decompiled classes...

#

This will break on different versions.

wraith rapids Apr 30, 2021, 4:05 PM

#

depends

#

the best way is to have version-specific submodules

#

but that is usually only for large projects that require a lot of diddling with the internals

#

reflection is fine for small things

sick ravine Apr 30, 2021, 4:06 PM

#

~~It gets repaired sometime with reflection~~

north osprey Apr 30, 2021, 4:07 PM

#

I think that in case of enchantments we already rely on some stability throughout versions. Otherwise we would not have that in the Spigot API.

wraith rapids Apr 30, 2021, 4:07 PM

#

issue with reflective code that it's not as maintainable as directly programming against existent things

#

of course that's not an issue for something as simple as setting a single field somewhere

north osprey Apr 30, 2021, 4:07 PM

#

agreed\

#

Reflective code does not typecheck

wraith rapids Apr 30, 2021, 4:08 PM

#

what I usually do is either have version specific submodules + a reflective fallback impl

#

or for smaller projects, just build against the latest version of nms and have a reflective fallback impl

vast quest Apr 30, 2021, 4:11 PM

#

Ok NNY

#

I made it work

#

tho how can I reload it

wraith rapids Apr 30, 2021, 4:12 PM

#

config.load

#

like i said, reloading is re-loading

#

loading again

vast quest Apr 30, 2021, 4:12 PM

#

.getCustomConfig().load;??

wraith rapids Apr 30, 2021, 4:13 PM

#

you would want to create a method like reloadCustomConfig

#

which would just do customConfig.load

vast quest Apr 30, 2021, 4:13 PM

#

and what do I put into that

wraith rapids Apr 30, 2021, 4:13 PM

#

in the class that manages your custom config

#

and remembers the YamlConfiguration that represents the config

#

and the File that specifies where your config is on the disk

#

so it can call config.load(file)

vast quest Apr 30, 2021, 4:14 PM

#

I just use the main class for config

wraith rapids Apr 30, 2021, 4:14 PM

#

then do it there

vast quest Apr 30, 2021, 4:15 PM

#

so but

#

can you show me what to do

wraith rapids Apr 30, 2021, 4:15 PM

#

no

vast quest Apr 30, 2021, 4:15 PM

#

im just so confused

wraith rapids Apr 30, 2021, 4:15 PM

#

make your main plugin object remember the File

#

make your main plugin object remember the YamlConfiguration

vast quest Apr 30, 2021, 4:15 PM

#

but like getCustomConfig is ALREADY the file

wraith rapids Apr 30, 2021, 4:15 PM

#

no

#

it should not return the File

#

it should return the YamlConfiguration

vast quest Apr 30, 2021, 4:16 PM

#

    public FileConfiguration getCustomConfig() {
        return this.customConfig1;
    }```

wraith rapids Apr 30, 2021, 4:16 PM

#

yes

#

YamlConfiguration is a kind of FileConfiguration

#

it's not a File

#

it's a Configuration

vast quest Apr 30, 2021, 4:16 PM

#

ok

#

so

north osprey Apr 30, 2021, 4:16 PM

#

Out of curiosity @wraith rapids how do you manage state that needs persistence and atomic writes in your plugins?

vast quest Apr 30, 2021, 4:16 PM

#

getCustomConfig().load("config.yml")

wraith rapids Apr 30, 2021, 4:16 PM

#

atomic in what context

#

cross-server? threaded?

north osprey Apr 30, 2021, 4:17 PM

#

That a server crash in the middle of a state modification does not corrupt it.

#

Main thread only.

wraith rapids Apr 30, 2021, 4:17 PM

#

depends on how robust it needs to be

#

the most robust way is to piggyback off the atomicity of the filesystem

north osprey Apr 30, 2021, 4:18 PM

#

That's the way I want to go right now.

vast quest Apr 30, 2021, 4:18 PM

#

uh also

north osprey Apr 30, 2021, 4:18 PM

#

But have you tried out some local no-sql DBs?

wraith rapids Apr 30, 2021, 4:18 PM

#

or if you are using a database, your db probably has atomicity guarantees

vast quest Apr 30, 2021, 4:18 PM

#

how can I delete the old config whenever I update the plugin

wraith rapids Apr 30, 2021, 4:19 PM

#

depends on the db you're using

#

i don't really use nosql

north osprey Apr 30, 2021, 4:19 PM

#

then how do you serialize your state?

wraith rapids Apr 30, 2021, 4:19 PM

#

i serialize it and then send it to whatever persists it

#

it's the job of the thing persisting it to make the underlying write atomic

#

if it's a database, I rely on the writes being atomically implemented there

#

if it's like a raw file or something, I write and replace

north osprey Apr 30, 2021, 4:20 PM

#

What serialization do you use? I wanted my state to be readable so I serialize it to JSON. Having that Mongo seems like an obvious choice for storing it when it comes to a DB.

wraith rapids Apr 30, 2021, 4:21 PM

#

with raw files, usually I just hammer everything into raw bytes

#

json is fine for readability I suppose

#

i'm not so sure about nosql but in most sql cases, hammering shit into json and storing in a text column is kind of frowned upon except for specific cases

north osprey Apr 30, 2021, 4:22 PM

#

I asked because I was wondering whether there is some tried and tested solution to that.

wraith rapids Apr 30, 2021, 4:22 PM

#

the meta is to have a table with columns for each of the keys your json mapping would have

north osprey Apr 30, 2021, 4:23 PM

#

Or perhaps that you've managed to do some performance analysis.

wraith rapids Apr 30, 2021, 4:23 PM

#

and then store a reference to that row in the column you'd store your json in

north osprey Apr 30, 2021, 4:23 PM

#

Yeah, I know how to use an SQL DB 😄

wraith rapids Apr 30, 2021, 4:23 PM

#

but, well, my point is that the atomicity should be provided by the database

vast quest Apr 30, 2021, 4:24 PM

#

can I disable my plugin?

wraith rapids Apr 30, 2021, 4:24 PM

#

it shouldn't be handled on your end

vast quest Apr 30, 2021, 4:24 PM

#

like make it red on /pl

wraith rapids Apr 30, 2021, 4:24 PM

#

Bukkit.getPluginManager().disablePlugin

#

or something

north osprey Apr 30, 2021, 4:25 PM

#

One more question. Have you compared doing file IO on the main server thread vs offloading it to a different thread and then scheduling a continuation to go back to the main thread?

wraith rapids Apr 30, 2021, 4:25 PM

#

i generally design everything so that doing io on the main thread is not necessary

vast quest Apr 30, 2021, 4:25 PM

#

can I get the plugins version

#

and use it in main clas

#

the one in the pom

wraith rapids Apr 30, 2021, 4:25 PM

#

jumping to an off-thread and having the off-thread do the IO and blocking the main thread until the IO is done will obviously be slower than just the raw IO

#

because you get overheads from hopping your data between threads and all of the scheduling overhead

north osprey Apr 30, 2021, 4:26 PM

#

@vast quest in SBT there is a plugin for that but I don't know how Maven deals with that. I'd guess there is something similar.

#

Yeah, I don't mean blocking the main thread.

eternal oxide Apr 30, 2021, 4:26 PM

#

vast quest the one in the pom

Your version shoudl be in yoru plugin.yml so can be read using pluign.getDescription()

vast quest Apr 30, 2021, 4:27 PM

#

o

wraith rapids Apr 30, 2021, 4:27 PM

#

if you absolutely have to have your main thread operation not resume a tick later or something, you can do your work on the main thread while the off-thread IO happens

vast quest Apr 30, 2021, 4:27 PM

#

so plugin.getDescription("version")?

wraith rapids Apr 30, 2021, 4:27 PM

#

and once you're done with your MT work, you start blocking on the completed IO result

eternal oxide Apr 30, 2021, 4:27 PM

#

look and see

#

because no, thats not right

wraith rapids Apr 30, 2021, 4:28 PM

#

that can be faster than just doing the IO on the main thread, but not necessarily because of the concurrency overhead

vast quest Apr 30, 2021, 4:28 PM

#

eternal oxide because no, thats not right

its getDescription().getVersion()

eternal oxide Apr 30, 2021, 4:28 PM

#

I know

wraith rapids Apr 30, 2021, 4:28 PM

#

it's best to design things so that your MT work can be put on hold and allow the server to resume for a tick before checking whether your off-thread resources are ready, and then resuming if they are

#

of course that's not always possible, with things like events

north osprey Apr 30, 2021, 4:29 PM

#

What do you mean by "MT"?

wraith rapids Apr 30, 2021, 4:29 PM

#

main thread

north osprey Apr 30, 2021, 4:29 PM

#

ok

vast quest Apr 30, 2021, 4:29 PM

#

what???

wraith rapids Apr 30, 2021, 4:29 PM

#

replace == with equals()

#

don't compare strings with ==

#

read the description of the warning

#

more actions -> show description

vast quest Apr 30, 2021, 4:30 PM

#

also should I put objectnonull thing

wraith rapids Apr 30, 2021, 4:30 PM

#

if the string you are calling .equals on can be null

#

use Objects.equals(a,b)

#

instead of a.equals(b)

#

if a is null and you call .equals on it, it explodes

#

Objects.requireNotNull hides the warning but still explodes

vast quest Apr 30, 2021, 4:32 PM

#

wraith rapids use Objects.equals(a,b)

on the if statement?

north osprey Apr 30, 2021, 4:32 PM

#

What I considered is something like that:

  modifyMinecraftWorldBefore()
  Bukkit.getScheduler().runTaskAsynchronously(plugin, () => {
    saveStateFile()
    Bukkit.getScheduler().runTask(plugin, () => {
      modifyMinecraftWorldAfter()
    })
  })

wraith rapids Apr 30, 2021, 4:33 PM

#

yeah, that is a pretty standard way of doing some mt work, then doing off thread work, and then resuming work on the main thread

#

there are some libraries and things that simplify it and reduce the indentation madness, like Aikar's TaskChain

north osprey Apr 30, 2021, 4:34 PM

#

I'm writing in Scala so I considered using the builting Future class

sharp bough Apr 30, 2021, 4:34 PM

#

vast quest Apr 30, 2021, 4:34 PM

#

NNY is there anyway I can catch a empty null error

wraith rapids Apr 30, 2021, 4:34 PM

#

futures don't really play well with the main thread

#

there are surprisingly few cases where you can use them

#

basically, your future must be completed on the MT if you want to use any of the thenX methods to do bukkit stuff

#

since the thenX methods are called by the thread completing the future

north osprey Apr 30, 2021, 4:35 PM

#

I mean scala.concurrent.Future

wraith rapids Apr 30, 2021, 4:35 PM

#

i haven't worked with those, but I'd assume they run into the same restriction

north osprey Apr 30, 2021, 4:36 PM

#

you can specify an ExecutionContext with every flatMap

#

so it could be done

wraith rapids Apr 30, 2021, 4:36 PM

#

jist of the issue is that there isn't really any good way to tell a future to run on the main thread

#

since bukkit doesn't provide any executors or anything that futures could hook into

#

there's just the scheduler

#

Bukkit.getScheduler().runTask()

north osprey Apr 30, 2021, 4:37 PM

#

but I'm not sure I'll get enough value from that to justify the additional overhead

wraith rapids Apr 30, 2021, 4:37 PM

#

do whatever is easier to maintain

#

without using libraries or whatnot, the simplest and easiest to read way would probably be to create a class for each of these kind of tasks, and then declare a method for each of the phases

#

and then use the bukkit scheduler to invoke the methods either on an off-thread or the main thread

#

and have each of the methods schedule the next one

#

and then you basically have taskchain

#

but, for simple things, you can just nest scheduler calls and lambdas

vast quest Apr 30, 2021, 4:40 PM

#

how can I check if protocolib is enabled

#

and on the server

wraith rapids Apr 30, 2021, 4:40 PM

#

BUkkit.getPlugin("ProtocolLib")

#

check if it's null or if it's not isEnabled

north osprey Apr 30, 2021, 4:41 PM

#

That's the idea. The rest of the code is supposed to be organised into neat functions already so it should still be readable. If I get into a situation where I need to nest state updates then I'll probably go with the "for-comprehension" notation from Scala and try to implement an ExecutionContext based on the Bukkit Scheduler.

#

Should be easy enough.

vast quest Apr 30, 2021, 4:42 PM

#

there is no getPlugin

wraith rapids Apr 30, 2021, 4:42 PM

#

try PluginManager::getPlugin

#

bukkit.getpluginmanager

sharp bough Apr 30, 2021, 4:42 PM

#

why do i get that i dont get it

vast quest Apr 30, 2021, 4:42 PM

#

Ok

#

how can I check if its not enabled?

wraith rapids Apr 30, 2021, 4:42 PM

#

read what I said

north osprey Apr 30, 2021, 4:43 PM

#

@sharp bough use the streams API.

#

It is much more readable.

wraith rapids Apr 30, 2021, 4:43 PM

#

real men write for loops

vast quest Apr 30, 2021, 4:43 PM

#

so

#

this?
if (Bukkit.getPluginManager().getPlugin("ProtocolLib") != null || Bukkit.getPluginManager().getPlugin("ProtocolLib").isEnabled()) {

north osprey Apr 30, 2021, 4:43 PM

#

😄

wraith rapids Apr 30, 2021, 4:43 PM

#

don't call it twice

#

assign it to a variable

quiet ice Apr 30, 2021, 4:44 PM

#

If anything use List#forEach

wraith rapids Apr 30, 2021, 4:44 PM

#

and use &&

quiet ice Apr 30, 2021, 4:44 PM

#

Streams have an overhead of their own, not worth it

wraith rapids Apr 30, 2021, 4:44 PM

#

you want it to be not null and enabled

sharp bough Apr 30, 2021, 4:44 PM

#

north osprey <@!199697125372723200> use the streams API.

https://www.spigotmc.org/threads/how-to-do-this-using-streams.362284/ this?

SpigotMC - High Performance Minecraft

How to do this using streams

Hello guys, a week ago i started a new project which takes movements, turns, and some crazy stuff,
when i was developing the TurnManager class, i found...

vast quest Apr 30, 2021, 4:44 PM

#

but... but... you said OR

north osprey Apr 30, 2021, 4:44 PM

#

@quiet ice I think what you're suggesting is premature optimisation.

wraith rapids Apr 30, 2021, 4:44 PM

#

yeah you wouldn't believe how much extra performance paper has squeezed out of the server by just replacing streams with for loops and shit in mojang code

#

it's absolutely insane

#

like a third of the server's tick time is streams overhead

quiet ice Apr 30, 2021, 4:45 PM

#

It will use an iterator either way, using the iterator directly is a lot better

wraith rapids Apr 30, 2021, 4:45 PM

#

I said if it's null or if it's not enabled

vast quest Apr 30, 2021, 4:45 PM

#

Plugin protocheck = Bukkit.getPluginManager().getPlugin("ProtocolLib");
if (protocheck != null && protocheck.isEnabled()) {

wraith rapids Apr 30, 2021, 4:46 PM

#

(a == null || !a.isEnabled)
is the same as
!(a != null && a.isEnabled)

#

it is

vast quest Apr 30, 2021, 4:46 PM

#

so then

north osprey Apr 30, 2021, 4:46 PM

#

@sharp bough I can try to get you a code snippet. Give me a moment.

vast quest Apr 30, 2021, 4:46 PM

#

if (protocheck == null && !protocheck.isEnabled()) { this will trigger if its NOT installed

#

right

quiet ice Apr 30, 2021, 4:47 PM

#

Now it is

wraith rapids Apr 30, 2021, 4:47 PM

#

yes

vast quest Apr 30, 2021, 4:47 PM

#

Ok

wraith rapids Apr 30, 2021, 4:47 PM

#

note that you shouldn't import any protocollib classes in the class you're checking that in

#

interacting with classes that don't exist will cause the entire class to blow up before it even gets to your condition

quiet ice Apr 30, 2021, 4:48 PM

#

Well, it might work, but sometimes will not work

wraith rapids Apr 30, 2021, 4:48 PM

#

yeah, imports are kind of a rule of thumb

quiet ice Apr 30, 2021, 4:48 PM

#

It has always been a gamble for me

vast quest Apr 30, 2021, 4:48 PM

#

im just making it so the plugin does not work when protocolib is not installed

wraith rapids Apr 30, 2021, 4:48 PM

#

then add protocollib as a depend in plugin.yml

#

and bukkit will check it for you

vast quest Apr 30, 2021, 4:48 PM

#

I did

wraith rapids Apr 30, 2021, 4:49 PM

#

and not enable your plugin at all if it isn't enabled

vast quest Apr 30, 2021, 4:49 PM

#

oh so I dont even need to do that

#

ok.

wraith rapids Apr 30, 2021, 4:49 PM

#

instead it will throw some arcane and fucking unintelligible exception

#

which is going to result in 300 1 star reviews on your resource page

north osprey Apr 30, 2021, 4:49 PM

#

@sharp bough

IntStream.range(0, totalLimits)
  .map(index -> Main.get().getConfig().getInt("bedLimits." + index + ".limit")

wraith rapids Apr 30, 2021, 4:49 PM

#

"plugin doesn't work"

sharp bough Apr 30, 2021, 4:49 PM

#

north osprey <@!199697125372723200> ```java IntStream.range(0, totalLimits) .map(index -> ...

uh

glossy scroll Apr 30, 2021, 4:49 PM

#

young knoll What packet

In NMS its called PacketPlayOutFlying i believe

#

But its the movement packet

sharp bough Apr 30, 2021, 4:49 PM

#

that looks even worse than what im using lol

wraith rapids Apr 30, 2021, 4:50 PM

#

in md5 mapped nms yeah

sharp bough Apr 30, 2021, 4:50 PM

#

its fine i can figure it out thanks tho

wraith rapids Apr 30, 2021, 4:50 PM

#

md can't name things

north osprey Apr 30, 2021, 4:50 PM

#

It doesn't involve mutating a list...

glossy scroll Apr 30, 2021, 4:50 PM

#

And basically i just always set the onGround boolean to true with jump boost 128

north osprey Apr 30, 2021, 4:50 PM

#

Every opportunity to avoid mutating state is worth considering...

glossy scroll Apr 30, 2021, 4:50 PM

#

wraith rapids md can't name things

I wish we just go to mojang mappings lol

wraith rapids Apr 30, 2021, 4:50 PM

#

paper is going to

#

soon ™

glossy scroll Apr 30, 2021, 4:51 PM

#

Jealous but im loyal to spigot

wraith rapids Apr 30, 2021, 4:51 PM

#

why eat next to a clown when you could dine with a king

glossy scroll Apr 30, 2021, 4:51 PM

#

LOL

quiet ice Apr 30, 2021, 4:51 PM

#

I'll stay loyal to not using nms

glossy scroll Apr 30, 2021, 4:51 PM

#

Paper is the clown

wraith rapids Apr 30, 2021, 4:51 PM

#

you're the clown

north osprey Apr 30, 2021, 4:51 PM

#

xD

glossy scroll Apr 30, 2021, 4:51 PM

#

:(

young knoll Apr 30, 2021, 4:51 PM

#

Player Movement on wiki.vg

#

Interesting

glossy scroll Apr 30, 2021, 4:51 PM

#

quiet ice I'll stay loyal to not using nms

What if i said everything uses NMS mwahahahaha

wraith rapids Apr 30, 2021, 4:52 PM

#

yeah, the packet name belongs to a long list of examples like

#

VillagePlace

glossy scroll Apr 30, 2021, 4:52 PM

#

LOL

wraith rapids Apr 30, 2021, 4:52 PM

#

and entityJoinedWorld

quiet ice Apr 30, 2021, 4:52 PM

#

I don't care about the impl

glossy scroll Apr 30, 2021, 4:52 PM

#

and Effect.STEP_SOUND

#

that one is one of the worst

#

Its in bukkit too

wraith rapids Apr 30, 2021, 4:52 PM

#

we can't even change it

#

because it would break backwards compat with the 1.8 plugins

glossy scroll Apr 30, 2021, 4:52 PM

#

Yes exactly

#

Maybe deprecate and just add a new one unless that breaks something, not checked l

#

But it’s definitely top 10 worst names

wraith rapids Apr 30, 2021, 4:53 PM

#

the enchantment and potion effect names are also cancer

glossy scroll Apr 30, 2021, 4:53 PM

#

lol true

#

They used to be worse

#

Same with material

#

DIODE

wraith rapids Apr 30, 2021, 4:53 PM

#

iirc they're cancer because those used to be their internal names or something at the time

young knoll Apr 30, 2021, 4:53 PM

#

The entire material enum

wraith rapids Apr 30, 2021, 4:53 PM

#

yeah the material enum is a fucking travesty

glossy scroll Apr 30, 2021, 4:53 PM

#

Yea material still is cancer

young knoll Apr 30, 2021, 4:53 PM

#

And yes, Mojang had some strange internal names

glossy scroll Apr 30, 2021, 4:53 PM

#

Accept Choco’s pr when?

wraith rapids Apr 30, 2021, 4:54 PM

#

we changed the material enum to conform with vanilla item and block names

young knoll Apr 30, 2021, 4:54 PM

#

Until emerald was added, diamonds were emerald internally

wraith rapids Apr 30, 2021, 4:54 PM

#

and look at all of the hoops we had to jump through to get there

glossy scroll Apr 30, 2021, 4:54 PM

#

we need the registry system choco has

#

Desperately

wraith rapids Apr 30, 2021, 4:54 PM

#

the entire fucking plugin bytecode of a plugin running a legacy api version is rewritten prior to plugin load now

#

just to weed out some legacy material names

#

it's fucking ridiculous

young knoll Apr 30, 2021, 4:54 PM

#

But backwards compat

glossy scroll Apr 30, 2021, 4:54 PM

#

1.18 should be the great spigot reqrite

#

Similar to 1.8

wraith rapids Apr 30, 2021, 4:55 PM

#

it breaks a hundred times more shit than just changing the material names alone would have