help-development

[upper hazel]

but marker not detected

[crude zephyr]

good thing i did it before the full relese of the server to the public

[mortal vortex]

when am i getting an invite to this server, ahah

[crude zephyr]

whenever you want

[mortal vortex]

dm

[crude zephyr]

since youve helped so much

sent dm

[upper hazel]

maybe i shoulde use boundbox?

hashing this not good idea for locations?

[thorn isle]

location generally has excess information for what you need to represent a location; specifically, it includes pitch/yaw

so two locations at the same location are not the same location if their "direction" is different

if that doesn't make sense to you, that's because it doesn't

[upper hazel]

bruh

thenks

[thorn isle]

if you don't need floating point precision for the coordinates, you can use Block as the key, just remember to clear the block references on world unload since they strongly reference the world they're in

if you don't need world information but need floating point precision, you can use bukkit Vector

for anything else you'll want to define your own class/record to use as key and implement hashcode/equals on it as desired

e.g.

public record Position(World world, float x, float y, float z) {}

[upper hazel]

world can be null?

like player

[thorn isle]

any reference can be null

it if shouldn't be null you can annotate it with @NotNull which will on a best effort basis emit compile time warnings if you try passing something that is or might be null to it

e.g. @NotNull World world

[upper hazel]

i mean

world can guaranteed itself notnull in runtime?

for example when player leave player object can be null

so need use uuid every method args

[thorn isle]

you are mixing concepts a bit here but yes, the same principle does apply to worlds, though it is much rarer for worlds to not be present

[upper hazel]

so i need use world name then

[thorn isle]

for example if you try doing Bukkit.getWorld("myworldname") before a world named myworldname is loaded, it will return null

[upper hazel]

wolrd loading before onEnable

[thorn isle]

you can use UUID in place of World in the record, yes, that will be more robust

[upper hazel]

not?

[thorn isle]

not necessarily

e.g. multiverse loads worlds in its onEnable

[pliant hill]

hello

[upper hazel]

lol arl thenks

[thorn isle]

so if your plugin loads before multiverse and your world is loaded by multiverse, it won't be loaded yet

[ivory sleet]

You can use compiler hacks like lombok or w jetbrains annots to enforce nonnullness (it injects checks)

Or you can use checkers nonnullness framework to prove that ur code isn’t null in certain parts

[thorn isle]

this is particularly catastrophic for serialized Locations because they're deserialized from your plugin config when you load the config, typically in onEnable, and if the world they're in isn't loaded yet, you will have a bunch of null-world locations in your config

[ivory sleet]

But otherwise, almost anything can be null ilmir, Java sucks due to this

[thorn isle]

skill issue

[ivory sleet]

120%

[upper hazel]

So ihave to think of all the objects in bukkit as ones that could disappear at any time.

[thorn isle]

no, that's not what null means

[pliant hill]

can you run papermc plugins on folia

[ivory sleet]

Well not really, if a reference points to an object, it won’t magically stop pointing to that same object

[pliant hill]

and is folia better than paper?

[ivory sleet]

somewhere there has to be a “ref = null” kinda thing

[thorn isle]

imo folia is snake oil

[upper hazel]

yea...

[pliant hill]

what is that supposed to mean

[thorn isle]

it's something you apply to a snake so its scales don't fall off

[slender elbow]

you'd think

[ivory sleet]

folia can be better, if utilized correctly

[slender elbow]

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/Location.java#666-669

[pliant hill]

jhmm

so do papermc plugins run on folia?

[thorn isle]

is that new?

[slender elbow]

no

[ivory sleet]

Some do, most need to be modified since folia requires plugins to properly synchronize

[thorn isle]

weird

[pliant hill]

ah

[thorn isle]

maybe i was deserializing from json myself or something

[pliant hill]

so I'll just say on Paper

[thorn isle]

i ended up like subclassing it with PersistentLocation or something that'd hold the world UUID and do the Bukkit.getWorld call in Location::getWorld

[ivory sleet]

If the plugin claims to support folia, that’s probably ur green flag

[thorn isle]

quite a few large plugins already do "support" folia

[pliant hill]

My server has 83 Plugins

Don't think most of them are gonna be supporting folia

[ivory sleet]

“Support” 😭🙏

[thorn isle]

though i'm a little bit skeptical about how proper that support is, as things are very easy to get catastrophically wrong in a threaded environment

just because it compiles and you mass-replaced your bukkit.getscheduler calls to whatever entity scheduler folia added, doesn't mean it actually works as intended

[pliant hill]

Am I too dumb to understand or are you speaking 🤓 language

[thorn isle]

yes

[ivory sleet]

Yea I mean its also hard as a plugin to not oversynchronize, as in keeping the granularity on ur locks balanced

[pliant hill]

okay

anyways can someone reply to my question in #general

[ivory sleet]

He basically says, plugin devs == clumsy wizards => they dont support folia properly even though they think they do

[pliant hill]

ohh

alright

[thorn isle]

i.e. it will probably load and work for the most part but there could be for example dupe exploits introduced by the changes

[mortal vortex]

You're in the development channel lol

[pliant hill]

right thank you

[pliant hill]

makes sense

[echo basalt]

this menu code might genuinely be some of the worst I've ever made

I might emulate all the logic to make it less ass ngl

[blazing ocean]

I bet that'll make it even worse

[echo basalt]

nothing worse than 1000 lines of bullshit fuckery

I tried separating the actual contents from the display items and I broke the container synchronizer

[blazing ocean]

what if it was 1000 lines of larky's bullshit fuckery

[echo basalt]

https://paste.md-5.net/ecezupikat.java

peak code

[blazing ocean]

what the fuck

[echo basalt]

atp might be worth emulating

[echo basalt]

I've got no clue why commenting out the synchronizer code magically fixes all my issues

doing this the manual way is a huge pain in the ass

[slender elbow]

have you considered a change in career

like carpentry, or husbandry

[blazing ocean]

work on @remote swallow's farm and send me catpics daily

[echo basalt]

fts I'm not gonna do it that low level

just gonna make some button that emulates it

it's like 10 lines instead of 1000

[remote swallow]

No

[glacial narwhal]

How can i listen to a command being used?

[sly topaz]

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/player/PlayerCommandPreprocessEvent.html

don't use it to make commands, though. For that use the CommandExecutor API

[glacial narwhal]

No, its to listen to a player getting op don't worry

[sly topaz]

if you're trying to restrict players from using commands, you're better off using a permissions plugin for that

[glacial narwhal]

No, its to give an item to the player getting op

[sly topaz]

I see, that should be fine then

[glacial narwhal]

Any ideas how i could get the player / args & the command name

[sly topaz]

you just get the message from the event and split by space

first element on the array would be the command name and the rest would be the arguments

[glacial narwhal]

is there the / in the message?

[sly topaz]

I honestly don't remember, there could be

try it out

[burnt current]

Is there any way to modify knockback for PVP?

Like say I want to make it so that there's more knockback (goes farther)

I listen to the PlayerVelocityEvent and set the event's knockback but this only works in PVE and not PVP for some reason

[wise mesa]

how do i get the value of a gamerule https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/GameRule.html

is there some method in server or world?

nvm think i found it

i assumed it would be in server but of course gamerules are per world so it is in world

makes sense

[young knoll]

That’s a craftbukkit thing

Fancy

[blazing ocean]

didn't paper make them per-world?

[young knoll]

No

[blazing ocean]

huh

thought they were the ones doing that

[wise mesa]

is there a way to check if a world has a gamerule

im trying to make something compatible with both the minecart experiments and not the minecart experiments

and GameRule.getByName returns a value whether the experiments are enabled or not

and world.getGameRuleValue does not return null if the world doesn't have a gamerule but instead throws an exception

[young knoll]

Check the FeatureFlag

[wise mesa]

hm

[young knoll]

Specifically world.getFeatureFlags().contains(FeatureFlag.minecartthingy)

[wise mesa]

okay well what if I want to make this future compatible

assuming this will one day be implemented

i guess I can do world.getGamerules or whatever and do a linear search

but then I'd probably want to cache that somewhere

ugh

[young knoll]

The feature flag isn’t going anywhere

I assume the deprecated ones are always included? Idk

[left jay]

hey so question, when i call this slash method, from a plugin that depends on a separate damage plugin, that damage plugin returns null when trying to create its own damage key. any1 know wassup? i have it saved as a dependancy in my pom.xml and and plugin.yml

[thorn isle]

oooor don't worry about trying to futureproof it and just update it when things change

the thing about the future is that it's unpredictable

[left jay]

whoops put the same image twice

[thorn isle]

are you shading it into your jar

90% of cases where you're trying to get another plugin's instance and it's null, you are either shading in that plugin's classes into your own plugin jar, or you forgot to include it in depends in your plugin.yml

[torn shuttle]

remind me, how do I detect a right click on air?

[left jay]

no, i dont have it shaded in my pom.xml, im pretty sure

[torn shuttle]

or I guess just

a right click

under any circumstances

[thorn isle]

open up your jar and doublecheck

[thorn isle]

i don't remember if the client sends any packet for right click on air with an empty hand

[torn shuttle]

seems like interactevent does according to docs

but defaulted as false

sorry cancelled I mean

[thorn isle]

you can try it but i'm not 100%

[torn shuttle]

worth a shot I guess

[left jay]

yep i dont

[thorn isle]

and you have it listed in the depends of your plugin.yml

[left jay]

yep

[thorn isle]

check the logs and see if that plugin enabled correctly

[left jay]

yep it does

[thorn isle]

what happens if you try Bukkit.getPluginManager().getPlugin(pluginname) instead of that static instance getter

i mean you presumably can't change the code for DamageKey, but try calling ^ in your plugin and see what it returns

[left jay]

so i made an if else to check if its not null and apparently it isnt null

[thorn isle]

see if it returns true for isEnabled

then try getClass() on it and compare it to DamagePlugin.class

if you have the source code for that class or your ide can decompile it, check if the author made a boob setting the static instance field or something

[left jay]

wait no i made the plugin lol

[thorn isle]

then doublecheck it all the more

[young knoll]

The client doesn’t send anything if you right click air with an empty hand

[blazing ocean]

just create an empty item

[young knoll]

But what if I don’t use a resource pack

Actually

Can you use air with custom_model

[blazing ocean]

possibly

[blazing ocean]

then fuck you ig

[sly topaz]

air isn't a model but a texture

but I do wonder

[young knoll]

Technically it’s neither

[sly topaz]

technically it is a texture, rhetorically it is neither

ig the lack of a model counts as a model

[young knoll]

ig the lack of a texture counts as a texture

[sly topaz]

well, there is a texture, no?

which is just a transparent png

for the item at least lol

[young knoll]

Maybe?

I know for the block the game just doesn’t render anything

Obviously

[left jay]

it is enabled, but not the same as DamagePlugin.class
i dont actually know what that means tho

[pseudo hazel]

there is no texture for air

[sly topaz]

then I must be misremembering

[pseudo hazel]

it has an item model

this is whats in it: {}

[young knoll]

Should work then

Also why does mcasset now have an ad

They did a redesign and now there’s a banner ad

[pseudo hazel]

interestingly the block model for air is also an empty json

[young knoll]

But iirc Mojang told them they couldn’t run ads on it

[pseudo hazel]

🤷‍♂️

[blazing ocean]

https://github.com/misode/mcmeta/tree/assets

[thorn isle]

that means someone is shading it into their jar

[young knoll]

Yeah ik

But there’s also the inventive website

[wise mesa]

I ended up going with this solution

since I'm pr-ing a plugin that supports back to 1.14

easiest option

[young knoll]

What is that recursion

Single time recursion but still

[left jay]

but it litterally isnt in my maven-shade-plugin part of my pom.xml

[thorn isle]

maven shades everything that isn't marked as provided by default

are you sure you checked in your jar and didn't find the classes there?

like open it in winrar or whatever and physically look at what's inside it

[left jay]

ok im gonna double check again, maybe im blind

[left jay]

oh shit i am blind, there it is

[thorn isle]

it could in theory also be some other plugin including the class, you can call DamagePlugin.class.getClassLoader().toString() to see which plugin loads it i think

not relevant here since you found the shade but might be useful in the future

[left jay]

well now that i found the shade how can i remove it? i tried deleting it but it just came back up when i restarted the server

[thorn isle]

let's see your pom.xml

[left jay]

ignore the censoring

[wise mesa]

must avoid code duplication at all costs

[thorn isle]

deepseek

did you have chatgpt generate this for you

[wise mesa]

nah i just didn't feel like putting the second two clauses a second time

er last two clauses

[left jay]

chatgpt has a problem with file pasting, apparently

[thorn isle]

    <dependency>  
        <groupId>com.github.Somebodys-home</groupId>  
        <artifactId>DamagePlugin</artifactId>  
        <version>c0d40b42cf</version>  
    </dependency>  

here is your problem

add a <scope>provided</scope>

the default scope is compile which means it will get included in the jar by maven shade plugin

provided means it will be "provided" by the runtime and not included in the jar

[left jay]

ok good news, i got it working but i do have a question
i updated some stuff about the damage plugin i was depeding on and when i changed the version and reloaded my plugin, the plugin was back in the .jar file. any reason why that happens?

[chrome beacon]

Make sure you're using the plugin jar without a suffix

[thorn isle]

let's see your new pom.xml

and make sure you do mvn clean package, if you omit the clean, you may be including stale classes in the jar

[burnt current]

So, when running code on a PlayerVelocityEvent (to alter knockback when it happens):

event.setVelocity(newVelocity);
does NOT work in PVP. works only with PVE.

but
event.setVelocity(new Vector(0,0.5,0));
WORKS FULLY ALWAYS.

Does anyone have any idea why?

[warm mica]

newVelocity isn't what you think it is

[burnt current]

newVelocity is a vector I have calculated and it says exactly what it should say

I take the original event's velocity, shrink it, and then set the events velocity to that

But in PVP, somehow the player will just take no knockback instead of modified knockback

Meanwhile zombies and skeletons etc. cause the correct amount of knockback to the player

Unless I manually specify a knockback in the code instead of calculating one... Then for some reason it works even in PVP

I don't understand

why is (0,0.5,0) ok but something more precise like (0.18674,0.2523,0.67362) is treated as (0.0,0.0,0.0)?

[young knoll]

You probably have to delay a tick

[burnt current]

And only with PVP... Otherwise both are fine

[young knoll]

As to why one of them works, /shrug

Also there’s a knockback event

[burnt current]

Wait is there actually?

Maybe I be using deprecated code and that's why 💀

[young knoll]

EntityKnockbackEvent

[burnt current]

I'm gonna try to use that then

Apparently I don't have that

Was this added recently?

[young knoll]

Define recently

[burnt current]

In the last few years

I'm using 1.19.4

[young knoll]

Well at least it isn’t 1.8

But yes I believe it was added in 1.20

[burnt current]

Oh

[burnt current]

I don't think I can do this actually. If I delay a tick, aren't I just letting the event run without me modifying the knockback at all?

[young knoll]

Yes

Until the next tick at least

[burnt current]

But then won't the knockback packet have already been sent to the player?

[young knoll]

Yes?

[burnt current]

So you aren't modifying it because you can't do that after the fact

[young knoll]

You can?

Knockback is just velocity

Sending another velocity packet a tick later will then update their velocity again

[burnt current]

So after the player has started their knockback trajectory, you can just come back and change it? And it won't look jank?

[sly topaz]

Well, if it isn’t timed properly or there’s latency to consider, it may look jank

But if it is just the next tick then it might be just fine

[burnt current]

I see

Unfortunately I think a lot of my players would notice, they don't have the best latency

[sly topaz]

Well, try it

If it does get affected by latency we can think of something else

[burnt current]

Well there's also the chance that it just doesn't fix this at all

And if it does, then there's the question of "why does it need 1 tick delay in PVP but not PVE"

And the answer is probably that something else is wrong that I'm missing and the problem will probably still pop up again occasionally

[sly topaz]

Player knock back might be treated differently, let me get into my computer and check

I’m the meantime, it’d be good if you could make a MRE so we can try to reproduce it

(MRE = Minimal Reproducible Example)

[burnt current]

Ah... I'm not sure I could make an MRE out of this but I know how to print variables that could possible narrow down what's going on.

Well

I can get something actually hold on

https://gitlab.com/Zettelkasten/armorweight/

This is the plugin I'm trying to fix

My code cleans up a few things, but the bug happens in this plugin without code changes as well

[young knoll]

Can’t you use the attribute for this

[sly topaz]

Did the attribute exist in 1.19

[young knoll]

Yeah

[burnt current]

Attributes exist... But I think by using them I would lose the functionality where if the plugin is removed and then you join the server it doesn't remember your previous attribute

[young knoll]

You could remove it when they leave

And add it on join

[burnt current]

Like it's permanent until you change it back

Oh

Hm

Ok

I guess I just need to figure out the math then

[sly topaz]

Use a multiplier operation on the attribute btw, don’t change the base

[burnt current]

Oh yeah those exist

I actually have never used those, how does that work?

[slender elbow]

doesn't spigot expose transient attribute modifiers?

[burnt current]

https://github.com/PaperMC/Paper/issues/9243

Interesting....

Ok this might be literally exactly what I need

Just need to find documentation on how to use 1 vs the other

[young knoll]

That’s a thing? I don’t think we do?

[crude zephyr]

i did a thing
would this give a player blindness for 10 seconds on respawn?

[slender wadi]

I’m trying to get world edit to work on realms but idk what to do. Help?

I cannot make a server, because my computer isn’t strong enough to run a server, so I have to use Java’s realms

So don’t ask me why I didn’t just make a server

[crude zephyr]

why are you asking about realms here in spigot #help-development ?

[slender wadi]

I’m new and I can’t find a chat that seems to be what I’m asking for

[crude zephyr]

okay, minecraft realms is vanilla, no mods, you cant host mods on realms

also spigot runs plugins and not mods

but you can get world edit for spigot

[slender wadi]

I thought it was a data pack

My friend sent me this https://dev.bukkit.org/projects/worldedit

Do plugins not work on vanilla ?

[chrome beacon]

They do not

[slender wadi]

Shit

[crude zephyr]

thats a plugin

[slender wadi]

I guess he was wrong idk

But I guess I won’t be getting world edit

[young knoll]

No

[slender wadi]

Damnit

Bye.

[young knoll]

That’s 10 ticks not 10 seconds

[crude zephyr]

ohhhhh

[slender wadi]

Thanks for the help, though.

[young knoll]

Also you need to delay the code by a tick in the respawn event

Iirc

[crude zephyr]

so i would do 200 ticks (10 seconds) then?

[young knoll]

Yes

[crude zephyr]

cool

ima try figure out how to delay then

[chrome beacon]

?scheduling

[undone axle]

https://www.spigotmc.org/wiki/scheduler-programming/

[crude zephyr]

btw i do have instant respawn on

like so?

i feel like ive done something wrong

because DreamDeath is underlined red

brb going to make waffles for friends bday
ping me when replying please 🙏

[sly topaz]

what is DreamDeath here

a variable?

[crude zephyr]

i didnt know what to put

sorry

[worthy yarrow]

An instance of your plugin

[sly topaz]

you need to put your plugin's instance there

aka, an instance of the class that extends JavaPlugin

if that is DreamDeath class, then you either pass the instance around in this class's constructor or make a singleton

dependency injection approach:

public class DreamDeath extends JavaPlugin {

  @Override
  public void onEnable() {
    new YourEventListener(this);
  }
}

public class YourEventListener implements Listener {
  private final DreamDeath plugin;
  public YourEventListener(DreamDeath plugin) {
    this.plugin = plugin;
  }

  @EventHandler
  public void onDeath(PlayerRespawnEvent event) {
    Bukkit.getScheduler().runTaskLater(this.plugin, () -> {/* do stuff */}, 1);
  }
}

Singleton approach:

public class DreamDeath extends JavaPlugin {

  private static DreamDeath INSTANCE;
  public DreamDeath() {
    INSTANCE = this;
  }

  @Override
  public void onEnable() {
    new YourEventListener();
  }

  public static DreamDeath instance() {
    if (INSTANCE == null)
      throw new IllegalStateException("Plugin isn't loaded")
    return INSTANCE;
  }
}


public class YourEventListener implements Listener {

  @EventHandler
  public void onDeath(PlayerRespawnEvent event) {
    Bukkit.getScheduler().runTaskLater(DreamDeath.instance(), () -> {/* do stuff */}, 1);
  }
}

[crude zephyr]

hi sorry i got to go, ill try working on it tomorrow!
thanks tho

[manic delta]

multiply it to ticks

[paper viper]

10 seconds = 10 seconds * 20 ticks / second = 200 ticks
You need to pass 200 ticks, and also you might have to do it in a scheduler because the player object might not be valid for a few ticks

[undone sphinx]

Hi I'd like to customize the appearance of the GUI by applying my own textures I’ve been working with the GUI code but haven’t found a straightforward way to integrate external images or textures into the interface elements.

Is there any way to apply custom textures to GUI components? If so, could someone point me in the right direction or provide an example of how to do it?

[drowsy helm]

https://www.spigotmc.org/threads/custom-inventory-uis-updated.635897/

I made this post a while ago about the topic

[undone sphinx]

this is look so difficult

is there another way?

like API?

[blazing ocean]

no

[sly topaz]

it just looks difficult but it is actually not that hard to get the hang of

[mellow edge]

Is there a more efficient way of finding an item in a player's inventory and modifying it (its lore) than iterating through all the inventory slots and finding it. You cannot store them in a collection because they will get added to the inventory as a copy anyway. This is needed because ofc we'll have more players at the same moment to modify the items. (all players have the same set of items that need to be modified). I don't want to re-add new items because of the adding animation.

[echo basalt]

What have you tried?

[mellow edge]

My idea was to not let the items out of a specific slot thus knowing the location. It ig works but I hate the idea.

[echo basalt]

Can you come up with any other solutions?

[mellow edge]

I could do some hashmap weird index stuff

[echo basalt]

Would the complexity of it outmatch looping over 45 items?

[mortal vortex]

Map<String, Integer> that maps item types to their current slot positions would work?

[echo basalt]

String

[mellow edge]

O(1) time execution would be ideal but I don't think is possible without really weird stuff

[wispy egret]

if I put this in a command block it doesn't work
give @p minecraft:diamond_sword{Unbreakable:1b,Enchantments:[{id:"minecraft:sweeping",lvl:1000s},{id:"minecraft:knockback",lvl:1000s},{id:"minecraft:fire_aspect",lvl:1000s},{id:"minecraft:mending",lvl:1000s},{id:"minecraft:sharpness",lvl:1000s},{id:"minecraft:looting",lvl:1000s}]} 1

[echo basalt]

#help-server

[mellow edge]

Idk it just hurts me to have 16 * 5 players having 45 slots checked concurrently

[echo basalt]

I don't recall if you can do it in spigot but in the other one you can check PDC without getting the item meta

It's a bit more performant

[mortal vortex]

lol "the other one"

cannot be named

[echo basalt]

If you care about updating things in a chest you'll still need to track it

https://paste.md-5.net/oposipakit.java

At least this is how I do it at work

[mellow edge]

Thanks I'll check it out

[echo basalt]

add just a little bit of tracking and you can get something pretty convincing

[mortal vortex]

what HUD element do you offset for those 3 slots on the right there?

[echo basalt]

magic

(I'm not revealing my secrets)

[mortal vortex]

LOL

[mellow edge]

Ig indexing is much better. You see O(n) approach would be even worser due to the fact that I need to look for 8+ items per player

[echo basalt]

you can index the inventory once and then look for the items but that's needlessly complex for just a getPDC -> getItemId -> do whatever

• dupe potentials when dropping items

you can do it in stages

loop through inv -> map out item ids to slots -> get item ids at slots -> update them

but that's not faster than just updating as you find

public interface ItemProcessor {

  Optional<ItemStack> process(ItemStack input);

}

Use the optional to prevent updating the gui

[mortal vortex]

True computer scientist

you could not imagine how many plugin developers dont look at optimizations in the long run

[mellow edge]

How much?

[echo basalt]

we're looping over 45 slots it's nun crazy

tracking each individual item will cause so much cpu overhead

[mortal vortex]

i mean i've seen many plugins do shit which just looks like it wasnt planned for servers with more than 50 concurrent users, but it makes sense why they stay small

[echo basalt]

not the case here

doing IO in the main thread and saving all the player data to a single giant .yml file is not what we're talking ab

[mellow edge]

Inject an item with a tag with PDC (each item has different id), do iteration once per player and check the ids of items, if we finish early -> break

[mortal vortex]

gang.. i know that.

I meant, being mindful on time complexity is not something I've seen much of witth plugin developers (with exceptions of bigger names)

[echo basalt]

public void processPlayer(Player player) {
  PlayerInventory inventory = player.getInventory();

  Map<UUID, Integer> itemsForProcessing = new HashMap<>();
  ItemStack[] contents = inventory.getContents();

  for (int index = 0; index < contents.length; index++) {
    ItemStack item = contents[index];

    if (item == null || item.isEmpty()) {
      continue;
    }

    UUID itemId = ...;
    
    if (itemId != null) {
      itemsForProcessing.put(itemId, index);
    }
  }

  if (itemsForProcessing.isEmpty()) {
    return;
  }

  for (Map.Entry<UUID, Integer> entry : itemsForProcessing.entrySet()) {
    UUID itemId = entry.getKey(); // You can replace the UUID with an itemstack or something, or just contents[slot]
    int slot = entry.getValue();
  }
}

[echo basalt]

in most cases it just doesn't really matter

Premature optimization is the devil and you shouldn't worry too much about it until it become a problem

[mortal vortex]

wise

[echo basalt]

If I'm scanning millions of blocks I'll worry about performance, sure

if I'm looping over 45 slots once in a while I really won't care

Especially when we're only talking about 16 players

would be worse at 50x that

and even then it's probably fine to do it async

[mellow edge]

Your example would need to check for slot changes no?

[young knoll]

No enhanced for loop? :(

[echo basalt]

we need the index

[echo basalt]

run it once in a while

[young knoll]

Ah I see it now

I always forget inventories are iterable

[echo basalt]

type shit

[mellow edge]

Wouldn't that be less efficient than iterating once when needed.

[mortal vortex]

shit

[mellow edge]

So I think I have 2 options:

• iterate once per player when needed (easy)
• track indexes

[echo basalt]

sure go ahead

call it whenever

[mellow edge]

Nice, thanks for help

[north ferry]

it can be actionbar texture, just i guess

[undone sphinx]

@drowsy helm what is map mean?
So, how is it done?
So what exactly is this method I hear you asking? Simple! Unicode textures.

Minecraft supports a character system called unicode, this allows us to map a texture to a character within the unicode range.
Minecraft resourcepacks allow us to map these textures through the default.json file within the fonts directory of a resourcepack.
Note: This can be done outside of default.json but for our purposes we will keep it simple.

[mortal vortex]

Map means to connect things together basically.

Connect A and B

So what he means there is, use a sample Unicode character, and associate a texture with it through the font

[left jay]

sorry i didnt respond, but its the same thing but with the provided scope declared

[drowsy token]

to display entity movement on 1.20.4 client, i use ClientboundMoveEntityPacket.Pos. but it just add move distance to the position previous one,not sync position.server sync position to client after i hurt the entity only.i want to know which packet that server using to sync entity position to client?

is it using ClientboundSetEntityDataPacket and package SynchedEntityData in a list,then send it to client to sync position?

[shrewd solstice]

where can I get the spigot api to make my plugin?

[north ferry]

you can with maven or gradle

<repositories>
    <!-- This adds the Spigot Maven repository to the build -->
    <repository>
        <id>spigot-repo</id>
        <url>https://hub.spigotmc.org/nexus/content/repositories/snapshots/</url>
    </repository>
</repositories>

<dependencies>
    <!--This adds the Spigot API artifact to the build -->
    <dependency>
           <groupId>org.spigotmc</groupId>
           <artifactId>spigot-api</artifactId>
           <version>1.21.5-R0.1-SNAPSHOT</version>
           <scope>provided</scope>
    </dependency>
</dependencies>

this for maven

[low marlin]

Does anybody has any good packet learning tutorials with protocollib?

[umbral ridge]

PlayerCommandSendEvent is only fired on player join right? So... what if I want to dynamically update an available list of commands during the gameplay? How would I do that

[echo basalt]

oh boy

[echo basalt]

the Pos packet sends relative movement, not absolute

[echo basalt]

Entity metadata has nothing to do with position, look for any "entity teleport" packets

[echo basalt]

I made one back in the day but it isn't really that great. What would you like to know? I'm noticing a trend in people switching to PacketEvents as protocollib has been buggy and "outdated"

[echo basalt]

look for the syncCommands method, might not be present in spigot

[umbral ridge]

huhh thank you very much

[echo basalt]

or updateCommands or something

[low marlin]

I'm trying to create scoreboard packets that will display in the sidebar

[umbral ridge]

that is perfect

[low marlin]

I have 0 knowledge in packets so I basically want to learn

[echo basalt]

I don't see why you can't do it without the API

[low marlin]

using nms?

[umbral ridge]

yeah i need it because player ranks can change during the gameplay and with that permissions change too

[echo basalt]

spigot's scoreboard system

[umbral ridge]

i have made PlayerGroupChangeEvent so i'll call it in there

[low marlin]

I have 2 different plugins that both use scoreboard and they collide

they don't work together

[umbral ridge]

waittt but how does updateCommands() work exactly? does it read plugin.yml command permissions? and based on .... whatt???!!? does it call the event again?

Right now I do that

basically

[drowsy token]

I tried to use teleport packet, but the entity seemed to twitch during movement, so I gave up using teleport packet and switched to using relative movement packet instead

[echo basalt]

It resyncs brigadier commands

should be used when, for example, you update the command map

[hard perch]

Is it possible to listen to packets without using external libraries ?

[shrewd solstice]

and, I'm using eclipse, how can I build my plugin?

[chrome beacon]

Yeah just do what the libraries do and hook in to the netty channel

Not worth the effort though

[umbral ridge]

yeah.... but how can you retrieve the command map, current commands available to the player? at runtime.. not on join

and modify it exactly as you want?

[echo basalt]

Bukkit.getCommandMap

[echo basalt]

the libraries have to do it somehow

(with nms and injecting into the netty channel)

[umbral ridge]

is that per player?

[echo basalt]

No

You're the one tracking that

[umbral ridge]

ohh. i though it would be simpler... because i have made this.. and i though that i could just update the list of commands in here?

this is just a sample... yeah.. how the heck do you track that?

if i store the command map somewhere on join event, i can't modify it later on

can i

but i've tried this and it didn't work... because i would need an actual method to retrieve the current command map for specific player

[north ferry]

I think Eclipse is deprecated

[umbral ridge]

https://tenor.com/view/drcox-scrubs-head-gif-4862594

[north ferry]

You should try IntelliJ IDEA Community Edition

[young knoll]

It’s not deprecated

[shadow night]

"eclipse is deprecated" hits hard tbf

[hard perch]

If you use maven, you just have to right-click on your project and click on run as > maven install

[shrewd solstice]

yeah I found how to do it

thx

[umbral ridge]

now it works. PERFECT!!!!

[echo basalt]

you fucking what

Bukkit.getPlayer(playerId)

[umbral ridge]

https://tenor.com/view/fadding-cat-dance-gif-15524768750287997468

[umbral ridge]

that's old code

[echo basalt]

you wrote it in the first place

[umbral ridge]

I still do

why would I need to use the name instead of uuid

server isnt in offline mode

now it works

[echo basalt]

player.isOnline will always return true

[umbral ridge]

really

[neon gull]

who can make recource packs for minecraft

[chrome beacon]

Don't post in all channels

[buoyant viper]

getPlayer can take a UUID 😭

?jd-s

[undone axle]

https://hub.spigotmc.org/javadocs/spigot

[fierce cave]

is it better to code spigot plugins in kotlin or java?

[echo basalt]

Realistically kotlin is a more modern language but java will result in better help

If you're a server owner and you decide to write your codebase in kotlin you're pretty much closing yourself to 80% of your potential candidates

[fierce cave]

ohh

so should i like code spigot in java

[echo basalt]

Ideally yes especially if you haven't mastered it

You can dabble in kotlin but you'll usually be on your own

[fierce cave]

i mean i know java pretty much coded many plugins in it but new to kotlin

[buoyant viper]

write Scala

[fierce cave]

what

[buoyant viper]

i did not stutter.

[sullen marlin]

Clojure or gtfo

[sly topaz]

Me and the boys do plugins in jython 😎 💪

[pale remnant]

Anyone here able to give advice on a server running slow? I have a sparks report

[buoyant viper]

well it would probably help if u sent said spark report

also this is for plugin development [mainly] so unless u think its ur own plugin slowin down, #help-server

[mortal hare]

doesn't private constructor in this case violate open-closed principle?

public class Foo {
  // imagine `bars` is a variable which is really internal collection which shouldnt be mutated outside, but could be inside of this class.
  private final Collection<Bar> bars;

  protected Foo(Collection<Bar> bars) { // which one should i choose: public, protected or private?
    this.bars = bars;
  }

  public static void create() {
    // Special logic goes here before creating foo.
    return new Foo(new ArrayList<>());
  }
}

protected seems like a compromise for future code extensions, but now you have responsibility to keep this constructor alive for people who are subclassing this externally

public is like fuck the safety, we're going C route

private kinda breaks open closed principle if you think pragmatically

[pseudo hazel]

maybe, but who cares

maybe it needs to be broken for the class to make sense

like singletons

[mortal hare]

the more i do software engineering, the more i hate it™

Dovias, 2025

[pseudo hazel]

the curse of overengineering

[mortal hare]

for me

software engineering is full of paradigms that are broken and contradictory to each other

[pseudo hazel]

yes

because different problems require different solutions

there are no 5 rules you can write for software that can always be followed

[young knoll]

What would curse of binding 5 entail

[mortal hare]

i would say the biggest problem for me personally is expect what future holds for the code

i can write code that just works for today but i dont know how much tech debt that code might incur in the future

that's the most painful of engineering for me

[pseudo hazel]

yes

thats probably the hardest thing ever

because its always changing

requirements are always changing, your own experience and ways t do things are always changing

my code from like 1.5 years ago looks ass

but my codebase is never big enough for it to be a real problem

refactoring should be a big part of the normal programming flow

sadly

[slender elbow]

nooo not sadly, it's what guarantees me a salary :kekw:

[pseudo hazel]

well yeah

I guess it depends who you are talking too

but I like refactoring too

[young knoll]

Refactoring? We don’t have time for that

We have to ship by next week!

[pseudo hazel]

haha exactly, and thats the other side of the equation 😛

hate refactoring because of the idea that it takes time that noone has

but funnily enough usually the codebase that got scrambled together the fastest has the longest refactor time

[mortal hare]

i feel like this can never go wrong if you provide factory methods anyways

full encapsulation is rigid imho

and doesnt adapt to the context of class use

[echo basalt]

The only way to guarantee pure immutability is to make the variable private and copying the list into an immutable collection in the constructor

[mortal hare]

its like with react components too, you have component which needs specific margin on the element to position it correctly

its either you dump full encapsulation and add class attribute which allows you to inject custom css classes on top of already predefined classes in component
or you wrap component in a separate <div> container with flexbox and gap. but that essentially bloats the html structure with useless notations

[echo basalt]

the factory method might just sanitize inputs

make the constructor protected if you plan on having the class extended, make it private (and the class final) if you don't

[mortal hare]

or just make public and dont bother

[echo basalt]

then skip the static factory method entirely

[mortal hare]

why? what if its specific implementation of class i want to reuse somewhere?

with specific dependencies

[echo basalt]

then you apply dependency inversion and yeet the factory method to the interface

make a skeleton class with a traditional constructor

Use the factory method to pick the impl based on the parameters

best of both worlds

public interface ElementContainer extends Iterable<Element> {

  ...

  static ElementContainer create(Element... elements) {
    ...
  }

  static ElementContainer create(Iterable<Element> iterable) {
    ...
  }
  
}

public abstract class SkeletonElementContainer implements ElementContainer {

  protected SkeletonElementContainer(...) {
    ...
  }
}

look at List.copyOf for inspiration ig

[sly topaz]

it is usually pointless to worry about this unless you're working with a team

whatever tech debt one might incur from code they make themselves is manageable enough when they're already proficient enough with the language

the rest is just understanding the problem space and understanding what needs to be adapted in order to continue expanding that space

and to understand the problem space, you just have to code your way through it, no better way than that

[north ferry]

because when a player change his username uuid keeps same iirc (if online mode is true)

[ivory sleet]

I mean the open closed principle is like “closed for modification but open for extension” I don’t follow SOLID rigorously, but I have done it in the past, and my experience with that principle is that its a perspective trying to ensure reusability and independent redeployment. Let’s say you’re running a microservice architecture with many smaller jar files that have the ability to be independently redeployed w/o recompiling ur entire system.

On another note, I think its important to consider scope with this principle, seeing as private would only allow extension within the same class-file, and as u are aware sometimes public is used to provide visibility for testing.

But to answer your question, no it doesn’t- at core object oriented programming was a bout sending messages from sender to receiver, depending on the receiver type, the message may be interpreted one way or another (polymorphism). This in conjunction with procedural programming where we emphasize the scope of our code components, reusability by isolation and abstract away global state and data.

[buoyant viper]

oh hey im also working on a UI framework rn

but for the client

its really fucked

[echo basalt]

I just gave a random example

I'm not writing awt from scratch again

[buoyant viper]

LOL

no yeah i want to Kms rn

[young knoll]

Aren’t there some good gui libs for the client

[buoyant viper]

probably

but wheres the fun in not reinventing the wheel?

[buoyant viper]

i wish i could do math on Number objects

[blazing ocean]

purple made a NumberWrapper class that does all that shit super quickly

[remote swallow]

Who's purple

[blazing ocean]

idk

[umbral ridge]

my dog

[rough ibex]

your dog is purple?

[umbral ridge]

PlayerInteractEvent only works for RIGHT_CLICK_BLOCK and not LEFT_CLICK_BLOCK

If I left click the block with the axe, isn't that supposed to be LEFT_CLICK_BLOCK? or maybe its considered block breaking? because I'm in creative and it instantly breaks the block?

PlayerInteractEvent doesn't even fire if I left "click" the block with the axe..

doesn't even work in survival

[sly topaz]

what's the code

even if it is considered block breaking, it should trigger an interact event

[umbral ridge]

fixed it

it was an unusual bug

now it's time to ☕ 🚬

[sly topaz]

don't crosspost

[drowsy helm]

#help-server

[undone sphinx]

does anyone know how to apply custom enchantment ? Right now, I have the GUI working and I can detect the item and the click event, but I'm not sure how to properly apply a custom enchantment

[drowsy helm]

What mc version?

They changed it recently

[undone sphinx]

1.21.5

[sly topaz]

if the enchantment has been properly registred, you'd get the enchantment from the registry and then just apply it like any other enchantment with ItemMeta#addEnchant method

[drowsy helm]

https://www.spigotmc.org/threads/1-20-2-how-do-you-register-enchantments-now.629029/

[sly topaz]

with the registry being Registry.ENCHANTMENT

[sly topaz]

they're looking to apply one, not to register it

[undone sphinx]

it's working with advancedenchantment plugin?

[sly topaz]

wait, are you developing a plugin?

Because if not, then this is a question for #help-server

[drowsy helm]

Given that they dont know how to apply it. Im assuming they done know how to register it either

[undone sphinx]

yeah i'm developing plugi

[sly topaz]

I mean you can just use a datapack for the registration and hope it works lol

[sly topaz]

https://ae.advancedplugins.net/for-developers/plugin-api

just use their API if you're using their plugin to create enchantments

[undone sphinx]

yeah i'm a little bit confuse about import this api

i don't know how to import this one to my build.gradle

it's different from other

[sly topaz]

since they just give you a jar, you need to import the file itself

https://docs.gradle.org/current/userguide/declaring_dependencies.html#3_file_dependencies

[undone sphinx]

thank!

uhh..

[sly topaz]

what did you put in your build.gradle

[undone sphinx]

i'm using kotlin dsl

[sly topaz]

is the jar in the libs folder?

[blazing ocean]

and did you reload gradle

[sly topaz]

the class seems to be AEAPI, not sure where you got AdvancementEnchantmentsAPI from

[blazing ocean]

that's a nice class name

AEAPI

[sly topaz]

I smell AI-generated code 👻

[undone sphinx]

net.advancedplugins.ae.api

this one?

[sly topaz]

just copy whatever is in their wiki

[undone sphinx]

it's red

[sly topaz]

then import it

[undone sphinx]

thank!

[mortal vortex]

maybe he saw "AEAPI" and figured to expand the acronym lol

but uh---- maybe also ai

[sly topaz]

probably

well, I can't fault anyone for trying to use AI in this case, but if there's a wiki available then at least copy it into the prompt so the AI has any idea what you're on about

[urban cloak]

How would you sync inventories between servers connected via velocity? Make it a velocity plugin and request it from the old server, send it to the new one and then transfer the player?
Or Have it run on the server and save it to some database when the player leaves and hope its saved before it gets loded by the server the player transfers to

[robust helm]

database locks exist

is there any reason to sync inventories in velocity though?

[blazing ocean]

you're not gonna have a fun time if you decide to do this on the proxy

[urban cloak]

I thought so

[sly topaz]

can it even be done at the proxy level, I don't think you have an inventory information there

[blazing ocean]

you do not

[urban cloak]

Then id need to hope the lock is created before the data is accessed

[sly topaz]

unless you send it through plugin messages or just lookup a database

[urban cloak]

Idk how quickly velocity does all that

[blazing ocean]

not sure if plugin messages are ideal there

[urban cloak]

Yeah cause they dont have a request/response kinda pattern

[sly topaz]

anything that can communicate between servers should work fine

[blazing ocean]

I'd probably just go for some message broker

[sly topaz]

I would personally just make velocity keep them at configuration phase till the database lock is lifted

[blazing ocean]

yeah

[young knoll]

But what if it takes more than 30 seconds!

[urban cloak]

But i think the time between the Client disconnecting and the check for that lock might be too short for the lock to be created

Idk how velocity does that

[sly topaz]

that's why you keep them at configuration phase

[young knoll]

If they are transferring from server to server you can just delay the transfer

[sly topaz]

explode the current server

[young knoll]

If they disconnect and reconnect you’ll have to hold them somewhere

[robust helm]

isnt it possible to have an always-active lock and then just unlock it after saving the inv?

[urban cloak]

Hmm

[mortal vortex]

would absolutely hate having to use a closed source API

[sly topaz]

a database operation like that should take a few miliseconds at best anyway

without taking into account latency

[young knoll]

But my database is on Pluto

Saves me money on server cooling

[blazing ocean]

smart

[urban cloak]

Or message broker and update the inv as soon as a message comes, i think joining the world takes long enough so you cant dupe

[sly topaz]

have you considered existing solutions

[urban cloak]

No

[sly topaz]

there must be a cross-server sync plugin out there

ah well the only option that came up with google is premium so yeah

it is source-available tho, so you can take inspiration from it at least

[urban cloak]

I found husk sync but i would need it to be for fabric

But i guess i can take inspiration from them

Oh husksync is for frabrix

[young knoll]

Compile it?

[sly topaz]

it works on fabric and spigot, yeah

[sly topaz]

disingenuous

if I am going to use it for a production server, I'll at least have the decency to buy the plugin

[young knoll]

if it’s open source they clearly expect people to do that ¯_(ツ)_/¯

You pay for support

And convenience

[sly topaz]

I mean, if I am just a kid making a server for my friends, I can see why one would prefer to just compile it

but if I am actually using it in a server where I make money, I don't see any reason to not contribute to the project by buying the plugin, regardless of whether one needs the support

[urban cloak]

When one server goes down and the player leaves and joins the one that was down before, i need to save the inventory somewhere

I cant use a queue then

[sly topaz]

if a server goes down then you got bigger problems than the inventory I imagine lol

I'd just save the inventory periodically as well as on-demand when someone leaves/switches a server

[worthy yarrow]

True dev right here lol

[fossil wigeon]

is there perchance some form of event that triggers when a new day starts on a world? I wanted to avoid the plugin having to constantly check the world age

[worthy yarrow]

I don’t remember how to get there, but the world should already track time and I thought there was api to play with. That being said just make your own event and call it whenever

[sly topaz]

just check it every tick, no need to make it complicated

[azure vault]

this is my old code from 1.20.?:```java
public static ItemStack setNBT(ItemStack item, String key, String value) {
net.minecraft.world.item.ItemStack nms = CraftItemStack.asNMSCopy(item);
NBTTagCompound tag = nms.w();

tag.a(key, value);
nms.c(tag);

return CraftItemStack.asBukkitCopy(nms);

}

[fossil wigeon]

well I believe the world does keep track of global time, but I wanted to avoid having to constantly check whether that time is now a new day

[sly topaz]

what are you using NBT for

[azure vault]

my goal is to be able to write some key-value to the itemstack and retrieve it later (without adding it to the lore of the item)

[sly topaz]

why though, a task timer isn't expensive by any means

[worthy yarrow]

It’s not a very demanding thing, can check like every 10 ticks

[sly topaz]

you're better off using PDC for that

[worthy yarrow]

Even 1, like it’s really not even close to being anything bad in the sense of performance

[sly topaz]

?pdc

[undone axle]

https://www.spigotmc.org/threads/a-guide-to-1-14-persistentdataholder-api.371200/

[azure vault]

thanks

[worthy yarrow]

And also there is no event so you will have to track it yourself

[sly topaz]

me asf PRing a TimeTickEvent right now

[worthy yarrow]

I was gonna say

[azure vault]

this is exactly what i was looking for!

[worthy yarrow]

Feels like that one’s not bad at all, and actually makes sense to have kek

There’s plenty of useless mojank approved api points

[sly topaz]

It'd be just a pretty way to make a task timer honestly

even worse considering it'd trigger for every world that ticks lol

[worthy yarrow]

Well I feel like if this were an event, time would be sync across all worlds yeah?

[sly topaz]

why would that be the case

time on world a isn't necessarily the same as world b, I could've created world b later in the server lifetime and they'll have inherently different world time

of course, you could sync them but that's often too meddlesome

[worthy yarrow]

A, so you’re not ticking every world + event doing god knows what with other listeners, and B, I just feel the event implies it’s a rather global tick event, what are we passing the event in the first place? And to my knowledge, if we’re passing and holding a world reference that’s just bad anyway so keep it lighter right?

Point a, you’ve essentially just made another player move event

[fallow gyro]

Hi. Is there a way to track a moving entity with an end crystal beam? Set beam target doesn't seem as smooth as the beams look while tracking an ender dragon. Thanks.

[sly topaz]

https://www.spigotmc.org/threads/laser-guardian-and-crystal-beams-1-9-1-20.348901/

[fallow gyro]

I saw this, but would this still work for end crystal beams?

[sly topaz]

the post mentions both end crystal beams and guardian lasers

[fallow gyro]

Cool. I'll look into it a bit further in that case. I appreciate the help.

[sly topaz]

tbf it doesn't seem to be doing anything special

just setting the beam target every tick should work as well

it does use packet for the end crystal instead of spawning an actual end crystal but eh, I don't think that makes any difference

[undone sphinx]

uhm does anyone know why the enchantbook i get from my custom gui with ae apply enchantment from this snippet code: doesn't work?

` for (int slot : selectedEnchantSlots) {
EnchantmentData enchantData = slotEnchantmentMap.get(slot);
if (enchantData != null) {
enchantedBook = AEAPI.applyEnchant(enchantData.getName(), enchantData.getLevel(), enchantedBook);
}
}

    inventory.setItem(COIN_SLOT, enchantedBook);
}`

[smoky anchor]

I bet you enchanted the book instead of storing the enchant lol

You gotta use EnchantmentStorageMeta to make books work

[undone sphinx]

yeah i try it

doesn't work

it's advanced enchantment

[smoky anchor]

idk what that means

[undone sphinx]

i create a gui for put a scripture and then you can select an enchantment from gui and you will get an enchantment book

[smoky anchor]

ask whoever made that thing then

[sly topaz]

it is a premium plugin so they should have some kind of support channel

[undone sphinx]

no they won't

[sly topaz]

they have a discord tho

what's worse is that they don't seem to have registered the enchantment properly, otherwise you wouldn't have to do custom logic for the anvil

[pure dagger]

i made an inventory when you can put an item, when you clsoe it you get the item back. but when server is stopped it deosnt call the InventoryCoseEvent i guess?? when i start the server again the item is gone.

should i just close every inventory at onDisable() by iterating through all players?

[sly topaz]

you could do it at player quit rather than on disable

but I am surprised disconnecting doesn't call inventory close, probably a bug

consider reporting it to the JIRA

[pure dagger]

uhm

im not sure its not called but the item disappears

so i geuss

it is not

[sly topaz]

well, you can test it

[pure dagger]

yep

by logging that

it didnt print anything

not playerquit and not inventoryclose

its disabling my plugin first

then it says i left

xD

[pure dagger]

so no

[sly topaz]

that shouldn't be possible

the first thing that happens when one does /stop is players being kicked, not plugins being disabled

[pure dagger]

uhm

?

[sly topaz]

that's really weird

are you using spigot or paper?

[pure dagger]

spigot

cause i know ?whereami 🙄

[sly topaz]

latest version?

[pure dagger]

1.21.5

[sly topaz]

if you are using Paper then you have to report it to Paper, no other way around that

[pure dagger]

i said im not

[sly topaz]

well then just report it to the JIRA

[pure dagger]

whhat is that

[sly topaz]

?jira

[undone axle]

https://hub.spigotmc.org/jira/secure/Dashboard.jspa

[pure dagger]

what do i do in my code

close on onDisable

?

[sly topaz]

sure, that works in the meantime, but it is ultimately a bug for plugins to be disabled before the players are kicked

[pure dagger]

isnt that the same issue

[sly topaz]

what's the link

[pure dagger]

https://hub.spigotmc.org/jira/browse/SPIGOT-6621?filter=10108&jql=text ~ "disabling before"

[sly topaz]

while the cause is the same, the resolution for that bug and yours is different

in your case, you'd be asking for the players to be kicked before the plugins are disabled, that way the events are called properly. While that bug report is asking to change the behavior of the plugin loader to allow for access to plugins being disabled upon shutdown

[surreal talon]

Hi , how to get requirement for sell plugins on spigot ? i mean what is the condition ?

[sly topaz]

?premium

[undone axle]

https://www.spigotmc.org/threads/premium-resource-guidelines.31667/

[wet breach]

why would you need to iterate through all the players if you created the inventory to begin with? do you not have a list of opened inventories?

[pure dagger]

i do but hwat?

does it tell me whcih players have it opened?

[wet breach]

then just itereate the inventories and close out your objects and call world.save()

[pure dagger]

how do i close inventory from inventory instnace

[pure dagger]

why world.save?

[sly topaz]

InventoryView#close

you shouldn't save the Inventory instance but the InventoryView since that's the actual opened inventory though

[wet breach]

idk what kind of inventory you have, if you are making use of one that would save to the world then you need the world to save to preserve the inventory

[pure dagger]

so it closes this inventory for everhy player which has it opened?

[wet breach]

otherwise you need to save your data

[pure dagger]

if 2 players open 1 inventory is it 2 inventoryviews?

[sly topaz]

could be, it all depends on how you open that inventory

[pure dagger]

no, its custominventory, its ment to disappear

i dont know ;c

[wet breach]

no it is 1 inventoryview

[sly topaz]

if you open the InventoryView, then it'll be an inventory with 2 viewers, if you open the Inventory itself, then it'll create another InventoryView

[wet breach]

^

[pure dagger]

🤯

[wet breach]

anyways, you should be saving the inventories every so often

in case you can't do it at server shutdown

[pure dagger]

i dont need them

to be saved

[pure dagger]

i need the player's inventory at the bottom

why would i use inentoryview??

[buoyant viper]

reinventing the wheel go Brrrrrrr

[blazing ocean]

what are you making.........

[buoyant viper]

ignore the fact that its a cheat i just needed a codebase

was making a UI framework

[blazing ocean]

mhm....

[mortal vortex]

Am gaining so much respect for you

You should see my latest bypasses. mmmmm

[sly topaz]

I've lost count at how many UI frameworks for minecraft there are

they usually don't pass the test of time

if you can manage to maintain it over a long period of time, it should already be better than 99% of the ones out there

[mortal vortex]

meteor has a nice UI. It’s not really a framework since it’s just dynamic entries done for each module with very little configuration. But it just looks clean

[sly topaz]

meteor the client?

[barren peak]

Is there a way to disable the number shown above the xp bar (as if you were level 0) but still be able to use the bar as if you were a higher level (have more increments)?

(I'm trying to use the xp bar to represent other things and I'd like it to show many increments as if it was a high level xp bar but I don't want a number to show up above it)

[echo basalt]

✨ packets ✨

might do

[barren peak]

yeah :/ any way without packets?

[echo basalt]

or you can get away by doing some resource pack funkery

[sly topaz]

not without resource packs, no

oh wait, I misunderstood what you meant, you can do it with packets, yeah

but no, not any way without packets

public void setPlayerExperience(Player player, float experience, int level, int totalExp) {
    var packet = new WrapperPlayServerSetExperience(
        experienceBar, 
        level, 
        totalExp
    );
    
    PacketEvents.getAPI().getPlayerManager().sendPacket(player, packet);
}

setPlayerExperience(player, 0.0f, 0, 0);

pretty easy with packetevents though

[barren peak]

interesting- is packetevents a plugin/dependancy?

[sly topaz]

it is a minecraft library

you can check it out here, and here: https://github.com/retrooper/packetevents

[barren peak]

yeah alr i'll look into it, ty

[pure dagger]

should calling player.closeInventory(); in onDisable call InventoryCloseEvent ??

cause it doesnt

[ivory sleet]

I think it does, will def happen if u run /reload no?

but maybe not on shutdown tho

[pure dagger]

it doesnt ;c

its 1.21.5

idk whats wr4ong with this version

[mortal hare]

?mappings

[undone axle]

Compare different mappings with this website: https://mappings.dev/

[pure dagger]

what is that

[sly topaz]

it is a bug introduced by the automatic library support feature, you should just report and wait for it to get fixed, should be fairly fast

[pure dagger]

;-;

ok so manually...

[mortal hare]

its basically a dictionary which translates mojang names for methods between different server software

[sly topaz]

if it is just for your server, you could do a quick patch yourself tbh

[mortal hare]

due to how mojang obfuscated their method names for minecraft server sometimes its very handy to compare them to see what it means

[sly topaz]

it should be just moving the statement that kicks all players before the plugin disabling logic

[mortal hare]

or if you're doing reflection stuff

[pure dagger]

not for my own

[mortal hare]

its basically google translate for NMS code

[pure dagger]

how where

[sly topaz]

if it is for a public plugin then just wait for it to get fixed

[pure dagger]

its for someone but they wont wanna wait soo

ill just do it manually instead of in the event

[sly topaz]

just save the inventory periodically then

only real option

[pure dagger]

but i dont wanna save it ??

[mortal hare]

In vanilla native minecraft server Grindstone menu class is for example named: net.minecraft.world.inventory.GrindstoneMenu, but on spigot its net.minecraft.world.inventory.ContainerGrindstone

[pure dagger]

closei t

close it

[pure dagger]

but was the link ment to ssave my problem ?

[sly topaz]

weren't you trying to save it since whatever item you were handling disappears?

[pure dagger]

i dont understand

or was it just for you

[sly topaz]

I think they're talking about something different

[mortal hare]

no it was just for my use, i did call the bot for myself

lol 😄

[pure dagger]

just take the item, give it to player

and i dont need the inventory

anymoere

[pure dagger]

yep

but what do you mean they'll fix it? will i have to use buildtools to generate 1.21.5 spigot again ?

[sly topaz]

yes

well, rather. It'll get fixed if you report it

if you don't report it then it'll just go unnoticed like it has now

md usually picks up bugs like these pretty fast so that's why I am saying it should be fixed relatively fast but I don't know their schedule so it's all speculation

otherwise, it is a free PR

[distant hazel]

hey guys i am currently working on a civilzation server with 4 differnt contients like desert,jungle,snow and plains . i wanted to give one of these roles to a player joining for the first time and teleport them to their respective contitent . i have tried some plugins but it doesnt seem to work.can anyone help with a working method?

[umbral ridge]

https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/Sound.html#valueOf(java.lang.String)

how am I supposed to use Registry.getKey

what is NamespacedKey

how does it convert to a sound enum

eg.: I want to parse a string into a Sound object

[sly topaz]

NamespacedKey is just a key with a namespace, i.e. minecraft:ambient.cave or whatever the sound is called

I don't remember whether sounds use dot or underscore but yeah

to get a sound by their namespace, you'd do it like this Registry.SOUNDS.get(NamespacedKey.minecraft("whatever"))

[sly topaz]

are you developing a plugin to do this? Otherwise this is a question for #help-server

[distant hazel]

oh sorry my bad

[slender elbow]

both

ambient.basalt_deltas.additions

[sly topaz]

well that's fun

[slender elbow]

but that's only because the biomes and entities have underscores in them

[umbral ridge]

that makes things much more complicated

and takes time

[sly topaz]

how is it more complicated

[umbral ridge]

i have to go through entire list of strings instead of suggested enum list

and check whether they have _ in it or not

i have to make some kind of wrapper for this

this is dumb

[sly topaz]

registries are iterable

so you can just collect all sounds into a List

[umbral ridge]

hmm

where can i find the list of minecraft... sounds?

i don't even know the format of the string

[slender elbow]

the wiki

[umbral ridge]

minecraft:sounds.<sound name> ?? what

[slender elbow]

or iterate the registry

[sly topaz]

Registry.SOUNDS.stream().limit(10).forEach(System.out::println);

you can do that for example

it'd be more helpful if we knew what you were trying to do with the sounds

[pure dagger]

hm, but is it server jars fault?

cause if i do this manually, and then this will get fixed, tha thing will happen 2 times, 1 on onDisable(), 2. in the event

[sly topaz]

I'd consider it a bug, since you should be able to listen to some of these events even on shutdown

[sly topaz]

does it matter

[pure dagger]

so server jars fault

[pure dagger]

yep

[sly topaz]

well, that's ultimately up to MD, we won't know till the bug report gets marked as accepted

[pure dagger]

uhm

[sly topaz]

that's why I told you to report it

the sooner you report it, the sooner it'll get fixed

[pure dagger]

oky

[umbral ridge]

I'm just trying to get the string from the config -> try to parse it into a Sound object -> play it to the player

I can't find anything on the wiki with the list of sounds

am i blind

[slender elbow]

then you don't need to gather any list of strings

[umbral ridge]

or is there nothing

[slender elbow]

yeah

the article is literally called Sounds.json

and then every individual article for every entity and block has a list of sounds they play

[kind hatch]

On the minecraft wiki

https://minecraft.wiki

[umbral ridge]

i didnt even know this existed

[sly topaz]

if you're just parsing them off a configuration or something, then you can just do something like this:

public Sound getSound(String value) {
  var key = value.indexOf(':') == -1 ? NamespacedKey.minecraft(value) : NamespacedKey.fromString(value);
  return Registry.SOUNDS.get(key);
}

that's all you have to do to parse it

you may put a try in there for invalid keys but other than that, yeah

[umbral ridge]

yea

thank you for that

[buoyant viper]

i was actually just looking at exp related stuff, https://hub.spigotmc.org/javadocs/spigot/org/bukkit/entity/Player.html#sendExperienceChange(float,int)

[sly topaz]

welp, I'll be damned

there was an API way to do it lol

[fallow gyro]

Apologies if this isn't the correct place to ask about other plugins, but I'm experiencing the following issue using ProtocolLib:

[19:57:41 WARN]: Exception in thread "Thread-8" FieldAccessException: Field index 0 is out of bounds for length 0
[19:57:41 WARN]:        at ProtocolLib.jar//com.comphenix.protocol.reflect.FieldAccessException.fromFormat(FieldAccessException.java:49)
[19:57:41 WARN]:        at ProtocolLib.jar//com.comphenix.protocol.reflect.StructureModifier.write(StructureModifier.java:318)
[19:57:41 WARN]:        at fireworks-1.0-SNAPSHOT.jar//com.dnamaster10.fireworks.ExplosionInstruction.execute(ExplosionInstruction.java:24)
[19:57:41 WARN]:        at fireworks-1.0-SNAPSHOT.jar//com.dnamaster10.fireworks.ShowRunner.lambda$run$0(ShowRunner.java:98)
[19:57:41 WARN]:        at java.base/java.lang.Thread.run(Thread.java:1583)

A snippet of the problematic code is as follows:

PacketContainer explosionPacket = new PacketContainer(PacketType.Play.Server.EXPLOSION);
explosionPacket.getDoubles()
  .write(0, position.getX())
  .write(1, position.getY())
  .write(2, position.getZ());
explosionPacket.getIntegers().write(6, 3);

protocolManager.broadcastServerPacket(explosionPacket);

From what I can tell, my code appears to match that of the examples on the GitHub repository for ProtocolLib. Does anyone know why I might be getting an out of bounds exception for this type of packet, when the examples seem to be able to modify these values perfectly fine?

Thanks, and please redirect me if there's a more-relevant channel to post this question.

Edit: The error is being thrown for the first write call, write(0, position.getX()).

[echo basalt]

Check the packet's nms definition

it's likely you won't see any double fields

if you do protocollib L

[left jay]

hey so when i imported my custom damage plugin, whenever i try to use any of the methods in there i get this nomethodfound error. how can i be sure that the version of the plugin im importing is the same one thats being used by the server?

[drowsy helm]

Do you have teh actual damage plugin in your server

or shaded if thats how it's intended

That error just means it's not in the current runtime

[left jay]

yep, its actually there

[drowsy helm]

only other reason that would show is if you have an old dependency of that plugin and they have changed method names/package

[left jay]

nope, no name changes here

[drowsy helm]

and it's 1000% loaded in and enabled on the server?

because that doesn't make sense

And you’re not doing any package relocations

[vocal cloud]

does it have it has a dependency?

[left jay]

yes