so to me it would be a waste of time
#help-development
silver robin
could I have some examples in an open source plugin (that's preferably not too large) please?
worthy yarrow
could I have some examples in an open source plugin (that's preferably not too l...
Uh I’m pretty sure you just do saveConfig
When updates are needed to be made
quasi gulch
https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/inventory/meta/SkullMeta.html#setOwnerProfile(org.bukkit.profile.PlayerProfile) Does the Method SkullMeta.setOwnerProfile involve a blocking Web Request to Mojang if only the name is given or will it only look up the players that are online?
wet breach
https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/inventory/meta/SkullMeta.htm...
if they don't exist in the player data then it will do a lookup
quasi gulch
so i should to run it async?
silver robin
Uh I’m pretty sure you just do saveConfig
i'm not quite sure you understood me, when you have a config.yml within the resources in your jar, and call JavaPlugin#saveDefaultConfig(), it will copy it to plugins/<plugin name>/config.yml, however if you release a new version of your plugin, where the config.yml has some new properties, they won't get copied over
tardy delta
what a noob \🤓
worthy yarrow
i'm not quite sure you understood me, when you have a config.yml within the reso...
This doesn’t make any sense to me, it should put every config path/value that you have…
I’ve never had an issue like this before
kind hatch
could I have some examples in an open source plugin (that's preferably not too l...
I don't have any plugins that do this, but the idea is simple.
Iterate over your config while comparing to the new one and write any new sections that don't exist using FileConfiguration#set() and then save the file.
worthy yarrow
And you have to do this?
kind hatch
Yes
#saveResource() gives you two options
Overwrite the file, or don't.
So you can't get fine grain control
quasi gulch
https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/inventory/meta/SkullMeta.htm...
Is there a method that doenst make a web request and just gives a exeption or some stuff so i dont need to run it async?
worthy yarrow
Odd, I’ve never had an issue like that before, every time I add new config options, I just put ‘em in my config startup method and everything “new” gets added
kind hatch
But how? That's never been the case with the API.
Are you sure you weren't using some other library to handle the files?
undone axleBOT
worthy yarrow
But how? That's never been the case with the API.
Are you sure you weren't using...
https://paste.md-5.net/sigejisufi.cpp
This is pretty much what I do every time, any new config options I just add and it writes it in next reload
kind hatch
Ah, you use the other approach.
worthy yarrow
Copy default (true) ?
kind hatch
Copy default (true) ?
Tbh, I don't know much about the config options.
I've always used the direct approach.
tardy delta
kind hatch
FileConfiguration loading from disk
silver robin
Ah, you use the other approach.
yeah I came across that while browsing online too, however it seemed bizarre to me that I have to have specify a default value in code. But I realised it might just be the best to loop through plugin's own config.yml that comes in the jar, and then add the defaults to the existing config.yml from plugins folder and call copyDefaults
worthy yarrow
I guess I never realized there was a “direct” approach lol
I’ve also never had to deal with vcs so maybe that’s another issue
kind hatch
But here's the other thing.
That only works with the default config afaik
If you have any other files that need updating, you don't get those benefits.
tardy delta
i have no idea what this is about, too much people yapping
worthy yarrow
i have no idea what this is about, too much people yapping
Flat files and stuff and things
silver robin
started from here lol
here are some related links from the web:
wet breach
i'm not quite sure you understood me, when you have a config.yml within the reso...
just rename the config in the plugins directory
then call that method
old configs are saved, new configs are used
worthy yarrow
That’s smort frost
kind hatch
old configs are saved, new configs are used
They want existing values that have been changed to exist in the new config.
If you just copy over the new config, you won't have any of the existing changes.
worthy yarrow
Wouldn’t the new ones be “overriding” the old ones as it were?
worthy yarrow
Man whatever this “direct approach” is, I don’t like it kek
kind hatch
If they new ones don't exist, then technically yes.
But any ones that already exist shouldn't be touched. (Even if the default has changed)
wet breach
but, its generally not worth the effort to implement diffing
its just easier to rename the old config, use the updated new config then let the user handle it from there
if the user is too stupid to modify the configs they shouldn't be running a server
not sure why dev's want to put the effort into trying to automate everything as if its somehow better that way lol
kind hatch
Well, if the config options aren't there then the plugin would likely error out if they didn't use the methods that provide fallback values.
wet breach
what config options?
worthy yarrow
https://paste.md-5.net/sigejisufi.cpp
This is pretty much what I do every time,...
That’s why I’ve always just done this
kind hatch
The ones they want to add/update.
wet breach
they should be in the config included with the jar
worthy yarrow
That’s why I’ve always just done this
What’s the difference?
kind hatch
That’s why I’ve always just done this
I have to look more into this.
worthy yarrow
Other than just having easy fallback values
kind hatch
Maybe there's a way to leverage it
wet breach
probably
but eventually you end up with a big class file of nothing of updating values
when you could just....install a new config file
worthy yarrow
Why even do that, just use the existing one no? In the way I do it, /myplugin reload will save the new values
kind hatch
Yea, but what if the config file is large and heavily modified?
I think it's a nice thing to have where all of those changes I have made I don't have to redo every single time there's an update.
wet breach
Why even do that, just use the existing one no? In the way I do it, /myplugin re...
it depends how much changed. But as I said it is generally not worth coding a diffing mechanism all because you want to save your user from having to update their config stuff themselves
kind hatch
Yea, but what if the config file is large and heavily modified?
I think it's a n...
Especially strings/messages.
worthy yarrow
I don’t even see a point in automated config updates, in the sense of wanting a concurrent state of config values, automation makes no sense to me
wet breach
I don’t even see a point in automated config updates, in the sense of wanting a ...
I basically said this
wet breach
all that is happening is you are taking the time and effort the user would put in, quadrupling it and you are putting that time and effort in so they don't have to
and if its a free plugin
even more pointless to go through all that trouble lol
the troll that needs slapping has appeared at the perfect time
@worthy yarrow you can now let your nuclear fustrations out
merry cove
hey, am struggeling to find the right dependency to hook a later version (dev build) for protocollibs. is that even a thing that I can hook the alter one simply using a dependency? or do I need to build it in if so?
worthy yarrow
<@478547445937078283> you can now let your nuclear fustrations out
Fortunately I’m on vacation, that’s one of the reasons I’m here!
worthy yarrow
hey, am struggeling to find the right dependency to hook a later version (dev bu...
I had that issue too, idk why it wouldn’t let me use the latest even tho its listed on the git
merry cove
might try to add the jar file directly in then
worthy yarrow
Perhaps that will work, I just settled for the most recent (before latest)
merry cove
am updating my codes to 1.20.6 😐
worthy yarrow
Eek
kind hatch
You know, I think if #setDefaults() is easy enough to understand and actually works in the way I think it does, then I might be able to update the wiki.
Because if it does provide the ability to set default values without changing existing ones, then I think everyone who made their own systems just didn't realize how it worked in the first place. Me included :kek:
worthy yarrow
You know, I think if #setDefaults() is easy enough to understand and actually wo...
I’m pretty sure it does kek
wet breach
You know, I think if #setDefaults() is easy enough to understand and actually wo...
it sets it in memory if I recall
worthy yarrow
Like I said that paste is the way I’ve always done it, then to induce the changes I give the user a reload command
worthy yarrow
Should I look into cleanup of config memory?
kind hatch
Cause here's my initial thoughts right.
A lot of people have files in their plugins. More than just the default config.
#addDefaults() is accessible through FileConfiguration.
So in theory, we could take the existing files in the resources folder, iterate over the sections and use #addDefaults on them to update the existing config.
Which would negate the need for a complex diff comparison.
worthy yarrow
There’s no theory about it if it’s accessible through fileconfig, why would it be different just for the default config?
fleet kraken
Hi guys, where can I get the direct download link for a plugin on spigot?
worthy yarrow
(Download now)
chrome beacon
Are you trying to wget or curl a plugin
worthy yarrow
Yeah what Olivo said
fleet kraken
Are you trying to wget or curl a plugin
yes
fleet kraken
(Download now)
thats not the directly download link
worthy yarrow
thats not the directly download link
I didn’t realize there was a more direct link kek
mellow edge
thank you it actually worked. I have no clue how tho, the entity isn't registered anywhere...
fleet kraken
Use the Spiget api
thanks
chrome beacon
thank you it actually worked. I have no clue how tho, the entity isn't registere...
the client knows about the entity
That is all it needs
mellow edge
oh, yeah, that makes sense, so basically even if the server has no clue what I am doing, the client does
worthy yarrow
oh, yeah, that makes sense, so basically even if the server has no clue what I a...
I would run under the assumption that it should it doesn’t always work first try :p
mellow edge
I just registered it by a deprecated method OfflinePlayer, then set the nametagvisibility to false and it worked
first try
worthy yarrow
Well now it’s time to rewrite it
mellow edge
why
kind hatch
There’s no theory about it if it’s accessible through fileconfig, why would it b...
Yea, it's what it looks like.
worthy yarrow
why
If it’s deprecation to be removed, then rewrite it, but also because no method should be considered “good” until rewritten a couple times - Bruce eckel (thinking in java 4th series)
mellow edge
yeah that is a minor change, I can just change it to its name
worthy yarrow
Yea, it's what it looks like.
Noice glad my simple ways unlocked an easier path for ya haha
mellow edge
now another problem comes with how to detect NPC click; I assume PlayerInteractManager is for that but I don't know.
tardy delta
why not use Path and the Files api?
mellow edge
may I ask how to listen to incoming packets, the problem is that I don't want to write my own netty handler for that, although I know how, but I just want to somehow get a packet PacketPlayInUseEntity
meager wolf
how do u give a command an optional argument? like this:
if u run /mycommand your "storage" will show up
if u run /mycommand <player> the <player> "storage" will show up, but only if u are an admin
my googling skills are so bad 😭
mellow edge
simple
remote swallow
ruturn different stuff based on the arg and if sender has permission
meager wolf
ruturn different stuff based on the arg and if sender has permission
i dont want the player to see that he can enter an argument if he is not admin
meager wolf
all of that will be in the onCommand method, so when the player enters /mycommand in the chat and clicks space, he will see that he can enter a player name as argument, i dont want that, i only want admins to see it
mellow edge
may I ask how to listen to incoming packets, the problem is that I don't want to...
@remote swallow would you happen to know the answer to my question?
remote swallow
all of that will be in the `onCommand` method, so when the player enters `/mycom...
modify it on tab complete
you have the exact same arguments
inner mulch
Is tracking the player interaction on a packet entity even possible? (server doesnt know abput it)
remote swallow
<@549995524590403595> would you happen to know the answer to my question?
idk about packets
mellow edge
kk
mellow edge
Is tracking the player interaction on a packet entity even possible? (server doe...
so if the client knows it will still send packets about interaction
river oracle
@remote swallow do you know the answer
@remote swallow your role color is different
you must
come on
remote swallow
slag
mellow edge
alr I will just write my own handler and just check
inner mulch
so if the client knows it will still send packets about interaction
Thanks
mellow edge
because I will NOT use protocollib, where is the fun in that?
river oracle
because I will NOT use protocollib, where is the fun in that?
use PacketEvents 💪
mellow edge
maybe if the raw netty channel handler won't work
wraith delta
How do you get the spigot api for 1.20.5/6?
fallow imp
hi, i have my spigot server up and running and it works great for me, i created a port forward for the ip of my server however my friends still cant join, does anyone know what i can do?
mellow edge
OMG IT IS **** WORKING HOW IS IT POSSIBLE?!?!?!?!
stiff crown
hi, i have my spigot server up and running and it works great for me, i created ...
adjust windows firewall settings maybe... otherwise look what the error for him says
fallow imp
his error is just a timeout error
remote swallow
How do you get the spigot api for 1.20.5/6?
go into options and override the java exe
fallow imp
it showed him attempting to join once in the server terminal
wraith delta
go into options and override the java exe
ah man i downloaded java 22 this time and clicked the build tools hoping to open the gui but it ran instead -.- wrong folder
stiff crown
it showed him attempting to join once in the server terminal
thats awkward... do you have both tcp and udp forwarded?
fallow imp
in the cox app i added the port foward set to both tcp and udp for my macs ip address (im using the laptop as the server) and he still couldnt join
mellow edge
something I've never done before, now that I can detect when NPC is clicked with nms, I can add my own spigot event right?
or register it
tardy delta
yes
young knoll
You need a packet listener
alpine urchin
i heard packet
worthy yarrow
I want packet lessons from retrooper
alpine urchin
if compensated, i'd love to provide those.
i'd even give programming lessons
if compensated
that would be more fun
worthy yarrow
I mean
I feel like you’d be better than illusion cuz he’d just yell at you the whole time
worthy yarrow
No
alpine urchin
you know anywhere to get clients
worthy yarrow
I’m reading a book, and have been doing spigot dev for maybe a year
worthy yarrow
I’m reading a book, and have been doing spigot dev for maybe a year
That’s my experience
Though I only say a year because I’ve been doing it on / off the past 4
worthy yarrow
Trooper doesn’t like to converse D:
nova notch
I want packet lessons from retrooper
just fuck around and find out thats how i learn
alpine urchin
that was a pretty random fact xd
@worthy yarrow how you got 1
from on and off 4
just say 4, so it sounds better
worthy yarrow
Sure it sounds better, but for how I write you’d say 1
alpine urchin
When someone says they have 10 years of experience, you can't expect that they dedicated hours every single day.
without skipping a single dya
XD
but i get you
stay dedicated though
don't stop
worthy yarrow
I actually have been doing that since January kek
Only issue is I forgot my computer charger for this trip I’m on, so now I just have to read my book 😦
worthy yarrow
No
storm crystal
can I use my own commands inside code?
fossil flax
is there a way to format an int like 1200 to 1.2K and 2400000 to 2.4M?
worthy yarrow
can I use my own commands inside code?
Elaborate please
shadow night
Why
storm crystal
To save space
acoustic pendant
Hey, could someone guide me on how to reset a world (trying to make a minigame)
I don't get how to do this
slender elbow
<https://github.com/stianloader/slbrachyura/blob/master/brachyura/src/main/java/...
god forbid NumberFormat be used
young knoll
Is there a formatter for that
royal heath
https://paste.md-5.net/efakamewad.cpp
You could also do this, I just ripped this up. It should work for versions lower than Java 12. There are likely better ways at this but this is readable
You could use an array with an index as well
slender elbow
Is there a formatter for that
sure
NumberFormat.getCompactFormat() + setMin/MaxFractionDigits
royal heath
He might want to throw it into a variable and do .setMinimumFractionDigits(decimalPlace); if he wants 1234 to be 1.234k
royal heath
@quaint mantle Put a \ in front of the quote. Regarding your question in general
quaint mantle
Yeah I figured it out, thanks.
royal heath
No problem
quaint mantle
Did intellij update their dark theme?
quaint mantle
I was used to their old Darcula UI
but, i swear
they changed the theme
to be darker
and have circular stuff
which
is amazing
royal heath
Yeah it’s really nice now. I still have the old one on my work pc I need to update it there.
I like the old one in its own ways so I keep it lol
quaint mantle
The old UI is probably the best in my opinion
royal heath
New one is sleeker but old one has a place in my heart
quaint mantle
It makes me think of VS Code @royal heath
nova notch
The old UI is probably the best in my opinion
no not dark enough
royal heath
Lol yeah, I like the font though
quaint mantle
soemone should join #695010567907180554
spiral bramble
Heya,
At the moment I'm utilizing getItemMeta().getPersistentDataContainer, is there anything similar for Blocks, or an I going to need to spawn in armor stands and use them for persistent data?
young knoll
?blockpdc
undone axleBOT
Learn about CustomBlockData here:
https://www.spigotmc.org/threads/custom-block-data-persistentdatacontainer-for-blocks.512422/
spiral bramble
Legend thanks
sacred cedar
Hello,
I am currently trying to replace the /version and /ver command with my own /version command that will send a custom string to the sender.
But it still uses the normal /version command from bukkit how do i disable the vanilla one?
Any help is much appreciated ^^
wet breach
Hello,
I am currently trying to replace the /version and /ver command with my ...
do you know how to compile spigot yourself?
sacred cedar
do you know how to compile spigot yourself?
you mean the server version itself?
like the .jar file?
shadow night
Do default bukkit commands exist in the command map?
wet breach
not entirely sure if the version command can be overridden easily from a plugin, however the version info is pulled from the manifest in the jar which is created from the pom
so the easiest way to change it, is to change it in the pom
I recommend though if you intend on changing it you make it known that it is a spigot variant
sacred cedar
I recommend though if you intend on changing it you make it known that it is a s...
but is there no config option/way to do it?
like disable-command or something inside the spigot.yml or bukkit.yml?
wet breach
no there is not
sacred cedar
alright thats unfortunate
wet breach
Do default bukkit commands exist in the command map?
not entirely sure been a really long time since I looked at the code for the default and bukkit commands
shadow night
Because if they do, doesn't it mean overriding is as simple as just getting the command, then overriding the executor and tab completer? Might cause some issues with other plugins that do that, but who cares
wet breach
Because if they do, doesn't it mean overriding is as simple as just getting the ...
possibly, don't have my IDE up to look
but I remember version command being different, don't even think it has tab completion
shadow night
I think this is the version command
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/command/defaults/VersionCommand.java
quiet ice
NumberFormat.getCompactFormat() + setMin/MaxFractionDigits
Hey, that's cheating - only exists since Java 12 (https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/text/NumberFormat.html#getCompactNumberInstance()).
nova notch
those poor 1.8 users 😭
mellow edge
how does that make sense? every player has their own netty ChannelPipeline. But I want to just intercept the packet from childHandler
alpine urchin
sounds familiar
but that's a very odd and specific question @mellow edge
I hope you're aware there's projects that already do this for you.
mellow edge
I know, but I try to do it by myself since I understand netty
mellow edge
I intercept a packet PacketPlayInUseEntity, the only problem is that it triggers Caused by: net.minecraft.server.v1_8_R3.CancelledPacketHandleException every 2nd time I get this packet
charred blaze
does itemdisplay have its own hologram system or something?
mellow edge
then figure out the cause
do you know any similar project that uses nms (not protocollib) to intercept packets within spigot
alpine urchin
Look at TinyProtocol
You might have to tweak it for it to work well today, I don't think it'll be stable out the box. But that's a way to do it.
Generally there's multiple ways to actually inject and hack to get the pipeline and insert your handler. So which project you decide to look at shouldn't matter, you could look at ViaVersion or mine. But since you claim to be a netty expert, from there on you should be capable of assessing where your handler should be inserted and proceed from there on.
If you are fine with only supporting modern paper, the injection process is like a 5 liner.
mellow edge
I mean I injected my handler before packet_handler and used auto-release handler
mellow edge
Did you even consider anything I just mentioned.
I will take a look at TinyProtocol
alpine urchin
Personally I think ViaVersion's injection is easier to learn from.
But with TinyProtocol, I guess you technically could just yoink the code and get it somewhat working.
acoustic pendant
Could someone tell me some way to reset a World (trying to make a minigame)
blazing ocean
wdym reset
i have a world in my plugins/plugin/maps/mygame which i copy over to the server root and create a world of
alpine urchin
elaborate, what do you mean by reset? what some minigames do is they a world of the map. and then they have a seperate minigame world which copies the map upon start of a minigame
blazing ocean
then you can juts create a new one
blazing ocean
i have a world in my plugins/plugin/maps/mygame which i copy over to the server ...
temp worlds ^
alpine urchin
yup
mellow edge
Could someone tell me some way to reset a World (trying to make a minigame)
well there is multiple ways of doing this, probably the best one would be to use proxy to redirect to the actual minigame server from lobby, but you could also just copy the original world to player world, then when the minigame is over you could delete your playing world and copy it from original source again. BUT do not use an arraylist of "placed blocks" - this is not a good practice
alpine urchin
lol
blazing ocean
i actually use a list of placed blocks for a minigame
(in a temp world)
mellow edge
I'll try Just coping the World
but note that when you are deleting the world, you MUST unload it
acoustic pendant
but note that when you are deleting the world, you MUST unload it
Oh, that's true
mellow edge
(Bukkit.unloadWorld)
brittle geyser
How to get comment above config key (YamlConfiguration)
blazing ocean
i actually use a list of placed blocks for a minigame
i mean it's user-specified how many rounds you can play so always loading n worlds can cause a lot of performance impacts as world loading is pretty slow
mellow edge
i actually use a list of placed blocks for a minigame
I mean you can, but what if your server crashes mid-game?
alpine urchin
blazing ocean
i mean the game would just be over as it's a temp world
glad prawn
How to get comment above config key (YamlConfiguration)
there are getComments and getInLineComments in YamlConfiguration
mellow edge
you have a world copy logic (original->temp) world AND a list of blocks to remove?
brittle geyser
there are getComments and getInLineComments in YamlConfiguration
There are no getComments and getInLineComments methods
blazing ocean
you have a world copy logic (original->temp) world AND a list of blocks to remov...
well yes, and i also have a reasoning for this.
it's kitpvp duels, i copy over the arena to a tempworld and have a list of actions the players do (blocks broken, placed, etc), and i clear that every round. the reason i don't use multiple tempworlds is because the players can specify how many rounds they want to play, so if somebody wants to play 10 rounds, loading the worlds will lag out the server
glad prawn
There are no getComments and getInLineComments methods
old version?, then you have to find a way yourself.
mellow edge
oh yeah that makes sense
brittle geyser
old version?, then you have to find a way yourself.
I don't know how to do this, so I'm asking here.
alpine urchin
well yes, and i also have a reasoning for this.
it's kitpvp duels, i copy over t...
make em wait
blazing ocean
no
alpine urchin
you could have em waiting in some area as they wait for the next round
but i feel you tho
i understand you
whats your server, i want to lag it
blazing ocean
especially now that i'm moving stuff over to a temp server architecture, it'll be an even longer wait
blazing ocean
whats your server, i want to lag it
no
blazing ocean
not public atm
mellow edge
you want to lag it lol
glad prawn
I don't know how to do this, so I'm asking here.
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/configuration/file/YamlConfiguration.java
u can look here to see how it stores comments
alpine urchin
ok
blazing ocean
breaks on my paper fork
mellow edge
you mean PE
PE?
alpine urchin
thanks for reporting
blazing ocean
packetevents
mellow edge
yk my api collects non-anonymous stats
wait what? you api collects data?
alpine urchin
non-anonymous was a joke
blazing ocean
kekw
mellow edge
haha imagine
icy beacon
yk my api collects non-anonymous stats
oh no, i sure hope my data is safe
blazing ocean
alpine urchin
if google wants some user data, they should reach out
hopefully we can find a good deal
i'll manually type in everyone's data
icy beacon
can i get all the data you've collected with a buy-now-pay-later plan
mellow edge
I see you made PE. Then I went to see reviews, they were very positive, except this one:
blazing ocean
????
icy beacon
I see you made PE. Then I went to see reviews, they were very positive, except t...
nice pfp
alpine urchin
omg, i saw the guy in my discord the other day
icy beacon
his name "govno" is literally "shit" in russian
blazing ocean
lmao
mellow edge
he doesn't have plugins....
wait he has
no way... my custom npc click event is working!
drowsy helm
poggers
mellow edge
this time protocol wiki saved me
twin venture
hi , its been a while since i last codded anything , what is the best aproch to deal with local values of kills , deaths , etc? so when game end it reset , a map with String,Integer?
in the User class ?
drowsy helm
UUID key ideally
twin venture
well , can i do it inside the user ? which obv have uuid?
drowsy helm
spigot doesn't come with a User class
mellow edge
I mean increasing kills is not bad
twin venture
I mean increasing kills is not bad
better way?
drowsy helm
but can't you make a variable for the specific stat?
twin venture
this is local data, so when a game end , it will calucate it for each player , and then add them to the stats StatsUser have
mellow edge
what does SkyUser class represent?
twin venture
this is Stats user , so i can do skyuser.getStatsuser().setkills(getKills(),localValues.get(kills)))
if i wana to set the kills in the db
is this a good aproch?
mellow edge
it is ok, if it's working it's working
mellow edge
I mean I would ask myself why I would make it batter.
because I don't know what you mean with batter
twin venture
so to put it simple , the values in the UserStats class is the user data that will be loaded from database .
and the localValues map , are the ingame (inside arena) data for each user , once a game end , it will get the data from the map for each user and add them to the user Stats data ..
better in design , and performance
mellow edge
why not directly add it to user stats?
and db
also
databases are meant to store huge amounts of data, why would you load all that data back into UserStats class?
twin venture
why would i store the game data ,and user data? that does not make any sense
mellow edge
I meant why don't you just pull values from database when you need them.
twin venture
iam doing that , and i think you still don't understand what iam trying to do
so in lobby , i want to pull the data from database [placeholders] , so i can show
mellow edge
well from you've told me I assume you are trying to at the end of the game calculate stats and add them to db
mellow edge
is your system working rn
glad prawn
this is Stats user , so i can do skyuser.getStatsuser().setkills(getKills(),loca...
u can write like private int kills, deaths, killstreaks to make it shorter
twin venture
u can write like `private int kills, deaths, killstreaks` to make it shorter
already have that
that's for total kills , total deaths .. etc
inside the arena , i want another set of stats for example kills , deaths will show it inside the game , and it is resetable after each game
but the total kills are not
sullen canyon
it would be better if userstats was an abstract class containing only players uuid and then you would have SkywarsSoloStats SkywaraDoubleStats etc.. extending your userstats class
twin venture
oh do you think so that is better?
sullen canyon
ig thats open closed principle
sullen canyon
and then you could make your saving system work based on given abstract user data class rather than some specific class thou I dont know how your system works right now so I cant give you much help
twin venture
thanks
quasi gulch
When i hit the rate limit of the Mojang API it throws an exeption when i use playerprofile.update and i accept it async. How do i catch that exeption because that method doenst throw one it just prints it in the console so try catch doenst help
eternal oxide
How the hell are you hitting the rate limit? Its something like 600 in 10 minutes
nope I just looked its 200 per minute
quasi gulch
yes i because i wanted to test if i hit it
But is there a way to catch that exeption?
But i think i will do it on another way. I will just store their profile when the player joins so i dont need to api lookup them
eternal oxide
you need to try/catch inside the async call, or use the proper catch Exceptionally
quasi gulch
Ok thanks
teal oracle
whats the difference between
pluginname.jar
pluginname-shaded.jar
original-pluginname.jar?
eternal oxide
Shortest name is to be used on a server
shaded is teh same as teh shortest name.
original is (I forget)
teal oracle
original took less space in bits
eternal oxide
yeah, has no shaded depenedencies
teal oracle
ok
torpid forge
I need a scripting plugin but Im on aternos 1.20.5 and the Skript plugin wont work. I am trying to do that: https://www.youtube.com/watch?v=Mjj-1LDHfBs&ab_channel=FanStaaff can anyone help?
and all of that in only one world
teal oracle
is there a way to teleport to server world spawn? or should i just use a regular teleport event?
teal oracle
I need a scripting plugin but Im on aternos 1.20.5 and the Skript plugin wont wo...
this isnt the place to ask for this, but isnt mine reset lite a plugin?
torpid forge
but Its only in blocks no?
teal oracle
i dont think it cna do crops if thats what you are asking
torpid forge
like Its not diagonal
tardy delta
go to skript support
torpid forge
what will they tell me
tardy delta
this is spigot, we dont do that nonsense here
torpid forge
the version of skript is not worknig on 1.20.5 and Im on spigot thats why I came here
Its only with world edit I want to do all of the coal ores in a world
eternal oxide
Wrong channel #help-server
teal oracle
go to aternos support or smth if that exists
eternal oxide
I just wanna create a regenerating mine broo
You are not writing a plugin so wrong channel #help-server
small trail
pls help
eternal oxide
Try asking a question
tardy delta
#general message
small trail
so the font doesnt work here but here it works pls help fix it
eternal oxide
Not writing a plugin #help-server
teal oracle
how can i register commands without adding properties? like not having description to a command and such
inner mulch
how can i register commands without adding properties? like not having descripti...
you cant
eternal oxide
can;t have an empty key
inner mulch
how can i register commands without adding properties? like not having descripti...
you dont need a description
but you need to add it to plugin yml
silver robin
how can i register commands without adding properties? like not having descripti...
perhaps a better question would be 'how to add a global command listener'?
and I think the only way is to listen to packets, I could be wrong
eternal oxide
what?
teal oracle
no i mean like only having the name of the command in the plugin.yml
eternal oxide
you can't
inner mulch
no i mean like only having the name of the command in the plugin.yml
you can
i dont get errors
eternal oxide
a key with nothing under it is not a valid section and will be ignored
inner mulch
commands:
test:
idk:
works
teal oracle
what
eternal oxide
commands:
test:
idk:
works
it does?
inner mulch
ok
teal oracle
lets goo
tardy delta
i saved 0.03 kb
plot twist, if you wanna get technical you actually dont
dawn flower
what's a good way to hide plugins to non op players? so u can't do /pluginname:command, u can only do /command
i tried using commandmap but that does it globally (even for opped players) and i can't just listen for tab completions cuz that'd leak my plugins if the server stops (unless there's a way to create a non plugin dependant listener)
tardy delta
listen to command pre process event iirc
dawn flower
i can't just listen for tab completions cuz that'd leak my plugins if the server stops
also that event is after u already execute the command
eternal oxide
dawn flower
same with that
calm marsh
Hello, I'm making a Spigot plugin, and I'm having some trouble with it. Does someone know how to "set" the Text on a WallHangingSign ? Thank you.
dawn flower
> i can't just listen for tab completions cuz that'd leak my plugins if the serv...
if the plugin stops not the server*
eternal oxide
same with that
What I linked is what you want
dawn flower
it isn't
eternal oxide
yes it is
eternal oxide
Its literally all commands that are exposed to a client
dawn flower
(even if the plugin is disabled)
eternal oxide
you can;t use a command with no permissions
dawn flower
not all plugins have good devs
eternal oxide
you can;t see a command with no permissions
tardy delta
not all plugins have good devs
forking moment ig
dawn flower
trash devs use if (!player.hasPermission("wtvr")
eternal oxide
for those Like worldedit you can remove the command in that event I just linked
dawn flower
forking moment ig
some of them obfuscate their plugins (even if it's free)
is there a way to make a listener that is non plugin dependant
eternal oxide
remove the damn command in teh event I linked
dawn flower
if the plugin dies it leaks everything
eternal oxide
oh my god, I'm talking to a wall
dawn flower
bro
eternal oxide
bro
dawn flower
if the goddamn plugin gets disabled
silver robin
Hello, I'm making a Spigot plugin, and I'm having some trouble with it. Does som...
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/block/Sign.html#getSide(org.bukkit.block.sign.Side)
SignSide has setLine(index, line)
dawn flower
the plugin stops handling the listener
eternal oxide
That event has ALL commands teh client CAN know about
dawn flower
WHICH MEANS IT LEAKS IT
inner mulch
tardy delta
then hide it there
dawn flower
that's global
eternal oxide
if it's not sent in that event the client does not know it even exists
dawn flower
the server sends the command update every whatever
that's how when u load a plugin during runtime using plugman the command shows up
eternal oxide
it updates on join, permission attachment change and world change
dawn flower
great it updates on join
calm marsh
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/block/Sign.html#getSide(org....
Thx, I did saw this, but I don't get it. I do a World.GetBlockAt(my location) I get back my WallHangingSign, then, I cast it as a "SignSide" and it throw an error out, so I don't thing I'm on the right track.
dawn flower
what if the plugin gets disabled
inner mulch
missingreports did you even try before saying elgarL's method doesnt work?
inner mulch
how about trying
eternal oxide
if of course it works
inner mulch
before saying that
silver robin
what's a good way to hide plugins to non op players? so u can't do /pluginname:c...
what does "if the server stops" mean?
do you mean that during the server closing, there is a period of time where tab completions work, but your plugin doesn't?
rough drift
WHICH MEANS IT LEAKS IT
no because the listener is removed and the gc will know it is garbage and will remove it
dawn flower
what does "if the server stops" mean?
do you mean that during the server closing...
i meant if the plugin stops
eternal oxide
Stop arguing and try it
dawn flower
u owe me 100k if it doesnt work
eternal oxide
commands do not leak
dawn flower
they do
eternal oxide
its impossible for a client to even know a command exists without it going torough that event
dawn flower
uh
eternal oxide
On OLD spigot you used to get a permission error
rough drift
its impossible for a client to even know a command exists without it going torou...
no? depends on which event, tab completion is not required
dawn flower
how tf do u even set the commands
eternal oxide
today the client has no knowlege of teh command at all
rough drift
today the client has no knowlege of teh command at all
It does
dawn flower
oh wait it returns a modifieable list
rough drift
the client does
silver robin
i meant if the plugin stops
okay, are you trying to do this to your plugin, or some other plugin?
in the former, i'm not sure what the problem is about, because when your plugin stops, your plugin's tab completer also stops
rough drift
Elgar the client gets sent the command tree lmao
eternal oxide
Elgar the client gets sent the command tree lmao
Yes, in https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/player/PlayerCommandSendEvent.html which I already linked and told him to remove it from there
rough drift
Yes, in <https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/player/Player...
ah my bad I misunderstood
rough drift
show us your code
eternal oxide
dawn flower
yes
dawn flower
yes i did
silver robin
please chill down
are you talking about non-OPs seeing FAWE commands being tab completed, but not being able to execute them?
silver robin
@dawn flower just to be sure that I/we understand you, are you talking about this behaviour? (hypixel has a /f command for friends)
eternal oxide
Show the code in https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/player/PlayerCommandSendEvent.html where you blocked the fawe commands
dawn flower
i just did e.getCommands().clear()
idc abt fawe rn
at first it worked
only fawe popped up
but then i disabled the plugin
rejoined
eternal oxide
thats impossible
dawn flower
and all commands r back
eternal night
what plugin did you disable?
dawn flower
the listener plugin
rough drift
me about to drop Player#updateCommands
eternal night
So
eternal night
Okay?
rough drift
if the plugin dies all plugins r leaked
what
eternal night
If world guard dies, so is your map
dawn flower
world guard doesnt die
dawn flower
also i have extra protection
rough drift
bro is schizo
eternal oxide
I don;t see its possible to leak commands without firing https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/player/PlayerCommandSendEvent.html
dawn flower
can i just create an always existing listener
eternal night
this discussion is dumb, if you care to have a minimal surface area, extract that specific logic into its own small plugin that does nothing else
no
rough drift
can i just create an always existing listener
no
eternal oxide
every command the client knows about goes through that event
dawn flower
with refleciton
eternal night
No
eternal night
just, write a two line plugin that does this
it can't break, its just an event listener
calm marsh
Someone already made a plugin which set the text on a WallHangingSign guys?
tardy delta
bruh why, its five lines
silver robin
Someone already made a plugin which set the text on a WallHangingSign guys?
sign.getSide(Side.FRONT).setLine(1, "Nice text");```I'm going to give it a try, thank you
rough drift
```java
sign.getSide(Side.FRONT).setLine(1, "Nice text");```
iirc you have to call setSide after that like ItemMeta
tardy delta
cast the blockstate to a Sign
silver robin
iirc you have to call setSide after that like ItemMeta
eh, I'm not sure
eternal night
you don't hacve to call setSide
you have to call .update on the sign block state snapshot
silver robin
cast the blockstate to a Sign
make sure to check first before casting https://discordapp.com/channels/690411863766466590/741875863271899136/1241741686196011070
~~ java if (blockState.getType() == Material.BIRCH_WALL_HANGING_SIGN) // and other types of Material.*_WALL_HANGING_SIGN too~~
eternal night
just instanceOf it 
eternal oxide
just Tag it
dawn flower
what field has the listeners set / map / list?
eternal night
if (!(block.getState() instanceof final Sign sign)) return`
sign....
tardy delta
why the final lol
dawn flower
what's funny?
eternal night
listeners are stored in the handler list
rough drift
I do that
eternal night
best of luck
rough drift
final is nice
eternal night
final is nice 
tardy delta
extra bloat
eternal night
not really
tardy delta
with no added value in this case
eternal night
prevents you from changing something you should probably not be changing
rough drift
^
eternal night
you have 0 idea what this case is lol
tardy delta
skill issue if you do that
rough drift
I don't do it much so I should begin doing it more
eternal night
Yea I mean, people tend to run into skill issues tho
some people reassign variables accidentlly, others fail to come up with a simple 17 endpoint rest service.
It's a nice safety mechanism with no downside beyond verbosity
dawn flower
what happens if i set the plugin as null in RegisteredListener constructor
eternal night
just patch the damn server man
if you care THIS much about your plugins not leaking
just patch the server
rough drift
chat remember to always call hasCustomModelData, apparently that fixed my code
rough drift
if you care *THIS* much about your plugins not leaking
or uh
dawn flower
ugh
rough drift
HandlerList.unregisterAll(this);
rough drift
I mean a plugin that just filters has 0 attack surface because it reads nothing
eternal night
Yea
dawn flower
is there a way to identify commands with ":" in their name and pluginname + commandmap?
or do i just use regex
rough drift
is there a way to identify commands with ":" in their name and pluginname + comm...
check if they contain a :
dawn flower
commands could contain : for whatever reason
rough drift
try parse it to a namespaced key
dawn flower
actually commands with : in their name deserve to not exist
acoustic pendant
Hey, i'm getting the world folder:
But it says it is null
I'm getting the world from player location
tidal kettle
hey Bukkit.getPlayer produce an error when the player isn't online or didn't exist, how can i check and delete the error?
eternal oxide
bukkitWorld is null
eternal night
hey Bukkit.getPlayer produce an error when the player isn't online or didn't exi...
it'll just yield null back
acoustic pendant
bukkitWorld is null
yea, but i'm getting the world from player location
how can that be null?
eternal night
I mean, show the more extended code for bukkitWorld
eternal oxide
you clearly are not
acoustic pendant
eternal night
so you are not
you are blindly guessing if a world by that name exists
which, in your case, it does not
acoustic pendant
no wait
eternal night
eternal oxide
Show where you get teh String world
silver robin
hey Bukkit.getPlayer produce an error when the player isn't online or didn't exi...
it doesn't produce an error, it returns null, so just check for that
tidal kettle
okay
acoustic pendant
Show where you get teh String world
silver robin
okay
Player me = Bukkit.getPlayer("musava_ribica");
if (me == null || !me.isOnline())
return;
// do whatever ```that code would not even compile
eternal night
it clearly isn't the commented out code 
eternal oxide
show us ACTUAL code
undone axleBOT
acoustic pendant
eternal oxide
```java
Player me = Bukkit.getPlayer("musava_ribica");
if (me == null || !me.isO...
use an OfflinePlayer if you can
acoustic pendant
there you got
eternal night
Bukkit.unloadWorld(bukkitWorld, false);
GameManager manager = new GameManager(plugin, world);
okay so
eternal night
yea
acoustic pendant
that is a great point actually xd
eternal oxide
I'll just unload this world and then try to use it later 😉
acoustic pendant
```java
Bukkit.unloadWorld(bukkitWorld, false);
GameManager manager =...
Well, but I want to copy this world and if it is loaded i cannot do that
tidal kettle
```java
Player me = Bukkit.getPlayer("musava_ribica");
if (me == null || !me.isO...
i think bukkit.getOnlinePlayer.contain() is better
silver robin
at this point, it's a matter of preference
it would be a lot worse if there could be thousands of online players, in which case what I sent is faster (assuming the player name is exactly correct), because it uses a Map, while you would still have to iterate through a Collection
acoustic pendant
just don;t copy the lock file
https://paste.md-5.net/apubokuhos.cs Something like this would work?
eternal night
i think bukkit.getOnlinePlayer.contain() is better
it REALLY isn't
tidal kettle
why?
silver robin
File newSource = new File(source, file);
File newDestination = new File(destination, file);``` is this required? since `source` and `destination` variables are `File` alreadybeacuse getPlayer does the exact same if you rely on the weird prefix behaviour
tidal kettle
beacuse `getPlayer` does the exact same if you rely on the weird prefix behaviou...
if i check getPlayer.isOnline and the player isn't online i got an error
with bukkit.getOnlinePlayer.contain() i do not
eternal night
you were literally linked the "pls just null check"
shadow night
if i check getPlayer.isOnline and the player isn't online i got an error
Because it's null then
eternal night
```java
Player me = Bukkit.getPlayer("musava_ribica");
if (me == null || !me.isO...
^ like
the null check is the important part
eternal night
doubt
acoustic pendant
https://paste.md-5.net/apubokuhos.cs Something like this would work?
did actually work 👍
eternal night
not that the isOnline check there is actually useful
silver robin
if i check getPlayer.isOnline and the player isn't online i got an error
you don't get an error because the player isn't online
you get an error because you do something assuming he is online, but you forgot to add a check
and generally it's helpful to also mention what type of error you get, in this case it's probably NullPointerException
eternal night
getPlayer yields null for offline players, non null for online ones
shadow night
How to check if player is online? getPlayer(playerName) != null
silver robin
How to check if player is online? getPlayer(playerName) != null
&& player.isOnline()
eternal night
no
shadow night
~~&& player.isOnline()~~
No need to
silver robin
okay yeah I get it mb
shadow night
getPlayer will return null if the player is offline
tidal kettle
Player target = Bukkit.getPlayer(args[1]); if (target.getName() == null || !target.isOnline()){
icy beacon
fyi use getPlayerExact if you are working with names and not uuids
tidal kettle
this is gonna work right?
eternal night
no
silver robin
but if you have a Player object instead of their username or UUID, it's probably better to call isOnline method, no?
shadow night
fyi use getPlayerExact if you are working with names and not uuids
Whats the difference? never seen getPlayerExact
eternal night
you are null checking the name
which means you call getName() on something that might be null
icy beacon
Whats the difference? never seen getPlayerExact
i believe getplayer can give you the player even if the name doesn't match exactly
tidal kettle
yep my bad...
icy beacon
e.g. if you are checking for name123 and the player's name is name1234 you will get the player
but not with getplayerexact
silver robin
getPlayer simplified is just this java Player found = this.getPlayerExact(name); if (found != null) { return found; } else { return ... /* approximate lookup }
silver robin
note that getPlayer is deprecated in CraftBukkit
silver robin
well yeah, but at the time being, it's just a proxy call
inner mulch
how do servers change an inventories apperance based on the inventory (with a texture pack)
I've seen completely different looking guis
but there is only one inventory texture in minecraft, right?
echo basalt
It's pretty trivial
The resourcepack has a font file
Where you can define custom characters and such
And they can map out to a .png file
So you match a utf character (\uE001) to a picture (my-custom-gui.png)
The next thing you need is a negative space font to be able to shift the picture left and right
inner mulch
oh so i just a char?
echo basalt
Once that's done, you just set it on the inventory title (<space.-8>\uE001)
inner mulch
thanks
echo basalt
For animated guis, you just create multiple characters, one for each frame
For fancier guis where buttons can be on/off you can have a hollow main gui and then separate characters for buttons
You change their height by messing with the character ascent
silver robin
Once that's done, you just set it on the inventory title (<space.-8>\uE001)
how to get rid of this text though?
I've seen cases where it renders above whatever items are clipping
echo basalt
Lang file -> container.inventory.title iirc
You can then make a font to add it back with a crazy ascent and just toss a character with some spacing in there when needed
If you want lang file support, you can just edit container.inventory.title to container.inventory.customtitle, for example
and then still use the font stuff but with a translatable component
it's wonky
silver robin
seems cool, I've never looked into using custom fonts
thanks
blazing ocean
how do servers change an inventories apperance based on the inventory (with a te...
make sure to make the texture minecraft:gui/sprites/inventory/generic_54.png
since that is the default chest bg
wrong path
minecraft:gui/container/generic_54.png
blazing ocean
Lang file -> container.inventory.title iirc
should just be container.inventory
echo basalt
no fucking clue it's been months
blazing ocean
works for me 🤷
trail coral
how do i spawn an entity at a location and then get the instance of it?
eternal oxide
when you spawn it you get the instance back
trail coral
oh thanks
quiet ice
what do you reckon is the more natural ordering of parameters: x1, x2, y1, y2 or x1, y1, x2, y2?
I think I always did x1, y2, x2, y2 but I feel like I have a little bit of temporary brain damage
tardy delta
depends on their use, the latter for coordinates
quiet ice
well it is for defining a 2D rectangle, so yeah - coordinates
tardy delta
ye the latter
echo basalt
I usually make point classes for this
ornate heart
I've made a custom enchantment system that store the enchantments via PDC. I'm wondering how I should approach displaying the enchantments in lore.
My thought process is: Since Minecraft has its own lore for the default enchantments, I should add the HIDE_ENCHANTS flag and then rewrite the lore myself.
The problem with this is if there is another enchantments plugin that writes their own lore, then that may mess things up.
Any suggestion s on a way to approach this?
echo basalt
then just pass min and max
blazing ocean
what do you reckon is the more natural ordering of parameters: x1, x2, y1, y2 or...
2 records
icy beacon
I've made a custom enchantment system that store the enchantments via PDC. I'm w...
Tell people not to use other enchantment plugins
There should only be one
If they use multiple, it's on them to figure shit out
blazing ocean
the latter imho
agreed but imo having records is clearer
icy beacon
or that
ornate heart
If they use multiple, it's on them to figure shit out
It feels weird forcing people to use a certain plugin just to be able to use my plugin.
It also makes my plugin pretty heavily dependent on another plugin.
icy beacon
It feels weird forcing people to use a certain plugin just to be able to use my ...
What
I'm saying that they SHOULD NOT use other enchantment plugins
umbral ridge
ornate heart
I know. I'm just saying: Lets say my plugin depends on a plugin like AdvancedEnchantments. If the person that wants to use my plugin is already using ANOTHER enchantments plugin, then they would have to switch to AdvancedEnchantments in order to use my plugin (Since, they shouldn't be using more than one enchantments plugin)
icy beacon
Why would your enchantment plugin depend on another enchantment plugin
ivory sleet
agreed but imo having records is clearer
Free hashCode() equals() and toString() implementation
which iirc also uses invokedynamic or invokespecial
So big W
ornate heart
Why would your enchantment plugin depend on another enchantment plugin
I explained it poorly before. My plugin isn't an enchantments plugin. It's a crops plugin. I need custom enchantments.
icy beacon
Ah
I mean if advancedenchantments has an api just use that and don't have your own custom enchantment system
ornate heart
Yea
and then I could also support other enchantment plugin in the case that they use another plugin.
quiet ice
2 records
In that case I'd use LWJGL's Vector2f class over useless purpose-made records from an API design perspective
blazing ocean
In that case I'd use LWJGL's Vector2f class over useless purpose-made records fr...
would work, assuming you don't need other methods and stuff
ivory sleet
Vector2fc :D
blazing ocean
Vector2fc :D
wtf does the c stand for
ivory sleet
wtf does the c stand for
read only type
blazing ocean
ahh
blazing ocean
Vector2fro kekw
quiet ice
which iirc also uses invokedynamic or invokespecial
what would be the improvement of that over the normal invokevirtual? I suppose it could do a lazily computed constant but outside of that?
blazing ocean
Vector2fim 🤷
tardy delta
invokedynamic means it does code generation at runtime through bootstrap methods
quaint mantle
Vector2ManagerFactory
blazing ocean
oh god
tardy delta
RecordX::hashcode does not exist in the bytecode when compiled, it gets generated through ObjectMethods::objectMethods or smth
quiet ice
And I'm not sure how you'd need to lazily computed data with indy (unless it is constant per-class, but not per-instance)
tardy delta
ah ::bootstrap its called
ye its per class
classfile size ig? cant think of anything else
ivory sleet
Tbh im not sure either, iirc not much was said about it in the JEP ntl
quiet ice
RecordX::hashcode does not exist in the bytecode when compiled, it gets generate...
uh wha? I always understood records to be syntatic sugar, but in that case it'd be much more than that.
tardy delta
ye it is
ivory sleet
well they’re “transparent immutable data carriers”
with deconstruction right? Or maybe thats still in preview
tardy delta
iirc their getters arent actually written out in the bytecode, but compiled at runtime
slender elbow
what would be the improvement of that over the normal invokevirtual? I suppose i...
basically it's the runtime that chooses the method impl rather than the compiler with room for improvement without having to recompile the class
tardy delta
they just point to a bootstrap method that generates their code
slender elbow
iirc their getters arent actually written out in the bytecode, but compiled at r...
they're present in the classfile
tardy delta
well ye sorta
tardy delta
but they simply do an invokedynamic ObjectMethods::bootstrap or smth
which generates the actual callsite
quiet ice
I don't see how indy is required here
slender elbow
I think we're talking about different things here
tardy delta
i dont either 🤷♂️
quiet ice
invokevirt suffices, no?
slender elbow
not if the bsm wants full access to the class data
tardy delta
ive heard it can be faster but i dont see how
tardy delta
not if the bsm wants full access to the class data
mightve been only for equals/hashcode/toString
quiet ice
indy is good for functional interfaces I'd say. Can also be good for more advanced niche purposes to do things that would otherwise be completely impossible to do with invokeX (i.e. obfuscation)
tardy delta
not sure about the implicit getters anymore
indy is good for reflection
well methodhandles
slender elbow
indy is good for dynamic languages, that's what it was originally introduced for, not java specifically
tardy delta
i believe ruby uses them
slender elbow
jruby was one of the first iirc
quiet ice
* These methods may be used, for example, by
* Java compiler implementations to implement the bodies of {@link Object}
* methods for record classes.
Okay, so it's the compiler-generated implementation of the Record methods that uses them
tardy delta
ye
same for lambdas
but LambdaMetaFactory
theres also one for string concatenations IIRC
slender elbow
yep
tardy delta
StringConcatFactory::concatWithConstants and such
youre not the only one who wrote a classfile reader
slender elbow
and there's one for switch expressions I believe, but the fancier ones like pattern matching over switch
slender elbow
well, not when you're switching over types
quiet ice
Lookupswitch is the old-style switch statements
slender elbow
then there's the jdk.dynalink module which helps dynamic language compilers and runtimes deal with generation of, uh, stuff, it was a cool thing to make a compiler
tardy delta
never used any jdk internals tbh
only ever had the urge to pull in the module that provides @ForceInline
silver robin
what do you reckon is the more natural ordering of parameters: x1, x2, y1, y2 or...
I'm fascinated by how active this chat is, and how long discussions about a certain topic could be, this all started from here and I can't stop reading
tardy delta
ig this isnt about x1, x2 anymore :(
slender elbow
it isn't really internals, it's a jdk module that just isn't part of SE
silver robin
and by the way I was too scared to mention minX, minY, width, height instead of x1 x2 y1 y2
tardy delta
if it were c i woulve written #define rect(x1, x2) x1, x2 :(
quiet ice
and by the way I was too scared to mention minX, minY, width, height instead of ...
Well for the context it is for querying elements within a QuadTree, doing the "standard" centerX, centerY, width, height makes little sense imo
slender elbow
it's pretty neat but, like, unless you're making your own language runtime it isn't really all that useful
tardy delta
ooh so much new stuff to explore
tardy delta
it's pretty neat but, like, unless you're making your own language runtime it is...
and ig you did?
quiet ice
idk, the main appeal of invokedynamic I find is for doing obfuscation; which I am not the person to do in the first place
tardy delta
i cannot seem to remember how indy worked for lambdas
slender elbow
and ig you did?
i toyed with it for like a weekend, said "that's cool" and deleted the test project
lol
quiet ice
So I kinda ignore invokedynamic (well I still know that javac generates them for me, but there is little reason to actually write ASM transformers that emit them).
quiet ice
I've contributed two or three (depending on how you count it) commits to janino, does that count?
quiet ice
Embedded java compiler, written in java: https://github.com/janino-compiler/janino
in some ways it is equivalent to javac - but doesn't require a JDK to execute!
tardy delta
"execute the code directory in the running jvm"? as in a classfile generator?
feels like hot swapping
quiet ice
it generates *.class files from *.java files
tardy delta
i seem to have read over the fact that its a compiler and not a vm
quiet ice
that is pretty much all it does; it claims to do things ontop of that - but they are mostly scripting related and sit ontop of that compilation thing. It's the main appeal to some, but for me the compiler thing is the main appeal
slender elbow
I mean if you include the jdk.compiler module you can also compile java files at runtime
modules 💜
quiet ice
Well the absolute main appeal is that it has a super intuitive structure for me. But it is sorely out of date feature-wise sadly.
quiet ice
Though I have to warn you: I consider 4k+ LoSC behemoths intuitive (which janino has a few of) - so most will absolutely not like it
slender elbow
it depends on the application ofc
tardy delta
LoSC?
quiet ice
lines of source code
slender elbow
as a library developer there isn't really a downside, as an application developer, well, you have full control over your application
tardy delta
only 4k
ah per file 💀
god bless you, you havent had the time to see 30k lines of generated c code in a file
quiet ice
Yeah, and the Java.java file in janino is 6.5k lines
tardy delta
most editors simply die
quiet ice
I've been meaning to try out modules at runtime + compiletime. So far I exclusively use modules at compiletime where they are quite good at hiding implementation details if necessary
tardy delta
i havent found a reason to use them
quiet ice
Well I've mainly been meaning to use them as it would hide away the fact that a good portion of my projects have a class called "JavaInterop"
tardy delta
its always the legacy code
rough drift
chat I am setting the InventoryClickEvent's result to DENY but apparently it still lets me pick up items? I added a debug statement before setting it and it's running, it also has the highest priority so idfk anyone know why this may be happening at all?
if (result.shouldCancel()) {
System.out.println("I'm running");
event.setResult(Event.Result.DENY);
}
```This is printing fine but I can still pick up the itemresult is my own object, returned from another piece of code
... and now it works what?
Alright thanks guys
tardy delta
wonderful
silver robin
chat I am setting the InventoryClickEvent's result to DENY but apparently it sti...
what does InventoryClickEvent have to do with picking items up?
do you mean take from a chest for example?
also event.setResult(Event.Result.DENY); is very suspicious to me, shouldn't it be something like event.setCancelled(true) ?
rough drift
also `event.setResult(Event.Result.DENY);` is very suspicious to me, shouldn't i...
setCancelled calls the first one fyi
also yes picking up from a chest
Apparently it works, don't know if I just went full schizo and forgot to build something or what but it works now
sand spire
Does the <id> in maven repository matter? Cause I have some duplicate repository URL's with different id's and I'm not sure if I need to keep both or can remove one
rough drift
the ID does matter afaik
sand spire
ty 👍
whole gust
```java
if (result.shouldCancel()) {
System.out.println("I'm running");
...
My I ask why you opt to use this over setCanceled?
rough drift
My I ask why you opt to use this over setCanceled?
It's the preferred method because you can specify DENY, DEFAULT and ALLOW iirc
where DEFAULT uses vanilla's mechanic, DENY is like setting cancelled to true and ALLOW is like setting cancelled to false
plus if I ever need to have users pick something I can show the name directly
and it's clearer what it is doing
whole gust
Interesting. Ig I'm just used to using setCanceled. Hopefully it doesn't result in future issues
The less methods I have to mentally register, the better lol
rough drift
nope, setCancelled just does:
setResult(cancelled ? DENY : ALLOW)
so you're fine with using it
rough drift
The less methods I have to mentally register, the better lol
fair I just use tab completion, javadocs and source for methods I don't know
whole gust
nope, setCancelled just does:
setResult(cancelled ? DENY : ALLOW)
LOL oh I gotchu
hushed spindle
how do i get the server's version package like 1_20_R4, i used this previously but the naming conventions seem to have changed
i would prefer not to have to use Bukkit.getVersion() and mapping each to a package version
hushed spindle
relocating?
chrome beacon
Adding the versioned package
remote swallow
Also Paper will stop relocating so be prepared
they have on 1.20.5
small valve
If a message is cancelled on Spigot, how do I check if that message is cancelled on Bungeecord?
chrome beacon
they have on 1.20.5
ah ok
chrome beacon
If a message is cancelled on Spigot, how do I check if that message is cancelled...
?xy
undone axleBOT
small valve
I want to check if a spigot message is cancelled in Bungeecord. I'm sending a message via a spigot server, let's say "hi" is in the list of banned words.
"hi" is cancelled on the spigot server, but on my Bungeecord plugin, even if I check if "event.cancelled()" is true, it still runs, so I assume the event is not cancelled.
Is tehre any communication I can do without plugin messaging channel to check (on the proxy) if an event fired on the spigot server is cancelled
chrome beacon
so why do you need to check that
small valve
I have a global proxy chat plugin and I want it to be compatible with plugins that cancel messages with links or curse words
small valve
🗿
That means I need to make my own "helper" plugin and put it on the spigot server as well right?
buoyant viper
theres no real communication between bungee and the server beyond the messaging channel :p
chrome beacon
If you really want to avoid it you can check for out going messages
That would cause all sorts of issues though
chrome beacon
That means I need to make my own "helper" plugin and put it on the spigot server...
yes
buoyant viper
why not find (or make) a bungee plugin to manage ur chat instead of something per-server?
small valve
I was told that cancelling (or editing) proxy messages are not really a good thing to do.
My plugin works with some proxy-based chat filters but not server-based. And again, compatibilty seems to change depending on how that person implemented their filter
chrome beacon
why using nms
rare rover
cuz im making the entities client side
chrome beacon
also when working with nms it's very important that you specify the version you're on
rare rover
i need them to be client sided
oh sorry, 1.20.4 so 1.20_R3 iirc
currently got this:
private void spawnClientSideEntity(@NotNull Player player, @NotNull Location blockLocation) {
final ServerPlayer serverPlayer = ((CraftPlayer) player).getHandle();
final ServerLevel level = serverPlayer.level().getWorld().getHandle();
final ServerGamePacketListenerImpl listener = ((CraftPlayer) player).getHandle().connection;
final ItemStack itemStack = ItemStack.fromBukkitCopy(new org.bukkit.inventory.ItemStack(Material.COAL));
final ItemEntity entity = new ItemEntity(level, blockLocation.x() + 0.5, blockLocation.y(), blockLocation.z() + 1.5, itemStack);
listener.send(new ClientboundAddEntityPacket(entity));
listener.send(new ClientboundSetEntityDataPacket(entity.getId(), entity.getEntityData().getNonDefaultValues()));
startTrack(player, listener, entity);
}```why not use the api? you can show entities to a single player if you wish