#help-development | SpigotMC | Page 835

echo basalt Dec 22, 2023, 7:23 PM

#

I've seen upwards of 1ms for each call

waxen plinth Dec 22, 2023, 7:23 PM

#

I'll make sure to avoid that then

echo basalt Dec 22, 2023, 7:23 PM

#

Player#getLocation returns a new location

#

Location#getBlock returns a new block

waxen plinth Dec 22, 2023, 7:23 PM

#

ok that makes sense

lost matrix Dec 22, 2023, 7:23 PM

#

More than one usage means im creating a new variable.
I dont make exceptions there.

echo basalt Dec 22, 2023, 7:24 PM

#

I just assign all variables at the top and re-use them whenever

waxen plinth Dec 22, 2023, 7:24 PM

#

one of the worst things about java is that heap allocations are a byproduct of virtually all meaningful work

ivory sleet Dec 22, 2023, 7:24 PM

#

lost matrix More than one usage means im creating a new variable. I dont make exceptions the...

Yeah except for multithreading where u sometimes want the up to date value every call

waxen plinth Dec 22, 2023, 7:24 PM

#

it's so gross

echo basalt Dec 22, 2023, 7:24 PM

#

So that if I want to use it again I don't need to refactor

waxen plinth Dec 22, 2023, 7:24 PM

#

Location should 100% be a value type

#

same with Block

echo basalt Dec 22, 2023, 7:24 PM

#

go write RustySpigot

waxen plinth Dec 22, 2023, 7:24 PM

#

🥲

#

someone's already doing it

echo basalt Dec 22, 2023, 7:24 PM

#

call it Plumber or something

lost matrix Dec 22, 2023, 7:25 PM

#

Faucet

waxen plinth Dec 22, 2023, 7:25 PM

#

did you see that imlucid denied evolution

#

isn't it funny we worked for that guy

#

and took it seriously

#

💀

echo basalt Dec 22, 2023, 7:26 PM

#

Well

#

Bro got depresso and canceled the entire project

#

I don't think I've been paid for it more than once

#

I did sell some minigames

#

for $$$

waxen plinth Dec 22, 2023, 7:26 PM

#

damn

echo basalt Dec 22, 2023, 7:26 PM

#

made a couple grand on top of the couple grand I was paid to write them

waxen plinth Dec 22, 2023, 7:27 PM

#

I had a few preexisting minigames I wanted to sell and put into use somehow but they were old and riddled with issues

echo basalt Dec 22, 2023, 7:27 PM

#

get gud

#

but yeah I never took it 100% seriously

#

The pay was also subpar

waxen plinth Dec 22, 2023, 7:27 PM

#

mm

#

I don't remember what I got paid but I think I settled for less because I was excited to work on a minigame core

remote swallow Dec 22, 2023, 7:27 PM

#

echo basalt Bro got depresso and canceled the entire project

what project

echo basalt Dec 22, 2023, 7:27 PM

#

waxen plinth I don't remember what I got paid but I think I settled for less because I was ex...

eH

waxen plinth Dec 22, 2023, 7:28 PM

#

and then quickly became unable to work on it because of mental health

echo basalt Dec 22, 2023, 7:28 PM

#

could've done your research :)

#

I based my entire core around minikloon's state system

#

think yours was just a bunch of kit logic

waxen plinth Dec 22, 2023, 7:28 PM

#

I mean sure but what they paid is reflected in what they got

echo basalt Dec 22, 2023, 7:28 PM

#

we had to scrap most of it

#

and the entire project lmao

waxen plinth Dec 22, 2023, 7:28 PM

#

I don't doubt it

echo basalt Dec 22, 2023, 7:28 PM

#

it might still come out of the dead

waxen plinth Dec 22, 2023, 7:28 PM

#

I wish they'd had me write a minigame alongside it instead of the core first

#

whenever I try to build an abstraction in a vacuum it ends up not working very well

#

I need to adapt it alongside an implementation of its use case, and this has proven itself time and time again

echo basalt Dec 22, 2023, 7:29 PM

#

I'm working on some minigame infrastructure stuff rn, might resell it to him

waxen plinth Dec 22, 2023, 7:29 PM

#

he's trying again?

echo basalt Dec 22, 2023, 7:29 PM

#

well no

#

But I did tell him about the idea a few months ago and he was super interested in buying it

#

and told me that the project might be restarted in ~6-8 months

#

well it's been 6 months

waxen plinth Dec 22, 2023, 7:30 PM

#

nice

#

hope you get in touch with him and make bank off the loser

#

you might be able to find a better buyer though

echo basalt Dec 22, 2023, 7:31 PM

#

I'm not doing exclusive reselling I'll prob resell my stuff like 5-6 times

waxen plinth Dec 22, 2023, 7:31 PM

#

if I were to make a really good core I'd probably just open source it

echo basalt Dec 22, 2023, 7:31 PM

#

I'm not just making a minigame core

orchid trout Dec 22, 2023, 7:31 PM

#

like this?

echo basalt Dec 22, 2023, 7:31 PM

#

that's the least of my concerns

echo basalt Dec 22, 2023, 7:31 PM

#

orchid trout like this?

Reuse variables

waxen plinth Dec 22, 2023, 7:31 PM

#

I would want to abstract every part of minigame development

quaint mantle Dec 22, 2023, 7:32 PM

#

lol

waxen plinth Dec 22, 2023, 7:32 PM

#

in order to get a feel for it I'd probably want to write a few minigames first, then start building abstractions around it and retrofit them into the existing games, and slowly build higher and higher level abstractions to target problematic areas that have a lot of boilerplate

quaint mantle Dec 22, 2023, 7:32 PM

#

yo so uh

echo basalt Dec 22, 2023, 7:32 PM

#

going to be writing the entire infrastructure and sell it as a package

quaint mantle Dec 22, 2023, 7:32 PM

#

boxbeam i tried to abstract my plugin into like

waxen plinth Dec 22, 2023, 7:32 PM

#

oh hi good timing

quaint mantle Dec 22, 2023, 7:32 PM

#

a bunch of configs and stuff and it just seems rly unneccessary

lost matrix Dec 22, 2023, 7:32 PM

#

orchid trout like this?

You dont actually use the future here...

orchid trout Dec 22, 2023, 7:32 PM

#

echo basalt Dec 22, 2023, 7:32 PM

#

lost matrix You dont actually use the future here...

lmao just noticed

waxen plinth Dec 22, 2023, 7:33 PM

#

quaint mantle a bunch of configs and stuff and it just seems rly unneccessary

what do you mean

orchid trout Dec 22, 2023, 7:33 PM

#

ijm actually supid

#

wthank you

waxen plinth Dec 22, 2023, 7:33 PM

#

echo basalt going to be writing the entire infrastructure and sell it as a package

looks very cool

#

so you're trying to make the full package, front to back

echo basalt Dec 22, 2023, 7:33 PM

#

Yep

waxen plinth Dec 22, 2023, 7:33 PM

#

could spawn a lot of minigame servers

quaint mantle Dec 22, 2023, 7:33 PM

#

waxen plinth what do you mean

it just looks like a ton of work and I just wanna add my custom items

echo basalt Dec 22, 2023, 7:33 PM

#

And a solid minigame core that lets me make a minigame in like a day

waxen plinth Dec 22, 2023, 7:33 PM

#

I'd be very interested to see how that plays out

echo basalt Dec 22, 2023, 7:33 PM

#

wtf am I saying with a week it takes like 2 hours rn

waxen plinth Dec 22, 2023, 7:34 PM

#

lol

echo basalt Dec 22, 2023, 7:34 PM

#

Worst case scenario I just spin up my own bootleg network

#

And try to fit 800 people in a single dedi

waxen plinth Dec 22, 2023, 7:34 PM

#

hmu if you do set that up

#

I'd be interested in trying to write a minigame in your framework and making something for your server

echo basalt Dec 22, 2023, 7:34 PM

#

gotta rewrite half of it but I'll make it work out

waxen plinth Dec 22, 2023, 7:35 PM

#

quaint mantle it just looks like a ton of work and I just wanna add my custom items

ok but what did you actually do

lost matrix Dec 22, 2023, 7:35 PM

#

orchid trout like this?

Btw you should probably reduce your nesting my refactoring the codeblock into a method and referencing it with

CompletableFuture<Profile> future = CompletableFuture.supplyAsync(() -> loadProfile(discordId));

It gives your anonymous method an actual name and makes it more readable by adding secondary information.

echo basalt Dec 22, 2023, 7:35 PM

#

I also gotta work on my skyblock core :p it'd allow me to do player housing n stuff

waxen plinth Dec 22, 2023, 7:35 PM

#

you're not showing us any code or getting specific

quaint mantle Dec 22, 2023, 7:35 PM

#

nothing

#

i just kept it the way it is

#

cause it works

#

lol

waxen plinth Dec 22, 2023, 7:35 PM

#

but you said you abstracted it and made it very config based

quaint mantle Dec 22, 2023, 7:36 PM

#

oh I tried but it just seems so like dumb lol

orchid trout Dec 22, 2023, 7:36 PM

#

lost matrix Btw you should probably reduce your nesting my refactoring the codeblock into a ...

sop instead of 1 method threes 2

waxen plinth Dec 22, 2023, 7:36 PM

#

ok so do you want to tell us what you tried?

#

like how were you implementing it

quaint mantle Dec 22, 2023, 7:36 PM

#

ill need a config for every item, and descriptions for every item, then ill need a config for the character the item belongs to

echo basalt Dec 22, 2023, 7:36 PM

#

lost matrix Btw you should probably reduce your nesting my refactoring the codeblock into a ...

yeah p much

waxen plinth Dec 22, 2023, 7:36 PM

#

and what was the code for that looking like

#

lots of manual save and load calls?

lost matrix Dec 22, 2023, 7:37 PM

#

orchid trout sop instead of 1 method threes 2

Yes. 🙂 More methods = More information => results in comments being less needed

quaint mantle Dec 22, 2023, 7:37 PM

#

no

#

so

#

I made a dc bot and I had this config system where it's very easy to get configs Repository#getConfig(Class) kinda like that and it's easy to register them too

lost matrix Dec 22, 2023, 7:37 PM

#

echo basalt yeah p much

smileybolb

echo basalt Dec 22, 2023, 7:38 PM

#

All fun and games until you have multiple copies of the same config for different stuff

#

For example, map files

#

thumbsup

orchid trout Dec 22, 2023, 7:38 PM

#

lost matrix Yes. 🙂 More methods = More information => results in comments being less needed

i really hate methods that jump around a lot

#

it makes it harder to read code form e

echo basalt Dec 22, 2023, 7:39 PM

#

I really hate nasty code

#

brb putting chicken in the air fryer

waxen plinth Dec 22, 2023, 7:39 PM

#

quaint mantle I made a dc bot and I had this config system where it's very easy to get configs...

ok, can I see what the code for that looked like?

waxen plinth Dec 22, 2023, 7:40 PM

#

echo basalt All fun and games until you have multiple copies of the same config for differen...

symlinks 👍

lost matrix Dec 22, 2023, 7:40 PM

#

orchid trout it makes it harder to read code form e

That is counter intuitive. If your methods have proper names, then you can read your code like a book.
You should be able to inferr what your method does by its name, making you read one word instead of 30 lines and having the same understanding of your code.

quaint mantle Dec 22, 2023, 7:40 PM

#

public interface ConfigService {

    void loadAndRegister(@NotNull Object config) throws IOException;

    <T> @NotNull T get(@NotNull Class<T> configClass);

    @NotNull List<@NotNull Object> getRegistered();

    void save(@NotNull Class<?> configClass) throws IOException;

    boolean isSaved(Class<?> configClass) throws IOException;
    
    boolean isRegistered(Class<?> configClass);

}

I used generics dw but this was what i copied

waxen plinth Dec 22, 2023, 7:41 PM

#

ok, so is it using reflection to load config values or something?

quaint mantle Dec 22, 2023, 7:41 PM

#

gson

waxen plinth Dec 22, 2023, 7:41 PM

#

gotcha

#

seems pretty good

orchid trout Dec 22, 2023, 7:41 PM

#

lost matrix That is counter intuitive. If your methods have proper names, then you can read ...

im looking at the image that imillusion sent and i have no idea whats going on

quaint mantle Dec 22, 2023, 7:41 PM

#

bruh

#

i cant post imgs

waxen plinth Dec 22, 2023, 7:41 PM

#

gotta verify

quaint mantle Dec 22, 2023, 7:41 PM

#

iok here

orchid trout Dec 22, 2023, 7:41 PM

#

?verify

lost matrix Dec 22, 2023, 7:41 PM

#

orchid trout im looking at the image that imillusion sent and i have no idea whats going on

For example

public Profile loadPlayerProfile(String profileId) {

You dont need to care what the body of this method looks like. You give it an ID and it returns a Profile. Thats all you need to know.

quaint mantle Dec 22, 2023, 7:41 PM

#

yeah my old acc

#

gone

remote swallow Dec 22, 2023, 7:42 PM

#

!verify

undone axleBOT Dec 22, 2023, 7:42 PM

#

Usage: !verify <forums username>

quaint mantle Dec 22, 2023, 7:42 PM

#

and i aint doing allat to msg staff to change my dc

#

@Config(name = "StartUpConfig")
public class StartUpConfig {

    @Mandatory
    private final String token;
    private final String motd;

    public StartUpConfig(String token, @Nullable String motd) {
        this.token = token;
        this.motd = motd;
    }

    @NotNull
    public String getToken() {
        return this.token;
    }

    public Optional<String> getMOTD() {
        return Optional.ofNullable(this.motd);
    }

}

remote swallow Dec 22, 2023, 7:42 PM

#

just email md

#

takes a few min

quaint mantle Dec 22, 2023, 7:42 PM

#

and here's an example

waxen plinth Dec 22, 2023, 7:42 PM

#

yeah that looks really nice

quaint mantle Dec 22, 2023, 7:42 PM

#

thanks

orchid trout Dec 22, 2023, 7:42 PM

#

lost matrix For example ```java public Profile loadPlayerProfile(String profileId) { ``` You...

and then a method loadplayerprofileasync

waxen plinth Dec 22, 2023, 7:42 PM

#

similar to my own config system

#

but using gson

orchid trout Dec 22, 2023, 7:42 PM

#

that returns completablefuture

quaint mantle Dec 22, 2023, 7:42 PM

#

then I would do this: configService.loadAndRegister(new StartUpConfig(null, null));

#

now that I think abt it

echo basalt Dec 22, 2023, 7:43 PM

#

waxen plinth symlinks 👍

well no because they have different values

quaint mantle Dec 22, 2023, 7:43 PM

#

I might remove the constructor parameters

waxen plinth Dec 22, 2023, 7:43 PM

#

yeah

quaint mantle Dec 22, 2023, 7:43 PM

#

but

waxen plinth Dec 22, 2023, 7:43 PM

#

then you could set defaults in the class

quaint mantle Dec 22, 2023, 7:43 PM

#

ye

lost matrix Dec 22, 2023, 7:43 PM

#

orchid trout im looking at the image that imillusion sent and i have no idea whats going on

For me it is kind of clear. The method associate is just a bad name.
Thats why you need really descriptive method names.

waxen plinth Dec 22, 2023, 7:43 PM

#

that's what I was gonna suggest

quaint mantle Dec 22, 2023, 7:43 PM

#

but now think about this for a bunch of items

#

like hundreds lol

waxen plinth Dec 22, 2023, 7:43 PM

#

yeah

#

I mean do you not have a way of storing them in a generalizable form

quaint mantle Dec 22, 2023, 7:44 PM

#

store what

waxen plinth Dec 22, 2023, 7:44 PM

#

like a base custom item class that stores all the regular properties

quaint mantle Dec 22, 2023, 7:44 PM

#

no lol

waxen plinth Dec 22, 2023, 7:44 PM

#

and some optional meta which can be a subclass attached to it only for items that need more special properties

#

so every item has special properties like that?

quaint mantle Dec 22, 2023, 7:45 PM

#

this is what a custom character is lookin like rn

waxen plinth Dec 22, 2023, 7:45 PM

#

in that case, a class per item sounds pretty standard - the only real alternative would be to pass around lambdas for any overridable functionality

quaint mantle Dec 22, 2023, 7:45 PM

#

public class KnightCharacter extends CustomCharacter {

    public KnightCharacter() {
        super(
                new CustomCharacterInformation.Builder()
                        .setVerse(CharacterVerse.CLASSIC)
                        .setReferenceName("classic_knight")
                        .setDisplayName("Classic Knight")
                        .build(),
                new CustomArmorEquipment.Builder()
                        .setHelmet(() -> new CustomItemBuilder(Material.IRON_HELMET, "classic_knight_helmet")
                                .setName("<gray>Knight's Helmet")
                                .setLore("<gray>Just a good old knight's helmet.")
                                .build())
                        .setChestplate(() -> new CustomItemBuilder(Material.IRON_CHESTPLATE, "classic_knight_chestplate")
                                .setName("<gray>Knight's ChestPlate")
                                .build())
                        .setLeggings(() -> new CustomItemBuilder(Material.IRON_LEGGINGS, "classic_knight_leggings")
                                .setName("<gray>Knight's Leggings")
                                .build())
                        .setBoots(() -> new CustomItemBuilder(Material.IRON_BOOTS, "classic_knight_boots")
                                .setName("<gray>Knight's Boots")
                                .build())
                        .build(),
                List.of(
                        () -> new CustomItemBuilder(Material.IRON_SWORD, "classic_knight_sword")
                                .setName("<gray>Knight's Sword")
                                .setLore("<gray>This sword could have some history",
                                        "<gray>behind it.")
                                .build()
                )
        );
    }
}```

waxen plinth Dec 22, 2023, 7:45 PM

#

hmm

#

at that point I feel like it's better to be able to load that from config or something

#

then you could write it out in a much more concise format

#

and define any special behavior separately in the code

lost matrix Dec 22, 2023, 7:46 PM

#

quaint mantle ```java public class KnightCharacter extends CustomCharacter { public Knigh...

This needs refactoring...

quaint mantle Dec 22, 2023, 7:46 PM

#

lol

waxen plinth Dec 22, 2023, 7:46 PM

#

like you could imagine it looking like this in config

quaint mantle Dec 22, 2023, 7:46 PM

#

the thing is tho

#

I dont want characters and custom items to be coupled

echo basalt Dec 22, 2023, 7:47 PM

#

quaint mantle ```java public class KnightCharacter extends CustomCharacter { public Knigh...

Yeah so here's the thing

orchid trout Dec 22, 2023, 7:47 PM

#

lost matrix Btw you should probably reduce your nesting my refactoring the codeblock into a ...

echo basalt Dec 22, 2023, 7:47 PM

#

None of this needs to be set in code

#

You can make a parser and read all of these values from a config

waxen plinth Dec 22, 2023, 7:47 PM

#

characters:
  Knight:
    verse: CLASSIC
    referenceName: "classic_knight"
    display_name: "Classic Knight"
    helmet: ...```

#

^

lost matrix Dec 22, 2023, 7:48 PM

#

orchid trout

I think this looks better. Why is your method package-private?

orchid trout Dec 22, 2023, 7:48 PM

#

i have my database in my manager class

#

its public in manager class

#

super epic not confusing

#

waxen plinth Dec 22, 2023, 7:49 PM

#

waxen plinth ```yaml characters: Knight: verse: CLASSIC referenceName: "classic_kni...

you could create a base class that is loaded from config which holds all of the regular properties of the character

lost matrix Dec 22, 2023, 7:49 PM

#

echo basalt You can make a parser and read all of these values from a config

But default values have to come from somewhere. 🙂

orchid trout Dec 22, 2023, 7:49 PM

#

so i dont have to have instance of manager and database when i need them

waxen plinth Dec 22, 2023, 7:50 PM

#

and then you could make a wrapper class that is passed the config and can specify any additional behavior

#

if there is no additional behavior it can just be the base class like Character or something

#

make a registry that stores them by their reference name in a Map<String, Character> and you're set

quaint mantle Dec 22, 2023, 7:51 PM

#

Uh

#

so I don't use my old config system?

waxen plinth Dec 22, 2023, 7:54 PM

#

well it looks like you weren't loading these with the old config system

quaint mantle Dec 22, 2023, 7:55 PM

#

Wdym wasnt

waxen plinth Dec 22, 2023, 7:56 PM

#

you're using a builder

quaint mantle Dec 22, 2023, 7:56 PM

#

Oh I meant the one using gson

waxen plinth Dec 22, 2023, 8:02 PM

#

that could work

waxen plinth Dec 22, 2023, 8:02 PM

#

waxen plinth ```yaml characters: Knight: verse: CLASSIC referenceName: "classic_kni...

can gson convert to yaml?

#

if not, I have a config library which can

#

https://github.com/boxbeam/RedLib/wiki/Config-Manager

quaint mantle Dec 22, 2023, 8:12 PM

#

Well

#

I choose json cause snake yaml or whatever it's called looks kinda weird to use

#

And json looks fine with the pretty printint

waxen plinth Dec 22, 2023, 8:13 PM

#

probably annoying to configure by hand though

waxen plinth Dec 22, 2023, 8:13 PM

#

waxen plinth <https://github.com/boxbeam/RedLib/wiki/Config-Manager>

this works very much like gson, you won't have to touch snakeyaml at all

#

you just define your data and it will serialize and deserialize it automatically

quaint mantle Dec 22, 2023, 8:17 PM

#

Lmao

#

What doesn't red lib have 💀

waxen plinth Dec 22, 2023, 8:18 PM

#

exactly

#

I wouldn't use its command manager though

#

Ordinate is much better

quaint mantle Dec 22, 2023, 8:19 PM

#

ok so

#

well

#

when I end up having my configs

#

Do I pass in a ConfigurationSection, or a concrete class

#

like KnightBootsConfig

remote swallow Dec 22, 2023, 8:20 PM

#

for red lib?

waxen plinth Dec 22, 2023, 8:20 PM

#

concrete class

#

the point of the deserialized object is to abstract away the config layer

#

and provide the data directly

quaint mantle Dec 22, 2023, 8:22 PM

#

So...

#

A config for each item basically

remote swallow Dec 22, 2023, 8:22 PM

#

sounds a bit pointless

#

you can have 1 config for all of it

waxen plinth Dec 22, 2023, 8:28 PM

#

quaint mantle A config for each item basically

only if they have additional behavior to define

#

again, there's no way you're getting overridden behavior per item unless you have a class per item or pass around lambdas to define that behavior

#

or somehow make all of that behavior expressible through config

river oracle Dec 22, 2023, 8:30 PM

#

waxen plinth only if they have additional behavior to define

sounds like dumb behavior. Why would it be beneficial to have a config for each item instead of deserialize one config into an array of items

waxen plinth Dec 22, 2023, 8:32 PM

#

I'm literally saying you don't have an additional config for each item

#

each item can be deserialized into a common config class storing all of the base metadata

#

and then you can attach additional behavior if you want to by either wrapping it in a class that defines that behavior or passing around lambdas

#

but even if you do define that additional behavior, you're not redeclaring the config logic, you're just reading the config data from variables

ivory sleet Dec 22, 2023, 8:36 PM

#

We just love those bean and orm libs

#

:^)

waxen plinth Dec 22, 2023, 8:37 PM

#

serialization has always been the source of way too much boilerplate

#

gotta get rid of it somehow

ivory sleet Dec 22, 2023, 8:37 PM

#

Yeah true, there is that aspect to not neglect

waxen plinth Dec 22, 2023, 8:38 PM

#

one of my favorite things about rust is that you can just slap a #[derive(Serialize, Deserialize)] on any type and basically be able to convert it to any serialization format

#

json, toml, yaml, xml, I think it might even work for sql

#

raw bytes

ivory sleet Dec 22, 2023, 8:39 PM

#

Oh yeah, but rust is just a chad language in general lol

waxen plinth Dec 22, 2023, 8:39 PM

#

fr

echo basalt Dec 22, 2023, 8:45 PM

#

bro came back from the dead just to shit on java

quaint mantle Dec 22, 2023, 8:46 PM

#

waxen plinth again, there's no way you're getting overridden behavior per item unless you hav...

I might have a class per item lol

#

That was the original plan

ivory sleet Dec 22, 2023, 8:48 PM

#

Maybe do it similarly to how mc does it, I mean that has its disadvantages also, but yeah just an idea

cyan void Dec 22, 2023, 8:48 PM

#

i got this code but it dosent tdo the breaking when its netherite i know its not because of the config because all the others work:


import org.bukkit.Bukkit;
import org.bukkit.Material;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockDamageAbortEvent;
import org.bukkit.event.block.BlockDamageEvent;
import org.bukkit.inventory.ItemStack;
import org.bukkit.scheduler.BukkitTask;
import uk.co.agwoo.zelrpg.Functions;
import uk.co.agwoo.zelrpg.ZelRPG;

import java.util.HashSet;
import java.util.Set;
import java.util.UUID;

public class BlockDamageListener implements Listener {
    private final Set<UUID> damagingPlayers = new HashSet<>();
    public BukkitTask task;

#

    public void onBlockDamage(BlockDamageEvent event) {
        Player player = event.getPlayer();
        ItemStack heldItem = player.getInventory().getItemInMainHand();
        FileConfiguration config = ZelRPG.config;

        if (Functions.isPickaxe(heldItem.getType())) {

            int delay;
            if (heldItem.getType().equals(Material.WOODEN_PICKAXE)) {
                delay = config.getInt("timings.tools.pickaxes.wooden");
            } else if (heldItem.getType().equals(Material.STONE_PICKAXE)){
                delay = config.getInt("timings.tools.pickaxes.stone");
            } else if (heldItem.getType().equals(Material.IRON_PICKAXE)){
                delay = config.getInt("timings.tools.pickaxes.iron");
            } else if (heldItem.getType().equals(Material.GOLDEN_PICKAXE)){
                delay = config.getInt("timings.tools.pickaxes.golden");
            } else if (heldItem.getType().equals(Material.DIAMOND_PICKAXE)){
                delay = config.getInt("timings.tools.pickaxes.diamond");
            } else if (heldItem.getType().equals(Material.NETHERITE_PICKAXE)){
                delay = config.getInt("timings.tools.pickaxes.netherite");
            }

            else {
                delay = config.getInt("timings.tools.pickaxes.wooden");
            }

            player.sendMessage(heldItem.getType() + "");

            damagingPlayers.add(player.getUniqueId());

            task = Bukkit.getScheduler().runTaskLater(ZelRPG.getInstance(), () -> {
                if (damagingPlayers.contains(player.getUniqueId())) {
                    event.getBlock().breakNaturally();
                }
                damagingPlayers.remove(player.getUniqueId());
            }, delay);
        }
    }

#

    public void onBlockDamageAbort(BlockDamageAbortEvent event) {
        Player player = event.getPlayer();

        damagingPlayers.remove(player.getUniqueId());
        if (task != null) {
            task.cancel();
        }
    }
}```

ivory sleet Dec 22, 2023, 8:49 PM

#

Ehm

#

Every time the event is called, u just store the a new bukkit task

#

Is that intended? I mean you basically forget about the older ones

quaint mantle Dec 22, 2023, 8:53 PM

#

ivory sleet Maybe do it similarly to how mc does it, I mean that has its **disadvantages** a...

Wdym how mc does it

ivory sleet Dec 22, 2023, 8:55 PM

#

I pretty much meant how they structured their design after items, materials etc

quaint mantle Dec 22, 2023, 8:57 PM

#

Yeah how

waxen plinth Dec 22, 2023, 8:58 PM

#

one class per

ivory sleet Dec 22, 2023, 9:00 PM

#

I mean they have some sort of type inheritance such that there is a base/universal type all item subtypes derive

#

But yea

minor junco Dec 22, 2023, 9:04 PM

#

Damn whats this if else clause hell I'm witnessing

quaint mantle Dec 22, 2023, 9:05 PM

#

ivory sleet Maybe do it similarly to how mc does it, I mean that has its **disadvantages** a...

If it's one class per item, that is how I originally intended it to be

ivory sleet Dec 22, 2023, 9:05 PM

#

I mean, not sure every item does need its own class

#

But maybe a subset of items do shrug

quaint mantle Dec 22, 2023, 9:05 PM

#

why not I be consistent with it

ivory sleet Dec 22, 2023, 9:06 PM

#

I mean sure, but on the other hand, dont overdo it and keep it simple

#

look at mc’s source

#

They keep their code open for extension

quaint mantle Dec 22, 2023, 9:06 PM

#

maybe I should make a core for this and have extension plugins

ivory sleet Dec 22, 2023, 9:06 PM

#

that is, you’ll see some materials with custom classes, and some materials just represented with the base material class

#

Or well they call materials for items but you get the point :)

quaint mantle Dec 22, 2023, 9:07 PM

#

quaint mantle maybe I should make a core for this and have extension plugins

Should I do this

ivory sleet Dec 22, 2023, 9:08 PM

#

If you want

inner mulch Dec 22, 2023, 9:14 PM

#

can someone explain why tf sometimes == or .equals() have different results?

if you dont want to explain just ignore it dont throw lernjavas at me pls

ivory sleet Dec 22, 2023, 9:14 PM

#

okay here is the rule basically

#

if A.equals(B) is true
then A == B should always be true
the converse is not necessarily true

A.equals(B) may be true even though A == B is false, this implies that there might be cases where different objects C and D are not the same (C != D) but their data/content is the same so C.equals(D) still holds true

inner mulch Dec 22, 2023, 9:17 PM

#

ivory sleet if A.equals(B) is true then A == B should always be true **the converse is not n...

okay, thanks :)

ivory sleet Dec 22, 2023, 9:17 PM

#

yeah

#

For instance if you do something like
A = new String("test".toCharArray());
B = new String("test".toCharArray());
then A != B is true or equivalently A == B is false

yet A.equals(B) is true

inner mulch Dec 22, 2023, 9:20 PM

#

okay, yeah thats kinda confusing, i guess i need to adapt to .equals()

proud badge Dec 22, 2023, 9:22 PM

#

Whats the best way to make a multipaged chat answer?

ivory sleet Dec 22, 2023, 9:22 PM

#

equals() basically tests if two objects contain the same data

#

And if the two objects are the same object, then ofc the data will be the same

inner mulch Dec 22, 2023, 9:23 PM

#

ok

ivory sleet Dec 22, 2023, 9:23 PM

#

proud badge Whats the best way to make a multipaged chat answer?

Example?

proud badge Dec 22, 2023, 9:23 PM

#

Coreprotects lookup feature has multiple pages of information.

#

I have a similar query feature for my plugin

#

Well in the works

ivory sleet Dec 22, 2023, 9:24 PM

#

do u have an image or sth of how it looks? :>

proud badge Dec 22, 2023, 9:24 PM

#

Whats the best way to store the information so the player can run the command to go to the next page?

proud badge Dec 22, 2023, 9:24 PM

#

ivory sleet do u have an image or sth of how it looks? :>

yes

#

oh image wait

#

1 sec let me boot up my test server

proud badge Dec 22, 2023, 9:28 PM

#

ivory sleet do u have an image or sth of how it looks? :>

Here, its a query system, right now it just shows the 8 most recent ones (17-10) but I plan to add a pages system so I could see more (9-2 etc). What would be the best way to do this/store information?

ivory sleet Dec 22, 2023, 9:28 PM

#

I think you keep the pages absolute

#

And in the command you just provide the TUI if needed

#

(Like a next/previous/jump to, buttons)

#

Else ned, to calculate lines and pages etc, modulo usually works great :)

quaint mantle Dec 22, 2023, 9:31 PM

#

is it ok if I override java's classes

#

like

#

I rename something to Character

ivory sleet Dec 22, 2023, 9:32 PM

#

What exactly is that class doing

#

I can prov cook up a better name for u

proud badge Dec 22, 2023, 9:32 PM

#

I think ill make like a /query fromindex command, for example if it goes 20-13, I’ll use a text component that does /query fromindex 12 (cause 12 is 1 less than 13) and it will go from there

quaint mantle Dec 22, 2023, 9:32 PM

#

ivory sleet I can prov cook up a better name for u

CustomCharacter

#

CCharacter?

ivory sleet Dec 22, 2023, 9:33 PM

#

Maybe sth like Symbol, Letter, Digit etc

#

instead

quaint mantle Dec 22, 2023, 9:33 PM

#

what

#

no

ivory sleet Dec 22, 2023, 9:33 PM

#

Name for the class

quaint mantle Dec 22, 2023, 9:33 PM

#

like character as in person

ivory sleet Dec 22, 2023, 9:33 PM

#

Oh

#

User maybe?

#

Profile perhaps?

quaint mantle Dec 22, 2023, 9:34 PM

#

nah that's kinda misleading

#

my server name is CharacterWar

ivory sleet Dec 22, 2023, 9:34 PM

#

yeah, but code wise the names can be different yk

#

And then when u display it to the end user, translate it back

quaint mantle Dec 22, 2023, 9:35 PM

#

bruh

#

user sounds like a user tho

#

it's like

#

someone that

#

idk how to explain

proud badge Dec 22, 2023, 9:35 PM

#

Variable/object names dont really matter in java if youre the only developer

#

And you can understand what you meant

ivory sleet Dec 22, 2023, 9:36 PM

#

I mean it’s convenient not to use the names of classes that already exist in the java std library

quaint mantle Dec 22, 2023, 9:37 PM

#

do u think a "Person" is a good class name 💀

ivory sleet Dec 22, 2023, 9:37 PM

#

Sounds fine

quaint mantle Dec 22, 2023, 9:41 PM

#

nah im just override character

#

never rly seen the character class being used anyway

hasty oyster Dec 22, 2023, 10:18 PM

#

Maven CLI Invocation

quaint mantle Dec 23, 2023, 1:11 AM

#

how can I enforce something like this (getItem()) that the item has a pdc which contains a specific namespacedkey

public interface CustomItemProvider {

    ItemStack getItem();

}

carmine mica Dec 23, 2023, 1:11 AM

#

to rephrase, you want to enforce that the item returned by getItem has a matching pdc key?

quaint mantle Dec 23, 2023, 1:11 AM

#

yes

#

or has a pdc key set

carmine mica Dec 23, 2023, 1:12 AM

#

I mean there isn't a way to do it at compile time, but at runtime, wherever you call getItem, just verify a key has been set

#

you could add the key yourself if you added another method to get the key, and then when you call getItem you add the key yourself

#

but that is more of a structural change

quaint mantle Dec 23, 2023, 1:20 AM

#

okay

#

ill just add it in the docs

astral pilot Dec 23, 2023, 3:55 AM

#

does Location#subtract mutates itself?

echo basalt Dec 23, 2023, 3:58 AM

#

Yes

#

Opinions on an item abstraction API?

public class MyPhone extends CustomItem {

  @Override
  public ClickResult handleClick(Player player, ItemClickContext context) {
    // The context is basically a PlayerInteractEvent wrapper 
    Menu menu = ...;
    menu.open(player);

    return ClickResult.PREVENT_ACTION;
  }

  @Override
  public String getIdentifier() {
    return "phone";
  }
}

#

StareTrollThink

#

I could change all the clickresult logic to the ItemClickContext object

#

Or should I do something a bit more picky

#

@Override
public ClickContext getClickContext() {
  return ClickContext.builder()
    .limitTypes(ClickType.LEFT)
    .entityPolicy(EntityPolicy.IGNORE_ENTITY_CLICKS)
    .filter((player, context) -> player.isSneaking()) // shift-left click
    .build();
}

#

Seems like I'm overengineering clicking

floral hedge Dec 23, 2023, 4:38 AM

#

I made a custom intelligence system for my plugin
the code i use to update it (along with relevant feedback) is this

Score score = Objects.requireNonNull(Objects.requireNonNull(Plugin.getInstance().getServer().getScoreboardManager()).getMainScoreboard().getObjective("Intelligence")).getScore(p.getName());
if(score.getScore() < 1000) {
    score.setScore(score.getScore() + 1);
    Plugin.getInstance().getLogger().info(p.getName() + " damaged " + e.getEntity().getName() + ", gaining 1 Intelligence.  Current intelligence: " + (score.getScore() + 1));
    p.spigot().sendMessage(ChatMessageType.ACTION_BAR, TextComponent.fromLegacyText("Intelligence: " + score.getScore() + "/1000", ChatColor.AQUA.asBungee()));
} else {
    Plugin.getInstance().getLogger().info(p.getName() + " damaged " + e.getEntity().getName() + ", but they are at max Intelligence.  Current intelligence: " + (score.getScore() + 1));
    p.spigot().sendMessage(ChatMessageType.ACTION_BAR, TextComponent.fromLegacyText("Intelligence: " + score.getScore() + "/1000 " + ChatColor.RED + ChatColor.BOLD + "MAX INTELLIGENCE", ChatColor.AQUA.asBungee()));
}```

this worked in version 1.20.1, but upon updating to 1.20.4 it no longer updates the score of the scoreboard, is there any reason as to why this may be?

echo basalt Dec 23, 2023, 4:47 AM

#

this hurts to read

spark flower Dec 23, 2023, 7:02 AM

#

hello!
how to disable this inventory sort?

sullen marlin Dec 23, 2023, 7:31 AM

#

floral hedge I made a custom intelligence system for my plugin the code i use to update it (a...

create a minimal test case and open a bug report

#

?jira

undone axleBOT Dec 23, 2023, 7:31 AM

#

https://hub.spigotmc.org/jira/secure/Dashboard.jspa

floral summit Dec 23, 2023, 7:42 AM

#

so, I'm trying to make a Placeholder in my plugin that changes every few minutes. but I don't know how to give it a timer.
basically I have a txt file with a list of things I want it to display and I want it to go to the next line of the file every like 5 minutes but I dont know how to setup a timer for it.
any help is appreciated!
please ping me when u respond!

jagged thicket Dec 23, 2023, 7:47 AM

#

floral summit so, I'm trying to make a Placeholder in my plugin that changes every few minutes...

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/scheduler/BukkitScheduler.html#scheduleSyncRepeatingTask(org.bukkit.plugin.Plugin,java.lang.Runnable,long,long)

BukkitScheduler (Spigot-API 1.20.4-R0.1-SNAPSHOT API)

declaration: package: org.bukkit.scheduler, interface: BukkitScheduler

#

i think this might help you

floral summit Dec 23, 2023, 7:50 AM

#

I think it might just be what I wanted. thanks!!

icy beacon Dec 23, 2023, 8:38 AM

#

Is it possible to disable this auto-condensing in intellij?

#

I want it to look like this

remote swallow Dec 23, 2023, 8:40 AM

#

At the top of the project files theres three dots clicl that go into the tree appearance and disable compact middle packages

icy beacon Dec 23, 2023, 8:43 AM

#

Ooooooooooo

#

Thanks 🙂

twin venture Dec 23, 2023, 9:28 AM

#

hi why this keep giving me null?

#

#

this one exactly :

#

also the cosmetic data is there in the mongodb :

#

the players is also in the mongodb :

worn yew Dec 23, 2023, 10:21 AM

#

does anybody know how to invert world edit selection i want to make only some chunks/areas are avaibale other block/chunk will be deleted

cyan void Dec 23, 2023, 10:26 AM

#

worn yew does anybody know how to invert world edit selection i want to make only some ch...

do you mean like a plugin to do that or for a world edit tutorial

cyan void Dec 23, 2023, 10:28 AM

#

worn yew does anybody know how to invert world edit selection i want to make only some ch...

also tlauncher is spyware

quaint mantle Dec 23, 2023, 10:45 AM

#

I have:

Map<String, Object> serializedMap = itemStack.serialize();
String itemStackString = String.valueOf(serializedMap);

and i saved the string somewhere. Now i want to get "serializedMap" back, how would i do it?

lost matrix Dec 23, 2023, 10:46 AM

#

quaint mantle I have: ``` Map<String, Object> serializedMap = itemStack.serialize(); String it...

That doesnt work

quaint mantle Dec 23, 2023, 10:46 AM

#

lost matrix That doesnt work

what

worn yew Dec 23, 2023, 10:46 AM

#

cyan void do you mean like a plugin to do that or for a world edit tutorial

yeah

worn yew Dec 23, 2023, 10:46 AM

#

cyan void also tlauncher is spyware

ik but what can i do i am poor ;-;

quaint mantle Dec 23, 2023, 10:46 AM

#

itemStackString returned {v=3578, type=DIAMOND_SWORD, meta=UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"text":"Teast@Teast"}, enchants={FIRE_ASPECT=2}}} so i think it works?

lost matrix Dec 23, 2023, 10:47 AM

#

quaint mantle itemStackString returned ```{v=3578, type=DIAMOND_SWORD, meta=UNSPECIFIC_META:{m...

It might look like it works, but this is not how serialization works.

#

What is your original plan?

quaint mantle Dec 23, 2023, 10:48 AM

#

to save the itemstack as a string

#

and vise versa

chrome beacon Dec 23, 2023, 10:48 AM

#

Save where and why

lost matrix Dec 23, 2023, 10:48 AM

#

What data object does this String get written in?

cyan void Dec 23, 2023, 10:48 AM

#

worn yew ik but what can i do i am poor ;-;

yea uhhh tlauncher has a keylogger in it and moitors your web activity, steals ur passwords

dry hazel Dec 23, 2023, 10:49 AM

#

quaint mantle to save the itemstack as a string

toStringification is a one-way process, it's not supposed to be deserialized

worn yew Dec 23, 2023, 10:50 AM

#

cyan void yea uhhh tlauncher has a keylogger in it and moitors your web activity, steals u...

ummmm anyway ;-;

quaint mantle Dec 23, 2023, 10:50 AM

#

chrome beacon Save where and why

in a file

#

not a yml file tho

lost matrix Dec 23, 2023, 10:50 AM

#

twin venture hi why this keep giving me null?

typo in the field name maybe?
Debug your code all the way up.

lost matrix Dec 23, 2023, 10:50 AM

#

quaint mantle in a file

Which format?

quaint mantle Dec 23, 2023, 10:50 AM

#

lost matrix Which format?

txt

worn yew Dec 23, 2023, 10:51 AM

#

cyan void yea uhhh tlauncher has a keylogger in it and moitors your web activity, steals u...

i dont have any purchase also my pc is potato so i dont care that much ;-;

lost matrix Dec 23, 2023, 10:51 AM

#

quaint mantle txt

cat_what

worn yew Dec 23, 2023, 10:51 AM

#

any way can you help me with world edit tho

clever lantern Dec 23, 2023, 10:52 AM

#

any guides to testing plugins? idk what to use, mockito or mock bukkit, maybe both idk ?

shadow night Dec 23, 2023, 10:53 AM

#

worn yew ik but what can i do i am poor ;-;

There are other, better cracked launchers, just saying.

twin venture Dec 23, 2023, 10:53 AM

#

lost matrix typo in the field name maybe? Debug your code all the way up.

i made sure its the name!

quaint mantle Dec 23, 2023, 10:53 AM

#

lost matrix <:cat_what:679424989102997537>

i know that serialized stuff isnt supposed to be put in a txt file, but i really need a method that works with txt

twin venture Dec 23, 2023, 10:53 AM

#

#

chrome beacon Dec 23, 2023, 10:53 AM

#

quaint mantle txt

Why

worn yew Dec 23, 2023, 10:53 AM

#

shadow night There are other, better cracked launchers, just saying.

i will deal with that later but now i need help with world edit T_T

quaint mantle Dec 23, 2023, 10:54 AM

#

chrome beacon Why

to store container data

lost matrix Dec 23, 2023, 10:54 AM

#

quaint mantle i know that serialized stuff isnt supposed to be put in a txt file, but i really...

Use the BukkitObjectOutputStream, create a byte[] with it, pipe it into a Base64 encoder to get a String.
Im guessing since its txt you wont need to edit it.

twin venture Dec 23, 2023, 10:54 AM

#

this is null for some reason :

lost matrix Dec 23, 2023, 10:54 AM

#

quaint mantle to store container data

Why not just use yml for this?

quaint mantle Dec 23, 2023, 10:54 AM

#

lost matrix Why not just use yml for this?

0.0;0.0;0.0@minecraft:chest[facing=north,type=single,waterlogged=false]@13@SPLITINDEX@{v=3578, type=DIAMOND_SWORD, meta=UNSPECIFIC_META:{meta-type=UNSPECIFIC, display-name={"text":"Teast@Teast"}, enchants={FIRE_ASPECT=2}}}

#

this is how it looks like full

#

yes i know its bad

lost matrix Dec 23, 2023, 10:55 AM

#

quaint mantle ```0.0;0.0;0.0@minecraft:chest[facing=north,type=single,waterlogged=false]@13@SP...

Let me start up my IDE and show you how easy it is with yml

quaint mantle Dec 23, 2023, 10:55 AM

#

lost matrix Let me start up my IDE and show you how easy it is with yml

ik that it is easy

#

i can just use getItemStack with yml

lost matrix Dec 23, 2023, 10:55 AM

#

Right, so then what is your argument for txt

twin venture Dec 23, 2023, 10:55 AM

#

twin venture this is null for some reason :

This is how i use it :

quaint mantle Dec 23, 2023, 10:56 AM

#

lost matrix Right, so then what is your argument for txt

because txt is compact

lost matrix Dec 23, 2023, 10:56 AM

#

Why not use a raw binary file then?

quaint mantle Dec 23, 2023, 10:56 AM

#

lost matrix Why not use a raw binary file then?

cuz of filtering

chrome beacon Dec 23, 2023, 10:57 AM

#

quaint mantle because txt is compact

If you're trying to save disk space txt won't help much

quaint mantle Dec 23, 2023, 10:57 AM

#

the files it generates should be used in plugin resource

chrome beacon Dec 23, 2023, 10:57 AM

#

You can disable filtering

lost matrix Dec 23, 2023, 10:57 AM

#

What are you trying to filter?
I sure hope you wont filter files by their content, because that can get horribly slow, really fast.

quaint mantle Dec 23, 2023, 10:57 AM

#

lost matrix What are you trying to filter? I sure hope you wont filter files by their conten...

resource filtering from maven

#

its not mine

lost matrix Dec 23, 2023, 10:58 AM

#

Ah you can exclude bin files from being filtered

quaint mantle Dec 23, 2023, 10:58 AM

#

but ye i could do exclude but do it for every file?

#

wait i could just exclude a custom extension

#

thanks

dry hazel Dec 23, 2023, 10:58 AM

#

wildcards exist yea

worn yew Dec 23, 2023, 10:58 AM

#

worn yew does anybody know how to invert world edit selection i want to make only some ch...

.

twin venture Dec 23, 2023, 10:58 AM

#

twin venture This is how i use it :

any ideasxd?

lost matrix Dec 23, 2023, 10:59 AM

#

Yeah just create your own .utter_rubbish extension and let it not being filtered.

shadow night Dec 23, 2023, 10:59 AM

#

utter rubbish

chrome beacon Dec 23, 2023, 10:59 AM

#

.bin

lost matrix Dec 23, 2023, 11:00 AM

#

twin venture This is how i use it :

Debug and check when your Cosmetic becomes null and tell us the pos

quartz dove Dec 23, 2023, 11:01 AM

#

Hey all my name is Shiv im a beginner dev. Im trying to make a building minigame based on random prompts that are stored in the config file. So far the command "/prompt get" works well where a book is given to the player with a random string in the page from the config. What i need help with is adding and removing these promts from the config file with the commands /prompt add <msg> and /prompt rem <msg>

eternal oxide Dec 23, 2023, 11:03 AM

#

?configs

undone axleBOT Dec 23, 2023, 11:03 AM

#

See this wiki page on how to use custom configuration files: https://www.spigotmc.org/wiki/config-files/

eternal oxide Dec 23, 2023, 11:03 AM

#

just alter what you want in the config and call saveConfig()

worn yew Dec 23, 2023, 11:05 AM

#

cyan void do you mean like a plugin to do that or for a world edit tutorial

worldedit tutorial

shadow night Dec 23, 2023, 11:05 AM

#

If I remember correctly, yaml can do stuff like

map:
  - key: value
``` right?

quaint mantle Dec 23, 2023, 11:05 AM

#

lost matrix Yeah just create your own ``.utter_rubbish`` extension and let it not being filt...

After making my class serializable, i can just save the Map<> instead, right?

#

not just the string

eternal oxide Dec 23, 2023, 11:05 AM

#

shadow night If I remember correctly, yaml can do stuff like ```yml map: - key: value ``` r...

no - as that indicates a list element

shadow night Dec 23, 2023, 11:05 AM

#

Hmm

#

just

map:
  key: value
```?

eternal oxide Dec 23, 2023, 11:06 AM

#

yep

shadow night Dec 23, 2023, 11:06 AM

#

And that map element can be gotten as a HashMap, right?

eternal oxide Dec 23, 2023, 11:06 AM

#

yes

#

get("map")

#

well that returns a ConfigurationSection but call getValues() on it to get the backing Map

shadow night Dec 23, 2023, 11:07 AM

#

Nice

twin venture Dec 23, 2023, 11:10 AM

#

lost matrix Debug and check when your Cosmetic becomes null and tell us the pos

its bugged here :

#

the data is already in the databse for both the cosmeticWrapper and the player data ..

#

but it send null when i try to get the Cosetmic object

#

why i use Wrapper , cuz gson don't support abstract class serliztion

#

lost matrix Dec 23, 2023, 11:14 AM

#

twin venture its bugged here :

Show me:

How you create your collection object
The cosmetic wrapper

twin venture Dec 23, 2023, 11:14 AM

#

and i tried to do it without the transient keyword , and with

lost matrix Dec 23, 2023, 11:14 AM

#

twin venture why i use Wrapper , cuz gson don't support abstract class serliztion

It does

twin venture Dec 23, 2023, 11:14 AM

#

i tried , it doesn't

#

it send me a really long gson errors

#

this is where i create the CosmeticWrapper :

#

and i use it here :

#

this is only in lobby , cuz i don't want the file creation of the glass comsetic in all servers , that will be so redundent

#

only in lobby , and after that it will load it to mongodb, and from there other servers can get it from mongodb

lost matrix Dec 23, 2023, 11:16 AM

#

Show me where you create your mongo collection.
Print out what document.toJson() looks like.

twin venture Dec 23, 2023, 11:19 AM

#

1-Here :

#

last pic is onEnable

#

in Lobby

lost matrix Dec 23, 2023, 11:20 AM

#

Show me where you create your mongo collection.

twin venture Dec 23, 2023, 11:21 AM

#

#

it works i mean the mongo , connect no problem

#

lost matrix Dec 23, 2023, 11:22 AM

#

Ok, then print out what your document.toJson() returns.

twin venture Dec 23, 2023, 11:23 AM

#

alright 1 moment..

#

#

some values are null weird??

cyan void Dec 23, 2023, 11:25 AM

#

worn yew worldedit tutorial

can i recomend joining the engin hub discord server: https://discord.com/invite/enginehub

#

they can probaly help u better

twin venture Dec 23, 2023, 11:25 AM

#

#

yeah it still giving me null ..

faint aspen Dec 23, 2023, 11:35 AM

#

what is null? document?

#

or the result of toJson?

twin venture Dec 23, 2023, 11:35 AM

#

the cosetmic it self..

fair crest Dec 23, 2023, 11:36 AM

#

hey

twin venture Dec 23, 2023, 11:36 AM

#

this one

#

faint aspen Dec 23, 2023, 11:36 AM

#

yeah bc its transient

fair crest Dec 23, 2023, 11:36 AM

#

Hey guys, how do i make a loaded crossbow?

#

using Java

twin venture Dec 23, 2023, 11:36 AM

#

faint aspen yeah bc its transient

i tried without transient

shadow night Dec 23, 2023, 11:36 AM

#

What does transient even do

quiet ice Dec 23, 2023, 11:37 AM

#

shadow night What does transient even do

Prevents it from being serialized

shadow night Dec 23, 2023, 11:37 AM

#

Ah

twin venture Dec 23, 2023, 11:37 AM

#

shadow night What does transient even do

prevent it from being serlized with gson

quiet ice Dec 23, 2023, 11:37 AM

#

Why did you even apply transient here?

faint aspen Dec 23, 2023, 11:38 AM

#

this GSON instance how did you create it, did you provide any configuration via the builder to create the instance?

#

Does it work now for some reason?

twin venture Dec 23, 2023, 11:44 AM

#

faint aspen Does it work now for some reason?

no still not working ..

brisk estuary Dec 23, 2023, 11:45 AM

#

Hey, I have a plugin already in production and I want to include a new feature, which will be basically a NPC with a RightClickEvent. The two options I think I have is using the Citizens API or using pure nms. The thing is that I don't want to force the servers that are already using my plugin to download Citizens, so I guess the best option would be using pure NMS. It's a 1.19+ plugin, so apparently nms packages names do not include the version, so I don't know how it would work having different nms dependencies in the same project if they have packages with the same name. Also, my maven project is not a multi module one. Does anybody know how I should proceed in this case? (I have just started with nms)

twin venture Dec 23, 2023, 11:45 AM

#

#

this si the gson builder i have

#

faint aspen Dec 23, 2023, 11:45 AM

#

twin venture no still not working ..

An everything else in the Wrapper class is initialzed?

twin venture Dec 23, 2023, 11:46 AM

#

#

should be

faint aspen Dec 23, 2023, 11:46 AM

#

so you dont know?^^

twin venture Dec 23, 2023, 11:46 AM

#

faint aspen Dec 23, 2023, 11:52 AM

#

maybe log or inspect the json (for the cosmetic) which you give gson

#

Could be something wrong with the encoding of the text maybe

twin venture Dec 23, 2023, 11:53 AM

#

Gonna check it out

fair crest Dec 23, 2023, 11:54 AM

#

Yo guys. how do i make it so it gives a player a loaded crossbow

faint aspen Dec 23, 2023, 11:55 AM

#

what do you mean by loaded?

#

ahh sorry

#

I read "bow" for crossbow it makes sense xD

quiet ice Dec 23, 2023, 11:58 AM

#

fair crest Yo guys. how do i make it so it gives a player a loaded crossbow

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/meta/CrossbowMeta.html#addChargedProjectile(org.bukkit.inventory.ItemStack)

#

So getItemMeta of your item, cast it to CrossbowMeta, invoke said method on it and use setItemMeta on that itemstack again.

worn yew Dec 23, 2023, 11:59 AM

#

cyan void can i recomend joining the engin hub discord server: https://discord.com/invite/...

ok

fair crest Dec 23, 2023, 12:03 PM

#

quiet ice <https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/meta/CrossbowMeta...

thanks i'll check that out.

short raptor Dec 23, 2023, 12:06 PM

#

Can BlockPlaceEvent ever be triggered by enderman placing a block?

#

In which case I assume event.getPlayer would be null

shadow night Dec 23, 2023, 12:06 PM

#

That's a very interesting case

faint aspen Dec 23, 2023, 12:09 PM

#

Called when a block is placed by a player. says the docu so I guess only player can trigger this

short raptor Dec 23, 2023, 12:09 PM

#

Yeah I think so. getPlayer is also marked as nonnull

#

So there couldn't be any case where it doesn't give a player

quiet ice Dec 23, 2023, 12:09 PM

#

Paper defines the player as @NotNull in the constructor, so yeah

#

Though it is a good question what event will be called for this - EntityBlockFormEvent comes to mind, but that is unlikely to be the case

#

Well there is EntityChangeBlockEvent, that is probably the one being used

magic raptor Dec 23, 2023, 12:12 PM

#

Guys I have a very weird issues, what are the causes for Bungeecord to return false to a ping request using the api? Even if the server is online (for sure, it's not timeout).

#

The ping api is really weird tbh, functions 1 time on 100

sterile sapphire Dec 23, 2023, 12:17 PM

#

When your in a project and the wrighting is red how do u import the class?

hazy parrot Dec 23, 2023, 12:18 PM

#

Hover over and alt+enter

#

Assuming ij

quiet ice Dec 23, 2023, 12:18 PM

#

Ctrl + Shift + O in Eclipse

sterile sapphire Dec 23, 2023, 12:18 PM

#

quiet ice Dec 23, 2023, 12:19 PM

#

It's CommandSender

#

Notice the difference in casing

sterile sapphire Dec 23, 2023, 12:19 PM

#

Oh yea

#

That’s annoying, thanks

quiet ice Dec 23, 2023, 12:19 PM

#

Uh, generally autocompletion should nullify that problem, as long as you eagerly accept the IDE's suggestions

short raptor Dec 23, 2023, 12:20 PM

#

I am trying to stop the player's block from getting consumde when he places it, but this event doesn't work. If I put + 1 on the setamount line, then he starts gaining block

#

What is causing that behaviour

#

I don't want to just use inventory.additem because then it could go into any stack

#

I need it to return to the same stack

quiet ice Dec 23, 2023, 12:21 PM

#

Could it be that they are ghost items?

short raptor Dec 23, 2023, 12:22 PM

#

I will check right now but I doubt it

#

Nope it's not a visual thing

quiet ice Dec 23, 2023, 12:23 PM

#

Also, beware that you can place block via the OffHand - make sure to use getHand();
The easiest approach would be to schedule the change the next tick, but that isn't great

short raptor Dec 23, 2023, 12:23 PM

#

I was thinking of schedule but then it's got a weird lag

#

And thanks about the get hand I didn't realise

quiet ice Dec 23, 2023, 12:25 PM

#

You could cancel the event and handle it yourself, but that is also a bit bogus

short raptor Dec 23, 2023, 12:26 PM

#

Yeah then I have to place the block myself and there are edge cases and it's getting complicated

#

I mght have to just schedule it

quiet ice Dec 23, 2023, 12:29 PM

#

I'd try player.getInventory().setItem(event.getHand(), event.getItemInHand().clone());, but that'd be stupid if it works

short raptor Dec 23, 2023, 12:29 PM

#

Oh that's clever

#

I'll tryt it

#

It works!

#

It's got the item pickup squish animation thing on the hotbar but that's ok

#

Better than scheduled solution

quiet ice Dec 23, 2023, 12:32 PM

#

Bruh what

short raptor Dec 23, 2023, 12:32 PM

#

Thanks man

short raptor Dec 23, 2023, 12:32 PM

#

short raptor I am trying to stop the player's block from getting consumde when he places it, ...

Also for the record I tried doing -1 and he doesn't lose two items

#

It has no effect

#

Very weird

quiet ice Dec 23, 2023, 12:32 PM

#

That was more of a joke than anything else. There might be a bug somewhere in spigot I guess

short raptor Dec 23, 2023, 12:33 PM

#

lmao💀

quiet ice Dec 23, 2023, 12:33 PM

#

Or just some really undocumented behaviour

quaint mantle Dec 23, 2023, 12:47 PM

#

How to make SpigotLibraryLoader download/load my deps or its own thing?

remote swallow Dec 23, 2023, 12:59 PM

#

cant use the built in one, use something like libby instead

#

https://github.com/AlessioDP/libby/

GitHub

GitHub - AlessioDP/libby: A runtime dependency management library f...

A runtime dependency management library for plugins running in Java-based Minecraft server platforms. - GitHub - AlessioDP/libby: A runtime dependency management library for plugins running in Java...

chrome beacon Dec 23, 2023, 1:08 PM

#

Something changed

#

So you're not making a plugin

#

Ask in #help-server

sick willow Dec 23, 2023, 1:09 PM

#

ah, blind me. sorry..

fair crest Dec 23, 2023, 1:31 PM

#

quiet ice So getItemMeta of your item, cast it to CrossbowMeta, invoke said method on it a...

can you provide a example if possible

#

i don't fully understand

#

im new to this

quiet ice Dec 23, 2023, 1:33 PM

#

CrossbowMeta meta = (CrossbowMeta) itemstack.getItemMeta();
meta.addChargedProjectile(arrowItemstack);
itemstack.setItemMeta(meta);

#

+/- a few inaccuracies

versed moss Dec 23, 2023, 1:34 PM

#

could anyone help me here? im trying to make it so that when ever the player closes the inventory it writes to the hashmap, if the title of the inventory is the players name. here is the inventory close event, and the inventory code: for some reason, it does not change the hashmap when ever i close the GUI

rare garden Dec 23, 2023, 1:35 PM

#

uwu

twin venture Dec 23, 2023, 1:40 PM

#

twin venture

i was able to fix it . thanks everyone .

faint aspen Dec 23, 2023, 1:40 PM

#

twin venture i was able to fix it . thanks everyone .

what was it?

fair crest Dec 23, 2023, 1:40 PM

#

quiet ice ```java CrossbowMeta meta = (CrossbowMeta) itemstack.getItemMeta(); meta.addChar...

it shows red on the arrow instance

twin venture Dec 23, 2023, 1:42 PM

#

faint aspen what was it?

the bug returned xD

faint aspen Dec 23, 2023, 1:43 PM

#

versed moss could anyone help me here? im trying to make it so that when ever the player clo...

do you get the message "ruuning" send?

versed moss Dec 23, 2023, 1:43 PM

#

nope

#

here is where it is initialised

faint aspen Dec 23, 2023, 1:45 PM

#

then log all the keys in the hashmap so you know if the keys are in the same way as you want them to be

fair crest Dec 23, 2023, 1:45 PM

#

quiet ice ```java CrossbowMeta meta = (CrossbowMeta) itemstack.getItemMeta(); meta.addChar...

is there a way to fix the arrowitemstack issue. it shows red for me

versed moss Dec 23, 2023, 1:45 PM

#

faint aspen then log all the keys in the hashmap so you know if the keys are in the same way...

alr ill try that

quiet ice Dec 23, 2023, 1:46 PM

#

fair crest is there a way to fix the arrowitemstack issue. it shows red for me

?

faint aspen Dec 23, 2023, 1:46 PM

#

fair crest is there a way to fix the arrowitemstack issue. it shows red for me

screen of the error

#

maybe import missing?

quiet ice Dec 23, 2023, 1:46 PM

#

Do you have any idea of what you are doing?

quiet ice Dec 23, 2023, 1:47 PM

#

faint aspen maybe import missing?

I can safely assert without any proof that this is not the case.

umbral ridge Dec 23, 2023, 1:47 PM

#

ArrowItemStack doesn't exist

quiet ice Dec 23, 2023, 1:48 PM

#

Jesus people, why do naming conventions exist?

umbral ridge Dec 23, 2023, 1:48 PM

#

ArrowItemStack exists in net.minecraft?

#

idk

quiet ice Dec 23, 2023, 1:48 PM

#

arrowItemStack is obviously a variable, and a variable needs to be declared and initialized

umbral ridge Dec 23, 2023, 1:48 PM

#

XD

shadow night Dec 23, 2023, 1:49 PM

#

💀 ya guys took so long to notice it's a variable

fair crest Dec 23, 2023, 1:49 PM

#

quiet ice `arrowItemStack` is obviously a variable, and a variable needs to be declared an...

ummmmmmmmmmm

#

i said i was new

umbral ridge Dec 23, 2023, 1:49 PM

#

i didnt look at the code

#

just the conversation

umbral ridge Dec 23, 2023, 1:50 PM

#

shadow night 💀 ya guys took so long to notice it's a variable

jesus guys it took so long jesus

quiet ice Dec 23, 2023, 1:51 PM

#

If I used ArrowItemStack it would be a class, and that would be syntactically incorrect as you cannot pass a type that way (hell, why the hell would you even pass a type in there?) - if I wanted to do that I'd so ArrowItemStack.class, but again, that is not what we want (there isn't even an ArrowItemStack class as far as I am concerned).

umbral ridge Dec 23, 2023, 1:51 PM

#

fair crest i said i was new

it's ok, everyone were new at some point. it's ok to make mistakes

#

class names will always begin with an uppercase letter whereas variable names start with lowercase letter

fair crest Dec 23, 2023, 1:52 PM

#

umbral ridge it's ok, everyone were new at some point. it's ok to make mistakes

yea. i don't know how to make the variable. or even much about them

umbral ridge Dec 23, 2023, 1:53 PM

#

fair crest yea. i don't know how to make the variable. or even much about them

I learned java from w3schools, here's some info about variables https://www.w3schools.com/java/java_variables.asp

W3Schools offers free online tutorials, references and exercises in all the major languages of the web. Covering popular subjects like HTML, CSS, JavaScript, Python, SQL, Java, and many, many more.

quiet ice Dec 23, 2023, 1:53 PM

#

ItemStack arrowItemstack = new ItemStack(Material.ARROW, 1); - with some room for error caused by me not having seriously touched bukkit for multiple years now

fair crest Dec 23, 2023, 1:54 PM

#

quiet ice `ItemStack arrowItemstack = new ItemStack(Material.ARROW, 1);` - with some room ...

thanks.

#

it works.

fair crest Dec 23, 2023, 1:54 PM

#

umbral ridge I learned java from w3schools, here's some info about variables https://www.w3sc...

also thanks for showing me this

twin venture Dec 23, 2023, 1:55 PM

#

why this give me ?
spam this error?

#

what iam dooing wrong

#

iam so tired ..

quiet ice Dec 23, 2023, 1:55 PM

#

recursive relations?

twin venture Dec 23, 2023, 1:55 PM

#

#

i made a CosmeticWarpper ,cuz from what i understood , i can't use abstract class in gson serliztion

quiet ice Dec 23, 2023, 1:57 PM

#

To be honest I have no clue what you are doing

clever lantern Dec 23, 2023, 1:57 PM

#

how do i mock commands?

quiet ice Dec 23, 2023, 1:57 PM

#

Like, I feel like this is a typical enterprise java moment

twin venture Dec 23, 2023, 1:57 PM

#

quiet ice To be honest I have no clue what you are doing

trying to serlize it and add it to mongodb

quiet ice Dec 23, 2023, 1:59 PM

#

whatever the cause, I cannot really know it from what you are providing us

faint aspen Dec 23, 2023, 1:59 PM

#

provide the complete stacktrace at best

twin venture Dec 23, 2023, 2:00 PM

#

no stacktrace it only send spam that

#

#

start from there

quiet ice Dec 23, 2023, 2:00 PM

#

It's pretty evident that two different types both require each other for (de-)serialization, so the full stacktrace isn't all that needed

quiet ice Dec 23, 2023, 2:00 PM

#

twin venture start from there

Stacktraces start from the bottom

twin venture Dec 23, 2023, 2:01 PM

#

xD?

#

#

#

nothing

quiet ice Dec 23, 2023, 2:02 PM

#

I suppose your logger somehow doesn't flush it's outputs correctly. Whatever

#

Do you happen to know what version of GSON your server is running on?

twin venture Dec 23, 2023, 2:03 PM

#

using 1.8.8 spigot for testing .

quiet ice Dec 23, 2023, 2:04 PM

#

Ye, but to what GSON version does that correspond? Otherwise I'll be searching for a needle in a haystack

twin venture Dec 23, 2023, 2:05 PM

#

alr

#

let me check

#

ik why .. it wasn't working

ivory sleet Dec 23, 2023, 2:09 PM

#

clever lantern how do i mock commands?

I mean

#

Probably wanna use mockito just

clever lantern Dec 23, 2023, 2:10 PM

#

idk if i need to mock it, i used plugin.getCommand

ivory sleet Dec 23, 2023, 2:10 PM

#

Or powermocks if you need to lol

#

I mean you can mock that tho

#

if you want

clever lantern Dec 23, 2023, 2:11 PM

#

i just wanna test a kick command

#

so idk if mocking is necessary

#

sry im new to tests

ivory sleet Dec 23, 2023, 2:12 PM

#

I can tell, its fine

#

Well usually when you test commands you end up needing to do integration, system or some other larger tests

atomic niche Dec 23, 2023, 2:13 PM

#

~~mockbukkit~~

ivory sleet Dec 23, 2023, 2:13 PM

#

Yes thats a thing but you rarely need mock bukkit for actual unit tests

#

Then you ought to be able to isolate units and mock its environment with mockito

umbral ridge Dec 23, 2023, 2:14 PM

#

twin venture using 1.8.8 spigot for testing .

1.8.8 😣

twin venture Dec 23, 2023, 2:18 PM

#

umbral ridge 1.8.8 😣

its good for me ..

shadow night Dec 23, 2023, 2:19 PM

#

1.8 is awful in any case

twin venture Dec 23, 2023, 2:20 PM

#

the plugin does not have any nms , so it should work on any .

#

i use 1.8.8 cuz its the lightest ..xD

ivory sleet Dec 23, 2023, 2:21 PM

#

twin venture i use 1.8.8 cuz its the lightest ..xD

What java version do you use w it?

twin venture Dec 23, 2023, 2:25 PM

#

ivory sleet What java version do you use w it?

8

quaint mantle Dec 23, 2023, 2:25 PM

#

Why spigot unloads the deps first when disabling the plugin?

#

Using 1.20.2 spigot build

ivory sleet Dec 23, 2023, 2:26 PM

#

twin venture 8

Poor server, java 8 is significantly worse than newer versions in terms of gc performance etc

umbral ridge Dec 23, 2023, 2:26 PM

#

twin venture its good for me ..

xd

pastel locust Dec 23, 2023, 2:27 PM

#

hey there how can i make changes to a bossbar i created in a file in my plugin through another event file? ive tried so many different things including using the same file for everything but i just cant get it to work. v1.20.2

young knoll Dec 23, 2023, 2:30 PM

#

?di

undone axleBOT Dec 23, 2023, 2:30 PM

#

Guide to dependency injection: https://www.spigotmc.org/wiki/using-dependency-injection/

elder grove Dec 23, 2023, 2:32 PM

#

Hello, does anyone know why even though the packets are good, the packets to players aren't getting sent? On 1.20.1 it works, but in 1.20.2 and 1.20.4 it doesnt anymore:

                public void send(Player to) {
                    try {
                        Object player = to.getClass().getMethod("getHandle").invoke(to);
                        Field connectionField = player.getClass().getField("c");
                        connectionField.setAccessible(true);
                        Object connection = connectionField.get(player);
                        Class<?> packetClass = Class.forName("net.minecraft.network.protocol.Packet");
                        connection.getClass().getMethod("a", packetClass).invoke(connection, packet);
                    } catch (IllegalAccessException | InvocationTargetException | NoSuchMethodException | NoSuchFieldException | ClassNotFoundException e) {
                        throw new RuntimeException("Error when trying to send packet: ", e);
                    }
                }

I've printed all of them, connection seems fine, so as the packet. I dont get any errors.

quaint mantle Dec 23, 2023, 2:40 PM

#

elder grove Hello, does anyone know why even though the packets are good, the packets to pla...

Viaversion compat

elder grove Dec 23, 2023, 2:42 PM

#

I've tried for each server 1.20.1, 1.20.2 and 1.20.4 without viaversion and it still didnt work

#

and the method names to get connection and packet are the same from 1.20.1 to 1.20.2 and 1.20.4

#

but it only works on a 1.20.1 server

quaint mantle Dec 23, 2023, 2:47 PM

#

Is the repository pattern strictly for holding data

#

like would it be misleading if I registered the data to some like bukkit listeners or something

hazy parrot Dec 23, 2023, 2:51 PM

#

I mean it's pattern for separating data access logic, not sure what it have to do with listeners

quaint mantle Dec 23, 2023, 2:52 PM

#

hazy parrot I mean it's pattern for separating data access logic, not sure what it have to d...

I'm making it store an implementation and the impls can have a listener

#

It's fine though ima just use a service class

hazy parrot Dec 23, 2023, 2:53 PM

#

It's probably better

#

I can't see how repository will benefit u here

quaint mantle Dec 23, 2023, 2:54 PM

#

Is a service just a fancy way of saying manager

hazy parrot Dec 23, 2023, 2:55 PM

#

Are u referring to spring service?

ivory sleet Dec 23, 2023, 2:55 PM

#

quaint mantle Is a service just a fancy way of saying manager

Na

hazy parrot Dec 23, 2023, 2:56 PM

#

If so, it's not

ivory sleet Dec 23, 2023, 2:56 PM

#

Almost all managers are some sort of service, all services may not be managers though

hazy parrot Dec 23, 2023, 2:56 PM

#

Service is basically component inside of ioc container which holds some application logic

ivory sleet Dec 23, 2023, 2:56 PM

#

But the term service is really vague

hazy parrot Dec 23, 2023, 2:56 PM

#

Also assuming you are talking about spring

ivory sleet Dec 23, 2023, 2:56 PM

#

Apart from spring i suppose lol

#

Yeah

quaint mantle Dec 23, 2023, 2:58 PM

#

so what does a service do

quiet ice Dec 23, 2023, 2:58 PM

#

If you talk about services in java I think of Java's ServiceLoader API

quaint mantle Dec 23, 2023, 2:58 PM

#

maybe ill just use a manager

quiet ice Dec 23, 2023, 2:59 PM

#

That is, a service is the implementation of a specification (most of the time that specification is an interface) which is dynamically discovered at runtime through the ServiceLoader API

ivory sleet Dec 23, 2023, 3:04 PM

#

Yeah the module api thingy thing

quiet ice Dec 23, 2023, 3:04 PM

#

Nah, JPMS is something different altogether, although it ties in nicely

ivory sleet Dec 23, 2023, 3:04 PM

#

Well you’d use JPMS in conjunction with the service api

#

No?

quiet ice Dec 23, 2023, 3:05 PM

#

You can use services even outside of modularity. For example SLF4J works like that, but plenty of other libraries use it too even outside of Java 9+

#

Okay it's me again with another incredibly specific question: Is there some maven plugin to generate jar-in-jars while having a lot of control over said process?
Basically I want to have a single of my own classes and a few dependencies bundled as usual, while all my other classes and dependencies are bundled in a jar within that jar.

Although I suppose I ought to use gradle for such accursed setups.

ivory sleet Dec 23, 2023, 3:09 PM

#

Yeah I’d prob stick w gradle

ivory sleet Dec 23, 2023, 3:11 PM

#

quiet ice You can use services even outside of modularity. For example SLF4J works like th...

Ah I see yeah… thats nice

#

Well I thought it was mainly just for the JPMS even tho it has existed since java 8 if not earlier as well

quiet ice Dec 23, 2023, 3:16 PM

#

quiet ice Okay it's me again with another incredibly specific question: Is there some mave...

Of course I could also fix the underlying bug that necessitates such drastic measures, but that might take even longer than figuring out how to work around it

ivory sleet Dec 23, 2023, 3:17 PM

#

What bug are we talking about?

quiet ice Dec 23, 2023, 3:17 PM

#

My custom classloader using the app classloader instead of itself to load a class

ivory sleet Dec 23, 2023, 3:18 PM

#

Ah and I assume u want it to use ur custom cl instead?

quiet ice Dec 23, 2023, 3:21 PM

#

Yep. I assume the fix would be as trivial as changing up the logic of Classloader#loadClass to not consult the plattform classloader, but I cannot exactly know what kind of issues that would cause.

ivory sleet Dec 23, 2023, 3:24 PM

#

Yeah true, although that might be easier than an uber jar, anyway if you do end up with the uber jar stuff, I think luckperms does that as well so you might be interested in their gradle setup

quaint mantle Dec 23, 2023, 3:24 PM

#

why do i need to cast this still

#

    public <C extends T> void loadAndRegister(@NotNull C config) throws IOException {
        Preconditions.checkNotNull(config, "config is null.");
        Class<? extends T> configClass = (Class<? extends T>) config.getClass();```

#

if the method knows C extends T, and we get its class so the class has to be of a type that extends T

slender elbow Dec 23, 2023, 3:25 PM

#

quiet ice That is, a service is the implementation of a specification (most of the time th...

eh, the service is the interface/public API, the service provider is the implementation

quaint mantle Dec 23, 2023, 3:25 PM

#

oh bruh

quiet ice Dec 23, 2023, 3:25 PM

#

Yeah you can define it like that too, yeah.

quaint mantle Dec 23, 2023, 3:25 PM

#

the class returns Class<?>

#

oops

ivory sleet Dec 23, 2023, 3:26 PM

#

I think returns Class<? extends ClassType> no?

quaint mantle Dec 23, 2023, 3:26 PM

#

nah just <?>

#

bruh

ivory sleet Dec 23, 2023, 3:26 PM

#

Oh yeah nvm me

quaint mantle Dec 23, 2023, 3:27 PM

#

https://imgur.com/XqQzNgE

quiet ice Dec 23, 2023, 3:28 PM

#

quiet ice Yep. I assume the fix would be as trivial as changing up the logic of Classloade...

Okay actually it is not caused by this - doesn't suprise me tbh given that the plattform classloader should not contain anything but the JRE.
Well then time to hunt down the other bottleneck(s)

ivory sleet Dec 23, 2023, 3:31 PM

#

Actually Max, it should be Class<? extends T> @quaint mantle

quaint mantle Dec 23, 2023, 3:31 PM

#

what should

ivory sleet Dec 23, 2023, 3:31 PM

#

getClass()

quaint mantle Dec 23, 2023, 3:32 PM

#

    @IntrinsicCandidate
    public final native Class<?> getClass();```

quiet ice Dec 23, 2023, 3:32 PM

#

It should be Class<? super C>, no?

ivory sleet Dec 23, 2023, 3:32 PM

#

Read the javadoc, but I thought it was weird to just be a wildcard type, I mean

ivory sleet Dec 23, 2023, 3:33 PM

#

quiet ice It should be `Class<? super C>`, no?

yeah lol

quiet ice Dec 23, 2023, 3:33 PM

#

You cannot have it be anything differently because java does not have a "self" generic type

ivory sleet Dec 23, 2023, 3:33 PM

#

quaint mantle ```java public <C extends T> void loadAndRegister(@NotNull C config) throws ...

Well I think this is cause of covariance and contravariance and type erasure

quaint mantle Dec 23, 2023, 3:33 PM

#

bruh i hate generics

quiet ice Dec 23, 2023, 3:34 PM

#

quiet ice It should be `Class<? super C>`, no?

Uhhhh, no. I meant extends, not super

ivory sleet Dec 23, 2023, 3:34 PM

#

yeah extends it is lol

quiet ice Dec 23, 2023, 3:34 PM

#

super is such a strange keyword, imo.

quaint mantle Dec 23, 2023, 3:35 PM

#

ok so if I have a method like this

ivory sleet Dec 23, 2023, 3:35 PM

#

well, it makes sense for consumers

quaint mantle Dec 23, 2023, 3:35 PM

#

<C extends T> void loadAndRegister(@NotNull C config) throws IOException;

Do i need the generic C

ivory sleet Dec 23, 2023, 3:35 PM

#

Not really

quaint mantle Dec 23, 2023, 3:35 PM

#

alr

ivory sleet Dec 23, 2023, 3:36 PM

#

I mean C erases to whatever T erases to

quiet ice Dec 23, 2023, 3:36 PM

#

quaint mantle ```java <C extends T> void loadAndRegister(@NotNull C config) throws IOException...

Yes, and no.

ivory sleet Dec 23, 2023, 3:36 PM

#

And since you don’t really have some sort of type token or anything, presumably quite useless method type arg

quiet ice Dec 23, 2023, 3:36 PM

#

It isn't needed for compilation, but it is needed for making a good API

quaint mantle Dec 23, 2023, 3:37 PM

#

<C extends T> C get(@NotNull Class<C> configClass);

and for this one i can just have Class<? extends T> right

quiet ice Dec 23, 2023, 3:37 PM

#

Actually no, my brain is melting right now

ivory sleet Dec 23, 2023, 3:37 PM

#

I mean yeah generics is nice, but type erasure is… well… a mess

ivory sleet Dec 23, 2023, 3:37 PM

#

quaint mantle ```java <C extends T> C get(@NotNull Class<C> configClass); ``` and for this one...

Nah

#

There its fine

quaint mantle Dec 23, 2023, 3:37 PM

#

why

quiet ice Dec 23, 2023, 3:37 PM

#

It is only required API-wise if you want to return it, but not necessarily for consumption

quaint mantle Dec 23, 2023, 3:37 PM

#

oh wait

#

im returning it

ivory sleet Dec 23, 2023, 3:37 PM

#

Since you want to get the exact type of the Class<C> argunent

quaint mantle Dec 23, 2023, 3:37 PM

#

i didnt even see it

#

lol

#

yeah I forgot i was returning the class

#

    @NotNull
    List<@NotNull T> getRegistered();

    void save(@NotNull Class<? extends T> configClass) throws IOException;

    boolean isSaved(Class<? extends T> configClass) throws IOException;
    
    boolean isRegistered(Class<? extends T> configClass);

these are all fine right

ivory sleet Dec 23, 2023, 3:41 PM

#

I think you return List<? extends T> no?

#

first one

quaint mantle Dec 23, 2023, 3:43 PM

#

i dont know

#

lol

#

whoever made this class needs to leave import org.checkerframework.checker.units.qual.C;

quiet ice Dec 23, 2023, 3:44 PM

#

That is why you always exclude transitive dependencies

ivory sleet Dec 23, 2023, 3:44 PM

#

Oh yeah checkerqual with its thousands of annots

quiet ice Dec 23, 2023, 3:45 PM

#

Oh, and annotation frameworks need to be provided/compileOnly

quaint mantle Dec 23, 2023, 3:45 PM

#

ima do some testing with this service lol

#

this config thing cause ion trust it rn

ivory sleet Dec 23, 2023, 3:47 PM

#

quiet ice Oh, and annotation frameworks need to be `provided`/`compileOnly`

Well yeah most ones can, apart from if you need it at runtime, then prob wna have it there tho doubt Max needs that

versed moss Dec 23, 2023, 3:53 PM

#

question: how would i add something to this because when ever i do, it deletes the old value, and replaces it:

HashMap<Player, HashMap<String,Location>> bagLocations = new HashMap<>();

HashMap<String,Location> baginfo = new HashMap<>();
bagNumber.put(p,num);
bagLocations.put(p,baginfo);

quiet ice Dec 23, 2023, 3:54 PM

#

Map#compute is one way

#

However, I recommend to not use Player in maps, instead UUID should be used.
But it is fine to do so as long as you remove the player once they disconnect

ivory sleet Dec 23, 2023, 3:54 PM

#

you have Map::replace as well

versed moss Dec 23, 2023, 3:57 PM

#

Like, it stores the player's name, and then the other hashmap will have a load of other Strings aka the names of the beds/bags, and when i look at that it will give me the location of the bag, so if i used replace, would i need a value already there?

versed moss Dec 23, 2023, 3:57 PM

#

quiet ice Map#compute is one way

also how do i use map#compute?

quiet ice Dec 23, 2023, 3:59 PM

#

map.compute(key, (finalKey, value) -> {
  if (value == null) {
    value = new HashMap<>();
  }
  // Do stuff
  return value;
});

finalKey being the same as key, but you can use finalKey inside your lambda without having to copy your key explicitly (though most of the time that is not needed)

versed moss Dec 23, 2023, 4:00 PM

#

okay thank you!!

ivory sleet Dec 23, 2023, 4:02 PM

#

versed moss okay thank you!!

You can also use HashBasedTable

#

Which is basically Map<R,Map<C,V>>

versed moss Dec 23, 2023, 4:03 PM

#

ivory sleet You can also use HashBasedTable

Wait that will actually really help, i didnt know they existed 💀

#

thanks xD

ivory sleet Dec 23, 2023, 4:04 PM

#

HashBasedTable.create() gives you one also :)

quaint mantle Dec 23, 2023, 4:05 PM

#

How can i use Plugin.getResource in this context?
BukkitObjectInputStream in = new BukkitObjectInputStream(new GZIPInputStream(HERE));

#

Should i immedietly use InputStream instead of GZIP?

quiet ice Dec 23, 2023, 4:08 PM

#

It depends on how your object is stored on disk

#

You can use PluginClass.class.getResourceAsStream("my-resource-file.dat") to obtain an input stream

#

Does anyone know how to obtain an absolute URL from a non-absolute URL?
So far I tried

                    URI uri = url.toURI();
                    if (!uri.isAbsolute()) {
                        arr.put(url.toString());
                    } else {
                        uri = Path.of(".").toAbsolutePath().toUri().resolve(uri);
                        arr.put(uri.toASCIIString());
                    }

but URI#isAbsolute returns true even for file://myJar.jar, besides the else branch does not seem to work either

ivory sleet Dec 23, 2023, 4:20 PM

#

I’ve had issues with that as well in the past

#

Dont remember exactly how I fixed it, but I think I used a File object at some point

#

(Instead of Path)

quiet ice Dec 23, 2023, 4:22 PM

#

Hm right, I can use that

quaint mantle Dec 23, 2023, 4:23 PM

#

ivory sleet I think you return List<? extends T> no?

yeah i dont think it needs to be like his

ivory sleet Dec 23, 2023, 4:23 PM

#

Yeah well it was weird when I fixed it cuz I remember just freaking out

quaint mantle Dec 23, 2023, 4:23 PM

#

i did some testing and everything I think works

#

idk if im doing this whole unit test things right tho

#

    @Test
    void getRegistered() {
        assertEquals(2, configService.getRegistered().size());
        assertTrue(configService.getRegistered().stream().anyMatch(c -> c instanceof ConfigOne));
        assertTrue(configService.getRegistered().stream().anyMatch(c -> c instanceof ConfigTwo));
        assertFalse(configService.getRegistered().stream().anyMatch(c -> c instanceof UnRegisteredConfig));
    }

quiet ice Dec 23, 2023, 4:24 PM

#

Exception in thread "main" java.lang.IllegalArgumentException: URI has an authority component
    at java.base/java.io.File.<init>(File.java:425)
    at org.stianloader.smatterbuild.cli.sll.CLISLLJumploader.main(CLISLLJumploader.java:45)

great.

#

Okay, for some reason the filename is encoded as the authority? Great - seems as if I am working with malformed URLs

ivory sleet Dec 23, 2023, 4:26 PM

#

lmao

short plover Dec 23, 2023, 4:37 PM

#

Is there a way to determine if a block would change a noteblock's instrument or would I have to use NMS to do that?

quiet ice Dec 23, 2023, 4:38 PM

#

Okay after fixing the problem at it's source it is gone now.

clever lantern Dec 23, 2023, 4:41 PM

#

how do i fix it

#

i have adventure in my pom

quiet ice Dec 23, 2023, 4:43 PM

#

that method will only exist under paper

#

Finally, progress!

clever lantern Dec 23, 2023, 4:49 PM

#

quiet ice that method will only exist under paper

so mockbukkit doesnt work with spigot or what

quiet ice Dec 23, 2023, 4:50 PM

#

At least not with spigot on the classpath

#

Under gradle you could've excluded spigot from the test classpath and added paper on the test classpath, but that is not possible under maven

pulsar monolith Dec 23, 2023, 4:56 PM

#

Can anyone help me here? I am trying to sort the player list but everything I tried doesn’t work. By default it is sorted alphabetically, so I tried to put abc letters in front of the name but it’s still being sorted by the original username. I also tried creating teams, for example 00Owner 01Admin 02Supporter but no success..

quaint mantle Dec 23, 2023, 4:56 PM

#

FirmlyMCMoon.getInstance().getResource("moon_house.dStructure");

This returns null, even tho that the file exists under src > main > java > resources

hazy parrot Dec 23, 2023, 4:57 PM

#

quaint mantle ``` FirmlyMCMoon.getInstance().getResource("moon_house.dStructure"); ``` This r...

Show your file structure

quaint mantle Dec 23, 2023, 4:57 PM

#

hazy parrot Show your file structure

any image host?

hazy parrot Dec 23, 2023, 4:58 PM

#

?img

undone axleBOT Dec 23, 2023, 4:58 PM

#

Can't send images? That's because you're not verified! Use !verify to complete verification.
Alternatively, you can upload screenshots to any image hosting site and share the link.

Here's some screenshot utilities that can use to upload images.
Lightshot: https://prnt.sc
Imgur: https://imgur.com/upload
Flameshot: https://flameshot.org

quaint mantle Dec 23, 2023, 4:58 PM

#

Oh let me do verification

proud badge Dec 23, 2023, 4:58 PM

#

does gradle make a difference if I dont care about build speed?

quaint mantle Dec 23, 2023, 4:59 PM

#

hazy parrot Show your file structure

https://imgur.com/a/E0Isx5C
did you mean this?

clever lantern Dec 23, 2023, 4:59 PM

#

gradle is more advanced but in some edge cases allows for more

quaint mantle Dec 23, 2023, 5:00 PM

#

quaint mantle https://imgur.com/a/E0Isx5C did you mean this?

if you need full
https://imgur.com/a/qF7o68o

#

I disabled filtering for them, does it affect it?

hazy parrot Dec 23, 2023, 5:03 PM

#

Can you check if that file is actually present in your jar

quaint mantle Dec 23, 2023, 5:04 PM

#

its not

#

i guess filtering disabled removes them as resources.

#

i disabled filtering

#

fully

#

now its there

hazy parrot Dec 23, 2023, 5:14 PM

#

quaint mantle now its there

Is it working if file is there?

quaint mantle Dec 23, 2023, 5:14 PM

#

hazy parrot Is it working if file is there?

The file does exists now yes, but it gives eof exception

#

i am trying to fix it

#

the problem is in

BukkitObjectInputStream in = new BukkitObjectInputStream(inputStream);

are binary files even supposed to be a input stream?

#

they should be right

hazy parrot Dec 23, 2023, 5:19 PM

#

Input stream is stream of bytes

#

Not sure about bukkit impl of object stream, but is should be checked exception

#

Meaning you should catch it

#

https://stackoverflow.com/questions/2626163/java-fileinputstream-objectinputstream-reaches-end-of-file-eof

Stack Overflow

Java FileInputStream ObjectInputStream reaches end of file EOF

I am trying to read the number of line in a binary file using readObject, but I get IOException EOF. Am I doing this the right way?

FileInputStream istream = new FileInputStream(fileName);

#

Yeah

quaint mantle Dec 23, 2023, 5:22 PM

#

hazy parrot Meaning you should catch it

I catched the exception already, do you mean that i should ignore it?

hazy parrot Dec 23, 2023, 5:22 PM

#

Read this so article

quiet ice Dec 23, 2023, 5:23 PM

#

quaint mantle ``` FirmlyMCMoon.getInstance().getResource("moon_house.dStructure"); ``` This r...

What file type is that?

quaint mantle Dec 23, 2023, 5:23 PM

#

quiet ice What file type is that?

its a wildcard

quiet ice Dec 23, 2023, 5:24 PM

#

I have no idea what you mean with that

#

Is it a standard structure file? In that case, (Bukkit-)ObjectInputStream will not work. ObjectInputStreams can only decode stuff that was encoded via an ObjectOutputStream

quaint mantle Dec 23, 2023, 5:25 PM

#

quiet ice Is it a standard structure file? In that case, (Bukkit-)ObjectInputStream will n...

no its not a standard structure file

#

a custom class is serialized in it

quiet ice Dec 23, 2023, 5:25 PM

#

And that class implements Serializable, right?

eternal oxide Dec 23, 2023, 5:26 PM

#

what items are you serializing?

quaint mantle Dec 23, 2023, 5:26 PM

#

quiet ice And that class implements `Serializable`, right?

yes

quaint mantle Dec 23, 2023, 5:26 PM

#

eternal oxide what items are you serializing?

a hashset and a string, custom serializable tuples, another custom serilizable class

ivory sleet Dec 23, 2023, 5:26 PM

#

proud badge does gradle make a difference if I dont care about build speed?

Nah

quiet ice Dec 23, 2023, 5:26 PM

#

And that class has never been changed since it was written via an ObjectOutputStream, or changes to it did not impact it's compatibility?

ivory sleet Dec 23, 2023, 5:27 PM

#

Gradle and maven can both be equally fast

quaint mantle Dec 23, 2023, 5:27 PM

#

quiet ice And that class has never been changed since it was written via an ObjectOutputSt...

Ohhhh

#

i only changed one function

ivory sleet Dec 23, 2023, 5:27 PM

#

I mean gradle does have incremental build, task caching and the daemon runner

quiet ice Dec 23, 2023, 5:27 PM

#

As long as that function had nothing to do with the serialization process it should be okay

ivory sleet Dec 23, 2023, 5:27 PM

#

But i think maven got some upgrades also

quaint mantle Dec 23, 2023, 5:28 PM

#

quiet ice As long as that function had nothing to do with the serialization process it sho...

it didnt

quiet ice Dec 23, 2023, 5:29 PM

#

Do you have filtering activated in your pom perchance? Although that cannot really cause EOFs afaik

quaint mantle Dec 23, 2023, 5:29 PM

#

what might be different is the methods i used:

BukkitObjectOutputStream out = new BukkitObjectOutputStream(new GZIPOutputStream(new FileOutputStream(FilePath)));

BukkitObjectInputStream in = new BukkitObjectInputStream(inputStream);

#

maybe i should use the same methods...

quiet ice Dec 23, 2023, 5:30 PM

#

If you GZIP it out, you need to read it via GZIP

quaint mantle Dec 23, 2023, 5:30 PM

#

same issue

quiet ice Dec 23, 2023, 5:30 PM

#

Although I never used that one, and it is a bit uncanny for me that you don't declare all three streams in a try-with-resources

quaint mantle Dec 23, 2023, 5:31 PM

#

quiet ice Although I never used that one, and it is a bit uncanny for me that you don't de...

i dont really understand what u mean with "try-with-resources"

quiet ice Dec 23, 2023, 5:31 PM

#

Did you invoke GZIPOutputStream#finish()?

quaint mantle Dec 23, 2023, 5:32 PM

#

you mean close

quiet ice Dec 23, 2023, 5:33 PM

#

quaint mantle i dont really understand what u mean with "try-with-resources"

try (OutputStream rawOut = Files.newOutputStream(path); OutputStream gzippedOut = new GZIPOutputStream(rawOut); ObjectOutput oubjectOutput = new BukkitObjectOutputStream(gzippedOut)) {
  // Logic here
}

quaint mantle Dec 23, 2023, 5:33 PM

#

and yes i closed it

quiet ice Dec 23, 2023, 5:34 PM

#

quaint mantle you mean close

Yeah same thing, didn't see that DeflaterOutputStream#close calls finish

pulsar monolith Dec 23, 2023, 5:35 PM

#

pulsar monolith Can anyone help me here? I am trying to sort the player list but everything I tr...

anyone?

quiet ice Dec 23, 2023, 5:38 PM

#

@quaint mantle Could you look into the contents of your jar file? (This can be done by renaming the *.jar file to *.zip if you don't already know that) and check whether your file hasn't been changed?

quaint mantle Dec 23, 2023, 5:38 PM

#

quiet ice <@456226577798135808> Could you look into the contents of your jar file? (This c...

it is the same file

quiet ice Dec 23, 2023, 5:39 PM

#

Even the path is the right one?

eternal oxide Dec 23, 2023, 5:41 PM

#

@quaint mantle You can filter some and not others.```xml
<resources>

<resource>
<directory>resources</directory>
<filtering>true</filtering>
<includes>
<include>.yml</include>
<include>.txt</include>
<include>*.json</include>
</includes>
</resource>

        <resource>
            <directory>resources</directory>
            <filtering>false</filtering>
            <includes>
                <include>*.nbt</include>
            </includes>
        </resource>
    </resources>```

#

compressed files (like nbt) must not be filtered.

quiet ice Dec 23, 2023, 5:42 PM

#

well that would mean that the file in the jar has changed as a result of filtering.
And they even stated that filtering was disabled by them

quaint mantle Dec 23, 2023, 5:45 PM

#

quiet ice Even the path is the right one?

yes

quiet ice Dec 23, 2023, 5:47 PM

#

Just out of safety, does #getResource work now?

quaint mantle Dec 23, 2023, 5:48 PM

#

yes

quiet ice Dec 23, 2023, 5:50 PM

#

yeah then I have no clue what is going on

quaint mantle Dec 23, 2023, 5:51 PM

#

How do I pass player chat signature into custom message? Or this even possible?

river oracle Dec 23, 2023, 5:53 PM

#

you don't

#

chat signing won't work properly if any chat formatting is done

shadow night Dec 23, 2023, 6:00 PM

#

You could, just in theory, do some crazy magic, but I'm not sure

carmine mica Dec 23, 2023, 6:01 PM

#

river oracle chat signing won't work properly if any chat formatting is done

I mean... that's not true

#

its true on spigot cause it just uses the system chat packet iirc

#

but it doesn't have to be that way

shadow night Dec 23, 2023, 6:01 PM

#

Hmm

carmine mica Dec 23, 2023, 6:01 PM

#

it only checks if the signed potion is contained in the plain text serialized chat component

#

so if you add some prefix/suffix to the signed content, then it can still be signed

#

but spigot just redirects all chat to use the system chat packet iirc (if a format is set)

hazy parrot Dec 23, 2023, 6:04 PM

#

carmine mica it only checks if the signed potion is contained in the plain text serialized ch...

That seems wrong from cryptographic pov lol

#

But seems it's true

#

While the message always needs to be verified by the player that sent it, player display name, team name, and surrounding format can be freely defined by the server.

dire tapir Dec 23, 2023, 6:05 PM

#

Hello, I have a problem with the BlockDamageEvent. It does not get triggered when the player keeps mining a block after a BlockBreakEvent has been cancelled. I tried using the BLOCK_DIG packet same thing. So basically the player starts digging BlockDamageEvent gets triggered -> finished mining, but BlockBreakEvent is cancelled -> starts digging again while still holding LMB, but then both BlockDamageEvent AND BlockDamageAbortEvent are not triggered. Is there an alternative thing I could do to detect this moment?

quaint mantle Dec 23, 2023, 6:06 PM

#

Can I add stuff like prefix, suffix, e.t.c?

carmine mica Dec 23, 2023, 6:06 PM

#

hazy parrot > While the message always needs to be verified by the player that sent it, play...

it uses the MODIFIED trust level. So I think it shows the message with the yellow indicator. whereas no indicator is pure signed

#

and red is unsigned

carmine mica Dec 23, 2023, 6:07 PM

#

hazy parrot > While the message always needs to be verified by the player that sent it, play...

this is actually entierly different, and not related to what I'm talking about. that is the chat type and isn't included in the signed message at all

hazy parrot Dec 23, 2023, 6:10 PM

#

You aren't talking about modifying format?

#

Mb ig

carmine mica Dec 23, 2023, 6:10 PM

#

well in a way, yes, but not that way. Like if you take the signed string, and put it into a component with a prefix or suffix and put that into the unsigned content of the clientbound packet, it will show as modified, not unsigned.

#

there is the separate ChatType system which can define chat formats in datapacks which are synced to the client

#

but spigot has 0 API for that and setFormat does not use that at all, it just puts the whole thing into a system chat packet if you try to use setFormat with the non-default format

steel swan Dec 23, 2023, 6:23 PM

#

is this the most optimal way to load all the chunks from x -1000 to x 1000 and z -1000 and z 1000?

remote swallow Dec 23, 2023, 6:25 PM

#

that wont load them all

formal ether Dec 23, 2023, 6:25 PM

#

steel swan is this the most optimal way to load all the chunks from x -1000 to x 1000 and z...

use completable features and run it in async, not sure if async chunk loading is possible with a normal plugin tho

remote swallow Dec 23, 2023, 6:25 PM

#

chunks have there own x and z so you just need to add 1, it will also probably just die

steel swan Dec 23, 2023, 6:27 PM

#

remote swallow chunks have there own x and z so you just need to add 1, it will also probably j...

so the chunk at x10 z20 does not contain the block 10 20?

remote swallow Dec 23, 2023, 6:27 PM

#

no

steel swan Dec 23, 2023, 6:27 PM

#

like what i mean is, in here, we use coordonates of chunks not blocks?

remote swallow Dec 23, 2023, 6:27 PM

#

coord of chunk in getChunkAt

steel swan Dec 23, 2023, 6:28 PM

#

remote swallow coord of chunk in getChunkAt

so yes?

remote swallow Dec 23, 2023, 6:28 PM

#

so yes what

steel swan Dec 23, 2023, 6:28 PM

#

ok i get it

steel swan Dec 23, 2023, 6:28 PM

#

remote swallow so yes what

i missread what u wrote

remote swallow Dec 23, 2023, 6:28 PM

#

chunk 10,20 doesnt contain block 10,20

steel swan Dec 23, 2023, 6:28 PM

#

remote swallow chunk 10,20 doesnt contain block 10,20

yep understood

#

thx

rotund ravine Dec 23, 2023, 6:43 PM

#

Ignore the following msg

#

?blockpdc

undone axleBOT Dec 23, 2023, 6:43 PM

#

Learn about CustomBlockData here:
https://www.spigotmc.org/threads/custom-block-data-persistentdatacontainer-for-blocks.512422/

quaint mantle Dec 23, 2023, 6:43 PM

#

undone axle Learn about CustomBlockData here: <https://www.spigotmc.org/threads/custom-block...

thanks!

remote swallow Dec 23, 2023, 6:43 PM

#

whos the blockpdc for

steel swan Dec 23, 2023, 6:43 PM

#

remote swallow chunk 10,20 doesnt contain block 10,20

is this better? (its still reaaaally slow)

rotund ravine Dec 23, 2023, 6:43 PM

#

remote swallow whos the blockpdc for

Apparently that guy?

#

Jk some guy on paper

quaint mantle Dec 23, 2023, 6:44 PM

#

rotund ravine Apparently that guy?

ay

quaint mantle Dec 23, 2023, 6:44 PM

#

steel swan is this better? (its still reaaaally slow)

yes

remote swallow Dec 23, 2023, 6:44 PM

#

steel swan is this better? (its still reaaaally slow)

sure

steel swan Dec 23, 2023, 6:44 PM

#

remote swallow sure

do you have any way of doing that faster? it takes a REAAAAAlly long time

quaint mantle Dec 23, 2023, 6:45 PM

#

it might be slow becuase you are loading 252 chunks at once

#

wait too low

#

my math bad

steel swan Dec 23, 2023, 6:45 PM

#

rotund ravine Dec 23, 2023, 6:45 PM

#

steel swan do you have any way of doing that faster? it takes a REAAAAAlly long time

You can use paper and get em async then wait for the async world system to create em all

quaint mantle Dec 23, 2023, 6:45 PM

#

quaint mantle it might be slow becuase you are loading 252 chunks at once

7.938 chunks at once

steel swan Dec 23, 2023, 6:45 PM

#

rotund ravine You can use paper and get em async then wait for the async world system to creat...

what do you mean? i dont understand your message

subtle folio Dec 23, 2023, 6:45 PM

#

lol

quaint mantle Dec 23, 2023, 6:46 PM

#

steel swan what do you mean? i dont understand your message

async

#

?async

#

aw man

rotund ravine Dec 23, 2023, 6:46 PM

#

Don’t use it async

echo basalt Dec 23, 2023, 6:46 PM

#

pregenerating a world is fine

#

keeping the entire world loaded in ram is not

quaint mantle Dec 23, 2023, 6:46 PM

#

Asynchronous (aka async) programming in Java is a technique for parallel programming that lets teams distribute work and build application features separately from the primary application thread. Then, when the team is ready with the feature, the code is synced with the main thread.

#

that is wrong

#

lol

#

dont listen to google

river oracle Dec 23, 2023, 6:47 PM

#

rotund ravine You can use paper and get em async then wait for the async world system to creat...

you could still probably execute this better using some form of work distribution

rotund ravine Dec 23, 2023, 6:47 PM

#

The server is sync

#

Wouldn’t matter much since spigot halts until it has generated le chunk

steel swan Dec 23, 2023, 6:48 PM

#

So, you want me to put the chunk loading thing on an other thread?

river oracle Dec 23, 2023, 6:48 PM

#

you can't

#

well you might beable to use PaperLib here

#

should help if your plugin is run on paper

steel swan Dec 23, 2023, 6:48 PM

#

river oracle should help if your plugin is run on paper

it does

remote swallow Dec 23, 2023, 6:49 PM

#

steel swan do you have any way of doing that faster? it takes a REAAAAAlly long time

chunky

river oracle Dec 23, 2023, 6:49 PM

#

steel swan it does

wasn't a question it was a statement

brisk estuary Dec 23, 2023, 6:50 PM

#

hey guys, I wanted to ask you about a "pattern" decision. So basically I have a class called MerchantManager and it represents a feature for my plugin that soft-depends on Citizens. The idea is to spawn a NPC every X time and then despawn it after Y time. It will be basically a merchant with a custom inventory and players can trade items with him. If Citizens is not enabled in the server, I'll just enable a command to access the same inventory/gui that would be accessible with the NPC. In the MerchantManager class I'll basically have the timing logic, so it will check if it's time to end the "merchant event", start it, etc and also get config settings. What's the best approach in this case? Like, I'll have two implementations of the event, one using Citizens and another one using just the GUI and a command. Should I have an interface like this:

public interface MerchantEvent {
  void start();
  void stop();
}

and then on the manager:

public void start() {
  // timing logic
  merchantEvent.start();
}

steel swan Dec 23, 2023, 6:52 PM

#

river oracle wasn't a question it was a statement

do you have any documentation on how it can help me with chunk loading?

quaint mantle Dec 23, 2023, 6:53 PM

#

Craftbukkit modification

rancid ibex Dec 23, 2023, 6:53 PM

#

How to cap enchanting that it doesnt go further than prot 3 and sharp 3 I had someone make a plugin for me but it doesnt work good

quaint mantle Dec 23, 2023, 6:53 PM

#

Theres no way to speed up the chunk gen other than having powerful pc

remote swallow Dec 23, 2023, 6:54 PM

#

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/enchantment/PrepareItemEnchantEvent.html with getOffers

PrepareItemEnchantEvent (Spigot-API 1.20.4-R0.1-SNAPSHOT API)

declaration: package: org.bukkit.event.enchantment, class: PrepareItemEnchantEvent

rancid ibex Dec 23, 2023, 6:54 PM

#

remote swallow https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/enchantment/PrepareIte...

Is there an option I could send you the plugina nd tell you the errors and you fix it or no?

remote swallow Dec 23, 2023, 6:55 PM

#

depends on the plugin

quaint mantle Dec 23, 2023, 6:55 PM

#

I think bros gonna send jar 💀

rancid ibex Dec 23, 2023, 6:55 PM

#

quaint mantle I think bros gonna send jar 💀

I got source code rn

remote swallow Dec 23, 2023, 6:56 PM

#

did kacper code you a plugin

rancid ibex Dec 23, 2023, 6:56 PM

#

remote swallow did kacper code you a plugin

kaspain did ye

remote swallow Dec 23, 2023, 6:56 PM

#

@onyx fjord do you not do bug fixes or smth

rancid ibex Dec 23, 2023, 6:57 PM

#

remote swallow <@693506818361786436> do you not do bug fixes or smth

not him

#

kaspiandev

#

did make it for me

#

(i payed him for it)

remote swallow Dec 23, 2023, 6:57 PM

#

that is kaspiandev

rancid ibex Dec 23, 2023, 6:57 PM

#

i thought u misstyped or smth

rancid ibex Dec 23, 2023, 6:58 PM

#

remote swallow that is kaspiandev

but is it possible I could send you it in dm send you the list of bugs and you fix it or no?

remote swallow Dec 23, 2023, 6:59 PM

#

sure

echo basalt Dec 23, 2023, 7:00 PM

#

brisk estuary hey guys, I wanted to ask you about a "pattern" decision. So basically I have a ...

Yeah that looks fine

#

public interface MerchantEvent {
  
  void start();
  void stop();
  boolean isActive();

}

#

on your command you just check isActive

clever lantern Dec 23, 2023, 7:05 PM

#

why when i do this plugin = MockBukkit.load(CorePlugin.class); this is thrown

#

sry i am new to tests

quaint mantle Dec 23, 2023, 7:06 PM

#

It mean its not mocking