Chest chest = location. getBlock()
#help-development
chrome beacon
Why not use the block state?
tender shard
no
tender shard
Chest chest = location. getBlock()
are you drunk?
vast ledge
yes
small current
Why not use the block state?
usage
chrome beacon
?
tender shard
wtf is going on here, everyone drunk today
small current
2.8%
chrome beacon
I assume you mean it's slow
chrome beacon
ofc there is
vast ledge
why
chrome beacon
You just need to find it
vast ledge
would you need nms just use blockstate
tender shard
how is it slow? are you calling it 3 million times per tick?
small current
how is it slow? are you calling it 3 million times per tick?
yeah there is a problem like that
tender shard
getting a container's inventory is not slow
vast ledge
why are you calling it 3m times per tick
vast ledge
getting a container's inventory is not slow
true
small current
getting a container's inventory is not slow
getting the block state
is
block.getState()
tender shard
hm not really
small current
why are you calling it 3m times per tick
its a huge amount of blocks and im breaking it and adding it to an inventory
smoky anchor
oh no
echo basalt
mhm I wouldn't advise doing this shit
small current
settings blocks are also very slow but i managed to fix it
smoky anchor
I really wanna see the code for that
please share
vast ledge
yea
small current
mhm I wouldn't advise doing this shit
what should i do
echo basalt
I should honestly just make a full set of utilities around multi-threaded block manipulation
Including tile states n shit
tender shard
why do you need the blockstate to get a container in the first place?
small current
the maximum is 1500 blocks being broken at the same time
i used multi threaded
yes
vast ledge
why do you need the blockstate to get a container in the first place?
That's what I said
small current
but adding the item to the inventory
vast ledge
oh
echo basalt
i used multi threaded
blud doesn't know wtf he's talking about
adding items to inventories can be done async
tender shard
You don't need the blockstate at all
smoky anchor
its a huge amount of blocks and im breaking it and adding it to an inventory
I imagine something stupid like
for (Block b : blocks)
world.getBlock(chestLoc).getInventory().add(b.item());
I hope I am wrong
echo basalt
But it can also cause some problems
buoyant viper
tender shard
https://github.com/JEFF-Media-GbR/InvUnload/blob/master/src/main/java/de/jeff_media/InvUnload/BlockUtils.java#L39
Chuk#getTileEntities() -> check if they are container -> get the blockstate
then you dont have to get the blockstates of all other blocks
small current
@tender shard i have location of the chest
vast ledge
then just get the inventory
tender shard
dude you are talking about only one single chest?
vast ledge
ig
small current
Also why tf im adding the items in a for loop
Hell naw
Was i drunk coding this shit
smoky anchor
well now I really wanna see that
come on, don't be shy
show us some code :)
tender shard
wow i'm out, i have no clue what kind of weird things you guys are doing, but I could easily get that chest's inventory a hundred times per tick and add a ton of random items every time without ayone complainin about it being slow or anything. literally no reason at all to use slughorn/nms for this
vast ledge
yea
small current
@smoky anchor i will explain
I will get the inventory of the chest for every single block
tender shard
i thought you were scanning like a 3x3 chunk area for containers and that's why you wanted to avoid getting each block's blockstate,....
one single chest, lmao
what a waste of time to even think about it
small current
One single chest 1600 times
smoky anchor
I imagine something stupid like
```
for (Block b : blocks)
world.getBlock(che...
wait SO THIS ?!
smoky anchor
Drink some water, sober up
And fucking rewrite that shit
vast ledge
Holy shit
small current
I will also use a queue to add the items
small current
What in the shitcode was that
vast ledge
just use
while(true) {
chestInv.add(item);
}
tender shard
I always code great stuff when drunk, like MorePersistentDataTypes lol
Or CustomBlockData
smoky anchor
Aren't those like actually good ?
don't you even have a ? command for morepdc ? XD
tender shard
?morepdc
undone axleBOT
You can create custom persistent data types on your own, or use one of the many libraries available which have implemented those which match your needs. Learn about more persistent data types here: https://www.spigotmc.org/threads/more-persistent-data-types-collections-maps-and-arrays-for-pdc.520677/
tender shard
?customblockdata
?blockdata
?cbd
Hm
There was a command for cbd too
?customblock
?blockpdc
undone axleBOT
Learn about CustomBlockData here:
https://www.spigotmc.org/threads/custom-block-data-persistentdatacontainer-for-blocks.512422/
smoky anchor
imagine forgetting a command for your own plugin
smh
undone axleBOT
tender shard
what's Dayzz line 706?
quaint mantle
Could someone please help? The plugin works correctly on craftbukkit and there is an error on spigot, I do not understand what is the matter, since in this case there should be no error
smoky anchor
what in the name of all that is holy
quaint mantle
what's Dayzz line 706?
706 line: double balance = Double.parseDouble(lastMessage);
tender shard
lastMessage is an empty string
quaint mantle
lastMessage is an empty string
That is, I need to rewrite the system for getting the last line from the console?
chrome beacon
``` player.sendMessage("§x§3§E§8§D§0§6§l[§x§5§7§A§E§2§C§lD...
Legacy color rgb 😎
quaint mantle
``` player.sendMessage("§x§3§E§8§D§0§6§l[§x§5§7§A§E§2§C§lD...
rgb
smoky anchor
Legacy color rgb 😎
I do know what that is but...
if he's on paper doesn't he have Minimessage or something
Does't that do rgb ?
chrome beacon
It can do RGB yes
tender shard
That is, I need to rewrite the system for getting the last line from the console...
idk what your weird code is doing in the first place
but if you wanna get the console output, here's how to do that https://blog.jeff-media.com/how-to-read-or-block-spigots-console-output/
quaint mantle
okey, thanks
chilly hearth
package me.airforce.excavation.Listensers;
import org.bukkit.block.Block;
import org.bukkit.event.Listener;
import org.bukkit.event.block.BlockBreakEvent;
public class BlockBreak implements Listener {
public void onBlockBreak(BlockBreakEvent e) {
Block block = e.getBlock();
{
}
}
} ```how do i make it so if thye block gets broken blocks in 3x3 raduis will also get broken ?
pseudo hazel
use 3 for loops
smoky anchor
3x3 or 3x3x3 ?
pseudo hazel
assuming you want it to be 3 dimensional
chilly hearth
3x3
echo basalt
Let's start by addressing 2 things, maybe 3
For starters you need to annotate your listener with @EventHandler
chilly hearth
like excavation enchant
hazy parrot
just destroy blocks same way you would print matrix ig
chilly hearth
just destroy blocks same way you would print matrix ig
a ?
echo basalt
Second, no point in opening random code blocks for no reason
pseudo hazel
and make sure these blocks dont call the blockbreakevent..
echo basalt
I'd refer to this but I honestly doubt you'll be able to understand it
smoky anchor
and make sure these blocks dont call the blockbreakevent..
Called when a block is broken by a player.
Would not worry about that
pseudo hazel
okay, well you never know 🤷
chilly hearth
bro so what i need to do ?
echo basalt
research
chilly hearth
bruh tell me a way man
pseudo hazel
no
smoky anchor
?spoon
undone axleBOT
Spoonfeed a newbie for a day and they'll come back with more questions. Teach them to find their own answers and you'll both be better off: you won't get stuck answering the easy questions and they'll be much more productive than before.
echo basalt
You can't even break down your problem into steps
pseudo hazel
because then youll be back with the next question
chilly hearth
hmmmm
echo basalt
And you're just asking to be spoon-fed
flint coyote
okay, well you never know 🤷
In fact he wants to fire a blockbreakevent to not break plugins like worldguard and logblock. He can just extend the block break event and fire that custom event so he can ignore it in his listener
chilly hearth
And you're just asking to be spoon-fed
i aint asking for the code tbh
echo basalt
Might be a little harsh but we want you to be able to understand how to solve issues by yourself
smoky anchor
In fact he wants to fire a blockbreakevent to not break plugins like worldguard ...
Hmm good catch
chilly hearth
tell a simple method isnt called spoonfeeding
ivory sleet
It might be
echo basalt
Just breaking down the problem for you is spoon-feeding
ivory sleet
The problem with spoonfeeding is the mindset you get from it
echo basalt
Well not exactly but it's something so basic
echo basalt
Yeah but you don't learn anything from this if I just do all the work for you
But fuck it let's walk over the steps
Define 3x3
chilly hearth
bro
echo basalt
Does it include height?
pseudo hazel
wdym i guess
echo basalt
Okay so 3x3, in relative positioning
chilly hearth
height*
echo basalt
It's -1, 0, 1 in all axis
pseudo hazel
okay so its a cube of blocks around the broken block
chilly hearth
okay so its a cube of blocks around the broken block
yes
echo basalt
AKA a cube where your origin is your center and it expands by 1 in all axis
echo basalt
So let's start with what you have
flint coyote
Please use a variable for the size so you can easily increase it in case you want/need to
chilly hearth
make sense
echo basalt
Remove 1 as it's your center, and divide by 2 to have your radius
So if it's 5x5, the radius is 2
chilly hearth
ok
twilit roost
bungeecord
is there some way to check if some server went offline or online?
echo basalt
ok
Red is your center, your radius is the length of yellow
Now you want to loop through all axis
Starting at -radius and ending at radius
I'll do it for a single radius
chilly hearth
alr the the ridaius 2 and -2 ?
echo basalt
int centerX = ..:
int centerY = ...;
int centerZ = ...;
int diameter = 5; // 5x5
int radius = (diameter - 1) / 2; // 2
for(int x = -radius; x <= radius; x++) {
}
So this will loop through
-2, -1, 0, 1, 2
Think of those as "relative" positions
pseudo hazel
(you dont technically have to do diameter - 1 but it make it more clear I think)
echo basalt
(you dont technically have to do diameter - 1 but it make it more clear I think)
Correct
echo basalt
Think of those as "relative" positions
What happens if you add these relative positions to your centerX?
Give me an answer
chilly hearth
what will be my x y z ?
chilly hearth
ok
echo basalt
Anyways you still haven't answered
chilly hearth
int centerX = block.getX();
int centerY = block.getY();
int centerZ = block.getZ();
it give me those options
zenith gate
when retrieving an inventory name, if its colored, does that get retrieved as well? If i need to compare it, do i need the color?
warm mica
I love how it says modern but that's how it was done since always
Apart from having lambdas
eternal night
really wasn't 😅
too many people used like, item stack comparison
or I guess inventory holders (tho you can't say that too loud or md_5 is gonna come for you)
warm mica
The correct adjective would be properly not modern, that's what I am trying to say
It's not making use of anything special that I'd call modern as it only exists in newer versions
wet breach
or I guess inventory holders (tho you can't say that too loud or md_5 is gonna c...
They used the inventory name for the longest time
Which was equally bad as using holder
eternal night
for what part of it ? xD
onyx fjord
nah i mean like
iso standard or whatever
that languages follow to create formatters
eternal night
I mean, 8601 is the ISO standard for that
onyx fjord
gotcha
wet breach
is it standarized?
Yes
fervent cobalt
I made a plugin for 1.18.2 with Java 8, which should support other versions. But it doesn't. How to add support for other minecraft versions?
chrome beacon
Start by targetting the lowest version you want to support
Set api-version in the plugin.yml to 1.13 and then add submodule for each version of nms/version where new api got added and code that part there
shade it all together and only load code supported on the current version
That's the basics of it ^
chrome beacon
Lower than 1.17 uses Java 8
1.17 uses Java 16
1.18+ uses Java 17
fervent cobalt
But latest versions still support older java versions, right?
fervent cobalt
I mean in terms of plugin development
So theoretically any version of minecraft supports a plugin that was made for Java 8
chrome beacon
1.8+ at least
fervent cobalt
Ok, thank you!
chrome beacon
If you start going lower than that you will have even older Java versions
eternal oxide
?paste for me
undone axleBOT
fervent cobalt
Set api-version in the plugin.yml to 1.13 and then add submodule for each versio...
The plugin is really simple. All it does is reply to some commands with text messages, nothing version-specific
upper hazel
is it possible to change without using reflection
max stack potion?
eternal oxide
no
upper hazel
demm(
smoky anchor
I believe it is but in inventory it would be "laggy" for the player
Like you can listen to interaction events and do math to set the stack size
upper hazel
and through reflection without lags will be?
eternal oxide
even using reflection its buggy
smoky anchor
yes
client still thinks the max stack size is 1
and you can't change what client thinks without modifying it
which is impossible via just server
||if you were in the past tho you could have used the log4j vulnerability tho XD||
upper hazel
Does this apply to all items?
smoky anchor
yes
lilac dagger
how do i make it so intellij won't warn about methods annotated with EventHandler?
tawdry monolith
Hey guys, how do I add hex color codes to a TextComponent? I need a custom colored clickable link
upper hazel
who knows what the variable is called responsible for this
smoky anchor
how do i make it so intellij won't warn about methods annotated with EventHandle...
hover over the annotation and click some text on the tooltip
or the method that shows the warning
zenith gate
when retrieving an inventory name, if its colored, does that get retrieved as we...
bump.
lilac dagger
this is so clean now
smoky anchor
bump.
#1 read what was said below
#2 yes, it gives you the color as well, yes you need to compare it with the color
smoky anchor
who knows what the variable is called responsible for this
My guess is to look through the nms Item class
But again, if you do change it it will be buggy for the player.
lilac dagger
does this mean that the itemstack is not null huh?
i assume it's just the array itself that is not null, not the items in the array
vestal pewter
Hi,
I'm trying to work with scoreboards,
If I use this code :
@EventHandler
public void onPlayerLogin(PlayerJoinEvent event) {
score.playerScores.put(event.getPlayer().getUniqueId(), 0);
ScoreboardManager manager = Bukkit.getScoreboardManager();
Scoreboard scoreboard = manager.getNewScoreboard();
Objective objective = scoreboard.registerNewObjective("Test", Criteria.create("dummy"), Component.text("Test"));
objective.setDisplaySlot(DisplaySlot.SIDEBAR);
Team team = scoreboard.registerNewTeam("ol");
team.addEntry(" score");
team.prefix(Component.text(score.playerScores.get(event.getPlayer().getUniqueId())));
objective.getScore(" score").setScore(1);
event.getPlayer().setScoreboard(scoreboard);
}
Will my teams be shared between all the players or not ?
eternal oxide
no
young knoll
does this mean that the itemstack is not null huh?
It’s only the array
earnest plinth
how can i download java 16 on ubuntu 22.04 for 1.16 minecraft server?
twilit roost
how should one make an editor simillar to LuckPerms?
fervent cobalt
I was using MiniMessage to parse text in my plugin, but now I'm adding support for older versions and I can't send Component in chat directly anymore. Any way out?
fervent cobalt
Just adventure
<dependency>
<groupId>net.kyori</groupId>
<artifactId>adventure-api</artifactId>
<version>4.14.0</version>
</dependency>
<dependency>
<groupId>net.kyori</groupId>
<artifactId>adventure-text-minimessage</artifactId>
<version>4.14.0</version>
</dependency>
I don't think they have support, do they?
eternal night
They have a discord
however, if you are on spigot you'd also need the bukkit bridge
fervent cobalt
I found the server, thank you
opal juniper
like, how are you sending components
kyori support:
Step One: Use Paper
eternal night
manic furnace
I try to make my own argument type for brigadier. I registered it via reflections and it is loaded with no errors. But when I try to type the command, the argument input is all red and there are no suggestions. It actually calls the pars method from the type, but still the command fails
smoky anchor
wait I think I know this one
'cause I tried it years ago
You have to somehow register that I believe BUT those are somehow synched to client and if the client does not recognize it it throws an error
try looking into the clients console
manic furnace
Ill try that. I have already registered them in ArgumentTypInfos
silent steeple
Any good command frameworks?
fervent cobalt
So I made a simple plugin. In this context, all it does is reply to a command with some text. Originally it was made for 1.18.2, but since it is so simple I decided to add support from 1.12 and up. I set the API version to 1.12 in plugin.yml and downgraded all dependecies to 1.12, but when I try to load it in newer versions of minecraft I get: org.bukkit.plugin.InvalidPluginException: Unsupported API version 1.12
Also it uses java 8
smoky anchor
the argument was added in 1.13
So just put 1.13
It should work on lower versions regardless
fervent cobalt
I will try that, thank you
silent steeple
Maybe wrap it in “”
smoky anchor
ye no
those characters NEVER work with ANYTHING programming related
smoky anchor
the argument was added in 1.13
So just put 1.13
It should work on lower versions...
I am assuming I am correct, since ElgarL stopped typing XD
fervent cobalt
the argument was added in 1.13
So just put 1.13
It should work on lower versions...
It worked! Thank you so much
Now the plugin supports ANY minecraft version *insert evil laugh*
I was wondering, is there like some sort of a list of what minecraft versions use what java version?
Couldn't find that
smoky anchor
Literally first result when googling "minecraft java java versions"
tho it is not full actually
manic furnace
wait I think I know this one
'cause I tried it years ago
You have to somehow reg...
When I set the output protocol to open, there is absolutely nothing about this command in it, except that it failed.
grizzled oasis
something with math I'm trying to do,
if a player sets the config every 1000 blocks are 1 level of exp, how can I calculate exp correctly to then every 1000 blocks give a level?
(this doesn't not depends on Minecraft level experience every 200000 exp is equal to some level but it's forced but should show correctly inside the bar if I have 200 blocks remaining it should show like it)
fervent cobalt
I found this but not sure
smoky anchor
When I set the output protocol to open, there is absolutely nothing about this c...
ye, I probably should have made myself clear
You can't create custom arguments unless you modify the client
chrome beacon
I found this but not sure
I sent you the information you needed earlier?
smoky anchor
ye, I probably should have made myself clear
You can't create custom arguments u...
But the arguments are for like JSON error message or swizzle error message
So unless you're making something fancy, you should not need them
manic furnace
ye, I probably should have made myself clear
You can't create custom arguments u...
Oh ok. Thanks
quiet ice
I found this but not sure
These the the supported Java versions, yeah
fervent cobalt
I sent you the information you needed earlier?
About the plugin - yes, it works now, thank you. This is another question
quiet ice
The recommended one is always the lowest java version though - unless you don't care about the userbase
fervent cobalt
These the the supported Java versions, yeah
Ok, thanks
quiet ice
if you want to run a server you should use the highest version in the list though
And ideally use a fork that supports newer java versions
manic furnace
But the arguments are for like JSON error message or swizzle error message
So un...
But is there a way to allow only the suggested options?
(They are dynamically generated)
smoky anchor
I don't think I quite understand
can you show a picture of an example or something ?
manic furnace
Like that you type: /test and then the plugin suggests n number of options. But you can only use these options. Otherwise it will be red
smoky anchor
Like that you type: /test and then the plugin suggests n number of options. But ...
yes
I do believe you can do this
either with just literals or some string argument option
I don't have my old code with me rn, if you don't solve it in an hour, tag me here
manic furnace
Ok thx
reef flower
Hello, I'm having problems with the encoding of my plugin / server. When I write "¨" in the chat, "¿" this appears in the console instead!
smoky anchor
Hello, I'm having problems with the encoding of my plugin / server. When I write...
That sounds more like a problem with the console not being able to show that character
nothing you should worry about I think
quiet ice
Are you calling new String() anywhere?
(or String#getBytes) - if not then it is probably that your client and your console are using different codepages
reef flower
That sounds more like a problem with the console not being able to show that cha...
okay but when i use a configfile with this char and i broadcast the char, the same think apears !
reef flower
Are you calling `new String()` anywhere?
no thats just a message logged in the console
quiet ice
Yes, but how do you obtain that message?
smoky anchor
okay but when i use a configfile with this char and i broadcast the char, the sa...
broadcast to players (in chat) ?
reef flower
Yes
quiet ice
If you pass it through any kind of input stream (and thus somehow calling new String(...) with a byte-array) then chances are this happens as intended
reef flower
Try explicitly saving the file as UTF-8 with your editor
already tried...
quiet ice
And when explicitly saving with ANSI?
silent steeple
Any good command frameworks where you can register commands using annotations
brazen oriole
What is the order of events that get called when a player joins a server? I was wondering if there is an event that happens after PlayerJoinEvent. I'm trying to send a PluginMessage packet to a player when they join, but it seems that the messaging channel isn't registered for the Player's connection until a bit after the PlayerJoinEvent happens.
reef flower
And when explicitly saving with ANSI?
nothing changes...
reef flower
What is the order of events that get called when a player joins a server? I was ...
PlayerLoginEvent before the PLayer join the server and PlayerJoinEvent when the player join the server
reef flower
What exactly IDK
I use ShadowJar to produce the .jar, the problem can't come from ? (gradle)
fervent cobalt
How to make the plugin jar smaller? Mine is giant, like 5MB, while the code is super simple.
smoky anchor
already tried...
What version are you on, do you ha e any resourcepacks
quiet ice
I use ShadowJar to produce the .jar, the problem can't come from ? (gradle)
Nah, it is a logic problem
flint coyote
How to make the plugin jar smaller? Mine is giant, like 5MB, while the code is s...
you probably have the wrong scope for your libs
fervent cobalt
"provided"
brazen oriole
Any good command frameworks where you can register commands using annotations
I really like the CommandAPI, which has limited support for annotation-based commands (https://commandapi.jorel.dev/9.0.3/annotationsintro.html). I haven't used it mayself, but I also hear AFC is good (https://github.com/aikar/commands).
eternal night
I mean, if you are shading all of adventure, that is a lot
quiet ice
How to make the plugin jar smaller? Mine is giant, like 5MB, while the code is s...
Maven or gradle?
fervent cobalt
Maven
quiet ice
Could you show the pom just so we are sure?
reef flower
What version are you on, do you ha e any resourcepacks
no i dont use ressource pack, i'm on 1.20.1 (mc version)
reef flower
Maven or gradle?
gradle
reef flower
I mean, if you are shading all of adventure, that is a lot
i need to shade Reflections and the discord api
quiet ice
gradle
not relevant for you as I already said it is a logic problem. You are somewhere converting from java.lang.String to byte[] to java.lang.String
reef flower
Could you show the pom just so we are sure?
build.gradle you mean ?
fervent cobalt
you probably have the wrong scope for your libs
Actually, most of the dependencies had no scope in pom.xml. Does this matter?
quiet ice
Yes - depending on the dependency it should be provided
fervent cobalt
Ok, I will try that, thanks
eternal night
obviously only those dependencies you do not need to shade
quiet ice
Yeah, no - something will break
flint coyote
most likely
eternal night
cannot wait for you to have set adventure platform to provided
and getting runtime clapped
fervent cobalt
idek what shading is ¯_(ツ)_/¯
eternal night
including the dependency in your output jar
which is needed if the depdency is not provided by the server itself
which would be the case for adventure and the likes on spigot
quiet ice
(or by another plugin)
fervent cobalt
Ohhhhh
reef flower
obviously only those dependencies you do not need to shade
my build.gradle loogs like : ```gradle
plugins {
id 'com.github.johnrengelman.shadow' version '7.0.0'
id 'java'
}
group 'fr.toutcourt.plugin'
version '1.0-SNAPSHOT'
repositories {
mavenCentral()
mavenLocal()
}
dependencies {
implementation 'net.dv8tion:JDA:5.0.0-beta.10'
implementation 'org.reflections:reflections:0.10.2'
compileOnly 'org.spigotmc:spigot-api:1.20.1-R0.1-SNAPSHOT'
}
shadowJar {
destinationDirectory = file("../../Minecraft Server/survival/plugins")
compileJava.options.encoding='UTF-8'
}
sourceCompatibility = targetCompatibility = '17'
compileJava.options.encoding = 'UTF-8'
I have these
<dependencies>
<dependency>
<groupId>org.spigotmc</groupId>
<artifactId>spigot-api</artifactId>
<version>1.12-R0.1-SNAPSHOT</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>com.theokanning.openai-gpt3-java</groupId>
<artifactId>service</artifactId>
<version>0.12.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>net.kyori</groupId>
<artifactId>adventure-api</artifactId>
<version>4.14.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>net.kyori</groupId>
<artifactId>adventure-text-minimessage</artifactId>
<version>4.14.0</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>net.kyori</groupId>
<artifactId>adventure-platform-bukkit</artifactId>
<version>4.3.0</version>
<scope>provided</scope>
</dependency>
</dependencies>
What should I do? I made them all provided just now
quiet ice
my build.gradle loogs like : ```gradle
plugins {
id 'com.github.johnrengelma...
Just give us the jar then
quiet ice
Again, this is probably not a build system problem but if you insist I can make it one
reef flower
Just give us the jar then
my plugin works but the utf-8 looks like broken
eternal night
compileJava.options.encoding='UTF-8' is also wrong there
that does not go into the shadowJar configuration
quiet ice
Java 17 is UTF-8 by default anyways iirc
fervent cobalt
all others need to be set to `compile`
Ok, so I'm back to where I was. How do I make it smaller now?
quiet ice
(Or was it Java 18? Whatever.)
eternal night
you don't
you are shipping a large amount of code
you can try to ask maven to minimize it
fervent cobalt
Can I shade only the relevant parts?
fervent cobalt
you can *try* to ask maven to minimize it
How?
quiet ice
Can I shade only the relevant parts?
That is called choosing the proper libraries
fervent cobalt
That is called choosing the proper libraries
I meant like the relevant part of a library
reef flower
Again, this is *probably* not a build system problem but if you insist I can mak...
where do you think the problem comes from?
eternal night
don't expact a magical solution tho
fervent cobalt
Ok, thanks
quiet ice
where do you think the problem comes from?
Any improper IO or .getBytes() calls
If you were to give me the jar I could quickly check thanks to recaf my beloved
(would also catch improper buildscript configs while we are at it)
reef flower
If you were to give me the jar I could quickly check thanks to recaf my beloved
how can i give you the jar ?
fervent cobalt
It worked a little bit. Now it is half a MB smaller than before. Maybe now SpigotMC will accept it. Huge thanks to everybody here
flint coyote
spigotmc has a 5MB limit?
fervent cobalt
Nope. Still too big. Guess I'll have to use somthing external
fervent cobalt
spigotmc has a 5MB limit?
Yes, at least for me
kind hatch
Last time I checked
4MB limit for normal resources.
4.5MB for premium resources.
flint coyote
well, should be enough for 95%
eternal night
Yes, at least for me
how low in terms of version are you supporting
if you are only going down to 1.16.5, you can use the library loader
that thing basically downloads dependencies on the servers for you
so you don't have to shade them
fervent cobalt
how low in terms of version are you supporting
all of them
since the plugin is so simple, I added support for all minecraft versions that support Java 8
It's fine, I'll just post a release on github
eternal night
yea ¯_(ツ)_/¯
silent steeple
I really like the CommandAPI, which has limited support for annotation-based com...
Thx
echo basalt
my build.gradle loogs like : ```gradle
plugins {
id 'com.github.johnrengelma...
Use spigot's library system
Given your dependencies are in mavenCentral
echo basalt
Depends on what your plugin does and what the errors are about
Read the exceptions then
That looks fine
We can't do much if we don't know what the error is
Show full code
?paste
undone axleBOT
echo basalt
I asked for full code not for 2 classes and an exception
Just a copypaste of the class
But I see an issue
And it's called static abuse
Which in this case will cause you issues if you ever /reload
If you're unfamiliar with static read this
Or in short
?di
undone axleBOT
Guide to dependency injection: https://www.spigotmc.org/wiki/using-dependency-injection/
echo basalt
And no, this is not an issue due to a custom spigot jar
Passing your map around with DI certainly helps
But ideally you'd change your get to a getOrDefault and pass false as your second param
Just for additional safety
That's what dependency injection is for
echo basalt
Guide to dependency injection: <https://www.spigotmc.org/wiki/using-dependency-i...
Read this
tender shard
Guide to dependency injection: <https://www.spigotmc.org/wiki/using-dependency-i...
that article is way too bloated imho
https://blog.jeff-media.com/getting-your-main-classes-instance-in-another-class/ this explains it much simpler
I mean wtf you don't need more than 2 sentences to explain it lol
umbral ridge
hey,
itemMeta1.getDisplayName().equals(itemMeta2.getDisplayName())
would be an equavilent to this?
Objects.equals(itemMeta1.getDisplayName(), itemMeta2.getDisplayName());
could I also use getEnchants() and getLore() on 2nd function?
tender shard
no, that's not the same
first one would throw NPE if itemMeta1 is null, Objects.equals() will not
umbral ridge
Objects.equals() will return false instead?
tender shard
then they are obviously not equal
tender shard
I'd always use Objects.equals in case one could be null
umbral ridge
Yeah, 🤓
timid hedge
Im trying to fix my pyramide with if statements but i am getting these errors: Suspicious indentation after 'if' statement should i just ignore them or have i done it wrong?
@EventHandler
public void onPlayerDamage(EntityDamageByEntityEvent e) {
Entity victim = e.getEntity();
Entity attacker = e.getDamager();
if (!(victim.getLastDamageCause() != null)) return;
if (!(victim instanceof Player && attacker instanceof Player)) return;
if (!(victim.hasPermission("Vagt"))) return;
victim.sendMessage("§3§lVAGT §f§lSYSTEM §8» §7Du blev slået af §a" + e.getDamager().getName());
if (!(attacker.hasPermission("Vagt"))) return;
attacker.sendMessage("§3§lVAGT §f§lSYSTEM §8» §7Du slog §a" + victim.getName());
if(!(((Player) victim).getHealth() <= 20)) return;
List<Player> players = new ArrayList<>();
Bukkit.getOnlinePlayers().stream()
.filter(p -> p.hasPermission("vagt"))
.forEach(p -> sendActionbar(p, "hej"));
}
It's warning you that you may have written something incorrectly based on the indentation
You can ignore it, but instead you should fix the indentation so: you get rid of the error, don't accidentally cause emotional damage to whoever reads the code
iron crow
Im trying to fix my pyramide with if statements but i am getting these errors: `...
ChatGPT response: https://prnt.sc/gtcYyX7zQq2c
umbral ridge
XD I read the indentation in your code is correct, which is causing the errors
iron crow
Basically, don't nest your code, it'll look a bit ugly, try using early returns.
- Each
(must end with), there cannot be 2 starts and 3 ends.
smoky anchor
Basically, don't nest your code, it'll look a bit ugly, try using early returns.
That is what is happening here
But he puts tab after the early return for some reason, which is causing the error I assume
iron crow
- Don't use
victim.getLastDamageCause(), usee.getDamageCause()
timid hedge
+ Don't use `victim.getLastDamageCause()`, use `e.getDamageCause()`
I dont have a e.getDamageCause option when im trying to change it
Oh, it was because i should use e.getDamager().getLastDamageCause()
Thanks for the help
timid hedge
Sorry, e.getCause()
Its fine, thanks
manic furnace
@smoky anchor sadly I didn't find a argument type the matches my requirements
smoky anchor
ok, I'll try to go through my old plugin
timid hedge
How do i get ride of this warning? Condition 'attacker instanceof Player' is redundant and can be replaced with a null check'
I have tried many thing but i am still getting this warning
if(!(victim instanceof Player && attacker instanceof Player)) return;
@EventHandler
public void onPlayerDeath(EntityDeathEvent e) {
Entity victim = e.getEntity();
Entity attacker = e.getEntity().getKiller();
if (!(e.getEntity().getLastDamageCause() == null)) return;
if(!(victim instanceof Player && attacker instanceof Player)) return;
if (victim.hasPermission("vagt")) {
victim.sendMessage("You killed " + attacker);
}
}
}
jagged quail
wet breach
How do i get ride of this warning? `Condition 'attacker instanceof Player' is re...
Attacker is a player therefore no need to check if its an instance of player
smoky anchor
<@239011484678488064> sadly I didn't find a argument type the matches my require...
ok, I have found argument.requires(Predicate)
But I do not think it will do what you need(I tried to look for documentation, but it's not Mojangs Brigadier github page... for some reason)
A way to do that would be to just manually build the command tree with literals
wet breach
But there is a playerdeathevent too
river oracle
I was today days old when I learned about PlayerDeathEvent
timid hedge
Attacker is a player therefore no need to check if its an instance of player
Ohh, thanks
How do i get the player that damaged the last time? so if a player died to fall damaged it sends in the that the player died to the last that hit the player
wet breach
Probably need to listen for playerinteractentity event
Use a global object that can be set so when the player dies you can check if they were a few ticks ago hit by a player and then can attribute their death to such
timid hedge
I dont know if this is correct but its kind of this right?
String killer = e.getEntity().getKiller().getPlayer().getName();
torn shuttle
I feel scammed, I've been working out for something like 2 years now and I still get DOMS bad enough that it hurts to even program
undone axleBOT
torn shuttle
anyone familiar with the remapped nms code? is #canReach actually whether it has already reached the target?
hm... actually I wonder if moveTo is returning whether the objective can be reached
looks like it might be
umbral ridge
How do you make a player "lay down" when they die? (for a few seconds)
What's the best to achieve this? packets?
manic furnace
ok, I have found argument.requires(Predicate)
But I do not think it will do what...
Ok thank you very much
timid hedge
Can someone help?
umbral ridge
Does that happen too, if you restart the server?
timid hedge
Yeah
remote swallow
you have an invald .env path, and the file doesnt exist
umbral ridge
I don't know much about this but .env is a file for variables I believe
I use it for completely different thing, vue.js, js framework
timid hedge
you have an invald .env path, and the file doesnt exist
I have 1 named files.env and one named info.env and i cant see why i am getting a error because of that
remote swallow
pretty sure thats not have env files work
tender shard
I have 1 named files.env and one named info.env and i cant see why i am getting ...
so you don't have any .env file
you have two filles with a different name and none called .env
timid hedge
I have, i have 2, 1 named files.env and another one named info.env
tender shard
yes
you have two files that are not named .env
and you have 0 files that are named .env
while you should have one file that's called .env
timid hedge
But when its .env it dosent work, that was the problem yesterday
tender shard
?notworking
undone axleBOT
"Does not working" is a useless statement. Please describe what exactly is not working, what you expect it to do, and what actually happens. If you get any console errors, also ?paste the entire stacktrace.
timid hedge
So if i have 1 named .env and 1 named test.env it should work?
tender shard
i dont even know what you're trying to do
so no clue what you mean with "it should work"
timid hedge
So im not getting the error in the console
tender shard
all I know is that yesterday you sent a stacktrace where dotenv couldnt find a file called .env
compact haven
the file has to be named literally ".env"
the only time you have "<anything>.env" is when you are running a different .env for prod/staging
and that has to be configured with dotenv, you don't just magically have three files ending in .env and they all load
torn shuttle
why the hecking heck are my entities absolutely crawling with this movement speed...
timid hedge
So when i have one file named ".env" what should i call the other one "info.env" or ".env.info"?
remote swallow
why are you even using env files in the first place
torn shuttle
oh there we go now they're moving normally
glad prawn
He doesn't know what he has to do 😭
obtuse meadow
Does anyone know how to create a protocollib packet SCOREBOARD_TEAM that shows invisible players for the members? Thansk
lavish hemlock
What's a more efficient idea?
- Creating a listener per inventory.
- Creating a listener per plugin that delegates to different inventories.
I've been a bit mixed on how to implement GUIs in a way that could easily scale while having a nice API.
ivory sleet
What's a more efficient idea?
- Creating a listener per inventory.
- Creating a ...
Latter
Less committed to the spigot api is a benefit imo
lavish hemlock
Figured. This is meant to be platform-agnostic so registering events could get slower when working with something like Paper.
ivory sleet
Yeah
lavish hemlock
Less committed to the spigot api is a benefit imo
I agree.
For one, I dislike Spigot's API. For two, I need to abstract if I want to support a wider range of platforms.
ivory sleet
Yeah right, much nicer to have ur own event bus for ur other modules and eventual api users
lavish hemlock
My main rationale is that I'm going to be having clients of different server architectures.
Most people'll use Spigot or a fork, of course, but there's always exceptions.
I'm in the process of abstracting away the plugin loading mechanism.
wet breach
My main rationale is that I'm going to be having clients of different server arc...
Yeah like spoons
lavish hemlock
Possibly even a spork.
torn shuttle
I love the mineblox spork that allows me to run spigot plugins in robolox
ivory sleet
I'm in the process of abstracting away the plugin loading mechanism.
Same, I even use a hacky design to have my own classloader to load my plugin
lavish hemlock
Oh that was what I was considering doing
ivory sleet
lavish hemlock
I've done classloader hacking in the past to do stuff like runtime class modification
brisk estuary
hey, is this the correct way to check if it's the first time the villager get trades? I mean, when it gets the first 2 trades
@EventHandler
public void onVillagerGetTrade(VillagerAcquireTradeEvent e) {
AbstractVillager villager = e.getEntity();
List<MerchantRecipe> trades = villager.getRecipes();
if (trades.isEmpty() || trades == null) {
// insert new trade
}
}
This code would produce an NPE
You check if the value is null after calling a method on it
brisk estuary
yea ur right, i just have to invert it
vivid tangle
Hello everyone. Some body have a todo list to check for start use Spigot with the wiki, i know java basement.
brisk estuary
but is it the correct way to check if it's the first time the villager get trades?
ocean hollow
how can i create custom enchant? it gives my that
lavish hemlock
```java
@EventHandler
public void onVillagerGetTrade(VillagerAcquireTradeEve...
What version is this code for?
brisk estuary
1.19
lavish hemlock
Okay well getRecipes is marked as @NonNull so the null check is redundant
Just check if it's empty, that might work.
brisk estuary
oh, I didn't notice that, thank you
lavish hemlock
Additionally if you're inserting trades, don't do it with the list returned by getRecipes
Docs say it's immutable, so modifying it would cause an error
brisk estuary
yea, there's a method to insert trades
lavish hemlock
A'ight.
lavish hemlock
Well I do it a jar in a jar fashioned way like luckperms
Something I've considered with my plugin mechanism is live reloading
It's not a good idea to live reload Bukkit plugins but if I'm not relying on Bukkit's plugin mechanism then it's no big deal
Only issue is that you can't unload classes in Java
Well actually I think you can.
But only through instrumentation or JVM TI?
lavish hemlock
Supposedly it is possible to unload a class as long as the classloader is garbage-collected.
ivory sleet
Yeah
lavish hemlock
Not too difficult if that's the case.
ivory sleet
By far not reliable but I mean hey it’s there
lavish hemlock
Yeah but thankfully this is a me-only feature
lavish hemlock
I dislike restarting the server over and over to test
A long time ago I wrote a Gradle plugin that let you build and start a server but I abandoned that project because it was too hard to maintain
ivory sleet
Oh have u tried running debug mode with the jvm thingy that allows for better debug
lavish hemlock
You mean uhh
ivory sleet
Yea paper has good stuff now
ivory sleet
yeah
Always forget the name
But it’s pretty neat although unsure how up to date it is
lavish hemlock
I tried to use that once but it just wouldn't start up, lol
ivory sleet
🥲
lavish hemlock
Stuff like this is why I stopped writing Java
But uh, Spigot is a profitable market so I'm back at it, I guess
lavish hemlock
Stuff like this is why I stopped writing Java
For the past few months I've been writing Rust exclusively. Actually had a neat project in development. https://github.com/maow-tty/tokyo
ivory sleet
Oo yeah if (almost) everything was in rust we would line in peace 100%
lavish hemlock
I agree from the standpoint of someone who hates writing C and C++.
I don't actually dislike the languages all that much.
Just the build tools :)
Swear to god, GNU software makes me want to game end myself
ivory sleet
Lol understandable
ocean hollow
Now I need to enter NameSpacedKey, what should I enter?
paper cosmos
can I play a sound when deciding which one to use from IJ because there are a lot of sounds and I dont know what many of them sound like?
lavish hemlock
I believe there's a page on the wiki.
It'll probably be a pain in the ass to find the specific sound event IDs for each but you can also look at the game files
warm light
is this the corrent way to check if custom event is cancelled?
tender shard
gobbledegook
tender shard
is this the corrent way to check if custom event is cancelled?
no
warm light
how can I do it then?
tender shard
Cancellable myEvent = new MyEvent(...);
// Now call the event
getServer().getPluginManager().callEvent(myEvent);
// Now check if it was cancelled
if(myEvent.isCancelled()) {
// My Event was cancelled
}
remote swallow
HeadDropEvent headDropEvent = new HeadDropEvent
tender shard
erm no?
no need to cast anything
public class HeadDropEvent extends Event implements Cancellable {
seems like your event class does not extend Event
onyx fjord
what event triggers this (bed)
remote swallow
seems like your event class does not extend Event
look at the line aboe
above
Cancellable ... = new HeadDropEvent
tender shard
oh yeah
flint coyote
what event triggers this (bed)
interact event on a bed?
tender shard
i assumed Event was an interface that Cancellable extends
mossy dock
@Override
public void belowPrefix(Player player, int score, Component content) {
Scoreboard scoreboard = player.getScoreboard();
Objective objective = scoreboard.registerNewObjective("BelowNames", Criteria.DUMMY, content);
objective.setDisplaySlot(DisplaySlot.BELOW_NAME);
player.setScoreboard(scoreboard);
}
Any idea how i could change the score 0 to the score var?
onyx fjord
interact event on a bed?
yea but i see no way to cancel the message and let the event run
reef flower
Hi ! i have a problem, i'm using some custom configFile but when i try to know if the config file exist,
file.getAbsoluteFile().exists()
always return false... can someone help me ?
remote swallow
just do file.exists
flint coyote
yea but i see no way to cancel the message and let the event run
yeah there probably is no way
onyx fjord
btw when i set Player#setBedSpawnLocation player still gets message when right clicks the exact same bed
reef flower
just do file.exists
same problem
ivory sleet
same problem
The file does not exist then
flint coyote
btw when i set Player#setBedSpawnLocation player still gets message when right c...
doublecheck that getBedSpawnLocation is equal to the one that is set afterwards
ivory sleet
U sure u use the same file for everything thats related?
reef flower
The file does not exist then
the file exist
reef flower
U sure u use the same file for everything thats related?
no my file's nbame is lang.ymland he is in the folder of my plugin but when i tried to know if the file exist he saied nop and overwrite my file
reef flower
if (!this.file.getAbsoluteFile().exists()) {
this.plugin.saveResource(template_file_name, true);
}
More than that will be needed
reef flower
Wait i break the code cause discord sayed too much char
ivory sleet
?paste
undone axleBOT
tender shard
what is "file"?
reef flower
tender shard
print out the path of file
reef flower
absolute or not ?
onyx fjord
i guess this will work
reef flower
C:\Users\natha\Desktop\Java\Minecraft Server\survival\plugins\lang.yml
onyx fjord
for the message
tender shard
C:\Users\natha\Desktop\Java\Minecraft Server\survival\plugins\lang.yml
yeah that's not the correct path
i doubt you want to save your file in plugins/
warm light
`Cancellable ... = new HeadDropEvent`
so this is correct?
tender shard
it's because you add this weird "parent + /" to your file's path
reef flower
Oh yeah my bad !
tender shard
also why aren't you just using getDataFolder() ?
reef flower
idk
tender shard
getDataFolder returns your plugin's folder, e.g. plugins/MyPlugin/
you can create files inside that like new File(plugin.getDataFolder(), "lang.yml");
reef flower
yeah i know but idk why i dont use this !
quaint mantle
hey i got a quick question how would i disable a wither not taking arrow damage below 50%?
paper cosmos
https://minecraft.fandom.com/wiki/Category:Sound_effects
thank you
cold tartan
What is the difference between rayTrace, rayTraceEntities, & rayTraceBlocks?
tender shard
hey i got a quick question how would i disable a wither not taking arrow damage ...
EntityDamageByEntityEvent, check if the damager is an arrow, check if the wither got less than 50% HP, if both is true -> cancel event
quaint needle
hey i got a quick question how would i disable a wither not taking arrow damage ...
i think this is just normal minecraft when it activate it's shield that means it cannot take projectile dammage
tender shard
What is the difference between rayTrace, rayTraceEntities, & rayTraceBlocks?
rayTrace = both
entities = only entities
blocks = only blocks
quaint needle
not sure
remote swallow
so this is correct?
yeah
cold tartan
rayTrace = both
entities = only entities
blocks = only blocks
so rayTraceEntities goes through blocks?
tender shard
so rayTraceEntities goes through blocks?
yes
quaint mantle
also can i force a wither to go lower, ik if a wither is below 50% hp to hover's lower
warm light
here my code. so the event get called before the drop adding
I have cancled the event in 2nd class. so its not modifying the drops.
but in 3rd class, I did a task on that event. and that didn't got cancelled :/
tender shard
wdym "I did a task on that event"?
pseudo hazel
also can i force a wither to go lower, ik if a wither is below 50% hp to hover's...
that is what a vanilla wither will also do, it will lower itself when the ranged shield activates
not like instantly
but gradually
remote swallow
here my code. so the event get called before the drop adding
I have cancled the ...
that shouldnt be made like that
quaint mantle
yes but can i force it if its not at 50%
pseudo hazel
not that I know
remote swallow
the event should have the new drop included, then if it isnt cancelled you drop it on the floor
warm light
wdym "I did a task on that event"?
like it will send a notify on discord if a mob drop head.
so if I cancle the HeadDropEvent, it don't drop head. but send notify on discord
quaint mantle
not that I know
i tried looking at EntityWither and it calls a method .cm() which is a boolean, tried overriding it and damageEntity but it just recursively calls
gusty jungle
Guys, can you create a plugin that has items with custom textures?
quaint mantle
Guys, can you create a plugin that has items with custom textures?
custom model data
and a texture pack
tender shard
Guys, can you create a plugin that has items with custom textures?
you need a resource pack
gusty jungle
Does it overwrite textures or add new items in this case?
tender shard
add new ones
cold tartan
Does it overwrite textures or add new items in this case?
you can make items have specific textures based on their name or other properties
tender shard
it doesnt really add new items, it just makes you able to use different textures for already existing items without changing the default item look
gusty jungle
Can you explain to me how I can do it?
chrome beacon
The Minecraft wiki has all the information you need
tender shard
warm light
like it will send a notify on discord if a mob drop head.
so if I cancle the Hea...
can you help me mfnalex pls :")
gusty jungle
Ty
quaint mantle
tender shard
like it will send a notify on discord if a mob drop head.
so if I cancle the Hea...
i dont get it. why dont you just send the notification in the same block where you add the drops?
gusty jungle
Can I also use them in a custom craft?
gusty jungle
Ty
quaint mantle
it can do all the things a normal item can it just gets rendered differently client side
gusty jungle
Ok
remote swallow
send the message if the event isnt cancelled
gusty jungle
So I have to create a custom model data pack?
But if I use items from other plugins in the craft, is that a problem?
quaint mantle
no
just add the checks for those items
but those items wont have the custom model data (so no custom textures) unless the author or you sets it
orchid trout
whats the purpose of implementing an interface once
ocean hollow
how to register Enchantment when server is enabling, it gives me IllegalStateExeption
tender shard
how to register Enchantment when server is enabling, it gives me IllegalStateExe...
you are not supposed to register any enchantments
if you want to do it anyway, you gotta use reflection to allow registering new enchantments https://github.com/JEFF-Media-GbR/JeffLib/blob/master/core/src/main/java/com/jeff_media/jefflib/EnchantmentUtils.java#L48
however there is really no reason to do it unless you wanna create a fake glow enchantment
ocean hollow
and why not register, I need it to be just like a real one, appear in the enchantment table, for example
timber basalt
and why not register, I need it to be just like a real one, appear in the enchan...
Dr Murphy 😄
chrome beacon
and why not register, I need it to be just like a real one, appear in the enchan...
You're still going to have to handle much of the behaviour yourself
For example the client won't be able to see the name
So you need to listen to a bunch of events and add lore
ocean hollow
I only need the appearance in the table of enchantments, trade with the inhabitants, everything else itself.
ocean hollow
For example the client won't be able to see the name
really?
chrome beacon
Yeah
And you won't be able to get it to display the name when hovering the enchantment buttons
tender shard
and why not register, I need it to be just like a real one, appear in the enchan...
that won't happen anyway
ocean hollow
but why it has Rarity and can be Traded?
chrome beacon
So you can check the rarity and if you can trade for it
chrome beacon
?
mossy nimbus
Is there a way to avoid nbt stuff from Being able to place/use?
chrome beacon
Is there a way to avoid nbt stuff from Being able to place/use?
Yeah listen to place and interact event
Cancel if it has the information
pseudo hazel
how instant will a task timer set to 0 be completed once its started?
like the next tick?
ivory sleet
wdym?
eternal oxide
probably but no guarantee
ivory sleet
Im still confused about the question
pseudo hazel
okay so lets start from the beginning
I am creating a plugin where I want to divide some players from a list into teams, I am currently getting a concurrentmod exception when removing from my list, likely because I am ending the timer too soon
I have a timer which when it goes of should start the game
the timer start when enough players have joined
but in teh config you can set the timer to 0 seconds
so my timer is going off probably before I added the player to the team
and while the timer is timing out, and messing with the list, I am trying to add a player to said list
lavish hemlock
I am creating a plugin where I want to divide some players from a list into team...
Are you sure you're not just getting the exception because you're removing whilst iterating over the list?
pseudo hazel
no
I am explicitly using iterators to avoid that
but
it can still be modified from the outside
because if I just change the timer to be 1 second, I have no issues
hence why I thik its actually because I am adding to the list
hmm
nvm
seems like I will have to do more debugging on the actual feature
nova notch
for (NamespacedKey key : player.getPersistentDataContainer().getKeys()) {
player.sendMessage(key.toString() + " VALUE");
}```
how do i iterate over the keys and get their values?player.getPersistentDataContainer().get(key)
rain cypress
Is there an event that's triggered when a suspicious block changes state from a player using a brush?
pseudo hazel
and idk how to do the thing when the type is unknown
lol idk actually, I always use pdc where I know what my values are supposed to be
rare rover
quaint mantle
```java
for (NamespacedKey key : player.getPersistentDataContainer().getKeys()) ...
whats your use case
pseudo hazel
idk what kinda monster plugin you would have to have to make it super long
nova notch
whats your use case
storing a bunch of different variables with different types in PDC and putting them into a json file
like idk a message and a kill count
actually i guess i dont need to do that cus i can just remove the stuff i dont want to keep since it saves itself
but i still wanna figure it out
pseudo hazel
yeah the whole point of pdc is that you dont need to save it somewhere else
nova notch
maybe i want to make backups idk
young knoll
If you backup the world like you should, that will also backup PDC
nova notch
fine ill do it the lame manual way
pseudo hazel
it seems like pdc wasnt made for what you wanna do
tender shard
```java
for (NamespacedKey key : player.getPersistentDataContainer().getKeys()) ...
just get the correct datatype by checking has(...)
https://github.com/JEFF-Media-GbR/PersistentDataSerializer/blob/main/src/main/java/com/jeff_media/persistentdataserializer/PersistentDataSerializer.java#L116
nova notch
wait so when is pdc actually saved to the file
every few min or on server shutdown or what
nova notch
...it saves when it most??
eternal night
it saves with the parent
on a chunk, it saves when the chunk is saved
on an item, it is saved when an item is saved
nova notch
oh
icy bone
I got a question, i made this part to send a player a message the moment the players is standing to long on the same block (not coords, same block):
@EventHandler
public void onPlayerMove(PlayerMoveEvent e) throws IOException {
Player player = e.getPlayer();
if(isStandingOnSameBlock(player))
{
Bukkit.getScheduler().runTaskLater(plugin, () -> {
if(isStandingOnSameBlock(player))
{
player.sendMessage("You have transformed!");
}
}, 60L);
}```
But i got a question, does the task keep the player that triggerd it or is it possible if multiple players are online that the message will go to the wrong player?Cuz im not sure if im standing still for example and right before the task runs (after 3 sec) another player moves and the message will be send to that player
eternal night
this would be fine
icy bone
Ah okay so no multiplayer issues here
eternal night
the player variable is method local
this would be an issue if the variable is defined e.g. on the class
icy bone
Ahh okay awesome, thank you!
tender shard
what does isStandingOnSameBlock do?
remote swallow
io ig
hushed spindle
how would one avoid a ClassNotFoundException if a class in my code exists and it references a class from a future version that doesn't exist on the one i'm playing, even if that code is never ran because of a version check?
like i got a custom recipe class that references SmithingTransformRecipe, but this doesn't exist in 1.19 versions so it throws that error, even though the code will never get to that point
ivory sleet
its an exception from a reflective call
NoClassDefFoundError is if the class doesnt exist tho
hushed spindle
yeah obviously
thats not the point
i want my plugin to support a range of versions but this 1.20 class doesnt exist in other versions, but i still need to work with it
how would i avoid that in a preferably nice way, because i know i can just put that referenced class in a different class and have it do its thing that way
tender shard
how would one avoid a ClassNotFoundException if a class in my code exists and it...
quick and dirty way, only works for local variables and stuff:
you'd wrap that into something that checks beforehand
if(McVersion.current().isAtleast(1,20)) {
SmithingTransformRecipe recipe = new SmithingTransformRecipe(...);
// ,,,
i could have sworn it used to do that before but im pretty sure because i persist and load this object with gson it does it anyway
tender shard
and the whole stacktrace
hushed spindle
pretty sure its just because of gson that it throws the exception regardless
i dont even have any custom smithing recipes made right now so the bit of code that's meant to generate the recipe never runs either
just the reference alone causes the exception
ivory sleet
yes its gson
cuz gson uses reflection (sometimes)
and u happen to be getting cnfe
which is impossible to get if u dont use reflection
hushed spindle
is there some workaround i can use to avoid it
ivory sleet
how exactly do u use gson rn?
hushed spindle
like can i make a fake SmithingTransformRecipe to trick gson lol
tender shard
put your gson deserialization into a try/catch
hushed spindle
i guess yeah
i dont think im doing anything special with gson, besides registering some type adapters for my abstract classes and interfaces
its not even allowing me to catch CNFE because it thinks it's never thrown
tender shard
Isnt the CNFE caused by NoClassDefFoundError?
Or sth
Worst case, catch Throwable and rethrow anything thats not NoClassStuff
tender shard
you cannot detect that reliably
listen to incoming ServerboundCustomPayloadPacket
idk how exactly the data looks, but that's the one where forge MIGHT send a list of mods
you can easily disable that with another mod though
sooo it's not reliable at all
to listen to that?
you either need to inject a custom netty listener, or use sth like ProtocolLib or PacketEvents
i'd suggest ProtocolLib because then you don't need to update for every new NMS version
PacketEvents requires to be shaded, and yeah NMS you also gotta recompile for every new versino
who? ProtoclLib?
it is
one sec
river oracle
was there even many changes in 1.20 for protocol
tender shard
hmmm
weird, idk then
one sec
oh yeah you're right, I thought I was running ProtoclLib but I'm not
hmm then I'd use a custom netty listener
?nms
tender shard
and then you can follow this guide, it's outdated but the general principle is still valid https://www.spigotmc.org/threads/packet-listener-using-netty-tutorial.69772/
river oracle
oh yeah you're right, I thought I was running ProtoclLib but I'm not
PacketEvents
tender shard
and then you can follow this guide, it's outdated but the general principle is s...
except you must not use reflection because obviously the names change on every version
PacketEvents would also work if it's on 1.20, idk
never used it
river oracle
PacketEvents would also work if it's on 1.20, idk
it was updated last week so I'd assume it was
PacketEvents is 1.8+
afaik
idk try it out
novel kite
Heyo, I've got a few questions about sending custom events as I've never used it before.
- When an external plugin depends on my artifact to have the event should it shade my code or use as provided?
- If shade, if a plugin relocates the artifact would it still be able to use the event as normal?
use packetevents 2.0, 1.8.x is outdated
river oracle
I sent you the link
on github
compile it yourself then? though you shouldn't need to
its not a plugin
its a library
just use moj maps then
novel kite
2.0 github https://github.com/retrooper/packetevents/
2.0 examples https://github.com/retrooper/packetevents-example/tree/2.0
river oracle
you don't even need to use all these libraries just use mojang maps + nms
novel kite
Use the CodeMC repository as shown here
https://github.com/retrooper/packetevents-example/blob/2.0/pom.xml
young knoll
ProtocolLib and packetevents both work for 1.20.1
novel kite
then you gotta compile your own copy
river oracle
PacketEvents isn't a plugin no?
young knoll
It can be run as one
novel kite
PacketEvents isn't a plugin no?
it can be, yeah
river oracle
oh didn't know
I thuoght you had to shade it
they probably just haven't updated the spigot page yet
young knoll
Use the latest dev build
icy bone
what does isStandingOnSameBlock do?
Own function that checks if person is still on the same block as before
tender shard
why don't you just compare the move event's getFrom and getTo()
eternal night
I mean, those locations will always change
tender shard
ofc I meant the block
eternal night
ah
tender shard
basically just check if getFrom().getBlock().equals(getTo().getBlock())
eternal night
either you are not depending correctly or you are shading the API
yea no scope means it would be shaded
ye
undone axleBOT
tender shard
onPacketSending is to listen to outgoing packets
you have to listen to the incoming packet, not the outgoing
public class ProtocolLibTest {
{
Plugin plugin = null;
ProtocolManager manager = ProtocolLibrary.getProtocolManager();
manager.addPacketListener(new PacketAdapter(plugin, ListenerPriority.NORMAL, PacketType.Play.Client.CUSTOM_PAYLOAD) {
@Override
public void onPacketReceiving(PacketEvent event) {
// Stuff
}
});
}
}
works fine for me
idk whether the correct type is Client or Server, protocollib's names are ridiculous
they should use the proper names, Clientbound and Serverbound
simply saying "Client" or "Server" makes absolutely no sense because the packets are alwayws sent between client ADN server lol
idk which is the correct one
no clue why protocollib fails to use the correct packet names
?
then client is the correct one
and it's out of bounds because that packet doesn't have any strings
it only has a byte array or sth
eternal night
why are you listening to the custom payload packet 
ehm
given how trivial it is to disable that modlist sending
not really an effective way
I mean, depends on the mod you want to counteract ?
anti xray and anti cheat work well
worldly ingot
Cheat mods and clients aren't going to announce that they're joining
eternal night
yeaaa
worldly ingot
They'll present themselves as vanilla
worldly ingot
lynx typing too slow
eternal night
I mean, you can do it this way
its a minimal barrier for entry
will it block people that know a bit about abusing mods
no
nova notch
just get the correct datatype by checking has(...)
https://github.com/JEFF-Media...
ive been looking at this for like an hour and idk what im doing
tender shard
what do you not understand?
nova notch
anything
tender shard
yeah well idk how to explain it then lol
imho it's pretty straightforward
better dont look at MorePersistentDataTypes then lol
nova notch
is this what you mean by has or what am i supposed to be looking for
tender shard
yes
it loops over all existing primitive PersistentDataTypes, checks if the pdc has(this type) and if yes, returns it
the list of native types (NATIVE_PRIMITIVE_PERSISTENT_DATA_TYPES) is set via reflection in the static init block
tender shard
yes
I mean, the javadocs explain that
Gets the proper {@link org.bukkit.persistence.PersistentDataType} for the given {@link NamespacedKey}
eternal night
I'd strongly suggest ordering that
the average speedup of first checking STRING, INTEGER, BYTE_ARRAY
vs them being in a set
young knoll
Shame we don't have a method to just get an object without a type