#help-development | SpigotMC | Page 609

silent steeple Jul 9, 2023, 2:53 PM

#

just the active thing

remote swallow Jul 9, 2023, 2:54 PM

#

25565 most likely isnt open with it then

#

see if anything shows up with sudo ufw status

echo basalt Jul 9, 2023, 2:54 PM

#

I wonder if linux devs say sudo-code instead of pseudo-code

silent steeple Jul 9, 2023, 2:54 PM

#

i did this

#

sudo ufw allow 25565

#

and now it says

#

v

#

Status: active
Logging: on (low)
Default: deny (incoming), allow (outgoing), disabled (routed)
New profiles: skip

To Action From

25565 ALLOW IN Anywhere
25565 (v6) ALLOW IN Anywhere (v6)

remote swallow Jul 9, 2023, 2:55 PM

#

sudo ufw reload

silent steeple Jul 9, 2023, 2:55 PM

#

ight

#

ima run the server now

#

yesss its working

#

thanks epicebic

remote swallow Jul 9, 2023, 2:58 PM

#

enjoy the port scanners btw

silent steeple Jul 9, 2023, 2:58 PM

#

yeah im turning on whitelist

#

lol

agile laurel Jul 9, 2023, 2:58 PM

#

remote swallow enjoy the port scanners btw

block known spam ASs

remote swallow Jul 9, 2023, 2:59 PM

#

silent steeple yeah im turning on whitelist

whitelist wont stop port scanners

silent steeple Jul 9, 2023, 2:59 PM

#

ok so? they cant connect

remote swallow Jul 9, 2023, 2:59 PM

#

ur console would get flooded

silent steeple Jul 9, 2023, 2:59 PM

#

really bruh

#

how do i stop them

agile laurel Jul 9, 2023, 2:59 PM

#

silent steeple ok so? they cant connect

They still can query info about your server + add lag since packets are processed by the server

remote swallow Jul 9, 2023, 2:59 PM

#

somethign like this

#

fail2ban would be useful in most cases

silent steeple Jul 9, 2023, 3:00 PM

#

weirdos bruh how do i make it so they cant

remote swallow Jul 9, 2023, 3:00 PM

#

fail2ban

silent steeple Jul 9, 2023, 3:00 PM

#

whats fail2ban

#

how do i delete a world in linux

#

rmdir or rm doesnt work

#

got it 👍

river oracle Jul 9, 2023, 3:02 PM

#

echo basalt I wonder if linux devs say sudo-code instead of pseudo-code

no

#

we say super-user-do-code

#

acronyms are bloat to the dictionary

remote swallow Jul 9, 2023, 3:03 PM

#

do you still say faq

river oracle Jul 9, 2023, 3:03 PM

#

no

#

just say Frequently Asked Questions

remote swallow Jul 9, 2023, 3:04 PM

#

faqu then

river oracle Jul 9, 2023, 3:04 PM

#

faq is bloat

dull schooner Jul 9, 2023, 3:04 PM

#

hey, does anyone know how to make a player use a held item?

silent steeple Jul 9, 2023, 3:09 PM

#

dull schooner hey, does anyone know how to make a player use a held item?

like even when the item is unusable?

dull schooner Jul 9, 2023, 3:09 PM

#

nope

#

to give some context, im trying to do an autofishing

river oracle Jul 9, 2023, 3:14 PM

#

dull schooner hey, does anyone know how to make a player use a held item?

PlayerInteractEvent and then check for right click

crystal latch Jul 9, 2023, 3:15 PM

#

Hello, with custom npc how to execute a command to the player who clicks on it?

dull schooner Jul 9, 2023, 3:20 PM

#

river oracle PlayerInteractEvent and then check for right click

i mean, i want to simulate the right click, not check if it happened

#

otherwise it isnt an autofishing

late sonnet Jul 9, 2023, 3:25 PM

#

remote swallow fail2ban

exists a guide for this?
if i remember you need configure a regex for that not?

remote swallow Jul 9, 2023, 3:25 PM

#

idk, havent had a reason to set it up yet lol

hazy parrot Jul 9, 2023, 3:28 PM

#

late sonnet exists a guide for this? if i remember you need configure a regex for that not?

https://github.com/asifbacchus/fail2banUFW here is preconfigured for ufw

late sonnet Jul 9, 2023, 3:28 PM

#

remote swallow idk, havent had a reason to set it up yet lol

XD i remember a old case for a user spamming connection and pretty sure a plugin listening the joinevent make the server very slow (maybe was that.. many time since this)

late sonnet Jul 9, 2023, 3:29 PM

#

hazy parrot <https://github.com/asifbacchus/fail2banUFW> here is preconfigured for ufw

nice i take a look.

river oracle Jul 9, 2023, 3:33 PM

#

dull schooner i mean, i want to simulate the right click, not check if it happened

you can't simulate a right click afaik

#

thouhg I suppose you could send a packet not sure how the client would respond to that though

dull schooner Jul 9, 2023, 3:34 PM

#

maybe with nms?

river oracle Jul 9, 2023, 3:40 PM

#

dull schooner maybe with nms?

probably only somethnig that can be done with packets if at all

eternal oxide Jul 9, 2023, 3:45 PM

#

There is a swing arm method.
You can fire your own interact event and there is a method to execute a command by the player. If thats what they mean.

river oracle Jul 9, 2023, 3:50 PM

#

eternal oxide There is a swing arm method. You can fire your own interact event and there is ...

oh probably what they mean

fluid river Jul 9, 2023, 3:51 PM

#

they who

#

you are answering one guy fr

river oracle Jul 9, 2023, 3:53 PM

#

fluid river they who

They can be used in a singular sense

#

Used to refer to the one previously mentioned or implied or Used to refer to the ones previously mentioned or implied

rose trail Jul 9, 2023, 3:59 PM

#

can the CompletableFuture be reused?

river oracle Jul 9, 2023, 4:00 PM

#

wdym by re-use

crystal latch Jul 9, 2023, 4:00 PM

#

Hello, with custom npc how to execute a command to the player who clicks on it?

river oracle Jul 9, 2023, 4:01 PM

#

crystal latch Hello, with custom npc how to execute a command to the player who clicks on it?

are you a developer?

crystal latch Jul 9, 2023, 4:01 PM

#

river oracle are you a developer?

Nope

river oracle Jul 9, 2023, 4:01 PM

#

#help-server

river oracle Jul 9, 2023, 4:01 PM

#

crystal latch Nope

maybe in #help-server specify the plugin? custom npc is pretty vague

crystal latch Jul 9, 2023, 4:02 PM

#

its custom npc for jobs reborn

river oracle Jul 9, 2023, 4:02 PM

#

ask in their discord they probably have one

river oracle Jul 9, 2023, 4:02 PM

#

crystal latch its custom npc for jobs reborn

https://www.spigotmc.org/resources/jobs-reborn.4216/

SpigotMC - High Performance Minecraft

Jobs Reborn

#

river oracle Jul 9, 2023, 4:02 PM

#

rose trail can the CompletableFuture be reused?

No

#

there's no need to ever "reuse" one anyways

#

they are single operations

remote swallow Jul 9, 2023, 4:04 PM

#

river oracle

nice image

rose trail Jul 9, 2023, 4:04 PM

#

river oracle No

I need to get a message from the proxy server before the command completes, can you recommend something?

#

I send the player's name to the proxy server and it returns the uuid to me, but it turns out that the uuid is returned after the command

#

And I need to use it in the command

river oracle Jul 9, 2023, 4:06 PM

#

?paste

undone axleBOT Jul 9, 2023, 4:06 PM

#

https://paste.md-5.net/

river oracle Jul 9, 2023, 4:06 PM

#

show me the code

#

seems like you have flawed design

#

I wanna see what you're doing it

eternal oxide Jul 9, 2023, 4:07 PM

#

you can;t use it in the command, but you can send some trigger data in the request so when you get a response you can run the command you want

#

your response should contain whatever data you need to run the command

river oracle Jul 9, 2023, 4:07 PM

#

eternal oxide your response should contain whatever data you need to run the command

I'm thinking maybe they aren't using CompletableFuture's thenAccept correctly

eternal oxide Jul 9, 2023, 4:08 PM

#

nope, they are using messaging channels

river oracle Jul 9, 2023, 4:08 PM

#

oh Ic

rose trail Jul 9, 2023, 4:09 PM

#

river oracle show me the code

https://paste.md-5.net/opohifadom.java

river oracle Jul 9, 2023, 4:10 PM

#

rose trail https://paste.md-5.net/opohifadom.java

why are you using future#get

#

you're halting the main thread

#

use thenAccept or whenComplete

eternal oxide Jul 9, 2023, 4:11 PM

#

I told him to use futures earlier before I saw he was using messagign channels, but he seems to have not understood about running off thread

rose trail Jul 9, 2023, 4:11 PM

#

river oracle why are you using future#get

I just tried it, there were private strings before

river oracle Jul 9, 2023, 4:11 PM

#

eternal oxide I told him to use futures earlier before I saw he was using messagign channels,...

also more confusingly he only has one future per the entire command class

rose trail Jul 9, 2023, 4:11 PM

#

but they were always null because

river oracle Jul 9, 2023, 4:12 PM

#

running Future#get is a death sentence for the main thread if you're running a heavy operation you're freezing the entire server for however long it takes the operation to complete

remote swallow Jul 9, 2023, 4:12 PM

#

rose trail but they were always null because

everything has to run when the future is complete, nothing should run before bc it will be null

rose trail Jul 9, 2023, 4:12 PM

#

I'm a noob in multithreading)

eternal oxide Jul 9, 2023, 4:13 PM

#

what you shoudl be doing is sending the PMC requests, then listening for a response and doing whatever you need to do there. Let your command exit without taking any other action after sending the request

sullen canyon Jul 9, 2023, 4:13 PM

#

rose trail I'm a noob in multithreading)

а что собственно ты пишешь?

ivory sleet Jul 9, 2023, 4:13 PM

#

Dw so are many others, but yeah you should learn about callbacks and why they are so useful when you play with concurrency

sullen canyon Jul 9, 2023, 4:13 PM

#

я имею ввиду о чем плагин

rose trail Jul 9, 2023, 4:13 PM

#

sullen canyon а что собственно ты пишешь?

party between servers

rose trail Jul 9, 2023, 4:16 PM

#

eternal oxide what you shoudl be doing is sending the PMC requests, then listening for a res...

I need to record in the database what the join request was so that the player can join later

eternal oxide Jul 9, 2023, 4:16 PM

#

thats fine

rose trail Jul 9, 2023, 4:16 PM

#

so i need to have uuid somehow

eternal oxide Jul 9, 2023, 4:17 PM

#

you do it when you get a reponse, OFF thread

#

you don't wait for a response

#

all your onCommand code should do is make sure the player is allowed to use the command and send your PMC request. Your onCommand should then exit. It's done its job.

rose trail Jul 9, 2023, 4:21 PM

#

eternal oxide all your onCommand code should do is make sure the player is allowed to use the ...

ok, but how to collect it further?

eternal oxide Jul 9, 2023, 4:21 PM

#

in the response

#

your response should contain all the data you need to execute whatever code you want to run.

rose trail Jul 9, 2023, 4:24 PM

#

eternal oxide your response should contain all the data you need to execute whatever code you ...

I finally figured out how to do it, thanks

cobalt thorn Jul 9, 2023, 4:30 PM

#

most basic thing that i can do because math is not my best, im making a sort of economy and im adding buy what you can, and i need a way to sell to a player the max he can so if an item cost 100 and he has 500 in automatic the player will get 5 items and so in this way

young knoll Jul 9, 2023, 4:31 PM

#

Balance / cost

#

Round down

fluid river Jul 9, 2023, 4:34 PM

#

river oracle `Used to refer to the one previously mentioned or implied` or `Used to refer to ...

english = cringe

cobalt thorn Jul 9, 2023, 4:35 PM

#

young knoll Balance / cost

int max = Math.round(UserManager.getTokens(player.getUniqueId()) / config.getLong(path + "cost")); so in this way?

young knoll Jul 9, 2023, 4:36 PM

#

I would use Math.floor

#

To round down

river oracle Jul 9, 2023, 4:37 PM

#

fluid river english = cringe

non gendered languages go brrrrrrrrrrr

shadow owl Jul 9, 2023, 4:45 PM

#

Does anyone know if BiomeProvider is supposed to be extended? Otherwise how do I control the biome generation using a worldcreator? I want to make a whole world one biome

young knoll Jul 9, 2023, 4:53 PM

#

Yeah you can extend it

quaint mantle Jul 9, 2023, 4:57 PM

#

Has anyone ever worked with lettuce (redis)? I need to set my charset to ASCII (I guess) but I can't find how.

For more context: It returns "\u003d" instead of "=" and It completely brokes NPC skins

eternal oxide Jul 9, 2023, 5:11 PM

#

I don;t use redis but unless you misconfigured somewhere it shoudl default to utf8, which is what you need

rough ibex Jul 9, 2023, 5:12 PM

#

I don't see why you would intentionally want your charset to be ASCII

#

it is returning \\u003d or \u003d

quaint mantle Jul 9, 2023, 5:13 PM

#

eternal oxide I don;t use redis but unless you misconfigured somewhere it shoudl default to u...

I dont have any extra configuration regards to this thing, also there is no way (I can see) to change it.

rough ibex Jul 9, 2023, 5:13 PM

#

\u003d and = are the same thing

#

\u003d is just an escape

eternal oxide Jul 9, 2023, 5:13 PM

#

yep, thats unicode, utf8

rough ibex Jul 9, 2023, 5:13 PM

#

technically its also ASCII

quaint mantle Jul 9, 2023, 5:14 PM

#

I know they are same but the player skins are not loaded for some reason and I can't figure out why

eternal oxide Jul 9, 2023, 5:14 PM

#

?paste some code then

undone axleBOT Jul 9, 2023, 5:14 PM

#

https://paste.md-5.net/

quaint mantle Jul 9, 2023, 5:15 PM

#

Oh I'm blind, sorry for the trouble. I forgot to wait some time before sending playerinforemove packet 🤦

crimson tinsel Jul 9, 2023, 5:21 PM

#

Hello! I ran into some problems with trying to make an object of a class outside the package and when i try to use setters it doesnt work. Can somebody tell if has an interest to help thanks!

eternal oxide Jul 9, 2023, 5:22 PM

#

?ask

undone axleBOT Jul 9, 2023, 5:22 PM

#

If you have a question, please just ask it. Don't look for staff or topic experts. Don't ask to ask or ask if people are awake or available. Just ask the question to the channel straight out, and wait patiently for a reply. Make sure you use the right channel regarding the topic of your question. Create a thread in case the channel is already in use!

tender shard Jul 9, 2023, 5:23 PM

#

?notworking too

undone axleBOT Jul 9, 2023, 5:23 PM

#

"Does not working" is a useless statement. Please describe what exactly is not working, what you expect it to do, and what actually happens. If you get any console errors, also ?paste the entire stacktrace.

crimson tinsel Jul 9, 2023, 5:33 PM

#

This is my explosion blockbreakevent class where i tried to initialize the TokensCommand class

#

?paste

undone axleBOT Jul 9, 2023, 5:33 PM

#

https://paste.md-5.net/

crimson tinsel Jul 9, 2023, 5:34 PM

#

https://paste.md-5.net/lunetipoko.java

#

And this is the TokensCommand class

#

https://paste.md-5.net/wozusitegu.java

#

And when i break blocks everything works except that it doesnt add anything to my tokens field

eternal oxide Jul 9, 2023, 5:36 PM

#

@fluid river ^ someone here needs a few lessons

crimson tinsel Jul 9, 2023, 5:36 PM

#

i havent finished my oop lessons yet

glad prawn Jul 9, 2023, 5:37 PM

#

crimson tinsel https://paste.md-5.net/wozusitegu.java

https://www.spigotmc.org/wiki/create-a-simple-command/

Creating a Simple Command | SpigotMC - High Performance Minecraft

The home of Spigot a high performance, no lag customized CraftBukkit Minecraft server API, and BungeeCord, the cloud server proxy.

quaint mantle Jul 9, 2023, 5:38 PM

#

crimson tinsel https://paste.md-5.net/lunetipoko.java

not the pyramind of doom

fluid river Jul 9, 2023, 5:39 PM

#

eternal oxide <@558290529750745098> ^ someone here needs a few lessons

where

#

i see

silver robin Jul 9, 2023, 5:41 PM

#

Is anyone here familiar with maven? I never really liked using it or gradle either because it is always introducing problems before even writing any code but more and more libraries are requiring it so I kind of have no option
Error: ```
Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project CustomBlockDataExample: Fatal error compiling

My pom.xml : <https://paste.md-5.net/akopoyegex.xml> i'm using spigot 1.16.5 hope that's not a problem
Intellij idea doesn't give any red errors in the pom.xml, even tried invalidate caches and restart

fluid river Jul 9, 2023, 5:42 PM

#

crimson tinsel Hello! I ran into some problems with trying to make an object of a class outside...

dm me

tender shard Jul 9, 2023, 5:50 PM

#

silver robin Is anyone here familiar with maven? I never really liked using it or gradle eith...

your maven-shade-plugin is horribly outdated

#

update it to 3.5.0

#

also what's all of this?

orchid gazelle Jul 9, 2023, 5:50 PM

#

@tender shard what gpu do you have

tender shard Jul 9, 2023, 5:51 PM

#

tender shard also what's all of this?

remove the finalName, sourceDirectory, targetPath, and ${basedir} from the <directory>

tender shard Jul 9, 2023, 5:51 PM

#

orchid gazelle <@632994436401594368> what gpu do you have

rtx 2080 super on desktop, m2 max 30 cores on the macbook

orchid gazelle Jul 9, 2023, 5:51 PM

#

What do you think about the RTX 4070? Should I get it?

tender shard Jul 9, 2023, 5:51 PM

#

idk

tender shard Jul 9, 2023, 5:52 PM

#

silver robin Is anyone here familiar with maven? I never really liked using it or gradle eith...

also what's the full error? you only posted one line, please show the complete maven output

orchid gazelle Jul 9, 2023, 5:52 PM

#

It's literally 700€, this is 2 years of saving for me

silver robin Jul 9, 2023, 5:53 PM

#

tender shard also what's the full error? you only posted one line, please show the complete m...

it is one line though
here's the logs where it was downloading everything https://paste.md-5.net/bilunivota.cs

silver robin Jul 9, 2023, 5:53 PM

#

tender shard update it to 3.5.0

also I wish this is possible...

tender shard Jul 9, 2023, 5:54 PM

#

silver robin also I wish this is possible...

now try to compile

#

the CustomBlockData-Example repo compiles just fine btw

tender shard Jul 9, 2023, 5:54 PM

#

silver robin also I wish this is possible...

mvn package

silver robin Jul 9, 2023, 5:54 PM

#

I'm using this option, shouldn't it be the same?

tender shard Jul 9, 2023, 5:54 PM

#

silver robin I'm using this option, shouldn't it be the same?

yep, double click that

unique shuttle Jul 9, 2023, 5:55 PM

#

Is this or could it be malicious code? It's from a plugin that was sold to me.
https://paste.md-5.net/qosimohido.java

tender shard Jul 9, 2023, 5:56 PM

#

unique shuttle Is this or could it be malicious code? It's from a plugin that was sold to me. h...

yes

silver robin Jul 9, 2023, 5:56 PM

#

tender shard yep, double click that

one sec, I did invalidate caches and restart intellij (so the 3.5.0 red goes away)

rose trail Jul 9, 2023, 5:56 PM

#

how better to do operations with the database, asynchronously? And how to combine it with the main thread of bukkit?

tender shard Jul 9, 2023, 5:56 PM

#

silver robin one sec, I did invalidate caches and restart intellij (so the 3.5.0 red goes awa...

you don't have to do that, just run mvn package and maven will download version 3.5.0

silver robin Jul 9, 2023, 5:57 PM

#

tender shard the CustomBlockData-Example repo compiles just fine btw

by the way, the finalName, sourceDirectory, targetPath, and ${basedir} were from the example repo you managed to clone and compile

silver robin Jul 9, 2023, 5:57 PM

#

tender shard you don't have to do that, just run `mvn package` and maven will download versio...

there (double clicked the package)

#

~~wait nvm, let me try something~~ okay nvm I accidentally forgot to change shadedPattern in pom but it still errors

tender shard Jul 9, 2023, 5:58 PM

#

click the uppermost entry in the list on the left, then you can copy/paste the full log

#

click this, then copy/paste the full log

silver robin Jul 9, 2023, 5:59 PM

#

here https://paste.md-5.net/puxopewani.sql

unique shuttle Jul 9, 2023, 5:59 PM

#

tender shard yes

must be a virus?

#

💀

tender shard Jul 9, 2023, 6:00 PM

#

silver robin here https://paste.md-5.net/puxopewani.sql

Run "mvn clean package -X" then send the log again pls

silver robin Jul 9, 2023, 6:03 PM

#

tender shard Run "mvn clean package -X" then send the log again pls

it's not letting me upload it 😭 can I send as txt file?

tender shard Jul 9, 2023, 6:03 PM

#

You set the java version to 16.0.1

alpine cairn Jul 9, 2023, 6:03 PM

#

When I write "p.sendMessage()" it gets a strikethrough and hovering over it reads "Obsolete API is used." Can anyone tell me what the issue is or what I should use instead?

tender shard Jul 9, 2023, 6:03 PM

#

tender shard You set the java version to 16.0.1

It must be 16

#

Not 16.0.1

tender shard Jul 9, 2023, 6:03 PM

#

alpine cairn When I write "p.sendMessage()" it gets a strikethrough and hovering over it read...

You are using paper API

alpine cairn Jul 9, 2023, 6:04 PM

#

tender shard You are using paper API

yes

silver robin Jul 9, 2023, 6:04 PM

#

tender shard It must be 16

I didn't set it
is it in pom?

<plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <version>3.8.0</version>
                <configuration>
                    <source>${java.version}</source>
                    <target>${java.version}</target>
                </configuration>
            </plugin>``` (sorry for terrible indentation)

tender shard Jul 9, 2023, 6:04 PM

#

alpine cairn yes

Thats the issue.

alpine cairn Jul 9, 2023, 6:04 PM

#

Uhhh

tender shard Jul 9, 2023, 6:04 PM

#

silver robin I didn't set it is it in pom? ```xml <plugin> <groupId>org.apach...

In your properties

young knoll Jul 9, 2023, 6:04 PM

#

Paper deprecates all the string thing

silver robin Jul 9, 2023, 6:04 PM

#

tender shard In your properties

this? ```xml
<properties>
<maven.compiler.source>16</maven.compiler.source>
<maven.compiler.target>16</maven.compiler.target>
</properties>

alpine cairn Jul 9, 2023, 6:04 PM

#

tender shard Thats the issue.

What should I use instead?

tender shard Jul 9, 2023, 6:05 PM

#

silver robin I didn't set it is it in pom? ```xml <plugin> <groupId>org.apach...

change the {java.version} to just 16

<plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-compiler-plugin</artifactId>
                <version>3.8.0</version>
                <configuration>
                    <source>16</source>
                    <target>16</target>
                </configuration>
            </plugin>

tender shard Jul 9, 2023, 6:05 PM

#

alpine cairn What should I use instead?

spigot-api

#

groupid org.spigotmc
artifactid spigot-api
version 1.20.1-R0.1-SNAPSHOT

alpine cairn Jul 9, 2023, 6:06 PM

#

Thank you

silver robin Jul 9, 2023, 6:08 PM

#

tender shard change the {java.version} to just 16 ```xml <plugin> <groupId>or...

well this was awkward but it worked, thanks ❤️
may I ask why what was with the finalName, sourceDirectory and targetPath?
also I'm not sure why but some weird file is put into my jar https://www.decompiler.com/jar/9fd54de090154fe0bd2499f6af983d64/CustomBlockDataExample.jar/dev/ribica/customblockdataexampleplugin/.java

crimson tinsel Jul 9, 2023, 6:08 PM

#

Are there something like minecraft plugin development courses where i can learn more?

tender shard Jul 9, 2023, 6:09 PM

#

silver robin well this was awkward but it worked, thanks ❤️ may I ask why what was with the ...

Well those were all the default values, its not needed to specify them. Your issue was that you used the old maven shade version which didnt support java 16, and then didnt run „clean“ after updating it - you also didnt specify java.version in your properties, so it used the java version environment variable, which was 16.0.1, which is not a valid option for maven.compiler.target and source

silver robin Jul 9, 2023, 6:11 PM

#

eh, didn't think maven would be so tricky in intellij

tender shard Jul 9, 2023, 6:12 PM

#

you can either use {java.version} and then declare that in your properties:

<properties>
  <java.version>16</java.version>

or just directly use "16" or whatever in the maven-compiler-plugin configuraiton

silver robin Jul 9, 2023, 6:12 PM

#

Hard-coding it should be fine I assume

tender shard Jul 9, 2023, 6:13 PM

#

in the CustomBlockData-Example pom, I used ${java.version} but I also declared it in the properties:

tender shard Jul 9, 2023, 6:13 PM

#

silver robin Hard-coding it should be fine I assume

yeah but you can also delete the <configuration> section as you already set it in properties through maven.compiler.target and source, so one of those is redundant - you can either remove the compiler <configuration> section, or remove the stuff from the <properties>

#

doesn't really matter which one you use

#

btw if you wanna change the output directory or final name, you should do that in the maven-jar-plugin's <configuration> and not directly inside <build>: https://blog.jeff-media.com/how-to-make-maven-automatically-put-your-plugins-jar-into-your-test-servers-plugins-folder/

JEFF Media Developer Blog

mfnalex

How to make maven automatically put your plugin’s .jar into your te...

shadow owl Jul 9, 2023, 6:17 PM

#

Does anyone know if there's a way to get the highest block at a point excluding certain materials (in this case, barrier blocks)?

#

Do I need to just manually search

uncut needle Jul 9, 2023, 6:17 PM

#

How to type || on uk keyboard

#

I have to google the symbol and copy it everytime I want to use it

shadow owl Jul 9, 2023, 6:19 PM

#

uncut needle I have to google the symbol and copy it everytime I want to use it

https://www.quora.com/Where-is-the-pipe-key-on-the-UK-keyboard#:~:text=Assuming you mean a UK,shifted character on that key. ?

tender shard Jul 9, 2023, 6:19 PM

#

shadow owl Do I need to just manually search

yes. I'd just write a tiny method that takes a Predicate<Material> or sth so you can reuse it later

    /**
     * Returns the highest block at the given x/z coordinates, ignoring the given materials
     */
    public static Block getHighestBlockAt(World world, int x, int z, Predicate<Material> ignoredMaterials) {
        for(int y = world.getHighestBlockYAt(x, z); y >= world.getMinHeight(); y--) {
            Block block = world.getBlockAt(x, y, z);
            if(!ignoredMaterials.test(block.getType())) {
                return block;
            }
        }
        return null;
    }

shadow owl Jul 9, 2023, 6:20 PM

#

tender shard yes. I'd just write a tiny method that takes a Predicate<Material> or sth so you...

Ok, thank you!

tender shard Jul 9, 2023, 6:20 PM

#

uncut needle How to type || on uk keyboard

that's 2 pipe symbols. the pipe symbol is right to the left shift key, probably you need to press Ctrl+Alt plus that key

#

or maybe shift + that key, idk

eternal oxide Jul 9, 2023, 6:21 PM

#

uk keyboard it should be right next to the left shift key, press shift + \

#

||

uncut needle Jul 9, 2023, 6:22 PM

#

~

tender shard Jul 9, 2023, 6:22 PM

#

what the heck is this

uncut needle Jul 9, 2023, 6:22 PM

#

its a gun

tender shard Jul 9, 2023, 6:22 PM

#

ah sure

#

the gun key

eternal oxide Jul 9, 2023, 6:23 PM

#

¬

uncut needle Jul 9, 2023, 6:23 PM

#

- ¬

#

- - - - ¬

uncut needle Jul 9, 2023, 6:23 PM

#

eternal oxide uk keyboard it should be right next to the left shift key, press shift + \\

~

#

when i press this

tender shard Jul 9, 2023, 6:23 PM

#

show a picture of your keyboard

uncut needle Jul 9, 2023, 6:24 PM

#

my keyboard is us layout

#

but I like uk layout more

#

on windows

#

only diffrence is dolllar sign

eternal oxide Jul 9, 2023, 6:25 PM

#

a few keys are different

#

but minor

tender shard Jul 9, 2023, 6:25 PM

#

you're gonna have a bad time if you use a different layout in windows than your keyboard is made for

uncut needle Jul 9, 2023, 6:25 PM

#

I have been doing it for 2 years

#

ez

tender shard Jul 9, 2023, 6:25 PM

#

yet you can't type a |

#

after 2 years

#

lol

uncut needle Jul 9, 2023, 6:25 PM

#

that is the only problem

eternal oxide Jul 9, 2023, 6:26 PM

#

its literally shift + the key between shift and Z

tender shard Jul 9, 2023, 6:26 PM

#

US keyboards don't have a key between Z and shift

#

at least not the one shown on wikipedia

eternal oxide Jul 9, 2023, 6:26 PM

#

uk do 🙂

tender shard Jul 9, 2023, 6:26 PM

#

yeah but they got a US keyboard

uncut needle Jul 9, 2023, 6:26 PM

#

yes

eternal oxide Jul 9, 2023, 6:26 PM

#

oh I saw him ask how to do it on uk keyboard

uncut needle Jul 9, 2023, 6:27 PM

#

my windows layout is uk

tender shard Jul 9, 2023, 6:27 PM

#

eternal oxide oh I saw him ask how to do it on uk keyboard

yeah that also confused me. They set it to UK in windows but it's actually a US one lol

eternal oxide Jul 9, 2023, 6:27 PM

#

just add a US one too. you can switch in windows taskbar

tender shard Jul 9, 2023, 6:27 PM

#

or with Win-Space

#

I always accidentally press that

silver robin Jul 9, 2023, 6:28 PM

#

tender shard yeah but you can also delete the <configuration> section as you already set it i...

should I then just stick to using plugin <configuration> instead of the properties maven.compiler.target ?

tender shard Jul 9, 2023, 6:28 PM

#

silver robin should I then just stick to using plugin <configuration> instead of the properti...

do it however you like. it's literally the same

silver robin Jul 9, 2023, 6:28 PM

#

tender shard or with Win-Space

unrelated but wasn't it alt+shift?

tender shard Jul 9, 2023, 6:28 PM

#

using the <configuration> is probably more straightforward

eternal oxide Jul 9, 2023, 6:28 PM

#

pretty sure they depricated it in properties

tender shard Jul 9, 2023, 6:29 PM

#

silver robin unrelated but wasn't it alt+shift?

it's definitely Win+SPace for me, I just tried it

eternal oxide Jul 9, 2023, 6:29 PM

#

best to do it in plugin configuration

tender shard Jul 9, 2023, 6:29 PM

#

eternal oxide pretty sure they depricated it in properties

both is fine https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html

eternal oxide Jul 9, 2023, 6:30 PM

#

I remember it stopped workign at some point when just in properties

tender shard Jul 9, 2023, 6:30 PM

#

it's also still mentioned in the compile mojo docs

remote swallow Jul 9, 2023, 6:31 PM

#

i think TAB supports 1.8

#

dont remember tho

tender shard Jul 9, 2023, 6:31 PM

#

what do you wanna do?

#

spigot got API for per player header and footer, and the names can be changed with the display name

silver robin Jul 9, 2023, 6:34 PM

#

tender shard Well those were all the default values, its not needed to specify them. Your iss...

can we please return to this?
the last problem I'm facing is that plugin.yml isn't getting added into the jar
do I have to add something in pom?
I looked at this guide https://www.spigotmc.org/wiki/creating-a-plugin-with-maven-using-intellij-idea/#creating-plugin-yml and I created it in the exact same way

tender shard Jul 9, 2023, 6:35 PM

#

silver robin can we please return to this? the last problem I'm facing is that plugin.yml isn...

show a screenshot of your directory structure in IntelliJ pls

remote swallow Jul 9, 2023, 6:35 PM

#

where is the plugin.yml

silver robin Jul 9, 2023, 6:35 PM

#

tender shard Jul 9, 2023, 6:35 PM

#

looks good. show pom.xml again pls

silver robin Jul 9, 2023, 6:35 PM

#

https://paste.md-5.net/moyilugagi.xml

tender shard Jul 9, 2023, 6:36 PM

#

remove the whole includes part

unique shuttle Jul 9, 2023, 6:36 PM

#

tender shard yes

If I give you the plugin, could you see if it is malware?

tender shard Jul 9, 2023, 6:36 PM

#

tender shard remove the whole includes part

you don't need a <includes> set, you wanna include everything from the resources folder
if you wanna use an includes set, then you gotta specify the full path, or use the ant style:
Either <include>src/main/resources/plugin.yml
or
<include>**/plugin.yml

#

TL;DR: just do it like this

    <build>
        <resources>
            <resource>
                <filtering>true</filtering>
                <directory>src/main/resources</directory>
            </resource>
        </resources>

#

also note that there's no starting / in the directory

#

it's a relative path

remote swallow Jul 9, 2023, 6:38 PM

#

silver robin

why have you added a purpur jar manually

silver robin Jul 9, 2023, 6:38 PM

#

~~removed the includes, ran 'package', new jar still doesn't have plugin.yml (when I view it with 7zip)~~ okay nevermind the forwardslash

tender shard Jul 9, 2023, 6:38 PM

#

unique shuttle If I give you the plugin, could you see if it is malware?

no. why don't you ask the dude who sold it to you what that is?

#

anyway it's highly suspicous and I'd demand my money back lol

silver robin Jul 9, 2023, 6:40 PM

#

remote swallow why have you added a purpur jar manually

because purpur officially doesn't support "older versions" and I'm thinking they removed it from their maven repo (atleast mvn couldn't fetch it, saying it was not found) but I doubt i'll need it)

remote swallow Jul 9, 2023, 6:40 PM

#

the way you didnt it wont work anyway

#

you added paperclip jar, not an actual purpur server jar

unique shuttle Jul 9, 2023, 6:40 PM

#

I want to make sure before doing it since in a few hours I have an event that I cannot cancel 😬

silver robin Jul 9, 2023, 6:40 PM

#

tender shard TL;DR: just do it like this ```xml <build> <resources> <...

dang, it worked this was weird though
once again sorry for being terribly lost in this stuff

silver robin Jul 9, 2023, 6:41 PM

#

remote swallow you added paperclip jar, not an actual purpur server jar

what do you mean?

tender shard Jul 9, 2023, 6:41 PM

#

silver robin dang, it worked this was weird though once again sorry for being terribly lost i...

np! I also found maven very confusing at first, especially since most tutorials do very bad stuff in their pom.xmls

remote swallow Jul 9, 2023, 6:41 PM

#

paper (and its forks) distribute something call paperclip jars, they dont include any code thats on any repo, just instructions for the end server to download the patches and apply a binary patch

remote swallow Jul 9, 2023, 6:42 PM

#

silver robin because purpur officially doesn't support "older versions" and I'm thinking they...

i found it all https://repo.purpurmc.org/#/snapshots/org/purpurmc/purpur/purpur-api

PurpurMC Repository

Your Minecraft, your way

#

maven can pull it

eternal oxide Jul 9, 2023, 6:42 PM

#

unique shuttle Is this or could it be malicious code? It's from a plugin that was sold to me. h...

send me the jar

silver robin Jul 9, 2023, 6:42 PM

#

tender shard np! I also found maven very confusing at first, especially since most tutorials ...

may I ask what is it that makes maven make two jars (they are identical checksums)

orchid gazelle Jul 9, 2023, 6:43 PM

#

shaded includes Libraries and Dependencies into the jar

#

If you do not have any Dependencies, it is the same

rough drift Jul 9, 2023, 6:43 PM

#

Extending character limit on a scoreboard with teams.

tender shard Jul 9, 2023, 6:43 PM

#

silver robin may I ask what is it that makes maven make two jars (they are identical checksum...

It doesnt have any purpose tbh

orchid gazelle Jul 9, 2023, 6:44 PM

#

Isn'r it there to include deps?

tender shard Jul 9, 2023, 6:44 PM

#

The shade plugin copies the -shaded .jar to the normal ind

remote swallow Jul 9, 2023, 6:44 PM

#

orchid gazelle Isn'r it there to include deps?

the normal jar also includes it

orchid gazelle Jul 9, 2023, 6:44 PM

#

Huh? Last time I used maven it did not

silver robin Jul 9, 2023, 6:44 PM

#

remote swallow i found it all https://repo.purpurmc.org/#/snapshots/org/purpurmc/purpur/purpur-...

bruh... I used this https://github.com/PurpurMC/Purpur/tree/ver/1.16.5#dependency-information

orchid gazelle Jul 9, 2023, 6:44 PM

#

And had a second jar including everything

tender shard Jul 9, 2023, 6:44 PM

#

orchid gazelle Isn'r it there to include deps?

The YourPlugin-1.0.jar and YourPlugin-1.0-shaded.jar are the same. The original-YourPlugin-1.0.jar is the unshaded one

remote swallow Jul 9, 2023, 6:44 PM

#

yeah, they changed maven info

orchid gazelle Jul 9, 2023, 6:44 PM

#

Ohh sorry for the missinformation then

shadow night Jul 9, 2023, 6:45 PM

#

What is shading for again?

remote swallow Jul 9, 2023, 6:45 PM

#

<dependency>
  <groupId>org.purpurmc.purpur</groupId>
  <artifactId>purpur-api</artifactId>
  <version>1.16.5-R0.1-SNAPSHOT</version>
  <scope>provided</scope>
</dependency>

<repository>
  <id>purpurmc-snapshots</id>
  <name>PurpurMC Repository</name>
  <url>https://repo.purpurmc.org/snapshots</url>
</repository>

tender shard Jul 9, 2023, 6:45 PM

#

orchid gazelle Ohh sorry for the missinformation then

I think the reason is that you can specify a different identifier for the shaded one but it defaults to replacing the normal one

kind hatch Jul 9, 2023, 6:45 PM

#

shadow night What is shading for again?

Including dependencies in your plugin. I.E copying required classes from other libraries.

tender shard Jul 9, 2023, 6:45 PM

#

shadow night What is shading for again?

Include libraries and stuff

shadow night Jul 9, 2023, 6:45 PM

#

Ah right

silver robin Jul 9, 2023, 6:46 PM

#

remote swallow the normal jar also includes it

aren't deps (dependencies) things like spigot jar? it shouldn't get into the compiled jar though

tender shard Jul 9, 2023, 6:46 PM

#

Maven shade is like gradle‘s shadow

orchid gazelle Jul 9, 2023, 6:46 PM

#

tender shard Include libraries and stuff

Well then im kind of correct?

shadow night Jul 9, 2023, 6:46 PM

#

silver robin aren't deps (dependencies) things like spigot jar? it shouldn't get into the com...

Some shouldn't, some should

tender shard Jul 9, 2023, 6:46 PM

#

silver robin aren't deps (dependencies) things like spigot jar? it shouldn't get into the com...

Spigot is a runtime dependency - your plugin expects it to already be there

#

CustomBlockData is a compile dependency - you gotta ship it yoursef

silver robin Jul 9, 2023, 6:46 PM

#

remote swallow ```xml <dependency> <groupId>org.purpurmc.purpur</groupId> <artifactId>purpu...

this is exactly what happened last time (copied both repository and dependency)

tender shard Jul 9, 2023, 6:47 PM

#

silver robin this is exactly what happened last time (copied both repository and dependency)

Run package

undone axleBOT Jul 9, 2023, 6:47 PM

#

https://cdn.discordapp.com/attachments/864180468680360027/944415049462714469/whereami.mp4

▶ Play video

remote swallow Jul 9, 2023, 6:47 PM

#

reload maven

silver robin Jul 9, 2023, 6:47 PM

#

tender shard Spigot is a runtime dependency - your plugin expects it to already be there

is that why one puts <scope>provided</scope> in there?

tender shard Jul 9, 2023, 6:47 PM

#

silver robin this is exactly what happened last time (copied both repository and dependency)

https://blog.jeff-media.com/why-intellij-complains-about-your-pom-xml-file/

JEFF Media Developer Blog

mfnalex

Why IntelliJ complains about your pom.xml file

remote swallow Jul 9, 2023, 6:47 PM

#

silver robin is that why one puts <scope>provided</scope> in there?

otherwise you shade it

orchid gazelle Jul 9, 2023, 6:47 PM

#

silver robin is that why one puts <scope>provided</scope> in there?

Yes

tender shard Jul 9, 2023, 6:48 PM

#

silver robin is that why one puts <scope>provided</scope> in there?

Yes. Spigot is already running (you dont have to include it), so you set it to „provided“

#

Its explained here (second headline) @silver robin https://blog.jeff-media.com/common-maven-questions/

JEFF Media Developer Blog

mfnalex

Three Common Maven Questions

silver robin Jul 9, 2023, 6:49 PM

#

remote swallow ```xml <dependency> <groupId>org.purpurmc.purpur</groupId> <artifactId>purpu...

okay I copied this before you edited and added the scope provided thing and now it included the whole purpur jar into my plugin but thanks

remote swallow Jul 9, 2023, 6:49 PM

#

add the scope provided i missed

#

i forgot that reposilite doesnt care about stuff like that

#

and then clean build

silver robin Jul 9, 2023, 6:51 PM

#

I opened a ton of tabs already just from discussions here :/
now all I can hope that my pom won't break sometime in the future

#

Thanks again every one of you 😃

tender shard Jul 9, 2023, 6:52 PM

#

if it breaks, just ask here again lol

silver robin Jul 9, 2023, 6:54 PM

#

i was hesitant at first to use spigot discord server for such things but again if I were to ask general java people I thought they'd get as confused as me

sharp bough Jul 9, 2023, 7:11 PM

#

anyone knows if this is normal? 60% on votifier? running 1.16.5 arclight

remote swallow Jul 9, 2023, 7:11 PM

#

is there any reason you arent using nuvotifier

fluid river Jul 9, 2023, 7:12 PM

#

?learnjava

undone axleBOT Jul 9, 2023, 7:12 PM

#

Here are some links to get you started on learning Java:

The last one is the only official one, however some of those concepts assume that you already know a bit about programming.

fluid river Jul 9, 2023, 7:12 PM

#

not for you guys

remote swallow Jul 9, 2023, 7:12 PM

#

why not

sharp bough Jul 9, 2023, 7:12 PM

#

remote swallow is there any reason you arent using nuvotifier

no, its a server i joined as a dev, having some issues

#

made a profile and found that

#

im honestly not sure if thats just the normal ussage of votifier

#

but i dont think so?

#

feels like too much

remote swallow Jul 9, 2023, 7:13 PM

#

idk how bad it was, check source code of both and check if nuvotifier adds something to counter it

ornate patio Jul 9, 2023, 7:16 PM

#

I'm creating a custom UI using inventoryframework

#

and for some reason the library places some custom nbt data on items that i place in

#

making it non-stackable

#

how can I delete this nbt tag?

sharp bough Jul 9, 2023, 7:17 PM

#

ornate patio and for some reason the library places some custom nbt data on items that i plac...

public class NBTIManager {
    public static ItemStack cleanItemOfGuiTag(ItemStack item) {
        try {
            NBTItem nbtItem = new NBTItem(item);
            nbtItem.removeKey("PublicBukkitValues");
            return nbtItem.getItem();

        } catch (Exception e) {
            return item;
        }
    }
}

#

is what i use

#

i already asked the dev

ornate patio Jul 9, 2023, 7:17 PM

#

hmm okay

carmine mica Jul 9, 2023, 7:17 PM

#

wow that looks like not a good idea

remote swallow Jul 9, 2023, 7:17 PM

#

that removes all pdc, be careful with that one

ornate patio Jul 9, 2023, 7:18 PM

#

i thought there would be a better way

silver robin Jul 9, 2023, 7:18 PM

#

tender shard Its explained here (second headline) <@336872196771151872> https://blog.jeff-med...

By the way, you're the author of CustomBlockData , right? Could I ask a question related to it in DMs?

carmine mica Jul 9, 2023, 7:18 PM

#

just wipe all plugin's custom info on items = bad time

remote swallow Jul 9, 2023, 7:18 PM

#

carmine mica wow that looks like not a good idea

i call for a ban with that status message

sharp bough Jul 9, 2023, 7:18 PM

#

remote swallow that removes all pdc, be careful with that one

hes right, be carefull

tender shard Jul 9, 2023, 7:18 PM

#

silver robin By the way, you're the author of CustomBlockData , right? Could I ask a question...

yes I am, and yes

ornate patio Jul 9, 2023, 7:18 PM

#

is that a pdc though?

carmine mica Jul 9, 2023, 7:18 PM

#

yes, its all the PDC

ornate patio Jul 9, 2023, 7:18 PM

#

because if so can't i just use the pdc api

carmine mica Jul 9, 2023, 7:18 PM

#

yes, you don't need anything extra

ornate patio Jul 9, 2023, 7:18 PM

#

to delete it

#

ok

#

yeah i'll do that then

carmine mica Jul 9, 2023, 7:19 PM

#

just create a namespaced key that matches the key in the nbt you have, so new NamespacedKey("classmmo", "if-uuid");

remote swallow Jul 9, 2023, 7:19 PM

#

(NamespacedKey.fromString("classmmo:if-uuid"))

tender shard Jul 9, 2023, 7:19 PM

#

better use NamespacedKey.fromString

carmine mica Jul 9, 2023, 7:20 PM

#

why is that better?

tender shard Jul 9, 2023, 7:20 PM

#

#

because the constructor is deprecated and tells you to NEVER use it, with 2(!!) exclamation marks

carmine mica Jul 9, 2023, 7:20 PM

#

oh yeah, forgot spigot still has that deprecated for whatever reason

#

don't really understand why

remote swallow Jul 9, 2023, 7:21 PM

#

tender shard because the constructor is deprecated and tells you to NEVER use it, with 2(!!) ...

TWO?

#

better stay the hell away from it

tender shard Jul 9, 2023, 7:21 PM

#

yeah lol

carmine mica Jul 9, 2023, 7:21 PM

#

fromString is nullable which is annoying. so new is better for this imo (assuming it wasn't deprecated), cause that's even more annoying from a static analyzer perspective

ornate patio Jul 9, 2023, 7:21 PM

#

why would i fromstring tho

#

cant i just use the plugin instance

carmine mica Jul 9, 2023, 7:22 PM

#

well is the plugin name classmmo? if they created a custom key

tender shard Jul 9, 2023, 7:22 PM

#

is "classmmo" your plugin?

ornate patio Jul 9, 2023, 7:22 PM

#

ornate patio

also what pdc type is this

#

integer array?

ornate patio Jul 9, 2023, 7:22 PM

#

tender shard is "classmmo" your plugin?

yes

carmine mica Jul 9, 2023, 7:22 PM

#

byte array

tender shard Jul 9, 2023, 7:22 PM

#

byte array

ornate patio Jul 9, 2023, 7:22 PM

#

oh

#

i should use the plugin instance then huh

remote swallow Jul 9, 2023, 7:23 PM

#

im just looking at a profiler of my dev server and i feel like this probably isnt good

#

i just managed to crash it trying to profile my plugin

#

thats great

worldly ingot Jul 9, 2023, 7:27 PM

#

I mean that's just how memory works in Java

remote swallow Jul 9, 2023, 7:27 PM

#

choco can we ban mm

#

look at his status

worthy moat Jul 9, 2023, 7:27 PM

#

How can I read in Spigot 1.8.8 what color a wool is if I only have the ItemStack?

young knoll Jul 9, 2023, 7:31 PM

#

It’s the damage value on the stack

#

Think it’s getData or something

worldly ingot Jul 9, 2023, 7:33 PM

#

Wool MaterialData existed back then

#

but please, for the love of God, write against modern API

young knoll Jul 9, 2023, 7:35 PM

#

Oh yeah you guys abstracted the magic values

#

And then they got yeeted right after

worthy moat Jul 9, 2023, 7:35 PM

#

young knoll It’s the damage value on the stack

ah thx

ornate patio Jul 9, 2023, 7:50 PM

#

I want to make a command that'll open up an Anvil GUI that has custom recipes

#

Right now I'm doing this with InventoryFramework but it's really scuffed because you're not meant to be placing items into the GUI

#

is there any alternative i can do

ancient glade Jul 9, 2023, 7:51 PM

#

Hey, I have been struggling with an issue for a while and found no help or useful information online regarding the issue.

Whenever I try to make a copy of a sqlite file from the resource path to the plugins datafolder it gets corrupted(Only sqlite files no other file formats, it corrupts the encoding), no matter what copy method I try no matter what encoding I set it to it always gets corrupted.

Now for the funny part. It only happens when loading it as a plugin, the code works fine without issues no corruption when just running it as java code. It also does not matter if I create the file on plugin startup or any other time during the servers lifetime. it always gets corrupted. Did anyone run into similar issues before?

eternal oxide Jul 9, 2023, 7:57 PM

#

how are you copying it?

ancient glade Jul 9, 2023, 7:58 PM

#

Currently using the nio Files.copy function, but I also tried manual binary copying and other methods I could find. Did not change anything, always worked on normal java and failed as a plugin

eternal oxide Jul 9, 2023, 7:58 PM

#

nm, when packaging (maven) you need to turn filtering off to package compressed files.

tender shard Jul 9, 2023, 7:59 PM

#

ancient glade Currently using the nio Files.copy function, but I also tried manual binary copy...

maybe the file's already broken inside your .jar

#

is it corrupted when you extract it with winrar etc?

eternal oxide Jul 9, 2023, 7:59 PM

#

it is, he filtered

ancient glade Jul 9, 2023, 8:00 PM

#

oh my god... you are a lifesaver, I tested everything under the sun but did not even think about filtering

carmine nacelle Jul 9, 2023, 8:07 PM

#

Anyone know why when this is only despawning the entity for one player online?

    public void despawnHologram(Player player, Hologram hologram) throws InvocationTargetException {
        List<Integer> holoIDs = hologram.getHoloIDs();

        for (Integer holoID : holoIDs) {
            PacketContainer metadata = new PacketContainer(PacketType.Play.Server.ENTITY_DESTROY);
            metadata.getModifier().write(0, new IntArrayList(new int[]{holoID}));
            ProtocolLibrary.getProtocolManager().sendServerPacket(player, metadata);
        }
    }

I'm sending the packet to all players, but it only actually deletes the hologram for one player

#

https://i.imgur.com/uHzVLwe.png

Imgur

#

image illustration

ornate patio Jul 9, 2023, 8:08 PM

#

can i create custom smithing table recipes

worthy moat Jul 9, 2023, 8:09 PM

#

How can I enchant my wool for example in 1.8?

quaint mantle Jul 9, 2023, 8:10 PM

#

worthy moat How can I enchant my wool for example in 1.8?

Enchant it with unbreakable 1

#

Hide enchants with hideflags

worthy moat Jul 9, 2023, 8:10 PM

#

And how do I enchant?

quaint mantle Jul 9, 2023, 8:10 PM

#

ItemMeta

worthy moat Jul 9, 2023, 8:10 PM

#

ah ok thx

quaint mantle Jul 9, 2023, 8:10 PM

#

I think ItemStack still allows doing enchantment operations

#

Let me ensure

#

Yeah, ItemStack itself can do it 👍🏻

#

No need to access the ItemMeta

#

But you’ll need the ItemMeta for the hideflags

cinder abyss Jul 9, 2023, 8:13 PM

#

Hello, I've got this error when reloading maven : org.spigotmc:spigot-api:jar:1.20.1-R0.1-20230709.090828-26 failed to transfer from https://hub.spigotmc.org/nexus/content/repositories/snapshots/ during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of spigot-repo has elapsed or updates are forced. Original error: Could not transfer artifact org.spigotmc:spigot-api:jar:1.20.1-R0.1-20230709.090828-26 from/to spigot-repo (https://hub.spigotmc.org/nexus/content/repositories/snapshots/): GET request of: org/spigotmc/spigot-api/1.20.1-R0.1-SNAPSHOT/spigot-api-1.20.1-R0.1-20230709.090828-26.jar from spigot-repo failedIt's perfectly working with 1.19.4, but not with 1.20.1

#

(working with 1.20 too)

rose trail Jul 9, 2023, 8:14 PM

#

cinder abyss Hello, I've got this error when reloading maven :``` org.spigotmc:spigot-api:jar...

mvn clean, mvn install

#

it just happened to me

cinder abyss Jul 9, 2023, 8:15 PM

#

LUL thanks !

rough drift Jul 9, 2023, 8:15 PM

#

When someone can, I'd appreciate some help in #1127671319434109078

tender shard Jul 9, 2023, 8:18 PM

#

cinder abyss Hello, I've got this error when reloading maven :``` org.spigotmc:spigot-api:jar...

mvn clean package -U

#

-U updates snapshots

cinder abyss Jul 9, 2023, 8:18 PM

#

tender shard mvn clean package -U

thanks 😄

ornate patio Jul 9, 2023, 8:20 PM

#

Can I create custom smithing table recipes

#

And could I also create dynamic recipes, like a callback function that checks the ingredients and returns a new item

young knoll Jul 9, 2023, 8:21 PM

#

Sure

tender shard Jul 9, 2023, 8:25 PM

#

ornate patio Can I create custom smithing table recipes

ofc

tender shard Jul 9, 2023, 8:25 PM

#

ornate patio And could I also create dynamic recipes, like a callback function that checks th...

for that you'd have to manually listen to InventoryClickEvent

#

normal (registered) recipes are "static"

young knoll Jul 9, 2023, 8:26 PM

#

There’s also the PrepareItemSmithingEvent

tender shard Jul 9, 2023, 8:28 PM

#

oh yeah right. but it's PrepareSmithingEvent*

grim ice Jul 9, 2023, 8:30 PM

#

i can recognize everyone here mostly

#

cool thing, nobody really disappeared since 2022

rough drift Jul 9, 2023, 8:30 PM

#

can you remove entries from a team while iterating on them?

#

I don't know if it returns a clone or not

#

and don't ?tas me

#

It's a clone

tender shard Jul 9, 2023, 8:33 PM

#

grim ice cool thing, nobody really disappeared since 2022

except the people who got banned lol

grim ice Jul 9, 2023, 8:34 PM

#

rough drift It's a clone

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/src/main/java/org/bukkit/craftbukkit/scoreboard/CraftTeam.java#6-8,14,16-17,19,21,28,35,93,100,107,114,121,128,135,296,308-309

quiet ice Jul 9, 2023, 8:34 PM

#

Yeah I also recognise most of you. But it would be strange if I wasn't able to

grim ice Jul 9, 2023, 8:34 PM

#

found this

#

maybe it can help

rose trail Jul 9, 2023, 8:34 PM

#

?paste

undone axleBOT Jul 9, 2023, 8:34 PM

#

https://paste.md-5.net/

grim ice Jul 9, 2023, 8:36 PM

#

quiet ice Yeah I also recognise most of you. But it would be strange if I wasn't able to

still that eclipse pfp

#

amazing

rose trail Jul 9, 2023, 8:37 PM

#

Can you tell me what my mistake is? The command /party invite executes without errors: https://paste.md-5.net/ebotinusen.java

rough drift Jul 9, 2023, 8:37 PM

#

quiet ice Yeah I also recognise most of you. But it would be strange if I wasn't able to

fr

quiet ice Jul 9, 2023, 8:37 PM

#

grim ice still that eclipse pfp

I used to have the ukranian recaf avatar for a while

grim ice Jul 9, 2023, 8:37 PM

#

yeah

#

its nostalgic seeing this chat

#

ive learnt csharp while i was gone from discord

#

and some dart

ornate patio Jul 9, 2023, 8:40 PM

#

young knoll There’s also the PrepareItemSmithingEvent

ill look into it thx

tender shard Jul 9, 2023, 8:41 PM

#

rose trail Can you tell me what my mistake is? The command /party invite executes without e...

what kinda weird command framework is that? why does onCommand return a Command? o0

rose trail Jul 9, 2023, 8:41 PM

#

tender shard what kinda weird command framework is that? why does onCommand return a Command?...

CommandAPICommand

quiet ice Jul 9, 2023, 8:42 PM

#

Anyways. I require some help from the spigot hivemind:
I have an array of numbers (integers) (called the test array) that is freely resizeable. At any time, any number may only present within this array once.
Upon invocation of a method I have control over, exactly one number is added or removed from that array.
Then I also have multiple arrays of numbers (the witness arrays). These arrays are relatively constant and will rarely change (and if they do the aforementioned test array is empty). I have control over the method that would change these witness arrays.

The root question here is what data structure or algorithm would return me the witness arrays that contain the test array fully - though order of elements does not matter. Furthermore, the test array may contain more values than the witness array.

noble crown Jul 9, 2023, 8:42 PM

#

rose trail CommandAPICommand

I don't think that's how you use CommandAPI...

tender shard Jul 9, 2023, 8:42 PM

#

I also don't think so

#

it makes absolutely no sense

rose trail Jul 9, 2023, 8:43 PM

#

It stops at future.get();

quiet ice Jul 9, 2023, 8:43 PM

#

Is the future ever completed?

#

Do you even know what futures do?

remote swallow Jul 9, 2023, 8:44 PM

#

rose trail It stops at future.get();

future.get blocks

#

this is very pointless

#

this.future.whenComplete(uuid -> {
//do whatever
}

#

your uuid will be null with the way you do it currently

rose trail Jul 9, 2023, 8:46 PM

#

thanks

rose trail Jul 9, 2023, 8:47 PM

#

quiet ice Do you even know what futures do?

No, but this is my only way to solve the problem

noble crown Jul 9, 2023, 8:48 PM

#

I don't think it's the only way 🤔

rose trail Jul 9, 2023, 8:49 PM

#

I can't think of anything else

quiet ice Jul 9, 2023, 8:50 PM

#

AtomicReferences might be another way

rough drift Jul 9, 2023, 8:50 PM

#

Quickly, if you set an objective score to 0, does it show as 1 or is it ignored

quiet ice Jul 9, 2023, 8:50 PM

#

I think it is shown as 0?

rough drift Jul 9, 2023, 8:50 PM

#

quiet ice Jul 9, 2023, 8:51 PM

#

Yeah could also be that I am misremebering those

rough drift Jul 9, 2023, 8:51 PM

#

only issue is that it's only showing one of em

remote swallow Jul 9, 2023, 8:51 PM

#

i think you have to use packets

#

check how TAB does it

quiet ice Jul 9, 2023, 8:51 PM

#

Okay yeah. It's 1 - X

rough drift Jul 9, 2023, 8:51 PM

#

wdym epic

young knoll Jul 9, 2023, 8:51 PM

#

Just get that resource pack that removes the numbers

rough drift Jul 9, 2023, 8:51 PM

#

That's not what I want lmao

#

I am just asking because some of the text is not showing

#

I set a team's score to zero to display that, but it's not showing so I was wondering if it started at 1 or zero

remote swallow Jul 9, 2023, 8:52 PM

#

oh i thought you wanted to make them all 0

rough drift Jul 9, 2023, 8:52 PM

#

oh no

young knoll Jul 9, 2023, 8:53 PM

#

Yeah I think 0 doesn’t show by default

rough drift Jul 9, 2023, 8:53 PM

#

moving the setting to be at least 3

#

let's see if that fixes it

#

if it does then I know the issue ;)

#

I've been making simple mistakes today

#

like != instead !.equals

#

lmao

eternal oxide Jul 9, 2023, 8:54 PM

#

0 displays

rough drift Jul 9, 2023, 8:54 PM

#

Apparently not

compact haven Jul 9, 2023, 8:54 PM

#

rough drift like != instead !.equals

#notAKotlinProblem

quiet ice Jul 9, 2023, 8:54 PM

#

I think it just depends

compact haven Jul 9, 2023, 8:54 PM

#

it's possible you have too many lines?

rough drift Jul 9, 2023, 8:54 PM

#

I have 15 iirc

remote swallow Jul 9, 2023, 8:54 PM

#

compact haven #notAKotlinProblem

no

#

bad

quiet ice Jul 9, 2023, 8:54 PM

#

I recall it not being a problem with Presence

compact haven Jul 9, 2023, 8:54 PM

#

ur bad

remote swallow Jul 9, 2023, 8:55 PM

#

eternal oxide Jul 9, 2023, 8:55 PM

#

where are MC screenshots saved? I forget

rough drift Jul 9, 2023, 8:55 PM

#

16 lines in total, going from 0 to 15, or is that too much

quiet ice Jul 9, 2023, 8:55 PM

#

But I don't recall seeing 0 elsewhere either

rough drift Jul 9, 2023, 8:55 PM

#

eternal oxide where are MC screenshots saved? I forget

%appdata%\.minecraft\screenshots

compact haven Jul 9, 2023, 8:55 PM

#

^

#

so quick

rough drift Jul 9, 2023, 8:55 PM

#

yep I got muscle mem for the mc directory

remote swallow Jul 9, 2023, 8:55 PM

#

eternal oxide where are MC screenshots saved? I forget

i rarely ever go there

#

mainy bc i dont use that .minecraft

#

i love discord making me reply to random things

neon nymph Jul 9, 2023, 8:56 PM

#

Hello! Is it possible to store custom enums into an item's PDC? Currently I only store the int references to my enums, but I was wondering if I could store the enum itself

eternal oxide Jul 9, 2023, 8:56 PM

#

odd mines not there 😦

remote swallow Jul 9, 2023, 8:56 PM

#

the entire enum?

hazy parrot Jul 9, 2023, 8:56 PM

#

neon nymph Hello! Is it possible to store custom enums into an item's PDC? Currently I only...

Make custom adapter

compact haven Jul 9, 2023, 8:56 PM

#

!notworking

#

lame ass bot

young knoll Jul 9, 2023, 8:57 PM

#

Bad

neon nymph Jul 9, 2023, 8:57 PM

#

remote swallow the entire enum?

I guess ?

rough drift Jul 9, 2023, 8:57 PM

#

?notworking

undone axleBOT Jul 9, 2023, 8:57 PM

#

"Does not working" is a useless statement. Please describe what exactly is not working, what you expect it to do, and what actually happens. If you get any console errors, also ?paste the entire stacktrace.

rose trail Jul 9, 2023, 8:57 PM

#

remote swallow this.future.whenComplete(uuid -> { //do whatever }

blocks anyway

hazy parrot Jul 9, 2023, 8:57 PM

#

Who tf is using java cord

remote swallow Jul 9, 2023, 8:57 PM

#

i dont see where this is, and use jda

timid hedge Jul 9, 2023, 8:57 PM

#

When i use !whoIsOnline nothing is happening

hazy parrot Jul 9, 2023, 8:57 PM

#

rose trail blocks anyway

That code isn't blocking

remote swallow Jul 9, 2023, 8:57 PM

#

rose trail blocks anyway

whenComplete wont block, im guessing you calling the future is blocking

neon nymph Jul 9, 2023, 8:57 PM

#

hazy parrot Make custom adapter

Could you point me to a resource where I could learn about this?

remote swallow Jul 9, 2023, 8:57 PM

#

this is probably the wrong use for futures

#

use callbacks or something

hazy parrot Jul 9, 2023, 8:58 PM

#

neon nymph Could you point me to a resource where I could learn about this?

https://www.spigotmc.org/threads/a-guide-to-1-14-persistentdataholder-api.371200/ scroll down to "Custom PersistentDataTypes and how to use them ?"

SpigotMC - High Performance Minecraft

Resource - A guide to 1.14 - PersistentDataHolder API

Hey there,

after 1.13.2 already got the new CustomItemTagContainer API, 1.14 is expanding on this new MetaData API and we will look into it a bit...

neon nymph Jul 9, 2023, 8:58 PM

#

Great, thanks so much! 😄

remote swallow Jul 9, 2023, 8:59 PM

#

it shouldnt?

#

i run it on mainthread

hazy parrot Jul 9, 2023, 8:59 PM

#

Jda have it's own thread anyway

#

Different for websocket and events

#

Because it's executing from jda thread, just call .runTask from consumer

umbral ridge Jul 9, 2023, 9:06 PM

#

rough drift

1 2 3 4 5 six even eight nine 10 eleven twlve 13 14 1five

rough drift Jul 9, 2023, 9:08 PM

#

Why does 1 get skipped though

umbral ridge Jul 9, 2023, 9:09 PM

#

That's a scoreboard on the right side yeah?

rough drift Jul 9, 2023, 9:09 PM

#

ye

umbral ridge Jul 9, 2023, 9:09 PM

#

What are you doing with it

#

how is it done

rough drift Jul 9, 2023, 9:10 PM

#

I generate 15 teams, set them to be an empty unique id, and set their score

#

then when I want I just change prefix/suffix for no flicker

umbral ridge Jul 9, 2023, 9:12 PM

#

if you do something like bukkit.broadcastMessage(id) in the code where you create these teams, does it output 15 ids?

#

any exceptions?

#

or if you go in your console and do /scoreboard

#

and check there if there are 15 teams

rough drift Jul 9, 2023, 9:12 PM

#

umbral ridge or if you go in your console and do /scoreboard

it's not the main sb

rough drift Jul 9, 2023, 9:12 PM

#

umbral ridge any exceptions?

0

umbral ridge Jul 9, 2023, 9:13 PM

#

rough drift it's not the main sb

OH?

rough drift Jul 9, 2023, 9:13 PM

#

nope

umbral ridge Jul 9, 2023, 9:13 PM

#

have you tried testing it with different ids?
eg.
11
12
13
14
15

rough drift Jul 9, 2023, 9:13 PM

#

yeah those all work

#

apart 1

umbral ridge Jul 9, 2023, 9:13 PM

#

then its probably just some bullshit hardcoded thing XD

rough drift Jul 9, 2023, 9:14 PM

#

What the fu-

umbral ridge Jul 9, 2023, 9:14 PM

#

Yeah it would piss me off too

#

what if you do negative? XD

#

can you even do that?

rough drift Jul 9, 2023, 9:15 PM

#

ye

umbral ridge Jul 9, 2023, 9:18 PM

#

then use negative I guess? if it works

wet breach Jul 9, 2023, 9:20 PM

#

rough drift What the fu-

it depends on your code

#

when it comes to looping inserts you have to insure you account for the initial loop

#

otherwise you miss an insert at the beginning or sometimes at the end

#

because it doesn't loop that one last time

#

this is why ++i and i++ are a thing

tawny remnant Jul 9, 2023, 9:21 PM

#

Whenever a mob tries to spawn the server crashes without any errors. Does anyone know what is wrong?
https://paste.md-5.net/epixamicam.coffeescript

wet breach Jul 9, 2023, 9:21 PM

#

show the error

#

please

eternal oxide Jul 9, 2023, 9:22 PM

#

you are spawning a mob in the spawn event

wet breach Jul 9, 2023, 9:22 PM

#

that may do it yeah

eternal oxide Jul 9, 2023, 9:22 PM

#

infinite loop

rough drift Jul 9, 2023, 9:22 PM

#

@wet breach When I register the team I just set text on it to debug, no further setting

#

Line 1 is just not rendered

wet breach Jul 9, 2023, 9:22 PM

#

eternal oxide infinite loop

bet the error is a stack exception

eternal oxide Jul 9, 2023, 9:22 PM

#

yep overflow

wet breach Jul 9, 2023, 9:23 PM

#

rough drift <@227800863022907393> When I register the team I just set text on it to debug, n...

mind showing the code?

ornate patio Jul 9, 2023, 9:23 PM

#

@EventHandler
public void onInventoryClick(InventoryClickEvent event) {
    // Allow tools and weapons to be placed in the smithing table (for custom upgrades)
    if (!(event.getInventory() instanceof SmithingInventory)) {
        return;
    }

    if (event.getSlot() == 1) {
        event.setResult(Result.ALLOW);
    }
}

I'm trying to allow players to put any tool or weapon inside a smithing table

#

This doesn't work, still only allows diamond tools

tawny remnant Jul 9, 2023, 9:24 PM

#

eternal oxide infinite loop

wdym i spawn a new mob and then i clear the original one

wet breach Jul 9, 2023, 9:24 PM

#

tawny remnant wdym i spawn a new mob and then i clear the original one

spawning a mob causes that event to run again

#

so its infinitely running with no condition to stop

eternal oxide Jul 9, 2023, 9:24 PM

#

the instant you call spawn, a new event is triggered. your event never gets to finish

#

and so on

tawny remnant Jul 9, 2023, 9:24 PM

#

oooohh

wet breach Jul 9, 2023, 9:24 PM

#

so you spawn the mob -> event runs your checks do its thing, removes entity, spawns another

#

and then it does it again

rough drift Jul 9, 2023, 9:24 PM

#

wet breach mind showing the code?

    for (int i = 0; i < 15; i++) {
        var team = scoreboard.registerNewTeam("test_team_" + i);
        var id = "§r".repeat(i);
        team.addEntry(id);
        team.setPrefix("A");
        objective.getScore(id).setScore(i);
    }

wet breach Jul 9, 2023, 9:25 PM

#

how you stop it from doing that is add something to your custom entities to check for

#

so as to not remove them

#

this way, the next event is just ignored instead 😛

wet breach Jul 9, 2023, 9:26 PM

#

rough drift ```java for (int i = 0; i < 15; i++) { var team = scoreboard.registe...

try changing it ++i

ornate patio Jul 9, 2023, 9:26 PM

#

ornate patio ```java @EventHandler public void onInventoryClick(InventoryClickEvent event) { ...

do i need to manually set the slot instead

wet breach Jul 9, 2023, 9:28 PM

#

ornate patio do i need to manually set the slot instead

well, you don't tell it what to do if its not slot 1

#

try adding an else statement to set result disallow?

ornate patio Jul 9, 2023, 9:28 PM

#

wet breach well, you don't tell it what to do if its not slot 1

why do i need to do that

#

i want to put any tool into the second slot

#

even if its not diamond

wet breach Jul 9, 2023, 9:28 PM

#

but I don't see where you check for the tools though 🤔

ornate patio Jul 9, 2023, 9:28 PM

#

i havent implemented that part yet

#

right now im just trying to put any item

#

which doesnt work

wet breach Jul 9, 2023, 9:29 PM

#

you might need to use a custom inventory for it, not sure. Does the smithing table typically allow any tools?

ornate patio Jul 9, 2023, 9:29 PM

#

no

#

it only allows diamond tools

wet breach Jul 9, 2023, 9:30 PM

#

then yeah going to need to use a custom inventory then most likely

ornate patio Jul 9, 2023, 9:30 PM

#

ugh damnit

wet breach Jul 9, 2023, 9:30 PM

#

because it could be a client side thing not allowing it, not necessarily the server

young knoll Jul 9, 2023, 9:30 PM

#

I know when you register recipes with different items they work fine

#

Well, at least in the old table they did

ornate patio Jul 9, 2023, 9:31 PM

#

well i need it to be dynamic tho

#

i need to read the properties of the tool

#

for the result item

young knoll Jul 9, 2023, 9:31 PM

#

You can still do that with a registered recipe

ornate patio Jul 9, 2023, 9:32 PM

#

i can do that for smithing tables?

tender shard Jul 9, 2023, 9:32 PM

#

tawny remnant oooohh

add a boolean field to your class

private boolean ignoreNextSpawn = false;

@EventHandler
public void onSpawn(EntitySpawnEvent event) {
  if(ignoreNextSpawn) {
    return;
  }

  // ...
  ignoreNextSpawn = true;
  event.getLocation().getWord().spawn(...);
  ignoreNextSpawn = false;
}

#

and instead of calling entity.remove(), why don't you just cancel the spawn event?

young knoll Jul 9, 2023, 9:33 PM

#

ornate patio i can do that for smithing tables?

Sure?

ornate patio Jul 9, 2023, 9:33 PM

#

how exactly

young knoll Jul 9, 2023, 9:35 PM

#

How to register a recipe?

ornate patio Jul 9, 2023, 9:36 PM

#

with a dynamic result

young knoll Jul 9, 2023, 9:36 PM

#

Same way you register crafting recipes, just with smithing instead

#

Use the event to change the result

ornate patio Jul 9, 2023, 9:36 PM

#

which event

#

and the issue still stands that I can't put any tool inside the smithing table

young knoll Jul 9, 2023, 9:37 PM

#

PrepareSmithingEvent

ornate patio Jul 9, 2023, 9:37 PM

#

young knoll PrepareSmithingEvent

wait so whats the purpose of registering the recipe

#

when i can just set the result inside that event

young knoll Jul 9, 2023, 9:38 PM

#

Like I said

#

It may only let you put the item in if there is a recipe that uses it

ornate patio Jul 9, 2023, 9:38 PM

#

oh

#

ok let me try rq

wet breach Jul 9, 2023, 9:40 PM

#

young knoll It may only let you put the item in if there is a recipe that uses it

seems reasonable

#

I am not super familiar with the smithing stuff as I haven't really messed with it lol

young knoll Jul 9, 2023, 9:40 PM

#

I’m not familiar with the new smithing table

ornate patio Jul 9, 2023, 9:41 PM

#

doesnt seem to work

#

Bukkit.addRecipe(
    new SmithingRecipe(new NamespacedKey(this, "custom_smithing"), new ItemStack(Material.IRON_SWORD), new RecipeChoice.MaterialChoice(Material.IRON_SWORD), new RecipeChoice.MaterialChoice(Material.IRON_INGOT))
);

#

also i just realized

#

this smithingrecipe class is outdated

#

theres now three elements inside the table

young knoll Jul 9, 2023, 9:42 PM

#

Iirc there’s new classes

#

SmithingTransformRecipe and SmithingTrimRecipe

ornate patio Jul 9, 2023, 9:46 PM

#

lemme try that then

young knoll Jul 9, 2023, 9:46 PM

#

They both seem to require 3 items tho

#

Hm

ornate patio Jul 9, 2023, 9:47 PM

#

oh shit it works

#

Bukkit.addRecipe(
    new SmithingTransformRecipe(
        new NamespacedKey(this, "custom_smithing"),
        new ItemStack(Material.IRON_SWORD),
        new RecipeChoice.MaterialChoice(Material.AIR),
        new RecipeChoice.MaterialChoice(Material.IRON_SWORD),
        new RecipeChoice.MaterialChoice(Material.IRON_INGOT)
    )
);

#

thank god

carmine mica Jul 9, 2023, 9:47 PM

#

yeah, spigot doesn't tell you that SmithingRecipe constructors are useless, as instances of pure SmithingRecipe aren't recognized by the server

#

addRecipe returned false there probably

ornate patio Jul 9, 2023, 9:47 PM

#

but yeah why are they 2 seperate recipes though

carmine mica Jul 9, 2023, 9:47 PM

#

because there are 2 kinds of smithing recipes now

ornate patio Jul 9, 2023, 9:47 PM

#

i mean

#

they both require templates anyways

carmine mica Jul 9, 2023, 9:47 PM

#

they have different behaviors

ornate patio Jul 9, 2023, 9:48 PM

#

i dont see why they're split

young knoll Jul 9, 2023, 9:48 PM

#

Ah you can just pass air to have no third item

#

Fair enough

ornate patio Jul 9, 2023, 9:48 PM

#

young knoll Ah you can just pass air to have no third item

yeah thats what i did

#

for the smithing template slot

carmine mica Jul 9, 2023, 9:49 PM

#

ornate patio i dont see why they're split

they have different behaviors

young knoll Jul 9, 2023, 9:49 PM

#

Wait can’t we just make SmithingRecipe abstract then

carmine mica Jul 9, 2023, 9:49 PM

#

well if you want to break API and probably ABI

young knoll Jul 9, 2023, 9:49 PM

#

I guess that would cause old plugins to explicitly throw an error, but that’s better than doing nothing imo

ornate patio Jul 9, 2023, 9:50 PM

#

carmine mica > they have different behaviors

whats different i dont understand

#

they're both the same recipes, one just uses armor trim templates and the other uses upgrade template

carmine mica Jul 9, 2023, 9:51 PM

#

if you use the trim one, and the stacks you input DON'T match trim pattern and trim material, it won't do anything

ornate patio Jul 9, 2023, 9:52 PM

#

wdym "stacks you put input"

#

what stacks

carmine mica Jul 9, 2023, 9:52 PM

#

the template and addition ingredients

ornate patio Jul 9, 2023, 9:53 PM

#

what needs to match

#

you can use any ore for the addition

#

and any smithing template

#

the only thing that won't work is if you use iron armor with an iron ingot addition or smthn

carmine mica Jul 9, 2023, 9:54 PM

#

you also don't specify a result for trim recipes, hence it extending ComplexRecipe

ornate patio Jul 9, 2023, 9:55 PM

#

hmm ok

#

i've never heard of ComplexRecipe before

#

could I perhaps use that for my own custom recipe instead too?

#

or do i have to use PrepareSmithingEvent

#

just completely out of curiosity

young knoll Jul 9, 2023, 9:57 PM

#

You can’t make an instance of ComplexRecipe directly

#

It’s an interface

ornate patio Jul 9, 2023, 9:59 PM

#

Oh ok

#

Should transform recipe use complexrecipe too though?

#

Because even though it always upgrades diamond to netherrite

#

It has to keep its enchants and nbt data

worthy moat Jul 9, 2023, 10:08 PM

#

hey

#

I want to save a Object with SnakeYAML (the yml framework which is used in spigot)

#

But

remote swallow Jul 9, 2023, 10:08 PM

#

ConfigurationSerializable

worthy moat Jul 9, 2023, 10:09 PM

#

Ah there you already know the problem hahaha

#

PirateCraft: !!de.marvn.alphablock.alphawars.util.objects.Arena

remote swallow Jul 9, 2023, 10:09 PM

#

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/configuration/serialization/ConfigurationSerializable.html

ConfigurationSerializable (Spigot-API 1.20.1-R0.1-SNAPSHOT API)

declaration: package: org.bukkit.configuration.serialization, interface: ConfigurationSerializable

worthy moat Jul 9, 2023, 10:09 PM

#

is it this one?

#

I am using 1.8.8

remote swallow Jul 9, 2023, 10:09 PM

#

that should exsit still

worthy moat Jul 9, 2023, 10:10 PM

#

I dont really understand how to use this

#

Should I implement this Interface into my Object?

remote swallow Jul 9, 2023, 10:11 PM

#

yeah

#

just follow its javadocs

worthy moat Jul 9, 2023, 10:12 PM

#

ok wait

#

A constructor that accepts a single Map<String, Object>.

#

?

#

What should I exactly put into the constructor

carmine mica Jul 9, 2023, 10:13 PM

#

a single Map<String, Object> param

#

then populate the fields from that map

worthy moat Jul 9, 2023, 10:13 PM

#

yeah but can i choose a name by myself?

young knoll Jul 9, 2023, 10:14 PM

#

Sure

#

Name doesn’t matter, only the type

remote swallow Jul 9, 2023, 10:14 PM

#

the name doesnt matter in a constructor

worthy moat Jul 9, 2023, 10:15 PM

#

        map.put("Name", name);
    }


    String name;```

#

Like that?

carmine mica Jul 9, 2023, 10:16 PM

#

well that's not constructing the object. you need to populate the feidl from the map

#

you create a map from the fields in the serialize() method that interface has you implement

remote swallow Jul 9, 2023, 10:16 PM

#

?learnjava moment

undone axleBOT Jul 9, 2023, 10:16 PM

#

Here are some links to get you started on learning Java:

The last one is the only official one, however some of those concepts assume that you already know a bit about programming.

worthy moat Jul 9, 2023, 10:17 PM

#

remote swallow ?learnjava moment

the problem is not that I dont know Java...The problem is that I have trouble understanding what you mean by populate

remote swallow Jul 9, 2023, 10:17 PM

#

the list will have whatever contents you add in the serialize method

worthy moat Jul 9, 2023, 10:18 PM

#

remote swallow the list will have whatever contents you add in the serialize method

So you mean I should add every String for example into this map in my serialize method?

young knoll Jul 9, 2023, 10:19 PM

#

Anything you need to serialize, yes

#

And then you read it from the map in the constructor

remote swallow Jul 9, 2023, 10:21 PM

#


public class MyCustomDataClass implements ConfigurationSerializable {

    private final String name;

    public MyCustomDataClass(String name) {
      this.name = name;
    }


    public MyCustomDataClass(Map<String, Object> map) {
      this.name = map.get("name");
    }

    public static MyCustomDataClass deserialize(Map<String, Object> map) {
        return new MyCustomDataClass(map):
    }

    public static MyCustomDataClass valueOf(Map<String, Object> map) {
        return new MyCustomDataClass(map):
    }

    @Override
    public Map<String,Object> serialize() {
        Map<String, Object> map = new HashMap<>();
        map.put("name", name);
        return map;
    }
}

worthy moat Jul 9, 2023, 10:22 PM

#

yes thats what I meant with the serialize method

#

yes

#

Thats why its a map

young knoll Jul 9, 2023, 10:23 PM

#

Yeah idk why you have a valueOf method there

#

Smh epic

worthy moat Jul 9, 2023, 10:24 PM

#

The question is...If I try to read my stuff...Why Do I need a deserialize and a valueOf if I get the Object with #get

young knoll Jul 9, 2023, 10:24 PM

#

Oh there are several options

worthy moat Jul 9, 2023, 10:24 PM

#

ahh

remote swallow Jul 9, 2023, 10:24 PM

#

young knoll Jul 9, 2023, 10:24 PM

#

Didn’t know that

remote swallow Jul 9, 2023, 10:24 PM

#

use eyes

young knoll Jul 9, 2023, 10:24 PM

#

Neat

remote swallow Jul 9, 2023, 10:24 PM

#

i didnt see the one

#

i thought it wanted all of them

young knoll Jul 9, 2023, 10:24 PM

#

Also hush I’ve never used ConfigurationSerializable

echo basalt Jul 9, 2023, 10:24 PM

#

man just did all 3

young knoll Jul 9, 2023, 10:24 PM

#

Kek

worthy moat Jul 9, 2023, 10:24 PM

#

young knoll Also hush I’ve never used ConfigurationSerializable

same XD

echo basalt Jul 9, 2023, 10:24 PM

#

ConfigurationSerializable is a bit gimmicky

#

looks ugly on yml

#

So I just make a constructor that takes a config section

young knoll Jul 9, 2023, 10:25 PM

#

Yeah it has the weird !!class to identify it

worthy moat Jul 9, 2023, 10:25 PM

#

Yeah....Cant do anything...Need to save it somehow

echo basalt Jul 9, 2023, 10:25 PM

#

And simply never have to impl a write method because all my YMLs are read-only :p

young knoll Jul 9, 2023, 10:25 PM

#

My cursed reflection config lib takes care of everything

worthy moat Jul 9, 2023, 10:25 PM

#

Uhhh what if I have a List of Objects in my Object xD

#

same thing for them?

#

map.put("teams", teams);

compact haven Jul 9, 2023, 10:26 PM

#

my configs are kinda scuffed, I have an interface, then a class YamlWhatsverConfig that accepts a ConfigurationSection in the constructor, then the interface returns the values of ConfigurationSection#get…

young knoll Jul 9, 2023, 10:26 PM

#

Make sure the items in the list are ConfigurationSerializable

worthy moat Jul 9, 2023, 10:26 PM

#

Just like that?

young knoll Jul 9, 2023, 10:26 PM

#

List itself is already serializable so ur good on that part

worthy moat Jul 9, 2023, 10:27 PM

#

So I wouldnt have to serialize that? HashMap<String, Team> teams = new HashMap<>();

remote swallow Jul 9, 2023, 10:27 PM

#

just make sure its vaulues are (configuration)Serializable

worthy moat Jul 9, 2023, 10:27 PM

#

remote swallow just make sure its vaulues are (configuration)Serializable

Yes Team for example does not implement that

remote swallow Jul 9, 2023, 10:27 PM

#

team is gonna need serializing

worthy moat Jul 9, 2023, 10:27 PM

#

ah ok

#

thx

ivory sleet Jul 9, 2023, 10:28 PM

#

compact haven my configs are kinda scuffed, I have an interface, then a class YamlWhatsverConf...

Tbh sounds like a robust design

compact haven Jul 9, 2023, 10:29 PM

#

It is

ivory sleet Jul 9, 2023, 10:29 PM

#

Sounds like everything but scuffed

worthy moat Jul 9, 2023, 10:29 PM

#

remote swallow ```java public class MyCustomDataClass implements ConfigurationSerializable { ...

do I need the first constructer on the top?

#

Otherwise I would juist use valueOf

remote swallow Jul 9, 2023, 10:30 PM

#

turns out you only need 1 of them

#

pick your favourit

#

e]

compact haven Jul 9, 2023, 10:30 PM

#

kek thank you for that

worthy moat Jul 9, 2023, 10:30 PM

#

remote swallow turns out you only need 1 of them

wait your talking to me or Dominick?

compact haven Jul 9, 2023, 10:30 PM

#

You

ivory sleet Jul 9, 2023, 10:30 PM

#

Yeah but fr tho, if I read code like that my eyes would be shining

remote swallow Jul 9, 2023, 10:30 PM

#

whoevers listening

young knoll Jul 9, 2023, 10:31 PM

#

I can make your eyes bleed if you want

#

Kek

ivory sleet Jul 9, 2023, 10:31 PM

#

🥹

#

peepoBlush

remote swallow Jul 9, 2023, 10:31 PM

#

young knoll I can make your eyes bleed if you want

do it

worthy moat Jul 9, 2023, 10:31 PM

#

remote swallow ```java public class MyCustomDataClass implements ConfigurationSerializable { ...

The second Constructer wouldnt work cause this.name needs a String but you only get a plain Object

#

I mean the IDE would have a probl

remote swallow Jul 9, 2023, 10:31 PM

#

cast it

compact haven Jul 9, 2023, 10:31 PM

#

https://github.com/Itzdlg/CPvP-Kits/tree/master/src/main/java/us/cpvp/kits/entities/configuration/kits @ivory sleet this is what I do

GitHub

CPvP-Kits/src/main/java/us/cpvp/kits/entities/configuration/kits at...

Contribute to Itzdlg/CPvP-Kits development by creating an account on GitHub.

ivory sleet Jul 9, 2023, 10:32 PM

#

I remember this faction code base where all their data was grabbed from debugging logs, oh god, dont think code can get any worse than that

worthy moat Jul 9, 2023, 10:32 PM

#

hmm ok

compact haven Jul 9, 2023, 10:32 PM

#

debugging logs cat_what

#

logs as input is actually crazy

ivory sleet Jul 9, 2023, 10:32 PM

#

compact haven https://github.com/Itzdlg/CPvP-Kits/tree/master/src/main/java/us/cpvp/kits/entit...

✨🔥

remote swallow Jul 9, 2023, 10:33 PM

#

@young knoll wheres my eye blood

young knoll Jul 9, 2023, 10:33 PM

#

Logs as input

#

Wtf

worthy moat Jul 9, 2023, 10:34 PM

#

ok so

#

    @Override
    public Map<String, Object> serialize() {
        Map<String, Object> map = new HashMap<>();
        map.put("name", name);
        map.put("maxPlayers", maxPlayers);
        map.put("teams", teams);

        map.put("bronzeSpawner", bronzeSpawner);
        map.put("silverSpawner", silverSpawner);
        map.put("goldSpawner", goldSpawner);
        map.put("diamondSpawner", diamondSpawner);
        map.put("emeraldSpawner", emeraldSpawner);
        return map;
    }```

#

Does this look good?

#

Is that how they want that?

remote swallow Jul 9, 2023, 10:34 PM

#

as long as its a a map string object its happy

worthy moat Jul 9, 2023, 10:35 PM

#

nice

#

    public Arena(Map<String, Object> map) {
        this.name = (String) map.get("name");
        this.maxPlayers = (Integer) map.get("maxPlayers");
        this.teams = (HashMap<String, Team>) map.get("teams");

        this.bronzeSpawner = (List<Location>) map.get("bronzeSpawner");
        this.silverSpawner = (List<Location>) map.get("silverSpawner");
        this.goldSpawner = (List<Location>) map.get("goldSpawner");
        this.diamondSpawner = (List<Location>) map.get("diamondSpawner");
        this.emeraldSpawner = (List<Location>) map.get("emeraldSpawner");
    }``` and this is my constructor

#

Looks good?

compact haven Jul 9, 2023, 10:35 PM

#

yep

worthy moat Jul 9, 2023, 10:35 PM

#

ok and if i read that correctly I have to serialize it in my onEnable?

remote swallow Jul 9, 2023, 10:36 PM

#

ConfigurationSerialization.registerClass(Arena.class)

worthy moat Jul 9, 2023, 10:36 PM

#

Wait

#

I first have to make Team serializable

compact haven Jul 9, 2023, 10:36 PM

#

probably

#

also you don't necessarily need to register it in onEnable I don't believe

#

if you find it better to stick it in a static block in the same class, that probably will work

static {
  ConfigurationSerialization.registerClass(Arena.class)
}

rough drift Jul 9, 2023, 10:37 PM

#

I need to split a string, whilst keeping color codes intact, is there a known way to do this?

compact haven Jul 9, 2023, 10:38 PM

#

doge_kek

ivory sleet Jul 9, 2023, 10:38 PM

#

rough drift I need to split a string, whilst keeping color codes intact, is there a known wa...

How do u split it?

rough drift Jul 9, 2023, 10:38 PM

#

Just using length right now, that's why it's happening

ivory sleet Jul 9, 2023, 10:38 PM

#

Like with String::split and pass a pattern?

rough drift Jul 9, 2023, 10:38 PM

#

var left = text.substring(0, Math.min(text.length(), 64));
var right = text.length() >= 64 ? text.substring(64) : "";

compact haven Jul 9, 2023, 10:38 PM

#

you could probably use indexOf, then loop all characters from then to indexOf, and build a new translatable string color code?

#

I mean instead of indexof you'd just use the second parameter of substring, but same idea

rough drift Jul 9, 2023, 10:39 PM

#

compact haven you could probably use indexOf, then loop all characters from then to indexOf, a...

If there was only one code that'd be fine, but take like hex §x§f§f§f§f§f§f or §l§n§6

compact haven Jul 9, 2023, 10:40 PM

#

well I'm thinking if you have a string like &aHello &cWorld &b&lHahahahah &r&6Test (split) &cmwhaha, you'd end up with &a&c&b&l&r&6&cmwhahaha, and that should just apply the right ones, I think?

rough drift Jul 9, 2023, 10:40 PM

#

I figured

if the last char is a color code, move it to right
if two characters behind is a color code, move the last two chars to right
try repeat two

ivory sleet Jul 9, 2023, 10:41 PM

#

You’d just wanna make sure the character after § is together with the § if its a valid chatcolor code character?

rough drift Jul 9, 2023, 10:41 PM

#

Oh shit yeah domi

ivory sleet Jul 9, 2023, 10:41 PM

#

Or is it important to have consecutive § pairs not split up?

remote swallow Jul 9, 2023, 10:41 PM

#

coll

#

wheres my eye blood

worthy moat Jul 9, 2023, 10:41 PM

#

Ah fuck it still shows that: " ==: de.marvn.alphablock.alphawars.util.objects.Arena"

rough drift Jul 9, 2023, 10:41 PM

#

I could just

indexOf('§r') (if it returns -1 I just use indexOf('§')) and just apply all existing color codes forward, thanks

ivory sleet Jul 9, 2023, 10:42 PM

#

Dw coll is cooking

worthy moat Jul 9, 2023, 10:42 PM

#

worthy moat Ah fuck it still shows that: " ==: de.marvn.alphablock.alphawars.util.objects.A...

in the middle of my data.yml

compact haven Jul 9, 2023, 10:42 PM

#

worthy moat Ah fuck it still shows that: " ==: de.marvn.alphablock.alphawars.util.objects.A...

yeah that's why no one uses ConfigurationSerializable

#

it's the worst API in existance

worthy moat Jul 9, 2023, 10:42 PM

#

But how should I then save my stuff?

compact haven Jul 9, 2023, 10:42 PM

#

manually write to ConfigurationSection

worthy moat Jul 9, 2023, 10:42 PM

#

what should I use instead

remote swallow Jul 9, 2023, 10:42 PM

#

database

worthy moat Jul 9, 2023, 10:42 PM

#

compact haven manually write to ConfigurationSection

damn...Never done something like that

#

any guide?

young knoll Jul 9, 2023, 10:42 PM

#

remote swallow wheres my eye blood

You’ve already seen my funny reflection config api

remote swallow Jul 9, 2023, 10:43 PM

#

i hav?e

young knoll Jul 9, 2023, 10:43 PM

#

And my unfreezing registries

compact haven Jul 9, 2023, 10:43 PM

#

worthy moat damn...Never done something like that

while this doesn't write, it does read. implementing write is simple since Yaml... has ConfigurationSection https://github.com/Itzdlg/CPvP-Kits/tree/master/src/main/java/us/cpvp/kits/entities/configuration/kits

#

but you most definitely have done this before

remote swallow Jul 9, 2023, 10:43 PM

#

young knoll And my unfreezing registries

oh yeah that i ahte

compact haven Jul 9, 2023, 10:43 PM

#

it's literally just section.setInt("maxPlayers", team.maxPlayers) and so-forth

#

https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/configuration/ConfigurationSection.html refer for set and read methods

#

and note that YamlConfiguration is also an instance of ConfigurationSection so if your data is at the root, it'll still work fine

worthy moat Jul 9, 2023, 10:44 PM

#

So the interface holds the data types?

ivory sleet Jul 9, 2023, 10:44 PM

#

Switch Map<String,Object> to ConfigurationSection lmao

remote swallow Jul 9, 2023, 10:44 PM

#

josh does ur config work off gson type adapters

ivory sleet Jul 9, 2023, 10:44 PM

#

Thats all

compact haven Jul 9, 2023, 10:44 PM

#

in my case yes, but you don't necessarily have to inplement it like that

#

you'd just change your constructor like Conclube said

young knoll Jul 9, 2023, 10:44 PM

#

Not my fault Mojang freezes the registries smh

young knoll Jul 9, 2023, 10:44 PM

#

remote swallow josh does ur config work off gson type adapters

No

remote swallow Jul 9, 2023, 10:45 PM

#

why not

worthy moat Jul 9, 2023, 10:45 PM

#

ivory sleet Thats all

and should I keep the serializable method and implement ConfigurationSerializable?

compact haven Jul 9, 2023, 10:45 PM

#

no do not implement that

#

and u can remove the method

ivory sleet Jul 9, 2023, 10:45 PM

#

^

worthy moat Jul 9, 2023, 10:46 PM

#

ok

ivory sleet Jul 9, 2023, 10:46 PM

#

or just change it to
public ConfigurationSection serialize() {
…
}

compact haven Jul 9, 2023, 10:46 PM

#

just from when you attempt to build the object it's not like this:
(Arena) config.get("arena"), it's like this: new Arena(config.getSection("arena"))

worthy moat Jul 9, 2023, 10:46 PM

#

ConfigurationSerialization.registerClass(Team.class);

#

This also out?

ivory sleet Jul 9, 2023, 10:47 PM

#

Yeah

compact haven Jul 9, 2023, 10:48 PM

#

kind of like this:

public class Arena {
    protected int maxPlayers;
    
    public Arena(int maxPlayers) {
        this.maxPlayers = maxPlayers;
    }
    
    public Arena(ConfigurationSection section) {
        super(
            section.getInt("maxPlayers")
        );
    }

    public Arena(ConfigurationSection config, String key) {
        return super(config.getSection(key)); /* even can do this, so getting becomes new Arena(config, "arena") */
    }
    
    public void write(ConfigurationSection section) {
        section.setInt("maxPlayers", maxPlayers);
    }
}

young knoll Jul 9, 2023, 10:48 PM

#

remote swallow why not

Because it ain’t json

remote swallow Jul 9, 2023, 10:48 PM

#

its a superset

#

anyway im going to bed

#

josh thing of things i can do tomorrow

#

and dm them me

#

https://www.youtube.com/watch?v=nzDqvxiEZ4k&ab_channel=StupidEdits

YouTube

Stupid Edits

That was a problem for future me and now I am future me

#onk #TomScott

▶ Play video

#

now im out

worthy moat Jul 9, 2023, 10:48 PM

#

compact haven kind of like this: ```java public class Arena { protected int maxPlayers; ...

wait for what the write?

#

Cant i just save?

compact haven Jul 9, 2023, 10:49 PM

#

wdym

rough drift Jul 9, 2023, 10:49 PM

#

compact haven well I'm thinking if you have a string like `&aHello &cWorld &b&lHahahahah &r&6T...

Testing this

#

(though going from last §r to not add too much, char limit is 64)

worthy moat Jul 9, 2023, 10:49 PM

#

I currently save like this;
I prepare an Arena after some setup things and then i put it in my yml like this
getConfig().set(Cache.arena.getName(), Cache.arena);

ivory sleet Jul 9, 2023, 10:50 PM

#

compact haven kind of like this: ```java public class Arena { protected int maxPlayers; ...

Yeah, I mean its possible to return ConfigurationSection also, you’d just invoke MemoryConfiguration’s constructor and use it as a fresh map, but that looks good (just if they want it to be as similar as possible to before)

compact haven Jul 9, 2023, 10:50 PM

#

instead you'd save like Cache.arena.write(getConfig().getSection(Cache.arena.getName()))

compact haven Jul 9, 2023, 10:51 PM

#

ivory sleet Yeah, I mean its possible to return ConfigurationSection also, you’d just invoke...

this as well ^

worthy moat Jul 9, 2023, 10:51 PM

#

compact haven instead you'd save like `Cache.arena.write(getConfig().getSection(Cache.arena.ge...

But wouldnt you only save the name in that case?

#

I want to push the whole object containing everything

compact haven Jul 9, 2023, 10:51 PM

#

you're pushing the whole object

#

    public void write(ConfigurationSection section) {
        section.setInt("maxPlayers", maxPlayers);
    }

that's what this does

#

you're giving it a new "section" in your config, like

data.yml

arenas:
  nameOfArena: # getConfig().getSection(Cache.arena.getName()
    maxPlayers: 5

and you'd write to that section using Cache.arena.write(getConfig().getSection(Cache.arena.getName()))

worthy moat Jul 9, 2023, 10:53 PM

#

compact haven instead you'd save like `Cache.arena.write(getConfig().getSection(Cache.arena.ge...

I only find getConfigurationSection

compact haven Jul 9, 2023, 10:53 PM

#

ah yeah it's that

#

sorry I forget they don't short-hand it

worthy moat Jul 9, 2023, 10:53 PM

#

compact haven kind of like this: ```java public class Arena { protected int maxPlayers; ...

Is it also possible to have an empyy constructor instead of the first one?

compact haven Jul 9, 2023, 10:53 PM

#

why would you have an empty constructor

#

please don't tell me you're filling in the fields manually like this is C

#

technically yes you can have an empty constructor and access new Arena().maxPlayers = 5;, but that's a huge anti-pattern

worthy moat Jul 9, 2023, 10:54 PM

#

compact haven please don't tell me you're filling in the fields manually like this is C

I have to because those fields have to get filled after another after specific events

compact haven Jul 9, 2023, 10:54 PM

#

there's probably a better design, but yes you can

worthy moat Jul 9, 2023, 10:55 PM

#

ok

compact haven Jul 9, 2023, 10:55 PM

#

though you need to replace super with this.maxPlayers

ivory sleet Jul 9, 2023, 10:56 PM

#

worthy moat Is it also possible to have an empyy constructor instead of the first one?

Marvin there are to designs you can have.

Either:
class Boo{
Boo(ConfigSection …){

}

ConfigSection …() {

}
}

or

class Doo {
void read(ConfigSection …){

}

void write(ConfigSection …){

}
}

One has 2 void methods, one has 0 void methods, choose one (the first one is if ur fields/variables in Boo.java can be re-assigned, the second one if they cant) mutability vs immutability.

glad prawn Jul 9, 2023, 10:57 PM

#

compact haven though you need to replace super with this.maxPlayers

super(..) to this(..)

ivory sleet Jul 9, 2023, 10:57 PM

#

Since I don’t know how ur data transfer (ur class that u wanna serialize) is used it is hard to say what would he the best choice here

worthy moat Jul 9, 2023, 10:57 PM

#

compact haven kind of like this: ```java public class Arena { protected int maxPlayers; ...

what should I use in the section.getInt if the Object is a Location from SPigot?

ivory sleet Jul 9, 2023, 10:57 PM

#

glad prawn super(..) to this(..)

?

worthy moat Jul 9, 2023, 10:57 PM

#

compact haven though you need to replace super with this.maxPlayers

yep

ivory sleet Jul 9, 2023, 10:58 PM

#

getSerializable("path",Location.class)

#

I think

glad prawn Jul 9, 2023, 10:58 PM

#

Call another constructor use the this keyword?

worthy moat Jul 9, 2023, 10:58 PM

#

So like this currently if I dont have a constructer with all fields? java public Team (ConfigurationSection map) { this.spawnPoint = (Location) map.get("spawnPoint"); this.spawnBlock = (Location) map.get("spawnBlock"); }

ivory sleet Jul 9, 2023, 10:59 PM

#

glad prawn Call another constructor use the this keyword?

Its possible

glad prawn Jul 9, 2023, 10:59 PM

#

Yes i'm talking about it

ivory sleet Jul 9, 2023, 10:59 PM

#

Constructors and overriding them works similar to methods and when you override them

#

In fact almost identical

#

super. goes up to the superclass above, if the superclass did not do anything with the methods, it chains to the superclass of the superclass

#

same with constructors

#

Only difference is when you override a constructor you must call its super

#

Otherwise you’d get a lot null pointer exceptions

worthy moat Jul 9, 2023, 11:01 PM

#

Thats too much info...Slowly please....My class currently looks like this:

#

public class Team {

    public Team(){

    }

    public Team (ConfigurationSection map) {
        this.spawnPoint = (Location) map.get("spawnPoint");
        this.spawnBlock = (Location) map.get("spawnBlock");
    }

    protected Location spawnPoint;
    protected Location spawnBlock;

    public Location getSpawnPoint() {
        return spawnPoint;
    }

    public void setSpawnPoint(Location spawnPoint) {
        this.spawnPoint = spawnPoint;
    }

    public Location getSpawnBlock() {
        return spawnBlock;
    }

    public void setSpawnBlock(Location spawnBlock) {
        this.spawnBlock = spawnBlock;
    }

    public void write(ConfigurationSection section) {
        section.set("spawnPoint", spawnPoint);
        section.set("spawnBlock", spawnBlock);
    }

}```

#

does that work?

ivory sleet Jul 9, 2023, 11:02 PM

#

Its bad

worthy moat Jul 9, 2023, 11:02 PM

#

yes but it would work?

ivory sleet Jul 9, 2023, 11:02 PM

#

Yes

worthy moat Jul 9, 2023, 11:02 PM

#

ok

#

so now to the optimization part

#

What exactly should I change

ivory sleet Jul 9, 2023, 11:03 PM

#

The constructor

compact haven Jul 9, 2023, 11:03 PM

#

why don't you use a builder pattern

worthy moat Jul 9, 2023, 11:03 PM

#

compact haven why don't you use a builder pattern

wdym exactly?

compact haven Jul 9, 2023, 11:04 PM

#

https://www.digitalocean.com/community/tutorials/builder-design-pattern-in-java

Builder Design Pattern in Java | DigitalOcean

Technical tutorials, Q&A, events — This is an inclusive place where developers can find or lend support and discover new ways to contribute to the community.

#

though that one is a bit weird, I don't think I've ever seen a class accept a builder as a constructor parameter

#

typically the builder returns the constructor invocation

worthy moat Jul 9, 2023, 11:06 PM

#

Ah you mean that

ivory sleet Jul 9, 2023, 11:06 PM

#

compact haven though that one is a bit weird, I don't think I've ever seen a class accept a bu...

Yeah, I think it can be fine if you have a static factory method but else myea

worthy moat Jul 9, 2023, 11:06 PM

#

Yeah I will build them like that afterwards...Thanks for remembering me..Havent thought of it

worthy moat Jul 9, 2023, 11:06 PM

#

ivory sleet The constructor

So what exactly should I change in this constructor

ornate patio Jul 9, 2023, 11:06 PM

#

I'm trying to increment a weapon's attack damage

private void enhanceGear(ItemMeta meta, Attribute attribute, int level) {
    Collection<AttributeModifier> modifiers = meta.getAttributeModifiers(attribute);

    if (modifiers != null) {
        for (AttributeModifier modifier : modifiers) {
            if (modifier.getName().equals("smithingEnhancement")) {
                meta.removeAttributeModifier(attribute, modifier);
            }
        }
    }

    meta.addAttributeModifier(attribute, new AttributeModifier("smithingEnhancement", level, AttributeModifier.Operation.ADD_NUMBER));
}
...
enhanceGear(meta, Attribute.GENERIC_ATTACK_DAMAGE, level);

ivory sleet Jul 9, 2023, 11:06 PM

#

Well you know how you hav setters

ornate patio Jul 9, 2023, 11:07 PM

#

but then all of this shows up

ivory sleet Jul 9, 2023, 11:07 PM

#

Because of that, there is no real need to actually do anything in ur constructor

#

Instead I would go with another void method that reads from a configuration section

worthy moat Jul 9, 2023, 11:08 PM

#

ivory sleet Well you know how you hav setters

i cant follow

ivory sleet Jul 9, 2023, 11:08 PM

#

I want u to delete ur constructor in that class

#

Instead use a method to set the values of the fields from ur config

worthy moat Jul 9, 2023, 11:09 PM

#

the empty one? probably not the one with the COnfiguration map

compact haven Jul 9, 2023, 11:09 PM

#

the empty one, yes

#

oh but wait pepeThink

#

conclube if he deletes that one then he can't do his weird design

#

oh I understand what you mean now

worthy moat Jul 9, 2023, 11:10 PM

#

compact haven conclube if he deletes that one then he can't do his weird design

np man I will change to a build pattern

#

but first i want to try and see if it works

ivory sleet Jul 9, 2023, 11:10 PM

#

Yeah, I just thought that since the class itself is mutable by nature, the reads and writes should follow the pattern he chose initially

compact haven Jul 9, 2023, 11:10 PM

#

shrug

worthy moat Jul 9, 2023, 11:11 PM

#

wait so as far as I understood

#

I just have my setter which gives the value to my var....And in my write method I manually do Config.set(Something.spawnPoint, spawnPoint) and this for each value?

#

I ve never worked with Serializing...I just wanted to write a MinecraftPlugin and save something....This is so complicated if you never done something with yml

ivory sleet Jul 9, 2023, 11:15 PM

#

Let me write a sample

ornate patio Jul 9, 2023, 11:15 PM

#

ornate patio I'm trying to increment a weapon's attack damage ```java private void enhanceGea...

for some reason this actually makes the sword weaker

#

i thought an attribute modifier would MODIFY the existing value

worthy moat Jul 9, 2023, 11:15 PM

#

ivory sleet Let me write a sample

I am sorry for making you help me hahaha

#

thanks a lot man

magic glacier Jul 9, 2023, 11:17 PM

#

how to get the uuid of the player if he is offline