remote swallow May 31, 2023, 11:33 PM

#

user error

young knoll May 31, 2023, 11:33 PM

#

“Can this be reopened? This as the current fix still can cause a memory leak. Entity metadata doesn't automatically delete on entity delete, so you need to either do it yourself or use a custom system for storing this data.”

worldly ingot May 31, 2023, 11:33 PM

#

Yeah, in that regards it's leaky. Though that's sort of tough to fix tbh

#

Java doesn't have destructors

young knoll May 31, 2023, 11:34 PM

#

Can’t you remove it on death

worldly ingot May 31, 2023, 11:34 PM

#

It should persist across deaths

young knoll May 31, 2023, 11:34 PM

#

On entities?

worldly ingot May 31, 2023, 11:34 PM

#

Yes

young knoll May 31, 2023, 11:35 PM

#

I see

worldly ingot May 31, 2023, 11:35 PM

#

young knoll May 31, 2023, 11:35 PM

#

Can it be fixed with weak references

worldly ingot May 31, 2023, 11:35 PM

#

Dunno. Haven't looked at the impl super in-depth enough to know how to resolve leaky API like that. I don't even really think you can resolve it without destructors

young knoll May 31, 2023, 11:35 PM

#

Hmm

quaint mantle May 31, 2023, 11:36 PM

#

                    if (item1.getType() == Material.IRON_HORSE_ARMOR && itemd1.getCustomModelData() == 1) {
                        if (e.getAction() == Action.RIGHT_CLICK_BLOCK || e.getAction() == Action.RIGHT_CLICK_AIR) {
                            List<Block> los = e.getPlayer().getLineOfSight(null, 5);
                            for (Block b : los) {
                                if (b.getType() == Material.WATER) {
                                    itemd1.setCustomModelData(2);
                                    world.playSound(block.getLocation(), Sound.ITEM_BUCKET_FILL_LAVA, 5,2);
                                    item1.setItemMeta(itemd1);
                                    Bukkit.broadcastMessage("test");
                                    break;
                                }
                            }
                        }
                    }``` @eternal oxide

#

this code not working btw

young knoll May 31, 2023, 11:36 PM

#

Might be something to look at if I get bored

quaint mantle May 31, 2023, 11:36 PM

#

i mean works but if click block in water not working

worldly ingot May 31, 2023, 11:36 PM

#

Point being, super super useful API, people just don't know how to use it correctly. Deprecating it isn't an option

young knoll May 31, 2023, 11:36 PM

#

Fair enough

#

Might be good to add a warning that you should explicitly remove any metadata you add

worldly ingot May 31, 2023, 11:37 PM

#

If it's not in the Javadocs currently then yeah, could probably be set on Metadatable

#

Although imho I think metadata should extend beyond a player disconnecting

#

For the same reason a Player instance still exists so long as a reference is held

young knoll May 31, 2023, 11:37 PM

#

Yeah I guess as long as the instance is still valid it can be useful

eternal oxide May 31, 2023, 11:40 PM

#

quaint mantle ```java if (item1.getType() == Material.IRON_HORSE_ARMOR && ...

what version spigot?

quaint mantle May 31, 2023, 11:40 PM

#

17

#

1.16.5

young knoll May 31, 2023, 11:41 PM

#

I think flowing water is a separate material

#

FYI

eternal oxide May 31, 2023, 11:42 PM

#

do you have an api version in your plugin.yml?

quaint mantle May 31, 2023, 11:42 PM

#

eternal oxide May 31, 2023, 11:42 PM

#

ok

#

code looks fine to me, so long as your model data is correct

#

add debugs

quaint mantle May 31, 2023, 11:44 PM

#

i added

#

not work

quaint mantle May 31, 2023, 11:44 PM

#

eternal oxide ok

i mean code working

#

but for to work i need click block inwater

eternal oxide May 31, 2023, 11:45 PM

#

you are on paper then

quaint mantle May 31, 2023, 11:45 PM

#

spigot

eternal oxide May 31, 2023, 11:47 PM

#

I forget what the default is for ignoreCancelled on events

young knoll May 31, 2023, 11:47 PM

#

I believe it’s false

eternal oxide May 31, 2023, 11:47 PM

#

won;t be that then

quaint mantle May 31, 2023, 11:47 PM

#

what i need cancel event ?

eternal oxide May 31, 2023, 11:47 PM

#

no

#

you need more debugs to see what path through yoru code it takes

young knoll May 31, 2023, 11:48 PM

#

young knoll I believe it’s false

It’s false

quaint mantle May 31, 2023, 11:49 PM

#

already u guys know this

#

but i wan't to send

hybrid spoke Jun 1, 2023, 12:03 AM

#

quaint mantle

since when can you smoke water

wise mesa Jun 1, 2023, 12:04 AM

#

I had an idea for using lombok/manifold extension methods but i want to know if its an appropriate use

#

we have a lot of "manager" classes, like party manager, level manager, etc.

#

its a pain to pass all these around, and it'd be nice to use object methods like player.getLevel instead of levelManager.getLevel(player)

#

so I was planning to use have some special player wrapper class

#

like PluginPlayer or whatever

#

that has all those methods

#

and then has .asPlayer()

#

this is all fine

#

the only problem is that it's a pain to go from player to plugin player

#

is it unreasonable to add like a .asPluginPlayer method to the bukkit player interface

remote swallow Jun 1, 2023, 12:06 AM

#

PluginPlayerManager#asPluginPlayer(player)

wise mesa Jun 1, 2023, 12:06 AM

#

not literally but using an extension method

hybrid spoke Jun 1, 2023, 12:07 AM

#

wise mesa is it unreasonable to add like a .asPluginPlayer method to the bukkit player int...

you really dont want to do that

remote swallow Jun 1, 2023, 12:07 AM

#

all the managers

hybrid spoke Jun 1, 2023, 12:07 AM

#

wrapping the playerdata is good

#

then you only need to pass one "manager" around

#

lets name it repository

#

the PluginPlayerRepository f.e.

#

which caches your wrapper instances

young knoll Jun 1, 2023, 12:08 AM

#

I have a lot of managers in my recent plugin

#

Sadly they don’t all connect to a player tho

hybrid spoke Jun 1, 2023, 12:09 AM

#

manager classes are the pure evil

#

you usually dont want to have them

#

and there is most likely a better way to approach what you do

#

despite that "Manager" is an awful suffix

wise mesa Jun 1, 2023, 12:12 AM

#

hybrid spoke manager classes are the pure evil

they really aren't

#

it's more the name than anything

hybrid spoke Jun 1, 2023, 12:12 AM

#

they really are

#

its the reason why it exists

wise mesa Jun 1, 2023, 12:12 AM

#

as long as you give them a more descriptive name

#

i disagree

hybrid spoke Jun 1, 2023, 12:12 AM

#

good for you

wise mesa Jun 1, 2023, 12:12 AM

#

I'm avoiding using static, and using dependency injection to get them into my classes

#

I have to manage state thats built upon builtin classes somehow

hybrid spoke Jun 1, 2023, 12:12 AM

#

why are you avoiding static

wise mesa Jun 1, 2023, 12:13 AM

#

so i can use DI?

#

not all static but static state

hybrid spoke Jun 1, 2023, 12:13 AM

#

singletons are not always wrong

young knoll Jun 1, 2023, 12:13 AM

#


private SpellPartRegistry spellPartRegistry;
    private CustomInventoryManager inventoryManager;
    private ConfigurationManager configurationManager;
    private PlayerManager playerManager;
    private AltarManager altarManager;
    private StorageAdapter storageAdapter;

tragic

hybrid spoke Jun 1, 2023, 12:13 AM

#

also manager classes break so many principles

#

and can overcomplicate your code

carmine mica Jun 1, 2023, 12:13 AM

#

hybrid spoke also manager classes break so many principles

what's a "manager class" in your opinion

hybrid spoke Jun 1, 2023, 12:13 AM

#

once done ugly your code's shit

hybrid spoke Jun 1, 2023, 12:13 AM

#

young knoll ```java private SpellPartRegistry spellPartRegistry; private CustomInventor...

perfect example

wise mesa Jun 1, 2023, 12:13 AM

#

hybrid spoke also manager classes break so many principles

what principles

#

I think they do a much better job of OOP principles than singletons do

#

di all the way

hybrid spoke Jun 1, 2023, 12:14 AM

#

wise mesa what principles

mostly SRP, encapsulation could be, DM, and the lack of abstraction

wise mesa Jun 1, 2023, 12:14 AM

#

how else shall you unit test

young knoll Jun 1, 2023, 12:14 AM

#

Tbf I like singletons

wise mesa Jun 1, 2023, 12:14 AM

#

my managers are all interfaces

young knoll Jun 1, 2023, 12:14 AM

#

But many people disagree

hybrid spoke Jun 1, 2023, 12:14 AM

#

carmine mica what's a "manager class" in your opinion

a class to manage your object

wise mesa Jun 1, 2023, 12:14 AM

#

i do like singletons

#

but I'm avoiding using them because I like unit testing

hybrid spoke Jun 1, 2023, 12:14 AM

#

wise mesa my managers are all interfaces

turn them into services

carmine mica Jun 1, 2023, 12:14 AM

#

talking about OOP... https://github.com/GodCipher/AsyncSpawnMob/blob/master/src/main/java/de/luzifer/asm/config/Variables.java

hybrid spoke Jun 1, 2023, 12:14 AM

#

and voila

wise mesa Jun 1, 2023, 12:14 AM

#

if I were to

young knoll Jun 1, 2023, 12:14 AM

#

young knoll ```java private SpellPartRegistry spellPartRegistry; private CustomInventor...

All of these are basically singletons

hybrid spoke Jun 1, 2023, 12:14 AM

#

carmine mica talking about OOP... <https://github.com/GodCipher/AsyncSpawnMob/blob/master/src...

whats wrong about that

wise mesa Jun 1, 2023, 12:15 AM

#

rename them to BlahBlahBlahService

#

and change nothing about them

#

would that be preferable

hybrid spoke Jun 1, 2023, 12:15 AM

#

ASM is pretty okay done, wouldv'e understood if you would've complained about antiac lmao

hybrid spoke Jun 1, 2023, 12:15 AM

#

wise mesa would that be preferable

depends how they are build up

#

what do they do

#

the architecture is important

wise mesa Jun 1, 2023, 12:16 AM

#

for example LevelManager

#

actually that one's called LevelController

#

because I made it more recently

#

the managers are all old

#

but anyways

#

public interface LevelController {
    /**
     * Gives back the level of the player
     * @param player player to check the level of
     * @return the level of player
     */
    int getPlayerLevel(OfflinePlayer player);

    /**
     * Levels up the player by 1
     * @param player the player to level up
     */
    default void levelUp(OfflinePlayer player) {
        addLevels(player, 1);
    }
    void addLevels(OfflinePlayer player, int amount);

    /**
     * Sets the players level - should be used for like
     * an admin command or something
     * @param player the player to set the level of
     * @param level the level to set the player to
     */
    void setLevel(OfflinePlayer player, int level);
}

hybrid spoke Jun 1, 2023, 12:16 AM

#

for that I would do what you initially said

#

make your own player class which wraps around the UUID of a player storing extra attributes

#

f.e. the level

young knoll Jun 1, 2023, 12:17 AM

#

And then have a manager to keep track of them

hybrid spoke Jun 1, 2023, 12:17 AM

#

not a manager, please

young knoll Jun 1, 2023, 12:17 AM

#

https://tenor.com/view/pepe-laugh-kek-intensifies-kek_intensifies-gif-10111909

Tenor

wise mesa Jun 1, 2023, 12:17 AM

#

I already mentioned that I plan to make a wrapper class

hybrid spoke Jun 1, 2023, 12:18 AM

#

yeah but dont extend or reimplement the bukkit api

wise mesa Jun 1, 2023, 12:18 AM

#

im not doing that

#

i mentioned using lombok extension methods

#

where you add a fake new method to a class

#

which is really just a static method

hybrid spoke Jun 1, 2023, 12:18 AM

#

a fake new method what

idle yacht Jun 1, 2023, 12:18 AM

#

inventory.getViewers().forEach(HumanEntity::closeInventory); inside a sync bukkit tasktimer throws java.util.ConcurrentModificationException: null what am I doing wrong

hybrid spoke Jun 1, 2023, 12:19 AM

#

idle yacht ``inventory.getViewers().forEach(HumanEntity::closeInventory);`` inside a sync b...

yeah because you remove them while looping over them

#

that wont work

wise mesa Jun 1, 2023, 12:19 AM

#

hybrid spoke a fake new method what

sorry lemme rephrase

#

new fake method

#

not fake new method

#

basicallyh

hybrid spoke Jun 1, 2023, 12:19 AM

#

that doesnt change the fact that im confused

idle yacht Jun 1, 2023, 12:19 AM

#

hybrid spoke yeah because you remove them while looping over them

how am I supposed to close their inventories then

hybrid spoke Jun 1, 2023, 12:20 AM

#

idle yacht how am I supposed to close their inventories then

delay it by a tick

young knoll Jun 1, 2023, 12:20 AM

#

Aren’t Lombok extension methods just fancy ways to have a static method

wise mesa Jun 1, 2023, 12:20 AM

#

public static void doACoolThing(Player thizz) {
    // Do something
}

Player player;
player.doACoolThing() // valid

// which is compiled to
doACoolThing(player);

#

its just a way to make static methods look a little nicer

idle yacht Jun 1, 2023, 12:20 AM

#

hybrid spoke delay it by a tick

thats so inconvenient

hybrid spoke Jun 1, 2023, 12:20 AM

#

idle yacht thats so inconvenient

welcome to spigot

#

or better, java.

#

you cant operate on a list while looping over it

carmine mica Jun 1, 2023, 12:21 AM

#

you could just copy the collection too, I think that's better than delaying stuff

young knoll Jun 1, 2023, 12:21 AM

#

You are supposed to delay certain things by a tick in the inventory click event

#

That’s just how the event is

carmine mica Jun 1, 2023, 12:21 AM

#

what event, there was no event given in the context

young knoll Jun 1, 2023, 12:21 AM

#

InventoryClickEvent

#

Idk I was just guessing

idle yacht Jun 1, 2023, 12:21 AM

#

carmine mica you could just copy the collection too, I think that's better than delaying stuf...

🧠 🙏

hybrid spoke Jun 1, 2023, 12:21 AM

#

wise mesa ```java public static void doACoolThing(Player thizz) { // Do something } P...

yeah well no i dont see why you would need something like that

young knoll Jun 1, 2023, 12:23 AM

#

young knoll ```java private SpellPartRegistry spellPartRegistry; private CustomInventor...

So what do I change these all to :p

hybrid spoke Jun 1, 2023, 12:23 AM

#

cant advice without context

idle yacht Jun 1, 2023, 12:24 AM

#

carmine mica what event, there was no event given in the context

so simple yet I didn't think of it, it's time to go to sleep

#

thanks though

idle yacht Jun 1, 2023, 12:24 AM

#

carmine mica you could just copy the collection too, I think that's better than delaying stuf...

i meant to reply to this

#

bruh

young knoll Jun 1, 2023, 12:24 AM

#

hybrid spoke cant advice without context

Fair

#

https://github.com/Jishuna/Spells/blob/master/spells-core/src/main/java/me/jishuna/spells/Spells.java

#

And yes a lot of code is just thrown together atm, don’t question the random try catch in the onEnable for example :p

hybrid spoke Jun 1, 2023, 12:28 AM

#

yeah was about to say, this is all so entangled

worldly ingot Jun 1, 2023, 12:30 AM

#

Exceptions in constructors Kreygasm

hybrid spoke Jun 1, 2023, 12:31 AM

#

there are many things to criticise

young knoll Jun 1, 2023, 12:32 AM

#

I know

#

Not enough async

hybrid spoke Jun 1, 2023, 12:32 AM

#

nah fuck that

worldly ingot Jun 1, 2023, 12:32 AM

#

More async makes everything better

hybrid spoke Jun 1, 2023, 12:32 AM

#

start in the first layer

young knoll Jun 1, 2023, 12:32 AM

#

Exactly

worldly ingot Jun 1, 2023, 12:32 AM

#

Surprised so few of Bukkit's events are async. They should all be!

#

Bukkit would perform so much better!

hybrid spoke Jun 1, 2023, 12:33 AM

#

time to build out the async catcher

river oracle Jun 1, 2023, 12:33 AM

#

SuperDuperAsyncSpigot

young knoll Jun 1, 2023, 12:33 AM

#

Gotta go for that deluxe async multithreaded data driven object oriented uhh

#

<Insert a bunch more buzzwords> code

river oracle Jun 1, 2023, 12:33 AM

#

young knoll Gotta go for that deluxe async multithreaded data driven object oriented uhh

stay

Functional

Because Functional is more catchy nowadays

hybrid spoke Jun 1, 2023, 12:33 AM

#

and it functions better

worldly ingot Jun 1, 2023, 12:33 AM

#

Annotate it with a new annotation, @FunctionalClass. It's like @FunctionalInterface only it's not

hybrid spoke Jun 1, 2023, 12:33 AM

#

methods are functions anyways

#

so why not go functional always

worldly ingot Jun 1, 2023, 12:34 AM

#

Actually just annotate it with a new @Functional annotation instead. That way API users know that the class is working as intended

young knoll Jun 1, 2023, 12:34 AM

#

Is there also a @NonFunctional

river oracle Jun 1, 2023, 12:34 AM

#

worldly ingot Actually just annotate it with a new `@Functional` annotation instead. That way ...

FSpigot

young knoll Jun 1, 2023, 12:35 AM

#

No that’s spigot in F#

worldly ingot Jun 1, 2023, 12:35 AM

#

young knoll Is there also a `@NonFunctional`

That's just any class that isn't annotated with @Functional

hybrid spoke Jun 1, 2023, 12:35 AM

#

here is a good OOP example: https://github.com/GodCipher/the-cipher-project

young knoll Jun 1, 2023, 12:37 AM

#

How do I stop the eye bleeding

hybrid spoke Jun 1, 2023, 12:38 AM

#

not sure

worldly ingot Jun 1, 2023, 12:38 AM

#

A tampon

young knoll Jun 1, 2023, 12:38 AM

#

Eye period

worldly ingot Jun 1, 2023, 12:38 AM

#

Good for nose bleeds, must be good for eyes

river oracle Jun 1, 2023, 12:38 AM

#

young knoll How do I stop the eye bleeding

go to the doctor you probably shouldn't be bleeding from your eyes

young knoll Jun 1, 2023, 12:38 AM

#

Note to self

#

Get tampons for nose bleeds

river oracle Jun 1, 2023, 12:38 AM

#

young knoll Get tampons for nose bleeds

no no

hybrid spoke Jun 1, 2023, 12:38 AM

#

tried to catch the blood with your eyelids?

river oracle Jun 1, 2023, 12:39 AM

#

I feel like a pad would be more effective

young knoll Jun 1, 2023, 12:39 AM

#

It’s too late the Amazon drone is already here

river oracle Jun 1, 2023, 12:39 AM

#

FUCK

#

well

young knoll Jun 1, 2023, 12:40 AM

#

Yeah idk I notice all my recent projects have a lot of managers to pass around

#

That’s probably the biggest issue

river oracle Jun 1, 2023, 12:40 AM

#

young knoll Yeah idk I notice all my recent projects have a lot of managers to pass around

Managers 😭

#

the most annoying thing

#

jesus I just make a ManagerManagerBuilder and call it a day

young knoll Jun 1, 2023, 12:40 AM

#

Yeah but like what else do I useeeee

ivory sleet Jun 1, 2023, 12:40 AM

#

young knoll Yeah idk I notice all my recent projects have a lot of managers to pass around

its not that big of an issue

young knoll Jun 1, 2023, 12:41 AM

#

Ah yes a ManagerManager

hybrid spoke Jun 1, 2023, 12:41 AM

#

just a tiny big issue

young knoll Jun 1, 2023, 12:41 AM

#

Why didn’t I think of that

river oracle Jun 1, 2023, 12:41 AM

#

young knoll Why didn’t I think of that

tut tut, you also need a ManagerManagerBuilder for teh cool pattern

ivory sleet Jun 1, 2023, 12:41 AM

#

like sometimes compromising design for usability (like with managers) may be justifiable

young knoll Jun 1, 2023, 12:41 AM

#

I mean technically they are all accessible from the main class so I could just pass that to everything

#

https://tenor.com/view/dog-smile-gif-21913178

Tenor

river oracle Jun 1, 2023, 12:42 AM

#

💀

#

don't hurt me

hybrid spoke Jun 1, 2023, 12:42 AM

#

chunk them together to a ManagerBundle

river oracle Jun 1, 2023, 12:42 AM

#

frrr ^

hybrid spoke Jun 1, 2023, 12:42 AM

#

have that in your main class

#

and pass your main class around

#

get.get.get.get

young knoll Jun 1, 2023, 12:42 AM

#

Exactly

hybrid spoke Jun 1, 2023, 12:43 AM

#

before i knew what i was doing, and i still dont, i made infinite sub classes in my class to have a this.class.doesthat.cando.with.cool.shit effect.takethispath.andyes.store

river oracle Jun 1, 2023, 12:44 AM

#

hybrid spoke before i knew what i was doing, and i still dont, i made infinite sub classes in...

?paste

undone axleBOT Jun 1, 2023, 12:44 AM

#

https://paste.md-5.net/

hybrid spoke Jun 1, 2023, 12:44 AM

#

i dont think i have that anymore

#

was in 2013 or whatever

young knoll Jun 1, 2023, 12:45 AM

#

Maybe I’ll just convert some of them to singletons

#

Idfk

hybrid spoke Jun 1, 2023, 12:45 AM

#

first of all work at the names

river oracle Jun 1, 2023, 12:45 AM

#

just be glad you didn't write this https://paste.md-5.net/xatehosuru.java

#

I had to come in and fix this code when the dev before me got fired

hybrid spoke Jun 1, 2023, 12:45 AM

#

then SRP, then untie the knots

#

and after all that refactorating you can think of how do i get that in this class

young knoll Jun 1, 2023, 12:46 AM

#

We have singletons but what about doubletons

#

Exactly 2 instances exist

hybrid spoke Jun 1, 2023, 12:46 AM

#

Pair sadly got removed

young knoll Jun 1, 2023, 12:47 AM

#

This is why you keep all your code closed source, then nobody can judge it

hybrid spoke Jun 1, 2023, 12:47 AM

#

river oracle just be glad you didn't write this https://paste.md-5.net/xatehosuru.java

whatever you will tell chatgpt, it wont be able to reproduce that

#

thats for sure

young knoll Jun 1, 2023, 12:47 AM

#

Unless they decompile it, in which case you can just blame it on the decompiler

#

https://tenor.com/view/think-about-it-use-your-brain-use-the-brain-think-brain-gif-7914082

Tenor

hybrid spoke Jun 1, 2023, 12:48 AM

#

young knoll This is why you keep all your code closed source, then nobody can judge it

good business dont need good code

#

it just have to work

#

f.e. twitter algo

young knoll Jun 1, 2023, 12:48 AM

#

Pretty much

#

If it’s stupid and it works

#

Then it still makes money

hybrid spoke Jun 1, 2023, 12:48 AM

#

never change only add

river oracle Jun 1, 2023, 12:49 AM

#

It may not be good, but it needs to be maintainable

#

if I can't add to it its shit code

#

non functional

hybrid spoke Jun 1, 2023, 12:49 AM

#

you always can add

#

if not force add with reflection or bytecode manipulation

river oracle Jun 1, 2023, 12:49 AM

#

hybrid spoke you always can add

How are you supposed to add when you have 30 singletons overlapping the same responsability? its nearly impossible

young knoll Jun 1, 2023, 12:49 AM

#

Just try harder

hybrid spoke Jun 1, 2023, 12:49 AM

#

add a singleton

#

make it 31

ancient plank Jun 1, 2023, 12:50 AM

#

code debt go brrrr

young knoll Jun 1, 2023, 12:50 AM

#

Takes less time to add more garbage than it does to clean up garbage

river oracle Jun 1, 2023, 12:50 AM

#

?paste

undone axleBOT Jun 1, 2023, 12:50 AM

#

https://paste.md-5.net/

river oracle Jun 1, 2023, 12:50 AM

#

https://paste.md-5.net/soriliqowu.java

#

this is my equivalent

#

not perfect, but better and you can add to it

river oracle Jun 1, 2023, 12:51 AM

#

young knoll Takes less time to add more garbage than it does to clean up garbage

i spent 1 week redoing the entire game engine versus spending 3 weeks learning how tf it works 🤷‍♂️ in my situation redoing it was definitely easier

hybrid spoke Jun 1, 2023, 12:51 AM

#

only thing

#

why does it need a gameprofile

#

and not just directly a player or whatever

river oracle Jun 1, 2023, 12:52 AM

#

hybrid spoke why does it need a gameprofile

thats not a mojang thing

#

its a internal impl of something

hybrid spoke Jun 1, 2023, 12:52 AM

#

ohhhhh so they just named it stupid

river oracle Jun 1, 2023, 12:52 AM

#

😭 rude asf man, but yeah makes sense lol

hybrid spoke Jun 1, 2023, 12:52 AM

#

oh then

#

you just named it stupid

#

copy that

river oracle Jun 1, 2023, 12:53 AM

#

yep I did, but we don't use mojang code in the game engine so its fine 😎

young knoll Jun 1, 2023, 12:54 AM

#

Clearly it should be PlayerProfile

hybrid spoke Jun 1, 2023, 12:54 AM

#

why do names never have an S in it

#

PlayersGameProfile

young knoll Jun 1, 2023, 12:54 AM

#

PlayersGamesProfiles

worldly ingot Jun 1, 2023, 12:54 AM

#

Just a convention to avoid pluralization

hybrid spoke Jun 1, 2023, 12:55 AM

#

choco, respectfully, no.

worldly ingot Jun 1, 2023, 12:55 AM

#

Only reasonable case to use a plural class name would be for a class containing constants or utility methods

young knoll Jun 1, 2023, 12:55 AM

#

Enums are constants

#

Pluralize them

worldly ingot Jun 1, 2023, 12:56 AM

#

Enums contain constants but are data types

hybrid spoke Jun 1, 2023, 12:56 AM

#

worldly ingot Only reasonable case to use a plural class name would be for a class containing ...

well yeah no, same for collections or grouping

worldly ingot Jun 1, 2023, 12:56 AM

#

Collections is a utility class

young knoll Jun 1, 2023, 12:56 AM

#

org.bukkit.Materials

compact haven Jun 1, 2023, 12:57 AM

#

Or something made to hold multiples

worldly ingot Jun 1, 2023, 12:57 AM

#

So is Arrays, or Utils (I hate this naming convention, but technically valid)

compact haven Jun 1, 2023, 12:57 AM

#

for example I have a class ILoadoutItems because it's the wrapper of a Map

#

(it's not actually wrapping a Map but the result is similar)

hybrid spoke Jun 1, 2023, 12:57 AM

#

Managers to group manager classes

young knoll Jun 1, 2023, 12:57 AM

#

Quick someone judge him for using the I prefix

worldly ingot Jun 1, 2023, 12:57 AM

#

compact haven for example I have a class ILoadoutItems because it's the wrapper of a Map

I would even avoid it here. LoadoutEquipment, LoadoutSet, or even just Loadout would be better

young knoll Jun 1, 2023, 12:58 AM

#

IAbstractAsyncLoadout

hybrid spoke Jun 1, 2023, 12:59 AM

#

the good old Listeners class

worldly ingot Jun 1, 2023, 12:59 AM

#

pepecringe

young knoll Jun 1, 2023, 12:59 AM

#

I feel attacked

#

Well

#

Me from 5 years ago feels attacked but still

compact haven Jun 1, 2023, 1:02 AM

#

I mean, I don't see the problem with plurals

remote swallow Jun 1, 2023, 1:02 AM

#

Why does 19 ur old coll feel attacked

compact haven Jun 1, 2023, 1:02 AM

#

if it feels right then I do it

#

the reason I have prefixed my interfaces with I here is because I wanted it to be clear that it isnt the implementation, because I'm providing both

#

(albeit under different class names)

#

ILoadoutItems is only provided anonymously, though my others have default implementations

young knoll Jun 1, 2023, 1:05 AM

#

Something tells me people will disagree on design choices throughout all of time and space

compact haven Jun 1, 2023, 1:05 AM

#

definitely

hybrid spoke Jun 1, 2023, 1:05 AM

#

young knoll Something tells me people will disagree on design choices throughout all of time...

i disagree

worldly ingot Jun 1, 2023, 1:05 AM

#

I disagree >:(

#

okay

hybrid spoke Jun 1, 2023, 1:05 AM

#

L

young knoll Jun 1, 2023, 1:05 AM

#

Alright well

worldly ingot Jun 1, 2023, 1:06 AM

#

first of all, fuck you

#

second, nice

young knoll Jun 1, 2023, 1:06 AM

#

Choco and cipher are the same person

#

Confirmed

compact haven Jun 1, 2023, 1:06 AM

#

bro wait a minute

#

wtf is this bullshit

#

why there an automatic new line after my end class brackets

#

i know its convention but like in C or some bs

ancient plank Jun 1, 2023, 1:07 AM

#

I can't think of any classes where I've named them with plural words

compact haven Jun 1, 2023, 1:07 AM

#

I have an IKitsConfig and YamlKitsConfig in the same project

#

but that isnt really "plural"

#

its plural but only in the adjective

#

not the noun

hybrid spoke Jun 1, 2023, 1:08 AM

#

Credentials

ancient plank Jun 1, 2023, 1:08 AM

#

I have some, but it's "Utils"

compact haven Jun 1, 2023, 1:08 AM

#

oh wtf

#

there's 2 immediately I can think of in the Java stdlib

#

stop making trouble

#

Collectors and Collections

hybrid spoke Jun 1, 2023, 1:08 AM

#

i avoid using them because they are plurals

compact haven Jun 1, 2023, 1:08 AM

#

aint no way 💀

#

bro doesn't use streams or immutable collections

ancient plank Jun 1, 2023, 1:09 AM

#

though recently I've been typing out "Utility" instead of Utils

hybrid spoke Jun 1, 2023, 1:10 AM

#

oh i also have a class called TaskForce1

ancient plank Jun 1, 2023, 1:12 AM

#

nope I've got nothin, no (recent) projects where a class name is plural

young knoll Jun 1, 2023, 1:12 AM

#

Just make them all plural

#

Problem solved

hazy parrot Jun 1, 2023, 1:13 AM

#

compact haven Collectors and Collections

It's because first is class which contains multiple static collectors and other is also utility method for collections

#

Those are not really any kind of instance classes

hybrid spoke Jun 1, 2023, 1:13 AM

#

oh so i can start using them?

hazy parrot Jun 1, 2023, 1:13 AM

#

It's fine ig

hybrid spoke Jun 1, 2023, 1:14 AM

#

how do i instantiate them

young knoll Jun 1, 2023, 1:14 AM

#

Kek

#

I’ll just get ChatGPT to write all my code

#

If it writes it then it can’t be bad

hybrid spoke Jun 1, 2023, 1:16 AM

#

automate it and force chatgpt to check itself 10 times

young knoll Jun 1, 2023, 1:16 AM

#

See because a computer can’t write bad code that will be run on another computer

#

That’s like, poisoning someone

#

And that’s illegal

hybrid spoke Jun 1, 2023, 1:17 AM

#

cannibalism

#

or something like that

sharp bough Jun 1, 2023, 1:27 AM

#

is it possible to listen when a fence updates visually? for example a player places a block next to a fence and this updates connecting to this block, or a player places a fence and this updates connecting to nearby blocks?
i have tried using BlockPhysicsEvent but it didnt work as expected

#

i have also checked out NMS to try and capture the package that updates the fence, but didnt get it to work

#

using 1.19+ java

#

public void onBlockPhysics(BlockPhysicsEvent event) {
        Block block = event.getBlock();
        if (block.getType() == Material.COBBLESTONE_WALL || block.getType() == Material.MOSSY_COBBLESTONE_WALL) {
            event.setCancelled(true);
        }
    }
``` this kinda works but its quite buggy

worldly ingot Jun 1, 2023, 1:31 AM

#

Yeah I think physics is the only one that would be fired in this instance

sharp bough Jun 1, 2023, 1:32 AM

#

but that means theres a deaper level with packages, something is changing that fence

#

something somewhere is udpating that fence because a new block was placed

young knoll Jun 1, 2023, 1:33 AM

#

I think the internal method is called updateStateForNeighbours

#

When a block is placed it notifies all neighbouring blocks which can then react however they see fit

wet breach Jun 1, 2023, 2:27 AM

#

young knoll When a block is placed it notifies all neighbouring blocks which can then react ...

Blocks and chunks

candid kindle Jun 1, 2023, 2:55 AM

#

Is this static abuse?

opaque scarab Jun 1, 2023, 3:16 AM

#

Anyone know how to properly rotate a display entity to set degrees on XYZ using the setTranslation method?

pliant wind Jun 1, 2023, 3:29 AM

#

Is the only way to change the required spawning light level for mob spawners through nms?

wise mesa Jun 1, 2023, 4:35 AM

#

is it possible to get an offline player by name if they've been on the server before

#

using their previously known name

#

I don't want the server asking mojang or anything in the middle of a tick

#

Bukkit.getOfflinePlayer(string) is deprecated and idk if there's anything better for this

#

this is for commands

#

I don't want it to run a blocking io call

#

if its to the hard drive that's fine if its to the network it isn't

quaint mantle Jun 1, 2023, 4:39 AM

#

<plugin>#getServer#getOfflinePlayer isnt deprecated

wise mesa Jun 1, 2023, 4:42 AM

#

yes it is

#

getOfflinePlayer with string is

#

with uuid isn't

#

but I am trying to get it with their name

quaint mantle Jun 1, 2023, 4:43 AM

#

It isnt deprecated for me

wise mesa Jun 1, 2023, 4:43 AM

#

I want those using the command to be able to type the name of the player

#

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Server.html#getOfflinePlayer(java.lang.String)

Server (Spigot-API 1.19.4-R0.1-SNAPSHOT API)

declaration: package: org.bukkit, interface: Server

quaint mantle Jun 1, 2023, 4:44 AM

#

In intellaJ it isnt saying deprecated, also it being deprecated doesnt matter

#

The reasoning is because "Persistent storage of users should be by UUID as names are no longer unique past a single session."

#

If you are not planning on accessing users too far into the future after they logged off then its fine

#

also they are correct, you should use UUID and not username since usernames are not unique after a session is ended

wise mesa Jun 1, 2023, 4:45 AM

#

did you read my usecase though?

#

I'm writing a command

#

my users are not going to check people's uuid's then they want to refer to them

quaint mantle Jun 1, 2023, 4:45 AM

#

Then use the username

#

Did you read my message?

quaint mantle Jun 1, 2023, 4:45 AM

#

quaint mantle If you are not planning on accessing users too far into the future after they lo...

^

wise mesa Jun 1, 2023, 4:45 AM

#

yes I did

quaint mantle Jun 1, 2023, 4:45 AM

#

Obviously not

wise mesa Jun 1, 2023, 4:45 AM

#

it just seems like you contradicted yourself

#

when you put that last part

quaint mantle Jun 1, 2023, 4:46 AM

#

Not at all

wise mesa Jun 1, 2023, 4:46 AM

#

you said that its okay for me to not use uuid

#

and then you said that I should use uuid

quaint mantle Jun 1, 2023, 4:46 AM

#

not a contridiction

wise mesa Jun 1, 2023, 4:46 AM

#

well anyways

#

I knew all of this

quaint mantle Jun 1, 2023, 4:46 AM

#

a contridiction would be me saying its okay to use uuid then to say its not okay to use uuid

wise mesa Jun 1, 2023, 4:46 AM

#

what I wanted to know is if there's a method that won't potentially make a blocking web request

quaint mantle Jun 1, 2023, 4:46 AM

#

I said you should use uuid, I never stated its not okay to use uuid thus I never contridicted myself

wise mesa Jun 1, 2023, 4:46 AM

#

quaint mantle a contridiction would be me saying its okay to use uuid then to say its not okay...

dawg that's just how I interpreted at first

#

because I was reading quickly

quaint mantle Jun 1, 2023, 4:47 AM

#

Double check your reading before you blame people then :/

lethal coral Jun 1, 2023, 4:47 AM

#

        MiniMessage miniMessage = MiniMessage.miniMessage();
        Player target = player;
        if (args.length > 0) {
            target = Bukkit.getPlayer(args[0]);
            if (target == null) {
                player.sendMessage(miniMessage.deserialize("<red>The referenced player was not found."));
                return;
            }
        }

I have this code in like 8 classes for commands to get an optional player argument. I've considered making this a method but even then I feel like it won't really reduce the amount of code in the method? any ideas?

wise mesa Jun 1, 2023, 4:48 AM

#

quaint mantle Double check your reading before you blame people then :/

im just sleepy maaannnn

#

like your username lol

quaint mantle Jun 1, 2023, 4:48 AM

#

fairs

#

also Hexic, you can make that if statement only 1 or 2 lines

wise mesa Jun 1, 2023, 4:49 AM

#

lethal coral ```java MiniMessage miniMessage = MiniMessage.miniMessage(); Pla...

if you're writing it again and again

#

in exactly the same way

#

then it'd probably be nice to have

#

as a method

quaint mantle Jun 1, 2023, 4:49 AM

#

Id say its better if he just simplifies it into 1 line then make a method but its his choice

wise mesa Jun 1, 2023, 4:49 AM

#

like what if you want to change that and then you have to change all 8 (and likely soon to be more) versions of it

lethal coral Jun 1, 2023, 4:49 AM

#

quaint mantle Id say its better if he just simplifies it into 1 line then make a method but it...

how would you simplify that to one line??

wise mesa Jun 1, 2023, 4:51 AM

#

well you could get rid of the first if

lethal coral Jun 1, 2023, 4:51 AM

#

wise mesa like what if you want to change that and then you have to change all 8 (and like...

right

wise mesa Jun 1, 2023, 4:51 AM

#

oh wait nvm

lethal coral Jun 1, 2023, 4:51 AM

#

wise mesa well you could get rid of the first if

no because it's optional

wise mesa Jun 1, 2023, 4:51 AM

#

that won't work

#

yea yea

#

wait no it will

quaint mantle Jun 1, 2023, 4:51 AM

#

oh okay well you cant do statement && return like in js so its 3 lines

wise mesa Jun 1, 2023, 4:51 AM

#

just gotta slightly modify my idea

#

Player target = args.length > 0 ? Bukkit.getPlayer(args[0]) : player;

#

there's your one liner

#

and then just check if target is null

quaint mantle Jun 1, 2023, 4:52 AM

#

if (args.length > 0 && Bukkit.getPlayer(args[0]) == null) {
  player.sendMessage();
  return true;};

lethal coral Jun 1, 2023, 4:53 AM

#

that never sets the target variable

wise mesa Jun 1, 2023, 4:53 AM

#

wise mesa ```java Player target = args.length > 0 ? Bukkit.getPlayer(args[0]) : player; ``...

edited

quaint mantle Jun 1, 2023, 4:53 AM

#

wise mesa ```java Player target = args.length > 0 ? Bukkit.getPlayer(args[0]) : player; ``...

oh mb I thought you use just checking if it was a player

#

(wrong reply)

wise mesa Jun 1, 2023, 4:53 AM

#

lol

lethal coral Jun 1, 2023, 4:54 AM

#

wise mesa and then just check if target is null

yeah then I have to reset it to the player

quaint mantle Jun 1, 2023, 4:54 AM

#

wise mesa ```java Player target = args.length > 0 ? Bukkit.getPlayer(args[0]) : player; ``...

this looks good but it doesnt check if its a player or not so you will have to check the target value to be null after
edit: im dumb you said that

wise mesa Jun 1, 2023, 4:54 AM

#

lethal coral yeah then I have to reset it to the player

no?

lethal coral Jun 1, 2023, 4:54 AM

#

yes if it's null

#

or no actually I'm throwing

wise mesa Jun 1, 2023, 4:54 AM

#

yea

lethal coral Jun 1, 2023, 4:54 AM

#

cause that's not what I want here

wise mesa Jun 1, 2023, 4:54 AM

#

or returning or something

lethal coral Jun 1, 2023, 4:54 AM

#

yeah

wise mesa Jun 1, 2023, 4:54 AM

#

my statement is exactly the same as the code you already have

#

without the second if statement

#

not exactly

#

but similar enough

lethal coral Jun 1, 2023, 4:55 AM

#

I'm still gonna have repeated code though

wise mesa Jun 1, 2023, 4:55 AM

#

move it to a function

lethal coral Jun 1, 2023, 4:55 AM

#

I'll make it work and come back

wise mesa Jun 1, 2023, 4:55 AM

#

wonderful

#

good luck

lethal coral Jun 1, 2023, 4:55 AM

#

🫡

split gull Jun 1, 2023, 4:58 AM

#

omg hapily

lethal coral Jun 1, 2023, 4:59 AM

#

hi jake

lethal coral Jun 1, 2023, 4:59 AM

#

wise mesa good luck

ok here's the problem

#

I have the method to get the player argument right

#

then I check if it's null in the execute method and then send them a response and stop the execute method right then and there

#

but that's what

#

4 lines

#

of repeated code

#

which is equal to what I already have

#

or actually like 1 line less

quaint mantle Jun 1, 2023, 5:02 AM

#

just make a method which takes in the args and the executing player then do all the checks and messages in the method, return either true of false and then do if (!method(args, executor)) return true;;

wet breach Jun 1, 2023, 5:03 AM

#

lethal coral then I check if it's null in the execute method and then send them a response an...

Just use offline player

quaint mantle Jun 1, 2023, 5:04 AM

#

I think he needs it to be an online player (im assuming)

lethal coral Jun 1, 2023, 5:04 AM

#

yes

wet breach Jun 1, 2023, 5:04 AM

#

Why?

quaint mantle Jun 1, 2023, 5:04 AM

#

does it matter?

wet breach Jun 1, 2023, 5:04 AM

#

Yes

quaint mantle Jun 1, 2023, 5:04 AM

#

no not really

lethal coral Jun 1, 2023, 5:04 AM

#

cause the operations I'm performing on the player are them being there

quaint mantle Jun 1, 2023, 5:04 AM

#

if he needs it to be an online player then he needs it to be an online player, doesnt matter to us what for

wet breach Jun 1, 2023, 5:05 AM

#

quaint mantle if he needs it to be an online player then he needs it to be an online player, d...

Well that is your opinion. But if i provide help i try to steer to best practices and usages

quaint mantle Jun 1, 2023, 5:06 AM

#

I assume he knows enough to know whether he needs a player to be online or offline to perform the desired action on them :/

#

I get where your coming from but it just doesnt apply here

wet breach Jun 1, 2023, 5:07 AM

#

If you understand then everything you said was pointless as it will not change how i provide help

#

I dont make assumptions and therefore why i ask questions of their code

quaint mantle Jun 1, 2023, 5:07 AM

#

I do not need to change how you provide help to get my point across

lethal coral Jun 1, 2023, 5:07 AM

#

quaint mantle just make a method which takes in the args and the executing player then do all ...

I have literally zero clue what you mean

wet breach Jun 1, 2023, 5:09 AM

#

lethal coral I have literally zero clue what you mean

What are you making and what issues are you having?

lethal coral Jun 1, 2023, 5:09 AM

#

commands and the issue I'm having is repeated code

wet breach Jun 1, 2023, 5:09 AM

#

So i can understand better and provide appropriate input if able lol

quaint mantle Jun 1, 2023, 5:10 AM

#

lethal coral I have literally zero clue what you mean

Alright so, make a method that takes in 2 arguments, one being the args from the command and one being the sender (or player), then inside the method check for the args length, check for the player and whatever other checks you need, if all checks pass return true in the method, if any check fails use the sender arg to send them a message about it then in the method return false, Back in your command code check whether the method returned true of false by if (!methodName(args, sender)) return true;
(i dont know your level in java so incase you dont know the !method() in the if statement is a replacement for doing method() == false)

wet breach Jun 1, 2023, 5:10 AM

#

lethal coral commands and the issue I'm having is repeated code

Mind elaborating on the commands part?

#

Depending on what you are doing i may have some example code for you

lethal coral Jun 1, 2023, 5:11 AM

#

quaint mantle Alright so, make a method that takes in 2 arguments, one being the `args` from t...

I'm gonna have to call Bukkit#getPlayer(String) twice

quaint mantle Jun 1, 2023, 5:11 AM

#

Why?

lethal coral Jun 1, 2023, 5:11 AM

#

to assign the variable

#

!paste

wet breach Jun 1, 2023, 5:11 AM

#

Well i guess i can show you how i do commands

lethal coral Jun 1, 2023, 5:11 AM

#

?paste

undone axleBOT Jun 1, 2023, 5:11 AM

#

https://paste.md-5.net/

quaint mantle Jun 1, 2023, 5:12 AM

#

Is it allowed to feed code in this server or no?

lethal coral Jun 1, 2023, 5:12 AM

#

https://paste.md-5.net/ikapeserox.java base command
https://paste.md-5.net/xesuyazoka.java example subcommand

#

that's what I have rn

wet breach Jun 1, 2023, 5:12 AM

#

lethal coral !paste

https://github.com/frostalf/ServerTutorial/tree/master/ServerTutorial/src/main/java/pw/hwk/tutorial/commands

GitHub

ServerTutorial/ServerTutorial/src/main/java/pw/hwk/tutorial/command...

Bukkit Plugin for in-game player tutorials. Contribute to frostalf/ServerTutorial development by creating an account on GitHub.

#

This is how i setup my commands

quaint mantle Jun 1, 2023, 5:13 AM

#

Hes not having issues with creating commands

lethal coral Jun 1, 2023, 5:13 AM

#

I know how to make commands I'm using my own command system

wet breach Jun 1, 2023, 5:13 AM

#

I typically make use of sub commands unless it doesnt make sense to

quaint mantle Jun 1, 2023, 5:13 AM

#

Please leave us be for now frost

quaint mantle Jun 1, 2023, 5:13 AM

#

quaint mantle Is it allowed to feed code in this server or no?

^ yes/no?

wet breach Jun 1, 2023, 5:13 AM

#

lethal coral I know how to make commands I'm using my own command system

Maybe not, but it sounds like your system isnt very well designed if your issue is repeated code though

round finch Jun 1, 2023, 5:13 AM

#

wet breach https://github.com/frostalf/ServerTutorial/tree/master/ServerTutorial/src/main/j...

*note to myself look at this later then got time

wet breach Jun 1, 2023, 5:13 AM

#

So it may help to see how others do it

lethal coral Jun 1, 2023, 5:14 AM

#

wet breach Maybe not, but it sounds like your system isnt very well designed if your issue ...

it doesn't handle argument parsing or whatever like brigadier

wet breach Jun 1, 2023, 5:14 AM

#

Oh you want tab completions

quaint mantle Jun 1, 2023, 5:14 AM

#

wet breach Maybe not, but it sounds like your system isnt very well designed if your issue ...

Hes issue is repeated code when checking if the arg input is a player in commands

lethal coral Jun 1, 2023, 5:14 AM

#

it's just made to be a little bit better than BukkitCommand (commandmap way of registering commands, not plugin.yml) and does like half of the things for you

quaint mantle Jun 1, 2023, 5:15 AM

#

wet breach Oh you want tab completions

Tab completions dont force the given argument (from what ive seen)

wet breach Jun 1, 2023, 5:16 AM

#

quaint mantle Hes issue is repeated code when checking if the arg input is a player in command...

Well this isnt difficult, if it must only be online players to match then you can do this by grabbing a map from the collection with the player names as keys.

quaint mantle Jun 1, 2023, 5:17 AM

#

Tab completions do not force the argument to match them (from what ive seen)

#

It doesnt matter if you give the end user all the options if they can input something else to break it

#

Passing completions does not fix his issue unless there is a way to force the completions as the only accepted arguments which I do not know about if there is

wet breach Jun 1, 2023, 5:18 AM

#

Well you can provide possible completions as they type but you cant force the completion as that is client side

quaint mantle Jun 1, 2023, 5:18 AM

#

Exactly my point

#

so please

#

leave us be since you are not helping

#

I appreciate the efforts but it will only cause more confusion

wet breach Jun 1, 2023, 5:19 AM

#

Then go to dms if you dont like public forums

quaint mantle Jun 1, 2023, 5:19 AM

#

I am more then welcome to have him privatly message me if he so prefers

wet breach Jun 1, 2023, 5:20 AM

#

Then it seems it isnt solely your decision

quaint mantle Jun 1, 2023, 5:20 AM

#

I politely asked you to please refrain from trying to help since what you are saying could only cause more confusion

#

I am not making any choices for anyone I am simple suggesting something

#

You are not forced to listen but it would be more helpful if you did

wet breach Jun 1, 2023, 5:21 AM

#

Sure everyone here is free to do so. But you suggesting someone to not talk is not constructive either

quaint mantle Jun 1, 2023, 5:21 AM

#

@lethal coral im sorry about this, we can continue this here or in dms whichever you would prefer

lethal coral Jun 1, 2023, 5:21 AM

#

idrc but in-case anybody else runs into the problem maybe here

quaint mantle Jun 1, 2023, 5:22 AM

#

Alrighty!

#

Here ill write some example code to show you what I mean with explanations

wet breach Jun 1, 2023, 5:23 AM

#

You both failed to explain the situation adequately. But in either case it seems their problem isnt all that trivial if they are looking to not repeat code

quaint mantle Jun 1, 2023, 5:24 AM

#

I understand his problem perfectly

#

Please refrain from speaking if you wish to help

#

moving on

wet breach Jun 1, 2023, 5:24 AM

#

quaint mantle Please refrain from speaking if you wish to help

Always want to hush people lol

quaint mantle Jun 1, 2023, 5:25 AM

#

I only hush people whose input is not needed

wet breach Jun 1, 2023, 5:25 AM

#

And you are in a public space

quaint mantle Jun 1, 2023, 5:25 AM

#

I still have the right to express my opinion as much as you do

wet breach Jun 1, 2023, 5:25 AM

#

Do you need reminding again?

quaint mantle Jun 1, 2023, 5:25 AM

#

I have the right to express my opinion as much as you do

wet breach Jun 1, 2023, 5:26 AM

#

Never said otherwise

quaint mantle Jun 1, 2023, 5:26 AM

#

I do not have to listen to you and you do not have to listen to me

#

Speaking of which I am now going to ignore you since this conversation has no positive effect on anything relating to spigot, spigot developers or any developers in general

wet breach Jun 1, 2023, 5:26 AM

#

Sure doesnt bother me in the least

#

Anyways time to look at the pastes

#

To see what they are saying in regards to repeated code

quaint mantle Jun 1, 2023, 5:31 AM

#

lethal coral idrc but in-case anybody else runs into the problem maybe here

I think personally in this situation the repeated code for checking if the player input is valid is not an issue since the repeated code is necessary and even if you made it into a method it would still require a few lines to set the target variable

Player Target = Bukkit.getPlayer(<username>);
if (args.length == 0 && Target == null) {
  <executing_player>.sendMessage(<message>)
  return true;
}

Would be your best bet, <username> being the provided username, <executing_player> being a reference to the player running the command and <message> being the message you want to send to them for inputing an invalid player
I am no means an expert but I personally dont think repeated code in this sort of context is bad for the reasons above

wet breach Jun 1, 2023, 5:35 AM

#

That piece of code seems fine and is similar to what others suggested. I dont see how this is repeated code unless they are referring in that they dont want to repeat that code in all their sub commands. If that is the case then move it either to the main class or to its own class. If its something expected to run all the time probably wise to make such methods static regardless where its at.

#

This would be the only way to avoid repeating such code and keeping it optimal

quaint mantle Jun 1, 2023, 5:36 AM

#

Yes they meant they didnt want that code in other commands/subcommands but even if you made it a method in a main class it would still use 2-3 lines just to check the method and assign the target variable

wet breach Jun 1, 2023, 5:37 AM

#

I would say use recursion but i probably wouldnt recommend it in case simply for the fact it seems it may get used too much and recursion can be bad for that somtimes lol

wet breach Jun 1, 2023, 5:37 AM

#

quaint mantle Yes they meant they didnt want that code in other commands/subcommands but even ...

Yes this true, but this shouldnt be a concern in regards to creating a function

#

Purpose of a function is repeated use, not how many lines the function needs

quaint mantle Jun 1, 2023, 5:39 AM

#

He already implied before that he didnt think it was worth it if it already used the same amount of lines

wet breach Jun 1, 2023, 5:39 AM

#

I hope their concern wasnt how large the method function would be?

wet breach Jun 1, 2023, 5:39 AM

#

quaint mantle He already implied before that he didnt think it was worth it if it already used...

It is if it has repeated use. It would also help the jit optimize better

quaint mantle Jun 1, 2023, 5:39 AM

#

lethal coral I have the method to get the player argument right

here

wet breach Jun 1, 2023, 5:39 AM

#

Hope that answers their concern in regards to that

#

Also the other advantage is that if something is wrong with it or it needs tweaking

#

Instead of changing that repeated code in however many command classes you only have a central point for it

quaint mantle Jun 1, 2023, 5:41 AM

#

I dont feel like a check for user input being a player would change that much

wet breach Jun 1, 2023, 5:41 AM

#

In fact this code would fit perfectly in a utility class where you could override it if necessary

wet breach Jun 1, 2023, 5:43 AM

#

quaint mantle I dont feel like a check for user input being a player would change that much

I doubt it, but its how the end result is obtained. It would be beneficial if that piece of code you gave was in its own method and then that method used where its needed

#

Sometimes 3 lines of code may seem insignificant but if you actually trace all those objects and methods back to where they come from as well as understand how the jvm and jit try to optimize. Then those 3 lines becomes clear that they are not as insignificant as you assumed them to be

#

One of the main objectives in objective programming is object reuse and code reuse

lethal coral Jun 1, 2023, 5:46 AM

#

quaint mantle I think personally in this situation the repeated code for checking if the playe...

args.length can't be 0 otherwise there is no player arg

quaint mantle Jun 1, 2023, 5:47 AM

#

sorry yes

lethal coral Jun 1, 2023, 5:47 AM

#

and I gotta check the length is greater than 0 before trying to do Bukkit#getPlayer(String)

quaint mantle Jun 1, 2023, 5:47 AM

#

I copied the part of code from my plugin

#

I meant > not ==

lethal coral Jun 1, 2023, 5:47 AM

#

but I would still have to extract that if before

wet breach Jun 1, 2023, 5:48 AM

#

So if you are able to reuse code that means put it in its own method and many things can use it, then this is generally the best choice

lethal coral Jun 1, 2023, 5:48 AM

#

otherwise I would get a potential indexoutofbounds exception

lethal coral Jun 1, 2023, 5:48 AM

#

wet breach So if you are able to reuse code that means put it in its own method and many th...

yes I would do that if I could

#

but I can't because I have to set the variable and in certain circumstances also stop the code

#

so I thought of throwing an exception

#

but even then I would have to have a try catch and then it doesn't reduce anything really

wet breach Jun 1, 2023, 5:48 AM

#

lethal coral but I can't because I have to set the variable and in certain circumstances also...

Which variable?

#

The player?

lethal coral Jun 1, 2023, 5:49 AM

#

the target variable

#

yes

wet breach Jun 1, 2023, 5:49 AM

#

That is easy

#

Use a default

lethal coral Jun 1, 2023, 5:49 AM

#

I do that

wet breach Jun 1, 2023, 5:49 AM

#

Default should be the same as the player doing the command in this manner its never null and easier to check

lethal coral Jun 1, 2023, 5:49 AM

#

yes I have that already

wet breach Jun 1, 2023, 5:49 AM

#

Alright i think that covers setting the variable

lethal coral Jun 1, 2023, 5:50 AM

#

no

wet breach Jun 1, 2023, 5:50 AM

#

Then i think you misunderstand a default

lethal coral Jun 1, 2023, 5:50 AM

#

I don't

wet breach Jun 1, 2023, 5:50 AM

#

If there is a default variable is always set

lethal coral Jun 1, 2023, 5:50 AM

#

what I'm saying is I have to set the variable to the argument

wet breach Jun 1, 2023, 5:51 AM

#

Alright, and why is it that a function couldnt do that part for you?

#

There is more pieces. You can feed a function any number of objects you want and with recent java versions you can even use optionals

#

Is the issue at hand in trying to make the function return what you are wanting?

lethal coral Jun 1, 2023, 5:55 AM

#

ok frostalf

#

I think you should give this a go yourself

#

and explain to me what you did to improve it

#

so I can learn

wet breach Jun 1, 2023, 5:57 AM

#

Well i think we need to work out the part where you say a function wouldnt work, because i am failing to see how it wouldnt. At least given my knowledge in how objects and methods work.

#

The piece of code to check for a player for example can be returned in 3 different ways for example

#

The code above that is

lethal coral Jun 1, 2023, 5:58 AM

#

yes frostalf we are not understanding each other

flint coyote Jun 1, 2023, 5:58 AM

#

Since this seems to go for a while already - where's the code?

lethal coral Jun 1, 2023, 5:59 AM

#

so if you give it a try maybe you will understand what I'm trying to say

wet breach Jun 1, 2023, 5:59 AM

#

You could return a boolean, return a string, return a player object and the 4th is returning nothing but instead setting something aka void method

lethal coral Jun 1, 2023, 5:59 AM

#

flint coyote Since this seems to go for a while already - where's the code?

https://paste.md-5.net/ikapeserox.java base command
https://paste.md-5.net/xesuyazoka.java example sub command
I have the optional player argument getting part repeated in like 8 classes

#

and we cannot seem to figure out how to effectively reduce the code repetition

flint coyote Jun 1, 2023, 6:00 AM

#

Usually you can trust on frostalf's advice. I just wanted to take a look because you two seem to not be on the same track

wet breach Jun 1, 2023, 6:01 AM

#

flint coyote Usually you can trust on frostalf's advice. I just wanted to take a look because...

We are not, but as i said i think this is mostly due to our differing experience and knowledge in where they are trying to convey a problem that i cant see as a problem

lethal coral Jun 1, 2023, 6:01 AM

#

the code is repeated

#

intellij yells at me

#

it looks bad

flint coyote Jun 1, 2023, 6:01 AM

#

if (args.length > 0) {
            target = Bukkit.getPlayer(args[0]);
            if (target == null) {
                player.sendMessage(miniMessage.deserialize("<red>The referenced player was not found."));
                return;
            }
        }

That part?

lethal coral Jun 1, 2023, 6:01 AM

#

yes perfect and the Player target = player;'

wet breach Jun 1, 2023, 6:03 AM

#

Well it was suggested to be moved to main class or its own class and you feed the method what it needs. So in this case i would recommend the constructor taking in a command, and spitting out a command.

#

And it would be the first thing your commands go through

#

Then you can interact with it however you want

#

If further interaction is needed

lethal coral Jun 1, 2023, 6:05 AM

#

see that sounds great in theory but I just tried to connect the bridges in my head and they didn't connect

wet breach Jun 1, 2023, 6:05 AM

#

Fantastic, we have identified the problem then

lethal coral Jun 1, 2023, 6:05 AM

#

no we did not

wet breach Jun 1, 2023, 6:06 AM

#

lethal coral see that sounds great in theory but I just tried to connect the bridges in my he...

This right here is the problem and we can work with this

lethal coral Jun 1, 2023, 6:06 AM

#

idk I think we're going to run into problems pretty quickly

wet breach Jun 1, 2023, 6:07 AM

#

For me to properly help with this particular problem i need to be at my computer. Currently at work on a phone and its not adequate. Unless maybe fabsi here understands and can demonstrate

wary topaz Jun 1, 2023, 6:08 AM

#

proof im tired

flint coyote Jun 1, 2023, 6:09 AM

#

What frostalf is suggesting would work but I can understand how that's hard to understand for devs without years of experience.
And simpler approach would be to have a function with the args array and the commandsender and then sending the message & returning null or returning the target player.

Would reduce the repeated code to

Player target = getTarget(player, args)
if(target == null) return;

wary topaz Jun 1, 2023, 6:10 AM

#

if ((Player target = getTarget(player, args)) == null) return;

flint coyote Jun 1, 2023, 6:11 AM

#

wet breach For me to properly help with this particular problem i need to be at my computer...

What I don't fully understand at this point is what you want to return. An instance of SimuXCommand?
Do you want to call your method before actually going into the execution?

lethal coral Jun 1, 2023, 6:13 AM

#

flint coyote What frostalf is suggesting would work but I can understand how that's hard to u...

it would still be only 1 line less

#

that idea was proposed earlier

flint coyote Jun 1, 2023, 6:13 AM

#

flint coyote What I don't fully understand at this point is what you want to return. An insta...

As I don't know the command framework that is used here I'm not aware if that's actually possible.

lethal coral Jun 1, 2023, 6:13 AM

#

but it's still repeated code

flint coyote Jun 1, 2023, 6:13 AM

#

Well a function call is one "repeated" line aswell

lethal coral Jun 1, 2023, 6:13 AM

#

sure

wet breach Jun 1, 2023, 6:14 AM

#

flint coyote What frostalf is suggesting would work but I can understand how that's hard to u...

Your idea might be better or just as good too

flint coyote Jun 1, 2023, 6:14 AM

#

Unless that command framework has some function where you put code to run before every command - then there's actually 0 repeated code

wary topaz Jun 1, 2023, 6:15 AM

#

whats a good yaml editor?

lethal coral Jun 1, 2023, 6:15 AM

#

flint coyote What frostalf is suggesting would work but I can understand how that's hard to u...

this would actually be

Player target = getTarget(player, args);
if (target == null) {
  player.sendMessage("error");
  return;
}

which I suppose is a bit better but nonetheless 💀

wet breach Jun 1, 2023, 6:15 AM

#

Repeated code doesnt include function calls. Because otherwise how are you suppose to call the function, the only way to have this not be the case is if the initial entry was the function to begin with

flint coyote Jun 1, 2023, 6:15 AM

#

you can send the error inside your function aswell

wary topaz Jun 1, 2023, 6:15 AM

#

if ((Player target = getTarget(player, args)) == null) return;

lethal coral Jun 1, 2023, 6:15 AM

#

ig

flint coyote Jun 1, 2023, 6:16 AM

#

that's why I put the player in there in the first place

wet breach Jun 1, 2023, 6:16 AM

#

wary topaz if ((Player target = getTarget(player, args)) == null) return;

Condensing it like that isnt exactly the overall point lol but very nice regardless

lethal coral Jun 1, 2023, 6:16 AM

#

well no the player has to be in there to be able to set it to the player possibly anyways

wet breach Jun 1, 2023, 6:17 AM

#

My idea earlier was on the basis of initial entry point, but fabsi did bring up a good point that it does depend on your framework

flint coyote Jun 1, 2023, 6:18 AM

#

Oh. I overlooked that part.
In that case you would have to return the player itself if the args length is 0 instead of null

#

maybe you did that already

wet breach Jun 1, 2023, 6:18 AM

#

flint coyote Oh. I overlooked that part. In that case you would have to return the player its...

I suggested this already as well

onyx fjord Jun 1, 2023, 6:18 AM

#

Optionals are cool

wet breach Jun 1, 2023, 6:18 AM

#

Maybe i am just too advanced to help

#

Am i really that knowledgeable that i cant help right now with something like this? Lol

wary topaz Jun 1, 2023, 6:19 AM

#

public boolean isNull(String[] args) {
return Bukkit.getPlayer(args[0]) == null;
}

#

if (isNull) return true;

flint coyote Jun 1, 2023, 6:20 AM

#

wet breach Maybe i am just too advanced to help

No don't feel like that - you are just abstracting a lot of steps at once. Beginner or Intermediate dev will have a hard time understanding that

onyx fjord Jun 1, 2023, 6:20 AM

#

Why not accept argument as the argument

#

@wary topaz

wary topaz Jun 1, 2023, 6:20 AM

#

you could do that too

hybrid spoke Jun 1, 2023, 6:20 AM

#

wet breach Am i really that knowledgeable that i cant help right now with something like th...

you're just too old

wary topaz Jun 1, 2023, 6:20 AM

#

im just giving an example

hybrid spoke Jun 1, 2023, 6:20 AM

#

you are not funky enough anymore

wet breach Jun 1, 2023, 6:20 AM

#

hybrid spoke you're just too old

I am inclined to believe this but fabsi's response is better

hybrid spoke Jun 1, 2023, 6:21 AM

#

what even is the problem

#

and what are the brought solutions

wet breach Jun 1, 2023, 6:21 AM

#

hybrid spoke you are not funky enough anymore

Maybe you are to something here

onyx fjord Jun 1, 2023, 6:21 AM

#

duke

wet breach Jun 1, 2023, 6:22 AM

#

hybrid spoke and what are the brought solutions

They are having trouble understanding how to abstract a piece of code in their command that will have repeated use and turn it into a function

flint coyote Jun 1, 2023, 6:22 AM

#

@lethal coral

private Player getTarget(Player player, String[] args) {
  if(args.length == 0) return player;
  Player target = Bukkit.getPlayer(args[0]);
  if(target == null) {
    player.sendMessage(miniMessage.deserialize("<red>The referenced player was not found."));
  }
  return target;
}

Something along those lines should do the job. Just don't forget the null check when you call it.

wet breach Jun 1, 2023, 6:22 AM

#

Their other issue is when doing so how to handle errors or other problems with said abstracted code

lethal coral Jun 1, 2023, 6:23 AM

#

I didn't need that but thank you

wary topaz Jun 1, 2023, 6:23 AM

#

https://paste.ethannetwork.net/ayiloserej.cpp https://paste.ethannetwork.net/utokurenag.typescript

The file is not getting its contents saved

#

I do not know why

lethal coral Jun 1, 2023, 6:23 AM

#

flint coyote <@450812718728085505> ```java private Player getTarget(Player player, String[] ...

minimessage coming in from the void

#

🚎

wary topaz Jun 1, 2023, 6:24 AM

#

public void saveConfig(FileConfiguration config, String configName) { try { config.save(new File(plugin.getDataFolder(), configName)); } catch (IOException e) { logError("Error while saving config,", e); } } If you want to know

hybrid spoke Jun 1, 2023, 6:24 AM

#

wet breach They are having trouble understanding how to abstract a piece of code in their c...

ah i see

flint coyote Jun 1, 2023, 6:24 AM

#

lethal coral 🚎

Am I too old to understand that joke?

hybrid spoke Jun 1, 2023, 6:24 AM

#

flint coyote Am I too old to understand that joke?

🚋

lethal coral Jun 1, 2023, 6:25 AM

#

flint coyote Am I too old to understand that joke?

the trolley?

flint coyote Jun 1, 2023, 6:25 AM

#

Or did I not sleep enough? lol

onyx fjord Jun 1, 2023, 6:25 AM

#

Haha lmfao

#

😂😂😂😂😂

hybrid spoke Jun 1, 2023, 6:25 AM

#

lethal coral the trolley?

🛒

lethal coral Jun 1, 2023, 6:25 AM

#

hybrid spoke 🛒

🚲

hybrid spoke Jun 1, 2023, 6:25 AM

#

lethal coral 🚲

woah, outstanding move??

onyx fjord Jun 1, 2023, 6:25 AM

#

🐗 hihiha

wary topaz Jun 1, 2023, 6:25 AM

#

fixed

hybrid spoke Jun 1, 2023, 6:25 AM

#

YOU ACTIVATED MY TRAP CARD 🚙

flint coyote Jun 1, 2023, 6:26 AM

#

I'm confused

onyx fjord Jun 1, 2023, 6:26 AM

#

GG

wet breach Jun 1, 2023, 6:26 AM

#

flint coyote <@450812718728085505> ```java private Player getTarget(Player player, String[] ...

Just return player from the constructor if target is null

lethal coral Jun 1, 2023, 6:26 AM

#

flint coyote I'm confused

I can't use external emojis so that's my replacement for the troll emoji

#

and it makes no sense so ha funny

onyx fjord Jun 1, 2023, 6:26 AM

#

🧌

#

Check this one out

wary topaz Jun 1, 2023, 6:26 AM

#

02:26:02] [Server thread/WARN]: java.io.FileNotFoundException: plugins\BetterServer\playerdata\homes (Access is denied)

but the file is there

lethal coral Jun 1, 2023, 6:26 AM

#

bad troll emoji

flint coyote Jun 1, 2023, 6:26 AM

#

Now I'm speechless

hybrid spoke Jun 1, 2023, 6:27 AM

#

wary topaz 02:26:02] [Server thread/WARN]: java.io.FileNotFoundException: plugins\BetterSer...

access is denied

onyx fjord Jun 1, 2023, 6:27 AM

#

Did you know GitHub has a real trollface

wet breach Jun 1, 2023, 6:27 AM

#

wary topaz 02:26:02] [Server thread/WARN]: java.io.FileNotFoundException: plugins\BetterSer...

Check perms and also check spellings and caps

wary topaz Jun 1, 2023, 6:27 AM

#

might be spelling

flint coyote Jun 1, 2023, 6:27 AM

#

wet breach Just return player from the constructor if target is null

Well then you would get an error that the player was not found and then set your own gamemode. That's rather confusing

onyx fjord Jun 1, 2023, 6:27 AM

#

Tf is that path

flint coyote Jun 1, 2023, 6:28 AM

#

hybrid spoke *access is denied*

you name it. Did you create that file with another user? Might have to use chmod to enable access

wary topaz Jun 1, 2023, 6:28 AM

#

public void saveConfig(FileConfiguration config, String configName) { try { config.save(new File(plugin.getDataFolder(), configName)); } catch (IOException e) { e.printStackTrace(); } }

this is the file saver

wet breach Jun 1, 2023, 6:28 AM

#

flint coyote Well then you would get an error that the player was not found and then set your...

Well you would check the return to ensure what is returned isnt the same. If it is dont do anything

wary topaz Jun 1, 2023, 6:28 AM

#

plugin.getFileApi().saveConfig(getConfig(player, plugin), "/playerdata/homes");

this is how I called it

#

https://paste.ethannetwork.net/ulefubagab.java
is the getConfig

hybrid spoke Jun 1, 2023, 6:29 AM

#

wet breach Well you would check the return to ensure what is returned isnt the same. If it ...

i would rather use an optional and fail if its not present in the end

onyx fjord Jun 1, 2023, 6:29 AM

#

That path looks absolute

wet breach Jun 1, 2023, 6:30 AM

#

hybrid spoke i would rather use an optional and fail if its not present in the end

Yeah you could do that too. I dont use optionals much but forget they are there lol

flint coyote Jun 1, 2023, 6:31 AM

#

I only ever use optionals because streams provide them on findFirst() to which I just go with orElse(null) to create fancy one-liners that probably everyone will hate when seeing them.

wet breach Jun 1, 2023, 6:31 AM

#

Lol

hybrid spoke Jun 1, 2023, 6:31 AM

#

optionals are cool and all but also very annoying if overused

#

but once you design your shit optional based its over

glossy venture Jun 1, 2023, 6:34 AM

#

.map(value -> /* ... */)
.orElse(default);
``` is pretty nice tho

tardy delta Jun 1, 2023, 6:34 AM

#

Optional.None when

glossy venture Jun 1, 2023, 6:35 AM

#

Optional.empty()?

tardy delta Jun 1, 2023, 6:35 AM

#

Cant afford An if check at Runtime 💀

hybrid spoke Jun 1, 2023, 6:35 AM

#

Optional != null

wet breach Jun 1, 2023, 6:35 AM

#

lethal coral I didn't need that but thank you

I hope this was a good learning experience in that sometimes the issue is your understanding and not necessarily the code. Which i hope helps you to better convey problems in the future and to not assume when others are asking questions its not due to lack of experience but rather trying to grasp what is really the problem. As you seen for someone like me, it can be hard to convey the solution if i dont know your level of understanding and knowledge and inadvertently tell you things that seem impossible or make no sense

tardy delta Jun 1, 2023, 6:35 AM

#

Those icons back?

wet breach Jun 1, 2023, 6:36 AM

#

Thought i should put that out there

flint coyote Jun 1, 2023, 6:36 AM

#

             currentField = actionFields.stream()
                     .filter(field -> {
                         String configKey = field.getAnnotation(ConfigurableValue.class).configKey();
                         if (configKey.isBlank()) {
                             configKey = field.getName();
                         }
                         return configKey.equals(fieldName);
                     })
                     .findFirst()
                     .orElse(null);
            if (currentField == null) {
                continue;
            }

The more I code the more I use streams and the less readable the code gets :(

lethal coral Jun 1, 2023, 6:36 AM

#

wet breach I hope this was a good learning experience in that sometimes the issue is your u...

I never said it was a problem with the code

#

if it was the compiler's fault I wouldn't have come here

hybrid spoke Jun 1, 2023, 6:37 AM

#

wet breach I hope this was a good learning experience in that sometimes the issue is your u...

frostalf playing god rn

#

thats my role

lethal coral Jun 1, 2023, 6:37 AM

#

and I also didn't say you lacked experience which is why I told you to give me an example so we could bridge the gap between what you were saying

wet breach Jun 1, 2023, 6:37 AM

#

Well regardless i hope you learned something nonetheless

wet breach Jun 1, 2023, 6:38 AM

#

hybrid spoke thats my role

Oh my bad. Seemed like something that should be said

echo basalt Jun 1, 2023, 6:40 AM

#

catlurk

wet breach Jun 1, 2023, 6:43 AM

#

lethal coral and I also didn't say you lacked experience which is why I told you to give me a...

While true you did end up saying this, the other issue is i couldnt provide you with an example in more ways then one. The major one was me failing to grasp the level of understanding you had or your experience level. And also could be that i typically dont spoonfeed code more so if i dont know if you would understand it. But yeah seems like you are getting the proper help now. And with that i have some work to do

#

So sorry i couldnt do that

#

And i need to learn to not be so abstract as well it seems

hybrid spoke Jun 1, 2023, 6:46 AM

#

signal writing a novel rn

wet breach Jun 1, 2023, 6:46 AM

#

Ok signal here is killling me

#

Been waiting for their message lmao

hybrid spoke Jun 1, 2023, 6:47 AM

#

wet breach While true you did end up saying this, the other issue is i couldnt provide you ...

looks like an ego problem to me.

wet breach Jun 1, 2023, 6:47 AM

#

hybrid spoke looks like an ego problem to me.

Is it?

flint coyote Jun 1, 2023, 6:47 AM

#

Seeing you reflecting yourself like that hurts my feelings frostalf. What you did or suggested wasn't bad at all. Sure he wasn't quite understanding what you said but that's neither yours nor his fault. You suggested what came to your mind based on your knowledge. He could have asked for a simpler solution - he chose to try to understand what you suggested. You both did a great job and none of you should feel bad at this point ♥️

echo basalt Jun 1, 2023, 6:47 AM

#

y'all both having a mental breakdown over misjudging someone

hybrid spoke Jun 1, 2023, 6:47 AM

#

wet breach Is it?

looks like it

elfin pilot Jun 1, 2023, 6:47 AM

#

Optimization question. I have a large set of data used for a wide variety of items, mechanics, and dialogue ingame (stat blocks, requirement lists, that sort of thing.) Sadly, the data can't be hard-coded, I can explain more if needed, but I retrieve it from an SQL server using a String object, but I'm puzzling over what to do next.
My question is, which is better: to deserialize into one giant JsonObject that we can pull from? Or separate into multiple smaller, different JsonObjects?
Assume the data is going to be accessed at random by different players and game elements (we might need to reference a stat-block when spawning a mob, for example.) Which is better? Or should I be approaching this in a different way?

hybrid spoke Jun 1, 2023, 6:47 AM

#

ahh there it is

elfin pilot Jun 1, 2023, 6:47 AM

#

hybrid spoke signal writing a novel rn

Lmfao sorry

wet breach Jun 1, 2023, 6:48 AM

#

echo basalt y'all both having a mental breakdown over misjudging someone

I dont have mental break downs

hybrid spoke Jun 1, 2023, 6:48 AM

#

not yet

echo basalt Jun 1, 2023, 6:48 AM

#

elfin pilot Optimization question. I have a large set of data used for a wide variety of ite...

You only want to fetch the data you need

hybrid spoke Jun 1, 2023, 6:48 AM

#

elfin pilot Optimization question. I have a large set of data used for a wide variety of ite...

for that you have microservices

echo basalt Jun 1, 2023, 6:48 AM

#

Fetching one giant json object is just going to spike your RAM usage

elfin pilot Jun 1, 2023, 6:48 AM

#

Perfect

#

Thank you

#

So it'd be better to create multiple smaller ones for what we need

echo basalt Jun 1, 2023, 6:49 AM

#

And your CPU for processing that json

#

Correct

wet breach Jun 1, 2023, 6:49 AM

#

hybrid spoke not yet

I dont think i ever will but i will be poking your brain later on the looks of it being ego cause i dont see it

echo basalt Jun 1, 2023, 6:49 AM

#

Same reason we use multiple individual player files when dealing with file-based storage instead of making a giant one

elfin pilot Jun 1, 2023, 6:49 AM

#

Perfect. Thank you!

quaint mantle Jun 1, 2023, 6:53 AM

#

Guys what plugin do you use for custom GUIs?

hybrid spoke Jun 1, 2023, 6:53 AM

#

wet breach I dont think i ever will but i will be poking your brain later on the looks of i...

long story short: you think too much of yourself, at least it looks like it. thats why you behave in a rather abstract way. you do not trust the person looking for help enough to understand your help because of your experience. so you only have one solution for them. not sure how to say it in english, but you arent staying at the same eye level with the OP

hybrid spoke Jun 1, 2023, 6:53 AM

#

quaint mantle Guys what plugin do you use for custom GUIs?

#help-server 🤔

#

or do you mean like a lib

echo basalt Jun 1, 2023, 6:54 AM

#

quaint mantle Guys what plugin do you use for custom GUIs?

if you mean a lib, I just make my own stuff for everything

quaint mantle Jun 1, 2023, 6:56 AM

#

I tried CommandPanels but i don t know how to configure it

hybrid spoke Jun 1, 2023, 6:57 AM

#

hybrid spoke <#741875845089722499> 🤔

^^

tardy delta Jun 1, 2023, 6:58 AM

#

https://www.spigotmc.org/threads/a-modern-approach-to-inventory-guis.594005/

SpigotMC - High Performance Minecraft

Resource - A modern approach to inventory GUIs

Introduction

The creation of inventory GUIs is a big topic in the spigot developer community and often butchered by inexperienced devs. This is ok...

flint coyote Jun 1, 2023, 6:58 AM

#

hybrid spoke long story short: you think too much of yourself, at least it looks like it. tha...

That's pretty harsh. I'd say the problem is just being used to people that join this discord, basically learned nothing but System.out.println("Hello world"); and ask how to code Facebook as a spigot plugin (this is an exaggeration but you get the point).
I also have to evaluate each developers on whether helping them would be reasonable or would lead to spoonfeeding

tardy delta Jun 1, 2023, 6:59 AM

#

coding facebook would just be easy :)

hybrid spoke Jun 1, 2023, 7:00 AM

#

flint coyote That's pretty harsh. I'd say the problem is just being used to people that join ...

no, thats victim blaming. well, kinda. its pretty much possible to help people and help them, or try to understand them, without taking the position way above their head. you don't have to put people down or tell them how bad they are compared to you. thats all im saying

flint coyote Jun 1, 2023, 7:00 AM

#

if(!facebook.isPresent()) {
  createFacebook();
}

tardy delta Jun 1, 2023, 7:01 AM

#

facebook.orElseGet smh

flint coyote Jun 1, 2023, 7:01 AM

#

hybrid spoke no, thats victim blaming. well, kinda. its pretty much possible to help people a...

But that's not what he did

hybrid spoke Jun 1, 2023, 7:01 AM

#

indirectly, yes.

hybrid spoke Jun 1, 2023, 7:01 AM

#

hybrid spoke frostalf playing god rn

also the reason for my comment here

#

im a fan of satire if you didnt noticed yet

flint coyote Jun 1, 2023, 7:02 AM

#

He provided a solution that was hard to understand but I doubt he did that to "play god". More like because he's used to solve his own problems like that.

hybrid spoke Jun 1, 2023, 7:02 AM

#

i dont want to boo anyone. he asked what i see, and i told him. what he does with it is not my beer

hybrid spoke Jun 1, 2023, 7:03 AM

#

flint coyote He provided a solution that was hard to understand but I doubt he did that to "p...

which could be the case, but we dont know, since he didnt delivered it like that. the tone plays the music, or whatever

#

therefore we have ?learnjava

#

so, ive shown enough humanity. y'all suck noobs

flint coyote Jun 1, 2023, 7:05 AM

#

exactly that is the reason I'm not always motivated to help.
As long as I notice the person on the other side is trying their best and is listening to feedback instead of saying "but chatgpt said that's better" I'm willing to help.
If "you don't have enough knowledge to achieve X yet and should start with Y" makes them mad then I'm out

sour folio Jun 1, 2023, 7:05 AM

#

                String coordkey = loreLine.substring(19);
                int length = pigsection.getInt(coordkey + ".length");
                long expiration = pigsection.getLong(coordkey + ".expiration") - System.currentTimeMillis();
                int amount = pigsection.getInt(coordkey + ".amount");
                long experience = pigsection.getLong(coordkey + ".experiance") - System.currentTimeMillis();

                if(e.getCurrentItem().getType() == PLAYER_HEAD) {
                    double moneytogivepercent = (((100.0 - (((double)expiration / length) * 100.0)) / 100.0));
                    if (moneytogivepercent <= 100 && moneytogivepercent > 0.005) {
                        double moneytogive = ((moneytogivepercent) * amount) * pigmake;
                        String playerName = p.getName();
                        String moneycmd = "economy give " + playerName + " " + moneytogive;
                        Bukkit.dispatchCommand(Bukkit.getConsoleSender(), moneycmd);
                        pigsection.set(coordkey + ".expiration", System.currentTimeMillis() + 14400000);

                    }else if(moneytogivepercent  < 0.005){
                        p.sendMessage(ChatColor.RED + "You need to have the GENERATOR at least 0.5% full before claiming");
                    } else {
                        double moneytogive = pigmake * amount;
                        String playerName = p.getName();
                        String moneycmd = "economy give " + playerName + " " + moneytogive;
                        Bukkit.dispatchCommand(Bukkit.getConsoleSender(), moneycmd);
                        pigsection.set(coordkey + ".expiration", System.currentTimeMillis() + 14400000);

                    }``` When the 'amount' is less tham 1,000,000 this works fine, but as soon as it goes abouve 1M it stops working, any ideas?

hybrid spoke Jun 1, 2023, 7:05 AM

#

?paste please

undone axleBOT Jun 1, 2023, 7:05 AM

#

https://paste.md-5.net/

hybrid spoke Jun 1, 2023, 7:07 AM

#

never said that

#

and couldnt care less

sour folio Jun 1, 2023, 7:07 AM

#

hybrid spoke ?paste please

https://paste.md-5.net/logupiviku.cpp

flint coyote Jun 1, 2023, 7:08 AM

#

Some people just join this discord and pretend that we are forced to help them. Nobody here has a contract or gets paid to do so. And if you are unfriendly and unable to deal with feedback then it's quite obvious that people don't like to help

half bane Jun 1, 2023, 7:08 AM

#

How do I define and get maps/dictionaries in config.yml

onyx fjord Jun 1, 2023, 7:09 AM

#

flint coyote Some people just join this discord and pretend that we are forced to help them. ...

So I'm the only one forced

hybrid spoke Jun 1, 2023, 7:09 AM

#

sour folio https://paste.md-5.net/logupiviku.cpp

i have no idea what that does. elaborate it a bit

flint coyote Jun 1, 2023, 7:09 AM

#

onyx fjord So I'm the only one forced

If you force yourself, sure

flint coyote Jun 1, 2023, 7:10 AM

#

half bane How do I define and get maps/dictionaries in config.yml

map:
  key1: value1
  key2: value2
```The standard yaml way basically

wet breach Jun 1, 2023, 7:10 AM

#

hybrid spoke long story short: you think too much of yourself, at least it looks like it. tha...

Imteresting. Thanks

half bane Jun 1, 2023, 7:11 AM

#

flint coyote ```yaml map: key1: value1 key2: value2 ```The standard yaml way basically

So it's the same. But how do I get the list of keys so I can turn it into map?

hybrid spoke Jun 1, 2023, 7:12 AM

#

wet breach Imteresting. Thanks

gladly again

flint coyote Jun 1, 2023, 7:12 AM

#

It's a configurationSection. You can iterate it and turn it into a map. You might be able to cast it directly aswell.

wet breach Jun 1, 2023, 7:12 AM

#

flint coyote exactly that is the reason I'm not always motivated to help. As long as I notice...

I think the issue was that they believed they understood and really didnt and therefore insisting it being some other problem

half bane Jun 1, 2023, 7:12 AM

#

flint coyote It's a configurationSection. You can iterate it and turn it into a map. You migh...

oh thanks

wet breach Jun 1, 2023, 7:14 AM

#

hybrid spoke gladly again

Social interactions are not always my forte so i really do appreciate that feedback

flint coyote Jun 1, 2023, 7:15 AM

#

wet breach I think the issue was that they believed they understood and really didnt and th...

I only followed the last ~10-20% of that conversation. And there they said that you are probably not understanding each other which was right in this case.
Both of you probably thought the other side does not understand the problem/solution. It was a misunderstanding and that's a common thing. I really feel like both of you did nothing wrong. Besides that your solution required quite deep knowledge - which isn't always a problem.

wet breach Jun 1, 2023, 7:16 AM

#

flint coyote I only followed the last ~10-20% of that conversation. And there they said that ...

Yeah once i realized that was the case it was just trying to figure out that misunderstanding lol

#

One of these days i will make educational videos

hybrid spoke Jun 1, 2023, 7:21 AM

#

do spigot tutorials

lethal coral Jun 1, 2023, 7:22 AM

#

is it static abuse if it's a utility class

#

🚎

flint coyote Jun 1, 2023, 7:22 AM

#

Not if you also have a private constructor and therefore make it a "real" utility class that does not hold a state

echo basalt Jun 1, 2023, 7:23 AM

#

.

lethal coral Jun 1, 2023, 7:23 AM

#

😡

hybrid spoke Jun 1, 2023, 7:23 AM

#

he's trying to be funny

echo basalt Jun 1, 2023, 7:23 AM

#

when in doubt

lethal coral Jun 1, 2023, 7:24 AM

#

echo basalt .

yeah I get all that

#

I just forgot the private constructor

flint coyote Jun 1, 2023, 7:24 AM

#

It's basically a glorified map

#

I wasn't sure about that anymore which is why I said might

tardy delta Jun 1, 2023, 7:25 AM

#

reflections 🙏

lethal coral Jun 1, 2023, 7:26 AM

#

shouldn't the utility class throw an exception in the private constructor

#

and in the singleton as well if it's not null

#

no I'm saying for A singleton

#

in their example code

flint coyote Jun 1, 2023, 7:27 AM

#

And then we end up with the same problems as the SimpleDateFormat

#

https://www.callicoder.com/java-simpledateformat-thread-safety-issues/

CalliCoder

Java's SimpleDateFormat is not thread-safe, Use carefully in multi-...

The SimpleDateFormat class in Java is not thread-safe. You should either create separate instances of SimpleDateFormat for every thread, or synchronize concurrent access by multiple threads with a synchronized keyword or a lock.

echo basalt Jun 1, 2023, 7:27 AM

#

I do throw it in the constructor

#

for the singleton

#

for utility class it's whatever

lethal coral Jun 1, 2023, 7:27 AM

#

oh the getInstance being on top of the constructor was throwing me off

#

I'm blind

flint coyote Jun 1, 2023, 7:27 AM

#

Therefore if avoidable at any cost don't make a static (especially utility) class have a state :/

#

Why would a static utility class have a usable constructor?

#

You said it doesn't have to be private

lethal coral Jun 1, 2023, 7:29 AM

#

the world also doesn't need mosquitos

#

but here we are

flint coyote Jun 1, 2023, 7:30 AM

#

Yeah sure but what's the point?
You could also name your classes MY_CLASS_FOR_COMMANDS because you SHOULD go with conventions

#

And why would I not teach conventions in #help-development ?

#

Oh that's not how my sentence was meant. I just wanted to be clear that there should be no state and a private constructor. Not that the private constructor makes it stateless

#

Yeah I see why

#

Also birds eat them, too

lethal coral Jun 1, 2023, 7:35 AM

#

guys come on

#

mosquitos suck rocks

flint coyote Jun 1, 2023, 7:35 AM

#

I still hate ticks more than mosquitos

lethal coral Jun 1, 2023, 7:35 AM

#

replace em with something that doesn't suck blood and make us itch

#

😬

flint coyote Jun 1, 2023, 7:35 AM

#

No open air concerts in the evening for you ig

#

🤷‍♂️ nobody asking for help atm

#

And I can't work either because I have to wait for 800 integration tests to run

hybrid spoke Jun 1, 2023, 7:37 AM

#

flint coyote 🤷‍♂️ nobody asking for help atm

help

flint coyote Jun 1, 2023, 7:38 AM

#

?ask

undone axleBOT Jun 1, 2023, 7:38 AM

#

If you have a question, please just ask it. Don't look for staff or topic experts. Don't ask to ask or ask if people are awake or available. Just ask the question to the channel straight out, and wait patiently for a reply. Make sure you use the right channel regarding the topic of your question. Create a thread in case the channel is already in use!

flint coyote Jun 1, 2023, 7:38 AM

#

jk

hybrid spoke Jun 1, 2023, 7:38 AM

#

undone axle If you have a question, please just ask it. Don't look for staff or topic expert...

thanks

undone axleBOT Jun 1, 2023, 7:38 AM

#

antm#7677 definitely regrets to for the most part inform you that unfortunately, they essentially are unable to definitely assist with definitely your enquiry, which essentially is fairly significant. Please simply really ask again later or possibly kind of ask someone else about this enquiry, demonstrating that the person that ran this command generally regrets to kind of inform you that unfortunately, they for the most part are unable to generally assist with actually your enquiry in a subtle way. Thank you very sort of much for kind of your time and the person that ran this command specifically wishes you a really good day, so the person that ran this command really regrets to actually inform you that unfortunately, they literally are unable to definitely assist with very your enquiry, or so they particularly thought.

flint coyote Jun 1, 2023, 7:38 AM

#

To get this back to something programming related:
Do you guys actually write unit/integration tests for your plugins? I can't be the only lazy one

tardy delta Jun 1, 2023, 7:38 AM

#

nah

hybrid spoke Jun 1, 2023, 7:38 AM

#

never

#

let your customers test it

tardy delta Jun 1, 2023, 7:39 AM

#

i just fix it if smth doesnt seem to work 💀

flint coyote Jun 1, 2023, 7:39 AM

#

Not even my biggest plugins have a single test

tardy delta Jun 1, 2023, 7:39 AM

#

no tests needed

hybrid spoke Jun 1, 2023, 7:39 AM

#

wouldnt test spigot logic anyways

tardy delta Jun 1, 2023, 7:40 AM

#

imagine finding spigot bugs while testing

flint coyote Jun 1, 2023, 7:40 AM

#

undone axle antm#7677 definitely regrets to for the most part inform you that unfortunately,...

wtf is this

#

sounds like what I would get when I asked chatgpt to write the most unreadable explanation of a simple term

flint coyote Jun 1, 2023, 7:42 AM

#

tardy delta imagine finding spigot bugs while testing

Imagine spending hours to write tests when I could have developed 10 new features in the same time

tardy delta Jun 1, 2023, 7:42 AM

#

facts

#

i let chatgpt write half of my testcases

flint coyote Jun 1, 2023, 7:42 AM

#

Tests make sense when multiple people work on a single project and there's no "single-point-of-truth" as in someone who's fully aware of all code reviewing everything

hybrid spoke Jun 1, 2023, 7:43 AM

#

flint coyote wtf is this

?cba

undone axleBOT Jun 1, 2023, 7:43 AM

#

Luzifer#0666 definitely regrets to for the most part inform you that unfortunately, they essentially are unable to definitely assist with definitely your enquiry, which essentially is fairly significant. Please simply really ask again later or possibly kind of ask someone else about this enquiry, demonstrating that the person that ran this command generally regrets to kind of inform you that unfortunately, they for the most part are unable to generally assist with actually your enquiry in a subtle way. Thank you very sort of much for kind of your time and the person that ran this command specifically wishes you a really good day, so the person that ran this command really regrets to actually inform you that unfortunately, they literally are unable to definitely assist with very your enquiry, or so they particularly thought.

flint coyote Jun 1, 2023, 7:44 AM

#

Wait you are God and the Devil at the same time

#

That's confusing

hybrid spoke Jun 1, 2023, 7:44 AM

#

thats mythology

tardy delta Jun 1, 2023, 7:44 AM

#

god luzifer

hybrid spoke Jun 1, 2023, 7:45 AM

#

im the better ending of the series lucifer

flint coyote Jun 1, 2023, 7:45 AM

#

Lucifer was decent

#

Also may I suggest we move to #general for more offtopic?

hybrid spoke Jun 1, 2023, 7:47 AM

#

flint coyote Also may I suggest we move to <#694661573125472256> for more offtopic?

no

sour folio Jun 1, 2023, 7:48 AM

#

When the 'amount' is less tham 1,000,000 this works fine, but as soon as it goes abouve 1M it stops working, any ideas? https://paste.md-5.net/logupiviku.cpp

hybrid spoke Jun 1, 2023, 7:48 AM

#

already told you to elaborate more since we dont know what you are trying to do

flint coyote Jun 1, 2023, 7:48 AM

#

hybrid spoke no

You aren't my god 😠

tardy delta Jun 1, 2023, 7:48 AM

#

more like devil

hybrid spoke Jun 1, 2023, 7:49 AM

#

flint coyote You aren't my god 😠

sin

undone axleBOT Jun 1, 2023, 7:49 AM

#

https://www.spigotmc.org/threads/a-guide-to-1-14-persistentdataholder-api.371200/

sour folio Jun 1, 2023, 7:49 AM

#

I didnt know abt that when i started making the plugin

flint coyote Jun 1, 2023, 7:49 AM

#

hybrid spoke sin

My only sin is using way to long stream.filter expressions to push things into one line

#

well I still split the line. But one expression

agile anvil Jun 1, 2023, 7:57 AM

#

Streams are so sexy we have to admit

flint coyote Jun 1, 2023, 7:58 AM

#

flint coyote ```java currentField = actionFields.stream() ....

I do like them but everyone seeing this code will hate me

agile anvil Jun 1, 2023, 7:59 AM

#

Yeah, there is a limit 🤣

flint coyote Jun 1, 2023, 8:00 AM

#

I told you that's my sin 😅

tardy delta Jun 1, 2023, 8:08 AM

#

join rust where streams compile to the same machinecode as normal loops

native ruin Jun 1, 2023, 8:08 AM

#

i am using an example i found online to change the metadata of a player (using protcollib )


            ProtocolManager pm = ProtocolLibrary.getProtocolManager();
            PacketContainer packet = pm.createPacket(PacketType.Play.Server.ENTITY_METADATA);
            packet.getIntegers().write(0, player.getEntityId());
            WrappedDataWatcher watcher = new WrappedDataWatcher();
            WrappedDataWatcher.Serializer serializer = WrappedDataWatcher.Registry.get(Byte.class); 
            watcher.setEntity(player);
            watcher.setObject(0, serializer, (byte) (0x40)); 
            packet.getWatchableCollectionModifier().write(0, watcher.getWatchableObjects());
            pm.broadcastServerPacket(packet);

when executing i am getting kicked from the server and get this errormessage in the console
class net.minecraft.network.syncher.DataWatcher$Item cannot be cast to class net.minecraft.network.syncher.DataWatcher$b
i assume this has something to do with the serializer, but don't know

#

wdym?

#

how do i use a datacontainer here

echo basalt Jun 1, 2023, 8:15 AM

#

do you not know what entity metadata is

#

well

#

you do not

native ruin Jun 1, 2023, 8:15 AM

#

i think this example makes the player glow
but i won't be using it for storage

echo basalt Jun 1, 2023, 8:16 AM

#

By entity metadata I'm not talking about bukkit's shitty metadata api

#

entity metadata in nms is like

#

All the data that the server needs to communicate to the client such as like

native ruin Jun 1, 2023, 8:16 AM

#

maybe i should have made that clearer mb

echo basalt Jun 1, 2023, 8:16 AM

#

how much health, if it is on fire, what items it has equiped

echo basalt Jun 1, 2023, 8:16 AM

#

native ruin maybe i should have made that clearer mb

No you're good

wet breach Jun 1, 2023, 8:17 AM

#

hybrid spoke do spigot tutorials

I would like to do this

echo basalt Jun 1, 2023, 8:17 AM

#

Here zacken

#

https://wiki.vg/Entity_metadata#Entity_Metadata_Format

Entity metadata

#

That's entity metadata in the context of packets and nms

tardy delta Jun 1, 2023, 8:17 AM

#

echo basalt Jun 1, 2023, 8:17 AM

#

native ruin i am using an example i found online to change the metadata of a player (using p...

I'd recommend uhh

#

updating protocollib

#

Just to be sure

native ruin Jun 1, 2023, 8:18 AM

#

echo basalt updating protocollib

using 5.0.0 is there a new one already?

echo basalt Jun 1, 2023, 8:18 AM

#

5.1.0 is in snapshot

native ruin Jun 1, 2023, 8:18 AM

#

can i just change the verison in pom and reload it?

echo basalt Jun 1, 2023, 8:18 AM

#

No, it's what's on the server that matters

native ruin Jun 1, 2023, 8:19 AM

#

ok server got it

echo basalt Jun 1, 2023, 8:19 AM

#

why the fuck would you shade protocollib

#

🤦

flint coyote Jun 1, 2023, 8:20 AM

#

😅

echo basalt Jun 1, 2023, 8:20 AM

#

I don't want to sound like a moron but there's still some learning for you to do

#

And don't worry we're all going through this at one stage

wet breach Jun 1, 2023, 8:21 AM

#

You cant shade protocollib as it wont work properly even if you relocate. Its one of few plugins/libs that simply cant be and will run into a lot of problems if you do

flint coyote Jun 1, 2023, 8:21 AM

#

he never said he is shading it though. He might just have scope provided

echo basalt Jun 1, 2023, 8:21 AM

#

There was like a time period back in 2020 where I stopped everything I was doing to fuck around with packets

native ruin Jun 1, 2023, 8:21 AM

#

where can i find the snapshot versions? i can only find the 5.0.0

wet breach Jun 1, 2023, 8:22 AM

#

Dont be rude now

echo basalt Jun 1, 2023, 8:22 AM

#

native ruin where can i find the snapshot versions? i can only find the 5.0.0

https://ci.dmulloy2.net/job/ProtocolLib/

#

Just go with the latest dev build

#

I honestly don't remember where I saw 5.1.0

#

Not always the case, ProtocolLib doesn't change much across versions

#

It's way too popular to afford splitting its community

wet breach Jun 1, 2023, 8:23 AM

#

echo basalt Not always the case, ProtocolLib doesn't change much across versions

True, the protocol does however which sometimes matters

echo basalt Jun 1, 2023, 8:24 AM

#

That's protocollib's job to handle, updating the pom won't change how you're writing data into the container

#

If you were using the packet wrappers, sure

#

But plib just wraps stuff and updating the pom on your plugin won't change how it serializes stuff

#

this is a stupid argument

wet breach Jun 1, 2023, 8:24 AM

#

echo basalt That's protocollib's job to handle, updating the pom won't change how you're wri...

I agree but point is. Sometimes alteration to the underlying implementation can still affect the higher level code even if the api didnt change

echo basalt Jun 1, 2023, 8:25 AM

#

wet breach I agree but point is. Sometimes alteration to the underlying implementation can ...

That's why I suggested updating the plugin on the server. The API didn't change

#

And it won't for a good time

wet breach Jun 1, 2023, 8:26 AM

#

If it does lots of people would be coming here to complain too 😂

echo basalt Jun 1, 2023, 8:26 AM

#

Because the only way that changing the pom would actually change how the underlying code would work is if you were shading it

native ruin Jun 1, 2023, 8:26 AM

#

how can i specify the 645 build in the pom?

echo basalt Jun 1, 2023, 8:27 AM

#

You don't need to

wet breach Jun 1, 2023, 8:27 AM

#

They do when it id necessary because the protocol somehwhere changed that forced it

#

But most of the time this isnt the case

native ruin Jun 1, 2023, 8:27 AM

#

then changing the versions didn't help, even deleted the protocollib server folder

echo basalt Jun 1, 2023, 8:27 AM

#

They change versions when the protocol changes, meaning they need to add new wrappers and more reflection

#

jfc it's disappointing we still arguing over something this minor

#

I'm gonna look for a solution, y'all 2 can bicker

#

fml

native ruin Jun 1, 2023, 8:29 AM

#

so anyone an idea on how the error occurs and maybe knows a solution?

echo basalt Jun 1, 2023, 8:29 AM

#

native ruin so anyone an idea on how the error occurs and maybe knows a solution?

Server version?

native ruin Jun 1, 2023, 8:29 AM

#

19.4

wet breach Jun 1, 2023, 8:29 AM

#

I dont really see the issue other then potentially building against a version that isnt for whatever mc version

echo basalt Jun 1, 2023, 8:30 AM

#

only thing I can think of

#

which I did on my packet wrapper

#

was like

#

boxing primitives

#

but I'm pretty sure that's just with getting the serializer rather than actually writing the data

#

okay yeah I can replicate

native ruin Jun 1, 2023, 8:36 AM

#

hmm i got no idea how to continue this so i am willing to try everything at this point

#

the code is a few years old so i assume something has changed over time

echo basalt Jun 1, 2023, 8:37 AM

#

yeah they changed something

#

I think protocollib genuinely broke this packet

#

think this packet uses WrappedDataWatcherObject now

#

@native ruin Found a solution!

native ruin Jun 1, 2023, 8:44 AM

#

fr?

echo basalt Jun 1, 2023, 8:44 AM

#

#

had to investigate some github issues back from december

#

but this works

#

native ruin Jun 1, 2023, 8:48 AM

#

yooooooo

#

amazing ty

tardy delta Jun 1, 2023, 8:57 AM

#

isnt Player#setGlowing a thing?

flint coyote Jun 1, 2023, 8:59 AM

#

Since Player is an Entity, yes

quiet ice Jun 1, 2023, 9:06 AM

#

Though the issue most likely is that it does not work on a per-player basis