can you extend player class and be able to make it have my own methods?
#help-development
river oracle
can you extend player class and be able to make it have my own methods?
No sounds like a dumb idea too
Usually if you want to extend player your doing something wrong with your data structure
terse ore
not really
river oracle
Yes really
terse ore
I am doing something wrong with my structure? No
I was going to do it? Yes
river oracle
Spigot doesn't allow you to natively associate any other data with Player so wanting to extend it shows something wrong is up
terse ore
okok ill make it in another awy
river oracle
If you want to associate more data with the player use PDC
terse ore
I just liked the idea of doing player.mymethod
river oracle
Or make a uuid wrapper and use a database
terse ore
Or make a uuid wrapper and use a database
that was one of my ideas
river oracle
That's your best option
You could have an internal getBukkitPlayer method or something along those lines
tender shard
Just snack some crack cocaine
river oracle
Alex back to being unhinged
hardy pollen
@tender shard
hi
i am using ur JeffLib
but it good an error
for entity player
remote swallow
?paste it
undone axleBOT
remote swallow
you need to define the method
hardy pollen
you need to define the method
do you know how to make EntityPlayer have pathfindergoal?
remote swallow
can an EntityPlayer even have a path finder goal
hardy pollen
that why i asked here
i want to make my EntityPlayer or humanEntity have pathfinder
remote swallow
if an EntityPlayer represents a player, that can move them self i doubt they can have a path finder goal
hardy pollen
if an EntityPlayer represents a player, that can move them self i doubt they can...
i'm try to make it attack nearest entity
hardy pollen
if an EntityPlayer represents a player, that can move them self i doubt they can...
do you know anymethods?
remote swallow
no sorry
hardy pollen
oh
river oracle
do you know anymethods?
EntityPlayers have their own goals you might need to extend the nms entity
And add them yourself
terse ore
That's your best option
let me tell you what I want to do before I do a bad decision
I want to store a selected kit
by name
should I use a .yml or a db
river oracle
Whatever your scale is tbh yml is fine for tiny amounts of data. Otherwise the next step up would be JSON, than Sqlite than, something like MongoDB or MySQL
terse ore
Whatever your scale is tbh yml is fine for tiny amounts of data. Otherwise the n...
I would like to implement info in Discord
I should not use Sqlite right?
river oracle
Sqlite is fine
terse ore
Sqlite is fine
but
didn't sqlite have only 1 connection?
like could only take a single connection
river oracle
I would like to implement info in Discord
Oh if you want other stuff to beable to open connections use MySQL
terse ore
okok
river oracle
Yea go with MySQL or Mongo
remote swallow
mingo
terse ore
Mingo?
river oracle
Shut
terse ore
oh okok
river oracle
Brit
terse ore
xdd
dull magnet
I'm wondering how to make the chat visible to all players when I type a command I've created.
urban mauve
how i can get block data(block id:block data) without getData() cuz it deprecated
icy beacon
val type = object : TypeToken<Map<UUID, Killstreak>>() {}.type
why is "object" needed here?
river oracle
Kotlin :(
icy beacon
thanks for your answer, anybody else wanna try?
glossy venture
lmao kotlin
river oracle
Most people here don't use that
remote swallow
it defines the type
glossy venture
thats the reason
icy beacon
it defines the type
does it?..
remote swallow
iirc if you use var you shouldnt need object:
icy beacon
nah typetoken is just a goofy ass thing
it's weird in both java and kotlin
gson is goofy in general it seems
this line looks like this in java
final Type type = new TypeToken<Map<UUID, Killstreak>>() {}.getType();
TypeToken Is like a hack lol
icy beacon
like, those curly brackets threw me off the first time i saw it
river oracle
It's so scuff
icy beacon
gson is hacky asf
rough drift
in a EntityDamageEvent, if the cause is FALL can I get the player that caused the fall damage? (eg attacked by player a and then took fall damage, like A was doomed to fall by B)
eternal oxide
only if you track all damage
icy beacon
you can manually track it maybe, track the last damager in a map like Map<UUID, UUID> and do something with it
eternal oxide
can't be obtained via events
rough drift
well I was able to get the killer (such as various player-triggered entities) using damage cause
figured I could use it for fall
eternal oxide
yes but FALL has no cause
rough drift
oh
eternal oxide
FALL is the cause
rough drift
alr thanks
eternal oxide
you could track last damager and then lookup if the cause is fall
but timestamp it so you know it's not from an hour ago
rough drift
Oh alright
terse ore
Best way to fill an area?
mortal hare
tall dragon
?workdistro
undone axleBOT
tall dragon
this helps alot too ^
terse ore
this helps alot too ^
they sound they were for heavy work
I need it for less than 1k blocks
tall dragon
well then ur fine
terse ore
how should I do it for that?
hazy parrot
```kotlin
val type = object : TypeToken<Map<UUID, Killstreak>>() {}.type
```
why...
because you create anonymous object which implements TypeToken interface or abstract class
terse ore
3 nested loops?
tall dragon
3 nested loops?
yea
terse ore
okok
hazy parrot
because you create anonymous object which implements TypeToken interface or abst...
its same as new TokenType<T>() {} in java
terse ore
should I check if the block is not air to set it to air and then set it
or just set it?
terse ore
ig so
maybe seting a block uses more resources than an if
so if I if it
I would save some resources
tall dragon
ohu mean check if its already the block ur changing it to
terse ore
yeah
tall dragon
u could do that, it'l probably be a little bit more performant yea
hybrid spoke
Best way to fill an area?
editing the region file
mortal hare
this is soo smart
ngl. I've never had thought you can just predefine a queue that uses special amount of tick time for each work task, without lowering the tps
@tall dragon thanks
i really really like this
@lost matrix
tender shard
I thought 7smile is dead
echo basalt
nah he was on last week
remote swallow
yeah
echo basalt
nah
remote swallow
who is sachin
remote swallow
oh
tender shard
and all the other plugins that end with -n
hardy pollen
nah i give up
tender shard
anyway
did anybode here text sachin in the last weeks?
I suspect he's actually dead
tender shard
plugg
icy beacon
yeah?
tender shard
have you heard anything from sachin in the last months?
tender shard
I remember he went to the hospital and after that I never heard fron him again D:
icy beacon
nvm
icy beacon
I remember he went to the hospital and after that I never heard fron him again D...
i think i recall seeing him online a week ago or so unless i've gone mad
wait no
tender shard
oh ok thats good
tall dragon
<@274948157711056896> thanks
icy beacon
that said he was available
don't you have some of his contact info
like i remember he had a gofundme for a surgery
i thought he had some there
tender shard
don't you have some of his contact info
no
icy beacon
https://www.spigotmc.org/threads/guide-on-workload-distribution-or-how-to-handle...
that's an incredible article, is there a shortcut in cafebabe for this?
tall dragon
?workdistro
@icy beacon
icy beacon
oh ty
tender shard
@tawdry scroll
you still alive?
pls answer
I already got DMs of people asking whether yo uare fine
icy beacon
his last github contribution is on october 19
tender shard
yeah that's like 5 months ago
icy beacon
wait
tender shard
4 months*
icy beacon
tender shard
oh
final monolith
lol
remote swallow
.mf
vague swallow
?paste
undone axleBOT
remote swallow
looks so jank tbh
icy beacon
that plugin is shit, doesnt properly work on multi-module maven projects
are there better ones
tender shard
none that I know
icy beacon
yeah same 😦
tender shard
there's a good CLI app though
final monolith
that plugin is shit, doesnt properly work on multi-module maven projects
xDD
tender shard
but I dont remember how it's called
icy beacon
i want everything to be gui so that my eyes can be pleased
remote swallow
code in vim
eternal night
Code in sed and echo
tender shard
Code in sed and echo
most of my code is so bad, nobody would worry if I'd just pipe it to /dev/null anyway
eternal night
vague swallow
Hey,
Could someone please help and/or explain me these Error Messages and what I have to change?
https://paste.md-5.net/dugokafori.pl
This is my codestarting from line 127:
for (Entity en : p.getWorld().getEntities()) {
if(en instanceof ArmorStand) {
ArmorStand as = (ArmorStand) en;
if(as.getScoreboardTags().contains("Holotable")) {
Location locE = p.getLocation().add(25, 25, 25);
Location locF = p.getLocation().subtract(25, 25, 25);
if(isNear(as.getLocation(), locE, locF)) {
coms.sendMessage(as, p, msg, false, false);
}
} if(as.getScoreboardTags().contains("nightsister")) {
}
}
}
people who claim their code sucks > people who claim their code is god-like
tender shard
Hey,
Could someone please help and/or explain me these Error Messages and what ...
which is line 127?
vague swallow
the first one
icy beacon
people who claim their code sucks > people who claim their code is god-like
what is this indentation :wheeze:
2 tabs
vague swallow
which is line 127?
for (Entity en : p.getWorld().getEntities()) {
tender shard
the world got unloaded
icy beacon
for (Entity en : p.getWorld().getEntities()) {
i bet world is null
nvm i didn't read the error
is this inside an async runnable?
vague swallow
the world got unloaded
how? I was in the world
vague swallow
is this inside an async runnable?
Inside an async Chat event
icy beacon
oh
tender shard
the world got unloaded
icy beacon
i think you should run a non async task inside it
because bukkit api can't be used async
tender shard
^
icy beacon
tender shard
do your stuff in a synced task
vague swallow
the world got unloaded
But how does it get unloaded if I'm right in the world?
vague swallow
do your stuff in a synced task
how can I do that?
icy beacon
make a synced task inside the event and run your stuff there
tender shard
public void onSomeAsyncEvent(AsyncWhatEverEvent event) {
Bukkit.getScheduler().runTasklater(() -> {
// do your stuff here
sth like that
tender shard
it's ?scheduling
icy beacon
?scheduling
undone axleBOT
vague swallow
```java
public void onSomeAsyncEvent(AsyncWhatEverEvent event) {
Bukkit.getSch...
Do I do that just for the for-loop or for the whole event?
icy beacon
```java
public void onSomeAsyncEvent(AsyncWhatEverEvent event) {
Bukkit.getSch...
the for loop must be inside the task
tender shard
Do I do that just for the for-loop or for the whole event?
for everything that you need "world access"
icy beacon
```java
public void onSomeAsyncEvent(AsyncWhatEverEvent event) {
Bukkit.getSch...
btw i'm not sure but for the sake of avoiding ambigious naming you could change the method to scheduleSyncDelayedTask or whatever it is
tender shard
you are not allowed to do any "world"-related things in any async context
icy beacon
probably not necessary
tender shard
IIRC, "scheduleSyncDelayedTask" with a delay of 1 is the same as runTaskLater
not sure though
icy beacon
just in case runTask runs on the same thread as whatever it was declared in
eternal oxide
IIRC, "scheduleSyncDelayedTask" with a delay of 1 is the same as runTaskLater
correct, same as runtask.
icy beacon
oh ok then
alex
what's your attitude to kotlin
i recall you wanted to code a plugin with it some time ago
tender shard
I do not like kotlin for a few reasons
I did many things in kotlin because I wanted to learn it, but I didnt like it
for example for the following reason:
vague swallow
```java
public void onSomeAsyncEvent(AsyncWhatEverEvent event) {
Bukkit.getSch...
What do I need to put inside the brackets of .runTasklater?
tender shard
public class MyClass
public String name;
public void setName(String newName) { ... }
your code
tender shard
in kotlin you do not know whether you call the setter, or set the field manually, when doing myClass.name = "asd";
icy beacon
no in these brackets: .runTasklater**()** <--
ah
it should be your plugin instance i think
tender shard
no in these brackets: .runTasklater**()** <--
are you not using an IDE?
icy beacon
in kotlin you do not know whether you call the setter, or set the field manually...
interesting
mortal hare
if something throws an exception on your classloader if halts the execution right
but what something bad happens on separate classloader?
tender shard
if something throws an exception on your classloader if halts the execution righ...
wdym?
mortal hare
it doesnt halt the main classes?
icy beacon
i'll try smth with the kotlin thing rq
vague swallow
are you not using an IDE?
what is an IDE?
tender shard
sth you gotta pay for if you're not a student 🥲
vague swallow
sth you gotta pay for if you're not a student 🥲
I'm using IntelliJ IDEA community edition
mortal hare
wdym?
lets say i have classes which throws unhandled exception on application classloader
that halts the flow of code right
tender shard
lets say i have classes which throws unhandled exception on application classloa...
are you talking about a spigot plugin?
tender shard
are you loading these classes in onEnable() or somewhere else
mortal hare
yes im loading them using URLClassLoader
what im asking if the badly written jar file can interrupt plugin's work
if their classloaders are separate
tender shard
if you do it in onEnable() and do not the catch the exception yourself, then the plugin will get disabled
mortal hare
you're givin me chat gpt vibes
tender shard
how so lol
icy beacon
in kotlin you do not know whether you call the setter, or set the field manually...
ok alex so it seems that you're calling the setter
tender shard
all my messages are written by a real drunk german human
tender shard
because if i set the setter to private, it won't allow me t o do it
yeah I know, isn't that weird?
to me it is weird
mortal hare
i mean lets say I load classes using different classloader, Spigot plugin uses PluginClassLoader to load plugin's classes and i load plugin's subplugin jar file using URLClassLoader class
tender shard
I also dislike kotlin for their weird funny idea of getting rid of knowing variable types
icy beacon
it's just conciseness to the point
icy beacon
I also dislike kotlin for their weird funny idea of getting rid of knowing varia...
oh you can know them though
mortal hare
does that halt the execution
icy beacon
like i did in var a: String = "A"
mortal hare
of the parent
icy beacon
or do you mean smth else
mortal hare
if child is dum dum and had a bug
tender shard
imho kotlin doesn't do anything useful besides adding stuff to java that wasn't added to java in the first place for good reasons
icy beacon
the three reasons i enjoy kotlin are 1) syntax sugar 2) conciseness 3) extensions to classes omg omg
tender shard
e.g. var/val
tender shard
the three reasons i enjoy kotlin are 1) syntax sugar 2) conciseness 3) extension...
haha "consiness" is exaxctly what I hate about in kotlin
icy beacon
😄
tender shard
some people call it "conciseness", I call it "inaccuracy"
tender shard
myNullObject.doSomething() yeah just don't do this ^
tender shard
tbh I love that java throws an NPE instead of just returning null
icy beacon
yeah in kotlin if it's null it just won't do the thingy
tender shard
if you wanna be able to debug stuff being null all the time, go use LUA
icy beacon
yeah in kotlin if it's null it just won't do the thingy
might be useful, might be nefarious asf
depends on the context of the usage
tender shard
I agree that kotlin is nice for allowing you to decide whether you want an NPE or just getting null
however I never saw ANY reason in using it
icy beacon
😄
tender shard
if "myObject" is null, I WANT to get an NPE
charred blaze
How do I do this with regex? |
e.getMessage().replace("&0", "").replace("&2", "").replace("&4", "").replace("&6", "").replace("&8", "").replace("&a", "").replace("&c", "").replace("&e", "").replace("&m", "").replace("&o", "").replace("&1", "").replace("&3", "").replace("&5", "").replace("&7", "").replace("&9", "").replace("&b", "").replace("&d", "").replace("&f", "").replace("&l", "").replace("&n", "").replace("&r", "");
icy beacon
i do have some use cases where it could be better
mortal hare
How do I do this with regex? |
``e.getMessage().replace("&0", "").replace("&2", ...
wtf
tender shard
How do I do this with regex? |
``e.getMessage().replace("&0", "").replace("&2", ...
are you drunk or sth
icy beacon
How do I do this with regex? |
``e.getMessage().replace("&0", "").replace("&2", ...
uhh
charred blaze
please strip color with chatcolor
WE DO HAVE THAT METHOD???
icy beacon
yeah...
icy beacon
stripColor
tender shard
and yes, it exists
icy beacon
i think you just need to replace & with paragraph
tender shard
yeah
mortal hare
even if it didnt exist char for loop would be way more clean than this
icy beacon
How do I do this with regex? |
``e.getMessage().replace("&0", "").replace("&2", ...
the grand wall
charred blaze
the grand wall
:D
charred blaze
does everyone agree?
tender shard
yes
charred blaze
and if you really want the regex you could probably use `(\&[0-9obdflnr])`
with this
ok ill use it
tender shard
no
icy beacon
is it wrong
do you want to use regex for the sake of using it?
tender shard
the & stuff will only work on "pre-ChatColor.translateAlternate...." stuff
charred blaze
use chatcolor
will stripcolor work when someone is chatting using & symbols?
icy beacon
just replace & with paragraph and strip color
tender shard
what the heck are you even trying to do
icy beacon
why use regex
undone axleBOT
charred blaze
just replace & with paragraph and strip color
do u mean some weird default translate color symbol?
icy beacon
it's not weird???
tardy delta
§
tender shard
if at all, then § is weird
hybrid spoke
its 🔥
icy beacon
i use this symbol all the time because i am a student
tender shard
your mom is fire
icy beacon
if it's weird, what isn't
hybrid spoke
true
icy beacon
ye i meant that
yeah just replace & with it..
charred blaze
yeah just replace & with it..
ok
icy beacon
anyway i don't get what you are trying to do either
hybrid spoke
who was btw the first who translated & to § and set the standard?
icy beacon
if they are using & to chat, it shouldn't get translated to colors anyway
unless some other plugin does that
charred blaze
unless some other plugin does that
yes
icy beacon
and if you want to prevent other plugins from doing that, you can probably disable that in the conig
charred blaze
some does
icy beacon
config*
icy beacon
ah
charred blaze
ChatColor.stripColor(e.getMessage().replace("&", "§"));
will this work for that thing?
icy beacon
well then don't do replacing
bright spire
Is GPL license inherited from Bukkit when I make a plugin that does not include any of the Bukkit libraries?
icy beacon
Is GPL license inherited from Bukkit when I make a plugin that does not include ...
if you make a bukkit plugin you are using bukkit
if you aren't, then you aren't making a bukkit plugin
bright spire
if you make a bukkit plugin you are using bukkit
I am using it to access the methods, but not including it in the jar. Isn't this like emulators where "accessing methods" is completely fine?
icy beacon
well that's what every plugin does i think
unless you use reflection for every single method you are still kinda including it
bright spire
Do that means I need to inherit the GPL license?
eternal oxide
I am using it to access the methods, but not including it in the jar. Isn't this...
What license are you wanting to use?
bright spire
What license are you wanting to use?
MIT
icy beacon
yeah
vague swallow
Why is the PrepareAnvilEvent not triggered if the name of the AnvilInventory is different?
vague swallow
show your code
@EventHandler
public void onAnvilInput(PrepareAnvilEvent e) {
Bukkit.broadcastMessage("bro");
if(e.getView().getTitle().equals(GUI_NAME2)) {
if(e.getView().getPlayer() instanceof Player) {
Player p = (Player) e.getView().getPlayer();
openCallInput(p, e.getInventory().getItem(2));
p.sendMessage("te");
}
}
}
it is only broadcasting "bro" when the name of the anvil Inventory is not changed
undone axleBOT
eternal oxide
if(e.getView().getTitle().equals(GUI_NAME2))
icy beacon
`if(e.getView().getTitle().equals(GUI_NAME2))`
"bro" should be broadcasted either way
it's the first thing in the method
tender shard
thanks btw and you too <@632994436401594368> It worked
Nice
lost matrix
<@220605553368498176>
👍
eternal oxide
cleaner is to if (!e.getView().getTitle().equals(GUI_NAME2)) return;
icy beacon
cleaner is to `if (!e.getView().getTitle().equals(GUI_NAME2)) return;`
yeah it's ?arrowcode
icy beacon
```
@EventHandler
public void onAnvilInput(PrepareAnvilEvent e) {
Bu...
also doesn't InventoryView#getPlayer return HumanEntity?
if it does then there's no need to check for player instanceof
tender shard
also doesn't `InventoryView#getPlayer` return HumanEntity?
Yes
icy beacon
because the only class that is a humanentity is player for now afaik
so it can be just casted
eternal oxide
No idea on why you don;t see bro
icy beacon
we haven't figured out the reason yet
tender shard
Plugins might implement it
icy beacon
Plugins might implement it
oh i guess
though isn't that a bukkit api misuse
sounds like one
tender shard
Eg Citizens
icy beacon
oh in that case i hereby allow it
tender shard
though isn't that a bukkit api misuse
Depends, i guess
vague swallow
allow what?
hybrid spoke
https://blog.jeff-media.com/avoiding-the-arrow-anti-pattern/
include the gif
tardy delta
dont compare inventories by title, if title changes you cry
icy beacon
dont compare inventories by title, if title changes you cry
agree
tender shard
allow what?
Implementing bukkit interfaces
icy beacon
though working with inventories in general is pain
hybrid spoke
dont compare inventories by title, if title changes you cry
just dont change the title
hybrid spoke
InventoryHolder
icy beacon
i used to create custom inventoryholders
but that's a misuse too
i don't wanna do that anymore
i just use triumphgui
tardy delta
abusing inventory holders
hybrid spoke
misuse
vague swallow
dont compare inventories by title, if title changes you cry
okay but the problem is that the event doesn't get triggered when the title of the anvil inventory is different
icy beacon
lol
tender shard
InventoryHolder
Lol exactly that is kinda not allowed
vague swallow
okay but the problem is that the event doesn't get triggered when the title of t...
the whole event
tardy delta
uh i havent really been following
icy beacon
i just use triumphgui
really though check it out
hybrid spoke
in that case my inventory is an inventoryholder
hybrid spoke
Lol exactly that is kinda not allowed
not allowed by who
lost matrix
there's no true good way to check if an inventory is one you want
Well inventories implement equals and hashCode. So you have plenty of utility with that.
hybrid spoke
stated as a "bad practice" from spigot, but that doesnt stop me
icy beacon
```
@EventHandler
public void onAnvilInput(PrepareAnvilEvent e) {
Bu...
@tardy delta we're here trying to figure why bro isn't broadcasted
tender shard
not allowed by who
By md_5, read the javadocs
hybrid spoke
its the same as using a deprecated method
icy beacon
its the same as using a deprecated method
Bukkit.getOfflinePlayer(String name) is the bane of my existence
fucking undeprecate that shit
icy beacon
i used to use inventoryholders for a while
hybrid spoke
if it would be not allowed i would do it anyways
icy beacon
didn't have any real bugs with that
tender shard
I have talked to md5 about this 3 years ago and he said „dont do it“
hybrid spoke
sounds like a you problem to me
tardy delta
💀
tender shard
Do whatever you want
icy beacon
I have talked to md5 about this 3 years ago and he said „dont do it“
i have asked him to add other ways to receive money from paid plugins and he sent me a link to a copypastable wall so i don't really care about his opinions anymore
tender shard
And what did that link say?
tender shard
Oki
icy beacon
but i honestly don't care, i only care about this
tardy delta
💀
icy beacon
which means that there needs to be an alternative?
terse ore
but i honestly don't care, i only care about this
this is just plain stupid
lost matrix
```
@EventHandler
public void onAnvilInput(PrepareAnvilEvent e) {
Bu...
If you have only one type of custom inventory:
public class SomeInventoryManager {
private final Set<Inventory> customInventories = new HashSet<>();
public boolean isCustom(Inventory inventory) {
return customInventories.contains(inventory);
}
public void registerCustom(Inventory inventory) {
customInventories.add(inventory);
}
public void unregisterCustom(Inventory inventory) {
customInventories.remove(inventory);
}
}
Or if you have a specific functionality for each inventory:
public class SomeInventoryManager {
private final Map<Inventory, InventoryHandler> customInventories = new HashMap<>();
public boolean isCustom(Inventory inventory) {
return customInventories.containsKey(inventory);
}
public void registerCustom(Inventory inventory, InventoryHandler handler) {
customInventories.put(inventory, handler);
}
public void unregisterCustom(Inventory inventory) {
customInventories.remove(inventory);
}
public void propagate(InventoryClickEvent event) {
Optional.ofNullable(customInventories.get(event.getClickedInventory())).ifPresent(handler -> handler.handleClick(event));
}
// ... do other events
}
yeah they are weirdos
terse ore
Fuck paypal
I could do everything without a verified card, now I need a verified card ;-;
tender shard
But i also do understand md5 not wanting to deal with stripe etc because tvh stripe is even worse
icy beacon
there are like 2 ways for international transfers in russia, and i only call recall one
terse ore
Spain and another country were the only ones to not need a card
terse ore
But i also do understand md5 not wanting to deal with stripe etc because tvh str...
what's tvh?
tender shard
Tbh* typo
tender shard
Go home plugg
vague swallow
If you have only one type of custom inventory:
```java
public class SomeInventor...
how does that solve my problem?
icy beacon
Go home plugg
YOU MISSED A G
tender shard
how does that solve my problem?
Maybe it doesnt
icy beacon
how does that solve my problem?
following good code standards may sometimes solve your future problems that you are not aware of yet
such as not using an arrow code anti-pattern
tender shard
^
lost matrix
how does that solve my problem?
It proposes a more robust approach to your inventory situation so you dont
have to rely on names. Didnt read your full problem dbh
icy beacon
good alex
astral condor
why
icy beacon
void
remote swallow
do you not like 1 liners
remote swallow
<@632994436401594368> why dont you use or?
bad practise
tender shard
If you think that adding a ton of code blocks for a one line statement is needed: okay
terse ore
bad practise
it should be done with || right?
icy beacon
also why is your class in lowercase
tender shard
If you think that adding a ton of code blocks for a one line statement is needed...
Many people think otherwise
remote swallow
it should be done with || right?
no
vague swallow
It proposes a more robust approach to your inventory situation so you dont
have ...
The problem was that the PrepareAnvilEvent only gets triggered in the anvil doesn't have a different name
astral condor
it's not a constructor
What should I do?
terse ore
how should it be done then
lost matrix
do you not like 1 liners
No i always add bodies to every statement and it has been a code standard at every company i worked so far
remote swallow
how should it be done then
like alex does it
remote swallow
icy beacon
What should I do?
public scoreboard(Main plugin)
also don't name your main classes Main
remote swallow
?main
undone axleBOT
icy beacon
yep
terse ore
?help
icy beacon
was looking that up
undone axleBOT
CafeBabe Help Menu
astral condor
`public scoreboard(Main plugin)`
thx
remote swallow
was looking that up
if you do ?cc list in #bot-commands you can see all of them,
tender shard
No i always add bodies to every statement and it has been a code standard at eve...
Thats a weird reasoning though. I could also say „killing jews was a standard at every company hitler worked for“.
Just because sth is standard somewhere doesnt mean its good
terse ore
oh the timing
remote swallow
if you do ?cc list in <#940291417455087627> you can see all of them,
this
lost matrix
The problem was that the PrepareAnvilEvent only gets triggered in the anvil does...
The event always gets fired when you click on any anvil. My suggestion simply removes
the need of checking for names all together because its a very brittle approach.
icy beacon
if you do ?cc list in <#940291417455087627> you can see all of them,
ik
i was looking up the thread
didn't know that it was a command too haha
remote swallow
lol
hybrid spoke
No i always add bodies to every statement and it has been a code standard at eve...
in my company its a standard that oneliners doesnt have a body
icy beacon
well your company is quite goofy
tender shard
In my company its standard that people do whatever is appropriate
hybrid spoke
well your company is quite goofy
not really
terse ore
how old are you guys?
tender shard
27
lost matrix
Thats a weird reasoning though. I could also say „killing jews was a standard at...
Its not the reason why i use them, its simply affirmation
icy beacon
how old are you guys?
you go first
terse ore
you go first
no problem, I am 16
terse ore
it's in my ab me xd
hybrid spoke
you cant work with 50 people without the code being messy without conventions and standards
icy beacon
ah
icy beacon
damn
terse ore
?reminder
tender shard
Oh
icy beacon
and i'll be 15 haha
tender shard
My best friend has birthdax on feb 21 lol
tender shard
Haha
vague swallow
The event always gets fired when you click on any anvil. My suggestion simply re...
Why is this event:
public void onAnvilInput(PrepareAnvilEvent e) {
Bukkit.broadcastMessage("test");
}```
Working when the name of the anvil inventory is "Repair & Name" but not if the name is "§bEnter your name here"?february is the new meta month
icy beacon
Why is this event:
```@EventHandler
public void onAnvilInput(PrepareAnvilEvent ...
wait
hybrid spoke
Why is this event:
```@EventHandler
public void onAnvilInput(PrepareAnvilEvent ...
did you check for the exact name?
tender shard
Why is this event:
```@EventHandler
public void onAnvilInput(PrepareAnvilEvent ...
Because those are two different strings
vague swallow
did you check for the exact name?
I didn't check for any name
undone axleBOT
remote swallow
astral condor
vague swallow
I didn't check for any name
I didn't check for any name but the first one is the default name of anvil inventories and the second one is custom
icy beacon
I didn't check for any name but the first one is the default name of anvil inven...
https://github.com/WesJD/AnvilGUI for fetching input from anvils
it'll really make your life easier
tender shard
Anyway, using a block for a single return statement is kinda useless imho
lost matrix
Imagine someone writes code like this:
if(condition) return;
And later on you need to add functionality to that.
if(condition) {
someLoggerCall();
somethingElse();
return;
}
Thats just a hustle and now if we remove the two lines again
we would also have to remove the body to get standardised code again.
Also clearly separating your scopes is very important. Its not clear
that everything after a conditional statement is a new scope if you just
skim over some code.
hybrid spoke
https://paste.md-5.net/obedugasuy.java
did you ever set the scoreboard to a player?
prisma needle
Modify default loot table for a block
astral condor
did you ever set the scoreboard to a player?
I'm not sure
hybrid spoke
I'm not sure
well then start there
astral condor
well then start there
what should i do
lost matrix
Why is this event:
```@EventHandler
public void onAnvilInput(PrepareAnvilEvent ...
There is literally nothing preventing your listener from firing regarding the name of your inventory. So this is not possible.
pseudo hazel
player.setscoreboard
tender shard
what should i do
Keep track of the inventories you create
Instead of merely comparing them by their name
pseudo hazel
wrong person xD
tender shard
Oh
astral condor
😂
lost matrix
Thats the almost 30 brain kicking in
tender shard
Yeah anyway lol
astral condor
player.setscoreboard
where to put
pseudo hazel
where you want to set the scoreboard to the player
pseudo hazel
I assume you have some class that determines what the scoreboard should look like
thatd be the first place I would look for applying the board to the player as well
astral condor
I confused
pseudo hazel
hmm
i looked at your code and im confused too since I never worked with fastboard
so idk what it does and doesnt do on its own
because you create a new board in join using the player as an argument
for all I know that should already set the board
astral condor
thank you for the advice
lost matrix
I confused
Hello confused im flo
astral condor
~~Hello confused im flo~~
lamo
icy beacon
imma have dinner now cya
astral condor
what happened
eternal night
Your scoreboard class is extending javaPlugin
Which it isn't allowed to do as you can only have one java plugin type and instance
astral condor
Which it isn't allowed to do as you can only have one java plugin type and insta...
thx u bro
bright spire
What should I do if I have a business out of Bukkit plugins but most of the people is getting the jars for free by compiling the source code? Am I forced to publish the source code by the GPL license?
I want to try to comply the licenses without the business getting bankrupt
pseudo hazel
usually people dont post the source of their premium resource
but yeah otherwise you would probably need to update the license on it
bright spire
@pseudo hazelBy the GPL license of Bukkit, I am forced to use GPL on all my plugins.
bright spire
make code private
Does that comply with GPL?
terse ore
no
eternal night
You should contact a lawyer about that
eternal oxide
Don;t comply with GPL
terse ore
You should contact a lawyer about that
not really
eternal night
No one here has any opinion that is worth anything to you
Nothing anyone here says is useful
In terms of "oh fuck I am about to get sued"
eternal oxide
keep private your source and anyone who trys to force you to give it ignore
bright spire
I think I can redistribute it for a price
As long as I don't deny it
The source code
eternal oxide
are you talking about yoru own plugins? or other peoples?
bright spire
My own
I think I can distribute source code with a fee
And that would comply with GPL
And prevents people from getting the plugin for free
eternal oxide
then you have no responsibility to expose your source, so long as you are not packaging any OS libs
bright spire
then you have no responsibility to expose your source, so long as you are not pa...
I think I do because my projects use the bukkit api
astral condor
why it doesn't connect
eternal oxide
I think I do because my projects use the bukkit api
Bukkit/Spigot is not going to sue you for keeping your plugin source private
bright spire
Bukkit/Spigot is not going to sue you for keeping your plugin source private
I have people menacing me
Thats why I want to make sure I comply
eternal oxide
Your choice, I'd use the block button
hasty prawn
eternal oxide
They only want things for free but have no way to force you
bright spire
Its a group of developers
eternal oxide
Only license holders can sue
pseudo hazel
sounds like a bunch of babies
hasty prawn
Doesn't it like... not even matter? Bukkit/Spigot may use GPL but since we're not compiling their code only relying on it as an external dependency, you can put whatever license you want on your own plugin?
Or am I misunderstanding how GPL works
eternal oxide
Not quite
When you compile you actually include some of the API
So IF Spigot wanted to enforce it's license THEY and they alone could demand your source
astral condor
I finally solved the problem myself.
hasty prawn
Ah, gotcha.
astral condor
and everyone who helped
trail lintel
Hey guys, I notice when I open an ender chest programmatically with player.openInventory(player.getEnderChest()), the name displayed at the top is always "Ender Chest", regardless of what the players language setting is set to. However when opening an ender chest normally, the language is displayed correctly. Is there something more I need to do to get this localization working? I notice openInventory() returns an InventoryView, which has a setProperty() method. But I feel like it should be using the localized string automatically. Any help would be appreciated =]
Hmm set property does not appear to be what I need
theres even a getTitle() method, but no setTitle() =[
mortal hare
Hey guys, I notice when I open an ender chest programmatically with `player.open...
i've noticed this myself
problem is that spigot always sends hardcoded name for some reason. Container names are hardcoded into OBC classes
trail lintel
That is unfortunate =[ I was looking at the relevant code here to see if I could figure out why it was happening
https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/browse/src/main/java/org/bukkit/craftbukkit/entity/CraftHumanEntity.java#277
mortal hare
you can send localized name, but it involves probs some packets or setting localized chat component as the container name
its just a dumb thing tbh that spigot has
trail lintel
Oh interesting, that is a bit above what I have worked with so far. Could you suggest some reading for packets?
I also was unable to find a way to "set container name" at all. There doesn't seem to be a setTitle method
mortal hare
on paper there's an easy fix for this
but it involves using Adventure API's TranslatableComponent
trail lintel
Hmm, I looked up adventure API. I would prefer to keep the plugin with zero dependencies. However if that is the only way, what can ya do haha
mortal hare
yea but its built into paper rn
lyric mica
I also was unable to find a way to "set container name" at all. There doesn't se...
Inventory enderChestInventory = player.getEnderChest();
InventoryView enderChestView = Bukkit.createInventory(null, enderChestInventory.getSize(), "Ender Chest");
enderChestView.setContents(enderChestInventory.getContents());
player.openInventory(enderChestView);
Maby something like this could work?
and when they close the inventory you would set the echest contents.
mortal hare
Bukkit.createInventory(InventoryType.ENDER_CHEST, Component.translatable("container.enderchest"))
would create enderchest type of inventory with translated text on paper
but this would be separate from player's ender chest
trail lintel
Oh that is an interesting approach, creating a temporary inventory. I am slightly worried doing that as it might cause some duplication issues if there were packet drops or something. But that is a total guess haha
mortal hare
i think sending a packet would be cleaner approach
but this would involve some NMS
or protocollib
trail lintel
"Resending this packet with already existing window id, will update the window title and window type without closing the window."
eureka, thats it baby THATS IT
now I just gotta figure out how to send packets haha
worn tundra
Are you looking to just rename the open inventory once?
trail lintel
Yup thats right, I want to rename the inventory with the correct localized name
worn tundra
And you have that localized name as what?
worn tundra
Yeah but does that not translate to other languages or whats the problem?
trail lintel
Yeah, when opening the ender chest programmatically. No matter what the language setting is set to the title is "Ender Chest".
worn tundra
Oh okay perfect
mortal hare
Yeah but does that not translate to other languages or whats the problem?
it would translate if the sent title is TranslatableComponent
server just sends the json key to the client
vague swallow
I've just got the shortest Error in my life:
java.lang.ArrayIndexOutOfBoundsException: null```
Does anyone know how to fix something like that?Check out this package
https://github.com/AKUS-Studio/nature/tree/master/nMauris/src/main/java/works/akus/mauris/objects/menu/title
mortal hare
and client translate it to normal lang
worn tundra
It uses protocollib
To read the windowId and containertype
when a player opens any inventory
Then uses that info to resend an open packet
with the same id
which in turn just renames
lyric mica
Oh that is an interesting approach, creating a temporary inventory. I am slightl...
if it does duplicate i think it would just set the values again to the same number since you'd be using setContents() but smth like addItems() would do that.
worn tundra
the open inventory
trail lintel
Excellent, I would prefer to avoid using any external libs, but this looks like a very good resource to look at for renaming a window title with packet sending
worn tundra
Yeah you could write some NMS I think as well
Since minecraft IS capable of renaming windows
(inventories)
trail lintel
Hmmm, protocol lib DOES look nice though
but I doubt the implementation of this specific packet will change much since I'm not planning anything advanced
mortal hare
you can do this without protocollib, but you would need to setup your maven or gradle project in a way to support NMS
and add abstraction classes
to each minecraft version you wish to support
Just use protocollib
trail lintel
Honestly yeah, sounds like its protocollib time
mortal hare
There are more slaves to update that plugin than your nerves and braincells watching the minecraft server's netcode
how would you call plugin which get loaded by the spigot plugin
addon?
extension?
subplugin?
trail lintel
This does of course raise the question..... Why doesn't spigot just use the localized name when opening an inventory lol. But thats just me bitchin 😉
mortal hare
probs due to backwards compatibility
or due to many people relying on names rather than inventory types
in order to detect ender chests
idk
trail lintel
OH you know what. I bet I could make protocollib a softdepend couldn't I. So its not REQUIRED but if they do have it then it will do the thing.
mortal hare
it just seems weird indeed
mortal hare
OH you know what. I bet I could make protocollib a softdepend couldn't I. So its...
good idea. that's what you should do
its a minor feature
trail lintel
I have my plan =]
thanks a bunch guys you all rock
specifically you dovidas you helped a bunch =]
mortal hare
you're welcome
mortal hare
hol up
at least on my paper
nms
its translatable component
what version of paper do you use
if you use it at all
im guaranteed that 1.19 paper will send enderchest container names correct
unless you create them explicitly
with Bukkit.createInventory() and use string instead of component
im not sure about spigot tho, iirc spigot didnt had chat components
or they were pretty shhh... (*cough* bungee ones)
vague swallow
How can I get a UUID from a String?
vague swallow
UUID.fromString()
I'm stupid, thanks!
mortal hare
np
trail lintel
or they were pretty shhh... (\*cough\* bungee ones)
sorry was eating my lunch
Ummm so hold up, lemme wrap my head around that
So I am using paper v1.19.3
and I am opening the inventory using player.openInventory(player.getEnderChest())
mortal hare
im running purpur, but its almost the same (Paper, Pufferfish and some other fork patches)
but it defines the translatable component
maybe you're using some kind of resource pack
that alters the locale?
trail lintel
Hmmm, I do have a custom resource pack enabled that skins the item. Let me turn that off and see if the problem persists.
Hm, even after disabling all resource packs it still seems the title isn't localized
trail lintel
Hmm nope it seems the same thing happens on purpur
mortal hare
ok lemme try that myself
trail lintel
Need me to send you any sample code to test with?
twilit roost
is there an BungeeCord alternative for OfflinePlayer?
trail lintel
Very strange right
blazing monolith
Does anyone know how to make a player mount an entity? Im trying to make a player mount a minecart using minecart.addPassenger(player), but it wont work
mortal hare
ok
this is not fixed
but its translatable key exists within a code
wtf
so apparently from reverse engineering you can see that the openInventory() calls for inventoryType to retrieve the name
inventoryType serializes old legacy hardcoded strings into components
thus no translatablecomponent is being sent
to the client
you'll still need packets
trail lintel
Oh wow, you know this codebase pretty well 😮 I would have never been able to delve that deep
Very interesting
So I have accidentally stumbled upon a bug huh haha
mortal hare
its probs not a bug
but a leftover
to keep broken plugins alive
who check if inventory.getType().getTitle().equals("Ender Chest")
mortal hare
the thing is it does correctly for ender chest blocks
it just doesnt whenever you open via the code
trail lintel
Right? Thats what I found peculiar haha
mortal hare
this would explain BlockState and other things
in this method args
that belong to the block classes
in other words, just use softdepends and protocollib to fix this
i doubt spigot would ever fix this
trail lintel
Working on it now =] I notice the enums in protocollib are slighly different than the ones listed on the packet site
mortal hare
yes
they're standardised
so that the names wont change
like in NMS they sometimes do
actually its an easy fix from spigot side
trail lintel
this guy must be a GOD tier developer, to create something that works across multiple versions like that
mortal hare
just change defaultTitle() to TranslatableComponent
and everything would be translated
but this is left purposefully if i had to guess
trail lintel
yeah prob what you said about compatibility is why
mortal hare
getting string equivalent name is even deprecated
im 99% sure that this is intentional, but its a codesmell that contributors of spigot and paper know about ;D
trail lintel
Ohh ya know what though, I just thought of something....
I intercept the OPEN_WINDOW packet, but theres no context there telling me whether its them opening an ender chest normally, or through my custom item
Hmmmmmm
mortal hare
you can just send the translatablecomponent
nvm
you would change custom titles
if you do that
mortal hare
what type of component does protocollib return
if its native to spigot or paper
you can do comparison
with == to detect
if the title is legacy hardcoded
trail lintel
hmm when you say component what do you mean? I don't see any component class in the spigot API, but I saw some in your code from before
mortal hare
can you retrieve WrappedChatComponent object from the intercepted packet?
trail lintel
it does appear that I can
mortal hare
ok this wont work
because WrapperChatComponent does not hold real component objects
but what you can do instead is to check the ids
of the containers
nvm
hmm
maybe you shouldnt intercept
packet
but instead send one
by wrapping the openInventory function
but you need to somehow get the menu id
trail lintel
Oh! I think you might be on to something!
fair vapor
How can I check what the item a player is attempting to pickup is
rotund ravine
use the event?
remote swallow
EntityPickupItemEvent?
yeah
trail lintel
PacketContainer container = new PacketContainer(PacketType.Play.Server.OPEN_WINDOW);
try {
manager.sendServerPacket(player, container);
} catch (InvocationTargetException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
I think you sent me on the right path @mortal hare 😉
I just have to make sure to send the correct window ID
remote swallow
if (event.getItem().getItemStack().isSimilar(YourItemStack) { do stuff }
mortal hare
```java
PacketContainer container = new PacketContainer(PacketType.Play.Server.O...
yea you can get it via NMS
but im thinking of a way to bypass that
since that would break version support
blazing monolith
How do I make a player mount a minecart? addPassenger() isnt working
mortal hare
i mean you can do simple check if wrappedchatcomponent is "Ender Chest" but that would make all the ender chests translatable
even if that was explicitly defined as "Ender Chest"
trail lintel
I think I am heading down the right route with this, lemme see if this is stupid 😉
trail lintel
PacketContainer container = new PacketContainer(PacketType.Play.Server.OPEN_WINDOW);
container.getIntegers().writeSafely(0, inventoryId);
container.getIntegers().writeSafely(1, 2);
the inventoryId still need to find a way to get that, but the second one is writing to index 1, with the value 2
https://wiki.vg/Protocol#Open_Screen
https://wiki.vg/Inventory
mortal hare
eureka
trail lintel
I'm not entirely sure I'm using that right. But I think I'm heading in the right direction
mortal hare
i know
trail lintel
OH SNAP
mortal hare
create a new variable
to store your id
int
make a map
Map<Player, int> ids = new HashMap<>();
as a global class field
outside the method
intercept a packet of open_window
check if MenuType is EnderChest if so add to map
intercept packet close_window
scarlet moat
?paste
undone axleBOT
mortal hare
remove the id
from the map
now you have a map which holds windowId
without nms
of a player
scarlet moat
Help please: https://paste.md-5.net/onufivajoh.cs
mortal hare
use it next to openInventory() to send packet, like you provided in the snippet above
idk if that would work but it could
trail lintel
Ohh that is interesting. But how would I know if its a real ender chest vs my custom item? Since the ender chest already translates correctly, I don't need to send the packet in that case
mortal hare
you dont need to
you wrap the method
of openinventory
since player can see only one container on the client
by executing wrapped method you're guaranteed player is opening patched one
but it would work only if you execute the wrapped method
to open the enderchest ivnentory
mortal hare
this should work
trail lintel
EVERY time a chest is opened, add its ID to that map, then ONLY when my custom open inventory is called will I send that ID
mortal hare
yes
trail lintel
the only time that ID will be sent, will be in the context of my method
thats clever
trail lintel
genius haha
mortal hare
but im not sure if packet send listener gets called instantly (single threaded execution) or its async
green prism
How can I use custom args in Aikar Command Framework?
I've created an Object class:
@Getter
@Setter
@RequiredArgsConstructor
public class Arena {
private final UUID id;
private final String name;
private final ArenaType type;
private final World world;
private final int maxPlayers;
private final Map<TeamColor, Location> spawns;
private final Map<GeneratorType, List<Location>> generators;
private final Location lobby;
private final Location[] shop, upgrade, beds;
private GameStatus status = GameStatus.WAITING;
}
And I would like to use it inside a subcommand arg
public void join(final CommandSender sender, Arena arena) {
afaik packet listeners are not thread safe