#help-development | SpigotMC | Page 114

buoyant viper Sep 5, 2022, 1:48 AM

#

then why even write java

echo basalt Sep 5, 2022, 1:48 AM

#

there are only a few rare instances where I actually like to enforce exceptions

buoyant viper Sep 5, 2022, 1:48 AM

#

smh

tender shard Sep 5, 2022, 1:48 AM

#

player between 3-16 blocks away: follow
otherwise: stop

echo basalt Sep 5, 2022, 1:48 AM

#

Trycatch from a clock cycle perspective is a bit slow

tender shard Sep 5, 2022, 1:49 AM

#

add debug statements

#

and see what they print

#

check what I sent above

#

yeah well if you say "its fine ", then no need to debug anything lol

echo basalt Sep 5, 2022, 1:49 AM

#

I only throw exceptions when I'm doing something extremely wrong

tender shard Sep 5, 2022, 1:49 AM

#

I got a method for that, 1 sec

echo basalt Sep 5, 2022, 1:49 AM

#

like trying to load a template that never existed

tender shard Sep 5, 2022, 1:50 AM

#

https://github.com/JEFF-Media-GbR/JeffLib/blob/master/core/src/main/java/com/jeff_media/jefflib/InventoryUtils.java#L149

GitHub

JeffLib/InventoryUtils.java at master · JEFF-Media-GbR/JeffLib

Avoid writing the same code over and over again - use JeffLib for your Spigot plugins! - JeffLib/InventoryUtils.java at master · JEFF-Media-GbR/JeffLib

echo basalt Sep 5, 2022, 1:50 AM

#

But from an API point of view, getting a canvas frame at the exact location of the pixel might return null sometimes

#

it'd be extremely unsettling if I got a result during my optimized calls because I make sure to validate my inputs

#

yet it's still a very valid possibility

tender shard Sep 5, 2022, 1:51 AM

#

tender shard https://github.com/JEFF-Media-GbR/JeffLib/blob/master/core/src/main/java/com/jef...

line 149 is only for materials, line 172 is for actual itemstacks

echo basalt Sep 5, 2022, 1:52 AM

#

tender shard https://github.com/JEFF-Media-GbR/JeffLib/blob/master/core/src/main/java/com/jef...

Do you really hate regular for loops so much that you go atomic just to have a 1 line stream smh my head

tender shard Sep 5, 2022, 1:52 AM

#

echo basalt Do you really hate regular for loops so much that you go atomic just to have a 1...

wdym?

echo basalt Sep 5, 2022, 1:52 AM

#

line 77

#

feels wasteful

tender shard Sep 5, 2022, 1:52 AM

#

oh that

#

yeah it's probably not the fastest way

echo basalt Sep 5, 2022, 1:52 AM

#

also items might be null

tender shard Sep 5, 2022, 1:53 AM

#

but what I sent uses regular for loops

echo basalt Sep 5, 2022, 1:53 AM

#

not sure how the stream handles that

#

int amount = 0;
for(ItemStack item : inventory.getContents())
  if(itemStack.isSimilar(item)) // not the other way around, nullability
    amount += item.getAmount();

return amount;

#

add braces if you want

#

I've been adding braces lately but my hands are hella sweaty and it's uncomfortable to type

tender shard Sep 5, 2022, 1:54 AM

#

echo basalt ``` int amount = 0; for(ItemStack item : inventory.getContents()) if(itemStack...

the good thing about open source is, that I can just say this:
"Pull request it if it bothers you" 😛

echo basalt Sep 5, 2022, 1:54 AM

#

fuck no I'm not importing your lib into my IDE

tender shard Sep 5, 2022, 1:54 AM

#

if you dont fix it yourself, you must not complain 😛

vocal cloud Sep 5, 2022, 1:55 AM

#

PR every character change separately

echo basalt Sep 5, 2022, 1:55 AM

#

consider it merely as a fine suggestion towards a replacement

echo basalt Sep 5, 2022, 1:55 AM

#

vocal cloud PR every character change separately

I'll make 1 commit per character change

#

then have a PR with like 200 commits

tender shard Sep 5, 2022, 1:55 AM

#

yes, will do. I think you're also right about the stream thing breaking when a slot is empty

echo basalt Sep 5, 2022, 1:55 AM

#

and hide some malware in one of them towards the middle

tender shard Sep 5, 2022, 1:55 AM

#

tender shard yes, will do. I think you're also right about the stream thing breaking when a s...

but on the other hand

#

it seemed to have worked by now

#

so I guess it's fine

#

EVERYTHING that's inside JeffLib is used somewhere in one of my plugins so I guess it does actually work fine

vocal cloud Sep 5, 2022, 1:56 AM

#

Time to PR and change that /s

quartz solstice Sep 5, 2022, 1:56 AM

#

Does anyone know how to store data about a player in spigot

tender shard Sep 5, 2022, 1:57 AM

#

quartz solstice Does anyone know how to store data about a player in spigot

what MC version?

quartz solstice Sep 5, 2022, 1:57 AM

#

1.19.2

tender shard Sep 5, 2022, 1:57 AM

#

quartz solstice 1.19.2

https://blog.jeff-media.com/persistent-data-container-the-better-alternative-to-nbt-tags/

JEFF Media Developer Blog

mfnalex

Persistent Data Container: the better alternative to NBT Tags

quartz solstice Sep 5, 2022, 1:58 AM

#

ok

#

i see

#

how would i use to make a cooldown for running a certain command

#

would i like remember the time last sent

tender shard Sep 5, 2022, 1:59 AM

#

quartz solstice how would i use to make a cooldown for running a certain command

I also got a class for that

#

1 sec

#

https://github.com/JEFF-Media-GbR/JeffLib/blob/master/core/src/main/java/com/jeff_media/jefflib/data/Cooldown.java

GitHub

JeffLib/Cooldown.java at master · JEFF-Media-GbR/JeffLib

Avoid writing the same code over and over again - use JeffLib for your Spigot plugins! - JeffLib/Cooldown.java at master · JEFF-Media-GbR/JeffLib

quartz solstice Sep 5, 2022, 2:00 AM

#

ty

tender shard Sep 5, 2022, 2:01 AM

#

example usage:

public class MyCommand extends CommandExecutor {
  private final Cooldown cooldown = new Cooldown();

  public void onCommand(...) {
    if(cooldown.hasCooldown(sender)) {
      sender.sendMessage("You gotta wait before running this again!");
      return;
    }
    cooldown.setCooldown(sender, 60, TimeUnit.SECOND);
    // Do your stuff. Players can only run this every 60 seconds
    }

echo basalt Sep 5, 2022, 2:09 AM

#

command api when

#

👀

tender shard Sep 5, 2022, 2:10 AM

#

from me? never

echo basalt Sep 5, 2022, 2:10 AM

#

maybe you can take some inspiration from mine

tender shard Sep 5, 2022, 2:10 AM

#

I just use ACF ❤️

echo basalt Sep 5, 2022, 2:10 AM

#

fuck

tender shard Sep 5, 2022, 2:10 AM

#

i dont get the hate against ACF

echo basalt Sep 5, 2022, 2:10 AM

#

I just don't like annotations tbh

tender shard Sep 5, 2022, 2:10 AM

#

yeah well

#

but why not

echo basalt Sep 5, 2022, 2:11 AM

#

also seems jank to shade like 200kb worth of parser stuff

#

annotations use reflections

#

and I'm a performance freak

tender shard Sep 5, 2022, 2:11 AM

#

but who cares whether your plugins takes 20ns to enable, or 7ms?

echo basalt Sep 5, 2022, 2:11 AM

#

I go to bed, spin for an hour, and get back to work because I want to optimize that 1 tiny method

#

code for another 3 hours and then sleep

tender shard Sep 5, 2022, 2:11 AM

#

idk I wouldnt bother about stuff like that

#

when people send a spark or timings report, then it's time to start optimizing stuff

#

but before that? naaaah thanks

echo basalt Sep 5, 2022, 2:12 AM

#

what if it's async

#

yet still takes more than 0.05ms

wet breach Sep 5, 2022, 2:12 AM

#

this isn't what the image says

tender shard Sep 5, 2022, 2:12 AM

#

noone ever complained to me that my plugin is 200kb bigger because of ACF, or that they doing /somecommand took 0.0003ms instead of 0.0001ms

echo basalt Sep 5, 2022, 2:12 AM

#

Eh

wet breach Sep 5, 2022, 2:13 AM

#

tender shard noone ever complained to me that my plugin is 200kb bigger because of ACF, or th...

https://tenor.com/view/complaining-complain-complaint-unacceptable-gary-vaynerchuk-gif-14838782

Tenor

echo basalt Sep 5, 2022, 2:13 AM

#

I'd pitch rewriting hypixel in Assembly if the guys ever accepted me

tender shard Sep 5, 2022, 2:13 AM

#

just check for "s" at the end?

echo basalt Sep 5, 2022, 2:13 AM

#

actually I got most devs on my friend list

#

time to spam them

wet breach Sep 5, 2022, 2:13 AM

#

am I part of most devs?

tender shard Sep 5, 2022, 2:14 AM

#

then it would be "exodus' zombie"

#

no

echo basalt Sep 5, 2022, 2:14 AM

#

if it ends with an s

tender shard Sep 5, 2022, 2:14 AM

#

it should be "exodus' zombie"

echo basalt Sep 5, 2022, 2:14 AM

#

then you add a '

echo basalt Sep 5, 2022, 2:14 AM

#

wet breach am I part of most devs?

I meant hypixel devs

#

tender shard Sep 5, 2022, 2:14 AM

#

check if it ends with "s" and yes, add "'". Otherwise, add "'s"

wet breach Sep 5, 2022, 2:14 AM

#

just so you know this won't work the way you expect

tender shard Sep 5, 2022, 2:14 AM

#

oh and for X too

#

e.g. "alex' pet"

#

"Linus' pet"

#

"Thommy's pet"

#

etc

echo basalt Sep 5, 2022, 2:15 AM

#

Illusion's - belongs to illusion
parent's - belongs to either parent
parents' - belongs to both parents

wet breach Sep 5, 2022, 2:15 AM

#

so getDisplayName is effected by nicknames just fyi, unless that is your intention

tender shard Sep 5, 2022, 2:15 AM

#

echo basalt Illusion's - belongs to illusion parent's - belongs to either parent parents' - ...

yeah

wet breach Sep 5, 2022, 2:16 AM

#

second if you are trying to add

#

's

tender shard Sep 5, 2022, 2:16 AM

#

i'd just check for "x" or "s" at end, if yes: add one '
otherwise add 's

tender shard Sep 5, 2022, 2:16 AM

#

tender shard i'd just check for "x" or "s" at end, if yes: add one `'` otherwise add `'s`

this will probably work in 99.99% of cases

#

yeah

#

but I'd also move this into an own method

#

e.g. getPetName(String playersName)

#

maybe you'll some day wanna add more stuff than just Undying zombies

#

if you can put something into its own method, then you should always do that

echo basalt Sep 5, 2022, 2:18 AM

#

private final String TEXT_MASK = "xs";

public static String reference(String input) {
  char lastChar = input.charAt(input.length() - 1);
  input += "'";
  
  if(!TEXT_MASK.contains(lastChar))
    input += "s";
  
  return input
}

#

^ is the "little shit that likes to use constants" approach

tender shard Sep 5, 2022, 2:19 AM

#

Alex' zombie

#

no

#

@wet breach is from USA so he must know it

echo basalt Sep 5, 2022, 2:20 AM

#

public static String reference(String input) {
  if(input.endsWith("x") || input.endsWith("s"))
    return input + "'";

  return input + "'s";
}

is probably the most common approach

tender shard Sep 5, 2022, 2:20 AM

#

is it "alex' zombie" or "alex's zombie"?

echo basalt Sep 5, 2022, 2:20 AM

#

I'd say alex's zombie

#

honestly

tender shard Sep 5, 2022, 2:20 AM

#

I'm pretty sure that it's "alex' zombie"

wet breach Sep 5, 2022, 2:20 AM

#

This would be correct for possessiveness

tender shard Sep 5, 2022, 2:20 AM

#

hm

#

maybe I learnt it wrong then

echo basalt Sep 5, 2022, 2:20 AM

#

https://socratic.org/questions/when-a-noun-ends-in-x-where-does-the-possessive-apostrophe-go#:~:text=The possessive form of nouns,lid would not close properly.

Socratic.org

When a noun ends in "x" where does the possessive apostrophe go? | ...

The apostrophe is placed between the 'x' and the 's'. The possessive form of nouns ending with 'x' will have the apostrophe placed between the 'x' and the 's'. For example: Rex's favourite ball was lost. The box's lid would not close properly. The farmer cleaned the ox's shed.

#

box's color

#

box color

#

I'd say box's color

tender shard Sep 5, 2022, 2:21 AM

#

they agree with you

#

english being weird again

wet breach Sep 5, 2022, 2:21 AM

#

if ends with an s using ' only is acceptable

echo basalt Sep 5, 2022, 2:21 AM

#

don't do s's

#

that's bad

tender shard Sep 5, 2022, 2:21 AM

#

wet breach if ends with an s using `'` only is acceptable

but the screenshot I sent says that it should be "Jesus's zombie"

echo basalt Sep 5, 2022, 2:21 AM

#

example

#

gangstas's guns

tender shard Sep 5, 2022, 2:22 AM

#

you could also just do "Undying zombie of Alex" lol

wet breach Sep 5, 2022, 2:22 AM

#

tender shard but the screenshot I sent says that it should be "Jesus's zombie"

This is also acceptable because it is a proper pronoun, really the only exception

tender shard Sep 5, 2022, 2:22 AM

#

"The Undying Zombie owned by Alex"

#

lol

echo basalt Sep 5, 2022, 2:22 AM

#

if we're having a 10 minute argument over something this irrevelant, the plugin will be baller

wet breach Sep 5, 2022, 2:22 AM

#

Grammar is a pain in the US

#

or in English in general

tender shard Sep 5, 2022, 2:23 AM

#

wet breach Grammar is a pain in the US

the whole english language is fucked

echo basalt Sep 5, 2022, 2:23 AM

#

make a phonetic parser

#

feed it through a neuralnetwork

#

and have consistently wrong results

tender shard Sep 5, 2022, 2:23 AM

#

or just make players enter a custom name for their zombie

wet breach Sep 5, 2022, 2:23 AM

#

tender shard the whole english language is fucked

Yeah I don't like it either. There is too many rules that end up being contradicted later and it was always upsetting the way they teach you in school

#

one year you learn something new

#

the following year, you learn what you learned last year isn't exactly true

tender shard Sep 5, 2022, 2:24 AM

#

wet breach Yeah I don't like it either. There is too many rules that end up being contradic...

exactly. and the pronounciation is kinda random at times

#

but german is also weird. we have random genders for every word

#

car is neutral, woman is obviously female, but the plural of "man" is also female

wet breach Sep 5, 2022, 2:24 AM

#

lol

tender shard Sep 5, 2022, 2:25 AM

#

lol wtf

#

who the fuck eats a whole pig('s) head

wet breach Sep 5, 2022, 2:25 AM

#

for instance when you learn i before e, except after c So we learn this in school, but when you get to high school, you learn that this is actually false for so many things >>

tender shard Sep 5, 2022, 2:26 AM

#

wet breach for instance when you learn `i before e, except after c` So we learn this in sc...

yeah but there's so many exceptions to this

wet breach Sep 5, 2022, 2:26 AM

#

for instance neighbor does not follow this rule

tender shard Sep 5, 2022, 2:26 AM

#

caffeine

#

protein

#

keith

wet breach Sep 5, 2022, 2:26 AM

#

exactly and it was annoying that what I was taught in school was wrong >>

tender shard Sep 5, 2022, 2:26 AM

#

seizure

buoyant viper Sep 5, 2022, 2:26 AM

#

i mean do names really count

tender shard Sep 5, 2022, 2:27 AM

#

buoyant viper i mean do names really count

probably not

#

but e.g. seizure

#

weird

lost matrix Sep 5, 2022, 2:37 AM

#

getTargetBlockExact or something

quartz solstice Sep 5, 2022, 2:37 AM

#

How would I get a player variable based on their ign

lost matrix Sep 5, 2022, 2:38 AM

#

quartz solstice How would I get a player variable based on their ign

Bukkit.getPlayer(String)
But you should avoid using igns at all. Always use their UUIDs where possible.

quartz solstice Sep 5, 2022, 2:39 AM

#

Well I am creating a command where you request to tp to another player using their ign, so I can't really use UUIDs

tender shard Sep 5, 2022, 2:42 AM

#

Player player = Bukkit.getPlayer(args[0]);
if(player == null) {
  // send error message that this player isnt online
} else {
  // teleport
}

#

sth like this?

#

or using ACF 😄

@CommandAlias("tp")
public void onTp(Player sender, Player target) {
  ...
}

#

ACF is such a time savor

white root Sep 5, 2022, 2:50 AM

#

Ok, so the whole chat formatting mess really has me feeling stupid rn.

Right now, I have a .parseColors() method that replaces normal color codes and hex colors (#rrggbb) with their ChatColor.of(color) format, and using player#sendMessage, it sends fine, colors and all.
But when I feed it into either TextComponent() or TextComponent.fromLegacyText(), the hex color formatting seems to just disappear.

Im trying to use components because in my plugin's config file, there are user defined strings that need to have (a pre-defined) click and hover actions, in addition to having both their normal and hex colors parsed.

This is my code: https://uploadi.ng/🧆📜🤷🍴 [first screenshot attached]
and this is the output: https://uploadi.ng/🦙🥜👄🔏 [second screenshot attached]

Can someone help me figure out how to parse the normal and hex colors from the config string, then apply click and hover actions to it?

@𝕄𝕣. 𝕄𝕔𝕐𝕖𝕖𝕥#9300

C:\Users\MrMcyeet\Images\idea64_FnfxwlM2CE43.png

@𝕄𝕣. 𝕄𝕔𝕐𝕖𝕖𝕥#9300

C:\Users\MrMcyeet\Images\javaw_VV6LzVJ7KP2D.png

tender shard Sep 5, 2022, 2:52 AM

#

white root Ok, so the whole chat formatting mess really has me feeling stupid rn. Right no...

try to use legacy hex color format and see if it fixes it

#

e.g. like this:

#

String message = ChatColor.translateAlternateColorCodes('&', "&x&f&f&0&0&0&0This should be solid red");

white root Sep 5, 2022, 3:00 AM

#

So doing that does let me send a red message (sending it with player#sendMessage()) but how do I then add hover and click actions to that?
When I use TextComponent.fromLegacyText(/* your example */),
it outputs an array of baseComponents ( https://uploadi.ng/🎋🐚🦃🌠 ), so it seems like I can't just do message.clickEvent = blablabla

Is there some way to make TextComponent.fromLegacyText() not output an array? Or some way to merge the elements from the resulting array into one baseComponent or chatComponent

@𝕄𝕣. 𝕄𝕔𝕐𝕖𝕖𝕥#9300

C:\Users\MrMcyeet\Images\idea64_wphRafczati0.png

tender shard Sep 5, 2022, 3:05 AM

#

white root So doing that does let me send a red message (sending it with player#sendMessage...

good question

#

I also had this issue once and I somehow solved this but tbh I have no idea how

#

lemme check if I find it

#

but to answer your first question: It will always return an array because it basically splits the string by colors

#

e.g. "&aGreen&cRed" will return two components, "Green" with green color and "Red" with red color

#

hm I don't remember in which plugin I added the click event but it's definitely somehow possible. Unofrunately I don't find it right now :/

#

@white root cant you just do stuff like this?

#

        BaseComponent[] components = TextComponent.fromLegacyText("§cRed§aGreen");
        components[1].setClickEvent(...);

#

this SHOULD add a click event to the "Green" part

white root Sep 5, 2022, 3:15 AM

#

tender shard ```java BaseComponent[] components = TextComponent.fromLegacyText("§cRed...

Actually, that isnt a bad idea, I can just iterate over the components, but again I feel dumb for not seeing a way of doing this, but how do I send that array of baseComponents to players?
Intellij seems to like nether player#sendMessage(BaseComponent[]) nor player#spigot()#sendMessage(BaseComponent[])
https://uploadi.ng/😇🧑🙅🍔

@𝕄𝕣. 𝕄𝕔𝕐𝕖𝕖𝕥#9300

C:\Users\MrMcyeet\Images\idea64_jn8imwl4WmiU.png

tender shard Sep 5, 2022, 3:15 AM

#

if you want to add a click event too the whole message, then you gotta add it to ALL the array elements

#

huh

#

sendMessage DOES take a BaseComponent... thing

#

#

maybe you missed it because it's a varargs method?

#

this is part of Player.Spigot

white root Sep 5, 2022, 3:19 AM

#

I'm not sure, Intellij seems to think im crazy for trying this
https://uploadi.ng/💛🌞🔈📷

@𝕄𝕣. 𝕄𝕔𝕐𝕖𝕖𝕥#9300

C:\Users\MrMcyeet\Images\idea64_t4oEWQaWqXjc.png

tender shard Sep 5, 2022, 3:20 AM

#

hm that is weird. In your screenshot, I can see that the second "suggestion" shows the BaseComponent varargs method

#

I mean, you're using kotlin, but normally that should work totally fine

white root Sep 5, 2022, 3:22 AM

#

The only thing that I can think of is that im building against 1.16 spigot api org.spigotmc:spigot-api:1.16.5-R0.1-SNAPSHOT, but even if I change that to 1.19, its still the same

tender shard Sep 5, 2022, 3:22 AM

#

what error message do you get when you try to compile it anyway, besides IntelliJ complaining?

tender shard Sep 5, 2022, 3:22 AM

#

white root The only thing that I can think of is that im building against 1.16 spigot api `...

nah that's no problem. this whole component thing has existed at least since 1.13 IIRC

white root Sep 5, 2022, 3:23 AM

#

tender shard what error message do you get when you try to compile it anyway, besides Intelli...

https://nekobin.com/tohenihixa

tender shard Sep 5, 2022, 3:23 AM

#

wow that's weird. it literally tells you that there's a varargs BaseComponent... function

tender shard Sep 5, 2022, 3:24 AM

#

tender shard

sorry no idea. It does work in normal java, as I showed here :/

#

what happens if you replace "val" with an explicit BaseComponent[] ?

#

I dont know much stuff about kotlin so no idea if this might fix it

#

like, try to explain to the kotlin compiler that "test2" is actually a BaseComponent array

#

(although normally it should know it already, so yeah, no idea :/ )

white root Sep 5, 2022, 3:27 AM

#

tender shard sorry no idea. It does work in normal java, as I showed here :/

Ok, copying what you wrote, and having intellij translate it to kotlin provided a syntax that Ive never seen before, and put player.spigot().sendMessage(*components)

on changing my code to it.spigot().sendMessage(*test2), intellij doesnt complain, give me a moment and Ill see if it actually runs

tender shard Sep 5, 2022, 3:27 AM

#

white root Ok, copying what you wrote, and having intellij translate it to kotlin provided ...

oh, that's weird lol

#

it might have something to do with the fact that it has the exclamation mark in this method signature

white root Sep 5, 2022, 3:29 AM

#

that just means that it cant be null in kotlin, I think

tender shard Sep 5, 2022, 3:29 AM

#

IIRC this is kotlins' version of saying "not null"

#

yeah

white root Sep 5, 2022, 3:31 AM

#

white root Ok, copying what you wrote, and having intellij translate it to kotlin provided ...

So doing some research, that is kotlin's spread operator (since im a js dev, learning kotlin, I had tried using javascript's "...variable" spread syntax, but wrong format haha. -200 iq moment)
anyway yeah, using player.spigot().sendMessage(*test2) does indeed work

tender shard Sep 5, 2022, 3:31 AM

#

nice! Now you only gotta check if it actually works ingame, too 😄

white root Sep 5, 2022, 3:31 AM

#

It does indeed :dogekek:

tender shard Sep 5, 2022, 3:31 AM

#

oh okay, perfect

white root Sep 5, 2022, 3:32 AM

#

You have no idea how long I spent this morning feeling dumb trying to mess with kyori, spigot's chat api and bungee's chat api trying to figure out how to just send the messages I was formatting lmao

#

Anyway, tysm <3

tender shard Sep 5, 2022, 3:32 AM

#

no problem :3

#

im kinda surprised myself that I could help because I have absolutely no idea about kotlin lol

#

yeah NMS is a hell in some regards

#

what exactly are you struggling with?

#

"mob keys"?

haughty idol Sep 5, 2022, 3:54 AM

#

hey y'alll, so i'm trying to code cooldowns and have no idea where to start, so i'd like a push in the right direction- like just the starting point and i can take it from there

#

i have a bunch of classes and i don't want to copy code too so i'd prefer to have a function in a class and reference it in other classes

lost matrix Sep 5, 2022, 3:56 AM

#

Use unix timestamps (longs) and Maps.
First map each player to a CooldownContainer (A data class you write)
and then inside this container you map a String to a Long so you can
have named cooldown.

When an action occurs you simply check if the timestamp is in the future or past.
If you need a countdown or something similar then use a task that checks the timestamp
every so often against the current time,

haughty idol Sep 5, 2022, 3:56 AM

#

hm

#

okay

#

so could i put this in a function in, lets say, my main java class?

#

and if so where?

#

i guess i could do a public static right inside the class

#

and could i use the config files for this?

#

i'm not good at SQL

#

unless i'm dumb and its not sql

lost matrix Sep 5, 2022, 3:59 AM

#

Dont use any statics for this whatsoever.
Learn java and abandon the static keyword for a while.
The only things you can make static are constants like

public static final double PI = 3.14

Thats it. No more static for you.

haughty idol Sep 5, 2022, 4:00 AM

#

ah

#

okay

#

public CooldownContainer cooldownContainer = new CooldownContainer(); would this work?

#

and then i'd make a new java class correct?

#

called cooldown container

lost matrix Sep 5, 2022, 4:01 AM

#

The first thing you want is a CooldownManager
And you only create a single instance of this manager.

haughty idol Sep 5, 2022, 4:01 AM

#

okay

#

this is a class, correct?

lost matrix Sep 5, 2022, 4:01 AM

#

This manager manages a Map<UUID, CooldownContainer> with all the CRUD methods.

#

And every CooldownContainer has a Map<String, Long> representing the named cooldowns.

haughty idol Sep 5, 2022, 4:03 AM

#

private final Map<UUID, CooldownContainer> cooldowns = new HashMap<>();

lost matrix Sep 5, 2022, 4:03 AM

#

Yes this is a class. And you make it a singleton. This manager should only ever have one instance and then
you dont create another one. This instance should be in your JavaPlugin class and either passed through the constructor
of other classes or being retrieved by a getter.

lost matrix Sep 5, 2022, 4:04 AM

#

haughty idol ```private final Map<UUID, CooldownContainer> cooldowns = new HashMap<>();```

Looks good

#

Important design note:
Never every create getters or setters for Maps, Lists, Sets or other data structures.
Never.

haughty idol Sep 5, 2022, 4:05 AM

#

okay

#

soo

#

i'll start

#

wouldn't this technically be inefficient, according to this wiki i found https://www.spigotmc.org/wiki/feature-command-cooldowns/

lost matrix Sep 5, 2022, 4:07 AM

#

Not its as efficient as it gets.

#

You can check timestamps millions of times per minute if you wanted and the server wouldnt even notice.

haughty idol Sep 5, 2022, 4:08 AM

#

how would i tweak this cooldown in each ability?

lost matrix Sep 5, 2022, 4:09 AM

#

You make the cooldowns agnostic. Dont think about which application will use them later.
Just make it modular.

#

Thats what the Map<String, Long> is for.
You will be able to set cooldowns for everything you want.

haughty idol Sep 5, 2022, 4:09 AM

#

orr i could make a setter :))

#

(jk (?))

#

    private final Map<UUID, CooldownContainer> cooldowns = new HashMap<>();
    public static final int defaultCooldown = 15;``` i got this so far

#

i'm not rlly good at this

#

twt

lost matrix Sep 5, 2022, 4:11 AM

#

The first line is useless

haughty idol Sep 5, 2022, 4:11 AM

#

ok

#

should i still have the cooldowncontainer class?

lost matrix Sep 5, 2022, 4:12 AM

#

Yes of course.

haughty idol Sep 5, 2022, 4:12 AM

#

ok

#

so what should i put next?

#

hm

lost matrix Sep 5, 2022, 4:14 AM

#

What do you mean? Did you finish all the classes and methods?
If so then send them first.

haughty idol Sep 5, 2022, 4:14 AM

#

uh

remote swallow Sep 5, 2022, 4:14 AM

#

?paste

undone axleBOT Sep 5, 2022, 4:14 AM

#

https://paste.md-5.net/

haughty idol Sep 5, 2022, 4:14 AM

#

lost matrix What do you mean? Did you finish all the classes and methods? If so then send th...

i'm sorry it's like 12 or so and i'm really tired, which classes and methods?

lost matrix Sep 5, 2022, 4:15 AM

#

The CooldownManager with all the CRUD methods
The CooldownContainer with all the CRUD methods

CRUD=
Create
Remove
Update
Delete

haughty idol Sep 5, 2022, 4:16 AM

#

https://paste.md-5.net/ejoxusavuy.java this is all i have so far

#

i'm sorry, i've only been coding plugins for about a week now twt

lost matrix Sep 5, 2022, 4:17 AM

#

Ok so the cooldown manager only needs a single map for now.
Map<UUID, CooldownContainer>
Nothing else.
Then you add the CRUD methods.
Create the CooldownContainer class but leave it empty for now.

haughty idol Sep 5, 2022, 4:18 AM

#

okay

#

i'm applying crud to the cooldowns

#

right?

#

so i add the player, remove them, then update the cooldown container then delete the map?

#

i'm sorry i'm half asleep

#

gonna try to figure it out tomorrow

#

thanks so much for the help

lost matrix Sep 5, 2022, 4:21 AM

#

public class CooldownManager {

  private final Map<UUID, CooldownContainer> cooldownContainerMap = new HashMap<>();

  public CooldownContainer createContainer(UUID playerId) {
    CooldownContainer container = new CooldownContainer();
    cooldownContainerMap.put(playerId, new CooldownContainer());
    return container;
  }

  public CooldownContainer removeContainer(UUID playerId) {
    return cooldownContainerMap.remove(playerId);
  }

  public CooldownContainer getContainer(UUID playerId) {
    return cooldownContainerMap.get(playerId);
  }

}

haughty idol Sep 5, 2022, 4:22 AM

#

aa okay

lost matrix Sep 5, 2022, 4:22 AM

#

This is how your typical manager class looks like

haughty idol Sep 5, 2022, 4:22 AM

#

thanks

#

hold on i'm gonna read it

lost matrix Sep 5, 2022, 4:22 AM

#

Player joins -> create or load container
Player quits -> remove and save container
On runtime -> you get the container and use it

haughty idol Sep 5, 2022, 4:23 AM

#

so in the playerjoin event i should run createContainer(pUUID)

#

    public static CooldownManager getCdInstance() {
        return cdInstance;
    }``` in the javaplugin class

lost matrix Sep 5, 2022, 4:24 AM

#

No statics

haughty idol Sep 5, 2022, 4:24 AM

#

oh yeah

lost matrix Sep 5, 2022, 4:24 AM

#

shush

haughty idol Sep 5, 2022, 4:25 AM

#

cdInstance = new CooldownManager(); we instantiate it in the onEnable();

lost matrix Sep 5, 2022, 4:25 AM

#

Yes. And then we pass this instance through constructors or create a getter for it.

haughty idol Sep 5, 2022, 4:26 AM

#

i like getters SMH

#

just kidding i'm just using a template so i can't use a constructor here

#

CooldownManager cooldownManager = plugin.getCdInstance();

#

on join

#

        UUID pUUID = p.getUniqueId();
        String pUUIDString = pUUID.toString();
        CooldownManager cooldownManager = plugin.getCdInstance();
        cooldownManager.createContainer(pUUID);```

#

so this should create a container

lost matrix Sep 5, 2022, 4:29 AM

#

Yes. What is the String for?

#

Remove it

haughty idol Sep 5, 2022, 4:29 AM

#

it's for other stuff in the evetn

lost matrix Sep 5, 2022, 4:29 AM

#

Oh god...

haughty idol Sep 5, 2022, 4:29 AM

#

look, right now i'm using config.yml as a database

#

there's much worse stuff i'm doing than making a pUUIDString

#

so where does the Delete come in for CRUD

#

okay so how do i use this now

#

let's say... in my Mage handler

lost matrix Sep 5, 2022, 4:32 AM

#

We are not at this point

haughty idol Sep 5, 2022, 4:32 AM

#

oh

#

okay

#

so what next

#

i added and removed it

lost matrix Sep 5, 2022, 4:32 AM

#

One moment

haughty idol Sep 5, 2022, 4:32 AM

#

mk

#

do u mind if i go get some water

lost matrix Sep 5, 2022, 4:35 AM

#

public class CooldownContainer implements ConfigurationSerializable {

  private final Map<String, Long> cooldownMap = new HashMap<>();

  public CooldownContainer(Map<String, Object> map) {
    map.forEach((key, value) -> cooldownMap.put(key, (long) value));
  }

  public CooldownContainer() {
    this(new HashMap<>());
  }

  public void setCooldownFromNow(String name, long millis) {
    cooldownMap.put(name, System.currentTimeMillis() + millis);
  }

  public long getCooldownLeft(String name) {
    return System.currentTimeMillis() - cooldownMap.getOrDefault(name, Long.MAX_VALUE);
  }

  public boolean isCooldownDone(String name) {
    return getCooldownLeft(name) <= 0;
  }

  @NotNull
  @Override
  public Map<String, Object> serialize() {
    return new HashMap<>(cooldownMap);
  }
}

lost matrix Sep 5, 2022, 4:35 AM

#

haughty idol do u mind if i go get some water

Stay hydrated

haughty idol Sep 5, 2022, 4:37 AM

#

back

#

okay do u mind letting me know what this does

#

cuz i really want to learn not copy code :/

lost matrix Sep 5, 2022, 4:38 AM

#

Ok so here is the CooldownContainer. It implements ConfigurationSerializable so that you can simply throw it in your ymls

haughty idol Sep 5, 2022, 4:38 AM

#

so i can put it into my config

#

ok cool

#

but i don't see anythign with the config in this code

lost matrix Sep 5, 2022, 4:38 AM

#

This is the important code.
Ignore the rest.

#

A container can have many different cooldown timestamps.
They are identified by a String.

haughty idol Sep 5, 2022, 4:40 AM

#

ok

#

ok first can you define a hashmap? i haven't done a deep delve into java yet so i'm not sure what it is :/

#

wait i can just search it up

#

oh

#

OH

#

so it's like the config file

#

but different

lost matrix Sep 5, 2022, 4:42 AM

#

A map is a data structure which maps a key to a value.
You put in a key and a value and on a later point you can get that value by using a key

haughty idol Sep 5, 2022, 4:42 AM

#

so like there's different values stored behind keys

#

that's really cool actually

lost matrix Sep 5, 2022, 4:42 AM

#

haughty idol so it's like the config file

kinda

haughty idol Sep 5, 2022, 4:42 AM

#

so i can just plug in my player's uuid into the hashmap and get their cooldown

#

pretty cool lmfao

lost matrix Sep 5, 2022, 4:43 AM

#

Yes you get their CooldownContainer. And the container has a Map<String, Long>
So every player can have thousands of cooldowns. All you need is a name for the cooldown.

haughty idol Sep 5, 2022, 4:43 AM

#

        cooldownMap.put(name, System.currentTimeMillis() + millis);
    }```

#

so what are we doing there

#

we're just inputting the cooldown into the HashMap?

#

hold on need more water

#

it's a really hot day lmfao

drowsy helm Sep 5, 2022, 4:45 AM

#

brain overheating

lost matrix Sep 5, 2022, 4:45 AM

#

name is the name of the cooldown you want to set and millis is the time in milliseconds for this cooldown.
System.currentTimeMillis() returns the current time in millis.

In computer programs you will very often encounter the so called unix timestamp.
Its one number which started counting up at 01.01.1970 and will count for the next
couple of thousands of years.

#

This is how the current timestamp looks like.
You just have to think about 3 more digits at the end.
And this is the same for every computer.

haughty idol Sep 5, 2022, 4:48 AM

#

okay

#

so what does the unix timestamp have to do with our plugin

lost matrix Sep 5, 2022, 4:48 AM

#

You can think of this as a fixed point in time which is simply one long number counting the milliseconds

haughty idol Sep 5, 2022, 4:48 AM

#

mkay

#

it counts up every millisecond

lost matrix Sep 5, 2022, 4:49 AM

#

So

long future = System.currentTimeMillis() + 1500;

Is exactly 1.5s in the future.

haughty idol Sep 5, 2022, 4:49 AM

#

so system.currenttimemillis gets the unix timestamp?

#

so what's the difference in doubles and floats? and why use floats instead of doubles? aren't floats just like half the size in bytes

#

same for like longs and ints, or ints and shorts

lost matrix Sep 5, 2022, 4:51 AM

#

Imagine our current time is
50000
and our cooldown is
1000

Then we put 51000 in the map and every time something happens we check if the timestamp
is already over.

drowsy helm Sep 5, 2022, 4:51 AM

#

double just holds more precise fvalues

haughty idol Sep 5, 2022, 4:51 AM

#

drowsy helm double just holds more precise fvalues

mkay

drowsy helm Sep 5, 2022, 4:51 AM

#

float is 32 bit, 7 decimals. double is 64 bit idk how many decimals

#

but more

haughty idol Sep 5, 2022, 4:52 AM

#

so why use floats instead of doubles?

#

if doubles are more accurate?

drowsy helm Sep 5, 2022, 4:52 AM

#

sometimes you only really need like 2 decimals

#

no point using all that memory

haughty idol Sep 5, 2022, 4:52 AM

#

oh

lost matrix Sep 5, 2022, 4:52 AM

#

double = double precision floating point = 64bit float
float = 32bit float

long = 64bit int
int = 32bit int
short = 16bit int
byte = 8bit

haughty idol Sep 5, 2022, 4:52 AM

#

so it uses memory

#

i thought it jsut could STORE that much memory

#

so with this you can just choose how much memory to take up

#

thanks :)

drowsy helm Sep 5, 2022, 4:52 AM

#

nah, even a double d = 0 uses 64 bits

haughty idol Sep 5, 2022, 4:52 AM

#

i get it now

drowsy helm Sep 5, 2022, 4:52 AM

#

its how much it reserves

haughty idol Sep 5, 2022, 4:53 AM

#

oh

#

okay

#

yeayea that's what i emant

#

so @lost matrix in getCooldownLeft, you input the name and check if that time stamp has passed right?

#

and you return the amount of milliseconds left

#

and then in isCooldownDone you check if that cooldown is at 0

lost matrix Sep 5, 2022, 4:54 AM

#

Yes. For example if the timestamp is 51000 and the current time is 50500 then there are still 500ms left

haughty idol Sep 5, 2022, 4:54 AM

#

okay

#

you are REALLY helpful thanks so much for taking the time to explain stuff instead of just handing me the code :) it's really cool to do that

#

ok so next, we use these in runtime right?

lost matrix Sep 5, 2022, 4:56 AM

#

Yes. I actually think we should add new methods to cooldown manager just for simplicity

haughty idol Sep 5, 2022, 4:57 AM

#

okay

#

so these methods being?

#

hm

#

just tell me what they should do, i want to try doing them myself

lost matrix Sep 5, 2022, 4:58 AM

#

  public void setCooldownFromNow(UUID playerId, String name, long millis) {
    CooldownContainer container = getContainer(playerId);
    container.setCooldownFromNow(name, millis);
  }

  public long getCooldownLeft(UUID playerId, String name) {
    CooldownContainer container = getContainer(playerId);
    return container.getCooldownLeft(name);
  }

  public boolean isCooldownDone(UUID playerId, String name) {
    CooldownContainer container = getContainer(playerId);
    return container.isCooldownDone(name);
  }

haughty idol Sep 5, 2022, 4:58 AM

#

okay

lost matrix Sep 5, 2022, 4:58 AM

#

Oh didnt read

haughty idol Sep 5, 2022, 4:58 AM

#

its ok

#

just spoiler that

#

pwp

#

and i'll look at it if i give up

#

nvm i'll just not look at it

lost matrix Sep 5, 2022, 4:59 AM

#

You basically just want easier methods for setting and checking cooldowns without having to always get the CooldownContainer.

#

So you copy the 3 methods into your CooldownManager

setCooldownFromNow
getCooldownLeft
isCooldownDone

And add a UUID parameter.

haughty idol Sep 5, 2022, 5:01 AM

#

ok

#

i think i did iscooldown done

#

        CooldownContainer container = getContainer(pUUID);
        return container.isCooldownDone(name);
    }```

#

i tried

#

did i get it right

lost matrix Sep 5, 2022, 5:01 AM

#

Yes

#

thats right

haughty idol Sep 5, 2022, 5:02 AM

#

oh

#

so i can just access the thing and return it

#

ok not that hard

#

alright so not that hard

#

thanks for letting me do it myself :)

#

okay so now

#

we can access this ONE instance of cdmanager

lost matrix Sep 5, 2022, 5:03 AM

#

If you have all 3 methods then you are pretty much done

haughty idol Sep 5, 2022, 5:04 AM

#

CooldownManager cooldownManager = plugin.getCdInstance();

#

at the start of each method i'd like to use it in?

lost matrix Sep 5, 2022, 5:05 AM

#

Well you would want a field that store it

haughty idol Sep 5, 2022, 5:05 AM

#

uh

#

it is in a field

#

CooldownManager cooldownManager = plugin.getCdInstance();

we're putting the instance into this variable

#

right?

#

or am i dumb

lost matrix Sep 5, 2022, 5:08 AM

#

Example

public class SomeListener implements Listener {

  private final CooldownManager cooldownManager;

  public SomeListener(CooldownManager cooldownManager) {
    this.cooldownManager = cooldownManager;
  }

  @EventHandler
  public void onBreak(BlockBreakEvent event) {
    Player player = event.getPlayer();
    UUID playerId = player.getUniqueId();

    if(cooldownManager.isCooldownDone(playerId, "block_break")) {
      cooldownManager.setCooldownFromNow(playerId, "block_break", Duration.ofMinutes(1).toMillis());
    } else {
      player.sendMessage("Sry but you can only break one block per minute.");
      event.setCancelled(true);
    }
  }

  @EventHandler
  public void onPlace(BlockPlaceEvent event) {
    Player player = event.getPlayer();
    UUID playerId = player.getUniqueId();

    if(cooldownManager.isCooldownDone(playerId, "block_place")) {
      cooldownManager.setCooldownFromNow(playerId, "block_place", Duration.ofMinutes(1).toMillis());
    } else {
      player.sendMessage("Sry but you can only place one block per minute.");
      event.setCancelled(true);
    }
  }

}

haughty idol Sep 5, 2022, 5:09 AM

#

so the method you used was putting it into the constructor right? i'm using a getter

lost matrix Sep 5, 2022, 5:10 AM

#

Well then you pass your JavaPlugin instance in the constructor and use the getter. Same result.

haughty idol Sep 5, 2022, 5:10 AM

#

well you see

#

i have a getter for the java plugin

lost matrix Sep 5, 2022, 5:10 AM

#

  private final CooldownManager cooldownManager;

  public SomeListener(YourPlugin plugin) {
    this.cooldownManager = plugin.getCdManager();
  }

haughty idol Sep 5, 2022, 5:10 AM

#

CooldownManager cooldownManager = plugin.getCdInstance();```

#

heehee haha

#

i love getters

lost matrix Sep 5, 2022, 5:11 AM

#

Thats static abuse and i can assure your that it will lead to problems

haughty idol Sep 5, 2022, 5:11 AM

#

uh

lost matrix Sep 5, 2022, 5:11 AM

#

This here is the only other solution i would allow

  private final CooldownManager cooldownManager;

  public SomeListener() {
    ClassSystem plugin = ClassSystem.getInstance();
    this.cooldownManager = plugin.getCdManager();
  }

haughty idol Sep 5, 2022, 5:12 AM

#

i really can't use a constructor here

#

okay s

lost matrix Sep 5, 2022, 5:12 AM

#

Well as long as you are not using getters in field initializers your are fine

haughty idol Sep 5, 2022, 5:12 AM

#


import org.bukkit.event.player.PlayerInteractEvent;

public abstract class PlayerClassTemplate {

    public abstract void onTrigger(PlayerInteractEvent e);

}

#

this is my PlayerClassTemplate

#


import classsystem.classsystem.ClassSystem;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;

public class PlayerClassListener implements Listener {

    @EventHandler
    public void onInteract(PlayerInteractEvent e) {
        ClassSystem plugin = ClassSystem.getInstance();
        Player p = e.getPlayer();
        String pUUID = p.getUniqueId().toString();
        PlayerClass playerClass = PlayerClass.stringToClass(plugin.getConfig().getString(pUUID + ".class"));
        PlayerClassTemplate playerClassTemplate = playerClass.supplier.get();
        playerClassTemplate.onTrigger(e);
    }
}```

#

and this is my playerclasslistener

#

its just that i have so many classes and don't want to rewrite the same code

ornate mantle Sep 5, 2022, 5:13 AM

#

is there any way to run my 1.8 plugin on a 1.19 server?

haughty idol Sep 5, 2022, 5:13 AM

#

i also have an enum

drowsy helm Sep 5, 2022, 5:13 AM

#

ornate mantle is there any way to run my 1.8 plugin on a 1.19 server?

if its set up properly, yeah

lost matrix Sep 5, 2022, 5:13 AM

#

ornate mantle is there any way to run my 1.8 plugin on a 1.19 server?

?1.8

undone axleBOT Sep 5, 2022, 5:13 AM

#

https://howoldisminecraft188.today/

How old is Minecraft 1.8.8 today?

Too old! (Click the link to get the exact time)

ornate mantle Sep 5, 2022, 5:13 AM

#

or do i have to change every variable back to 1.19

lost matrix Sep 5, 2022, 5:13 AM

#

ornate mantle or do i have to change every variable back to 1.19

Do you use nms or craftbukkit?

ornate mantle Sep 5, 2022, 5:13 AM

#

1.8 is older than my sister 💀

#

nms

lost matrix Sep 5, 2022, 5:14 AM

#

Then there is no way to use it in any other version

ornate mantle Sep 5, 2022, 5:14 AM

#

massive bruh moment

haughty idol Sep 5, 2022, 5:14 AM

#

should i be using NMS in my plugin?

ornate mantle Sep 5, 2022, 5:14 AM

#

now i have to switch from spigot 1.8 mappings to 1.19 mojang mappings 😍

ornate mantle Sep 5, 2022, 5:14 AM

#

haughty idol should i be using NMS in my plugin?

no

haughty idol Sep 5, 2022, 5:14 AM

#

or CraftBukkit?

ornate mantle Sep 5, 2022, 5:14 AM

#

its painful its complicated its messy

haughty idol Sep 5, 2022, 5:14 AM

#

i don't use either rn

ornate mantle Sep 5, 2022, 5:14 AM

#

dont use nms unless you absolutely have to

#

which do you use rn

haughty idol Sep 5, 2022, 5:15 AM

#

uh

#

would you believe neither?

ornate mantle Sep 5, 2022, 5:15 AM

#

spigot is basically craftbukkit

#

i think

haughty idol Sep 5, 2022, 5:15 AM

#

then spigot

#

i love spigot

lost matrix Sep 5, 2022, 5:15 AM

#

You really dont need it if you use newer spigot versions.
Its really only viable for very specific and quite complicated topics.

haughty idol Sep 5, 2022, 5:15 AM

#

ah ok

lost matrix Sep 5, 2022, 5:16 AM

#

In trash versions like 1.8 you have to still clutter your code with a bunch
of garbage nms to use even the simplest of approaches.

lost matrix Sep 5, 2022, 5:17 AM

#

haughty idol ah ok

Btw dont use configs on runtime

#

When a player joins -> load all data from the config into classes
when he quits -> save all data from the classes back into the config

haughty idol Sep 5, 2022, 5:17 AM

#

"demeters_saturation" can you use _'s in the names of cooldown containers @lost matrix

haughty idol Sep 5, 2022, 5:18 AM

#

lost matrix Btw dont use configs on runtime

hahahahahaha this is how i store my player's class

#

wait

#

but why not

lost matrix Sep 5, 2022, 5:19 AM

#

You can as well just use "$%&§ BLib_ -- Blob ##Ü*" if you wanted to.

#

Its a String.

haughty idol Sep 5, 2022, 5:19 AM

#

oh yeah

#

so i can use spaces?

lost matrix Sep 5, 2022, 5:19 AM

#

sure

#

More context. Im assuming that your backend runs a newer version and that you use viaversion and viabackwards?

haughty idol Sep 5, 2022, 5:27 AM

#

@lost matrix thank you SO much for the help today :)

lost matrix Sep 5, 2022, 5:29 AM

#

Those plugins allow whitelisted versions

#

Yeah

haughty idol Sep 5, 2022, 5:29 AM

#

haughty idol <@220605553368498176> thank you SO much for the help today :)

uh- actually it's really buggy

lost matrix Sep 5, 2022, 5:30 AM

#

haughty idol uh- actually it's really buggy

Show some code

haughty idol Sep 5, 2022, 5:30 AM

#

https://paste.md-5.net/uficiyokoh.java here's my entire Cleric class

lost matrix Sep 5, 2022, 5:30 AM

#

I am not reading that mess

haughty idol Sep 5, 2022, 5:31 AM

#

fair

lost matrix Sep 5, 2022, 5:31 AM

#

I have not doubt that this is buggy has hell and that you will have to debug this for weeks

haughty idol Sep 5, 2022, 5:32 AM

#

man.

lost matrix Sep 5, 2022, 5:32 AM

#

You should extract this into like 5 different methods

haughty idol Sep 5, 2022, 5:32 AM

#

https://paste.md-5.net/rehatamili.py this is all the code that actually uses the cooldowns

#

well at least one of the abilities

floral drum Sep 5, 2022, 5:34 AM

#

owo

lost matrix Sep 5, 2022, 5:34 AM

#

Looks fine. Nothing wrong with this section

haughty idol Sep 5, 2022, 5:34 AM

#

hm

#

https://paste.md-5.net/iyilotomub.java this is my class system, it was basically copy pasted from you so it shouldn't have any bugs

lost matrix Sep 5, 2022, 5:35 AM

#

Each of those should be in their own method

haughty idol Sep 5, 2022, 5:35 AM

#

okay

#

i'll do that later after cooldowns work

#

not procrastinating dw about it

lost matrix Sep 5, 2022, 5:36 AM

#

You can mark the lines, right click -> Refactor -> Exctract Method

haughty idol Sep 5, 2022, 5:36 AM

#

waiat damn

lost matrix Sep 5, 2022, 5:38 AM

#

haughty idol Sep 5, 2022, 5:40 AM

#

coool

#

ok

#

so now

#

https://paste.md-5.net/kiyetitija.java is there anything wrong with this?

#

did i make a mistake with anything

#

OH WATI

haughty idol Sep 5, 2022, 5:42 AM

#

lost matrix ```java public void setCooldownFromNow(UUID playerId, String name, long millis...

so you see the long on the 2nd method

#

that's not supposed to be caps right

#

all lower case

#

okay

#

i got it

#

pls work

lost matrix Sep 5, 2022, 5:43 AM

#

doesnt really matter

haughty idol Sep 5, 2022, 5:43 AM

#

uh

#

pain

#

i'm gonna try anyway

lost matrix Sep 5, 2022, 5:43 AM

#

but yes. Best practice is to use primitives

#

Same in the second to last method

haughty idol Sep 5, 2022, 5:43 AM

#

ok

#

the cooldowns seem to be in reverse

haughty idol Sep 5, 2022, 5:44 AM

#

lost matrix Same in the second to last method

in which class?

lost matrix Sep 5, 2022, 5:44 AM

#

haughty idol Sep 5, 2022, 5:45 AM

#

yea that's the one i was talking about

haughty idol Sep 5, 2022, 5:45 AM

#

haughty idol the cooldowns seem to be in reverse

okay so when you do an ability you can spam it until the cooldown runs out

#

so its like wierd

#

weird

lost matrix Sep 5, 2022, 5:46 AM

#

Oh yeah this method is wrong

  public long getCooldownLeft(String name) {
    return System.currentTimeMillis() - cooldownMap.getOrDefault(name, Long.MAX_VALUE);
  }

Should be

  public long getCooldownLeft(String name) {
    return cooldownMap.getOrDefault(name, 0L) - System.currentTimeMillis();
  }

#

In CooldownContainer

haughty idol Sep 5, 2022, 5:46 AM

#

oh

#

okay so what's the difference

#

oh

#

dOSHFp

#

OH

#

i got it

#

thanks so much

#

pls say it works

#

FRICK YEAH

#

thanks so much smile :)

lost matrix Sep 5, 2022, 5:47 AM

#

nice

haughty idol Sep 5, 2022, 5:49 AM

#

hm its still acting a bit weird but it's way better than before

#

so milliseconds are 1/1000 of a second right?

#

so 5 seconds would be 5k milliseconds

lost matrix Sep 5, 2022, 5:52 AM

#

right

haughty idol Sep 5, 2022, 5:52 AM

#

then why is the cd of one of these 50 seconds and the cd of the top one is like .5 seconds lmfao

#

https://paste.md-5.net/uwunadubig.java

#

https://paste.md-5.net/yoporoyini.cpp (this is what activates the command if it's any help

lost matrix Sep 5, 2022, 5:53 AM

#

Sysout the modifier

haughty idol Sep 5, 2022, 5:54 AM

#

it should be 1.0

#

yep

#

[22:55:26 INFO]: 1.0
[22:55:26 INFO]: 1.0
[22:55:26 INFO]: 1.0
[22:55:27 INFO]: 1.0```

lost matrix Sep 5, 2022, 5:56 AM

#

#

They use the same cooldown?

haughty idol Sep 5, 2022, 5:56 AM

#

i'm so fudging dumb

#

yeah they work now

#

thanks so much

ornate mantle Sep 5, 2022, 6:07 AM

#

BRUH

#

java version isnt switching from java 8 to java 18

#

changed the environment variables and stuff

#

still stuck on java 8

lost matrix Sep 5, 2022, 6:08 AM

#

go into terminal and type in java -version

ornate mantle Sep 5, 2022, 6:08 AM

#

did

#

java version "1.8.0_202"
Java(TM) SE Runtime Environment (build 1.8.0_202-b08)
Java HotSpot(TM) 64-Bit Server VM (build 25.202-b08, mixed mode)

lost matrix Sep 5, 2022, 6:08 AM

#

Just install the latest jdk then

ornate mantle Sep 5, 2022, 6:09 AM

#

lost matrix Sep 5, 2022, 6:09 AM

#

https://adoptium.net/

Home | Adoptium

Eclipse Adoptium provides prebuilt OpenJDK binaries from a fully open source set of build scripts and infrastructure. Supported platforms include Linux, macOS, Windows, ARM, Solaris, and AIX.

#

Get the installer. It does everything for you.

ornate mantle Sep 5, 2022, 6:09 AM

#

its german

#

oh i was on the /de page

lost matrix Sep 5, 2022, 6:10 AM

#

I removed the de edning

ornate mantle Sep 5, 2022, 6:10 AM

#

yeah

#

miss the good old days when you spent hours debugging stuff and did everything by hand rather than an application doing everything for you

vocal cloud Sep 5, 2022, 6:28 AM

#

Can do it all by hand if you like lol

young knoll Sep 5, 2022, 6:30 AM

#

Change the path

#

Not java home

boreal seal Sep 5, 2022, 6:31 AM

#

intelliJ users

#

cloud explain me what this color says?

#

the getSeconds

#

why its colored that way?

young knoll Sep 5, 2022, 6:31 AM

#

Deprecated

vocal cloud Sep 5, 2022, 6:31 AM

#

Hovering it should tell you too

kindred valley Sep 5, 2022, 6:31 AM

#

boreal seal why its colored that way?

It says the method is in void

boreal seal Sep 5, 2022, 6:31 AM

#

oh it doesnt return anything

#

?

kindred valley Sep 5, 2022, 6:32 AM

#

No the method just deprecated

boreal seal Sep 5, 2022, 6:32 AM

#

so deprecated stays for in simple english?

#

i cloud google it yeah guys but i want an human being explanation

lost matrix Sep 5, 2022, 6:33 AM

#

Deprecation means this method is about to be removed and should not be used.
In almost all cases there is a better alternative for that method already implemented.

boreal seal Sep 5, 2022, 6:33 AM

#

oh

vocal cloud Sep 5, 2022, 6:33 AM

#

Read the docs for the method to find the better one

boreal seal Sep 5, 2022, 6:33 AM

#

so the hint it shows me is the better alternative?

vocal cloud Sep 5, 2022, 6:33 AM

#

Well it might if you have the documentation for it

boreal seal Sep 5, 2022, 6:34 AM

#

the other thing showed the same thing

#

ill just not give it attention might Date be outdated a bit

#

but its fine

#

i dont see a reason to switch it if it works it works

boreal seal Sep 5, 2022, 6:35 AM

#

lost matrix Deprecation means this method is about to be removed and should not be used. In ...

thanks alot from what i understand its basically the out dated shit 😄 and it pretty much tells me listen we not gonna support it in the new versions so stick to what we suggest instead

lost matrix Sep 5, 2022, 6:36 AM

#

boreal seal i dont see a reason to switch it if it works it works

Deprecated code should always be avoided if possible. Its very possible for you so avoid it.

boreal seal Sep 5, 2022, 6:36 AM

#

yeah i have so many ways to get correct second

lost matrix Sep 5, 2022, 6:36 AM

#

What do you need?

boreal seal Sep 5, 2022, 6:36 AM

#

im just trying to get current second

#

im storing it into an data class i make

lost matrix Sep 5, 2022, 6:37 AM

#

The current second in which context?

boreal seal Sep 5, 2022, 6:37 AM

#

int

#

just the second

#

not Hour not day

#

or actually a better question

lost matrix Sep 5, 2022, 6:37 AM

#

I dont understand. There is no "current second"

river oracle Sep 5, 2022, 6:38 AM

#

System#getCurrenrMilli

boreal seal Sep 5, 2022, 6:38 AM

#

yeah i dont need it

lost matrix Sep 5, 2022, 6:38 AM

#

Unless you are speaking about the unix timestamp

river oracle Sep 5, 2022, 6:38 AM

#

Should get thr current millisecond

#

Than divide

boreal seal Sep 5, 2022, 6:38 AM

#

ik we got either nanosecond..

#

i have different goal guys its alright thanks!

river oracle Sep 5, 2022, 6:38 AM

#

Lol u make no sense

lost matrix Sep 5, 2022, 6:38 AM

#

Whats your goal? There is 100% a better approach.

boreal seal Sep 5, 2022, 6:39 AM

#

i already think about making own timing system instead of comparing time...

#

so ill just make in the data class an integar that will be timer

#

i just make a player select a block and be able to execute commands

#

now i was thinking to make a timer to remove him from the block

river oracle Sep 5, 2022, 6:40 AM

#

Your making a timer? Why not just use a ticker for a timer seems nonsensical to use much else isn't that how timers work after all?

boreal seal Sep 5, 2022, 6:40 AM

#

instead of checking if he is near all the time

lost matrix Sep 5, 2022, 6:40 AM

#

boreal seal instead of checking if he is near all the time

#help-development message

Read from here. I explain the best possible approach for timers and cooldowns in great detail.

river oracle Sep 5, 2022, 6:40 AM

#

Alternatively if you don't need per tick updates just compare current millisecond timings

boreal seal Sep 5, 2022, 6:41 AM

#

but i cloud update it anyway ;/

#

if he selects a different door the hashmap will replace it

#

each time

river oracle Sep 5, 2022, 6:41 AM

#

Cloud update it? Wrf

lost matrix Sep 5, 2022, 6:41 AM

#

Always compare timestamps. Never ever manually update a timer.
Its an absolutely horrible idea.

river oracle Sep 5, 2022, 6:42 AM

#

boreal seal but i cloud update it anyway ;/

Bruh don't be storing your timer in a database lol

boreal seal Sep 5, 2022, 6:42 AM

#

i dont store in database

#

i store it in hashmap you told me to make own objects to store locations

#

so why dont i make either a timer inside of it and update it

river oracle Sep 5, 2022, 6:42 AM

#

Oh I wouldn't consider that the cloud lol

#

Mb

young knoll Sep 5, 2022, 6:42 AM

#

I think it was a mistype of could

river oracle Sep 5, 2022, 6:43 AM

#

Mf I'm dumb

boreal seal Sep 5, 2022, 6:43 AM

#

why?

lost matrix Sep 5, 2022, 6:43 AM

#

Ill just say this one more time and then im off to sleep.
Dont manually increment a timer
Its a really really bad idea. Worst possible performance.
Most possible code fragility and worst sync issues.

boreal seal Sep 5, 2022, 6:43 AM

#

you understand what i mean now?

boreal seal Sep 5, 2022, 6:44 AM

#

lost matrix Ill just say this one more time and then im off to sleep. **Dont manually increm...

i do decrecment timer and == if equals

#

remove from map

lost matrix Sep 5, 2022, 6:44 AM

#

Yes. Terrible

#

Te ri ble

boreal seal Sep 5, 2022, 6:44 AM

#

why its terriable but if i need update value each time

#

what you do compare if value is >

#

and if remove and allow

lost matrix Sep 5, 2022, 6:45 AM

#

I dont have the willpower to deal with this right now.
Read the message ive posted above. It has a bunch of code you can read through and utilize.

boreal seal Sep 5, 2022, 6:45 AM

#

ine

#

+=

ornate mantle Sep 5, 2022, 6:46 AM

#

can i use 1.19.2 nms plugins on a 1.19 server?

river oracle Sep 5, 2022, 6:46 AM

#

ornate mantle can i use 1.19.2 nms plugins on a 1.19 server?

?tas

undone axleBOT Sep 5, 2022, 6:46 AM

#

https://tryitands.ee

ornate mantle Sep 5, 2022, 6:46 AM

#

best answer

#

absolute genius

#

be a shame if i had no way of trying it

young knoll Sep 5, 2022, 6:47 AM

#

I believe it’s all the same NMS version

river oracle Sep 5, 2022, 6:47 AM

#

The simplest answer is

#

Depends

ornate mantle Sep 5, 2022, 6:47 AM

#

depends how

river oracle Sep 5, 2022, 6:47 AM

#

Depends what you use

#

Depends how it's used and where it's used

ornate mantle Sep 5, 2022, 6:47 AM

#

i dont think 1.19.1 and 2 added something relating to nms?

river oracle Sep 5, 2022, 6:47 AM

#

Depends you'd have to check

ornate mantle Sep 5, 2022, 6:48 AM

#

1.19.1 added allay duplication and chat reports

#

1.19.2 fixed a join bug

river oracle Sep 5, 2022, 6:48 AM

#

Idk you could try and see if it works

ornate mantle Sep 5, 2022, 6:48 AM

#

yeah except i cant 💀

river oracle Sep 5, 2022, 6:48 AM

#

I'd say maybe

ornate mantle Sep 5, 2022, 6:49 AM

#

you cant join 1.19.2 servers with a 1.19 client

#

yeah maybe

river oracle Sep 5, 2022, 6:50 AM

#

I mean nms mighttt work across version maybe depending on what you use though I thought those classes couldn't be referenced cross version no Matter what

#

My best advice would be to try and see

ornate mantle Sep 5, 2022, 6:55 AM

#

another help

#

Unresolved dependency: 'org.spigotmc:spigot:jar:1.19.2-R0.1-SNAPSHOT'

#

using nms

boreal seal Sep 5, 2022, 6:56 AM

#

damn not gonna read his explanation to the guy who learn java yesterday

#

ill better stick to ways i know

#

damn

ornate mantle Sep 5, 2022, 6:57 AM

#

lmao

boreal seal Sep 5, 2022, 6:57 AM

#

im not about it if u look up u will get it

ornate mantle Sep 5, 2022, 6:57 AM

#

what

boreal seal Sep 5, 2022, 6:57 AM

#

but 7smile7 tells me to take a look at his high performance cooldown util or what ever

#

now i dont believe u can check 1 million times and server wont feel

#

will do a layer 7 attack on the cpu lmao

#

now in general it will do maybe a really small perfomrance tweak that maybe doesnt even worth the attention

#

i know an guy which converts UUID into binary

#

you know how efficent it will be

#

if you store 1 million UUID in binary instead of the normal way

#

it will save you 10 mb's

#

so sometimes those performance tweaks are dogshit and thanks god i pay for dedicated server and not for shared hosting with half theard lol

young knoll Sep 5, 2022, 7:02 AM

#

What

eternal oxide Sep 5, 2022, 7:04 AM

#

lol

#

The "normal way" to store a UUID is as 2 longs. Shortest it can be.

ornate mantle Sep 5, 2022, 7:29 AM

#

would ServerPlayer#displayName = "balls" set the serverplayer's display name to balls?

young knoll Sep 5, 2022, 7:32 AM

#

Yes

ornate mantle Sep 5, 2022, 8:02 AM

#

how do i set location of a serverplayer in nms mojang mappings

boreal seal Sep 5, 2022, 8:05 AM

#

im wondering

#

where i put those x,y,z for god sake

#

that what my mind told me

#

not sure if its the right that

#

gonna just try it..

scarlet creek Sep 5, 2022, 8:10 AM

#

I’m trying to make a countdown system but I’m not sure how to go about it. I’m using a runnable and I’m trying to get the counter value that increases whenever the runnable is running

#

Code:

        new BukkitRunnable() {

            // active for 30 secs
            // To Do, have a getter for counter?
            private int counter = 0;
            private int maxCounter = 30;

            @Override
            public void run() {
                // if game end
                if (counter == maxCounter || playerQueueStatus.getQueueSize() < playerQueueStatus.getMinQueueSize()){
                    cancel();
                    Bukkit.broadcastMessage("" + ChatColor.GOLD + ChatColor.BOLD + "Game Ended!");
                }
               
                counter ++;
            }

        }.runTaskTimer(plugin, 0, 20);
    }```

#

Unfortunately it’s not as simple as creating a getter inside the method.

agile anvil Sep 5, 2022, 8:15 AM

#

move your counter outside the runnable

#

btw if you're creating a game mode, it's easier to have one task running and put everything in it

scarlet creek Sep 5, 2022, 8:21 AM

#

agile anvil btw if you're creating a game mode, it's easier to have one task running and put...

Yea that’s going to be the main runnable for timing stuff

scarlet creek Sep 5, 2022, 8:21 AM

#

agile anvil move your counter outside the runnable

You put it out into the class?

oblique geyser Sep 5, 2022, 8:23 AM

#

Hey, How can I get this part of a player inventory?

agile anvil Sep 5, 2022, 8:24 AM

#

scarlet creek You put it out into the class?

Yes, in your Game instance save those counters, and other variable you'll need in the runnable

manic furnace Sep 5, 2022, 8:24 AM

#

In my plugin, I serialize data with gson. I have to use a custom-type-adapter, but how do I write one for a map?

agile anvil Sep 5, 2022, 8:24 AM

#

oblique geyser Hey, How can I get this part of a player inventory?

Player#getInventory and these are slots 0, 1, 2.....

oblique geyser Sep 5, 2022, 8:27 AM

#

Yes I have this but then I get a player inventory, if I cast it to inventory, it return only the 4x9 items?

kindred valley Sep 5, 2022, 8:28 AM

#

What happends after e.setCancelled(true);

#

does it finishes the code after setting the event cancelled

agile anvil Sep 5, 2022, 8:29 AM

#

oblique geyser Yes I have this but then I get a player inventory, if I cast it to inventory, it...

Why do you want to cast it as Inventory ?

tall dragon Sep 5, 2022, 8:29 AM

#

kindred valley does it finishes the code after setting the event cancelled

any other code you have after that will run just fine

#

that event will just be set to cancelled and will not happen

agile anvil Sep 5, 2022, 8:29 AM

#

kindred valley does it finishes the code after setting the event cancelled

even other events listening can still listen to it

oblique geyser Sep 5, 2022, 8:32 AM

#

agile anvil Why do you want to cast it as Inventory ?

I need to storage and load it from a db, then I used the inventory because I can use Bukkit.createInventory(...)

#

Can I do this with player inventory?

agile anvil Sep 5, 2022, 8:35 AM

#

Well how do you save Inventory ?

#

because it works the same : just save for each slots the item it contains

oblique geyser Sep 5, 2022, 8:35 AM

#

my problem is not save

#

is load it

#

I suppose I should storage the contents

scarlet creek Sep 5, 2022, 8:37 AM

#

agile anvil Yes, in your Game instance save those counters, and other variable you'll need i...

I tried it but I realised that because I was running the scoreboard timer in another class, I had to create a new object so the counter it returns won’t update because it is different

scarlet creek Sep 5, 2022, 8:38 AM

#

scarlet creek I tried it but I realised that because I was running the scoreboard timer in ano...

Any ideas?

quaint mantle Sep 5, 2022, 8:41 AM

#

the editionNumber part

chrome beacon Sep 5, 2022, 8:42 AM

#

quaint mantle the editionNumber part

We told you what the issue was yesterday 🙃

quaint mantle Sep 5, 2022, 8:42 AM

#

chrome beacon We told you what the issue was yesterday 🙃

I was told to do the id and I did

#

?di

undone axleBOT Sep 5, 2022, 8:42 AM

#

Guide to dependency injection: https://www.spigotmc.org/wiki/using-dependency-injection/

chrome beacon Sep 5, 2022, 8:43 AM

#

You did not

#

Also there is a typo on line 21 in DctrSpaceHelm

quaint mantle Sep 5, 2022, 8:46 AM

#

wait lemme check

quaint mantle Sep 5, 2022, 8:46 AM

#

chrome beacon You did not

checked da github?

chrome beacon Sep 5, 2022, 8:46 AM

#

yes

quaint mantle Sep 5, 2022, 8:46 AM

#

alrighty guess im more drunk now

#

also is there some kind of rule saying that u shouldnt have more than 1 extends java plugin thing

#

wait isnt super. a nms thing

chrome beacon Sep 5, 2022, 8:50 AM

#

That's a Java thing

chrome beacon Sep 5, 2022, 8:51 AM

#

quaint mantle also is there some kind of rule saying that u shouldnt have more than 1 extends ...

You can't have more than one main plugin instance per plugin

quaint mantle Sep 5, 2022, 8:51 AM

#

ah

kindred valley Sep 5, 2022, 9:05 AM

#

public HashMap<String, Integer> theBackSlot(String s, int i) {
        new HashMap<String, Integer>().put(s,i);
        return HashMap<>();
    }```

#

I want to do something like this
everytime method have been called it will create a new hashmap and add the parameters in it and will return it
how can i do that

hazy parrot Sep 5, 2022, 9:05 AM

#

Why would you do that

kindred valley Sep 5, 2022, 9:06 AM

#

Complicated

hazy parrot Sep 5, 2022, 9:06 AM

#

To me it looks like you don't want to use hashmaps

hazy parrot Sep 5, 2022, 9:06 AM

#

kindred valley Complicated

¯_(ツ)_/¯

kindred valley Sep 5, 2022, 9:06 AM

#

but i am trying to control which slot, player have been came

hazy parrot Sep 5, 2022, 9:06 AM

#

So why creating new hash map

#

Every time

kindred valley Sep 5, 2022, 9:07 AM

#

hazy parrot So why creating new hash map

i have 5 slots

#

and they are different

hazy parrot Sep 5, 2022, 9:08 AM

#

Is the slot key or value?

lost knoll Sep 5, 2022, 9:35 AM

#

When creating a custom entity, I saw that you use the initPathfinding() to add new path finding goals. How would I do that with Mojang Mapping? Also, if there's a doc site where it shows what everything does, it'll help a lot

drowsy helm Sep 5, 2022, 9:46 AM

#

RegistGoals iirc

#

Let me double check

kindred valley Sep 5, 2022, 9:46 AM

#

hazy parrot Is the slot key or value?

Value

drowsy helm Sep 5, 2022, 9:47 AM

#

Yeah registerGaols

kindred valley Sep 5, 2022, 9:48 AM

#

İmagine an inventory has sword, food,block, tool categoires and i am clicking one of them and saving the name of them such as if its sword saving the "sword" string and the slot sword is on.

scarlet creek Sep 5, 2022, 10:17 AM

#

I'm trying to make a minigame timer, however when I added a static to the values that increase in the runnable, every time I activate the runnable, it sends the time left on the countdown one more time to the player.

#

    static int maxCounter = 30;```

#

doing cancel; stops and deletes a runnable right?

agile anvil Sep 5, 2022, 10:19 AM

#

It's easier to create a single runnable that loop for a the game long

#

instead of creating multiple

#

but yes cancel stop the task

scarlet creek Sep 5, 2022, 10:23 AM

#

Hmm if that’s the case, it can’t be that I have runnables that aren’t stopped

#

So I’m confused why it is outputting the countdown more than once

agile anvil Sep 5, 2022, 10:24 AM

#

?paste your code

undone axleBOT Sep 5, 2022, 10:24 AM

#

https://paste.md-5.net/

scarlet creek Sep 5, 2022, 10:25 AM

#

Here: https://paste.md-5.net/wahakaxepu.cs

jade knot Sep 5, 2022, 10:26 AM

#

Is PluginMessageListener working as async?

agile anvil Sep 5, 2022, 10:28 AM

#

scarlet creek Here: https://paste.md-5.net/wahakaxepu.cs

few remarks:

your class seems to be an object, so why putting the counters static ?
you should to early returns to better understand your code
can you please explain more clearly what's your problem ?

scarlet creek Sep 5, 2022, 10:30 AM

#

agile anvil few remarks: - your class seems to be an object, so why putting the counters sta...

If I don’t put my counters to static I can’t access them from the other class where I am managing my scoreboards which would display the time left as I have to make a new object for the scoreboard managing class

agile anvil Sep 5, 2022, 10:33 AM

#

use depency injection

#

?di

undone axleBOT Sep 5, 2022, 10:33 AM

#

Guide to dependency injection: https://www.spigotmc.org/wiki/using-dependency-injection/

agile anvil Sep 5, 2022, 10:33 AM

#

scarlet creek If I don’t put my counters to static I can’t access them from the other class wh...

and why separate it ? call it directly from the game task

scarlet creek Sep 5, 2022, 10:34 AM

#

agile anvil few remarks: - your class seems to be an object, so why putting the counters sta...

And the problem would be that the debugtimer method that sends the player a message would send it again to the player after the first time the runnable is activated. Increasing by 1 time it would send to the player again after every time the runnable is executed again

agile anvil Sep 5, 2022, 10:36 AM

#

that's what i said. creating multiple tasks makes it a lot harder to manage.
you should definitely have only one task that you don't stop

sage dragon Sep 5, 2022, 10:56 AM

#

java.lang.IllegalArgumentException: x out of range (expected 0-15, got 27)
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:193) ~[guava-31.0.1-jre.jar:?]
        at org.bukkit.craftbukkit.v1_19_R1.CraftChunk.validateChunkCoordinates(CraftChunk.java:362)
        at org.bukkit.craftbukkit.v1_19_R1.CraftChunkSnapshot.validateChunkCoordinates(CraftChunkSnapshot.java:171)
        at org.bukkit.craftbukkit.v1_19_R1.CraftChunkSnapshot.getBlockSkyLight(CraftChunkSnapshot.java:106)
        at me.entity303.tramaniaclasses.listener.BlazeListener.lambda$new$2(BlazeListener.java:64) ~[TramaniaClasses-1.0-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftTask.run(CraftTask.java:101)
        at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

ChunkSnapshot#getBlockSkyLight returns 27?

eternal night Sep 5, 2022, 10:57 AM

#

?

#

it does not return 27, you feed it an x of 27

sage dragon Sep 5, 2022, 10:57 AM

#

How exactly am I supposed to feed it with an x of 27 while reading data? 😅

eternal night Sep 5, 2022, 10:58 AM

#

?

#

getBlockSkyLight takes x y and z

#

you are feeding it an x of 27

sage dragon Sep 5, 2022, 10:58 AM

#

                if (chunkSnapshot.getBlockSkyLight(
                        all.getLocation().getBlockX(),
                        all.getLocation().getBlockY(),
                        all.getLocation().getBlockZ()) >= 15)

#

Oooh

#

Ops

#

Sorry, my mistake 😅

#

Thought it was returning a light level of 27 for some reason

sage dragon Sep 5, 2022, 11:16 AM

#

Now it always returns 15, no matter what...

Tried one block below, tried one block up, nothing

eternal oxide Sep 5, 2022, 11:23 AM

#

You are working with a snapshot. Its not going to detect changes

#

the light level will be whatever it was when you took the snapshot

sage dragon Sep 5, 2022, 11:27 AM

#

Yes, I'm taking the snapshot after the change though

eternal oxide Sep 5, 2022, 11:31 AM

#

15 I belive is direct sky light

sage dragon Sep 5, 2022, 11:32 AM

#

Yes, I blocked any light, so it should be 0

#

https://imgur.com/a/0XZj1zR

This is where it is supposed to check for the sky light

#

It's completely dark, as you can see

agile anvil Sep 5, 2022, 11:36 AM

#

You're inputting a location x y z into a chunk location

#

First get the chunk of the location

#

Take your x y z modulo 15

#

And get the result

tender shard Sep 5, 2022, 11:39 AM

#

why tf does this always happen

#

why can intellij not understand that its the sources root folder

#

without me marking this explictly as sources root

#

I mean its in src/main/resources lol

#

erm

sage dragon Sep 5, 2022, 11:39 AM

#

agile anvil Take your x y z modulo 15

X: 12
Y: 2
Z: 5

tender shard Sep 5, 2022, 11:39 AM

#

I meant src/main/java

agile anvil Sep 5, 2022, 11:43 AM

#

sage dragon X: 12 Y: 2 Z: 5

?paste your code

undone axleBOT Sep 5, 2022, 11:43 AM

#

https://paste.md-5.net/

eternal oxide Sep 5, 2022, 11:45 AM

#

sage dragon It's completely dark, as you can see

you can;t be checking the block you think you are

sage dragon Sep 5, 2022, 11:47 AM

#

agile anvil ?paste your code

https://pastebin.com/9gi4HqCA

sage dragon Sep 5, 2022, 11:49 AM

#

eternal oxide you can;t be checking the block you think you are

It is.

I placed a sand block and checked the Material

agile anvil Sep 5, 2022, 11:50 AM

#

Uhh

#

AtomicReference 🤧

sage dragon Sep 5, 2022, 11:50 AM

#

agile anvil AtomicReference 🤧

Any better alternative? 😅

sage dragon Sep 5, 2022, 11:52 AM

#

sage dragon https://pastebin.com/9gi4HqCA

(I pretty much tried to reconstruct the nms check for "IsInRain")

agile anvil Sep 5, 2022, 11:52 AM

#

Why do you need it ?

#

Just put your variable inside the task

#

Try to test the SkyLight outside all of your code

tardy delta Sep 5, 2022, 11:53 AM

#

why the fuck are people calling their player variable 'all'?

burnt sand Sep 5, 2022, 11:53 AM

#

Can i make a web proxy for my spigot plugin?

tardy delta Sep 5, 2022, 11:53 AM

#

unless that player's called All it doesnt refer to all the players

agile anvil Sep 5, 2022, 11:53 AM

#

Like to a BlockPlacdEvent and get a sky light

sage dragon Sep 5, 2022, 11:54 AM

#

tardy delta why the fuck are people calling their player variable 'all'?

To remind me that I'm looping through all online players 🤔

Okay, jokes aside, I normally call it just player, not sure what happened here 🤔

tardy delta Sep 5, 2022, 11:54 AM

#

🤔

tender shard Sep 5, 2022, 11:55 AM

#

tardy delta why the fuck are people calling their player variable 'all'?

it's fine if you loop over all players I guess

#

for(Player all : Bukkit.getPlayers())

this is fine to me

sage dragon Sep 5, 2022, 11:55 AM

#

agile anvil Just put your variable inside the task

So... A normal variable instead of an AtomicReference?

If I do this, I won't be able to compile...

tardy delta Sep 5, 2022, 11:56 AM

#

tender shard it's fine if you loop over all players I guess

take a better naming convention then and call it yoMama

sage dragon Sep 5, 2022, 11:57 AM

#

tardy delta take a better naming convention then and call it yoMama

I think allPlayersInAForLoopLoopingThroughBukkitGetOnlinePlayers is a way better name

#

And makes totally sense

tardy delta Sep 5, 2022, 11:57 AM

#

sage dragon So... A normal variable instead of an AtomicReference? If I do this, I won't be...

create a wrapper class lmao without all that atomic shit

sage dragon Sep 5, 2022, 11:58 AM

#

tardy delta create a wrapper class lmao without all that atomic shit

But.... That would be work 😦

I mean... I could do that, but would it make any difference? 😅

tardy delta Sep 5, 2022, 11:58 AM

#

expression parser progress meh

tender shard Sep 5, 2022, 11:59 AM

#

sage dragon I think `allPlayersInAForLoopLoopingThroughBukkitGetOnlinePlayers` is a way bett...

yes

agile anvil Sep 5, 2022, 11:59 AM

#

sage dragon But.... That would be work 😦 I mean... I could do that, but would it make any ...

Before trying to improve the code, try first to do a dumb debug test of the ChunkSnapshot

#

Create a BlockPlaceEvent and try to get its sky light level

tender shard Sep 5, 2022, 11:59 AM

#

i dont get why people call atomic "shit"

agile anvil Sep 5, 2022, 11:59 AM

#

Without creating loops, and tasks or whatever

tender shard Sep 5, 2022, 11:59 AM

#

I mean, what's the problem in using it?

agile anvil Sep 5, 2022, 12:00 PM

#

tender shard i dont get why people call atomic "shit"

They're not. But in this case it's really useless

eternal oxide Sep 5, 2022, 12:00 PM

#

or search the snapshot for ANY block thats not level 15

tardy delta Sep 5, 2022, 12:00 PM

#

its shitty that you have to use that instead of assigning a variable within a lambda expression

sage dragon Sep 5, 2022, 12:02 PM

#

eternal oxide or search the snapshot for ANY block thats not level 15

It does find a few

eternal oxide Sep 5, 2022, 12:03 PM

#

then its down to how you are checking. wrong chunk, wrong coords or something

sage dragon Sep 5, 2022, 12:04 PM

#

All of these blocks are at chunkX 4, way up in the sky and chunkZ 12 🤔

eternal oxide Sep 5, 2022, 12:05 PM

#

are you certain there is a block above where you are testing?

sage dragon Sep 5, 2022, 12:06 PM

#

sage dragon All of these blocks are at chunkX 4, way up in the sky and chunkZ 12 🤔

And none of the tested blocks exist, all of them are just air

eternal oxide Sep 5, 2022, 12:07 PM

#

then you have no blocks there. 16 is correct

#

exposed to the sky

sage dragon Sep 5, 2022, 12:07 PM

#

eternal oxide then you have no blocks there. 16 is correct

I'm literally encased in dirt blocks, no light whatsoever

eternal oxide Sep 5, 2022, 12:08 PM

#

you just said no blocks were there, they were all air

sage dragon Sep 5, 2022, 12:08 PM

#

Let's try checking the light when placing a block

eternal oxide Sep 5, 2022, 12:08 PM

#

you can;t get a snapshot the second you place a block

#

it will not have the block

sage dragon Sep 5, 2022, 12:09 PM

#

eternal oxide you just said no blocks were there, they were all air

I made a loop going through all blocks in the ChunkSnapshot and printed all blocks which have a Sky Light level lower than 15, it only finds a few air blocks

sage dragon Sep 5, 2022, 12:09 PM

#

eternal oxide you can;t get a snapshot the second you place a block

Yes

tender shard Sep 5, 2022, 12:10 PM

#

ah yes, "half life" icons lol

sage dragon Sep 5, 2022, 12:10 PM

#

eternal oxide you can;t get a snapshot the second you place a block

    @EventHandler
    public void onPlace(BlockPlaceEvent e) {
        e.getPlayer().sendMessage(String.valueOf(e.getBlock().getLightFromSky()));
    }

This prints the correct value

#

But ChunkSnapshot doesn't

tender shard Sep 5, 2022, 12:11 PM

#

yes, the block hasnt been placed yet

#

it only gets placed after the event was called

eternal oxide Sep 5, 2022, 12:12 PM

#

actually I believe the block place is an odd event, it is placed and if you cancel the event it undoes the placement.

#

If I'm remembering correctly

tender shard Sep 5, 2022, 12:13 PM

#

I just tried to find that part of code but I cant find it lol

agile anvil Sep 5, 2022, 12:15 PM

#

It's dark magic. It exists but doesn't really exist

tender shard Sep 5, 2022, 12:15 PM

#

#

very weird code

#

its indeed some weird "inbetween state" during the actual event

terse ore Sep 5, 2022, 12:16 PM

#

Hey

#

I am trying to fill a chest with items but only at the center

#

but I can't manage to make it not to fill the right side

#

#

    public static ArrayList<Integer> getIndexes(int amount) {
        ArrayList<Integer> indexes = new ArrayList<Integer>();
        int index = 0;

        while (indexes.size() <= amount) {
            if (!(index % 9 == 0 || index >= 0 && index <= 8 || index >= 45 && index <= 53)) {
                indexes.add(index);
            }

            index += 1;
        }

        return indexes;
    }```

#

amount is the amount of items the chest is going to have

tender shard Sep 5, 2022, 12:17 PM

#

check if (index + 1) % 9 == 0

sage dragon Sep 5, 2022, 12:17 PM

#

tender shard yes, the block hasnt been placed yet

Okay, tested it 3 seconds after the event, but it still says 15.

So ChunkSnapshot is definitely broken if it comes to SkyLight 🤔

tender shard Sep 5, 2022, 12:17 PM

#

tender shard check if (index + 1) % 9 == 0

if yes, it's the right side, I think

agile anvil Sep 5, 2022, 12:18 PM

#

Index % 8 == 0

tender shard Sep 5, 2022, 12:18 PM

#

I dont think that would work

agile anvil Sep 5, 2022, 12:18 PM

#

Since sides are multiples of 8 and 0

tender shard Sep 5, 2022, 12:18 PM

#

it would return true for the 16th slot which is not on the right side

agile anvil Sep 5, 2022, 12:18 PM

#

Oh yeah also 9

terse ore Sep 5, 2022, 12:18 PM

#

agile anvil Index % 8 == 0

17?

#

sage dragon Sep 5, 2022, 12:18 PM

#

Let's just skip the light test then 🤷

Works just fine without it...

agile anvil Sep 5, 2022, 12:18 PM

#

index % 8 for right side and index % 9 for left side

terse ore Sep 5, 2022, 12:19 PM

#

17 % 8 == 0 != true

#

it would work if the chest were of 8 width

agile anvil Sep 5, 2022, 12:19 PM

#

Indeed

tender shard Sep 5, 2022, 12:19 PM

#

tbh I'd just hardcode the borders as quick fix lol

agile anvil Sep 5, 2022, 12:19 PM

#

My brain doesn't want to work today

tender shard Sep 5, 2022, 12:19 PM

#

int[] illegalSlots = { 0, 8, 9, 17, ... };

#

easiest solution 😄

agile anvil Sep 5, 2022, 12:21 PM

#

index % 9 == 0 || index % 9 == 8

#

Finally

tender shard Sep 5, 2022, 12:22 PM

#

i usually have a MenuPosition class that uses int row and int column

#

so I can just check if column is 0 or 8

#

?paste

undone axleBOT Sep 5, 2022, 12:22 PM

#

https://paste.md-5.net/

agile anvil Sep 5, 2022, 12:22 PM

#

That's quite the same actually

tender shard Sep 5, 2022, 12:22 PM

#

https://paste.md-5.net/edotogucun.java

tender shard Sep 5, 2022, 12:23 PM

#

agile anvil That's quite the same actually

yeah but it's easier to work with an actual object instead of "raw slot numbers" imho

terse ore Sep 5, 2022, 12:23 PM

#

now I have this error

#

[14:22:44 ERROR]: Could not pass event InventoryClickEvent to EcoEnchantsInterface v1.0
java.lang.ArrayIndexOutOfBoundsException: null```

agile anvil Sep 5, 2022, 12:23 PM

#

Show the code again pls

terse ore Sep 5, 2022, 12:24 PM

#

...
if (!(index % 9 == 0 || index >= 0 && index <= 8 || index >= 45 && index <= 53 || (index + 1) % 9 == 0)) ...

tender shard Sep 5, 2022, 12:24 PM

#

yeah code like this is horrible, why not just wrap the slot into some kinda object

#

then just check if the column is 0 or 8

agile anvil Sep 5, 2022, 12:25 PM

#

Or add a index > 53 in your ! Check 😂

tender shard Sep 5, 2022, 12:26 PM

#

I hate slot numbers

dusk flicker Sep 5, 2022, 12:27 PM

#

arent there also numbers for the crafting grid?

tender shard Sep 5, 2022, 12:27 PM

#

i dont know, I made this for angelchest which doesn't care about the crafting stuff

dusk flicker Sep 5, 2022, 12:28 PM

#

oh cool

tender shard Sep 5, 2022, 12:28 PM

#

but yeah IIRC the crafting grid is 41-44 and the result is 45

hazy parrot Sep 5, 2022, 12:28 PM

#

Why not like

for(int i=10; i<37; i+=9){
 for(int j = i; j<6; j++)    {
  setItem(i+j, item);
} 
}

Might be wrong cuz I'm on phone but something similar

#

If that is considered "center"

tender shard Sep 5, 2022, 12:30 PM

#

I'd still just do it like this 😛

        for(int i = 0; i < inv.getSize(); i++) {
            GUIUtils.MenuPosition pos = GUIUtils.slotToPosition(i);
            if(pos.getRow() == 1 || pos.getRow() == 6) continue;
            if(pos.getColumn() == 1 || pos.getColumn() == 9) continue;
            // Do stuff
        }

warm mica Sep 5, 2022, 12:31 PM

#

I hate to work with slots. Simply do the following.

int slot = ;
int x = slot%9;
int y = (int) (slot/9);

int slot = x + y*9;

This is making it so much easier

visual tide Sep 5, 2022, 12:32 PM

#

bukkit's inventory api sucks in general

shell finch Sep 5, 2022, 12:32 PM

#

is there a way to set an entity or a player to a riptide state?

tender shard Sep 5, 2022, 12:32 PM

#

warm mica I hate to work with slots. Simply do the following. int slot = ; int x = slot%9...

yeah that's basically what my MenuPosition class does

visual tide Sep 5, 2022, 12:32 PM

#

is it gonna be null? is it gonna be Material.AIR?
who fucking knows?

tender shard Sep 5, 2022, 12:32 PM

#

yeah that's so random

#

it's also funny how the amount of AIR is always 0

#

like

visual tide Sep 5, 2022, 12:32 PM

#

yah

tender shard Sep 5, 2022, 12:32 PM

#

if I have 0 air, then it's not actually air, I guess?

#

I could understand it if it at least would be 1 air

#

but 0 air?

warm mica Sep 5, 2022, 12:34 PM

#

Ig nothing would be a better name

terse ore Sep 5, 2022, 12:34 PM

#

how do I check if an int is inside

    private static int[] illegalSlots = {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 18, 27, 36, 45, 17, 26, 35, 45, 53, 46, 47, 48, 49, 50, 51, 52};
    ```

warm mica Sep 5, 2022, 12:34 PM

#

terse ore how do I check if an int is inside ```java private static int[] illegalSlots...

Use a Set, it's slow to check an array

#

Otherwise Arrays.binarySearch(array, entry) >= 0

warm mica Sep 5, 2022, 12:36 PM

#

warm mica Use a Set, it's slow to check an array

E.g. Set<Integer> illegalSlots = new HashSet<>(Arrays.asList(0, 1, 2, 3, ...));

drowsy helm Sep 5, 2022, 12:36 PM

#

probs want an immutable set

tender shard Sep 5, 2022, 12:38 PM

#

isnt Arrays.asList immutable?

#

so why put it into a set

drowsy helm Sep 5, 2022, 12:39 PM

#

new HashSet<>(list) will make it mutable again right?

tender shard Sep 5, 2022, 12:39 PM

#

yes

#

but why put it into a set in the first place

#

i mean it will only ever have like 8 entries or so

drowsy helm Sep 5, 2022, 12:39 PM

#

trying to over optimise

tender shard Sep 5, 2022, 12:39 PM

#

yeah it's a waste of time to even think about "is a list or a set better" lol

sterile token Sep 5, 2022, 12:40 PM

#

What better a list or set?

tender shard Sep 5, 2022, 12:40 PM

#

sterile token What better a list or set?

in this case: both are equally good

sterile token Sep 5, 2022, 12:40 PM

#

I always make that question

tender shard Sep 5, 2022, 12:41 PM

#

if someone really wants to overoptimize this, then just use a switch case

visual tide Sep 5, 2022, 12:41 PM

#

:concerned:

drowsy helm Sep 5, 2022, 12:42 PM

#

lmao

tender shard Sep 5, 2022, 12:42 PM

#

i guess this would indeed be the fastest way

sterile token Sep 5, 2022, 12:42 PM

#

What the best way for disabling a logger from another library?

#

For example I want to disable JDA logger

#

Because its really painfull to see that ugly Messages

tender shard Sep 5, 2022, 12:43 PM

#

logback.xml

sterile token Sep 5, 2022, 12:43 PM

#

?

#

Explain detailed please

tender shard Sep 5, 2022, 12:43 PM

#

#

with this, JDA only logs "info" stuff (and higher, like WARN and SEVERE) while my own stuff also logs "debug" stuff

sterile token Sep 5, 2022, 12:44 PM

#

I cannot do that

#

Because im using it as maven dependency

#

😬

#

Also why the heck Logger.getLogger("paxkage.logger.Class").setLevel(Level.OFF); doesnt work with JDA when with mongo works perfect

#

Sometime java coding its really weird

dusk flicker Sep 5, 2022, 12:47 PM

#

I feel like turning off logging is just a bad idea in general

tender shard Sep 5, 2022, 12:47 PM

#

yeah

#

although JDA indeed prints many useless stuff

shell finch Sep 5, 2022, 12:47 PM

#

How could I get a player to be able to use a bow even without arrows in their inventory? is that possible or is that fully client side?

dusk flicker Sep 5, 2022, 12:48 PM

#

I would think that would probably be clientsided; might be a way to do it with packets

sterile token Sep 5, 2022, 12:48 PM

#

shell finch How could I get a player to be able to use a bow even without arrows in their in...

You can launch an entity arrow

dusk flicker Sep 5, 2022, 12:48 PM

#

personally when they rightclick with the bow I would just give them an arrow and cancel the event when done

tender shard Sep 5, 2022, 12:49 PM

#

sterile token Also why the heck Logger.getLogger("paxkage.logger.Class").setLevel(Level.OFF); ...

JDA uses Log4J, you can do Logger logger = LogManager.getLogger(JDA.class)

sterile token Sep 5, 2022, 12:49 PM

#

Oh thanks mfalex