#help-development | SpigotMC | Page 25

crisp steeple Jul 30, 2022, 11:29 PM

#

because that causes a lot of issues

#

what if i renamed a chest to be the same title

carmine nacelle Jul 30, 2022, 11:29 PM

#

color codes?

crisp steeple Jul 30, 2022, 11:29 PM

#

well then you're just making a hacky workaround to something you can already do properly

carmine nacelle Jul 30, 2022, 11:29 PM

#

whats the "proper" way then

#

got an example of that?

kind hatch Jul 30, 2022, 11:30 PM

#

InventoryHolder is not the best. Comparing instances is the proper way to do it.

crisp steeple Jul 30, 2022, 11:30 PM

#

carmine nacelle whats the "proper" way then

the proper way is probably comparing instances of the inventory, people also do inventoryholders but its technically a misuse of the api although it wont cause any issues

carmine nacelle Jul 30, 2022, 11:31 PM

#

So you would like..make a list of custom inventories or somethin?

#

eh nvm.

ivory sleet Jul 30, 2022, 11:33 PM

#

kind hatch InventoryHolder is not the best. Comparing instances is the proper way to do it.

Yeah well until you deal with delegates and views

tranquil viper Jul 30, 2022, 11:41 PM

#

java.lang.IllegalStateException: Asynchronous command dispatch!
        at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:16) ~[pufferfish-1.18.2.jar:git-Pufferfish-72]
        at org.bukkit.craftbukkit.v1_18_R2.CraftServer.dispatchCommand(CraftServer.java:882) ~[pufferfish-1.18.2.jar:git-Pufferfish-72]
        at xyz.praydev.event.SpawnBossEvent$1.run(SpawnBossEvent.java:74) ~[CustomEggs-1.0-shaded.jar:?]
        at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftTask.run(CraftTask.java:101) ~[pufferfish-1.18.2.jar:git-Pufferfish-72]
        at org.bukkit.craftbukkit.v1_18_R2.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[pufferfish-1.18.2.jar:git-Pufferfish-72]
        at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[pufferfish-1.18.2.jar:git-Pufferfish-72]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

Bukkit.getServer().dispatchCommand(Bukkit.getServer().getConsoleSender(), "mm m spawn SkeletonKing 1 " + player.getWorld() + "," + clicked.getX() + "," + clicked.getY() + "," + clicked.getZ());

#

Anyone know what is causing this?

kind hatch Jul 30, 2022, 11:41 PM

#

?scheduling

undone axleBOT Jul 30, 2022, 11:41 PM

#

https://www.spigotmc.org/wiki/scheduler-programming/

frail spire Jul 30, 2022, 11:44 PM

#

502

tender robin Jul 30, 2022, 11:45 PM

#

my brain doesn't work for this do u have any other solution lmao

eternal oxide Jul 30, 2022, 11:46 PM

#

pdc is the correct approach

tender robin Jul 30, 2022, 11:46 PM

#

?pdc

undone axleBOT Jul 30, 2022, 11:46 PM

#

https://www.spigotmc.org/threads/a-guide-to-1-14-persistentdataholder-api.371200/

tender robin Jul 30, 2022, 11:47 PM

#

he talked to me

eternal oxide Jul 30, 2022, 11:47 PM

#

pdc wasn;t for you

crisp steeple Jul 30, 2022, 11:48 PM

#

huh

tender robin Jul 30, 2022, 11:51 PM

#

eternal oxide pdc wasn;t for you

how long would it take to do this?

eternal oxide Jul 30, 2022, 11:51 PM

#

minutes

tender robin Jul 30, 2022, 11:51 PM

#

do u know how to do it? ^^

eternal oxide Jul 30, 2022, 11:51 PM

#

yes

tender robin Jul 30, 2022, 11:52 PM

#

eternal oxide yes

u have time to do it?
and do you want to do it?

eternal oxide Jul 30, 2022, 11:53 PM

#

taken directly from that wiki page...modifiedjava ItemStack itemStack = ...; NamespacedKey key = new NamespacedKey(pluginInstance, "args"); ItemMeta itemMeta = itemStack.getItemMeta(); itemMeta.getPersistentDataContainer().set(key, PersistentDataType.STRING, args[1]); itemStack.setItemMeta(itemMeta);

#

that would put the data in the pdc

tender robin Jul 30, 2022, 11:54 PM

#

"args" is correct there?

eternal oxide Jul 30, 2022, 11:54 PM

#

Then in your interact or click event you read it from the PDC

#

thats what you want to store isn;t it?

#

args[1]

tender robin Jul 30, 2022, 11:55 PM

#

yes

eternal oxide Jul 30, 2022, 11:56 PM

#

reading is ```java
ItemStack itemStack = ...;
NamespacedKey key = new NamespacedKey(pluginInstance, "args");
ItemMeta itemMeta = itemStack.getItemMeta();
PersistentDataContainer container = itemMeta.getPersistentDataContainer();

if(container.has(key , PersistentDataType.STRING)) {
String foundValue = container.get(key, PersistentDataType.STRING);
}```

tender robin Jul 30, 2022, 11:57 PM

#

pluginInstance?

eternal oxide Jul 30, 2022, 11:57 PM

#

your plugin

tender robin Jul 30, 2022, 11:57 PM

#

yes

#

so the main class or

#

the cmd class

eternal oxide Jul 30, 2022, 11:58 PM

#

if your doing this in the class which extends JavaPlugin, you would use this

#

else

#

?di

undone axleBOT Jul 30, 2022, 11:58 PM

#

Guide to dependency injection: https://www.spigotmc.org/wiki/using-dependency-injection/

tender robin Jul 30, 2022, 11:59 PM

#

eternal oxide reading is ```java ItemStack itemStack = ...; NamespacedKey key = new Namespaced...

where do I say what to do if he clicks on it?

tender robin Jul 30, 2022, 11:59 PM

#

tender robin where do I say what to do if he clicks on it?

I know that i have to use action.... and stuff..

echo basalt Jul 31, 2022, 12:00 AM

#

nms unfortunately

#

FoodInfo

#

Or FoodData in mojmappings

eternal oxide Jul 31, 2022, 12:02 AM

#

https://github.com/Valks-Minecraft-Plugins/FoodValue/blob/master/src/main/java/com/foodvalue/listeners/ListenerConsume.java

#

yes, that is old code, use teh getSaturation/setSaturation on teh player

#

food level and saturation are different

#

saturation is how long you stay sated

#

food with zero saturation would fill you up, but instantly start to decrease

#

the higher the saturation level, the longer before your food level drops

#

you have to cancel teh consume event and reduce the item count yourself

#

you are doing the math now

#

of course you can

#

get the ItemStack

#

its teh actual ItemStack you are eating

chilly patio Jul 31, 2022, 12:20 AM

#

Uhm, so rn, I was going to check for every single thing I get from the config and report and error in case it doesn't find it, the thing is, is there no other way of doing this? Seems like DRY to be doing this like 15 different times...

eternal oxide Jul 31, 2022, 12:20 AM

#

not a clone so you can reduce the amount

#

getItem().setAmount(getItem().getAmount() -1)

#

the event has nothing to do with teh ItemStack

#

its just returning teh ItemStack

#

YOU reduce it

pine lake Jul 31, 2022, 12:22 AM

#

Hello, how can I change the build output of my plugin?

eternal oxide Jul 31, 2022, 12:23 AM

#

you don;t leave it for the event to do, you are canceling that

ancient plank Jul 31, 2022, 12:23 AM

#

teh

eternal oxide Jul 31, 2022, 12:23 AM

#

it doesn;t matter, you are just reducing it in the Listener

chilly patio Jul 31, 2022, 12:24 AM

#

rip

ancient plank Jul 31, 2022, 12:24 AM

#

birdfacepalm

eternal oxide Jul 31, 2022, 12:24 AM

#

canceling the event does not stop your code running. YOUR code still takes effect

ancient plank Jul 31, 2022, 12:25 AM

#

Reading this is giving me a headache even tho I've been taking ibuprofen

#

He literally told you the answer

eternal oxide Jul 31, 2022, 12:25 AM

#

Just cancel the event and reduce teh stack size as I've told you

#

cancelling an event just tells spigot not to make any changed due to the event. Your listener is not the event. it's just code.

#

yes, cancel event, reduce stack size, increase food level and saturation

#

yes

gray merlin Jul 31, 2022, 12:28 AM

#

Does anyone have any examples of FileConfiguration implementations?

eternal oxide Jul 31, 2022, 12:28 AM

#

a hearty meat pie shoudl give way more saturation than an apple

quaint mantle Jul 31, 2022, 12:28 AM

#

gray merlin Does anyone have any examples of `FileConfiguration` implementations?

What for

#

Are you making like a toml version

gray merlin Jul 31, 2022, 12:29 AM

#

Hmm, sure, toml is the simplest and easiest to understand afterall.

quaint mantle Jul 31, 2022, 12:29 AM

#

true

#

Just implement it

#

your ide will tell you what to override

#

its pretty self explanatory

gray merlin Jul 31, 2022, 12:31 AM

#

quaint mantle your ide will tell you what to override

Sure, but I don't know what each method does, and it would be easier for me If I had some sort of example for this.

#

hmm

#

?configs

undone axleBOT Jul 31, 2022, 12:40 AM

#

See this wiki page on how to use custom configuration files: https://www.spigotmc.org/wiki/config-files/

gray merlin Jul 31, 2022, 12:40 AM

#

I see.

shut field Jul 31, 2022, 12:42 AM

#

how do I get this location?

#

second image

#

I want the location of the shulker being held by the armorstand

#

or more accurately, I want the pufferfish to spawn directly on the shulker shell item held by the armorstand

abstract sleet Jul 31, 2022, 12:43 AM

#

I think you need to guesstimate it

#

Relative to a known location of the armour stand

shut field Jul 31, 2022, 12:43 AM

#

abstract sleet Relative to a known location of the armour stand

it is going to spawn at random pitches, yaws, and xyz cords

shut field Jul 31, 2022, 12:45 AM

#

shut field how do I get this location?

the shulker item will always be pointed away from the item, however, as shown in the image the shell is about 0.5 behind the armorstand and roughly 2 y cords above the armorstand base cord. But the xyz cords are changing

eternal oxide Jul 31, 2022, 12:48 AM

#

just get the item in teh players hand then

gray merlin Jul 31, 2022, 12:50 AM

#

Is there a way to create an empty dummy player?

#

Doesn't even need to exist in the world, I just have the object.

#

Thanks.

eternal oxide Jul 31, 2022, 12:50 AM

#

gray merlin Is there a way to create an empty dummy player?

yes but not a beginner thing. It uses NMS and is version specific

gray merlin Jul 31, 2022, 12:51 AM

#

eternal oxide yes but not a beginner thing. It uses NMS and is version specific

I see, thanks.

eternal oxide Jul 31, 2022, 12:51 AM

#

shut field how do I get this location?

Read this thread https://www.spigotmc.org/threads/player-right-hand-location.168219/

#

so long as you don't adjust the bodyPose you should be able to calculate the hand position

carmine nacelle Jul 31, 2022, 1:14 AM

#

question..

#

so I have an itemstack.
I then pass the itemstack into a function which sets PDC keys on it

#

then back in the main function, I set the itemmeta and add the item to my inventory

#

does it save the changes I made to the PDC?

#

        pdcManager.setCustomHive(customHiveItem);
        customHiveItem.setItemMeta(customHiveMeta);

        return customHiveItem;

    public void setCustomHive(ItemStack itemStack) {
        NamespacedKey customHiveKey = new NamespacedKey(cadiaBees, "custom-hive");

        if(!(itemStack.hasItemMeta()) || itemStack.getItemMeta().getDisplayName() == null) return;

        ItemMeta itemMeta = itemStack.getItemMeta();
        PersistentDataContainer container = itemMeta.getPersistentDataContainer();

        container.set(customHiveKey, PersistentDataType.INTEGER, 1);
        itemStack.setItemMeta(itemMeta);
    }

#

It's not actually setting my value

eternal oxide Jul 31, 2022, 1:17 AM

#

setCustomHive method is fine, however, test hasCustomName()

#

oh no methodf. I thought there was

carmine nacelle Jul 31, 2022, 1:18 AM

#

I dont see hasCustomName

eternal oxide Jul 31, 2022, 1:18 AM

#

ignore me then. I'm thinking of something else

carmine nacelle Jul 31, 2022, 1:18 AM

#

I also tried changing my setCustomHive to return an itemstack

#

        customHiveItem.setItemMeta(customHiveMeta);
        customHiveItem = pdcManager.setCustomHive(customHiveItem);

        return customHiveItem;

#

I dont see why this isnt working

eternal oxide Jul 31, 2022, 1:19 AM

#

make sure its actually reaching the PDC code

#

sysout

carmine nacelle Jul 31, 2022, 1:19 AM

#

Yeah it reaches it

eternal oxide Jul 31, 2022, 1:20 AM

#

theres nothing wrong with the pdc code

carmine nacelle Jul 31, 2022, 1:22 AM

#

Hmmm..

#

got it

echo basalt Jul 31, 2022, 1:31 AM

#

Ayo I'm struggling a bit with armorstand math

#

Let's assume that I want to rotate an upright item set on an armorstand's head

#

I can set the Z angle to 315º (-45º) for the item to be upright

#

but rotating the head on the Y axis breaks because of roll

#

Is there any simple way of rotating X Y and Z angles to negate the roll effect?

#

Basically getting the item to rotate around the Y axis as if Z was 0

carmine nacelle Jul 31, 2022, 1:38 AM

#

https://haselkern.com/Minecraft-ArmorStand/ idk if this will help

Minecraft Armor stand

Create poses for Minecraft armor stands in a breeze! Free, fast, open source.

drowsy helm Jul 31, 2022, 1:58 AM

#

echo basalt Basically getting the item to rotate around the Y axis as if Z was 0

are you trying to make it rotate in a loop de loop?

echo basalt Jul 31, 2022, 1:58 AM

#

no

tranquil viper Jul 31, 2022, 2:26 AM

#

#

Aren't these 1.8 attributes?

limber owl Jul 31, 2022, 2:45 AM

#

new 1.19.1 player chat event?

carmine nacelle Jul 31, 2022, 3:00 AM

#

    private UUID hiveUUID;
    private String hiveName;
    private UUID ownerUUID;
    private Location hiveLocation;
    private List<UUID> holoUUIDs;
    private List<RewardItem> rewardItems;
    private List<String> beeNames;
    private List<UUID> beeUUIDs;
    private int beeAmt;
    private int honeyAmt;
    private HiveLevel hiveLevel;
    private HiveStatus hiveStatus;
    private Boolean beesBeingRenamed = false;

Gson should be able to work with all these right?

#

its creating a blank json file when i save

#

or do I need a custom factory for the location?

worldly ingot Jul 31, 2022, 3:10 AM

#

It won't be able to serialize a Location, but aside from that, assuming all your other classes (RewardItem, HiveLevel, and HiveStatus) contain fields that are also serializable, should be fine

#

If RewardItem contains an ItemStack, it won't serialize either

near night Jul 31, 2022, 3:11 AM

#

any api for custom entities not using nms for 1.19?

#

coz i hate nms

carmine nacelle Jul 31, 2022, 3:11 AM

#

worldly ingot If RewardItem contains an ItemStack, it won't serialize either

It does...

#

so I need a custom factory?

#

do you have a link to a good tutorial? I haven't done it in a while

worldly ingot Jul 31, 2022, 3:12 AM

#

Most likely, yes

#

Don't think anybody's written an ItemStack serializer for Gson

carmine nacelle Jul 31, 2022, 3:12 AM

#

Well, in general

tranquil viper Jul 31, 2022, 3:13 AM

#

tranquil viper Aren't these 1.8 attributes?

bump

worldly ingot Jul 31, 2022, 3:13 AM

#

Not overly complicated to implement. You need a class that implements JsonSerializer and JsonDeserializer, then you can register an instance of it in a Gson builder with registerTypeAdapter()

Gson gson = new GsonBuilder()
    .registerTypeAdapter(ItemStack.class, new MyCustomItemStackSerializer())
    .build();```

upper vale Jul 31, 2022, 3:13 AM

#

i think ive seen a plugin where they just convert items to like base64 or smth

worldly ingot Jul 31, 2022, 3:14 AM

#

Something like that

near night Jul 31, 2022, 3:14 AM

#

near night any api for custom entities not using nms for 1.19?

like a plugin that a can use the api of?

carmine nacelle Jul 31, 2022, 3:18 AM

#

@worldly ingot Would I use extends TypeAdapter<CustomHive> instead?

#

could I*

worldly ingot Jul 31, 2022, 3:19 AM

#

You could, but that uses a JsonReader and JsonWriter, which means you have to work with very, very primitive Gson which can be faster but is excruciatingly annoying

carmine nacelle Jul 31, 2022, 3:20 AM

#

Oof

#

alright

worldly ingot Jul 31, 2022, 3:20 AM

#

The former two interfaces make it a bit nicer to write serializers/deserializers

carmine nacelle Jul 31, 2022, 3:22 AM

#

this is pretty uhhhhh

#

difficult

tranquil viper Jul 31, 2022, 3:23 AM

#

What are you trying to do?

#

Can't be asked to read it all

carmine nacelle Jul 31, 2022, 3:23 AM

#

Custom gson serializers/deserializers

tranquil viper Jul 31, 2022, 3:23 AM

#

Ah ok

#

Bit out of my expertise, lol

carmine nacelle Jul 31, 2022, 3:24 AM

#

oh wait

#

from SO

public class StudentAdapter implements JsonSerializer<Student> {

 @Override
 public JsonElement serialize(Student src, Type typeOfSrc,
            JsonSerializationContext context) {

        JsonObject obj = new JsonObject();
        obj.addProperty("name", src.name);
        obj.addProperty("school", src.school.id);

        return obj;
    }
}

#

its that easy?

compact haven Jul 31, 2022, 3:25 AM

#

yes

#

then there’s a method you need to call on the GsonBuilder instance

#

but that’s it

carmine nacelle Jul 31, 2022, 3:26 AM

#

How would I do it with a list?

#

like, itemstack lore

tranquil viper Jul 31, 2022, 3:27 AM

#

How could I get the GENERIC_ATTACK_DAMAGE value of an itemstack?

#

Or check if the GENERIC_ATTACK_DAMAGE value was modified in some way, shape, or form

ivory sleet Jul 31, 2022, 3:32 AM

#

ItemMeta

tranquil viper Jul 31, 2022, 3:32 AM

#

So if the GENERIC_ATTACK_DAMAGE value is in the itemmeta it's been modified correct?

ivory sleet Jul 31, 2022, 3:33 AM

#

I mean it has a default value

#

But yeah

#

Just use the api

tranquil viper Jul 31, 2022, 3:33 AM

#

I heard that it won't be in the ItemMeta if it's the default value

ivory sleet Jul 31, 2022, 3:33 AM

#

might be the case

tranquil viper Jul 31, 2022, 3:33 AM

#

Alr thanks

carmine nacelle Jul 31, 2022, 3:34 AM

#

guys, with a custom jsonserializer I am unable to simply obj.addProperty("itemLore", src.getItemMeta().getLore());

#

guessing its because lore is a string

#

#

Or would I do obj.add("itemLore", (JsonElement) src.getItemMeta().getLore());

echo basalt Jul 31, 2022, 3:39 AM

#

well

#

you can't cast a list to a jsonelement

fleet forge Jul 31, 2022, 3:41 AM

#

Is there a way to listen for when the warden sniffs

near night Jul 31, 2022, 3:41 AM

#

near night any api for custom entities not using nms for 1.19?

bump

echo basalt Jul 31, 2022, 3:43 AM

#

fleet forge Is there a way to listen for when the warden sniffs

seems to be bound to entity metadata

#

I don't see anything

echo basalt Jul 31, 2022, 3:43 AM

#

near night bump

There's only so much you can do with spigot

#

custom entities weren't something that should be in spigot by design

near night Jul 31, 2022, 3:44 AM

#

yeah but is there a plugin for nms custom enites for 1.19

echo basalt Jul 31, 2022, 3:44 AM

#

closest thing you have is mythic mobs

near night Jul 31, 2022, 3:44 AM

#

danm

glossy scroll Jul 31, 2022, 3:44 AM

#

worldly ingot Don't think anybody's written an ItemStack serializer for Gson

I HAVE

#

except i believe it uses nms

#

because bukkit is DUMB and STUPID

#

and ive not fully tested all use cases so there's that

cedar oyster Jul 31, 2022, 3:46 AM

#

carmine nacelle guessing its because lore is a string

lore is a List of type String

carmine nacelle Jul 31, 2022, 3:47 AM

#

cedar oyster lore is a List of type String

Yes

#

I think I got it

#

by making a JsonArray instead and adding the lore to it.

cedar oyster Jul 31, 2022, 3:47 AM

#

ah yeah

compact haven Jul 31, 2022, 3:48 AM

#

carmine nacelle guys, with a custom jsonserializer I am unable to simply `obj.addProperty("itemL...

You need to make the List a JsonArray first, pretty sure the only way is to iterate and add to a new JsonArray(), then you call add with the new populated JsonArray

#

oh

carmine nacelle Jul 31, 2022, 3:48 AM

#

compact haven You need to make the List a JsonArray first, pretty sure the only way is to iter...

I did that

compact haven Jul 31, 2022, 3:48 AM

#

well it seems I’m late

carmine nacelle Jul 31, 2022, 3:48 AM

#

lol

#

np

#

now deserializing it back into an itemstack is gonna be different

noble lantern Jul 31, 2022, 3:49 AM

#

Stupid question

How can i incrase the animation speed of End Crystals? So they spin slower/faster

Or is it only client side for crystal rotation speed

echo basalt Jul 31, 2022, 3:50 AM

#

noble lantern Stupid question How can i incrase the animation speed of End Crystals? So they ...

clientside

#

server wouldn't bother

noble lantern Jul 31, 2022, 3:51 AM

#

z_aCRYYY

echo basalt Jul 31, 2022, 3:51 AM

#

maybe?

noble lantern Jul 31, 2022, 3:52 AM

#

wtf

#

didnt even think of nms ngl

#

wth would time be thats a big ass number

#

0 - 1m

echo basalt Jul 31, 2022, 3:53 AM

#

it isnt even getting used

#

probably leftover code

glossy scroll Jul 31, 2022, 3:54 AM

#

@carmine nacelle

#

hello

#

    public static final class ItemStackJsonSerializer implements JsonSerializer<ItemStack>, JsonDeserializer<ItemStack> {
        @Override
        public JsonElement serialize(ItemStack src, Type typeOfSrc, JsonSerializationContext context) {
            return new JsonPrimitive(CraftItemStack.asNMSCopy(src).save(new CompoundTag()).getAsString());
        }

        @Override
        public ItemStack deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context) throws JsonParseException {
            try {
                String asString = json.getAsJsonPrimitive().getAsString();
                CompoundTag compoundTag = TagParser.parseTag(asString);
                net.minecraft.world.item.ItemStack nmsStack = net.minecraft.world.item.ItemStack.of(compoundTag);
                return CraftItemStack.asCraftMirror(nmsStack);
            } catch (CommandSyntaxException e) {
                throw new IllegalArgumentException(e);
            }
        }
    }```

#

this is an item stack json serializer

#

i will warn you

#

this is untested for most items

carmine nacelle Jul 31, 2022, 3:55 AM

#

    @Override
    public JsonElement serialize(ItemStack src, Type typeOfSrc, JsonSerializationContext context) {

        if(!(src.hasItemMeta()) || !(src.getItemMeta().hasDisplayName())) return null;

        JsonArray loreArray = new JsonArray();
        for(String loreLines : src.getItemMeta().getLore()) {
            loreArray.add(loreLines);
        }

        JsonObject obj = new JsonObject();
        obj.addProperty("itemType", src.getType().toString());
        obj.addProperty("displayName", src.getItemMeta().getDisplayName());
        obj.addProperty("itemAmount", src.getAmount());
        obj.add("itemLore", loreArray);

        return obj;
    }

#

does the one I just made look fine?

glossy scroll Jul 31, 2022, 3:55 AM

#

BUT, i have confidence it will work because it literally uses nms' method for saving items to files

#

it would not account for any item meta thats unique to stuff like banners, armor, etc

carmine nacelle Jul 31, 2022, 3:55 AM

#

mine or yours

glossy scroll Jul 31, 2022, 3:55 AM

#

glossy scroll ```java public static final class ItemStackJsonSerializer implements JsonSer...

this could also be easily converted to reflection

#

yours, vivian

carmine nacelle Jul 31, 2022, 3:55 AM

#

because I dont have the tags?

glossy scroll Jul 31, 2022, 3:56 AM

#

well you would need to serialize all possible item meta types

carmine nacelle Jul 31, 2022, 3:56 AM

#

Yours does that?

glossy scroll Jul 31, 2022, 3:56 AM

#

i believe so

#

@worldly ingot do you have any second thoughts on what i have here

compact haven Jul 31, 2022, 3:58 AM

#

yours would definitely work

#

well I'm not going to make promises

glossy scroll Jul 31, 2022, 3:58 AM

#

i mean

compact haven Jul 31, 2022, 3:58 AM

#

but it's what it uses internally

glossy scroll Jul 31, 2022, 3:58 AM

#

yea

#

i dont see why it wouldnt

carmine nacelle Jul 31, 2022, 3:58 AM

#

So that'll work for serializing and deserializing...

#

nice

glossy scroll Jul 31, 2022, 3:58 AM

#

but i cant really promise anything

#

yes

compact haven Jul 31, 2022, 3:59 AM

#

Yes, but it wouldn't be editable in config

#

so it's quite a cop-out

carmine nacelle Jul 31, 2022, 3:59 AM

#

I dont need editable in config so its fine

#

just need to save/load

glossy scroll Jul 31, 2022, 3:59 AM

#

i mean it would, you would just need to know item NBT

#

i do use it for saving/loading player inventories btw

compact haven Jul 31, 2022, 3:59 AM

#

well that's fair, it just wouldn't be pretty kekw

glossy scroll Jul 31, 2022, 3:59 AM

#

idk what youre doing it for

#

i also refuse to touch ConfigurationSerializable too

carmine nacelle Jul 31, 2022, 4:00 AM

#

Well I won't be able to test it until I come up with one for locations but ill say TIA

compact haven Jul 31, 2022, 4:00 AM

#

glossy scroll i do use it for saving/loading player inventories btw

why not just make the NBT a blob and store it in a database 😢

glossy scroll Jul 31, 2022, 4:00 AM

#

can you jog my memory lol

#

nbt a blob

compact haven Jul 31, 2022, 4:00 AM

#

well the blob is unnecessary since NBT is quite literally a string

#

but why are u storing it in config files instead of a database

vestal dome Jul 31, 2022, 4:01 AM

#

can someone explain to me, what am I doing wrong?

#

the hopper items are not updated.

compact haven Jul 31, 2022, 4:01 AM

#

I don't know, maybe it hates you?

carmine nacelle Jul 31, 2022, 4:01 AM

#

How would you register this? @glossy scroll

glossy scroll Jul 31, 2022, 4:01 AM

#

?

compact haven Jul 31, 2022, 4:01 AM

#

same way Choco showed you Vivian

carmine nacelle Jul 31, 2022, 4:02 AM

#

so it counts as a TypeAdapter?

#

1s

glossy scroll Jul 31, 2022, 4:02 AM

#

oh

vestal dome Jul 31, 2022, 4:02 AM

#

compact haven I don't know, maybe it hates you?

how can it hate me.

glossy scroll Jul 31, 2022, 4:02 AM

#

its important

#

it needs to be TypeHierarchyAdapter

#

i forgor why

#

new Gson(registerTypeHierarchyAdapter(ItemStack.class, new ItemStackJsonSerializer()))

#

oops

#

thats completely wrong

#

new GsonBuilder().registerTypeHierarchyAdapter(ItemStack.class, new ItemStackJsonSerializer()).create()

glossy scroll Jul 31, 2022, 4:03 AM

#

glossy scroll i forgor why

wait i rember

#

its cuz ItemStack is an interface

compact haven Jul 31, 2022, 4:03 AM

#

TypeHierarchyAdapter registers for all subtypes

vestal dome Jul 31, 2022, 4:03 AM

#

it isn't?

#

ItemStacks are classes not interfaces.

compact haven Jul 31, 2022, 4:03 AM

#

^

glossy scroll Jul 31, 2022, 4:03 AM

#

u right

#

i really do forget why i did HierarchyAdapter

vestal dome Jul 31, 2022, 4:03 AM

#

vestal dome can someone explain to me, what am I doing wrong?

so anyone knows?

glossy scroll Jul 31, 2022, 4:04 AM

#

what is instance

compact haven Jul 31, 2022, 4:04 AM

#

It probably doesn't need to be a TypeHierarchyAdapter

vestal dome Jul 31, 2022, 4:04 AM

#

glossy scroll what is instance

Hopper

#

a Hopper

#

block state

glossy scroll Jul 31, 2022, 4:04 AM

#

yes but what class

#

package

compact haven Jul 31, 2022, 4:04 AM

#

literally Hopper

glossy scroll Jul 31, 2022, 4:04 AM

#

theres 2 i think

vestal dome Jul 31, 2022, 4:05 AM

#

org.bukkit.block.Hopper

compact haven Jul 31, 2022, 4:05 AM

#

are block states mutable

#

don't you need to set it back or something

glossy scroll Jul 31, 2022, 4:05 AM

#

should be

#

thats block data

carmine nacelle Jul 31, 2022, 4:05 AM

#

        Gson gson = new GsonBuilder()
                .registerTypeHierarchyAdapter(ItemStack.class, new ItemStackSerializer())
                        .build()

Cannot resolve method build

compact haven Jul 31, 2022, 4:05 AM

#

oh

carmine nacelle Jul 31, 2022, 4:05 AM

#

hmm

vestal dome Jul 31, 2022, 4:05 AM

#

glossy scroll thats block data

BlockState*

#

"Hopper extends BlockState, InventoryHolder"

glossy scroll Jul 31, 2022, 4:06 AM

#

no i meant

#

BlockData is immutable

#

well actually

#

it is mutable

#

it just gives a copy

compact haven Jul 31, 2022, 4:06 AM

#

well it's immutable in effect xd

vestal dome Jul 31, 2022, 4:06 AM

#

that is not the point tho

glossy scroll Jul 31, 2022, 4:06 AM

#

The returned object will never be updated, and you are not guaranteed that (for example) a sign is still a sign after you capture its state.
Returns:
BlockState with the current state of this block.```

#

i believe it is a copy

vestal dome Jul 31, 2022, 4:06 AM

#

I have a BlockState (Hopper block state) and I'm currently attempting to edit it's inventory and update.

#

but it just doesn't update.

#

the array I'm providing IS the one I want

glossy scroll Jul 31, 2022, 4:07 AM

#

but you update it

vestal dome Jul 31, 2022, 4:07 AM

#

but setContents on the inventory is not working

glossy scroll Jul 31, 2022, 4:07 AM

#

so it should be ok

vestal dome Jul 31, 2022, 4:07 AM

#

it doesn't work

#

it literally doesn't

glossy scroll Jul 31, 2022, 4:07 AM

#

i know im just saying

carmine nacelle Jul 31, 2022, 4:07 AM

#

Martoph, a location serializer should be simple right

glossy scroll Jul 31, 2022, 4:07 AM

#

uhhhh

#

not quite

carmine nacelle Jul 31, 2022, 4:07 AM

#

:(((((

compact haven Jul 31, 2022, 4:08 AM

#

yes a location serializer in incredibly easy

#

write primites x, y, z, pitch, and yaw

#

and a uuid (string) world id

#

literally it

carmine nacelle Jul 31, 2022, 4:08 AM

#

oh

vestal dome Jul 31, 2022, 4:08 AM

#

this is so stupid

carmine nacelle Jul 31, 2022, 4:08 AM

#

I thot so

glossy scroll Jul 31, 2022, 4:08 AM

#


    public static final Gson LOCATION_GSON = new GsonBuilder()
            .registerTypeAdapter(Location.class, (JsonSerializer<Location>) (src, typeOfSrc, context) -> {
                JsonObject jsonObject = new JsonObject();
                jsonObject.addProperty("x", src.getX());
                jsonObject.addProperty("y", src.getY());
                jsonObject.addProperty("z", src.getZ());
                jsonObject.addProperty("pitch", src.getPitch());
                jsonObject.addProperty("yaw", src.getYaw());
                return jsonObject;
            }).registerTypeAdapter(Location.class, (JsonDeserializer<Location>) (json, typeOfT, context) -> {
                JsonObject jsonObject = json.getAsJsonObject();
                return new Location(null, jsonObject.get("x").getAsDouble(), jsonObject.get("y").getAsDouble(), jsonObject.get("z").getAsDouble(), jsonObject.get("pitch").getAsFloat(), jsonObject.get("yaw").getAsFloat());
            }).create();```

#

well i mean

#

you still need an adapter i meant

compact haven Jul 31, 2022, 4:08 AM

#

imagine using anon classes in your gson declaration

#

couldn't be me

glossy scroll Jul 31, 2022, 4:09 AM

#

that code is apparently from nov 2021 so

compact haven Jul 31, 2022, 4:09 AM

#

man u just pass null as the world

#

🤣

carmine nacelle Jul 31, 2022, 4:09 AM

#

Whats wrong with anonymous classes

glossy scroll Jul 31, 2022, 4:09 AM

#

compact haven man u just pass null as the world

yea i should specify

carmine nacelle Jul 31, 2022, 4:09 AM

#

(idk shit about them)

glossy scroll Jul 31, 2022, 4:09 AM

#

this is for my niche use case

#

you may need to alter as necessary

#

meaning write the world name and then use Bukkit.getWorld

compact haven Jul 31, 2022, 4:10 AM

#

anonymous classes are what he did there, where he was able to put the serializer code right into the body instead of declaring a new class

compact haven Jul 31, 2022, 4:10 AM

#

glossy scroll meaning write the world name and then use Bukkit.getWorld

world uuid pls*

glossy scroll Jul 31, 2022, 4:10 AM

#

or i mean a much easier way to serialize locations if you dont care about rotation is

#

convert them to vectors

#

then you dont need a type adapter

vestal dome Jul 31, 2022, 4:11 AM

#

Ugh, Bukkit is inefficient.

glossy scroll Jul 31, 2022, 4:11 AM

#

compact haven world uuid pls*

yea that would be better, admittedly didnt know they had uuids 😬

glossy scroll Jul 31, 2022, 4:11 AM

#

carmine nacelle (idk shit about them)

well theres nothing wrong with them

carmine nacelle Jul 31, 2022, 4:11 AM

#

    @Override
    public JsonElement serialize(Location src, Type typeOfSrc, JsonSerializationContext context) {
        JsonObject jsonObject = new JsonObject();
        jsonObject.addProperty("worldUUID", src.getWorld().getUID().toString());
        jsonObject.addProperty("x", src.getX());
        jsonObject.addProperty("y", src.getY());
        jsonObject.addProperty("z",src.getZ());
        return jsonObject;
    }

glossy scroll Jul 31, 2022, 4:11 AM

#

anon classes cannot be instantiated outside that very statement

carmine nacelle Jul 31, 2022, 4:11 AM

#

hows that

compact haven Jul 31, 2022, 4:12 AM

#

^ the reason I was like "yikes" is because it'll clutter your GSON-declaring class (your plugin class, probably) with serializer code, when it really should be in a separate class

carmine nacelle Jul 31, 2022, 4:12 AM

#

Oh

compact haven Jul 31, 2022, 4:12 AM

#

carmine nacelle ```java @Override public JsonElement serialize(Location src, Type typeOf...

looks good to me, as long as u dont care for rotation

carmine nacelle Jul 31, 2022, 4:12 AM

#

well im doing this in its own class

#

nah its block locations

glossy scroll Jul 31, 2022, 4:13 AM

#

if you wanted to get really technical you could use getLeastSignificantBits and getMostSignificantBits

carmine nacelle Jul 31, 2022, 4:13 AM

#

what the hell

glossy scroll Jul 31, 2022, 4:13 AM

#

instead of deserializing a uuid from a string

compact haven Jul 31, 2022, 4:13 AM

#

kekw

#

storing 2 longs instead of a string, while the whole config is a string

glossy scroll Jul 31, 2022, 4:13 AM

#

its honestly personal preference idc

compact haven Jul 31, 2022, 4:13 AM

#

nah just keep it a string, don't worry about what he said- you'd do that type of thing if you were storing in binary form

glossy scroll Jul 31, 2022, 4:13 AM

#

you just use UUID.fromString or new UUID()

vestal dome Jul 31, 2022, 4:14 AM

#

Why does this code not work?

#

when in doubt, create thread.

compact haven Jul 31, 2022, 4:14 AM

#

when life gives you lemons, you throw them at people.

carmine nacelle Jul 31, 2022, 4:14 AM

#

    @Override
    public Location deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context) throws JsonParseException {
        JsonObject jsonObject = json.getAsJsonObject();
        UUID worldUUID = UUID.fromString(jsonObject.get("worldUUID").getAsString());
        double x = jsonObject.get("x").getAsDouble();
        double y = jsonObject.get("y").getAsDouble();
        double z = jsonObject.get("z").getAsDouble();
        Location newLocation = new Location(Bukkit.getWorld(worldUUID), x, y, z);
        
        return newLocation;
    }

vestal dome Jul 31, 2022, 4:15 AM

#

compact haven when life gives you lemons, you throw them at people.

or make lemonade.

carmine nacelle Jul 31, 2022, 4:16 AM

#

WOOO IT SAVED LFG

glossy scroll Jul 31, 2022, 4:16 AM

#

carmine nacelle ```java @Override public Location deserialize(JsonElement json, Type typ...

if you dont care about the world (i.e. it is stored somewhere else)

#

just use Location#toVector

#

and save that

#

then Vector#toLocation

compact haven Jul 31, 2022, 4:16 AM

#

no

glossy scroll Jul 31, 2022, 4:16 AM

#

you dont need typeAdapter for Vectors

compact haven Jul 31, 2022, 4:16 AM

#

then he has to do serialization logic in the saving part

#

it don't belong there

carmine nacelle Jul 31, 2022, 4:17 AM

#

[
  {
    "hiveUUID": "a9715339-642d-4908-b6a6-540fb284fc7b",
    "hiveName": "???????????C????a???d???i????a ?????H???i???v?????e??????????",
    "ownerUUID": "e42b60b0-c35a-462f-a2b4-b1a9980f399e",
    "hiveLocation": {
      "worldUUID": "423cf54e-8122-4586-b34f-9d5b70594b30",
      "x": 133.0,
      "y": -60.0,
      "z": -389.0
    },
    "holoUUIDs": [
      "46aad801-0ecf-4836-8e21-5251ae834e8e",
      "f9fde4e2-f31d-4c86-bfd7-86ac0c4e77c1",
      "b3304f5b-e7f6-4f89-bd1c-0f34fd4854ea"
    ],
    "rewardItems": [],
    "beeNames": [
      "???B???e?e"
    ],
    "beeUUIDs": [
      "e87eb370-db05-401a-b007-5b1e137f446e"
    ],
    "beeAmt": 2,
    "honeyAmt": 0,
    "hiveLevel": {
      "hiveLevel": 1,
      "maxBees": 1,
      "maxHoney": 5,
      "cost": 0,
      "rewardChance": 0
    },
    "hiveStatus": "PRODUCING",
    "beesBeingRenamed": false
  }
]

compact haven Jul 31, 2022, 4:17 AM

#

wottf

carmine nacelle Jul 31, 2022, 4:17 AM

#

im satisfied with this i suppose, idk why its turning some of my stuff into weird characters lmao

glossy scroll Jul 31, 2022, 4:17 AM

#

wdym no im saying you would

#

serialize the vector

vestal dome Jul 31, 2022, 4:17 AM

#

carmine nacelle ```json [ { "hiveUUID": "a9715339-642d-4908-b6a6-540fb284fc7b", "hiveN...

hiveName: ???????????C????a???d???i????a ?????H???i???v?????e??????????

#

wtf

glossy scroll Jul 31, 2022, 4:17 AM

#

because gson works very nicely with vectors

carmine nacelle Jul 31, 2022, 4:17 AM

#

Yeah idk

#

its actually...
#25ec0dH#2eea0ci#37e80av#3fe609e #48e407L#51e206e#5ae004v#62de03e#6bdc01l#74da00

compact haven Jul 31, 2022, 4:18 AM

#

yes but then he needs to either store Vectors in the class, or write vectors in JsonObject

#

it just doesn't make sense

carmine nacelle Jul 31, 2022, 4:18 AM

#

its hex coded text.

compact haven Jul 31, 2022, 4:18 AM

#

Why is it doing that

glossy scroll Jul 31, 2022, 4:18 AM

#

yea

#

you should debug that

carmine nacelle Jul 31, 2022, 4:18 AM

#

I have no clue

glossy scroll Jul 31, 2022, 4:18 AM

#

you shouldnt have 2 serialization things going on at the same time

carmine nacelle Jul 31, 2022, 4:18 AM

#

#

its hex text

#

So idk why its translating to that

glossy scroll Jul 31, 2022, 4:19 AM

#

what are you deserializing

#

what is that field

compact haven Jul 31, 2022, 4:19 AM

#

make sure you have .disableHtmlEscaping(), but that shouldn't be the cause

#

it's a string with hex codes I presume

carmine nacelle Jul 31, 2022, 4:19 AM

#

carmine nacelle its hex text

yes

glossy scroll Jul 31, 2022, 4:19 AM

#

but its just a string right?

carmine nacelle Jul 31, 2022, 4:19 AM

#

yes

glossy scroll Jul 31, 2022, 4:19 AM

#

ok

carmine nacelle Jul 31, 2022, 4:19 AM

#

compact haven make sure you have `.disableHtmlEscaping()`, but that shouldn't be the cause

That didnt change it

#

weird af

#

It was working fine when I was saving it in a yml

compact haven Jul 31, 2022, 4:20 AM

#

are we sure it's saving like that, and it's not just your text editor

carmine nacelle Jul 31, 2022, 4:20 AM

#

gui-name: '#c35bfb⋯#b65ff8「#a963f6C#9c67f3a#8f6af0d#826eedi#7572eba #6776e8H#5a7ae5i#4d7ee2v#4081e0e#3385dd」#2689da⋯'

#

this is how that same thing looks when saved in yml

glossy scroll Jul 31, 2022, 4:21 AM

#

compact haven are we sure it's saving like that, and it's not just your text editor

this is good point

carmine nacelle Jul 31, 2022, 4:21 AM

#

im using N++

compact haven Jul 31, 2022, 4:21 AM

#

send the file

carmine nacelle Jul 31, 2022, 4:21 AM

#

📎 hives.json

#

Dafuq

glossy scroll Jul 31, 2022, 4:21 AM

#

now i see §

compact haven Jul 31, 2022, 4:21 AM

#

ah that's what it is

vestal dome Jul 31, 2022, 4:22 AM

#

why do you even have to store the UUID of the holograms?

carmine nacelle Jul 31, 2022, 4:22 AM

#

cause my holos save to file also

vestal dome Jul 31, 2022, 4:22 AM

#

well

#

using NMS to create holos is an idea..

carmine nacelle Jul 31, 2022, 4:22 AM

#

its packets

golden turret Jul 31, 2022, 4:22 AM

#

carmine nacelle im using N++

n++????

vestal dome Jul 31, 2022, 4:22 AM

#

WHAT?

carmine nacelle Jul 31, 2022, 4:22 AM

#

notepad++

compact haven Jul 31, 2022, 4:23 AM

#

legit the best text editor

noble lantern Jul 31, 2022, 4:23 AM

#

golden turret n++????

OHGODWHAT

carmine nacelle Jul 31, 2022, 4:23 AM

#

yes

golden turret Jul 31, 2022, 4:23 AM

#

i was like

#

c++ made a kid?

carmine nacelle Jul 31, 2022, 4:23 AM

#

KEKDOUBLEYOU

compact haven Jul 31, 2022, 4:23 AM

#

anyways

noble lantern Jul 31, 2022, 4:23 AM

#

emoji fail laugh at this user

compact haven Jul 31, 2022, 4:24 AM

#

your notepad++ encoding is wrong for that json file

carmine nacelle Jul 31, 2022, 4:24 AM

#

emoji fail?

compact haven Jul 31, 2022, 4:24 AM

#

that's why it can't read the section symbol unicode

carmine nacelle Jul 31, 2022, 4:24 AM

#

How can I change it

compact haven Jul 31, 2022, 4:24 AM

#

and it shows as that weird thing

carmine nacelle Jul 31, 2022, 4:24 AM

#

Oh

#

Hmmmm

#

Idk what one I would want

#

I tried converting to all the different options and nothing changed

compact haven Jul 31, 2022, 4:27 AM

#

UTF-8

#

but it should be on that xd

modest garnet Jul 31, 2022, 4:27 AM

#

can someone join a leave a 1.19 mc server real quick i wanna test a plugin

carmine nacelle Jul 31, 2022, 4:27 AM

#

it is

#

    public void loadHives() {
        File file = new File(cadiaBees.getDataFolder().getAbsolutePath() + "/hives.json");

        if(file.exists()) {
            Reader reader = null;
            try {
                reader = new FileReader(file);
            } catch (FileNotFoundException e) {
                e.printStackTrace();
            }

            Gson gson = new GsonBuilder()
                    .registerTypeHierarchyAdapter(ItemStack.class, new ItemStackSerializer())
                    .registerTypeHierarchyAdapter(Location.class, new LocationSerializer())
                    .disableHtmlEscaping()
                    .setPrettyPrinting()
                    .create();
            
            List<CustomHive> hives = gson.fromJson(reader, (Type) CustomHive[].class);
            for(CustomHive hive : hives) cadiaBees.hiveManager.addHive(hive);
        }
    }

 class [Lcom.squallz.cadiabees.objects.CustomHive; cannot be cast to class java.util.List ([Lcom.squallz.cadiabees.objects.CustomHive; is in unnamed module of loader org.bukkit.plugin.java.PluginClassLoader @639c9c75; java.util.List is in module java.base of loader 'bootstrap')
        at com.squallz.cadiabees.managers.configmanagers.ConfigManager.loadHives(ConfigManager.java:67) ~[?:?]

#

wat

#

List<CustomHive> hives = gson.fromJson(reader, (Type) CustomHive[].class); this line is the error

compact haven Jul 31, 2022, 4:29 AM

#

ehm

glossy scroll Jul 31, 2022, 4:29 AM

#

ok so

#

you need type adapter

#

or wait

compact haven Jul 31, 2022, 4:29 AM

#

he needs no such thing

#

give me one second

glossy scroll Jul 31, 2022, 4:29 AM

#

type token

#

new TypeToken<List<CustomHive>>() {}.getType()

compact haven Jul 31, 2022, 4:30 AM

#

Type listType = new TypeToken<ArrayList<CustomHive>>(){}.getType();

carmine nacelle Jul 31, 2022, 4:30 AM

#

REEE ANONYMOUS CLASS REEEEE

#

jk

#

ily in the gayest possible way

#

but its erroring on something kinda unrelated now

golden turret Jul 31, 2022, 4:35 AM

#

carmine nacelle ```java public void loadHives() { File file = new File(cadiaBees.get...

whats the probleem

carmine nacelle Jul 31, 2022, 4:35 AM

#

[
  {
    "hiveUUID": "a1455d0e-7466-47d9-989d-f5f2939f9d58",
    "hiveName": "???????????C????a???d???i????a ?????H???i???v?????e??????????",
    "ownerUUID": "e42b60b0-c35a-462f-a2b4-b1a9980f399e",
    "hiveLocation": {
      "worldUUID": "423cf54e-8122-4586-b34f-9d5b70594b30",
      "x": 138.0,
      "y": -60.0,
      "z": -379.0
    },
    "holoUUIDs": [
      "33449cc6-63d0-4a51-a4b6-f7093470feaf",
      "390166f1-2946-4ac8-bb9e-3099769de6c1",
      "4837653b-47ed-4f0b-962d-e7eb7864c547"
    ],
    "rewardItems": [],
    "beeNames": [
      "???B???e?e"
    ],
    "beeUUIDs": [
      "1b4682e9-4c41-4a92-b466-23651abd5999"
    ],
    "beeAmt": 2,
    "honeyAmt": 0,
    "hiveLevel": {
      "hiveLevel": 1,
      "maxBees": 1,
      "maxHoney": 5,
      "cost": 0,
      "rewardChance": 0
    }
  }
]

So this is my file

#

im loading it

#

error

[00:32:27] [Server thread/ERROR]: Error occurred while enabling CadiaBees v${project.version} (Is it up to date?)
java.lang.NullPointerException: Cannot invoke "com.squallz.cadiabees.objects.HiveLevel.getMaxHoney()" because the return value of "com.squallz.cadiabees.managers.HiveLevelManager.getHiveLevel(int)" is null

golden turret Jul 31, 2022, 4:36 AM

#

hm

carmine nacelle Jul 31, 2022, 4:36 AM

#

It shouldnt be erroring because... getMaxHoney should be returning the "maxHoney" for the hiveLevel in the json

golden turret Jul 31, 2022, 4:36 AM

#

getHiveLevel is null

carmine nacelle Jul 31, 2022, 4:37 AM

#

yeah but it should be...

#

shouldnt*

#

weird.

#

[00:38:56] [Server thread/INFO]: LEVEL: 1

#

                Bukkit.getLogger().info("LEVEL: " + hive.getHiveLevel().getHiveLevel().toString());

#

sussy

glossy scroll Jul 31, 2022, 4:39 AM

#

why are you using the Integer wrapper?

carmine nacelle Jul 31, 2022, 4:39 AM

#

wdym

kind hatch Jul 31, 2022, 4:39 AM

#

Also, why are you calling #getHiveLevel() twice?

carmine nacelle Jul 31, 2022, 4:39 AM

#

so

#

its just bad naming

#

package com.squallz.cadiabees.objects;

public class HiveLevel {
    private Integer hiveLevel;
    private Integer maxBees;
    private Integer maxHoney;
    private Integer cost;
    private Integer rewardChance;

    public HiveLevel(Integer hiveLevel, Integer maxBees, Integer maxHoney, Integer cost, Integer rewardChance) {
        setHiveLevel(hiveLevel);
        setMaxBees(maxBees);
        setMaxHoney(maxHoney);
        setCost(cost);
        setRewardChance(rewardChance);
    }

    public Integer getHiveLevel() {
        return this.hiveLevel;
    }

    public void setHiveLevel(Integer hiveLevel) {
        this.hiveLevel = hiveLevel;
    }

    public Integer getMaxBees() {
        return this.maxBees;
    }

    public Integer getMaxHoney() {
        return this.maxHoney;
    }

    public Integer getCost() {
        return this.cost;
    }

    public Integer getRewardChance() {
        return this.rewardChance;
    }

    public void setCost(Integer cost) {
        this.cost = cost;
    }

    public void setRewardChance(Integer rewardChance) {
        this.rewardChance = rewardChance;
    }

    public void setMaxBees(Integer maxBees){
        this.maxBees = maxBees;
    }

    public void setMaxHoney(Integer maxHoney) {
        this.maxHoney = maxHoney;
    }
}

#

the getHiveLevel in my HiveLevel class is just the numeric value.

glossy scroll Jul 31, 2022, 4:40 AM

#

You're using the wrapper Integer and not the primitive

#

yes

#

exactly

carmine nacelle Jul 31, 2022, 4:40 AM

#

can you elaborate

glossy scroll Jul 31, 2022, 4:40 AM

#

Integer is not the same as int

golden turret Jul 31, 2022, 4:40 AM

#

you using Integer

#

which is an object

glossy scroll Jul 31, 2022, 4:40 AM

#

boxed type vs primitive type

golden turret Jul 31, 2022, 4:41 AM

#

and every object can be null

carmine nacelle Jul 31, 2022, 4:41 AM

#

i usually use them interchangeably 😓

glossy scroll Jul 31, 2022, 4:41 AM

#

you... shouldnt

golden turret Jul 31, 2022, 4:41 AM

#

you should do that only when need

#

example

#

when retrieving data from database and the null represents empty data

glossy scroll Jul 31, 2022, 4:42 AM

#

yes, if your integer needs to be represented as null then use the boxing

#

otherwise use primitive

carmine nacelle Jul 31, 2022, 4:42 AM

#

where should I change it..

glossy scroll Jul 31, 2022, 4:42 AM

#

Integer -> int

carmine nacelle Jul 31, 2022, 4:42 AM

#

well

#

public class CustomHive {
    private UUID hiveUUID;
    private String hiveName;
    private UUID ownerUUID;
    private Location hiveLocation;
    private List<UUID> holoUUIDs;
    private List<RewardItem> rewardItems;
    private List<String> beeNames;
    private List<UUID> beeUUIDs;
    private int beeAmt;
    private int honeyAmt;
    private HiveLevel hiveLevel;
    private transient HiveStatus hiveStatus;
    private transient Boolean beesBeingRenamed = false;

#

I use int in my custom object

crisp steeple Jul 31, 2022, 4:43 AM

#

using Boolean is almost never a good idea

#

you dont want to end up with a troolean

carmine nacelle Jul 31, 2022, 4:43 AM

#

WHAT IS THAT

crisp steeple Jul 31, 2022, 4:43 AM

#

boolean = true, false
Boolean = true, false, null

glossy scroll Jul 31, 2022, 4:43 AM

#

yea you have a big problem with using box types unnecessarily

carmine nacelle Jul 31, 2022, 4:43 AM

#

omg

glossy scroll Jul 31, 2022, 4:43 AM

#

you need to convert these to primitive

carmine nacelle Jul 31, 2022, 4:43 AM

#

I thought the capitalized version was primitive

glossy scroll Jul 31, 2022, 4:43 AM

#

https://medium.com/geekculture/effective-java-prefer-primitive-types-to-boxed-types-ea02eb9b8c62

Medium

Effective Java: Prefer Primitive Types to Boxed Types

Comparing the benefits and issues with using boxed types vs primitive types in Java.

#

no...

#

capitalized version is a wrapper object

carmine nacelle Jul 31, 2022, 4:44 AM

#

is that my issue?

glossy scroll Jul 31, 2022, 4:44 AM

#

could be

glossy scroll Jul 31, 2022, 4:44 AM

#

carmine nacelle error ``` [00:32:27] [Server thread/ERROR]: Error occurred while enabling CadiaB...

where is this

#

in your code

carmine nacelle Jul 31, 2022, 4:45 AM

#

hold on

#

now that I changed my stuff to ints

#

it no longer lets me call #tostring

glossy scroll Jul 31, 2022, 4:45 AM

#

you dont need tostring for primitive

#

you could be picky and do String.valueOf()

carmine nacelle Jul 31, 2022, 4:46 AM

#

https://i.gyazo.com/b8137ef0d1c89b05b2eb8304db68a030.mp4

▶ Play video

#

String.valueOf works

glossy scroll Jul 31, 2022, 4:46 AM

#

oh yea you would need string valueOf

#

or just

#

"" + i

#

but thats

#

weird idk

carmine nacelle Jul 31, 2022, 4:47 AM

#

also

#

is there a better way to do what I just showed

#

it looks like cheeks but it works

glossy scroll Jul 31, 2022, 4:47 AM

#

i mean oyure not realy elaborating here

#

what is inputString

carmine nacelle Jul 31, 2022, 4:47 AM

#

    public String replacePlaceholders(String inputString, CustomHive customHive) {
        String returnString;

        HiveLevel hiveLevel =customHive.getHiveLevel();
        returnString =
            inputString.replace("{NEXT-HIVE-LEVEL}", String.valueOf(hiveLevel.getHiveLevel()))
            .replace("{NEXT-HIVE-COST}", String.valueOf(hiveLevel.getCost()))
            .replace("{NEXT-MAX-BEES}", String.valueOf(hiveLevel.getMaxBees()))
            .replace("{NEXT-MAX-HONEY}", String.valueOf(hiveLevel.getMaxHoney()))
            .replace("{NEXT-REWARD-CHANCE}", String.valueOf(hiveLevel.getRewardChance()))
            .replace("{BEE-AMOUNT}", String.valueOf(customHive.getBeeAmt())
            .replace("{HIVE-LEVEL}", String.valueOf(hiveLevel.getHiveLevel())
            .replace("{HIVE-NAME}", String.valueOf(customHive.getHiveName())
            .replace("{HONEY-LEVEL}", String.valueOf(customHive.getHoneyAmt());

        return returnString;
    }

#

ohg

#

Takes a string input and replaces the placeholders with real values

#

its so I can have configurable messages.

glossy scroll Jul 31, 2022, 4:48 AM

#

ok for one thing that method looks like it could be static

#

i personally would opt for String.format

strong parcel Jul 31, 2022, 4:49 AM

#

I tried that, but I get the same result.

glossy scroll Jul 31, 2022, 4:49 AM

#

https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/String.html#format(java.lang.String,java.lang.Object...)

String (Java SE 17 & JDK 17)

declaration: module: java.base, package: java.lang, class: String

#

something like

carmine nacelle Jul 31, 2022, 4:50 AM

#

javadocs are always confusing to understand

glossy scroll Jul 31, 2022, 4:51 AM

#

String.format("The hive level is %d", myInt)

#

i mean not really

#

that would produce "The hive level is 3" if myInt was 3

carmine nacelle Jul 31, 2022, 4:51 AM

#

for me cause im stupid lmao

carmine nacelle Jul 31, 2022, 4:51 AM

#

glossy scroll `String.format("The hive level is %d", myInt)`

And I could do this for each placeholder?

glossy scroll Jul 31, 2022, 4:51 AM

#

yea so you could do somehing like

#

String.format("The hive level is %d and it has %d bees", hiveLevel, numBees)

#

would say "The hive level is 3 and it has 2 bees" if numBees was 2

#

if you did String.format("The hive level is %d and it has %d bees", numBees, hiveLevel)

#

you would get "The hive level is 2 and it has 3 bees"

carmine nacelle Jul 31, 2022, 4:53 AM

#

gotcha

somber hull Jul 31, 2022, 4:53 AM

#

Can someone skim through this rq and lmk if theres anyhting i can imrove on.

#

https://github.com/Silent-Program/BetterSpawners/tree/1.1.0

GitHub

GitHub - Silent-Program/BetterSpawners at 1.1.0

Contribute to Silent-Program/BetterSpawners development by creating an account on GitHub.

carmine nacelle Jul 31, 2022, 4:54 AM

#

Dang.. I cant do like level.equals(level) anymore

#

with the ints

glossy scroll Jul 31, 2022, 4:54 AM

#

no and you SHOULDNT

somber hull Jul 31, 2022, 4:54 AM

#

==

compact haven Jul 31, 2022, 4:54 AM

#

bro what

carmine nacelle Jul 31, 2022, 4:54 AM

#

== cannot be applied to int

compact haven Jul 31, 2022, 4:54 AM

#

heh

glossy scroll Jul 31, 2022, 4:54 AM

#

yes it can

somber hull Jul 31, 2022, 4:54 AM

#

wat

compact haven Jul 31, 2022, 4:54 AM

#

are you doing

somber hull Jul 31, 2022, 4:54 AM

#

y lmao

compact haven Jul 31, 2022, 4:54 AM

#

level.==(level)

#

tf u doin

glossy scroll Jul 31, 2022, 4:54 AM

#

primitives literally are there so you can use ==

compact haven Jul 31, 2022, 4:54 AM

#

^

glossy scroll Jul 31, 2022, 4:54 AM

#

== cannot be applied objects

compact haven Jul 31, 2022, 4:54 AM

#

no it can be used everywhere

#

just not safely

glossy scroll Jul 31, 2022, 4:54 AM

#

well yea

#

technicality i suppose

#

.equals compares two objects

compact haven Jul 31, 2022, 4:55 AM

#

that's why we love Kotlin

#

because == is .equals()

glossy scroll Jul 31, 2022, 4:55 AM

#

== compares them in memory

#

well in java .equals is == so ha

compact haven Jul 31, 2022, 4:55 AM

#

no it is nit

glossy scroll Jul 31, 2022, 4:55 AM

#

unless you impl it

#

its the default

compact haven Jul 31, 2022, 4:55 AM

#

well yes and no 😢

#

anyways Kotlin superior

glossy scroll Jul 31, 2022, 4:56 AM

#

Kotlin is just unreadable java

#

its like half-compiled java

strong parcel Jul 31, 2022, 4:56 AM

#

I double checked the main file, and the listener is registered. I also have the gui's class implement listener. Also, the system should only print the error message I made if it recognizes the event, right? Would you mind explaining your subclass theory a bit more?

carmine nacelle Jul 31, 2022, 4:57 AM

#

YOOOOOO ITS WORKING

#

LETS GOOOOOOOOOOOOOOOOOOOOOOOOOOO

opal juniper Jul 31, 2022, 5:01 AM

#

don’t call your main class that you extend, MainClass. call it like SpawnerPlugin

#

@somber hull

kind hatch Jul 31, 2022, 5:01 AM

#

?main

undone axleBOT Jul 31, 2022, 5:01 AM

#

https://www.spigotmc.org/threads/why-you-shouldnt-name-your-main-plugin-class-main.493289/

compact haven Jul 31, 2022, 5:04 AM

#

glossy scroll Kotlin is just unreadable java

Kotlin is glorified Java but better

#

ur blind, quite clearly

#

obviously only knowing Java won't let you read Kotlin code

#

it's a different language

#

to read Kotlin code u must learn Kotlin

granite burrow Jul 31, 2022, 5:21 AM

#

is it possible to convert World#getTime() to a date format that the SimpleDateFormat would work on?

EX: World time is 24000 so if the SDF was set to HH:mm the output would be 00:00

somber hull Jul 31, 2022, 5:30 AM

#

opal juniper don’t call your main class that you extend, MainClass. call it like SpawnerPlugi...

ALr, i thought in that case it would be fine

echo basalt Jul 31, 2022, 5:41 AM

#

granite burrow is it possible to convert `World#getTime()` to a date format that the `SimpleDat...

multiply world#getTime by 3.6 and you have the seconds passed since midnight

#

why 3.6? because there are 86400 seconds in a day / 24000 ticks

#

So each game tick represents 3.6 seconds in a day

#

or each game second represents 72 seconds in a day

quaint berry Jul 31, 2022, 5:47 AM

#

Is there a way to force the model inside an item frame to stay loaded?

carmine nacelle Jul 31, 2022, 6:07 AM

#

I once again come with another stupid question

#

I need to store an ArrayList<String> into a String for PDC, then return it back as an ArrayList<String>

#

    public ItemStack setStoredBeeNames(ItemStack itemStack, List<String> beeNames) {
        NamespacedKey storedBeeNames = new NamespacedKey(cadiaBees, "stored-bee-names");

        if(!(itemStack.hasItemMeta()) || itemStack.getItemMeta().getDisplayName() == null ) return null;

        ItemMeta itemMeta = itemStack.getItemMeta();
        PersistentDataContainer container = itemMeta.getPersistentDataContainer();

        container.set(storedBeeNames, PersistentDataType.STRING, String.valueOf(beeNames));
        itemStack.setItemMeta(itemMeta);
        return itemStack;
    }

#

    public List<String> getStoredBeeNames(ItemStack itemStack) {
        NamespacedKey storedBeeNames = new NamespacedKey(cadiaBees, "stored-bee-names");

        if(!(itemStack.hasItemMeta()) || itemStack.getItemMeta().getDisplayName() == null || itemStack.getItemMeta().getPersistentDataContainer() == null) return new ArrayList<>();

        ItemMeta itemMeta = itemStack.getItemMeta();
        PersistentDataContainer container = itemMeta.getPersistentDataContainer();

        if (container.has(storedBeeNames, PersistentDataType.STRING)) {
            List<String> beeNames = new ArrayList<>();

            String beeNameString = container.get(storedBeeNames, PersistentDataType.STRING);
            if(beeNameString.contains(",")) {
                String[] beeNameArray = beeNameString.split(",");

                beeNames.addAll(Arrays.stream(beeNameArray).toList());
            } else {
                beeNames.add(cadiaBees.colorUtil.color(beeNameString));
            }
        }

        return new ArrayList<>();
    }

#

this no worky. Translation: returns nothing

strong parcel Jul 31, 2022, 6:14 AM

#

Does anybody know what is causing e.getInventory.equals(gui) to return false? I don't know what is causing the inventories to be unequal. The event is registered, and I also tried using getClickedInventory but got the same result. https://paste.md-5.net/jidarotovo.java

oblique vigil Jul 31, 2022, 6:15 AM

#

Hey, im having trouble getting the amount of a specific itemstack in a player's inventory. I can remove 1 just fine, but I need to get the amount they have if they have more than one. Ive seen plenty of threads about a normal material, such as Material.COBBLESTONE, etc. but not a custom itemstack with custom values.

Thanks!

vestal dome Jul 31, 2022, 6:15 AM

#

strong parcel Does anybody know what is causing e.getInventory.equals(gui) to return false? I ...

let's assume that the gui is equal, what can disprove they're equal?

#

if you call the method again it will overwrite the existence gui

#

and since they're different it will return false.

vestal dome Jul 31, 2022, 6:16 AM

#

oblique vigil Hey, im having trouble getting the amount of a specific itemstack in a player's ...

bukkit has methods for that?

oblique vigil Jul 31, 2022, 6:16 AM

#

it has a method to get an item in a persons inventory, but not to return the amount of that specific item

vestal dome Jul 31, 2022, 6:17 AM

#

just

strong parcel Jul 31, 2022, 6:17 AM

#

vestal dome and since they're different it will return false.

I am the only one testing this, and the gui comes back unequal on the first test.

vestal dome Jul 31, 2022, 6:18 AM

#

oblique vigil it has a method to get an item in a persons inventory, but not to return the amo...

int amount;
for (ItemStack item : inventory.getContents()) {
  if (item != null && item.equals(yourItem)) {
    amount += item.getAmount();
  }
}

vestal dome Jul 31, 2022, 6:19 AM

#

strong parcel I am the only one testing this, and the gui comes back unequal on the first test...

uh?

#

hm

#

are you using the same listener instance?

strong parcel Jul 31, 2022, 6:21 AM

#

I am not sure what you mean by that.

vestal dome Jul 31, 2022, 6:21 AM

#

how do you open the gui

strong parcel Jul 31, 2022, 6:22 AM

#

I open it through a command

vestal dome Jul 31, 2022, 6:22 AM

#

well show me the command

strong parcel Jul 31, 2022, 6:22 AM

#

https://paste.md-5.net/jowenufivu.cs

vestal dome Jul 31, 2022, 6:23 AM

#

so you're instantiating the class to open the gui every time

#

and the gui will always be different, unless gui is defined as static.

#

and even then it will be different if more people execute it

oblique vigil Jul 31, 2022, 6:24 AM

#

vestal dome ```java int amount; for (ItemStack item : inventory.getContents()) { if (item ...

that doesnt work, i tried putting it into a static method and its just returns null because "ItemStack item" is null

#

https://gyazo.com/6474fdccee4d8886fb76b3eee240160b

vestal dome Jul 31, 2022, 6:24 AM

#

fixed

#

check it again

#

I'm sorry

#

ItemStack can be null sometimes

#

soooo

#

just checking for it will fix it

oblique vigil Jul 31, 2022, 6:25 AM

#

kk lemme see

#

still doesnt work

#

https://gyazo.com/0111d14ab9936b8684ebf7673193d01c <- inventory method

https://gyazo.com/d36fcb065a0ddf84514f9ff077e283da <- method to check @vestal dome

vestal dome Jul 31, 2022, 6:28 AM

#

weeeirrd

oblique vigil Jul 31, 2022, 6:28 AM

#

yeah, checking inventories is a mess

#

its so confusing

vestal dome Jul 31, 2022, 6:30 AM

#

so uhh

#

hm

#

are you sure you have enough items

oblique vigil Jul 31, 2022, 6:31 AM

#

yeah, the method for checking checks if they have greater than 1 of the item stack after they get the amount

#

unless the way i made the method is just broken

#

but i would assume it would be with the InventoryUtils method and not the method that checks the result

vestal dome Jul 31, 2022, 6:32 AM

#

really weird

#

should be working

#

unless there's a difference

oblique vigil Jul 31, 2022, 6:33 AM

#

its probably me inventory method just not returning the amount but idk how to fix it so it would

vestal dome Jul 31, 2022, 6:34 AM

#

my guess is the item isn't equal

oblique vigil Jul 31, 2022, 6:35 AM

#

if it wasnt equal then this else statement https://gyazo.com/7e9b336817aec8bc77518a4386372d2e wouldnt either, but the else statement fires even if i have greater than 1

river oracle Jul 31, 2022, 6:53 AM

#

oblique vigil if it wasnt equal then this else statement https://gyazo.com/7e9b336817aec8bc775...

whats your issue I can probably help

oblique vigil Jul 31, 2022, 6:53 AM

#

im trying to make a static method that returns the amount of a specific itemstack in a players inventory

#

not a material

#

the itemstack has custom attributes added to it so i need to check if its an itemstack

river oracle Jul 31, 2022, 6:53 AM

#

let's see the code

#

?paste

undone axleBOT Jul 31, 2022, 6:53 AM

#

https://paste.md-5.net/

oblique vigil Jul 31, 2022, 6:54 AM

#

https://paste.md-5.net/liweheyahi.cs

echo basalt Jul 31, 2022, 6:55 AM

#

What if you only have 1 coral

river oracle Jul 31, 2022, 6:55 AM

#

oblique vigil https://paste.md-5.net/liweheyahi.cs

equals equaits the amount of item as well

#

I'd reccomend using isSimilar

#

it disregards stack size

echo basalt Jul 31, 2022, 6:55 AM

#

Oh yeah that too

oblique vigil Jul 31, 2022, 6:55 AM

#

ok lemme see

echo basalt Jul 31, 2022, 6:55 AM

#

I'm hella sleep deprived didn't even spot it

river oracle Jul 31, 2022, 6:56 AM

#

I work best late at night lol

echo basalt Jul 31, 2022, 6:56 AM

#

I got out of bed

river oracle Jul 31, 2022, 6:56 AM

#

1am-3am are the sweet spot

echo basalt Jul 31, 2022, 6:56 AM

#

To make clientside map canvases

river oracle Jul 31, 2022, 6:56 AM

#

lol

echo basalt Jul 31, 2022, 6:56 AM

#

It's 8 am

river oracle Jul 31, 2022, 6:56 AM

#

I work best late at night surprisingly

echo basalt Jul 31, 2022, 6:56 AM

#

Same

river oracle Jul 31, 2022, 6:57 AM

#

I have issues with concentration so the calmness really helps

#

I can sip on my tea in peace

echo basalt Jul 31, 2022, 6:57 AM

#

Thing is I've been working with no days off for the past few months/years

oblique vigil Jul 31, 2022, 6:57 AM

#

that didnt work

river oracle Jul 31, 2022, 6:57 AM

#

oblique vigil that didnt work

are you sure its the same item with 100% certainty

#

is the item data the same

oblique vigil Jul 31, 2022, 6:57 AM

#

it just runs the else statement as if i onyl have 1 in my inventory

#

yes

#

10000000%

echo basalt Jul 31, 2022, 6:58 AM

#

Sout both items

oblique vigil Jul 31, 2022, 6:58 AM

#

i give the items in a command and they're the exact same cause if they werent the else statement wouldnt fire

river oracle Jul 31, 2022, 6:58 AM

#

my next question would be why aren't you checking for the custom data instead of similarity

#

I feel like it'd be more precise to just check for that specific data

echo basalt Jul 31, 2022, 6:59 AM

#

I've had issues where 1 item had those legacy color codes on its name

#

And the other had components

#

isSimilar said they're different

river oracle Jul 31, 2022, 6:59 AM

#

yea I prefer to check specific values on items i usually ad like a byte pdc or something

oblique vigil Jul 31, 2022, 6:59 AM

#

plugin is all in 1.18

#

it wouldnt be any different

river oracle Jul 31, 2022, 7:00 AM

#

stdout both items and make sure they are exactly the same

#

don't assume

#

just stdout it

echo basalt Jul 31, 2022, 7:00 AM

#

river oracle yea I prefer to check specific values on items i usually ad like a byte pdc or s...

That 1 byte tag

river oracle Jul 31, 2022, 7:00 AM

#

hmhm I love my 1 byte PDC tags

river oracle Jul 31, 2022, 7:01 AM

#

echo basalt That 1 byte tag

I say we ditch databases and only use PDC from now on

carmine nacelle Jul 31, 2022, 7:01 AM

#

Anyone here a particle math wiz

echo basalt Jul 31, 2022, 7:01 AM

#

river oracle I say we ditch databases and only use PDC from now on

Store an entire skyblock island in player pdc

river oracle Jul 31, 2022, 7:01 AM

#

Lol these are the times I wish I could do 3d math but I'm hopeless

echo basalt Jul 31, 2022, 7:01 AM

#

👍

#

3d math is fun

river oracle Jul 31, 2022, 7:01 AM

#

echo basalt Store an entire skyblock island in player pdc

you probably could if you used Mfnalex's more data types

carmine nacelle Jul 31, 2022, 7:01 AM

#

I suck at it

#

I wanna make a looping particle helix, ive done it before but I forgot how

echo basalt Jul 31, 2022, 7:01 AM

#

Except for quaternions and euler angles

river oracle Jul 31, 2022, 7:02 AM

#

I'm good at math I just haven't had to learn it yet

compact haven Jul 31, 2022, 7:02 AM

#

that would be a terrible idea please do not

echo basalt Jul 31, 2022, 7:02 AM

#

That shit makes me mad

carmine nacelle Jul 31, 2022, 7:02 AM

#

by done it before I mean I found a chunk of code and slightly modified it.

river oracle Jul 31, 2022, 7:02 AM

#

compact haven that would be a terrible idea please do not

I say we do it anyways I'd like to see how much lag that could cause

echo basalt Jul 31, 2022, 7:02 AM

#

I made satanic cows with async particles out of pure nms

compact haven Jul 31, 2022, 7:02 AM

#

oh I meant the islands in pdc

#

that’s just cursed

river oracle Jul 31, 2022, 7:02 AM

#

yea I know

#

lol

#

I'd totally do that shit

compact haven Jul 31, 2022, 7:02 AM

#

having fun with particles, that’s amazing

oblique vigil Jul 31, 2022, 7:02 AM

#

river oracle stdout both items and make sure they are exactly the same

if they werent the exact same, then the else statement wouldnt fire because they both require red corals, it has to be an issue with getItemsInInventory# method but i dont know what the issue would be

echo basalt Jul 31, 2022, 7:03 AM

#

Spinning pentagram with a helix on top

#

Was fun

river oracle Jul 31, 2022, 7:03 AM

#

oblique vigil if they werent the exact same, then the else statement wouldnt fire because they...

let me see the other code your talking about

echo basalt Jul 31, 2022, 7:03 AM

#

Cows would fly like blazes and shoot fireballs

river oracle Jul 31, 2022, 7:03 AM

#

?paste

undone axleBOT Jul 31, 2022, 7:03 AM

#

https://paste.md-5.net/

carmine nacelle Jul 31, 2022, 7:03 AM

#

Should I just use ParticleLib to spawn my particles isntead of the PlayOutBlahBlah

echo basalt Jul 31, 2022, 7:04 AM

#

Player#spawnParticle

#

Works perfectly finr

#

Thread safe

oblique vigil Jul 31, 2022, 7:04 AM

#

river oracle let me see the other code your talking about

https://paste.md-5.net/bebebuhaxi.bash <- actual event
https://paste.md-5.net/liweheyahi.cs <- getItemsInInventory#

carmine nacelle Jul 31, 2022, 7:04 AM

#

well id want World#spawnParticle but ye

#

fine

echo basalt Jul 31, 2022, 7:04 AM

#

Both worky

river oracle Jul 31, 2022, 7:05 AM

#

oblique vigil https://paste.md-5.net/bebebuhaxi.bash <- actual event https://paste.md-5.net/li...

code looks fine all it'd seem is the items aren't the same i'd reccomend stdouting them and hand checking all the values

echo basalt Jul 31, 2022, 7:05 AM

#

It still calls equals

river oracle Jul 31, 2022, 7:06 AM

#

that too similar is just better lol

#

good catch

echo basalt Jul 31, 2022, 7:06 AM

#

I remember looking at internals

oblique vigil Jul 31, 2022, 7:06 AM

#

yeah i updated it to isSimilar

#

just not in the paste

echo basalt Jul 31, 2022, 7:06 AM

#

And it was like

river oracle Jul 31, 2022, 7:06 AM

#

isSimliar is pretty much just equals without the stack size iirc

#

thats what docs say atleast

echo basalt Jul 31, 2022, 7:07 AM

#

public void equals(ItemStack other) {
    return isSimilar(other) && amount == other.amount;
}

#

Writing code on mobile is tiring

river oracle Jul 31, 2022, 7:07 AM

#

kek

#

I don't even bother typing code whiule I'm on mobile

#

I just try to explain it

echo basalt Jul 31, 2022, 7:08 AM

#

I mean

#

Yeh

oblique vigil Jul 31, 2022, 7:08 AM

#

echo basalt ```java public void equals(ItemStack other) { return isSimilar(other) && amo...

what how would i use that

echo basalt Jul 31, 2022, 7:08 AM

#

Just showing internals

river oracle Jul 31, 2022, 7:09 AM

#

thats the equals method for item stacks

#

isSimilar is good for checking for similar items disregarding the item amount

oblique vigil Jul 31, 2022, 7:09 AM

#

yeah i changed it to isSimilar and it still doesnt work, and i know fs that the items are the same

river oracle Jul 31, 2022, 7:09 AM

#

I don't think they are 😉

oblique vigil Jul 31, 2022, 7:10 AM

#

bro if they arent the same then why does the else statement fire if its legit the same thing just if its only 1

#

they wouldnt stack if they werent the same either

river oracle Jul 31, 2022, 7:10 AM

#

true are they stacking in different slots?

oblique vigil Jul 31, 2022, 7:10 AM

#

nope

river oracle Jul 31, 2022, 7:10 AM

#

send a screenshot of your inventory

#

I'd just add debug statements to my loop and see where its not going through at tbh

#

its hard for me to help you considering all I'm seeing is that the items aren't the same

#

Wuat

#

LMFAO

#

I"M SO STUPID

echo basalt Jul 31, 2022, 7:12 AM

#

It's the only point of failure

river oracle Jul 31, 2022, 7:12 AM

#

BRO

echo basalt Jul 31, 2022, 7:12 AM

#

Unless we tripping

river oracle Jul 31, 2022, 7:12 AM

#

imillusion

#

look at this take a good hard look at whats wrong

#

        int amount = 0;

        for (ItemStack item : player.getInventory().getContents()) {
            if (item != null && item.equals(itemStack)) {
                amount += item.getAmount();
            }
        }
        return itemStack.getAmount();```

echo basalt Jul 31, 2022, 7:12 AM

#

Lol

#

Okay

oblique vigil Jul 31, 2022, 7:12 AM

#

https://prnt.sc/Vx3Tm72qL23N

#

thats my inv

echo basalt Jul 31, 2022, 7:12 AM

#

We're blind

river oracle Jul 31, 2022, 7:12 AM

#

you need to return your amount value lmfao

echo basalt Jul 31, 2022, 7:12 AM

#

Like

river oracle Jul 31, 2022, 7:12 AM

#

xD

oblique vigil Jul 31, 2022, 7:12 AM

#

bruh

#

lmao

echo basalt Jul 31, 2022, 7:12 AM

#

I gotta put my glasses on after that

river oracle Jul 31, 2022, 7:12 AM

#

omg we are both idiots

echo basalt Jul 31, 2022, 7:13 AM

#

Dude it's 8am and I've been doing nms for the past 16 hours

oblique vigil Jul 31, 2022, 7:13 AM

#

lemme see if its fixed now lmao

echo basalt Jul 31, 2022, 7:13 AM

#

I'm not stable enough

oblique vigil Jul 31, 2022, 7:13 AM

#

echo basalt Dude it's 8am and I've been doing nms for the past 16 hours

bet thats fun

river oracle Jul 31, 2022, 7:13 AM

#

lol I've been working with shitty minigame code I'm redoing

#

too bad its proprietary or I would share lol

echo basalt Jul 31, 2022, 7:13 AM

#

Minigame is written in nms

river oracle Jul 31, 2022, 7:13 AM

#

not a lot of NMS

#

thank god the core takes care of it

echo basalt Jul 31, 2022, 7:14 AM

#

I have fake blocks and fake entities and all

oblique vigil Jul 31, 2022, 7:14 AM

#

it works

#

i love you both

river oracle Jul 31, 2022, 7:14 AM

#

lmfao

oblique vigil Jul 31, 2022, 7:14 AM

#

❤️

river oracle Jul 31, 2022, 7:14 AM

#

we are all stupid

echo basalt Jul 31, 2022, 7:14 AM

#

That interact with each other in a game by game basis

#

And collide

oblique vigil Jul 31, 2022, 7:14 AM

#

hey man u clearly know more than me so dont put urself down

river oracle Jul 31, 2022, 7:14 AM

#

echo basalt That interact with each other in a game by game basis

the server I work for has a multi-server linking api where all players interact and can see across different servers

#

very neat

echo basalt Jul 31, 2022, 7:14 AM

#

It comes at the cost of having no friendd

echo basalt Jul 31, 2022, 7:15 AM

#

river oracle the server I work for has a multi-server linking api where all players interact ...

Some mf asked me for a full syncing plugin

river oracle Jul 31, 2022, 7:15 AM

#

I wish I could say I have no friends, but I have too many to say that 😥 I can only say it as a joke

echo basalt Jul 31, 2022, 7:15 AM

#

Asked for 10k, dude hasn't got back to me yet

river oracle Jul 31, 2022, 7:15 AM

#

lol

river oracle Jul 31, 2022, 7:15 AM

#

echo basalt Some mf asked me for a full syncing plugin

I made an entire game-engine from scratch its pretty nice

#

the map system we have is also really cool

echo basalt Jul 31, 2022, 7:16 AM

#

Who needs maps

river oracle Jul 31, 2022, 7:16 AM

#

true not me 😂

echo basalt Jul 31, 2022, 7:16 AM

#

Neither me

river oracle Jul 31, 2022, 7:16 AM

#

when's the last time you played bedwars

echo basalt Jul 31, 2022, 7:16 AM

#

🤡

river oracle Jul 31, 2022, 7:16 AM

#

is this good stats #general message

echo basalt Jul 31, 2022, 7:16 AM

#

river oracle when's the last time you played bedwars

Few years ago

echo basalt Jul 31, 2022, 7:17 AM

#

river oracle is this good stats https://discord.com/channels/690411863766466590/6946615731254...

Okay go take a shower

river oracle Jul 31, 2022, 7:17 AM

#

what

echo basalt Jul 31, 2022, 7:17 AM

#

Sweaty mf

river oracle Jul 31, 2022, 7:17 AM

#

I'm not good lol I suck

#

The people I went against just happened to suck more

echo basalt Jul 31, 2022, 7:18 AM

#

It's a bit wrong of me to call other people sweats honestly

river oracle Jul 31, 2022, 7:18 AM

#

I can only click 5cps :P i can never reach full potential

#

I'm a 5cps legend I used to play HCF and actually did pretty well for clicking so slowly

echo basalt Jul 31, 2022, 7:18 AM

#

I have a disorder that makes me physically sweat 20x more than the usual person

#

So I'm a literal sweat

river oracle Jul 31, 2022, 7:19 AM

#

you sweat

#

Also I can't be a nolife because I play sports and work out

echo basalt Jul 31, 2022, 7:19 AM

#

I work out sometimes

river oracle Jul 31, 2022, 7:19 AM

#

I touch grass and go out with friends too! I'm not a loser

#

right? right? 😭

echo basalt Jul 31, 2022, 7:20 AM

#

You're a plugin dev

#

Not a loser 🤡

river oracle Jul 31, 2022, 7:20 AM

#

I'm not just a plugin dev

#

I code my friends and families programs to make boring stuff easy

#

I think my top accomplishment is this reminder app for my mom who is a specialist at a school she has to send out lots of reminders and I completely automated it 🥲 had to bundle 4 platforms together

echo basalt Jul 31, 2022, 7:22 AM

#

eww this guy does more than minecraft

#

not me

#

I'm a professional plugin maker

#

don't even have a working website

crude charm Jul 31, 2022, 7:23 AM

#

Every time I go about starting a massive project I try to do everything else and end up getting overwhelmed and stopping development. Would planning every small thing in advanced help me pace myself? I could have like 3 tiers of importance and I do them all in order? Starting from easy stuff like storing player data and scoreboard to mines, private mines, robots, custom enchants and so on.

echo basalt Jul 31, 2022, 7:23 AM

#

at least I can say I interned at a school and fixed their printer

river oracle Jul 31, 2022, 7:23 AM

#

echo basalt eww this guy does more than minecraft

I enjoy coding a lot of stuff. My brother was going to have my automate some of his financing but didn't give me any website information to do it with so I just told him to F off

echo basalt Jul 31, 2022, 7:23 AM

#

crude charm Every time I go about starting a massive project I try to do everything else and...

break it down into steps and try to add new core functionality every week

river oracle Jul 31, 2022, 7:24 AM

#

Just make a bunch of small plugins than combine them it always keeps me more on task

echo basalt Jul 31, 2022, 7:24 AM

#

I have a massive project that I've been working on over the past 1-2 months and I'm still doing steady hours because:
1 - it's fun
2 - it's organized
3 - team overlooks development with weekly meetings and I don't want to disappoint

ivory sleet Jul 31, 2022, 7:24 AM

#

crude charm Every time I go about starting a massive project I try to do everything else and...

The single most important principle is to finalize and finish stuff, even though it may not be perfect in your eagle sharp eyes.

echo basalt Jul 31, 2022, 7:25 AM

#

In my case it's a zombies minigame

crude charm Jul 31, 2022, 7:25 AM

#

echo basalt break it down into steps and try to add new core functionality every week

Yeah, my best work is by far the stuff that is a fork of another plugin. I get the base where all the stuff I'd stress over having done already and I can work on the new ideas I get

echo basalt Jul 31, 2022, 7:25 AM

#

So the first thing I made was a game system (initializing and disposing games)

#

then a zombie spawning mechanism

#

then gun mechanics

#

then points, then doors

#

then perks

crude charm Jul 31, 2022, 7:25 AM

#

Yeah

echo basalt Jul 31, 2022, 7:25 AM

#

you break it into small objectives / features and fully implement them

#

You only start another feature once the feature you want is completely implemented

oblique vigil Jul 31, 2022, 7:26 AM

#

river oracle Just make a bunch of small plugins than combine them it always keeps me more on ...

ok mate now ive got another issue 😂 removeItem# was removing all the items of that stack in their inventory before, but now its not 😬

echo basalt Jul 31, 2022, 7:26 AM

#

But make sure that all dependent features are already done before starting work

#

So if I'm making a perk machine, I expect to have a points system make

#

And a perk system so that you use the machine and something actually happens

crude charm Jul 31, 2022, 7:27 AM

#

echo basalt You only start another feature once the feature you want is completely implement...

Yeah this is something I do poorly, I end up having 50 broken features instead of having five working

echo basalt Jul 31, 2022, 7:27 AM

#

After having all the guns done and points

#

then I can make a mystery box

#

type thing

crude charm Jul 31, 2022, 7:28 AM

#

It's also annoying when I have to make methods for getting basic stuff

echo basalt Jul 31, 2022, 7:28 AM

#

But it's more important to have working stuff than just "done" stuff

crude charm Jul 31, 2022, 7:28 AM

#

It's why I usually prefer to work with existing code bases

echo basalt Jul 31, 2022, 7:28 AM

#

basically you need internal planning

#

and to follow an order of operation

#

based on what's relied upon the most

river oracle Jul 31, 2022, 7:28 AM

#

I usually build up my API before i even start a project's main concept

crude charm Jul 31, 2022, 7:28 AM

#

Yeah

compact haven Jul 31, 2022, 7:29 AM

#

well if you build an API then you could literally work on perks before points

#

which is especially nice if 2 things rely on each other

echo basalt Jul 31, 2022, 7:29 AM

#

I never understood the concept of making an external API

#

I usually make an api and call it internally type thing

#

instead of having an api layer and an internals layer, the internals are the api

river oracle Jul 31, 2022, 7:30 AM

#

echo basalt I never understood the concept of making an external API

I like external API's on servers where your plugins are going to be the main thing used otherwise I see little to no point I rather just shade it

crude charm Jul 31, 2022, 7:30 AM

#

would making classes such as "PlayerData" and making 50 comments with methods I need to make, then make all of them.

//get tokens
public void getTokens() {

}
//set tokens
//get player level

echo basalt Jul 31, 2022, 7:30 AM

#

you'd end up with 2k lines

compact haven Jul 31, 2022, 7:30 AM

#

Typically your API is all interface, minus some utility implementations

#

Then your internal is all actual implementation

oblique vigil Jul 31, 2022, 7:30 AM

#

crude charm would making classes such as "PlayerData" and making 50 comments with methods I ...

why would you comment it

#

just make the methods bro

compact haven Jul 31, 2022, 7:30 AM

#

Which works just fine

echo basalt Jul 31, 2022, 7:30 AM

#

raytrace, get hit point, create particle line between

crude charm Jul 31, 2022, 7:30 AM

#

oblique vigil why would you comment it

Comment before making it

river oracle Jul 31, 2022, 7:31 AM

#

always comment before proceeding

crude charm Jul 31, 2022, 7:31 AM

#

To know what I need

river oracle Jul 31, 2022, 7:31 AM

#

My classes are usually marked up a shit ton

oblique vigil Jul 31, 2022, 7:31 AM

#

i mean i comment stuff but not every single thing

#

if im making a getter or setter or whatever i know what it does lmao

river oracle Jul 31, 2022, 7:31 AM

#

I usually leave myself an outline before I implement especially if I need to come back or I forget

oblique vigil Jul 31, 2022, 7:31 AM

#

and id hope anyone else would

compact haven Jul 31, 2022, 7:31 AM

#

Honestly that might be a good idea for me

echo basalt Jul 31, 2022, 7:32 AM

#

echo basalt raytrace, get hit point, create particle line between

if hit point is null, just make a line between start and start.add(start.clone.normalize.multiply(range))

crude charm Jul 31, 2022, 7:32 AM

#

river oracle I usually leave myself an outline before I implement especially if I need to com...

Exactly what I'd do

river oracle Jul 31, 2022, 7:32 AM

#

oblique vigil i mean i comment stuff but not every single thing

with bigger projects it gets insanely tough to deal with even simple stuff as well

oblique vigil Jul 31, 2022, 7:32 AM

#

ig

echo basalt Jul 31, 2022, 7:32 AM

#

river oracle with bigger projects it gets insanely tough to deal with even simple stuff as we...

I tend to build the full backend before even having listeners

river oracle Jul 31, 2022, 7:32 AM

#

you can actually get some Methods called get that have specific return reasons

echo basalt Jul 31, 2022, 7:32 AM

#

I have a full skyblock core that has 6 listeners

river oracle Jul 31, 2022, 7:32 AM

#

like I have getAdapter methods that return specific parts of the spigot API that i've wrapped

#

I like to explain why its there what it does for all other users of the API

oblique vigil Jul 31, 2022, 7:33 AM

#

fair enough

ivory sleet Jul 31, 2022, 7:33 AM

#

oblique vigil just make the methods bro

Yeah, if you can, ideally have the code explain itself

oblique vigil Jul 31, 2022, 7:33 AM

#

yeah getters and setters are self explanatory, i was just curious tbh

ivory sleet Jul 31, 2022, 7:33 AM

#

Comments are far from pure good although necessary sometimes, even if explanatory code could be used

oblique vigil Jul 31, 2022, 7:33 AM

#

still relatively new to coding

river oracle Jul 31, 2022, 7:33 AM

#

ivory sleet Yeah, if you can, ideally have the code explain itself

I feel like when your collaborating even if the code can kind of explain itself I prefer to leave an explanation for others

ivory sleet Jul 31, 2022, 7:33 AM

#

There are tons of issues with comments

echo basalt Jul 31, 2022, 7:33 AM

#

whatever can't be explained through the variable naming, shall be commented

#

getTokens() is self explanatory

oblique vigil Jul 31, 2022, 7:34 AM

#

^

#

my thought process

vocal cloud Jul 31, 2022, 7:34 AM

#

If you have a backend an entity relationship diagram is nice

echo basalt Jul 31, 2022, 7:34 AM

#

incrementRound() can do some underlying operations so it should be documented (cleaning entities, wiping scores type thing)

ivory sleet Jul 31, 2022, 7:34 AM

#

Not only variable naming, but naming of everything

crude charm Jul 31, 2022, 7:34 AM

#

Issues also arise when I need to implement another big feature to work on another. Like player levels to get player level

#

This is tame but it arises that I get massively sidetracked with something unrelated which takes days

echo basalt Jul 31, 2022, 7:35 AM

#

You only start working on a feature if all underlying systems are fully implemented

#

you gotta think about how it'll roll out before actually writing code

#

I'd say I do a 1:10 planning:developing ratio

#

sometimes up to 7:3

river oracle Jul 31, 2022, 7:35 AM

#

I spend a lot of time planning because I can't concentrate for shit

crude charm Jul 31, 2022, 7:36 AM

#

1/10th development or planning?

compact haven Jul 31, 2022, 7:36 AM

#

1:10 and 7:3 are very different dynamics LOL

echo basalt Jul 31, 2022, 7:36 AM

#

I spent 5 hours planning a system that took me about 25 minutes to code

compact haven Jul 31, 2022, 7:36 AM

#

I plan much more than I develop

#

It’s a bad habit

vocal cloud Jul 31, 2022, 7:36 AM

#

Plan twice develop once

echo basalt Jul 31, 2022, 7:36 AM

#

even pulled up the pen & paper

#

the minecraft notebook

#

unrelated question

#

am I the only mf out there collecting minecraft merch?

river oracle Jul 31, 2022, 7:36 AM

#

echo basalt the minecraft notebook

write your development planning in a book and quill

crude charm Jul 31, 2022, 7:36 AM

#

echo basalt even pulled up the pen & paper

I've only ever done that for the endless halls in wow lmfao

echo basalt Jul 31, 2022, 7:36 AM

#

I got mousepads, mugs, books

compact haven Jul 31, 2022, 7:37 AM

#

I create notepad++ files that literally outline how the API should end up

#

or the endpoints of the REST api

#

utterly ridiculous

river oracle Jul 31, 2022, 7:37 AM

#

I just outline it in my head than write it if its super big I'll write it on paper

echo basalt Jul 31, 2022, 7:37 AM

#

visual demos need writing in paper

#

or paint

#

like for zombie spawning

#

I had to make it so it would only spawn zombies in spawn points close to the map region the player was at

#

but that map region also had to be unlocked

#

But doors have to work bidirectionally as the map has 2 paths

vocal cloud Jul 31, 2022, 7:38 AM

#

Write lots of TODOs KEKW

compact haven Jul 31, 2022, 7:38 AM

#

then never complete them

echo basalt Jul 31, 2022, 7:38 AM

#

So I had to design a door system that connects 2 regions

earnest socket Jul 31, 2022, 7:38 AM

#

How can I setup mappings for nms?

echo basalt Jul 31, 2022, 7:38 AM

#

then a whole api to parse doors based on overlapping wg regions

compact haven Jul 31, 2022, 7:38 AM

#

Whenever you have time available for a project, spend it all on planning

vocal cloud Jul 31, 2022, 7:38 AM

#

compact haven then never complete them

Oh worse I've got TODOs I've completed but never removed

earnest socket Jul 31, 2022, 7:39 AM

#

I've tried everything I've found online but my mappings simple do not work

echo basalt Jul 31, 2022, 7:39 AM

#

earnest socket I've tried everything I've found online but my mappings simple do not work

I just use the paperweight plugin

#

it's quite simple

#

on gradle groovy