random js question | Scrimba | Page 1

spare lava Dec 10, 2022, 11:19 AM

#

Hey @unkempt rivet ,
Alright, I don;t fully understand how the game works lol,
But running some console.logs

highScore.innerHTML = `High Score: ${timer}`
                            console.log(highScore.innerHTML)
console.log($timer)

$timer is not defined, and that's creating he problems.
It's probably cause by your redefinition of variables on line 73
highScore = timer
But I'm not able to dig beyond that

Oh and by the way, you should use backticks instead of quotes

unkempt rivet Dec 10, 2022, 11:23 AM

#

I don't see any redefinition on line 47 I am guessing u ment line 73
And u might be right , But if u try add anything in the .textcontent it still doesn't work

#

And about the backticks I fixed it

#

and timer is defined because its not $timer that is the value its timer , $ just lets me be able to use it in the backticks..

#

Thank you anyway!!

spare lava Dec 10, 2022, 11:31 AM

#

I believe that the way you had written it would display "High score: ${timer}" as a string, and not the actual value of timer

#

unrelated, but on line 8 you have
let randomWidth it's not initialized?

unkempt rivet Dec 10, 2022, 11:32 AM

#

spare lava I believe that the way you had written it would display "High score: ${timer}" a...

I fixed that part

unkempt rivet Dec 10, 2022, 11:33 AM

#

Yep , Its for setinterval so I could call it later in a clearinterval so I set a name for it.. there for the randomWidth

spare lava Dec 10, 2022, 11:35 AM

#

that part puzzles me, line 14-15
let highScore = document.getElementById("high-score") highScore = 0

unkempt rivet Dec 10, 2022, 11:35 AM

#

Ye idk if the highScore = 0 was needed but I just set it to 0 because it will later be set to another number

#

I don't think it was needed

spare lava Dec 10, 2022, 11:37 AM

#

basically, it sets the DOM element to 0. I think that's the problem.
You want two constants no?
1 is the DOM element, theother is the highscore number value

#

damn, debugging someone else's code is HARD 😄

unkempt rivet Dec 10, 2022, 11:38 AM

#

spare lava damn, debugging someone else's code is HARD 😄

XDD Its like trying to fix your code after u didn't see it for 2weeks

unkempt rivet Dec 10, 2022, 11:38 AM

#

spare lava basically, it sets the DOM element to 0. I think that's the problem. You want ...

I don't really understand

spare lava Dec 10, 2022, 11:40 AM

#

alright, I created this bit to show you

let highScoreEl = document.getElementById("high-score")
highScore = 0
timer = 350
highscore = timer
highScoreEl.textContent = `Highscore: ${timer}```

#

pasting it at the top, in your constants, so it displays on refresh

#

highScoreEl is the DOM element,
highScore is your value, a number,
I understand that you want to set the timescore to the timer value,
them we display that timer value in the DOM with textContent

#

now it's just a matter of finding where to put that logic in your code, but I need to take a break and have lunch lol

unkempt rivet Dec 10, 2022, 11:42 AM

#

Bassicelly ye

spare lava Dec 10, 2022, 11:42 AM

#

does taht make sense?

unkempt rivet Dec 10, 2022, 11:42 AM

#

Im sure it make sense Just not my sense lol

#

Thanks for the help

#

bon appetit

spare lava Dec 10, 2022, 11:43 AM

#

merci . good luck

unkempt rivet Dec 10, 2022, 11:43 AM

#

ty

unkempt rivet Dec 10, 2022, 1:13 PM

#

Can somebody else help me ?

spare lava Dec 10, 2022, 1:33 PM

#

hey I'm back. Have you figured it out? I have

#

#

That snippet I gave you earlier? put the appropriate lines in your function line 74 and it'll work

unkempt rivet Dec 10, 2022, 2:38 PM

#

O fuc*

#

I didn't see u answered mb

#

Which one are u talking about? @spare lava

spare lava Dec 10, 2022, 2:42 PM

#

let highScoreEl = document.getElementById("high-score")
highScore = 0
timer = 350
highscore = timer
highScoreEl.textContent = `Highscore: ${timer}

unkempt rivet Dec 10, 2022, 2:43 PM

#

Put all of that in 74?

spare lava Dec 10, 2022, 2:47 PM

#

https://scrimba.com/scrim/co5f54e67915714854c0288a9

#

I put some comments for you to check what was changed

unkempt rivet Dec 10, 2022, 2:49 PM

#

is this what u mean?

#

Because it doesn't seem to work for me

spare lava Dec 10, 2022, 2:52 PM

#

don't forget to change the name of your getElelentbyID constants

unkempt rivet Dec 10, 2022, 2:52 PM

#

I added the highscore = timer

unkempt rivet Dec 10, 2022, 2:52 PM

#

spare lava don't forget to change the name of your getElelentbyID constants

Already did

#

I am not sure what is the difference

spare lava Dec 10, 2022, 2:54 PM

#

check my scrim; it works

unkempt rivet Dec 10, 2022, 2:54 PM

#

Ye ik

#

Here lemme send u an updated version of mine

#

https://scrimba.com/scrim/cKPq6nU3

Scrimba

Untitled Scrim

Learn to code with interactive screencasts. Our courses and tutorials will teach you React, Vue, Angular, JavaScript, HTML, CSS, and more. Scrimba is the fun and easy way to learn web development.

#

ignore the hugeeeeeee link

#

@spare lava

#

I found what was cauesing the issue

#

is there a difference between this:
highScore.textContent = Highscore: ${timer}

and this:

        highScore.textContent = `Highscore: ${timer}`

#

with backticks ofc

#

it just does the thingy

#

NOO

#

IDK WHAT I DID

#

BUT IT FIXED It

#

AND UNFIXED IT

#

BUT IT DOESN"T WORK NOW

#

IDK HOW TO FIX IT

#

NOO

#

deprrestion

spare lava Dec 10, 2022, 3:12 PM

#

Take a break then. Working frustrated doesn’t do any good. You’ll come back to it later and it’ll be alright

unkempt rivet Dec 10, 2022, 5:09 PM

#

Ye I figured it out

#

Thank you for ur help Geoffrey

#random js question