ChangingRoleAndSpawned Patch is broken (NRE) | EXILED | Page 1

prime phoenix Oct 25, 2024, 3:45 PM

#

Exiled Version: 8.13.1

Every time a player is spawned (including dedicated host), an NRE occurs; On a dedicated host spawn:

[2024-10-25 17:05:22.017 +02:00] [STDOUT] NullReferenceException: Object reference not set to an instance of an object
[2024-10-25 17:05:22.017 +02:00] [STDOUT]   at (wrapper dynamic-method) PlayerRoles.PlayerRoleManager.PlayerRoles.PlayerRoleManager.InitializeNewRole_Patch0(PlayerRoles.PlayerRoleManager,PlayerRoles.RoleTypeId,PlayerRoles.RoleChangeReason,PlayerRoles.RoleSpawnFlags,Mirror.NetworkReader)
[2024-10-25 17:05:22.018 +02:00] [STDOUT]   at PlayerRoles.PlayerRoleManager.get_CurrentRole () [0x00008] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-25 17:05:22.018 +02:00] [STDOUT]   at PlayerRoles.PlayerRolesUtils.GetTeam (ReferenceHub hub) [0x00000] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-25 17:05:22.018 +02:00] [STDOUT]   at RoundSummary+<>c.<Start>b__40_0 (ReferenceHub hub) [0x00000] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-25 17:05:22.018 +02:00] [STDOUT]   at Utils.NonAllocLINQ.HashsetExtensions.Count[T] (System.Collections.Generic.HashSet`1[T] target, System.Func`2[T,TResult] condition) [0x00013] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-25 17:05:22.018 +02:00] [STDOUT]   at RoundSummary.Start () [0x00064] in <0594d213d02e488398c476c559e1ee8e>:0

On a player spawn:

[2024-10-25 17:05:32.812 +02:00] [STDOUT] NullReferenceException: Object reference not set to an instance of an object
[2024-10-25 17:05:32.812 +02:00] [STDOUT]   at (wrapper dynamic-method) PlayerRoles.PlayerRoleManager.PlayerRoles.PlayerRoleManager.InitializeNewRole_Patch0(PlayerRoles.PlayerRoleManager,PlayerRoles.RoleTypeId,PlayerRoles.RoleChangeReason,PlayerRoles.RoleSpawnFlags,Mirror.NetworkReader)
[2024-10-25 17:05:32.813 +02:00] [STDOUT]   at PlayerRoles.PlayerRoleManager.get_CurrentRole () [0x00008] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-25 17:05:32.813 +02:00] [STDOUT]   at PlayerRoles.RoleSyncInfoPack.WritePlayers (Mirror.NetworkWriter writer) [0x00026] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-25 17:05:32.813 +02:00] [STDOUT]   at PlayerRoles.PlayerRolesNetUtils.WriteRoleSyncInfoPack (Mirror.NetworkWriter writer, PlayerRoles.RoleSyncInfoPack info) [0x00000] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-25 17:05:32.813 +02:00] [STDOUT]   at (wrapper delegate-invoke) System.Action`2[Mirror.NetworkWriter,PlayerRoles.RoleSyncInfoPack].invoke_void_T1_T2(Mirror.NetworkWriter,PlayerRoles.RoleSyncInfoPack)
[2024-10-25 17:05:32.813 +02:00] [STDOUT]   at Mirror.NetworkWriter.Write[T] (T value) [0x00023] in <30fac3f6504c4ec7842b66bf8ea075a1>:0
[2024-10-25 17:05:32.813 +02:00] [STDOUT]   at Mirror.NetworkConnection.Send[T] (T message, System.Int32 channelId) [0x00006] in <30fac3f6504c4ec7842b66bf8ea075a1>:0
[2024-10-25 17:05:32.813 +02:00] [STDOUT]   at PlayerRoles.PlayerRolesNetUtils.HandleSpawnedPlayer (ReferenceHub hub) [0x0001b] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-25 17:05:32.813 +02:00] [STDOUT]   at (wrapper delegate-invoke) System.Action`1[ReferenceHub].invoke_void_T(ReferenceHub)
[2024-10-25 17:05:32.813 +02:00] [STDOUT]   at (wrapper dynamic-method) ReferenceHub.ReferenceHub.Start_Patch1(ReferenceHub)

📎 LocalAdmin_Log_2024-10-25_17.05.15.txt

sterile hazel Oct 25, 2024, 3:53 PM

#

кто замержил пидор

hollow niche Oct 25, 2024, 4:35 PM

#

Idk if it's the same issue

#

[2024-10-26 00:31:05.409 +08:00] [STDOUT]   at (wrapper dynamic-method) PlayerRoles.PlayerRoleManager.PlayerRoles.PlayerRoleManager.InitializeNewRole_Patch0(PlayerRoles.PlayerRoleManager,PlayerRoles.RoleTypeId,PlayerRoles.RoleChangeReason,PlayerRoles.RoleSpawnFlags,Mirror.NetworkReader)
[2024-10-26 00:31:05.409 +08:00] [STDOUT]   at PlayerRoles.PlayerRoleManager.get_CurrentRole () [0x00008] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-26 00:31:05.409 +08:00] [STDOUT]   at PlayerRoles.RoleSyncInfoPack.WritePlayers (Mirror.NetworkWriter writer) [0x00026] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-26 00:31:05.409 +08:00] [STDOUT]   at PlayerRoles.PlayerRolesNetUtils.WriteRoleSyncInfoPack (Mirror.NetworkWriter writer, PlayerRoles.RoleSyncInfoPack info) [0x00000] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-26 00:31:05.409 +08:00] [STDOUT]   at (wrapper delegate-invoke) System.Action`2[Mirror.NetworkWriter,PlayerRoles.RoleSyncInfoPack].invoke_void_T1_T2(Mirror.NetworkWriter,PlayerRoles.RoleSyncInfoPack)
[2024-10-26 00:31:05.410 +08:00] [STDOUT]   at Mirror.NetworkWriter.Write[T] (T value) [0x00023] in <30fac3f6504c4ec7842b66bf8ea075a1>:0
[2024-10-26 00:31:05.410 +08:00] [STDOUT]   at Mirror.NetworkConnection.Send[T] (T message, System.Int32 channelId) [0x00006] in <30fac3f6504c4ec7842b66bf8ea075a1>:0
[2024-10-26 00:31:05.410 +08:00] [STDOUT]   at PlayerRoles.PlayerRolesNetUtils.HandleSpawnedPlayer (ReferenceHub hub) [0x0001b] in <0594d213d02e488398c476c559e1ee8e>:0
[2024-10-26 00:31:05.411 +08:00] [STDOUT]   at (wrapper delegate-invoke) System.Action`1[ReferenceHub].invoke_void_T(ReferenceHub)
[2024-10-26 00:31:05.411 +08:00] [STDOUT]   at (wrapper dynamic-method) ReferenceHub.ReferenceHub.Start_Patch1(ReferenceHub)```

#

I checked some patch code and found a commit

#

https://github.com/ExMod-Team/EXILED/commit/101eb8b656c16edaaff6cfa892802a43c3a52f87

GitHub

spawn fix (#148) · ExMod-Team/EXILED@101eb8b

#

The problem may be related to
LocalHub i guess

void solar Oct 25, 2024, 4:55 PM

#

@charred gorge

charred gorge Oct 25, 2024, 4:56 PM

#

Hm. Strange. How this can be related to this. Ok. Gonna test it now, gimme a sec

void solar Oct 25, 2024, 5:01 PM

#

There is a PR claiming to fix it https://github.com/ExMod-Team/EXILED/pull/153

GitHub

spawn fix by 1312255201 · Pull Request #153 · ExMod-Team/EXILED

Description
Describe the changes
Added some null judgments before the code of merge #148
What is the current behavior? (You can also link to an open issue here)
Throwing an error message when the ...

hollow niche Oct 25, 2024, 5:14 PM

#

kek

#

= rollback to last version code

#

but works

charred gorge Oct 25, 2024, 5:22 PM

#

But forces to fire event for LocalHub

#

Which causes some other issues

#

While this NRE seems to have a little effect on gameplay and plugin's work

prime phoenix Oct 25, 2024, 5:25 PM

#

I don't like NRE messages in my logs.

bitter ruin Oct 25, 2024, 5:26 PM

#

This null reference exception on my server caused an issue where players entering the server could not see other players and continued to experience this visibility issue. However, normal players could still see and even attack the players with the visibility problem

#

🥹

#

From the perspective of the affected player, it looks like they're just walking around and then suddenly get killed by invisible players.

void solar Oct 25, 2024, 5:28 PM

#

@charred gorge so you looked into it and found no solution? I am on a trip now so can’t check the codes.

charred gorge Oct 25, 2024, 5:28 PM

#

Yeah

#

@bitter ruin @prime phoenix any of you available to test a build?

📎 Exiled.Events.dll

prime phoenix Oct 25, 2024, 5:29 PM

#

sure

bitter ruin Oct 25, 2024, 5:29 PM

#

sure

charred gorge Oct 25, 2024, 5:30 PM

#

I need to check if event calls on LocalHub and if there any errors while firing

bitter ruin Oct 25, 2024, 5:33 PM

#

I registered the SpawnedEvent in the plugin, and it wasn't triggered once at server startup. Currently, I also haven’t seen any of the previous NullReferenceException errors.

#

It seems to be working fine.😋

prime phoenix Oct 25, 2024, 5:33 PM

#

yup

#

debug logs in case they are needed

charred gorge Oct 25, 2024, 5:35 PM

#

Good. Thx for help

hollow niche Oct 25, 2024, 5:40 PM

#

👍

prime phoenix Oct 25, 2024, 5:50 PM

#

charred gorge Good. Thx for help

btw another NRE, idk if this is related to this exact bug, but yeah...

📎 LocalAdmin_Log_2024-10-25_19.38.00.txt

hollow niche Oct 25, 2024, 5:56 PM

#

🤔

bitter ruin Oct 25, 2024, 5:57 PM

#

same

charred gorge Oct 25, 2024, 6:00 PM

#

I’ll try to investigate but iirc this is quite old issue

keen laurel Oct 27, 2024, 6:54 PM

#

charred gorge <@419466286574206976> <@365499281215586326> any of you available to test a build...

Yes, it helped.

prime phoenix Oct 27, 2024, 6:55 PM

#

prime phoenix **Exiled Version**: 8.13.1 Every time a player is spawned (including dedicated ...

#1300156891250561034 message

cinder prism Oct 29, 2024, 4:34 PM

#

charred gorge <@419466286574206976> <@365499281215586326> any of you available to test a build...

what the PR for it ?

prime phoenix Oct 29, 2024, 4:34 PM

#

none TrollFace

charred gorge Oct 29, 2024, 4:35 PM

#

cinder prism what the PR for it ?

Spawned fix

#

Don’t remember id and can’t look for it rn

cinder prism Oct 29, 2024, 4:35 PM

#

ok

prime phoenix Oct 29, 2024, 4:37 PM

#

cinder prism what the PR for it ?

https://github.com/ExMod-Team/EXILED/pull/156/commits/972cbb83eb1d7a55b247154940af014c802f2b78 i guess

GitHub

Fixing `Spawned` event on dev by VALERA771 · Pull Request #156 · Ex...

Description
Describe the changes
Fixing spawned event
What is the current behavior? (You can also link to an open issue here)
NRE
What is the new behavior? (if this is a feature change)
No nRE
Does...

#

https://github.com/ExMod-Team/EXILED/pull/154 and/or this?? (tf)

GitHub

Fix `Spawned` event + no more breaking changes by VALERA771 · Pull ...

Description
Describe the changes
Fixing event by simplifying check for local hub
Moved Metal EffectType to last pos cuz possible breaking change
What is the current behavior? (You can also link to ...

#

oh

prime phoenix Oct 29, 2024, 4:39 PM

#

prime phoenix https://github.com/ExMod-Team/EXILED/pull/156/commits/972cbb83eb1d7a55b247154940...

it's for dev

prime phoenix Oct 29, 2024, 4:39 PM

#

prime phoenix https://github.com/ExMod-Team/EXILED/pull/154 and/or this?? (tf)

it's for halloween

prime phoenix Nov 5, 2024, 10:49 PM

#