#how to submit a pull request to the website documentation?
13 messages · Page 1 of 1 (latest)
The website's source is here https://github.com/tauri-apps/tauri-docs.
The prereq change is here https://github.com/tauri-apps/tauri-docs/blob/dev/docs/guides/getting-started/prerequisites.md
If it's a simple change you may use github's web interface to change it (clikc on the edit pen on the top right), if not you gotta fork the repo like usual
its simple so i will use the pencil
https://github.com/tauri-apps/tauri-docs/pull/1318 submitted a PR @opaque plinth
first of all, big thanks for the pr. Looking at the preview though we definitly can't merge it. I also don't think the general flow of it really fits into and it also deletes important information.
Would it be alright if i interpret your PR as feedback instead of a contribution instead? I wanted to update the section anyway since rustup can now install the build tools so if i do that, i'd take your suggestion into account and see if i can find something that covers a more step-by-step approach too. I'd also request your feedback on that new PR then :)
The reason you can't merge it is because it is too much steps? Or because the images didn't load correctly?
What is the important information I deleted?
Yes please use it as a feedback for absolute beginners in rust I has to figure out a lot of steps by myself
You are creator of tauri ?
Right, i should have explained our decision a bit more, sorry about that!
So the single biggest reason is that we wanted to rewrite that section anyway, mainly because rustup can now automatically install visual studio which we wanted to address.
On top of that were a few minor things which all could have been fixed but with the pending rewrite it wouldn't have made much sense to spend that amount of time in fixing it up. Here's a list of things that comes to mind rn:
- images not loading / external images being used, alll images must be in the repo
- too many images, not only will it get a bit hard to read (for the lack of a better word) but it is also way less accessible for visually impaired people.
- Edit (added after i sent the message): I also think this is now too granular and too much hand-holding i guess, we have to make compromises and be careful of not overdoing it.
- Using headers for the list just doesn't work (also note the sidebar especially):
Most importantly the warning about the MSVC toolchain at the bottom. But also the note aobut webview2 existing on some systems and the winget instructions.