Monitor X and Y are incorrect | Tauri Apps | Page 1

rugged sonnet Apr 23, 2023, 2:15 PM

#

The positions of the X and Y from the Monitor Object are incorrect OR the WebviewWindow is summoned in the incorrect place!

Here is the code that opens the webviewwindow:

async open(monitor: Monitor, version: string, id: number|string|null =null) {
  if (id == null) id = monitor.name;
  console.log(monitor)
  let webviewwindow = new WebviewWindow(`presentation${id}${version}`, {url: this.url, fullscreen: true, resizable: false, title: 'presention'+version, x: monitor.position.x, y: monitor.position.y});
}

console.log(monitor) output (Aka. Monitor info):

{ "name": "\\\\.\\DISPLAY1", "scaleFactor": 1.5, "position": { "type": "Physical", "x": 0, "y": 0 }, "size": { "type": "Physical", "width": 1920, "height": 1080 } }
{ "name": "\\\\.\\DISPLAY216", "scaleFactor": 1, "position": { "type": "Physical", "x": 1920, "y": 0 }, "size": { "type": "Physical", "width": 1920, "height": 1080 } }
{ "name": "\\\\.\\DISPLAY217", "scaleFactor": 1, "position": { "type": "Physical", "x": 0, "y": 1080 }, "size": { "type": "Physical", "width": 1920, "height": 1080 } }

P.s. this has tag Windows since thats what I tested, I don't have linux or macos at all or with multiple (virtual) screens.

rugged sonnet Apr 23, 2023, 2:40 PM

#

Adding in the center: true to the WebviewWindows options seems to have fixed it, but I am not yet 100% sure

UPDATE: That doesn't really fix it

rugged sonnet Apr 23, 2023, 3:20 PM

#

It just doesn't work

rugged sonnet Apr 23, 2023, 4:25 PM

#

Oke when using this code:

webviewwindow.once('tauri://created', async function () {
  console.log(await webviewwindow.innerPosition())
  // ...
});

The console.log outputs these values in order of the screens:

{ "type": "Physical", "x": 0, "y": 0 }
{ "type": "Physical", "x": 2880, "y": 0 }
{ "type": "Physical", "x": 5760, "y": 0 }
{ "type": "Physical", "x": 8640, "y": 0 }

2880/1920=1.5
5760/1920=3
8640/1920=4.5

So with this info, I think it uses the scale factor (for screen 1 it is 1.5, the rest is 1) that I use because my screen is too small for 100% zoom.

Yeah, I guess it just uses the scale factor, whilst that is not needed. But I am unable to find the script which does it

Oh wait it might be the PhysicalPosition.toLogical()

I just temporarly fixed it by dividing the x and y of the monitor.position by the appWindow.scaleFactor()

stable lichen Apr 24, 2023, 7:21 AM

#

So tbh i had trouble following, but if you think there is a bug in tauri/wry/tao, feel free to create an issue (at the tauri repo) with an explanation and preferably a reproduction example so that the team can take a look :)

rugged sonnet Apr 24, 2023, 1:54 PM

#

Btw I am just updating the packages to make sure that it isn't a bug that might have already been fixed, but I just still use old code.

Update:

Uncaught (in promise) path not allowed on the configured scope: \\?\C:\YH4F\SongTextProjector\src-tauri\target\debug\_up_\songs
And the bug is still here

rugged sonnet Apr 24, 2023, 1:57 PM

#

stable lichen So tbh i had trouble following, but if you think there is a bug in tauri/wry/tao...

https://github.com/tauri-apps/tauri/issues/6784

GitHub

[bug] WebviewWindow X and Y are modified, whilst they shouldn't! · ...

Describe the bug Here is the 3 screen layout: [1] [2] [3] And here the result: Here is the 4 screen layout: [1] [2] [3] [4] And here the result: See the code in the reproduction: The output of the ...

stable lichen Apr 24, 2023, 1:58 PM

#

thanks

#

what's your scope config?

rugged sonnet Apr 24, 2023, 2:02 PM

#

"scope": ["$RESOURCE/*"]

stable lichen Apr 24, 2023, 2:02 PM

#

try ["$RESOURCE/**"]

stable lichen Apr 24, 2023, 2:03 PM

#

stable lichen try `["$RESOURCE/**"]`

* only matches the current level without recursion now

rugged sonnet Apr 30, 2023, 12:24 PM

#

How can I use https://github.com/tauri-apps/tauri/pull/5381

GitHub

feat: allow setting window size and position using physical units ...

Close #5228

What kind of change does this PR introduce?

Bugfix
Feature
Docs
New Binding issue #___
Code style update
Refactor
Build-related changes
Other, please describe:

Does this PR ...

stable lichen Apr 30, 2023, 2:24 PM

#

Basically this: https://tauri.app/v1/guides/faq#how-can-i-use-unpublished-tauri-changes but using their branch.

rugged sonnet May 5, 2023, 1:44 PM

#

stable lichen Basically this: <https://tauri.app/v1/guides/faq#how-can-i-use-unpublished-tauri...

but their branch is 286 commits behind tauri-apps:dev.

stable lichen May 5, 2023, 1:45 PM

#

if it doesn't work with [patch] you can replace the actual dependencies in the [dependencies] block

rugged sonnet May 5, 2023, 1:45 PM

#

ohhhh

#

Btw do I need to do all of the methods? or just the patch

stable lichen May 5, 2023, 1:47 PM

#

depends on what you need

#

tauri and tauri-build is a must have

rugged sonnet May 5, 2023, 1:47 PM

#

So with just the patch it should work?

stable lichen May 5, 2023, 1:47 PM

#

stable lichen tauri and tauri-build is a must have

the upstream cli should still work

#

and if you want to do something in js you'll also need the api.js package

stable lichen May 5, 2023, 1:48 PM

#

rugged sonnet So with just the patch it should work?

cargo will tell you if it works

#

if it doesn't it will print an error or at least a warning saying that it ignored the patch

rugged sonnet May 5, 2023, 1:49 PM

#

..
warning: Patch `tauri v1.1.1 (https://github.com/ysinsane/tauri?branch=dev#afbf9d53)` was not used in the crate graph.
Patch `tauri-build v1.1.1 (https://github.com/ysinsane/tauri?branch=dev#afbf9d53)` was not used in the crate graph.
Check that the patched package version and available features are compatible
with the dependency requirements. If the patch has a different version from
what is locked in the Cargo.lock file, run `cargo update` to use the new
version. This may also occur with an optional dependency that is not enabled.

#

But it does start

stable lichen May 5, 2023, 1:49 PM

#

yeah that's the warning i meant. it means it didn't apply it and you're still using upstream tauri and not the fork

#

which means you'll have to move it to the dependency section instead

rugged sonnet May 5, 2023, 1:53 PM

#

it says run cargo update to use the new version

#

But you just say I have to move it from patch to dependency???

stable lichen May 5, 2023, 1:53 PM

#

well, you can try cargo update first and see if that indeed works, but usually it doesn't

#

or i guess that depends on your current rust dependencies mainly

rugged sonnet May 5, 2023, 1:54 PM

#

ok

#

Hmm it didn't give error...

#

But it also does no longer open my webviewwindow

#

Strange, cause it doesn't give any message about it failing

rugged sonnet May 5, 2023, 2:24 PM

#

stable lichen or i guess that depends on your current rust dependencies mainly

Now that I tried adding it in the depencencies:

Updating git repository `https://github.com/tauri-apps/wry`
error: failed to select a version for `webkit2gtk-sys`.
    ... required by package `wry v0.28.3 (https://github.com/tauri-apps/wry?branch=dev#4d37135d)`
    ... which satisfies git dependency `wry` of package `tauri-runtime-wry v0.11.1 (https://github.com/ysinsane/tauri?branch=dev#afbf9d53)`
    ... which satisfies git dependency `tauri-runtime-wry` of package `tauri v1.1.1 (https://github.com/ysinsane/tauri?branch=dev#afbf9d53)`
    ... which satisfies git dependency `tauri` of package `app v0.1.0 (C:\YH4F\STP\src-tauri)`
versions that meet the requirements `^0.19.1` are: 0.19.1

the package `webkit2gtk-sys` links to the native library `web_kit2`, but it conflicts with a previous package which links to `web_kit2` as well:
package `webkit2gtk-sys v0.18.0`
    ... which satisfies dependency `ffi = "^0.18"` (locked to 0.18.0) of package `webkit2gtk v0.18.2`
    ... which satisfies dependency `webkit2gtk = "^0.18.2"` (locked to 0.18.2) of package `tauri v1.1.1 (https://github.com/ysinsane/tauri?branch=dev#afbf9d53)`
    ... which satisfies git dependency `tauri` of package `app v0.1.0 (C:\YH4F\STP\src-tauri)`
Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the links ='webkit2gtk-sys' value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

failed to select a version for `webkit2gtk-sys` which could resolve this conflict

stable lichen May 5, 2023, 3:00 PM

#

can you share the dependency list you got in cargo.toml now?

rugged sonnet May 7, 2023, 4:05 PM

#

stable lichen can you share the dependency list you got in cargo.toml now?

[package]
name = "app"
version = "0.1.0"
description = "A Tauri App"
authors = ["Miniontoby"]
license = ""
repository = ""
default-run = "app"
edition = "2021"
rust-version = "1.57"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[build-dependencies]
#tauri-build = { version = "1.2.1", features = [] }
tauri-build = { git = "https://github.com/ysinsane/tauri", branch = "dev" }
# 1.1.1

[dependencies]
serde_json = "1.0"
serde = { version = "1.0", features = ["derive"] }
#tauri = { version = "1.2.1", features = ["dialog-all", "fs-copy-file", "fs-exists", "fs-read-dir", "fs-read-file", "fs-remove-file", "fs-write-file", "path-all", "window-all"] }
tauri-plugin-fs-watch = { git = "https://github.com/tauri-apps/plugins-workspace", branch = "dev" }
include_dir = "0.7.3"
tauri = { git = "https://github.com/ysinsane/tauri", branch = "dev", features = ["dialog-all", "fs-copy-file", "fs-exists", "fs-read-dir", "fs-read-file", "fs-remove-file", "fs-write-file", "path-all", "window-all"] }

[features]
# by default Tauri runs in production mode
# when `tauri dev` runs it is executed with `cargo run --no-default-features` if `devPath` is an URL
default = [ "custom-protocol" ]
# this feature is used for production builds where `devPath` points to the filesystem
# DO NOT remove this
custom-protocol = [ "tauri/custom-protocol" ]


#[patch.crates-io]
#tauri = { git = "https://github.com/ysinsane/tauri", branch = "dev" }
#tauri-build = { git = "https://github.com/ysinsane/tauri", branch = "dev" }

rugged sonnet May 7, 2023, 4:46 PM

#

rugged sonnet How can I use https://github.com/tauri-apps/tauri/pull/5381

Btw they mention about version 2, so when will this be intergrated into the alpha build? That would save me a lot of problems...

stable lichen May 7, 2023, 5:24 PM

#

rugged sonnet ```toml [package] name = "app" version = "0.1.0" description = "A Tauri App" aut...

can you try adding back the patch section at the bottom? i'm hoping it will overwrite tauri used in the plugin

stable lichen May 7, 2023, 5:24 PM

#

rugged sonnet Btw they mention about version 2, so when will this be intergrated into the alph...

no idea

rugged sonnet May 7, 2023, 5:29 PM

#

stable lichen can you try adding back the patch section at the bottom? i'm hoping it will over...

Uhmm, what?

stable lichen May 7, 2023, 5:34 PM

#

typo

#

just uncomment the last three lines

rugged sonnet May 8, 2023, 9:28 AM

#

And what about the lines in the depencies section?

#

Cause I also have the 'patch'ed version in there

stable lichen May 8, 2023, 9:29 AM

#

yeah, but that's what you want so the dep section is fine

rugged sonnet May 8, 2023, 9:29 AM

#

so not the default tauri one there?

stable lichen May 8, 2023, 9:29 AM

#

no

rugged sonnet May 8, 2023, 9:29 AM

#

Oke

#

I will test

#

    Updating crates.io index
    Updating git repository `https://github.com/tauri-apps/wry`
error: failed to select a version for `webkit2gtk-sys`.
    ... required by package `wry v0.28.3 (https://github.com/tauri-apps/wry?branch=dev#c26a1879)`
    ... which satisfies git dependency `wry` of package `tauri-runtime-wry v0.11.1 (https://github.com/ysinsane/tauri?branch=dev#afbf9d53)`
    ... which satisfies git dependency `tauri-runtime-wry` of package `tauri v1.1.1 (https://github.com/ysinsane/tauri?branch=dev#afbf9d53)`
    ... which satisfies git dependency `tauri` of package `app v0.1.0 (C:\YH4F\SongTextProjector\src-tauri)`
versions that meet the requirements `^0.19.1` are: 0.19.1

the package `webkit2gtk-sys` links to the native library `web_kit2`, but it conflicts with a previous package which links to `web_kit2` as well:
package `webkit2gtk-sys v0.18.0`
    ... which satisfies dependency `ffi = "^0.18"` (locked to 0.18.0) of package `webkit2gtk v0.18.2`
    ... which satisfies dependency `webkit2gtk = "^0.18.2"` (locked to 0.18.2) of package `tauri v1.1.1 (https://github.com/ysinsane/tauri?branch=dev#afbf9d53)`
    ... which satisfies git dependency `tauri` of package `app v0.1.0 (C:\YH4F\SongTextProjector\src-tauri)`
Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the links ='webkit2gtk-sys' value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

failed to select a version for `webkit2gtk-sys` which could resolve this conflict

stable lichen May 8, 2023, 9:40 AM

#

try adding this: ```toml
[patch.'https://github.com/tauri-apps/wry']
wry = "=0.21.1"

rugged sonnet May 8, 2023, 9:53 AM

#

stable lichen try adding this: ```toml [patch.'https://github.com/tauri-apps/wry'] wry = "=0.2...

https://pastebin.com/63cEdi5L

p.s. discords limit required me to use pastebin

Pastebin

Compiling tauri-macros v1.1.1 (https://github.com/ysinsane/tauri...

Pastebin.com is the number one paste tool since 2002. Pastebin is a website where you can store text online for a set period of time.

stable lichen May 8, 2023, 10:01 AM

#

What about this then ```toml
[patch.'https://github.com/tauri-apps/wry']
wry = "=0.22.0"

rugged sonnet May 8, 2023, 10:10 AM

#

error[E0277]: the trait bound `tauri::plugin::TauriPlugin<_>: Plugin<tauri_runtime_wry::Wry<EventLoopMessage>>` is not satisfied
    --> src\main.rs:29:13
     |
29   |     .plugin(tauri_plugin_fs_watch::init())
     |      ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Plugin<tauri_runtime_wry::Wry<EventLoopMessage>>` is not implemented for `tauri::plugin::TauriPlugin<_>`
     |      |
     |      required by a bound introduced by this call
     |
     = help: the trait `Plugin<R>` is implemented for `TauriPlugin<R, C>`
note: required by a bound in `tauri::Builder::<R>::plugin`
    --> C:\Users\Miniontoby\.cargo\git\checkouts\tauri-845b2c232843dbd4\afbf9d5\core\tauri\src\app.rs:1156:20
     |
1156 |   pub fn plugin<P: Plugin<R> + 'static>(mut self, plugin: P) -> Self {
     |                    ^^^^^^^^^ required by this bound in `tauri::Builder::<R>::plugin`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `app` due to previous error

#

Hmmm, now the plugin doesnt work

stable lichen May 8, 2023, 10:12 AM

#

Can you run cargo update again? It seems to work fine for me

#

just to be sure, that's the toml i tested ```toml
[build-dependencies]
tauri-build = { git = "https://github.com/ysinsane/tauri", branch = "dev", features = [] }

[dependencies]
serde_json = "1.0"
serde = { version = "1.0", features = ["derive"] }
tauri-plugin-fs-watch = { git = "https://github.com/tauri-apps/plugins-workspace", branch = "dev" }
include_dir = "0.7.3"
tauri = { git = "https://github.com/ysinsane/tauri", branch = "dev", features = [] }

[features]
custom-protocol = [ "tauri/custom-protocol" ]

[patch.crates-io]
tauri = { git = "https://github.com/ysinsane/tauri", branch = "dev" }
tauri-build = { git = "https://github.com/ysinsane/tauri", branch = "dev" }

[patch.'https://github.com/tauri-apps/wry']
wry = "=0.22.0"

rugged sonnet May 8, 2023, 10:19 AM

#

Oke, now with cargo update it does build

#

Hmm I think it works... at least the webviewwindow shows up

stable lichen May 8, 2023, 10:29 AM

#

I hope it keeps working because i'm completely out of ideas

rugged sonnet May 8, 2023, 10:32 AM

#

I will have to make screenshot to see if it works (and to see if I implemented it correctly, since there is no documentation about how to use the new changes)

#

Hmm does seem good...

Will notify you after I did a bigger test with actual screens and such, but that I can only test later today...

rugged sonnet May 9, 2023, 4:47 PM

#

Hmm nope, its not fixed...

But maybe I dont use it correctly

rugged sonnet May 14, 2023, 12:24 PM

#

Hmm, I would really like this to work

#

new / old = factor

1920/1680 = 1.14285714286
1080/1050 = 1.02857142857

Hmm this doesn't make any sense

rugged sonnet May 18, 2023, 8:20 AM

#

Can anyone maybe help think at https://github.com/tauri-apps/tauri/pull/5381#issuecomment-1540542740 Cause yeah I really need this to work

rugged sonnet Sep 18, 2023, 2:47 PM

#

When will 5381 be added to v2?

GitHub

feat: allow setting window size and position using physical units ...

Close #5228

What kind of change does this PR introduce?

Bugfix
Feature
Docs
New Binding issue #___
Code style update
Refactor
Build-related changes
Other, please describe:

Does this PR ...

#Monitor X and Y are incorrect

new / old = factor

1920/1680 = 1.14285714286 1080/1050 = 1.02857142857

1920/1680 = 1.14285714286
1080/1050 = 1.02857142857