[v2 alpha] Fails to check for update

[stark panther]

I have this config for our updater:

      "active": true,
      "pubkey": "xxx",
      "dialog": false,
      "endpoints": [
        "https://sun.noor.to/api/check-for-update"
      ]
    },

But this has stopped working. What can be the reason since the JSON looks fine

[sacred whale]

hmm, i think that can only happen if the http request doesn't get a 2XX response 🤔

can you try debugging the updater events like this f.e. <#1067927006509023392 message>

and if you don't maybe add a log facility like pretty_env_logger with RUST_LOG=debug to check the http clients logs too

[stark panther]

we do have the logger setup, let me check

[stark panther]

I get these logs:
[2023-02-14][11:34:07][attohttpc][DEBUG] trying to connect to sun.noor.to:443
[2023-02-14][11:34:07][attohttpc][DEBUG] DNS returned only one address, using fast path

[stark panther]

Error is from this line:
https://github.com/tauri-apps/tauri/blob/50576a5e1e83978882d90aca280809da2235a8d5/core/tauri/src/updater/core.rs#L421

[sacred whale]

yep, which is why i said that it can only really happen if it gets a non 2xx response

errors in 2xx responses would be thrown in the if above that

[stark panther]

it can also be the JSON wasn't parsed to match the struct, no?

see: https://github.com/tauri-apps/tauri/blob/50576a5e1e83978882d90aca280809da2235a8d5/core/tauri/src/updater/core.rs#L399

[sacred whale]

that should crash on this line: https://github.com/tauri-apps/tauri/blob/50576a5e1e83978882d90aca280809da2235a8d5/core/tauri/src/updater/core.rs#L417

[stark panther]

oh you're right.

but the URL is perfectly reachable in safari/chrome

[sacred whale]

yeah i tried the url too

[stark panther]

you can download the app here: https://noor.to/download

in the preferences > check for update

[sacred whale]

can you try adding/removing the "reqwest-client" feature flag?

[sacred whale]

(still got no mac :P )

[stark panther]

: (

Let me try the flag

[sacred whale]

and my macos vm is not my friend at the moment

[stark panther]

u broke up?

[sacred whale]

the vm is a bit emotionally unstable when i'm near

[stark panther]

then you must've forgotten the valentine's gift

[sacred whale]

shit

and 2 times in a row too

[stark panther]

seems like it fixed it in my test build. let me try to do a release

is it expected?

[sacred whale]

well, no but also a little bit, yes. wouldn't be the first problem we've had with attohttpc

[stark panther]

I already have reqwest in my project, so it wouldn't even add anything, it's great

[sacred whale]

well, since it removes the attohttpc backend it shouldn't make much of a difference even if you wouldn't use reqwest yourself, but since you're using it, it should decrease your app size since you don't have 2 different http clients anymore

[stark panther]

let's see

it seems to work now, thank you!

~52kb less