where do std.mem.Allocator tests go? | Zig Programming Language | Page 1

wary chasm Oct 30, 2024, 10:45 PM

#

I believe I have fixed a bug in std.mem.Allocator, where should I add a test?

lunar oasis Oct 30, 2024, 11:40 PM

#

what's the bug and how would it be tested?

wary chasm Oct 30, 2024, 11:43 PM

#

lunar oasis what's the bug and how would it be tested?

The bug is with .create for zero-sized values with an alignment greater than one. I want to add a test that just calls the function with a type that would cause the current compilation error it gives.

lunar oasis Oct 30, 2024, 11:45 PM

#

Does it cause a compileError or does it return an error?

wary chasm Oct 30, 2024, 11:46 PM

#

a semantic error

lunar oasis Oct 30, 2024, 11:47 PM

#

there's no way to test that. if the change is simple enough and obvious enough, just posting some text that shows what the error message looks like will be sufficient

wary chasm Oct 30, 2024, 11:48 PM

#

well the test would just be that it compiles

lunar oasis Oct 30, 2024, 11:49 PM

#

oh so, currently it causes a compile error, but it shouldnt?

wary chasm Oct 30, 2024, 11:49 PM

#

yep

lunar oasis Oct 30, 2024, 11:50 PM

#

hmm, i guess the best place right now would be to put it into std.heap along with the other allocator tests.

#

like lib/std/heap.zig

wary chasm Oct 30, 2024, 11:51 PM

#

alright, thanks

#where do std.mem.Allocator tests go?