regal wadi
Noticed in the course of the in-game keybind rework. In-game: Settings -> Control -> Keybind Preset to "Custom"
Clicking the "Use gridmenu" toggle has a visual lag; and does not update the settings toggle (however it does update the actual interface on every other click). So instead of acting as a 2 way toggle, its acting as a 4 way toggle and adding legion unit errors or map shaders is enabled into the console on alternating clicks.
Note: while originally noticed when working on my keybind editor, I reproduced it on master to confirm it wasn't merely a regression specific to my work.
limber estuary
Pretty sure that just turns of the widget no? All those legion debugs etc happen every game you just don't see them
limber estuary
I actually fixed that issue, but the PR is attached to a widget
Might be a good way of sneaking in some features
quasi gate
honestly, I should have made a separate PR for that but I was already making many just to support my widget. I thought it will be fine to keep this one together with it
regal wadi
@limber estuary I can just strip out the legion stuff; I included it because it was annoying, but obviously its not newly introduced
I'm not sure I see what you're referring to as far as the changes just turning off the widget; but perhaps I've missed something.
regal wadi
Actually I just checked out your changes in particular @quasi gate which make more substantial changes but fix this entire class of issue; If you're fine with it, I'll just cherry pick your commit and replace my solution for yours, as if you had opened the PR yourself to begin with (aside from ownership of the PR itself, since I can't change that)?
quasi gate
Actually I just checked out your changes in particular <@533543024760979458> whi...
That would be perfect. I was actually preparing a PR for that myself right now but I think it's simpler if you just edit your PR
thanks and sorry again for the inconvenience
regal wadi
That is done; I didn't test it myself, though I'm assuming you have
