Lobby settings (and tweaks) saved to local file

[desert axle]

Hi

Currently when a new lobby Option Preset is created using the "New" option only the lobby advanced settings-start-boxes-map-bots are saved into this.
If one is try to create and save a new preset involving tweakunits or tweakdefs this information is ignored by the tool and the information is lost.

Is there any chance of having the game to save the lobby presets (including tweaks) to a local file from which it can read/write information from the different individual presets headings?
That way people could also manually modify the file externally allowing them to paste the desired preset codes that are shared to them without having to directly copy them from an active lobby.

Creating this additional functionality would be particularly helpful on getting people to both test anticoop solutions and also help hosting tweaked tournaments without the players suffering too much setting each individual lobby up inputting several tweaks. In addition to also be very helpful to the tester/pve part of the community.

[crude parrot]

I didn't realize that tweaks were not included. That seems like a good ask, to me.

[lyric badge]

There is an open issue to add more nice things to option presets, so contributions are welcome: https://github.com/beyond-all-reason/BYAR-Chobby/issues/912

[desert axle]

Currently what happens is this:
If I save a preset including a tweak, when I load the preset again it just adds start boxes and nothing else.

[desert axle]

local function SavePreset(name)
local presetData = {}
presetData.mapName = ...
presetData.modoptions = ...
-- ADD THIS:
presetData.tweakunits = tweakUnitsTextBox.text or ""
presetData.tweakdefs = tweakDefsTextBox.text or ""
-- Then save to file
end
Load Logic: Usually looks like:
lua

local function LoadPreset(presetData)
-- restore map, modoptions...
-- ADD THIS:
if presetData.tweakunits then
tweakUnitsTextBox:SetText(presetData.tweakunits)
-- Possibly trigger the apply logic
end
if presetData.tweakdefs then
tweakDefsTextBox:SetText(presetData.tweakdefs)
end
end

@lyric badge
I assume this haven seen any movement since so guess it is time for ai to do something about it but no idea if it makes any sense.
This is what it has vomited, any good?

[lyric badge]

Have a look at the readme of the chobby repo on how to set up a local development copy: https://github.com/beyond-all-reason/BYAR-Chobby
Then it can be launched from BAR launcher on dev config.
Then you can test whatever the AI comes up locally and open a pull request if it works for you.
Any questions about chobby development can be asked in #🏚️｜chobby

[desert axle]

@lyric badge @steady fox
So I actually didnt need to load the repo or setup a copy which was putting me off doing it. Got the free Ai to run the code which I pasted into the below documents filepath...
The game detects it from there and just runs saving and loading all the tweaks. It was a 5 minute job...

[Deleted as false positive AI hallucination]

[lyric badge]

Are you sure this is accomplishing anything? /lua/ui/lobby is a hallucination and not actually used by the game or lobby.

[desert axle]

does base game now save and load tweakunits and I missed it?
because it works

[lyric badge]

Perhaps you are noticing the effects of this? #📰｜development-blog message

[desert axle]

Well, that could very well be the answer

Never got the news from the update

Well, it is good stuff. Thank you 😄

[steady fox]

Thanks Moose for actually knowing what's happening. True gamer.

[desert axle]

#announcements message
Ptaq didnt mention it and no one shared the news so I had a "false positive" and believed the thing when it work flawlessly 😂

[desert axle]

@marble wave great stuff my man, much appreciated.
Have used it to load my patch three times today and went smooth twice, only one time it still kicked me from the lobby but no big deal. It is a massive improvement for tweaked gaming 😃

[marble wave]

🙂 great! yeah there are still ways to trigger the throttler. especially in lobbies with many people in it seems to be easily reproducible. thanks!

[desert axle]

I do have one more idea for improvement, not sure how doable it is.

Currently the preset just erases the existing information. But that actually can be done by just flicking the game mode to a different one (like swapping to tourney mode will reverse any non vanilla stuff).
Some times you may want to do preset A + preset B kind of thing and wont have that kind of combination saved.

What are the chances of including an additional "load without clean slate" option to the side of the current standard "erase load".

This would allow the possibility of modular stuff without having to save the specific exact combination of lobby settings.
@marble wave
@lyric badge

[marble wave]

"preset A + preset B" yea. removing "!preset" is quite easy. pair that with a naive overwrite could work. i dont view the preset loader as so robust yet (hitting the throttler). it merely works so would be nice to take another look at that before making it add even more :). i do like and thought about this idea though.

[desert axle]

it just doesnt make sense forcing people to have all these combinations that you have to save individually

lava preset
testing preset
balance preset A
balance preset B
b p C
lava preset + balance preset A
lava preset + b p B
l p + b p C
testing preset + balance preset A
....

• ideally just need 1 more button there to have the option not to clean slate the lobby before loading the new stuff

• and also the overwrite preset should have a confirmation "are you sure you want to proceed?" cause missclicking something there is painful

[marble wave]

yea the ux is not great 😄 it should at minimum be left aligned as well.

i think it would have to be a checklist that adds numbers kind of. that way you can set the order of the presets (but not change individual item ordering without reset). thats pretty much the most minimal solution i can think of

I agree about the misclick of overwrite protection

[desert axle]

yeah that is perfectly fine and functional

[marble wave]

actually even more minimal: a single checkbox with "reset settings" enabled by default would also fit the trivial case. and that would probably be useful if you expand into the ordering later.

[desert axle]

Also, there was other stuff suggested as well in the past, cant remember them all but

• Lobby name
• Welcome message
  (both of these could be a tickbox when the preset is stored as you may not always want them to be recorded)

[amber solar]

This has a lot of overlap with modes and should probably have first-class UI support eventually. It's heavy tweaks to a "dead" client but the under-the-covers stuff translates easily enough to the new client because it's all declarative and owned by the game (same as modes).