tranquil yew
Currently there is a filter that make all units with sonar <250 to be not rendered, i suggest lower this filter at 149 to show rez sub sonar (they have 150 sonar) and T1 amphibious tanks.
For example jam range filter is 63, so maybe synchronize sonar filter with this, or find a better filter cutOff for both
opal hullBOT
Faction: 
Cortex
Health: 420
Cost: 200 M / 3'200 E / 5'960 B
Speed: 67 / 48 accel / 87° per sec turning
Vision: 300 / 450 (air)
Sonar: 150
Build power: 150
Range: 140
tranquil yew
This could also fix garpike sonar rendering because they have 175 sonar also not rendered
tranquil yew
@serene forge
We found there is a nasty filter at 250 which pruned every sonar coverage below this number, i suggest lower this filter at 149 to permit rez sub and garpike/pincer to show their sonar coverage, what do you think ?
Rez sub sonar => 150
Garpike => 175
Pincer => 180
Cetus => 180
serene forge
<@237979011735617546>
We found there is a nasty filter at 250 which pruned ever...
Whose name is on the widget?
tranquil yew
#1426088895636049950 message
You remember the widget that contain the filter @unreal mural ?
serene forge
I would ask what the original intent was. It sounds like an intentional exclusion to prevent excessively noisy trivial sonar ranges.
Like, maybe it's supposed to be Los equivalent for underwater units for when they are close enough to "bump" into things
Because it would be very silly if you're navigating around things you can't see lol
unreal mural
Yeah the small sonar values are just that. They make things a bit less silly. I think this could be reworked in the Itanthias radar branch, but that's a separate thought.
I believe the widget is gui_sensor_ranges.lua. Changing the cutoffs for the filters seems fine to allow, and would use a settings slider. But I think the suggestion is also to change the default cutoffs, somehow.
tranquil yew
Line 33 :
local minSonarDistance = 250
for unitDefID, unitDef in pairs(UnitDefs) do
if unitDef.sonarDistance and unitDef.sonarDistance > minSonarDistance then -- save perf by excluding low sonar range units
if string.find(unitDef.name, "raptor", nil, true) then
-- skip raptors from sonar
else
unitRange[unitDefID] = unitDef.sonarDistance
end
end
end
Look like it is for performance indeed, but having rez sub with sonar coverage rendered have value, even more with new unified "reclaim enemies" and F special move "reclaim enemies".
Modify filter minSonarDistance at 149 maybe for safety.
@wind vigil Any major reasons to keep this filter that high ?
https://github.com/beyond-all-reason/Beyond-All-Reason/pull/5477
glad mica
Small sonar rings are important though, because of how sonar affects vision.
Otherwise how will a user work out why tumbleweed can't see things but pincer can?
serene forge
Small sonar rings are important though, because of how sonar affects vision.
Ot...
Sounds to me like the tumbleweed was a exemption overlooked, unintentional that it can't discover things by bumping into them
tranquil yew
Now you talk about tumbleweed, indeed they never had sonar, weird because one of his use case is to kill opponent sea mex, so you need a sonar unit near it to see things UW or just random self D if you think there is a mex (easy to deduct as it block path).
Would be cool to have beherith opinion on this, i pinged him one time, don't want to ping more, if you can contact him, would be op.
The filter on jammer coverage is 63 and the first units with jammer that lower is minelayer with 64.
If we apply the same logic with sonar coverage, we should put the filter at 149
unreal mural
We are just unlikely to make the change until it's been discussed a bit, with or without Beherith.
Whether this is for performance or for UI declutter, then we could identify a high-strain case and just test it, like 400 rez subs. I'm back on the road for a day, no testing for me rn.
And I think re: tumbleweed that might be good as it is.
tranquil yew
Rez sub still not have his sonar coverage rendered, any news on this ?
unreal mural
I don't think anyone has thought about this
midnight umbra
I might test and PR this today
plush krakenBOT
Set a reminder in 2 hours from now (<t:1774889808:f>)
View reminders with the reminders command
plush krakenBOT
Reminder for @midnight umbra
midnight umbra
Tested and PR made:
https://github.com/beyond-all-reason/Beyond-All-Reason/pull/7277
midnight umbra
@serene forge
serene forge
Expect it to get picked up in the next PR review session (1-2 weeks)
tranquil yew
OP !
glad mica
Look i'm on tv!
tranquil yew
@midnight umbra Tyty !!