Replays not being saved since engine update?

[echo haven]

Scroll down

Naming got changed and they're probably sorted by name

[zealous nymph]

confirmed, mine won't show at all either.

that is to say, old ones show, new replays do not.

tried manually deleting all replays and chucking in a new one all by itself, nothing.

[echo haven]

Okay, that's a larger issue then

@soft junco

[acoustic pelican]

do they show on bar-rts.com?

[echo haven]

https://bar-rts.com/replays/bed25d65addabfa15dd8d7153bccfc81 seems to be a recent one from the new engine that does appear there

[desert cloak]

yes engine version 105.1.1-2133 started about 40 mins ago

[zealous nymph]

yeah, i can't get this one to show up for instance: https://www.beyondallreason.info/replays?gameId=ead35d6547d4387665e51caef343a03f

[acoustic pelican]

you mean, you can't get your own local version to show up? would you mind uploading that file for me

I'm guessing it's a bug in the replay parser for new engine version but only for local demos and not server ones

[agile plover]

It's a format name change of the replays.

The replays are generated, but the file name format has changed slightly.

[zealous nymph]

Tried both, gimme a sec....

[acoustic pelican]

ah, maybe a chobby issue then where it's not displaying them in the right order?

maybe chobby parses the dates from the file name

date/time separated with - now?

[agile plover]

Yes.

[acoustic pelican]

https://github.com/beyond-all-reason/BYAR-Chobby/blob/master/LuaMenu/widgets/gui_replay_handler.lua#L167

[tacit rose]

I've pointed it out already: #🚂｜engine message

but looks nobody followed up

[agile plover]

Old format: 20231116_154713 New format: 2023-11-16_22-02-44-864

[tacit rose]

It needs to support both

[zealous nymph]

right, confirmed I can see it again with a manual rename.

[soft junco]

Thx for pinging me - I'll be hands-on with this soon...

[heavy glacier]

I'm looking too but not getting far, I have found Zero-Ks replay parser will also be affected by this.

I don't see any errors for the replays that aren't getting picked up.

[soft junco]

tested and pushed

[soft junco]

error looks like this
[t=00:00:10.980231][f=-000001] [AddReplay] Error: Couldn't add replay, demos\2023-11-22_16-09-28-616_All That Glitters v2_105.1.1-2113-g619dada BAR105.sdfz [t=00:00:10.980282][f=-000001] [AddReplay] Error: [string "LuaMenu/Widgets/gui_replay_handler.lua"]:167: bad argument #2 to 'format' (string expected, got nil) stack traceback: [string "LuaMenu/Widgets/gui_replay_handler.lua"]:664: in function <[string "LuaMenu/Widgets/gui_replay_handler.lua"]:662> [C]: in function 'format' [string "LuaMenu/Widgets/gui_replay_handler.lua"]:167: in function 'CreateReplayEntry' [string "LuaMenu/Widgets/gui_replay_handler.lua"]:655: in function <[string "LuaMenu/Widgets/gui_replay_handler.lua"]:654> [C]: in function 'xpcall' [string "LuaMenu/Widgets/gui_replay_handler.lua"]:653: in function 'AddReplay' [string "LuaMenu/Widgets/gui_replay_handler.lua"]:702: in function 'ReadReplayInfoDone' [string "LuaMenu/Widgets/sl_loopback.lua"]:141: in function 'callback' [string "libs/spring-launcher/luaui/widgets/api_spring_launcher.lua"]:157: in function <[string "libs/spring-launcher/luaui/widgets/api_spring_launcher.lua"]:156> [C]: in function 'pcall' [string "libs/spring-launcher/luaui/widgets/api_spring_launcher.lua"]:156: in function 'CommandReceived' [string "libs/spring-launcher/luaui/widgets/api_spring_launcher.lua"]:203: in function 'ParseCommandsFromString' [string "libs/spring-launcher/luaui/widgets/api_spring_launcher.lua"]:189: in function 'ReadAvailableSockets' [string "libs/spring-launcher/luaui/widgets/api_spring_launcher.lua"]:176: in function <[string "libs/spring-launcher/luaui/widgets/api_spring_launcher.lua"]:168> (tail call): ? [C]: in function 'pcall' [string "LuaHandler/Utilities/crashHandler.lua"]:50: in function 'f' [string "LuaHandler/Utilities/specialCallinHandlers.lua"]:80: in function <[string "LuaHandler/Utilities/specialCallinHandlers.lua"]:76>

https://github.com/beyond-all-reason/BYAR-Chobby/commit/2a3fe5e6226439ba69db667b5242add02bd64f78

[heavy glacier]

I have multiple replays in the new timestamp format that aren't getting picked up, why don't I see any errors like above?

[soft junco]

when i run it with my "player-installation" i don't get an error either - but at the same time i don't see a .cache file being created

[heavy glacier]

This fixes nothing for me, new replays still aren't appearing.

[soft junco]

create an empty demos folder and put in 2 demos, one from the old engine and one from the new, then it works.
But on my main installation if have thousands of replays. There it does not show the most recent demo from new engine.
Think i'll need to look for the sorting where it catches the most recent 50 files...

[heavy glacier]

Okay, this worked.

[soft junco]

Ah, got it 🫤
Chobby fetches all files with *sdfz and then takes the 10 files at the end

    1 = demos\2023-11-22_16-09-28-616_All That Glitters v2_105.1.1-2113-g619dada BAR105.sdfz
    2 = demos\20231009_160228_Supreme Isthmus v1_105.1.1-1821-gaca6f20 BAR105.sdfz
    3 = demos\20231009_162441_Angel Crossing 1_105.1.1-1821-gaca6f20 BAR105.sdfz
    4 = demos\20231009_213627_Comet Catcher Remake 1_105.1.1-1821-gaca6f20 BAR105.sdfz
    5 = demos\20231102_130356_Death Valley v1_105.1.1-1821-gaca6f20 BAR105.sdfz
    6 = demos\20231107_214242_Quicksilver Remake 1_105.1.1-1821-gaca6f20 BAR105.sdfz
},```
So, you would need to scroll down your whole list of replays to come to the one with the new file name

unfortuantly the new file name is at the beginning

at least for windows, don't know about linux file name sorting, maybe different

guess i need to crawl engine functions to get most recent files in a folder...

this is current implementation
local replays = VFS.DirList("demos", "*.sdfz")
and this works for new files only 💪
local replaysTest = VFS.DirList("demos", "*-*-*-*.sdfz")

[tacit rose]

I doubt there is anything, why is it only looking at 10 last?

[soft junco]

nvm, have it fixed in a short, final testings...

[tacit rose]

no. name format change was intentional. the fix is in code loading the replays.

[soft junco]

hehe, funny part, it brought up an engine testing from me from 1 month ago 🙂

replayPath, demos\2023-10-15_09-07-57-631_Quicksilver Remake 1_105.1.1-2031-gd4526bf BAR105.sdfz
replayPath, demos\20231121_233453_Quicksilver Remake 1_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231121_214809_Delta Siege Dry v5_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231120_215826_Sinkhole Network v1_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231121_232209_Starwatcher 1_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231121_222923_Pentos_V1_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231120_215246_Koom Valley 3 3_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231120_211711_Rosetta 1_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231120_204411_Delta Siege Dry v5_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231120_195011_Rifted_V2_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231120_194457_Rifted_V2_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231119_212115_Neurope_Remake 4_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231119_204804_Rosetta 1_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231119_202246_Koom Valley 3 3_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231119_195659_Bismuth Valley v2_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231119_193201_Neurope_Remake 4_105.1.1-1821-gaca6f20 BAR105.sdfz
replayPath, demos\20231119_183335_Eight Horses 1_105.1.1-1821-gaca6f20 BAR105.sdfz

pushing...

pushed

https://github.com/beyond-all-reason/BYAR-Chobby/commit/7482a5b4eb12ed6383af00b11c83a2b4914a4ac9

[heavy glacier]

LGTM

[soft junco]

on chobby start 10 demos are read to have sth. showing up when you switch to demos tab. Then it will load up to 50 async.

[heavy glacier]

Thanks, I will PR these fixes to ZK's chobby too.