Game Not Ending with 0 Commanders

[proven fox]

We had a game where the last commander died, but the game did not end. Per the replay (https://bar-rts.com/replays/4fbceb6480d51458753d7fea0c65c4d4) it looks like normal settings, but at 40:56 the last commander dies, however the game does not end.

We kept playing until the enemy team resigned. Had another player say they had seen this before, but it was a first for me

[winter inlet]

I had similar once, but it was a commander owned by a player who had left, and nobody had /taken. UI showed 0 coms BUT they were still present techically. Might be similar?

[prime tinsel]

Were you playing with Legion turned on?

I had this issue recently, but realized it wasn't counting Legion commanders in the total count, but they still needed to be killed to end the game.

[proven fox]

No to legion

[echo trellis]

interesting. I will see what I can do this sounds like an easy fix

[woeful ridge]

This problem feels harder than i expected, i didn't manage to find reproduce steps fast...

[echo trellis]

which one, the situation reported by OP or the legion commanders?

[echo trellis]

I can't seem to reproduce this, the legion commanders are properly counted and I can see the customparam iscommander (used by the topbar display to detect which units are commanders) properly set

[prime tinsel]

It's possible that it was purely coincidence that the legion commanders weren't counted on the enemy team, I'm actually not sure if they were counted on my team or not, so may have nothing to do with Legion in fact

It's just that the count went to zero and the only two left on enemy team happened to be Legion, so I mistakenly assumed it was a Legion issue when it wasn't apparently

(and the one before last I don't think was a Legion, the commander I thought in the game was the actual last before he died and game didn't end)

Would have to figure out which of my games had the Legion on as that's the one with the issue, let me see if I can figure out which game it was and link the replay

https://bar-rts.com/replays/42dfe764caceac3cc3b240547299444e
That game shows ? by faction, so think it's that one

[woeful ridge]

With 0 commanders game not ending

I have an idea how to bisect this problem. Need apply /destroy command to commanders on different timestamps and see if at some point it's will stop to work.

But firstly need skip almost to the end of replay and apply /destroy command just seconds before last com was killed.

[jolly sundial]

i just watched the replay, and indeed strange

no gadget error that could be resposible either

[woeful ridge]

@jolly sundial that bug was caused by gifting commander to another player on around ~10:34 min mark

[jolly sundial]

yeah i just found out myself too

great work finding that out btw, i just looked int othe code and found it sus so i converted it to a widget and echo what it does

[jolly sundial]

applied a fix!

[woeful ridge]

I think my method of bisecting problems is ridiculously simple one. Probably i need to do some little tutorial, but i'm not sure if bottleneck in people who don't know how to bisect bugs or people who don't want to do so...

This question important to me because i'm thinking if worth make tutorial or not...

[winter inlet]

https://discord.com/channels/549281623154229250/1141823880282001500 unsure if this one is related in any way?

[jolly sundial]

looks like the same since commander coutner shows 0 and i dont see a commander on the team somewher eiether

[winter inlet]

there's a green com middle of the sea - but that player left