SOLVED - DLL Mod made in Rust not running recurring task right? | ?ServerName? | Page 1

worn basin Mar 9, 2026, 12:33 AM

#

Making a dll mod that adds a regen based on your vigor/mind/endurance stat level.
I AM VERY NEW TO RUST so I barely know what I'm doing.

Hoping someone who does know can take a look and try to get it to work.

I have isolated the problem to somewhere inside "cs_task.run_recurring". After commenting the insides out, Elden Ring doesn't CTD when I open it with the dll.

#

@rich moon Any chance you could take a look?

#

Other info:
Using fromsoftware-rs and rust-ini crates
Made for Elden Ring

worn basin Mar 9, 2026, 1:05 AM

#

📎 lib.rs

south flare Mar 9, 2026, 1:25 AM

#

worn basin

you are trying to parse floats as ints

#

also, don't read ini every frame, it's kinda too much

#

you can read it once and move into closure

#

you can use lldb debugger if you use vscode to debug crashes like this
https://marketplace.visualstudio.com/items?itemName=vadimcn.vscode-lldb

CodeLLDB - Visual Studio Marketplace

Extension for Visual Studio Code - Debugger for native code, powered by LLDB. Debug C++, Rust, and other compiled languages.

worn basin Mar 9, 2026, 1:28 AM

#

south flare you are trying to parse floats as ints

Ok! I will check that thanks!

#

Where would I put the line to read the ini to have it called once?

south flare Mar 9, 2026, 1:33 AM

#

worn basin Where would I put the line to read the ini to have it called once?

ouside of the task closure

worn basin Mar 9, 2026, 1:57 AM

#

Ok I have fixed the float/int issue i think and it no longer CTDs

#

Where exactly can the read_write_ini line go? I put it elsewhere and it gave errors like this:

#

That is with the line here:

#

As i said before I am VERY new to rust so I dont understand a lot of it

#

Just learning as i go

south flare Mar 9, 2026, 2:10 AM

#

read ini before creating new task

#

and use move keyword on the task closure to access read config inside it

#

https://doc.rust-lang.org/std/keyword.move.html

move - Rust

Capture a closure’s environment by value.

worn basin Mar 9, 2026, 5:04 AM

#

So now that those things are fixed, I need to get the regen working... it seems like its not looping like I need

📎 lib.rs

#

CTD problem from my DLL mod made in Rust - SOLVED

rich moon Mar 9, 2026, 6:20 AM

#

south flare also, don't read ini every frame, it's kinda too much

My intention was to allow the user to change the settings on runtime

#

But yeah ig every frame is too much

south flare Mar 9, 2026, 6:23 AM

#

rich moon My intention was to allow the user to change the settings on runtime

just use something like notify
https://docs.rs/notify/latest/notify/

notify - Rust

Cross-platform file system notification library

#

you don't need to read and deserialize ini every frame, only when file is actually changed

rich moon Mar 9, 2026, 6:24 AM

#

Yeah i had no clue thats possible, ill take a look at it

worn basin Mar 9, 2026, 7:13 AM

#

hello again @rich moon
any ideas for how to fix this mod?

#

📎 lib.rs

rich moon Mar 9, 2026, 7:16 AM

#

Do some println debugging and look if the code even reaches the stuff inside the if statement

worn basin Mar 9, 2026, 7:16 AM

#

ok

rich moon Mar 9, 2026, 7:17 AM

#

Your println will show up in the mod engine 3 console

worn basin Mar 9, 2026, 7:17 AM

#

got it

worn basin Mar 9, 2026, 7:45 AM

#

Not seeing any printed lines in the console...?

#

tried it out on the staticbarsize mod too

#

still not seeing anything

#

Also it is very late here so i need to stop for tonight and sleep so we can pick this up later?

south flare Mar 9, 2026, 8:06 AM

#

rich moon Do some println debugging and look if the code even reaches the stuff inside the...

cringe

#

#1480362979663806748 message

rich moon Mar 9, 2026, 1:11 PM

#

worn basin Also it is very late here so i need to stop for tonight and sleep so we can pick...

Yeah i was in school anyways

rich moon Mar 9, 2026, 1:13 PM

#

south flare cringe

Using print seems more convenient in this case, at least to me

worn basin Mar 9, 2026, 6:05 PM

#

DLL Mod made in Rust not running recurring task right?

unique iris Mar 9, 2026, 7:10 PM

#

rich moon But yeah ig every frame is too much

I'd recommend to use Serde and Toml for reading the settings

#

A.e:

#

const CAMERA_CONFIG_TOML: &str = "camera_config.toml";

#[derive(Deserialize)]
#[serde(default, deny_unknown_fields)]
struct CameraSettings {
    field_of_view: f32,
    distance_multiplier: f32,
    render_distance_start: f32,
    render_distance_end: f32,
    aspect_width: f32,
    aspect_height: f32,
}

impl Default for CameraSettings {
    fn default() -> Self {
        Self {
            field_of_view: 48.0,
            distance_multiplier: 1.0,
            render_distance_start: 0.05,
            render_distance_end: 10_000.0,
            aspect_width: 16.0,
            aspect_height: 9.0,
        }
    }
}

#[derive(Default)]
struct CameraConfig {
    field_of_view: f32,
    distance_multiplier: f32,
    render_distance_start: f32,
    render_distance_end: f32,
    aspect_ratio: f32,
    is_reloaded: bool,
}

static CAMERA_CONFIG: OnceLock<RwLock<CameraConfig>> = OnceLock::new();

fn get_camera_config() -> &'static RwLock<CameraConfig> {
    CAMERA_CONFIG.get_or_init(|| {
        let config = read_camera_config();
        RwLock::new(config)
    })
}

fn read_camera_config() -> CameraConfig {
    let mut camera_config = CameraConfig::default();
    if let Some(config) = std::env::current_exe().ok().and_then(|path_buf| {
        path_buf
            .parent()
            .map(|path_buf| path_buf.join(CAMERA_CONFIG_TOML))
            .and_then(|path_buf| std::fs::read_to_string(path_buf.as_path()).ok())
    }) {
        let camera_settings = toml::from_str::<CameraSettings>(&config).unwrap_or_default();
        camera_config.field_of_view = camera_settings.field_of_view.to_radians();
        camera_config.distance_multiplier = camera_settings.distance_multiplier;
        camera_config.render_distance_end = camera_settings.render_distance_end;
        camera_config.render_distance_start = camera_settings.render_distance_start;
        camera_config.aspect_ratio = camera_settings.aspect_width / camera_settings.aspect_height;
    }
    camera_config
}

#

Turns it in to actual Struct useable at runtime

#

not a solution to your current issue sadcat

rich moon Mar 9, 2026, 7:11 PM

#

is it faster than ini?

#

or why are those better

unique iris Mar 9, 2026, 7:12 PM

#

if something == "abcdefghijklmnop" {} -> if something {}

#

Wether the reading of the file itself is faster or slower is something i don't know, but you shouldn't be parsing files every frame either way.

#

I'd recommend making a trigger to do it once when WorldChrMan can't be found

#

but during runtime it's faster

#

and toml is kinda rust standard

#

i think

#

it's moreso Serde that i want to point out

#

Can of course, also use Notify that Axi linked

#

but idk wether it's beginner friendly, toml and serde are pretty easy to implement. You can just use #[derive(Deserialize)] instead of manually defining what the .ini should read.

#

@worn basin Do you have a detailed scenario of what you expect/want to happen and what is currently happening when you run your code?

worn basin Mar 9, 2026, 7:25 PM

#

Yeah Ill write out the logic

#

On startup, make the .ini config file (working fine)
Settings:
HP regen enabled
HP regen level cap
HP regen max power

FP regen enabled
FP regen level cap
FP regen max power

In the thread/recurring task:

Constantly check player's vigor and mind level
Calculate the strength of regen that should be applied by doing max_power * (current_level / level_cap) - which should basically do a constant ramp-up of the regen strength as the level gets higher. (I want to add a section of code to limit the regen strength as right now, the regen strength will keep increasing as the player's level increases... i want it usable with solid uncapper, so stats would be able to go above 99)
Lastly apply the regen at the calculated strength to the player's hp/fp

#

I wonder if there is anything wrong with the reading of the config file 🤔

#

Or if the player_game_data isnt the right module to reference

worn basin Mar 9, 2026, 7:34 PM

#

unique iris <@1122618689909444628> Do you have a detailed scenario of what you expect/want t...

Currently with my code the ini gets created
The test damage applies when game starts
// test damage
player_game_data.current_hp = (player_game_data.current_hp as f32 - 100f32) as u32;
player_game_data.current_fp = (player_game_data.current_fp as f32 - 100f32) as u32;

#

And no regen effect occurs

unique iris Mar 9, 2026, 7:36 PM

#

player_game_data.current_hp

What should this value be currently

#

1000.0?

worn basin Mar 9, 2026, 7:36 PM

#

it should be constantly changing to be the player's current hp amount, changing on damage/heal

unique iris Mar 9, 2026, 7:37 PM

#

oh wait it reads that from player data puddingcat

worn basin Mar 9, 2026, 7:37 PM

#

At least thats my understanding... idk

worn basin Mar 9, 2026, 7:37 PM

#

unique iris oh wait it reads that from player data <:puddingcat:998811403727159376>

yea

unique iris Mar 9, 2026, 7:37 PM

#

i thought it was a value taken from the .ini, my bad

worn basin Mar 9, 2026, 7:37 PM

#

np

unique iris Mar 9, 2026, 7:38 PM

#

was this working before?

#

or it hasn't worked at all, so far

worn basin Mar 9, 2026, 7:39 PM

#

I havent seen any regen at all at any point

#

with this code

#

Only change ingame is the test damage

#

Cargo.toml if needed:

[package]
name = "passive_bonuses"
version = "0.1.0"
edition = "2024"

[dependencies]
eldenring = "0.13.0"
fromsoftware-shared = "0.13.0"
rust-ini = "0.21.3"
windows = {version ="0.62.2", features = ["Win32_System_LibraryLoader"]}

[lib]
crate-type = ["cdylib"]

unique iris Mar 9, 2026, 7:47 PM

#

I think you should be using the ChrData module instead of the player game data

worn basin Mar 9, 2026, 7:48 PM

#

where is that?

unique iris Mar 9, 2026, 7:49 PM

#

Also, you can chain methods on structures to access fields

// Reference world_chr_man
let Ok(world_chr_man) = (unsafe { WorldChrMan::instance() }) else {
    return;
};

// Reference main_player from world_chr_man
let Some(ref mut main_player) = world_chr_man.main_player else {
    return;
};

// Reference player_game_data
let player_game_data = unsafe { &mut *main_player.player_game_data.as_mut() };

let Some(chr_data) = unsafe { WorldChrMan::instance() }
    // Convert Result<> in to Option<> so that ".and_then()" can be used.
    .ok()
    // If world_chr_man exists, immediately grab the main_player.
    // We can do this because "main_player" is an "Option<>".
    .and_then(|world_chr_man| world_chr_man.main_player.as_mut())
    // If the main player exists, grab a mutable reference to it's ChrDataModule.
    // We don't use ".and_then" because ".as_mut()" isn't an "Option<>".
    // It automatically "maps" the closure to "Some()".
    .map(|main_player| main_player.chr_ins.module_container.data.as_mut())
else {
    return;
};

unique iris Mar 9, 2026, 7:52 PM

#

worn basin where is that?

https://github.com/vswarte/fromsoftware-rs/blob/61f7ed8b22cc875de4756bc0d0a15b13e160d032/crates/eldenring/src/cs/chr_ins/module/data.rs#L10

worn basin Mar 9, 2026, 7:52 PM

#

got it

#

will change when I have time and see what happens

#

Should be available somewhat soon tho

unique iris Mar 9, 2026, 8:06 PM

#

Also the reason im mentioning it is due to

let player_game_data = unsafe { &mut *main_player.player_game_data.as_mut() };

There is no need to use the unsafe {} parameters here and manually dereferencing it due to it's OwnedPtr<> properties.
OwnedPtr guarantees you that you can access it from there, whereas a.e Option<NonNull<>> or NonNull<> doesn't.

(see: https://github.com/vswarte/fromsoftware-rs/blob/61f7ed8b22cc875de4756bc0d0a15b13e160d032/crates/shared/src/owned_pointer.rs#L7)

south flare Mar 9, 2026, 8:19 PM

#

unique iris Also the reason im mentioning it is due to ```rust let player_game_data = unsafe...

wrong

#

player_game_data is nonnull here

unique iris Mar 9, 2026, 8:23 PM

#

south flare wrong

puddingcat

#

they need ChrDataModule, not PlayerGameDdata

worn basin Mar 9, 2026, 8:42 PM

#

what should the use at the top, and the referencing in the middle look like?

#

to get the chrdatamodule

unique iris Mar 9, 2026, 8:49 PM

#

Dont need anything besides WorldChrMan

worn basin Mar 9, 2026, 8:51 PM

#

k

#

what should the code look like to reference the chrdatamodule through worldchrman?? Im having a hard time

#

// Reference chr data through world_chr_man
let Some(chr_data) = unsafe { WorldChrMan::instance() }
// Convert Result<> in to Option<> so that ".and_then()" can be used.
.ok()
// If world_chr_man exists, immediately grab the main_player.
// We can do this because "main_player" is an "Option<>".
.and_then(|world_chr_man| world_chr_man.main_player.as_mut())
// If the main player exists, grab a mutable reference to it's ChrDataModule.
// We don't use ".and_then" because ".as_mut()" isn't an "Option<>".
// It automatically "maps" the closure to "Some()".
.map(|main_player| main_player.chr_ins.module_container.data.as_mut())
else {
return;
};

#

?

unique iris Mar 9, 2026, 9:06 PM

#

yes

worn basin Mar 9, 2026, 9:06 PM

#

ooook

unique iris Mar 9, 2026, 9:07 PM

#

instead of doing multiple

else { 
  return; 
};

it's obtained by stacking methods

worn basin Mar 9, 2026, 9:09 PM

#

// Reference world_chr_man
let Ok(world_chr_man) = (unsafe { WorldChrMan::instance() }) else {
return;
};

can be removed since this other code takes care of it, right'

unique iris Mar 9, 2026, 9:09 PM

#

yes

#

we aren't storing world_chr_man at all in the blob i posted, we immediately dive in to its contents till we have access to the CSChrDataModule

worn basin Mar 9, 2026, 9:10 PM

#

// Reference player_game_data
let player_game_data = unsafe { &mut *main_player.player_game_data.as_mut() };

remove this too?

unique iris Mar 9, 2026, 9:10 PM

#

yes

worn basin Mar 9, 2026, 9:10 PM

#

ok

unique iris Mar 9, 2026, 9:10 PM

#

#1480362979663806748 message

Upper block can be replaced with lower block entirely

worn basin Mar 9, 2026, 9:11 PM

#

got it

#

so how do I get the player's vigor and mind? since there's no more reference to player_game_data?

#

or is there vigor/mind pub in one of those we have referenced now?

unique iris Mar 9, 2026, 9:15 PM

#

ah i forgot you did math on the character stats

#

my bad

worn basin Mar 9, 2026, 9:15 PM

#

well...

#

I could just do math with the player's max health?

unique iris Mar 9, 2026, 9:16 PM

#

you can do that as well, but you totally can grab player game data and chr data module

worn basin Mar 9, 2026, 9:17 PM

#

can you write out how to get the playergamedata too?

#

with the stacking methods?

#

or should it be separate?

unique iris Mar 9, 2026, 9:23 PM

#

Well, the thing is, we can't have 2 references where 1 of them is mutable

#

A.e, i can't return 2 of them from the same method if we require .as_mut()

worn basin Mar 9, 2026, 9:25 PM

#

ok

#

so separate?

unique iris Mar 9, 2026, 9:25 PM

#

which we need to mutate the health or fp, etc

unique iris Mar 9, 2026, 9:26 PM

#

worn basin so separate?

main_player isn't obtained due to the stacking methods, which is why it gets you an &mut {unknown}

#

let Some(main_player) = unsafe { WorldChrMan::instance() }
    .ok()
    .and_then(|world_chr_man| world_chr_man.main_player.as_mut())
else {
    return;
};

let player_game_data = main_player.player_game_data.as_ref();
let chr_data_module = main_player.chr_ins.module_container.data.as_mut();

worn basin Mar 9, 2026, 9:31 PM

#

Current Code:

worn basin Mar 9, 2026, 9:31 PM

#

unique iris ```rust let Some(main_player) = unsafe { WorldChrMan::instance() } .ok() ...

oook

#

unique iris Mar 9, 2026, 9:37 PM

#

let Some(main_player) = unsafe { WorldChrMan::instance() }
    .ok()
    .and_then(|world_chr_man| world_chr_man.main_player.as_mut())
else {
    return;
};

let player_game_data = unsafe { main_player.player_game_data.as_ref() };
let chr_data_module = main_player.chr_ins.module_container.data.as_mut();

// Calculate each buff's power at current related stat level
let hp_regen_current_power = settings.hp_regen_max_power * (player_game_data.vigor as f32 / settings.hp_regen_level_cap as f32);
let fp_regen_current_power = settings.fp_regen_max_power * (player_game_data.mind as f32 / settings.fp_regen_level_cap as f32);

// Apply passives at calculated power if enabled in settings (- is minus, + is add ???)
if settings.hp_regen_enabled == "true" {
    chr_data_module.hp = (player_game_data.current_hp as f32 + 1f32) as i32;
}

if settings.fp_regen_enabled == "true" {
    chr_data_module.fp = (player_game_data.current_fp as f32 + 1f32) as i32;
}

// test damage
chr_data_module.hp = (player_game_data.current_hp as f32 - 100f32) as i32;
chr_data_module.fp = (player_game_data.current_fp as f32 - 100f32) as i32;

#

ah, im on a newer version, i have a different wrapper on player_game_data

#

fixed

#

really curious if it's gonne be working now thinkrome

worn basin Mar 9, 2026, 9:39 PM

#

ill finish updating with your code and try it out

#

if settings.hp_regen_enabled == "true" {
chr_data_module.hp = (player_game_data.current_hp as f32 + 1f32) as i32;
}

if settings.fp_regen_enabled == "true" {
chr_data_module.fp = (player_game_data.current_fp as f32 + 1f32) as i32;
}

did u mean to have the chr_data_module.XX on left and player_game_data.current.XX on right?

#

i was thinking this:

unique iris Mar 9, 2026, 9:42 PM

#

puddingcat oversight, should both be chr_data_module.SomeVar

worn basin Mar 9, 2026, 9:42 PM

#

👍

#

currrent version:

📎 lib.rs

#

gonna try it out now

#

seems to be working! need to fine tune the power of the regen since its stronger than needed rn

#

then need to test more

unique iris Mar 9, 2026, 9:55 PM

#

worn basin seems to be working! need to fine tune the power of the regen since its stronger...

Yeah, keep in mind it hits once a frame, can track current frame time or duration since X to run this logic less then needed

#

If you lessen the values and someone comes in with uncapped fps the floating point might become too small for the math to do anything

#

Since you're casting back and forth

worn basin Mar 9, 2026, 9:56 PM

#

ok

#

One thing im wondering is there a module somewhere that controls walk/run speed and jump height? And sorcery/incantation damage buff that could be used easily? That's what i was planning for me to try to add after I fix the problems i was having

#

So there can be buff for dex, str, int, fai

unique iris Mar 9, 2026, 9:58 PM

#

Animation speed is in behavior iirc

#

but i don't think you're looking for that

#

You can use the physics module to adjust jump heights

#

That will require a bunch of game dev math

worn basin Mar 9, 2026, 9:59 PM

#

ok

#

i will check it out. Thanks for all the help!!

unique iris Mar 9, 2026, 10:00 PM

#

np, glad it's working lizParty

worn basin Mar 10, 2026, 5:02 AM

#

SOLVED - DLL Mod made in Rust not running recurring task right?

worn basin Mar 10, 2026, 6:12 AM

#

https://www.nexusmods.com/eldenring/mods/9442?tab=description

Nexus Mods :: Elden Ring

Scaling Passive Regeneration

The Scaling Passive Regeneration mod automatically gives HP, FP, and SP regeneration based on character stat levels.The regeneration amount scales with the player's levels in Vigor for HP regen,

#

Here it is in all its glory!

#SOLVED - DLL Mod made in Rust not running recurring task right?