Make Custom Component recognize enchants

[limpid prism]

Moving this from #1067869136606220288 since I was told it would be better suited here

I'm trying to patch durability for my custom items, but I need unbreaking to actually work. I've tried several different formats and setups but I cannot figure out how to make it recognize it.

Currently on 1.13.0 scripting version, as I am unsure how high I can push the version before one of my other scripts breaks.

import { system, world } from "@minecraft/server";
import * as mc from "@minecraft/server";
import { EquipmentSlot, GameMode, Player } from "@minecraft/server";
/** @type {import("@minecraft/server").ItemCustomComponent} */

/*
const ItemUnbreakableComponent = {
    onBeforeDurabilityDamage(event) {
        event.durabilityDamage = 0;
    },
};
system.beforeEvents.startup.subscribe(({ itemComponentRegistry }) => {
    itemComponentRegistry.registerCustomComponent("wiki:unbreakable", ItemUnbreakableComponent);
});
*/

const percentageCheck = Math.random();

const DurabilityPatchComponent = {
    onBeforeDurabilityDamage(event) {
        //const player = e.source;
        //const item = e.itemStack;
        let item = entity?.getComponent("equippable")?.getEquipment("Mainhand")
        const unbreakingLevel = item.getComponent(mc.ItemComponentTypes?.Enchantable)?.getEnchantment("unbreaking")?.level || 0
        if ((1/(unbreakingLevel+1))>=percentageCheck) {
            event.durabilityDamage = 1;
        } else { return; }
    },
};
world.beforeEvents.worldInitialize.subscribe(({ itemComponentRegistry }) => {
    itemComponentRegistry.registerCustomComponent("htc:durability_patch", DurabilityPatchComponent);
});

[torn flint]

As long as you have been using stable API you should be able to Go up to 2.2.0 on the server module

However some methods may have changed in the way that they are formatted such as the apply knockback method

[delicate finch]

There are some differences between Script V1 (like 1.13.0) and Script V2 (like 2.2.0). The highest to ensure the most stable without out to much change would be 1.19.0 but don't know

[torn flint]

That is true there are some changes however I believe from what I have been keeping up with the changes are minimal at best for example server ui now use a options object rather than what it was previously when you were sitting the default values and so on as for the server as I mentioned the knockback has changed format apply impulses now available on the player class oh and there's custom component V2 as well and a few other things but nothing comes to mind when it comes to any major script rewriting that's why I was said what I said

[delicate finch]

runCommandAsync no longer works in V2

[torn flint]

But anyway that's not really that important What's important is helping OP get their issue fixed

[torn flint]

That is true however it is unnecessary as you can still detect success count with the regular run command

[delicate finch]

I did help them a little in items

[torn flint]

And that is the majority of what async was used for which is detecting whether a command was successful in execution or not

[delicate finch]

The main issue is the source, onBeforeDurabilityDamage doesn't use source, so I suggested this.

Instead of doing const player = event.source; use const player = event.attackingEntity;
There was more to the conversation but that was the end of it

[torn flint]

That might be part of it but I think the other part of it is the fact that this is a before event trigger therefore code needs to be wrapped in a system.run otherwise it will error with a insufficient permission error

It's not permission it's privileges but you get what I mean

[delicate finch]

I know, but will a Custom Component Item Event work like that. Aren't they afterEvents? It is called onBeforDurabilityDamage, so it would make sense. But then that would be the only beforeEvent then in the item events that I have seen

[limpid prism]

I'm losing my mind trying to get this to work

[torn flint]

Yeah but even if it's the only one that's still how it works you do need a system run otherwise it will give you that error I know because I've used this specific event in custom components before

[torn flint]

Are you getting any sort of errors in your content log?

That you can diagnose

[limpid prism]

const DurabilityPatchComponent = {
    onBeforeDurabilityDamage(event) {
        const player = event.attackingEntity
        if (!(player instanceof Player)) return;

        const equippable = player.getComponent("minecraft:equippable");
        const mainhand = equippable.getEquipmentSlot(EquipmentSlot.Mainhand);
        const enchantable = itemStack.getComponent("minecraft:enchantable");
        const unbreakingLevel = enchantable?.getEnchantment("unbreaking")?.level;

        const damageChance = durability.getDamageChance(unbreakingLevel) / 100;

        if (Math.random() > damageChance) return;
        const shouldBreak = durability.damage === durability.maxDurability;

        if (shouldBreak) {
            mainhand.setItem(undefined); // Remove the item
            source.playSound("random.break"); // Play break sound
        } else {
            durability.damage++; // Increase durability damage
            mainhand.setItem(itemStack); // Update item in main hand
        }
    },
};

this is what I'm trying currently, based off of what is shown on bedrock.dev

[torn flint]

Right so then we have a place to go from

[delicate finch]

Itemstack is not defined

[torn flint]

But I would do is use the main hand equipment that you are defining to get the enchantable component rather than item stack

Oh wait never mind You're using the get equipment slot You're not using get equipment my bad that wouldn't work

[delicate finch]

Do const itemStack = event.itemStack

[limpid prism]

that did not help

wait

I may have ordered it wrong

let me try that first

[torn flint]

Yeah you did if you're getting that that means you're using item stack before the variable where you define it

[torn flint]

Now you need to go and define durability in a variable

[delicate finch]

That was never defined either

[limpid prism]

this feels like it is overcomplicated for what I need

[torn flint]

Yeah well that's scripting for you in some cases some cases easy other times it's complicated

[limpid prism]

and now it uses 3 durability instead of 2

[torn flint]

What do you mean three instead of two?

[limpid prism]

const DurabilityPatchComponent = {
    onBeforeDurabilityDamage(event) {
        const player = event.attackingEntity
        if (!(player instanceof Player)) return;
        
        const itemStack = event.itemStack;
        const equippable = player.getComponent("minecraft:equippable");
        const mainhand = equippable.getEquipmentSlot(EquipmentSlot.Mainhand);
        const enchantable = itemStack.getComponent("minecraft:enchantable");
        const unbreakingLevel = enchantable?.getEnchantment("unbreaking")?.level;

        const durability = itemStack.getComponent("minecraft:durability");
        const damageChance = durability.getDamageChance(unbreakingLevel) / 100;

        if (Math.random() > damageChance) return;
        const shouldBreak = durability.damage === durability.maxDurability;

        if (shouldBreak) {
            mainhand.setItem(undefined); // Remove the item
            source.playSound("random.break"); // Play break sound
        } else {
            durability.damage++; // Increase durability damage
            mainhand.setItem(itemStack); // Update item in main hand
        }
    },
};

[limpid prism]

custom weapons without scripts use 2 durability a hit instead of 1

with the script.. ""working"" it now uses 3

[torn flint]

I've made multiple custom weapons before and mine have never used to durability instead of one?

[torn flint]

It is likely that you just messed up the damage chance on the durability component or something

[delicate finch]

I think it is because it is adding on the durabilityDamage

[limpid prism]

well guess what, you may want to double check them

because it even applies to marketplace items

[delicate finch]

This might help, don't know.
event.durabilityDamage // The damage applied to the item's durability when the event occurs.

[torn flint]

Wouldn't know about marketplace since I don't bother buying anything from there

[torn flint]

And I have checked my items I always triple check everything I do before I post an add-on

[limpid prism]

used the free stuff as example

[limpid prism]

would you mind sharing your addon?

[torn flint]

The problem with that is that the ones I made custom weapons for have been basically re worked at this point have their own damage systems and repair systems in there so it wouldn't do you any good to see them since it wouldn't apply but I think the problem here is simply that you have the damage chance from the durability component interacting with your script and as a result of that I think it's tripling the loss durability like you said the only thing I can think of is either triple checking your durability component or using console.warn to identify the particular section of your code that might be interacting with the component itself on the item

[limpid prism]

it uses 2 durability with just the vanilla durability component and no script

[torn flint]

And you have no other scripts that maybe interacting with the custom component such as ones that use global event listeners such as player break block or player hit block

[limpid prism]

no

I just started working on adding custom component support BECAUSE of the double durability usage

as stated, this applies to other addons as well

[delicate finch]

I have never noticed the double durability

[torn flint]

Do you mind going into VC as maybe actually seeing your screen may help fix this better than typing

[torn flint]

Neither have I which is why this is strange

[limpid prism]

I didn't notice it until someone mentioned that they thought something was wrong with their durability viewer pack

[torn flint]

The only other thing I can think of is that he may have another add-on on the world that is interacting with his

[limpid prism]

nope

https://www.youtube.com/watch?v=DpwgBhWWRRg&feature=youtu.be

I'll just drop this here to show the bug itself

[torn flint]

I'm gonna try something myself give me a few minutes

[delicate finch]

I applied a texture pack that has a durability thing. It does 2 damage for me too

[torn flint]

Do you mind sending me that pack so I can test it myself as I do not have it and I don't know whether download is for it

[limpid prism]

and if you try vanilla items, you'll see it's not an issue with the durability viewer

[delicate finch]

I can send it

[torn flint]

I'm gonna try using a custom utility function I created a while back that is supposed to help reduce durability and see if that's affected by it as well

[torn flint]

That would be great

[delicate finch]

I dmed you the pack

[torn flint]

Ok

[delicate finch]

The iron axe does 2 but the iron sword did 1, some vanilla items does 2

Wait, forgot that an axe is more of a tool not a weapon. So it would do 2, like if you mined with a sword it would do 2

[torn flint]

I'm about to test it with my own utility function just to see

I just realised I don't have a custom item to test I'm gonna have to make one

[delicate finch]

💀

[torn flint]

Just made a quick test sword

Ok yeah I just tested it and it does go down two Which is strange but I'm going to see if I can write a custom component that cancels it out

Yeah I know it seems to be a bug in the new version of Minecraft then which needs to be reported because I've even tried to use the item component to negate the extra damage but no matter what I do it still takes two off rather than the one that it's supposed to even with a damaged chance of maximum one and minimum one @delicate finch @limpid prism

[limpid prism]

already reported

and it isn't new either

been around for several updates

[torn flint]

It's new to me but then again I haven't made weapons in several updates lol

[limpid prism]

https://report.bugs.mojang.com/servicedesk/customer/portal/6/MCPE-228996?created=true

[torn flint]

Good hopefully they'll fix it soon because it shouldn't be doing too it should be doing one I have no idea why it's doing two the only thing I could wonder is could it be maybe something about durability values being too high because on the sword I just made and tested had a thousand durability on it

[delicate finch]

Okay

[limpid prism]

even low durability values do it, unfortunately

[limpid prism]

I have an idea on how to make a custom component to fix this now, but I can't try it until I get home

if it works, I'll post it here... and if not, we'll have a new point to work from

[delicate finch]

Ok

[limpid prism]

I HAVE HAD A BREAKTHROUGH

const DurabilityPatchComponent = {
    onBeforeDurabilityDamage(event) {
        const player = event.attackingEntity
        if (!(player instanceof Player)) return;
        
        const itemStack = event.itemStack;
        const unbreakingLevel = itemStack.getComponent(mc.ItemComponentTypes?.Enchantable)?.getEnchantment("unbreaking")?.level || 0
        const percentageCheck = Math.random();

        if ((1/(unbreakingLevel+1))>=percentageCheck) {
            event.durabilityDamage = 1;
        } else { event.durabilityDamage = 0; }
    },
};

not only does this work, but it is more performant and takes less code than the other examples

:D

if anyone else wants to use this, feel free... but could you please credit me? Custom components are hard and this took me a lot of experimentation to get working

@delicate finch check this out when you get the chance

[delicate finch]

Hmmm...🤔

[limpid prism]

is that a good or bad "hmmm"

honestly, I'm not even sure if the player check at the start is needed, considering I don't think mobs use weapon durability on bedrock?

maybe I'm just crazy though

[delicate finch]

They don't but it is still good just in case

[limpid prism]

alright

[delicate finch]

It is more condensed then mine, everything looks good

[limpid prism]

oop, didn't realise you were trying to make one as well

[delicate finch]

I work on a lot of different things, I always try to make things more compact but work the same or better

[limpid prism]

Posted it to https://discord.com/channels/523663022053392405/1428908575635275926 in case anyone else needs it