Apply Enchantment causes crash

[celest prairie]

when the system apply enchantments and leave the world, the game crashes

[rich valve]

addEnchantments() should be like this: addEnchantments([{ type: EnchantmentType(‘sharpness’), level: 2 }])

[shadow spruce]

smal mistake.

it's new EnchantmentType() not EnchantmentType()

[rich valve]

Oops mb, I was in class lol

[solemn jacinth]

yo this

enchantableComponent.getEnchantment(new EnchantmentType("sharpness"))?.level || 0;

is crashing my game when i leave the world is there anyway to fix it?

@rich valve

[shadow spruce]

How script looks like??

[solemn jacinth]

function getSharpnessDamage(item) {
  const enchantableComponent = item.getComponent("enchantable");
  if (!enchantableComponent) {return 0;}
  const sharpnessLevel = enchantableComponent.getEnchantment(new EnchantmentType('sharpness'))?.level || 0;
  const sharpnessDamageMap = {1: 1, 2: 1.5, 3: 2, 4: 2.5, 5: 3};
  return sharpnessDamageMap[sharpnessLevel] || 0;
}

[elfin girder]

Try disabling/rewriting parts of your code, making sure and find what crashed the game.

It could be an infinite loop, a heavy operation, or even an invalid component/entity instance.

Or might be the game is just failing to save 'something' after the world is closed.

[solemn jacinth]

if i remove that part of the code the game doesnt crash

like if i set
sharpnesslevel to 0 not enchantableComponent.getEnchantment(new EnchantmentType('sharpness'))?.level || 0;
it doesnt crash

is there any other way of getting enchants

[elfin girder]

Maybe try staging it.

const sharpnessEnch = enchantableComponent.getEnchantment(new EnchantmentType('sharpness'));
const sharpnessLevel = sharpnessEnch ? sharpnessEnch.level : 0;

[solemn jacinth]

ok

function getSharpnessDamage(item) {
  const enchantableComponent = item.getComponent("enchantable");
  if (!enchantableComponent) {return 0;}
  const sharpnessEnch = enchantableComponent.getEnchantment(new EnchantmentType('sharpness'));
  const sharpnessLevel = sharpnessEnch ? sharpnessEnch.level : 0;
  const sharpnessDamageMap = {1: 1, 2: 1.5, 3: 2, 4: 2.5, 5: 3};
  return sharpnessDamageMap[sharpnessLevel] || 0;
}

it looks like this now

[solemn jacinth]

still crashes

[elfin girder]

crash on exiting the world?

[solemn jacinth]

yes it works fine in till i leave the world then the game hard crashes

[solemn jacinth]

it only happens if the getSharpnessDamage function has been activated if it hasn't when i leave the world its fine

[elfin girder]

let me try

Doesn't seem to be a problem for me.
-# (Android - 1.21.70 - 2.0.0-beta)

world.afterEvents.entityHitEntity.subscribe(({damagingEntity,hitEntity})=>{
    if (!(damagingEntity instanceof Player)) return;
    const equippable = damagingEntity.getComponent("equippable");
    const itemStack = equippable.getEquipment("Mainhand");
    if (!itemStack) return;
    const sharpnessDmg = getSharpnessDamage(itemStack)
    damagingEntity.sendMessage("§bSharpness: §e"+sharpnessDmg)
})

try using it on a different world I guess

[solemn jacinth]

did you leave the world after it was activated?

to see if it crashes

[spiral sage]

there is a bug where enchantable crashes the game on windows

nothing you can do about it sadly

[solemn jacinth]

is there any other way of getting the enchant?

[spiral sage]

I don't know any other than that one

[solemn jacinth]

i figured it out

function getSharpnessDamage(item) {
  const enchantableComponent = item.getComponent("enchantable");
  if (!enchantableComponent) {return 0;}
  let sharpness = 0;
  for (const enchantment of enchantableComponent.getEnchantments()) {
    if (enchantment.type.id === "sharpness") {
      sharpness = enchantment.level;
    }
  }
  const sharpnessLevel = sharpness || 0;
  const sharpnessDamageMap = {1: 1, 2: 1.5, 3: 2, 4: 2.5, 5: 3};
  return sharpnessDamageMap[sharpnessLevel] || 0;
}
})

idk why this doesnt crash but

[elfin girder]

"If it works, don't touch it."

[solemn jacinth]

https://youtube.com/shorts/pLLDpAxqWKY?si=Qocij4M7phJz9xvh

[safe stratus]

I think it's something with keeping the enchantment as a variable where the for loop just temporarily places it in memory before deleting it.

[safe stratus]

just did some testing and found that the issue arises from repeatedly running a function that contains class declaration for EnchantmentType. So if you declare the classes outside of the function, you can use them inside it and it wont cause crashes.

export const sharpnessEnchantment = new EnchantmentType("sharpness");

function getSharpnessDamage(item) {
    const sharpnessLevel = item.getComponent("enchantable").getEnchantment(sharpnessEnchantment) ?? {level: 0};
    const damage = Math.floor(1.25 * sharpnessLevel.level);
    return damage
}