sell item script doesn't work | Bedrock Add-Ons | Page 1

pallid jay Dec 23, 2024, 12:45 AM

#

Im beginner in minecraft scripting and i don't understand why this function doesn't work:

function sell(player, item, cost) {
    const objective = world.scoreboard.getObjective('money');
    const itemCount = player.getComponent("minecraft:inventory").container.toArray()
        .filter(item => item && item.typeId === item)
        .reduce((total, item) => total + item.amount, 0);
    if (itemCount < 1) {
        player.onScreenDisplay.setActionBar('§cError: §rYou do not have this item');
        return;
    }
    giveItem(player, item, -1);
    objective.addScore(player, cost);
    player.onScreenDisplay.setActionBar(`§aSuccess: §rYou have sold §e` + item);
}```

#

i did this before for buying item:

function buy(player, item, cost) {
    const objective = world.scoreboard.getObjective('money');
    if (objective.getScore(player) < cost) {
        player.onScreenDisplay.setActionBar('§cError: §rYou do not have enough money');
        return;
    }
    giveItem(player, item, 1);
    objective.addScore(player, -cost);
    player.onScreenDisplay.setActionBar(`§aSuccess: §rYou have bought §e` + item);
}

feral roostBOT Dec 23, 2024, 12:47 AM

#

pallid jay Im beginner in minecraft scripting and i don't understand why this function does...

Debug result for [code](#1320552763561611359 message)

Compiler Result

Compiler found 1 errors:

[36m<REPL0>.js[0m:[33m10[0m:[33m5[0m - [31merror[0m[30m TS2304: [0mCannot find name 'giveItem'.

[7m10[0m     giveItem(player, item, -1);
[7m  [0m [31m    ~~~~~~~~[0m

Lint Result

ESLint results:

<REPL0>.js

1:10 error 'sell' is defined but never used @typescript-eslint/no-unused-vars

polar vigil Dec 23, 2024, 12:47 AM

#

pallid jay Im beginner in minecraft scripting and i don't understand why this function does...

What the error U got

pallid jay Dec 23, 2024, 12:47 AM

#

function giveItem(player, itemType, count) {
    const inventory = player.getComponent("minecraft:inventory");

    if (inventory) {
        const itemStack = new ItemStack(itemType, count);
        inventory.container.addItem(itemStack);
    }
}

feral roostBOT Dec 23, 2024, 12:48 AM

#

pallid jay i did this before for buying item: ```js function buy(player, item, cost) { ...

Debug result for [code](#1320552763561611359 message)

Compiler Result

Compiler found 1 errors:

[36m<REPL0>.js[0m:[33m7[0m:[33m5[0m - [31merror[0m[30m TS2304: [0mCannot find name 'giveItem'.

[7m7[0m     giveItem(player, item, 1);
[7m [0m [31m    ~~~~~~~~[0m

Lint Result

ESLint results:

<REPL0>.js

1:10 error 'buy' is defined but never used @typescript-eslint/no-unused-vars

polar vigil Dec 23, 2024, 12:48 AM

#

Alr

pallid jay Dec 23, 2024, 12:48 AM

#

...

#

:')

polar vigil Dec 23, 2024, 12:48 AM

#

What the problem U get it?

#

When running the script

pallid jay Dec 23, 2024, 12:49 AM

#

This ??

polar vigil Dec 23, 2024, 12:49 AM

#

When this error throwed

#

Can U send full code

pallid jay Dec 23, 2024, 12:50 AM

#

its for test something but this is the full code:

📎 message.txt

#

i just need to repair the sell function line:24

polar vigil Dec 23, 2024, 12:51 AM

#

Ok wait a moment

pallid jay Dec 23, 2024, 12:52 AM

#

Okayy thx

polar vigil Dec 23, 2024, 12:59 AM

#

📎 message.txt

#

@pallid jay alr test it

pallid jay Dec 23, 2024, 1:02 AM

#

That doesn't work x)

polar vigil Dec 23, 2024, 1:03 AM

#

What's wrong

pallid jay Dec 23, 2024, 1:03 AM

#

same error

#

Do you know how i can use the minecraft debugger ?

polar vigil Dec 23, 2024, 1:14 AM

#

pallid jay Do you know how i can use the minecraft debugger ?

Wait

pallid jay Dec 23, 2024, 1:14 AM

#

yep

spring daggerBOT Dec 23, 2024, 1:15 AM

#

Info

This bot was created by SmokeyStack for the purpose of making a FAQ bot for the Bedrock Add-Ons Discord Server.

Managing Entries

To manage entries, please make a pull request on GitHub.

Source Code

GitHub

polar vigil Dec 23, 2024, 1:16 AM

#

Wait not this

#

https://jaylydev.github.io/posts/jaylybot/

JaylyBot | JaylyMC

JaylyBot is a Discord bot that includes various Minecraft Scripting API toolings such as a TypeScript debugger for Minecraft scripting, within Discord.

#

@pallid jay

pallid jay Dec 23, 2024, 1:17 AM

#

nahhh

#

the extension in vscode

#

sry I wasn't clear

vale umbra Dec 23, 2024, 1:18 AM

#

lmao

polar vigil Dec 23, 2024, 1:19 AM

#

pallid jay the extension in vscode

Oh sry I'm using my phone to code so I don't know much about Vscode

pallid jay Dec 23, 2024, 1:19 AM

#

uh okay

#

dw

vale umbra Dec 23, 2024, 1:23 AM

#

pallid jay Im beginner in minecraft scripting and i don't understand why this function does...

nahh that's cursed, you can't just give -1 item:v
what should you do is:
do loop for the whole inven
find for that item
while finding, chech if the total value is already enough to clear then stop
loop for each slot you found, and do setItem(item)
if the last sloot you loop have left item, setItem(item, thisSlot.amount - total left from inven loop)

then done:v

polar vigil Dec 23, 2024, 1:25 AM

#

vale umbra nahh that's cursed, you can't just give -1 item:v what should you do is: do loop...

Yes, I already did that, didn't I?

vale umbra Dec 23, 2024, 1:26 AM

#

polar vigil Yes, I already did that, didn't I?

owhh yeah

polar vigil Dec 23, 2024, 1:27 AM

#

vale umbra owhh yeah

But I think maybe I still did something incorrectly

vale umbra Dec 23, 2024, 1:28 AM

#

polar vigil But I think maybe I still did something incorrectly

yeah actually

pallid jay Dec 23, 2024, 1:28 AM

#

function sell(player, item, cost) {
    const objective = world.scoreboard.getObjective('money');
    const itemCount = player.getComponent("minecraft:inventory")
        .container.toArray()
        .filter(i => i && i.typeId === item)
        .reduce((total, i) => total + i.amount, 0);

    if (itemCount < 1) {
        player.onScreenDisplay.setActionBar('§cError: §rYou do not have this item');
    } else {
        const inventory = player.getComponent("minecraft:inventory")
            .container;
        for (let slot = 0; slot < inventory.size; slot++) {
            const slotItem = inventory.getItem(slot);
            if (slotItem && slotItem.typeId === item) {
                if (slotItem.amount > 1) {
                    slotItem.amount -= 1;
                    inventory.setItem(slot, slotItem);
                } else {
                    inventory.setItem(slot, null);
                }
                break;
            }
        }
        const currentMoney = objective.getScore(player.scoreboardIdentity);
        objective.setScore(player.scoreboardIdentity, currentMoney + cost);

        player.onScreenDisplay.setActionBar(`§aSuccess: §rYou have sold §e${item}`);
    }
}

vale umbra Dec 23, 2024, 1:28 AM

#

polar vigil But I think maybe I still did something incorrectly

you can't just Container.toArray()

#

you should loop for the Whole inven then store it manually

#sell item script doesn't work