Game is crashing | Bedrock Add-Ons | Page 1

wheat sierra Oct 13, 2024, 5:13 AM

#

function replaceItems(player) {
if (!player.isValid()) return;
  try {
  const replaceableItems = ["minecraft:torch", "minecraft:soul_torch", "minecraft:lantern", "minecraft:soul_lantern"];
  const customItems = {
    "minecraft:torch": "evo:torch",
    "minecraft:soul_torch": "evo:soul_torch",
    "minecraft:lantern": "evo:lantern",
    "minecraft:soul_lantern": "evo:soul_lantern"
  };
  
  const inventoryComponent = player.getComponent("minecraft:inventory");
  if (!inventoryComponent) return;
  const inventory = inventoryComponent.container;

  for (let i = 0; i < inventory.size; i++) {
    let itemStack = inventory.getItem(i);
    if (itemStack && replaceableItems.includes(itemStack.typeId)) {
      let newItemId = customItems[itemStack.typeId];
      if (newItemId) {
        let newItemStack = new ItemStack(newItemId, itemStack.amount);
        inventory.setItem(i, newItemStack);
      }
    }
  }
} catch (error) {
  console.warn("Error:", error);
  }
}

#

When I am drop my custom torch, is crashing my game instantly

#

Why?

#

I try everything to stop it crash, what am I doing wrong??

raven wyvern Oct 13, 2024, 5:39 AM

#

your function is not even called

#

and why do you need an array and an object with the same values?

wheat sierra Oct 13, 2024, 5:43 AM

#

Yes because I just send the function

wheat sierra Oct 13, 2024, 5:44 AM

#

raven wyvern and why do you need an array and an object with the same values?

No, is custom one

raven wyvern Oct 13, 2024, 5:44 AM

#

const itemReplaceMap = {
  "minecraft:torch": "my:torch"
}

function replaceItem(player) {
  let inv = player.getComponent("minecraft:inventory").container
  for (let i = 0; i < inv.size; i++) {
    let item = inv.getItem(i)
    if (itemReplaceMap[item?.typeId] == undefined) continue
    inv.setItem(i, new ItemStack(itemReplaceMap[item.typeId], item.amount)) 
  }
}

raven wyvern Oct 13, 2024, 5:45 AM

#

raven wyvern ```js const itemReplaceMap = { "minecraft:torch": "my:torch" } function repla...

use this

#

2 times shorter

raven wyvern Oct 13, 2024, 5:46 AM

#

wheat sierra Yes because I just send the function

show the code that calls it

raven wyvern Oct 13, 2024, 5:47 AM

#

wheat sierra No, is custom one

but they still repeat themselves

wheat sierra Oct 13, 2024, 5:48 AM

#

Ja is because I am trying to stop crash

#

Here

#

system.runInterval(() => {
  addLightTag();
  glowingEntities();
  
  const players = world.getAllPlayers();
  
  players.forEach(player => {
    updateEnchantScore(player);
  });
}, 1);

#

This is what call function

#

The crash is when I drop item like torch

raven wyvern Oct 13, 2024, 5:49 AM

#

wheat sierra ```js system.runInterval(() => { addLightTag(); glowingEntities(); cons...

show all functions that are called here

wheat sierra Oct 13, 2024, 5:49 AM

#

Ok

#

But here error if helo

#

[Scripting][error]-TypeError: cannot read property 'container' of undefined    at replaceItems (index.js:95)
    at <anonymous> (index.js:142)
    at forEach (native)
    at <anonymous> (index.js:143)

(Am host on different account, that is how I see error)

raven wyvern Oct 13, 2024, 5:51 AM

#

Are your games crashing or is the function not working?

wheat sierra Oct 13, 2024, 5:51 AM

#

Crash

#

Only person who drop torch

raven wyvern Oct 13, 2024, 5:52 AM

#

raven wyvern show all functions that are called here

.

wheat sierra Oct 13, 2024, 5:52 AM

#

function glowingEntities() {
dimensions.forEach(d => {
let dims = world.getDimension(d);

let entities = dims.getEntities({excludeTypes: ["minecraft:item", "minecraft:xp_orb"]})
entities.forEach(entity => {
if (entity.isValid()) {
try {
if (entity.getComponent("minecraft:onfire")) {
entity.addTag("onFire")
} else {
entity.removeTag("onFire");
}
} catch {}
}
})
})
}

#

const dimensions = ["overworld", "nether", "the_end"];

const tier15 = [
  "lantern", "evo:lantern", "beacon", "conduit", "pearlescent_froglight", 
  "verdant_froglight", "ochre_froglight", "glowstone", 
  "lit_pumpkin", "lava_bucket", "campfire", "sea_lantern", "shroomlight"
];
const tier14 = ["torch", "evo:torch", "glow_berries", "end_rod"];
const tier10 = ["evo:soul_torch", "soul_torch", "evo:soul_lantern", "soul_lantern", "soul_campfire", "crying_obsidian"];
const tier7 = ["enchanting_table", "ender_chest", "glow_lichen", "redstone_torch"];
const tier6 = ["sea_pickle", "sculk_catalyst"];
const tier3 = ["magma"];
const tier1 = ["brewing_stand", "dragon_egg", "sculk_sensor"];

function addLightTag() {
  dimensions.forEach(d => {  	
    let dims = world.getDimension(d);
    let items = dims.getEntities({ type: "minecraft:item" });
    items.forEach(itemEntity => {
       if (!itemEntity.isValid()) return;
      const itemComponent = itemEntity.getComponent("item");
      let itemId = itemComponent.itemStack.typeId;
      if (itemId.startsWith("minecraft:")) {
        itemId = itemId.slice(10);
      }
      if (tier15.includes(itemId)) {
        itemEntity.addTag("lv15");
      } else if (tier14.includes(itemId)) {
        itemEntity.addTag("lv14");
      } else if (tier10.includes(itemId)) {
        itemEntity.addTag("lv10");
      } else if (tier7.includes(itemId)) {
        itemEntity.addTag("lv7");
      } else if (tier6.includes(itemId)) {
        itemEntity.addTag("lv6");
      } else if (tier3.includes(itemId)) {
        itemEntity.addTag("lv3");
      } else if (tier1.includes(itemId)) {
        itemEntity.addTag("lv1");
      }
    });
  });
}

#

function updateEnchantScore(player) {
  if (!player.isValid()) return;
  
  system.run(() => {
    const armourSlots = ["Head", "Chest", "Legs", "Feet", "Mainhand"];
    const excludedItems = ["evo:torch", "evo:soul_torch", "evo:lantern", "evo:soul_lantern"];
    let enchantScore = 0;

    let equipComponent = player.getComponent("equippable");
    if (!equipComponent) return;

    let mainhandItem = equipComponent.getEquipment("Mainhand");
    let offhandItem = equipComponent.getEquipment("Offhand");

    if (
      (mainhandItem && excludedItems.includes(mainhandItem.typeId)) ||
      (offhandItem && excludedItems.includes(offhandItem.typeId))
    ) {
      enchantScore = 0;
    } else {
      armourSlots.forEach(slot => {
        let armourItem = equipComponent.getEquipment(slot);
        if (armourItem) {
          const enchantComponent = armourItem.getComponent("enchantable");
          if (enchantComponent && enchantComponent.getEnchantments().length > 0) {
            enchantScore += 1;
          }
        }
      });
    }
    let score = world.scoreboard.getObjective("enchant");
    if (score) {
      score.setScore(player, enchantScore);
    }
  });
}

#

These functions work

#

It is only the replacement item I am have trouble with

#

I don't understand how container is undefined, that is what confusing

raven wyvern Oct 13, 2024, 5:55 AM

#

send all the code via file

wheat sierra Oct 13, 2024, 5:56 AM

#

Ok

#

Wrong one

#

Sorry

#

wait

#

why is not working??

#

let me reset my discord

#

📎 index3.js

#

Here it work, sorry

raven wyvern Oct 13, 2024, 6:06 AM

#

something tells me that you just have a very large nested loop and the code takes a very long time to execute, so mine collapses the world

wheat sierra Oct 13, 2024, 6:08 AM

#

There is no lag??

wheat sierra Oct 13, 2024, 6:08 AM

#

raven wyvern something tells me that you just have a very large nested loop and the code take...

Am not understand what that mean

#

What is nested loop?

raven wyvern Oct 13, 2024, 6:09 AM

#

try to optimize the code or disable a couple of functions and see how it works

wheat sierra Oct 13, 2024, 6:09 AM

#

Okay, I will try

raven wyvern Oct 13, 2024, 6:09 AM

#

wheat sierra Am not understand what that mean

a lot of code is running at the same time.

wheat sierra Oct 13, 2024, 6:09 AM

#

But am confused, why am I getting error if it is because of loop?

#

Is saying inventory container is undefined but I check for it

raven wyvern Oct 13, 2024, 6:11 AM

#

wheat sierra But am confused, why am I getting error if it is because of loop?

there is a system that turns off the world if the code takes too long to execute

wheat sierra Oct 13, 2024, 6:12 AM

#

Watch dog

#

Hm ok

raven wyvern Oct 13, 2024, 6:12 AM

#

although I'm not sure what your long code is. But still try to turn off some functions and see how it works

wheat sierra Oct 13, 2024, 6:12 AM

#

raven wyvern there is a system that turns off the world if the code takes too long to execute

Ja I have that happen before, but it close world ?

#

But my account that is hosting does not crash or get kick

raven wyvern Oct 13, 2024, 6:13 AM

#

hmm

wheat sierra Oct 13, 2024, 6:14 AM

#

Here what happen:

raven wyvern Oct 13, 2024, 6:14 AM

#

maybe Mojang did something weird and made some kind of "protection" from the crash of worlds

wheat sierra Oct 13, 2024, 6:14 AM

#

I drop item on other account. Then on my host account, it spam the console with the error I put before for a few seconds then stop

wheat sierra Oct 13, 2024, 6:15 AM

#

raven wyvern maybe Mojang did something weird and made some kind of "protection" from the cra...

???

#

I do crash

#

But here is what confuse me

#

The function is working

#

It will change torch into my custom one, but as soon as I drop it it crash

#

If it was because of too much lag, there would not be error?

#

Here is video show error.

#Game is crashing