does this script only work with weapons ?

[craggy oriole]

import { world, Player } from "@minecraft/server";

world.afterEvents.entityHitBlock.subscribe(({ hitBlock, damagingEntity: player }) => {
    if (!(player instanceof Player)) return;

    const item = player.getComponent('equippable')?.getEquipment('Mainhand');

    if (item?.typeId === 'minecraft:diamond_sword') {
        player.runCommand('say Something') 
    }
});

I tried it with a normal custom item and it didn't work but then I tried with a diamond sword and it worked

[exotic holly]

well what is your custom weapon name

[craggy oriole]

Ninjago:earthelement

Or something like that

[exotic holly]

it'll work any item

you must've spelled it wrong.

[craggy oriole]

It isn't working

Maybe it's the getEquipment

?

That's what I put ?

[exotic holly]

didnt he do that

lol

[craggy oriole]

Lmao

[exotic holly]

this is strange, it should be working

I see no spelling errors

[craggy oriole]

Ah dang

I thought that too

[exotic holly]

that could be a possiblity

[craggy oriole]

But the moment I change it to Minecraft:diamond_sword it starts to work

[exotic holly]

oh

so it has to do with the item

[craggy oriole]

hmm

[exotic holly]

well he said it was working with diamond sword already

just not with his item

[craggy oriole]

The function/command is completely the same for both items

I still say it's the getEquipment

[exotic holly]

I dont see how it would be that

[craggy oriole]

Would getItem work?

[exotic holly]

thats not the problem

if that were the problem why would diamond sword work

[craggy oriole]

And I don't see how this script isn't working despite it being perfectly correct

[craggy oriole]

Lmao

[craggy oriole]

Maybe cause the item isn't technically equipment or something and just falls under item...idk tbh

[exotic holly]

...

[craggy oriole]

That's what I used beforehand,lmao

[exotic holly]

getEquipment is getting the Mainhand slot in this case

[craggy oriole]

Yh idk then

[exotic holly]

anything defined in your maindhand slot will return

doesnt matter what category the item is in

[craggy oriole]

You mean it shouldn't matter.lol

This script should be working

[exotic holly]

it does not matter.

[craggy oriole]

Lol

[craggy oriole]

Do you have an idea on what the problem may be ?

[exotic holly]

can you show the function

[craggy oriole]

I don't think it really matters but sure

setblock ^^^1 ninjago:dirt_set

There

That's it

Nothing more

[exotic holly]

yeah, I have nothing

[craggy oriole]

Well I had more for the original command but I dumbed it down and it still doesn't work

execute as @s[scores={stone=1..}] at @s if entity @s[y=~1.1,dy=0.5] unless entity @s[y=~1.6,dy=0.5] run setblock ^^^1 ninjago:dirt_set

Is the original(this works as a normal command without scripts btw)

Yep

[exotic holly]

even he wasnt why would it work with diamond sword

lmfao

its the item

for some reason

Okay, yU, if you dont mind...
may you share the pack so I can try to figure it out from the inside

[craggy oriole]

The entire addon ?

[exotic holly]

if that's not a problem.

you can dm me.

[craggy oriole]

Do you mind shifting through about 700 functions, because there's only one script(it's all I'm allowed to make) and it's exactly what I showed you

[exotic holly]

I wont be looking at the functions

i'll be looking at the item

[craggy oriole]

Ah

Okay

There's the item

[exotic holly]

so you wont share the pack

thats fine

[craggy oriole]

I could but it may take forever to upload(it's not by any means small) and I ain't looking to leak anything

[exotic holly]

No I understand.

completely.

[craggy oriole]

Uh

[exotic holly]

im just not sure what else I can do

sorry

[craggy oriole]

Well giving you the full version won't help(if you only plan on looking at one item) but maybe you could write a different script that does the same thing virtually?

[exotic holly]

the reason why I wanted the pack so I could try to tinker with things to make it work without making you do it

no insult to your capabilities ofc, but that was my last idea.

[craggy oriole]

I heavily it would work for you, plus if you looked at the code rn im sure you'd find...problems

Problems that are not entirely in my control

[exotic holly]

Right, I probably would've said something

lmao

[craggy oriole]

Yes

Ofc none of the problems should affect how the scripts work but whatev

[exotic holly]

oh

Yu

dont use 1.17.0 for your format, change it to like 1.20.80+

[craggy oriole]

And there it is

Ik it was coming

[exotic holly]

lmfaoo

well, item and block events are deprecated

[craggy oriole]

All 81 items are on that format, like I said kinda out of my control(and it doesn't effect the scripts) and that's only half since I'm doing the other addon half on a different device so about 400 items on version 1.17

[exotic holly]

oh

my lord

im so sorry for you

all of those items wont work very soon

[craggy oriole]

It shouldn't at all effect the scripts tho

[craggy oriole]

Nah I'm using addon maker(yh I'm I'm a horrible person) the guy who's making it is fixing up the app so all our crap doesn't break in like 3 updates

That's why I'm learning scripts rn

[exotic holly]

yeah I could tell from the screenshot

I use bridge

[craggy oriole]

Lmao

[exotic holly]

im less of a peasant as you

lol

[craggy oriole]

And since addon maker...isn't the best he screwed up of course and we can only make one script file(we can't access the manifest)

[craggy oriole]

I have bridge...

[exotic holly]

come to bridge

or better yet, just use VSC

[craggy oriole]

Lmao not to be mean but Ik this would happen.(I send someone the files on my addon and they send me recommendations on doing anything else besides what I'm trying to do)

[exotic holly]

well that's how it works.

[craggy oriole]

Yh ik

[exotic holly]

lol

[craggy oriole]

I'm like 70 percent sure it's the fact that the item is an item and not a weapon so I'm guessing when I change the item to a weapon it'll work...

[exotic holly]

Well, im 100% sure its not

because ive been working with the api for a bit now

[craggy oriole]

I see

[exotic holly]

lets hope no one comes in here and tells us we've overlooked the smallest thing

[craggy oriole]

Lmao true

[autumn crescent]

Your item doesn't have the component minecraft:equippable

[craggy oriole]

so instead of equippable it needs to be minecraft:equippable ?

[autumn crescent]

No, you have to put minecraft:equippable in the item json for your item

[craggy oriole]

Where exactly would I put that feature?

[autumn crescent]

In your item json file

[exotic holly]

you dont

[autumn crescent]

I'm curious as to why?

[exotic holly]

there's no minecraft:equippabe component for items

minecraft:equippable is an entity component.

[autumn crescent]

Oh, I think it's minecraft:hand_equipped mb

[exotic holly]

hand_equipped has nothing to do with this

thats just rendering the item like a tool

[autumn crescent]

Hmm makes sense. I've tried using the getEquipment method on custom items before and it worked fine. Guess it's just a spelling problem

[craggy oriole]

It's not that

[craggy oriole]

I did some editing and the script doesn't work on any item that runs a function

[warped pike]

isnt it getEquipmentSlot("Mainhand"); or im crazy?

[exotic holly]

you can use both

[warped pike]

alr

[craggy oriole]

Would it help if I changed it ?

[exotic holly]

go ahead.

if it somehow works after this then great, but ill be confused

[craggy oriole]

I doubt it'll work tbh

[craggy oriole]

am I able to run multiple scripts on one item, like a script on rigt click, and a script that opens a forum on right click?

[exotic holly]

you can, you just need to condition it so it won't run both code for the actions
like checking if the player is sneaking for one action, and checking if the player is not for the other

[craggy oriole]

ah well, on my other item the earth one the player has to be looking down to acitvate something and shfiting to activate something else, but i made that with commands not scripts

maybe thats the problem

[exotic holly]

you check where the player is looking in the api

just look at the docs.