cannot read property 'typeId' of undefined | Bedrock Add-Ons | Page 1

covert ginkgo May 4, 2024, 12:01 PM

#

i need help

#

📎 message.txt

#

import { world } from "@minecraft/server";


world.afterEvents.playerBreakBlock.subscribe((ev) => {
    const player = ev.player;
    const block = ev.block;
    const item = player.getComponent("inventory").container.getItem(player.selectedSlot).typeId;
    const { x, y, z } = block.location;

#

player.getComponent("inventory").container.getItem(player.selectedSlot).typeId;

#

.typeId doesnt exist?

woeful thunder May 4, 2024, 12:06 PM

#

covert ginkgo .typeId doesnt exist?

if(item.typeId === "minecraft:stone")  {
}

woeful thunder May 4, 2024, 12:07 PM

#

covert ginkgo ```js import { world } from "@minecraft/server"; world.afterEvents.playerBreak...

world.beforeEvents.playerBreakBlock.subscribe((ev) => {
    const player = ev.player;
    const block = ev.block;
    const item = player.getComponent("inventory").container.getItem(player.selectedSlot).typeId;
    const { x, y, z } = block.location;

covert ginkgo May 4, 2024, 12:09 PM

#

It worked in 1.10.0-beta

#

=== doesn't matter

#

alr

#

il try

covert ginkgo May 4, 2024, 12:30 PM

#

doesnt work

#

@woeful thunder

covert ginkgo May 4, 2024, 12:31 PM

#

woeful thunder ```js world.beforeEvents.playerBreakBlock.subscribe((ev) => { const player =...

that doesnt work

#

😭

spring creek May 4, 2024, 12:41 PM

#

cannot read property 'typeId' of undefined
Is not saying typeId doesn't exist, it's saying the object before it doesn't exist.

woeful thunder May 4, 2024, 12:48 PM

#

covert ginkgo doesnt work

world.beforeEvents.playerBreakBlock.subscribe((ev) => {
    const player = ev.player;
    const block = ev.block;
    const item = player.getComponent("inventory").container.getItem(player.selectedSlot)
    const { x, y, z } = block.location;
    if(!item) return
    if (item.typeId === "minecraft:stone") {
        player.sendMessage(`${block?.typeId} In MainHand ${item?.typeId}`)
    }
})

carmine otter May 4, 2024, 1:09 PM

#

wich version are you using

covert ginkgo May 4, 2024, 1:17 PM

#

carmine otter wich version are you using

the server version or mc version

carmine otter May 4, 2024, 1:17 PM

#

yes server version

gleaming silo May 4, 2024, 1:17 PM

#

Just use optional chaining operator

covert ginkgo May 4, 2024, 1:17 PM

#

1.11.0-beta

gleaming silo May 4, 2024, 1:17 PM

#

item?.typeId

carmine otter May 4, 2024, 1:19 PM

#

covert ginkgo 1.11.0-beta

okay ill send you a better code

covert ginkgo May 4, 2024, 1:19 PM

#

carmine otter okay ill send you a better code

alr

#

It worked on 1.10.0-beta

#

but that doesn't exist now

carmine otter May 4, 2024, 1:20 PM

#


import { world } from "@minecraft/server";

const customItems = {
    "twm:drill": "drill",
    "twm:heavy_drill": "heavy_drill",
    "twm:smelting_pickaxe": "smelting",
    //    
    "twm:stone_hammer": "hammer/twm_break",
    "twm:iron_hammer": "hammer/twm_break",
    "twm:diamond_hammer": "hammer/twm_break",
    "twm:netherite_hammer": "hammer/twm_break",
    //
    "twm:advanced_iron_axe": "advanced_axe",
    "twm:advanced_diamond_axe": "advanced_axe",
    "twm:advanced_netherite_axe": "advanced_axe",
    //
    "twm:advanced_iron_shovel": "advanced_shovel",
    "twm:advanced_diamond_shovel": "advanced_shovel",
    "twm:advanced_netherite_shovel": "advanced_shovel",
    //
    "twm:advanced_iron_pickaxe": "advanced_pickaxe",
    "twm:advanced_diamond_pickaxe": "advanced_pickaxe",
    "twm:advanced_netherite_pickaxe": "advanced_pickaxe",
}

world.afterEvents.playerBreakBlock.subscribe((ev) => {
    const player = ev.player
    const item = player.getComponent("inventory").container.getItem(player.selectedSlot).typeId

    if (item) {
        const block = ev.block
        const { x, y, z } = block.location
        const functionName = customItems[item]
        
        if (functionName !== undefined) {
            player.runCommandAsync(`execute positioned ${x} ${y} ${z} run function ${functionName}`);
        }
    }
})

#

try this

#

better then if statements

woeful thunder May 4, 2024, 1:22 PM

#

covert ginkgo the server version or mc version

1.11.0-beta

covert ginkgo May 4, 2024, 1:22 PM

#

woeful thunder 1.11.0-beta

yea

covert ginkgo May 4, 2024, 1:22 PM

#

carmine otter ```js import { world } from "@minecraft/server"; const customItems = { "tw...

il try that in a second

carmine otter May 4, 2024, 1:23 PM

#

sure

woeful thunder May 4, 2024, 1:23 PM

#

carmine otter sure

yes

carmine otter May 4, 2024, 1:23 PM

#

woeful thunder yes

??

woeful thunder May 4, 2024, 1:24 PM

#

carmine otter ??

I thought you were talking to me sorry

carmine otter May 4, 2024, 1:24 PM

#

woeful thunder I thought you were talking to me sorry

its okay

carmine otter May 4, 2024, 1:24 PM

#

covert ginkgo il try that in a second

when typeId isnt working use id

covert ginkgo May 4, 2024, 1:24 PM

#

carmine otter when ``typeId`` isnt working use ``id``

alr

woeful thunder May 4, 2024, 1:25 PM

#

carmine otter when ``typeId`` isnt working use ``id``

id is stable

carmine otter May 4, 2024, 1:25 PM

#

oh okay

#

mb i see

const item = new ItemStack('minecraft:apple', 1)

item.type.id // minecraft:apple
// or
item.typeId // minecraft:apple

#

is the same ( says microsoft )

woeful thunder May 4, 2024, 1:26 PM

#

item.typeId // minecraft:apple

woeful thunder May 4, 2024, 1:27 PM

#

carmine otter mb i see ```js const item = new ItemStack('minecraft:apple', 1) item.type.id //...

what do you want to do with the itemStack??

carmine otter May 4, 2024, 1:27 PM

#

you can create items

woeful thunder May 4, 2024, 1:28 PM

#

carmine otter you can create items

or I it is but you want to add a direct item in the inventory to make it spawn in a location??,

carmine otter May 4, 2024, 1:28 PM

#

it will be an object as first so yu need to insert this object into the players inventory wait:

#

like:

// instead of using runCommand you can also use: (idk if this even works):
import { Player, ItemStack } from "@minecraft/server"

/**
 * @param {Player} player 
 * @param {...*} datas 
 * @throws error if the Player, ItemStack or Enchantmentsa are invalid
 */
function addItems (player, ...datas) {
    try {
        if (!player instanceof Player) throw new Error("Provided \"player\" must be from the Players class")
            const playerInventory = player.getComponent('minecraft:inventory').container
            
            for (const index in datas) {
                const data = datas[index], item = data[1]

                if (!item instanceof ItemStack) { throw new Error(typeof item === 'object' ? JSON.stringify(item) : item + "§r, must be an insteance of ItemStack") }
                const enchantments = data[2]
        
                if (enchantments) {
                    const enchantable = item.getComponent("minecraft:enchantable")
                    if (!enchantable) { throw new Error(`Item in array [${index}] is not enchantable`) }
                    enchantable.addEnchantments([...enchantments]) // can throw errors
                }
        
                playerInventory.setItem(data[0], item)
            }
    } catch (error) {
        console.error("[addItems]" + error.message)
    }
}

// example usage
function whenTriggeredExample (player) {
    addItems(player, 
        [0, new ItemStack("minecraft:diamond_sword", 1), [ { id: 'minecraft:sharpness', level: 2 }, { id: 'minecraft:unbreaking', level: 1 } ]],
        [1, new ItemStack("minecraft:diamond_pickaxe", 1), [ { id: 'minecraft:unbreaking', level: 1 } ]],
        [8, new ItemStack("minecraft:breed", 16), []],
    )
}

#

idk if this is working

woeful thunder May 4, 2024, 1:30 PM

#

carmine otter like: ```js // instead of using runCommand you can also use: (idk if this even w...

const inventory = player.getComponent("inventory")?.container
inventory.addItem(new ItemStack("minecraft:diamond_sword", 1))

carmine otter May 4, 2024, 1:31 PM

#

yes

#

but i made a function that can add mutliple items with enchantments

#

when its even working

woeful thunder May 4, 2024, 1:31 PM

#

okok

woeful thunder May 4, 2024, 1:33 PM

#

covert ginkgo il try that in a second

its work ?

carmine otter May 4, 2024, 1:35 PM

#

I hope so

woeful thunder May 4, 2024, 1:43 PM

#

carmine otter I hope so

for me it works so it would be strange if it didn't work

carmine otter May 4, 2024, 1:43 PM

#

wich code?

woeful thunder May 4, 2024, 1:43 PM

#

woeful thunder ```js world.beforeEvents.playerBreakBlock.subscribe((ev) => { const player =...

him

woeful thunder May 4, 2024, 1:44 PM

#

carmine otter wich code?

^
|
|

carmine otter May 4, 2024, 1:44 PM

#

carmine otter ```js import { world } from "@minecraft/server"; const customItems = { "tw...

he is testing this code ig

covert ginkgo May 4, 2024, 1:47 PM

#

i need it to work on realms btw

carmine otter May 4, 2024, 1:48 PM

#

should wokr on realm ig

covert ginkgo May 4, 2024, 1:48 PM

#

carmine otter ```js import { world } from "@minecraft/server"; const customItems = { "tw...

il test now

#

i play on xbox so it takes time to test

#

😭

carmine otter May 4, 2024, 1:51 PM

#

ohh okay

covert ginkgo May 4, 2024, 2:05 PM

#

doesnt work

#

@carmine otter

covert ginkgo May 4, 2024, 2:20 PM

#

can anyone help? 😭

carmine otter May 4, 2024, 2:27 PM

#

covert ginkgo <@456226577798135808>

any errors?

#

import { world } from "@minecraft/server"
// just an object
const customItemFunctionNames = {
    "twm:drill": "drill",
    "twm:heavy_drill": "heavy_drill",
    "twm:smelting_pickaxe": "smelting",
    //    
    "twm:stone_hammer": "hammer/twm_break",
    "twm:iron_hammer": "hammer/twm_break",
    "twm:diamond_hammer": "hammer/twm_break",
    "twm:netherite_hammer": "hammer/twm_break",
    //
    "twm:advanced_iron_axe": "advanced_axe",
    "twm:advanced_diamond_axe": "advanced_axe",
    "twm:advanced_netherite_axe": "advanced_axe",
    //
    "twm:advanced_iron_shovel": "advanced_shovel",
    "twm:advanced_diamond_shovel": "advanced_shovel",
    "twm:advanced_netherite_shovel": "advanced_shovel",
    //
    "twm:advanced_iron_pickaxe": "advanced_pickaxe",
    "twm:advanced_diamond_pickaxe": "advanced_pickaxe",
    "twm:advanced_netherite_pickaxe": "advanced_pickaxe"
}
//
world.afterEvents.playerBreakBlock.subscribe((ev) => {
    const player = ev.player
    const item = ev.itemStackBeforeBreak // if you want the orignal item
    const itemTypeId = item?.typeId // i use item.typeId twice so i added a const for this

    // item and itemTypeId will be undefined, if the holding Item was empty
    if (itemTypeId) {
        const block = ev.block
        const { x, y, z } = block.location
        
        if (itemTypeId in customItemFunctionNames) {
            player.runCommandAsync(`execute positioned ${x} ${y} ${z} run function ${customItemFunctionNames[itemTypeId]}`)
        }
    }
})

#

I improved the code a bit

covert ginkgo May 4, 2024, 3:28 PM

#

carmine otter any errors?

No errors

covert ginkgo May 4, 2024, 3:52 PM

#

carmine otter ```js import { world } from "@minecraft/server" // just an object const customIt...

Doesn't work

carmine otter May 4, 2024, 5:07 PM

#

Then i don't know why

#

Try sone Debugging with the console

covert ginkgo May 4, 2024, 5:11 PM

#

carmine otter Try sone Debugging with the console

what console

#cannot read property 'typeId' of undefined