Help Creating a Custom Spear/Trident | Bedrock Add-Ons | Page 1

true anchor Mar 18, 2023, 8:26 PM

#

I'm super new to scripting, and I was following the tutorial on wiki.bedrock.dev for Custom Spear. I was successfully able to replicate it, and it worked perfectly fine on 1.19.63. However, since the update I haven't been able to fix it, and the spear can't be picked up. This is my code, and I'm sure I messed something up.

import { world, ItemStack, ItemTypes } from "@minecraft/server"
import { system } from "@minecraft/server";
system.events.beforeWatchdogTerminate.subscribe(data => {
data.cancel = true;
});

world.events.itemReleaseCharge.subscribe(ev => {
for (const player of world.getPlayers()) {
let inv = player.getComponent('inventory').container
const itemStack = inv.getItem(player.selectedSlot);
if (itemStack?.typeId === 'tlc:iron_spear') {
var container = player.getComponent('inventory').container
var newItem = new ItemStack(ItemTypes?.get("tlc:iron_spear"));
var oldItem = container?.getItem(player.selectedSlot)
player.removeTag("iron_spear")
}
let e = system.runInterval(() => {
if (player.hasTag("iron_spear") && itemStack?.typeId === 'tlc:iron_spear' && itemStack?.getComponent("durability").damage <= 125) {
player.removeTag("iron_spear")
newItem.getComponent("durability").damage = oldItem.getComponent("durability").damage + 1;
container.setItem(player.selectedSlot, newItem);
if (!player.hasTag("iron_spear")) {
system.runTimeout(() =>
}
}
})
}
})

arctic thorn Mar 18, 2023, 8:27 PM

#

Oh, my spears don't work?

true anchor Mar 18, 2023, 8:27 PM

#

not anymore 😦 the tutorial was awesome tho and helped a ton

arctic thorn Mar 18, 2023, 8:27 PM

#

Idk, the script works for me

true anchor Mar 18, 2023, 8:28 PM

#

really?

arctic thorn Mar 18, 2023, 8:28 PM

#

Yea

true anchor Mar 18, 2023, 8:28 PM

#

ill check my manifest quick

#

{
"format_version": 2,
"metadata": {
"authors": [
"Tymeless"
]
},
"header": {
"name": "pack.name",
"description": "pack.description",
"min_engine_version": [
1,
19,
50
],
"uuid": "f76e4753-8d95-4792-bce6-efbb03cdc249",
"version": [
1,
0,
0
]
},
"modules": [
{
"language": "javascript",
"type": "script",
"uuid": "9708f314-6db5-453b-b375-688fb329c920",
"version": [
1,
0,
0
],
"entry": "scripts/main.js"
}
],
"dependencies": [
{
"version": "1.1.0-beta",
"module_name": "@minecraft/server"
},
{
"module_name": "@minecraft/server-ui",
"version": "1.0.0-beta"
},
{
"module_name": "@minecraft/server-gametest",
"version": "1.0.0-beta"
}
]
}

arctic thorn Mar 18, 2023, 8:29 PM

#

true anchor I'm super new to scripting, and I was following the tutorial on wiki.bedrock.dev...

Can you format this?

#

?format

carmine thornBOT Mar 18, 2023, 8:29 PM

#

Formatting JSON, JS

Please format your code as code-blocks! This makes the text monospaced, and has support for syntax highlighting.

The format looks like this:

for JSON
```json
{
"example": 123
}
```

for JavaScript
```js
console.log("hello world", 123)
```

The character used here is the backtick (U+0060 ` GRAVE ACCENT). This symbol is usually at the top left of your keyboard, occupying the tilde key (~). On mobile, it will be on the second or third page of symbols.

arctic thorn Mar 18, 2023, 8:29 PM

#

Wait

#

import { world, ItemStack, ItemTypes } from "@minecraft/server"
import { system } from "@minecraft/server";
system.events.beforeWatchdogTerminate.subscribe(data => {
  data.cancel = true;
});

world.events.itemReleaseCharge.subscribe(ev => {
  for (const player of world.getPlayers()) {
    let inv = player.getComponent('inventory').container
    const itemStack = inv.getItem(player.selectedSlot);
    if (itemStack?.typeId === 'tlc:iron_spear') {
      var container = player.getComponent('inventory').container
      var newItem = new ItemStack(ItemTypes?.get("tlc:iron_spear"));
      var oldItem = container?.getItem(player.selectedSlot)
      player.removeTag("iron_spear")
    }
    let e = system.runInterval(() => {
      if (player.hasTag("iron_spear") && itemStack?.typeId === 'tlc:iron_spear' && itemStack?.getComponent("durability").damage <= 125) {
        player.removeTag("iron_spear")
        newItem.getComponent("durability").damage = oldItem.getComponent("durability").damage + 1;
        container.setItem(player.selectedSlot, newItem);
        if (!player.hasTag("iron_spear")) {
          system.runTimeout(() => 
      }
      }
    })
  }
})```

novel drumBOT Mar 18, 2023, 8:29 PM

#

Debug Result

There are errors in this [code](#1086747536599023746 message):

[36m<repl>.js[0m:[33m24[0m:[33m7[0m - [31merror[0m[30m TS1109: [0mExpression expected.

[7m24[0m       }
[7m  [0m [31m      ~[0m

arctic thorn Mar 18, 2023, 8:30 PM

#

You're missing a bracket

true anchor Mar 18, 2023, 8:30 PM

#

omg yeah sorry i definitely shoulda formatted it

#

oh my word lol

arctic thorn Mar 18, 2023, 8:30 PM

#

At lime 24

true anchor Mar 18, 2023, 8:32 PM

#

so there should be two instead of 1?

arctic thorn Mar 18, 2023, 8:32 PM

#

That's what our bot says

#

Add it at lime 24

true anchor Mar 18, 2023, 8:33 PM

#

ok cool

#

ill run it quick

#

tysm

arctic thorn Mar 18, 2023, 8:33 PM

#

:))

#

I knew my spears didn't break :]

true anchor Mar 18, 2023, 8:34 PM

#

ok so its not that then

#

cuz it still didnt work

arctic thorn Mar 18, 2023, 8:35 PM

#

Send code

#

🥲

true anchor Mar 18, 2023, 8:36 PM

#

import { world, ItemStack, ItemTypes } from "@minecraft/server"
import { system } from "@minecraft/server";
system.events.beforeWatchdogTerminate.subscribe(data => {
  data.cancel = true;
});

world.events.itemReleaseCharge.subscribe(ev => {
  for (const player of world.getPlayers()) {
    let inv = player.getComponent('inventory').container
    const itemStack = inv.getItem(player.selectedSlot);
    if (itemStack?.typeId === 'tlc:iron_spear') {
      var container = player.getComponent('inventory').container
      var newItem = new ItemStack(ItemTypes?.get("tlc:iron_spear"));
      var oldItem = container?.getItem(player.selectedSlot)
      player.removeTag("iron_spear")
    }
    let e = system.runInterval(() => {
      if (player.hasTag("iron_spear") && itemStack?.typeId === 'tlc:iron_spear' && itemStack?.getComponent("durability").damage <= 125) {
        player.removeTag("iron_spear")
        newItem.getComponent("durability").damage = oldItem.getComponent("durability").damage + 1;
        container.setItem(player.selectedSlot, newItem);
        if (!player.hasTag("iron_spear")) {
          system.runTimeout(() => 
      }
      }
    }
    })
  }
})

novel drumBOT Mar 18, 2023, 8:36 PM

#

Debug Result

There are errors in this [code](#1086747536599023746 message):

[36m<repl>.ts[0m:[33m24[0m:[33m7[0m - [31merror[0m[30m TS1109: [0mExpression expected.

[7m24[0m       }
[7m  [0m [31m      ~[0m
[36m<repl>.ts[0m:[33m27[0m:[33m5[0m - [31merror[0m[30m TS1005: [0m',' expected.

[7m27[0m     })
[7m  [0m [31m    ~[0m
[36m<repl>.ts[0m:[33m27[0m:[33m6[0m - [31merror[0m[30m TS1128: [0mDeclaration or statement expected.

[7m27[0m     })
[7m  [0m [31m     ~[0m
[36m<repl>.ts[0m:[33m28[0m:[33m3[0m - [31merror[0m[30m TS1128: [0mDeclaration or statement expected.

[7m28[0m   }
[7m  [0m [31m  ~[0m
[36m<repl>.ts[0m:[33m29[0m:[33m1[0m - [31merror[0m[30m TS1128: [0mDeclaration or statement expected.

[7m29[0m })
[7m  [0m [31m~[0m
[36m<repl>.ts[0m:[33m29[0m:[33m2[0m - [31merror[0m[30m TS1128: [0mDeclaration or statement expected.

[7m29[0m })
[7m  [0m [31m ~[0m

true anchor Mar 18, 2023, 8:36 PM

#

damn

arctic thorn Mar 18, 2023, 8:36 PM

#

Oh my

true anchor Mar 18, 2023, 8:36 PM

#

thats a lotta errors

arctic thorn Mar 18, 2023, 8:36 PM

#

Let me fix that for you :)

true anchor Mar 18, 2023, 8:36 PM

#

hahaha thank you SOOO much

#

i really appreciate it

arctic thorn Mar 18, 2023, 8:43 PM

#

import { world, ItemStack, ItemTypes } from "@minecraft/server"
import { system } from "@minecraft/server";
system.events.beforeWatchdogTerminate.subscribe(data => {
  data.cancel = true;
});

world.events.itemReleaseCharge.subscribe(ev => {
  for (const player of world.getPlayers()) {
    let inv = player.getComponent('inventory').container
    const itemStack = inv.getItem(player.selectedSlot);
    if (itemStack?.typeId === 'tlc:iron_spear') {
      var container = player.getComponent('inventory').container
      var newItem = new ItemStack(ItemTypes?.get("tlc:iron_spear"));
      var oldItem = container?.getItem(player.selectedSlot)
      player.removeTag("iron_spear")
    }
    let e = system.runInterval(() => {
      if (player.hasTag("iron_spear") && itemStack?.typeId === 'tlc:iron_spear' && itemStack?.getComponent("durability").damage <= 125) {
        player.removeTag("iron_spear")
        newItem.getComponent("durability").damage = oldItem.getComponent("durability").damage + 1;
        container.setItem(player.selectedSlot, newItem);
        if (!player.hasTag("iron_spear")) {
          system.clearRun(e)
      }
      }
    })
  }
})```

#

@true anchor

novel drumBOT Mar 18, 2023, 8:44 PM

#

No Errors

No errors in [code](#1086747536599023746 message)

true anchor Mar 18, 2023, 8:44 PM

#

now for the big test!

#

YESSSS

#

IT WORKS

#

you are an absolutel legend @arctic thorn

#

thank you so much

arctic thorn Mar 18, 2023, 8:47 PM

#

ayy :p

true anchor Mar 18, 2023, 8:47 PM

#

if i make more than one spear do i just copy the lower part of the module and replace iron_spear with diamond_spear or whatever?

arctic thorn Mar 18, 2023, 8:48 PM

#

Yes, as the wiki suggests

true anchor Mar 18, 2023, 8:48 PM

#

ok cool

#

thank you again

#

you have an amazing day!

arctic thorn Mar 18, 2023, 8:49 PM

#

U too :)

#Help Creating a Custom Spear/Trident