Everything broke in .60. | Bedrock Add-Ons | Page 1

scenic veldt Feb 15, 2023, 2:44 AM

#

import { world, system } from '@minecraft/server'

//Sets the inCombat score to 30s:
world.events.entityHurt.subscribe((combatLog) => {
  const hit = combatLog.hurtEntity
  const attacker = combatLog.damageSource.damagingEntity
  if (hit.typeId !== "minecraft:player" || attacker?.typeId !== "minecraft:player") return;
  
  //Telling the player if they are inCombat:
    if (getScore(attacker, 'inCombat') == 0) {
  attacker.tell("§l§cYou are now in §o§4Combat!")
  }
    if (getScore(hit, 'inCombat') == 0) {
hit.tell("§l§cYou are now in §o§4Combat!")
}
console.warn('Hit detected')
  hit.runCommandAsync('scoreboard players set @s inCombat 600')
  attacker.runCommandAsync('scoreboard players set @s inCombat 600')

//Kill system:
  const health = hit.getComponent("minecraft:health").current
  if (hit.typeId !== "minecraft:player" || attacker?.typeId !== "minecraft:player") return;
  if (health <= 0) {
    attacker.runCommandAsync('scoreboard players add @s kills 1')
    attacker.runCommandAsync('effect @s instant_health 255 1 true')
  }
})

//Getting the player inCombat score:
function getScore(player, inCombat) {
  return world.scoreboard.getObjective(inCombat).getScore(player.scoreboard)
}

//Testing if the player has properly loaded in:
world.events.playerSpawn.subscribe((join) => {
        if (!join.initialSpawn) return;
  let player = join.player
  if (getScore(player, 'inCombat') !== 0) {
    world.say(`§l§4${player.name} §chas been killed for Combat Logging!`)
    player.runCommandAsync("scoreboard players set @s inCombat 0")
    player.runCommandAsync("kill @s")
  }
}) 

world.events.entityHurt.subscribe((ev) => {
  const hit = ev.hurtEntity
  const attacker = ev.damageSource.damagingEntity
console.warn('Test')
})

#

Hello! So, ever since the 1.19.60 update, all my scripts have completely stopped working. I have no idea why, as nothing is appearing in the content log, and the code looks correct. I've put it through multiple debuggers and they have said nothing is wrong with the code.

#

📎 index.js

#

📎 killcount.js

#

📎 manifest.json

#

Heres all my files. I don't see anything wrong with any of these files, any help is appreciated as nothing is showing up in the logs

#

Even the bottom console warn isn't logging

#

When I hit my other account, nothing happens

#

And in the logs no errors are related to scripts

crimson birchBOT Feb 15, 2023, 1:53 PM

#

Debug Result

There are errors in this [code](#1075246113294123048 message):

[36mindex.js[0m:[33m1[0m:[33m26[0m - [31merror[0m[30m TS2307: [0mCannot find module './db/Database.js' or its corresponding type declarations.

[7m1[0m import { Database } from './db/Database.js';
[7m [0m [31m                         ~~~~~~~~~~~~~~~~~~[0m

#

Debug Result

There are errors in this [code](#1075246113294123048 message):

[36mkillcount.js[0m:[33m12[0m:[33m12[0m - [31merror[0m[30m TS2339: [0mProperty 'tell' does not exist on type 'Entity'.

[7m12[0m   attacker.tell("§l§cYou are now in §o§4Combat!")
[7m  [0m [31m           ~~~~[0m
[36mkillcount.js[0m:[33m15[0m:[33m5[0m - [31merror[0m[30m TS2339: [0mProperty 'tell' does not exist on type 'Entity'.

[7m15[0m hit.tell("§l§cYou are now in §o§4Combat!")
[7m  [0m [31m    ~~~~[0m

scenic veldt Feb 15, 2023, 2:13 PM

#

I'm confused?

#

How does .tell now exist?

delicate radish Feb 15, 2023, 2:43 PM

#

Its .sendMessage now

#

Check #1067535712372654091

scenic veldt Feb 15, 2023, 3:54 PM

#

No way

scenic veldt Feb 15, 2023, 4:05 PM

#

delicate radish Its .sendMessage now

import { world, system } from '@minecraft/server'

//Sets the inCombat score to 30s:
world.events.entityHurt.subscribe((combatLog) => {
	console.warn('T')
  const hit = combatLog.hurtEntity
  const attacker = combatLog.damageSource.damagingEntity
  
  if (hit.typeId !== "minecraft:player" || attacker?.typeId !== "minecraft:player") return;
  
  //Telling the player if they are inCombat:
    if (getScore(attacker, 'inCombat') == 0) {
    attacker.sendMessage("§l§cYou are now in §o§4Combat!")
  }
    if (getScore(hit, 'inCombat') == 0) {
    hit.sendMessage("§l§cYou are now in §o§4Combat!")
}
console.warn('Hit detected')
  hit.runCommandAsync('scoreboard players set @s inCombat 600')
  attacker.runCommandAsync('scoreboard players set @s inCombat 600')

//Kill system:
  const health = hit.getComponent("minecraft:health").current
  if (hit.typeId !== "minecraft:player" || attacker?.typeId !== "minecraft:player") return;
  if (health <= 0) {
    attacker.runCommandAsync('scoreboard players add @s kills 1')
    attacker.runCommandAsync('effect @s instant_health 255 1 true')
  }
})

//Getting the player inCombat score:
function getScore(player, inCombat) {
  return world.scoreboard.getObjective(inCombat).getScore(player.scoreboard)
}

//Testing if the player has properly loaded in:
world.events.playerSpawn.subscribe((join) => {
	    if (!join.initialSpawn) return;
  let player = join.player
  if (getScore(player, 'inCombat') !== 0) {
    world.say(`§l§4${player.name} §chas been killed for Combat Logging!`)
    player.runCommandAsync("scoreboard players set @s inCombat 0")
    player.runCommandAsync("kill @s")
  }
}) 

world.events.entityHurt.subscribe((ev) => {
  const hit = ev.hurtEntity
  const attacker = ev.damageSource.damagingEntity
console.warn('Test')
})

#

Done, still not working

#

No errors again

#

@delicate radish

delicate radish Feb 15, 2023, 6:49 PM

#

There’s probably a lot more to fix

scenic veldt Feb 15, 2023, 10:54 PM

#

Do you know what errors?

#

I don't see any

crimson birchBOT Feb 16, 2023, 12:46 AM

#

Debug Result

There are errors in this [code](#1075246113294123048 message):

[36m<repl>.js[0m:[33m13[0m:[33m14[0m - [31merror[0m[30m TS2339: [0mProperty 'sendMessage' does not exist on type 'Entity'.

[7m13[0m     attacker.sendMessage("§l§cYou are now in §o§4Combat!")
[7m  [0m [31m             ~~~~~~~~~~~[0m
[36m<repl>.js[0m:[33m16[0m:[33m9[0m - [31merror[0m[30m TS2339: [0mProperty 'sendMessage' does not exist on type 'Entity'.

[7m16[0m     hit.sendMessage("§l§cYou are now in §o§4Combat!")
[7m  [0m [31m        ~~~~~~~~~~~[0m

wraith spindle Feb 16, 2023, 1:02 AM

#

@scenic veldt .sendMessage() isn't in 1.19.60. It is still .tell(). That's a change they made in the preview version for 1.19.70. You can see the other changes in that version here: #1074038906430955620 message

scenic veldt Feb 16, 2023, 1:04 AM

#

Doing .tell still don't do shit

#

I've been gettin no errors in the content log despite havin it on

#

Ion what's happening :(

wraith spindle Feb 16, 2023, 1:04 AM

#

scenic veldt Doing .tell still don't do shit

The files you shared in your post above is the source? Or just specific files in general?

scenic veldt Feb 16, 2023, 1:04 AM

#

The ones above

#

None of them are working

#

Ever since 1.19.60

#

I've got no errors in the content log

#

So idk whats going on as nothing has changed

wraith spindle Feb 16, 2023, 1:06 AM

#

I'll load them up and see if I notice anything. I'm not doing anything at this moment.

scenic veldt Feb 16, 2023, 1:06 AM

#

Alright thank you

wraith spindle Feb 16, 2023, 1:24 AM

#

scenic veldt Alright thank you

With your script above that is named killcount.js it appears that there is no method for .tell() when using the entityHurt event. So you may need to change those methods to .runCommandAsync() and use tellraw to send the message to that designated player.

#

Ok, so it seems the method .tell() falls under the Player Class and does not exist under the Entity Class according to what I am seeing on VSC and their documentation which frankly I find to be very odd.

#

Player Class with Methods

https://learn.microsoft.com/en-us/minecraft/creator/scriptapi/minecraft/server/player#methods

Entity Class with Methods

https://learn.microsoft.com/en-us/minecraft/creator/scriptapi/minecraft/server/entity#methods

minecraft/server.Player Class

Contents of the @minecraft/server.Player class.

minecraft/server.Entity Class

Contents of the @minecraft/server.Entity class.

scenic veldt Feb 16, 2023, 6:03 PM

#

Nope

#

Lmfao

#

I got my mate to try it and it works fine for him

#

So idk wtf is wrong with my goofy phone

wraith spindle Feb 16, 2023, 8:23 PM

#

scenic veldt I got my mate to try it and it works fine for him

entityHurt gets the entity object from the Entity Class. According to their documentation as well as what I saw in the code when loaded up in visual studio code it shouldn't work. Based solely upon what you shared above and assuming there is no extra that could potentially have a role or change of effect. So I'm uncertain about your situation at the moment.

scenic veldt Feb 16, 2023, 9:00 PM

#

Hold up

#

I'll send a clip

#

Of it working for him

#

The script worked pre 1.19.60, and is now suddenly broken

#

I've tried literally everything

#

And it just won't work for me

scenic veldt Feb 16, 2023, 10:38 PM

#

Turns out it had something to do with the fucking manifest lmfaoooo

#

Like a week

#

Of trying to find this stupid error and it was because of my manifest 🗿🗿🗿

wraith spindle Feb 17, 2023, 4:04 AM

#

scenic veldt Of trying to find this stupid error and it was because of my manifest 🗿🗿🗿

Hmm, and what issue did you have with the manifest?

scenic veldt Feb 17, 2023, 4:05 AM

#

Absolutely no clue

wraith spindle Feb 17, 2023, 4:05 AM

#

.... Yea, sounds fake lmao.

scenic veldt Feb 17, 2023, 4:05 AM

#

Wdym?

#

📎 manifest.js

ornate steepleBOT Feb 17, 2023, 4:06 AM

#

scenic veldt

Program Output

/home/jail/prog.js:2
"format_version": 2,
                ^

SyntaxError: Unexpected token ':'
    at Object.compileFunction (node:vm:352:18)
    at wrapSafe (node:internal/modules/cjs/loader:1032:15)
    at Module._compile (node:internal/modules/cjs

scenic veldt Feb 17, 2023, 4:06 AM

#

Old manifest

#

And

#

One sec

#

📎 manifest3.json

#

New manifest

#

You can literally try the script yourself it works lmfao

#

Tryna say I'm faking what? Fixing my issue? 🤡

wraith spindle Feb 17, 2023, 4:09 AM

#

scenic veldt You can literally try the script yourself it works lmfao

I'm not convinced with entityHurt. That is all.

scenic veldt Feb 17, 2023, 4:09 AM

#

You don't think the script works?

wraith spindle Feb 17, 2023, 4:11 AM

#

I loaded the script you shared from above into vsc, converted it to TypeScript to get realtime feedback, and quickly identified that the method didn't exist because the event being utilized was targeting the entity object versus a player object and therefore didn't exist.

#

Just giving insight on how I approached my conclusion.

scenic veldt Feb 17, 2023, 4:11 AM

#

I said earlier the script worked pre .60, so it makes sense on why I had to update my manifest. My mate sent me his pack that had the working script, and I used his manifest as he uses bridge which I'm assuming updates the manifest for you

#

Bro...

#

Typescript is going to give you an error if you use player in entity class

#

It'll still work regardless

wraith spindle Feb 17, 2023, 4:12 AM

#

scenic veldt Typescript is going to give you an error if you use player in entity class

I never said I used player. I was speaking about the two different objects and how one supports a method and the other does not.

scenic veldt Feb 17, 2023, 4:13 AM

#

Well... Have you tried testing the script?

wraith spindle Feb 17, 2023, 4:14 AM

#

Didn't bother with it since I had multiple circumstances showing pretty reasonable evidence that the code was not complete.

#

If it's working for you then great. Not gonna say it isn't. I just know what I was looking at based on the script you shared above in this forum.

#Everything broke in .60.