How to map from JSON. Getting a JSON.parse Error | TypeScript Community | Page 1

thorny beacon Feb 9, 2023, 3:17 PM

#

The error:
SyntaxError: Unexpected token o in JSON at position 1at JSON.parse (<anonymous>)

Code

export const createReview = functions.region("europe-west2")
    .firestore.document("timesheets/{timesheetId}")
    .onUpdate(async (change) => {
      const timesheet = change.after.data();
      if (timesheet) {
        let parsedDaysWorked: { [key: string]: { time: number;
          miles: number; expenses: number; } } = {};

        parsedDaysWorked = JSON.parse(timesheet.days_worked);
      }
    });

The picture show the firestore doc

wanton wadi Feb 9, 2023, 3:20 PM

#

try logging timesheet.days_worked to see what it is to maybe see what you messed up

thorny beacon Feb 9, 2023, 3:37 PM

#

This is what i get from logs

timesheet.days_worked: [object Object]

Code:
``` console.log(timesheet.days_worked: ${timesheet.days_worked});

hushed mortar Feb 9, 2023, 3:38 PM

#

log it without stringifying

thorny beacon Feb 9, 2023, 3:39 PM

#

how do i that?

#

The code:

export const createReview = functions.region("europe-west2")
    .firestore.document("timesheets/{timesheetId}")
    .onUpdate(async (change) => {
      const timesheet = change.after.data();
      if (timesheet) {
        console.log(`timesheet.days_worked: ${timesheet.days_worked}`);
      }
    });

wanton wadi Feb 9, 2023, 3:41 PM

#

don't put it in a string

thorny beacon Feb 9, 2023, 3:41 PM

#

yh k

wanton wadi Feb 9, 2023, 3:41 PM

#

- console.log(`text ${obj}`);
+ console.log("text", obj);

thorny beacon Feb 9, 2023, 3:41 PM

#

i was just being dumb ty

wanton wadi Feb 9, 2023, 3:42 PM

#

anyways from that log

#

it's not a string, don't parse it

#

it's already a parsed object

thorny beacon Feb 9, 2023, 3:53 PM

#

Only a sample of the logs as the whole things is too long its printing out the value of daysWorked

 daysWorked {
 '1': [
 {
client_doc_id: null,
client_name: 'Crocky Trail',
...
 miles: 5,
 project_doc_id: 'xDqvg58K6qxu4M5q7mvZ',
 project_id: 7211
 },
 {
client_doc_id: null,
 client_name: null,
...
 project_doc_id: 'MbgcJ6bz4LJTdcowyGC1',
project_id: 5537
 }
],
'2': [

wanton wadi Feb 9, 2023, 3:53 PM

#

doesn't change my answer

#

just the [object Object] solidifies it tbh

#

which ig could have been guessed from the token 'o' at position 1 but didn't want to guess that at first

thorny beacon Feb 9, 2023, 3:55 PM

#

so if its a prsed obj do i use something like timesheet.days_worked.get("1")?

wanton wadi Feb 9, 2023, 3:55 PM

#

no, just days_worked[1] just like any other js object

#

why is days_worked an object instead of an array though

thorny beacon Feb 9, 2023, 4:02 PM

#

becuase im guessing i have it as a map in firestore where i store the docments: {"1":day, "5" }. The reason for making it map was becuase i dont know the order in which the user will add the objects. So i made it map. For example the user can plan for tuesdsay ("2") and friday ("5") on a monday. And then tuesday they might end up remembering they forgot to add in for monday. I figured a map would be the easiest given the insane scenario

wanton wadi Feb 9, 2023, 4:11 PM

#

no that's just an object

#

but ok. why not just use weekday names then

thorny beacon Feb 9, 2023, 4:15 PM

#

only becuase numbers numbers shorter, which ik isnt gd but trying to keep everything in same doc if i do get tight for space might have end up changing the strucutre

blazing jay Feb 9, 2023, 4:16 PM

#

Make sure you try/catch the json.parse, it will throw if it cant parse

wanton wadi Feb 9, 2023, 4:18 PM

#

thorny beacon only becuase numbers numbers shorter, which ik isnt gd but trying to keep every...

you're changing at the most wednesday from 18 bytes to 8 bytes, that isn't really that significant

#

readability is king

wanton wadi Feb 9, 2023, 4:18 PM

#

blazing jay Make sure you try/catch the json.parse, it will throw if it cant parse

not the issue here

#

either it will always parse or it will never parse, with this kind of thing

#How to map from JSON. Getting a JSON.parse Error