BTA Achievements Screen Port for 1.20.1

[kindred pumice]

Not sure how well it'd work (especially with modded advancements) but might as well toss my shot

[wicked spruce]

Porting the achievements screen in general doesn't work well because advancements are data driven. The reason the advancements screen always goes to the right is that it's easier and more predictable to lay out. In order to achieve the spread out look, you'd probably have to use some force-based graph layout algorithm, and those aren't know for being super predictable when changes are made

[abstract badge]

unless you add special parameters to either force an offset from parent advancement or fixed position for advancements, which might require breaking changes to the advancement schema i don't think that's possible to do it 1:1, other than maybe to port the general ux

[kindred pumice]

I don't think it needs to be a general 1:1 port of the menu but something close to it would be preferable.

The closest I could really find to what I'm looking for was this mod for 1.21.1, but it's wonky at best with how spread out everything is.

[rancid mica]

ooo this could be realy cool actually

[sharp lion]

something like https://modrinth.com/mod/advancementinfo ?
I forget how customizable it is in terms of making the resources look closer

[mighty chasm]

Check your dm i can help with this

[abstract badge]

is this a commission scam?

ok yea, this might actually be

zero messages before this one

[kindred pumice]

Considering I haven’t seen them since they tried to DM me, yeah, most likely.

[kindred pumice]

Bump

[spring solstice]

I could try to do it, this doesn't seem too hard to do

[regal junco]

This is sick, if the data driven is a big problem why not just add 2 lines? horizontal distance away, vertical distant away. And by default it results back to "vanilla " behavior

And also one for what achievement it's connected to, but that already kinda exists

[abstract badge]

kid named modifying codecs:

[regal junco]

And the bg could work as a scammatic

Where you can build it in a creative world and then save each layer as a structure (and name them what ever category you want it for then front and back), then put a "background" folder within the achievements folder

And some alternative methods like: Pearlin noise for like the nether background

Just an idea to make it as easy as possible for the user

[spring solstice]

I created the base mod with the new advancement screen & tried to use force-based graph layout algorithm for the advancement tree layout. This is what I got so far
https://github.com/ImBonana/AdvancementScreenPlus

[kindred pumice]

For something that hasn't had much development time? I'd say this is already pretty good progress!

[regal junco]

trying to run this to check it out myself, but i'm not sure what I did wrong

using vscode

[spring solstice]

I created GHA, you can download from there
https://github.com/ImBonana/AdvancementScreenPlus/actions/runs/25649298857

[regal junco]

thank you

[spring solstice]

np

[regal junco]

omg can minecraft just work please 😭

finaly

it doesn't seem to be playing nice with Better Advancements

at any gui scale other then 3 you can't scroll up in husbandry

one thing I will say, it also likes doing this

going in straight lines

also making lines go way further then they need to be

but that's not too hard to edit I would think

but yeah, this is fucking great

looks alot better then what we have now

it only going right is so boring

OK NVM

[regal junco]

game just hard crashed when I clicked advancement without Better Advancements

[spring solstice]

I will look at it when I am at home. But I changed how the lines render, and it doesn't seem to work for you, weird

[regal junco]

ah alright

[regal junco]

this fixed itself

[spring solstice]

I fixed most of the things
https://github.com/ImBonana/AdvancementScreenPlus/actions/runs/25669527661

[regal junco]

alright checking it out

yeah this is sick

one thing is that these two turns are always broken

the other two look fine

[regal junco]

seems to work, I'm going to turn Better Advancements to see if it still hard crashes on my end

Oh yeah no that seems to work

[spring solstice]

oh, how did I missed that

[regal junco]

it's only 3 pixels, so it's not that hard to miss

also question:

are you going to readd the arrows?

atleast as an option

[spring solstice]

Let me add them now, It's actually looks cool

[regal junco]

screenshot taken from 1.10.2, the last version with Achievements

[kindred pumice]

Huh, didn’t even know arrows existed for Achievements.

Preferably would like it as a config option, though, considering Better than Adventure didn’t have them.

[regal junco]

I agree

trying to figure out when it was added

because it isn't mentioned on the wiki

it was added in 1.7

13w36a

the Achievements system was rewriten in that snapshot

so, the green line and next achievement blink.
and after... the light rotates around the block item, but it seems random

[torpid bison]

check the code?

[regal junco]

Wish I knew how

This is an obfuscated version

Like most older version

[kindred pumice]

Yeah, the achievements and the green line flash.

I was thinking something was off with the line, guess that was it.

[spring solstice]

I added the arrows and added config with yacl & modmenu
https://github.com/ImBonana/AdvancementScreenPlus/actions/runs/25702425707/

[hard panther]

Let her cool

Cook

[torpid bison]

mappings still exist.........

[kindred pumice]

How hard would it be to add the little blue ‘Taken!’ text to Advancements that were completed?

[spring solstice]

I will do it tomorrow

[spring solstice]

I added it

https://github.com/ImBonana/AdvancementScreenPlus/actions/runs/25985580165

[kindred pumice]

The 'Taken!' text seems to just be generally added to all Advancements, not just the ones that got completed

Also, the green line doesn't always seem to make it to the completed advancement? you can tell by the arrow still being turned green

[spring solstice]

This doesn't seem hard to fix, I will fix it when I am home

[spring solstice]

@kindred pumice Fixed
https://github.com/ImBonana/AdvancementScreenPlus/actions/runs/26055824020

[kindred pumice]

From what I've messed with for the past couple of days, seems to work just fine

Would it be possible to add the flashing line and achievements? as shown in the gif I replied to?

[spring solstice]

I will do it tomorrow

Or overmorrow

[spring solstice]

Sorry for the long wait, I added the flashing lines and achievements
https://github.com/ImBonana/AdvancementScreenPlus/actions/runs/26535989231