sullys mod for fabric!

[lost burrow]

https://www.curseforge.com/minecraft/mc-mods/sullys-mod
sullys mod is a 1.20.1 forge mod, and i would love for somebody to port it to fabric :D

[lapis matrix]

That mod looks really cool.

[lost burrow]

agreed!!! so many features and mobs :D

[lost burrow]

bump

ik its probably an unrealistic ask as the mod is HUGE but i think its doable :D

[lapis matrix]

Unfortunately I’m busy with my own project, otherwise I’d definitely work on this.

Have you opened an issue/request on GitHub to ask if a port could be made?

[lost burrow]

i asked in the discord server, they said there wasn't a known fabric port for it, and it is not planned unfortunately

[lapis matrix]

That’s a shame.

[light sphinx]

I am considering doing this, but I will d it slowly, will update here about my progress if I do end up doing this.

[regal escarp]

as a point of curiosity, I decided to walk through this and port to neo + fabric via arch + arch api. I have never used the mod so when i finish all the code stuffs, someone else will have to test it.

It will take time. Don't let this discourage anyone else from trying either. its a large mod but it does do quite a lot of (lexforge) datagen and such.

[lost burrow]

typing to remove the inactivity thing

[lost burrow]

typing to remove the inactivity thing

[regal escarp]

ngl, this mod has a LOT of copypasting vanilla code -_-

(well, lexforge patched vanilla code)

[lost burrow]

hey

any progress at all?

[regal escarp]

yes

[regal escarp]

I didnt realize how expansive the code in this mod is...it touches so. many. things.

making slow progress still

[lost burrow]

thank you so much for your commitment

:DDD

[lost burrow]

update ?

[regal escarp]

i dunno, maybe?

not much today, mostly just real world work and being OFO 😛

[lost burrow]

👍

[regal escarp]

well, its at the point where it can actually launch (in fabric at least, havent tested neo but most of the code is common side between the 2)

still have datagen to work through and some bits of code i commented out (and the more complex pieces like the workstations on tortoises that i nearly completely reworked)

[lost burrow]

thank you :D

[lost burrow]

what features aren't ready yet?

[regal escarp]

no idea. i've never played with the mod. the effort so far has just been converting code from one version and methodology to another

[regal escarp]

411 files datagenned (not including structures). still need to datagen the cauldron block but i had to revert efforts on the fluid so thats on the backlog at the moment.

all the other blocks appear to be showing up correctly (still need to check the skulls), and it no longer crashes in the debug world XD

[lost burrow]

yay!!

[storm barn]

I think you need the permission from the original author first tho

[regal escarp]

nope

the license the mod is released under allows combined works with notice and licensing requirements met

[indigo vault]

The mod is under LGPL, so as long as your derivative work is also under LGPL (and publish the source code) you can do the port

[regal escarp]

That being said, there is no plans to publish the mod to curseforge nor modrinth unless the original dev approves

[indigo vault]

why is that may I ask?

I mean ofc asking the dev first is always a very good and polite practice ofc, but wanted to know your thought process behind not publishing it yk

[regal escarp]

mostly, its rude and the dev put all the effort into making something with their design and goals. taking that and publishing it for other platforms if they specifically dont want that done drives devs away from open licensing and development work

[indigo vault]

as per license they are already allowing that and you are not competing against the original

[indigo vault]

fair

[lost burrow]

could i ask the dev for you?

[regal escarp]

you can. as i mentioned previously, my efforts should not prevent anyone else who wants to take this up, and my efforts are slightly wider than the request (as i am working to make it multiloader supported and am having to rework several things to make that happen)

[lost burrow]

@regal escarp

[high terrace]

Could make a prr hmmm 🤔

[lost burrow]

what's a PRR?

[regal escarp]

my port is not suitable for PRing back into the main mod since the main mod is developed for lexforge which is mostly unsupported these days

[lost burrow]

whats lexforge?!!

[regal escarp]

the version of forge that lexmanos supports

all the main devs of forge left Lex and started neoforge

it is widly believed that the main issue with forge and its dev community is Lex, and the shift to Neoforge has been mostly seen as a good move

[indigo vault]

LexForge is how "Old Forge" is called in order to distinguish it from Neoforged

[lost burrow]

i see

[indigo vault]

on 1.21 everyone moved to neoforged, and since Sullys Mod is for 1.20.1 its still in LexForge

[austere tiger]

if they're considering moving to multiloader anyway, a PR might still be fine

[regal escarp]

the mod is still under development and considering moving is not the same as working through developmental changes required to do so